doc: add Meson coding style to contributors guide
[dpdk.git] / lib / librte_lpm / rte_lpm.c
index 10705fc..002811f 100644 (file)
@@ -1,35 +1,6 @@
-/*-
- *   BSD LICENSE
- * 
- *   Copyright(c) 2010-2012 Intel Corporation. All rights reserved.
- *   All rights reserved.
- * 
- *   Redistribution and use in source and binary forms, with or without 
- *   modification, are permitted provided that the following conditions 
- *   are met:
- * 
- *     * Redistributions of source code must retain the above copyright 
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright 
- *       notice, this list of conditions and the following disclaimer in 
- *       the documentation and/or other materials provided with the 
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its 
- *       contributors may be used to endorse or promote products derived 
- *       from this software without specific prior written permission.
- * 
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- * 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2014 Intel Corporation
+ * Copyright(c) 2020 Arm Limited
  */
 
 #include <string.h>
 #include <errno.h>
 #include <stdarg.h>
 #include <stdio.h>
-#include <errno.h>
 #include <sys/queue.h>
 
 #include <rte_log.h>
 #include <rte_branch_prediction.h>
 #include <rte_common.h>
-#include <rte_memory.h>        /* for definition of CACHE_LINE_SIZE */
+#include <rte_memory.h>        /* for definition of RTE_CACHE_LINE_SIZE */
 #include <rte_malloc.h>
-#include <rte_memzone.h>
-#include <rte_tailq.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_per_lcore.h>
 #include <rte_errno.h>
 #include <rte_rwlock.h>
 #include <rte_spinlock.h>
+#include <rte_tailq.h>
 
 #include "rte_lpm.h"
 
-TAILQ_HEAD(rte_lpm_list, rte_lpm);
+TAILQ_HEAD(rte_lpm_list, rte_tailq_entry);
+
+static struct rte_tailq_elem rte_lpm_tailq = {
+       .name = "RTE_LPM",
+};
+EAL_REGISTER_TAILQ(rte_lpm_tailq)
+
 #define MAX_DEPTH_TBL24 24
 
 enum valid_flag {
@@ -66,6 +40,37 @@ enum valid_flag {
        VALID
 };
 
+/** @internal Rule structure. */
+struct rte_lpm_rule {
+       uint32_t ip; /**< Rule IP address. */
+       uint32_t next_hop; /**< Rule next hop. */
+};
+
+/** @internal Contains metadata about the rules table. */
+struct rte_lpm_rule_info {
+       uint32_t used_rules; /**< Used rules so far. */
+       uint32_t first_rule; /**< Indexes the first rule of a given depth. */
+};
+
+/** @internal LPM structure. */
+struct __rte_lpm {
+       /* Exposed LPM data. */
+       struct rte_lpm lpm;
+
+       /* LPM metadata. */
+       char name[RTE_LPM_NAMESIZE];        /**< Name of the lpm. */
+       uint32_t max_rules; /**< Max. balanced rules per lpm. */
+       uint32_t number_tbl8s; /**< Number of tbl8s. */
+       /**< Rule info table. */
+       struct rte_lpm_rule_info rule_info[RTE_LPM_MAX_DEPTH];
+       struct rte_lpm_rule *rules_tbl; /**< LPM rules. */
+
+       /* RCU config. */
+       struct rte_rcu_qsbr *v;         /* RCU QSBR variable. */
+       enum rte_lpm_qsbr_mode rcu_mode;/* Blocking, defer queue. */
+       struct rte_rcu_qsbr_dq *dq;     /* RCU QSBR defer queue. */
+};
+
 /* Macro to enable/disable run-time checks. */
 #if defined(RTE_LIBRTE_LPM_DEBUG)
 #include <rte_debug.h>
@@ -98,7 +103,7 @@ depth_to_mask(uint8_t depth)
 /*
  * Converts given depth value to its corresponding range value.
  */
-static inline uint32_t __attribute__((pure))
+static uint32_t __attribute__((pure))
 depth_to_range(uint8_t depth)
 {
        VERIFY_DEPTH(depth);
@@ -110,7 +115,7 @@ depth_to_range(uint8_t depth)
                return 1 << (MAX_DEPTH_TBL24 - depth);
 
        /* Else if depth is greater than 24 */
-       return (1 << (RTE_LPM_MAX_DEPTH - depth));
+       return 1 << (RTE_LPM_MAX_DEPTH - depth);
 }
 
 /*
@@ -119,96 +124,130 @@ depth_to_range(uint8_t depth)
 struct rte_lpm *
 rte_lpm_find_existing(const char *name)
 {
-       struct rte_lpm *l;
+       struct __rte_lpm *i_lpm = NULL;
+       struct rte_tailq_entry *te;
        struct rte_lpm_list *lpm_list;
 
-       /* check that we have an initialised tail queue */
-       if ((lpm_list = RTE_TAILQ_LOOKUP_BY_IDX(RTE_TAILQ_LPM, rte_lpm_list)) == NULL) {
-               rte_errno = E_RTE_NO_TAILQ;
-               return NULL;
-       }
+       lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
 
-       rte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);
-       TAILQ_FOREACH(l, lpm_list, next) {
-               if (strncmp(name, l->name, RTE_LPM_NAMESIZE) == 0)
+       rte_mcfg_tailq_read_lock();
+       TAILQ_FOREACH(te, lpm_list, next) {
+               i_lpm = te->data;
+               if (strncmp(name, i_lpm->name, RTE_LPM_NAMESIZE) == 0)
                        break;
        }
-       rte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);
+       rte_mcfg_tailq_read_unlock();
 
-       if (l == NULL)
+       if (te == NULL) {
                rte_errno = ENOENT;
+               return NULL;
+       }
 
-       return l;
+       return &i_lpm->lpm;
 }
 
 /*
  * Allocates memory for LPM object
  */
 struct rte_lpm *
-rte_lpm_create(const char *name, int socket_id, int max_rules,
-               __rte_unused int flags)
+rte_lpm_create(const char *name, int socket_id,
+               const struct rte_lpm_config *config)
 {
        char mem_name[RTE_LPM_NAMESIZE];
+       struct __rte_lpm *i_lpm;
        struct rte_lpm *lpm = NULL;
-       uint32_t mem_size;
+       struct rte_tailq_entry *te;
+       uint32_t mem_size, rules_size, tbl8s_size;
        struct rte_lpm_list *lpm_list;
 
-       /* check that we have an initialised tail queue */
-       if ((lpm_list = 
-            RTE_TAILQ_LOOKUP_BY_IDX(RTE_TAILQ_LPM, rte_lpm_list)) == NULL) {
-               rte_errno = E_RTE_NO_TAILQ;
-               return NULL;    
-       }
+       lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
 
-       RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl24_entry) != 2);
-       RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl8_entry) != 2);
+       RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl_entry) != 4);
 
        /* Check user arguments. */
-       if ((name == NULL) || (socket_id < -1) || (max_rules == 0)){
+       if ((name == NULL) || (socket_id < -1) || (config->max_rules == 0)
+                       || config->number_tbl8s > RTE_LPM_MAX_TBL8_NUM_GROUPS) {
                rte_errno = EINVAL;
                return NULL;
        }
 
-       rte_snprintf(mem_name, sizeof(mem_name), "LPM_%s", name);
-
-       /*
-        * Pad out max_rules so that each depth is given the same number of
-        * rules.
-        */
-       if (max_rules % RTE_LPM_MAX_DEPTH) {
-               max_rules += RTE_LPM_MAX_DEPTH -
-                               (max_rules % RTE_LPM_MAX_DEPTH);
-       }
-
-       /* Determine the amount of memory to allocate. */
-       mem_size = sizeof(*lpm) + (sizeof(lpm->rules_tbl[0]) * max_rules);
+       snprintf(mem_name, sizeof(mem_name), "LPM_%s", name);
 
-       rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
+       rte_mcfg_tailq_write_lock();
 
        /* guarantee there's no existing */
-       TAILQ_FOREACH(lpm, lpm_list, next) {
-               if (strncmp(name, lpm->name, RTE_LPM_NAMESIZE) == 0)
+       TAILQ_FOREACH(te, lpm_list, next) {
+               i_lpm = te->data;
+               if (strncmp(name, i_lpm->name, RTE_LPM_NAMESIZE) == 0)
                        break;
        }
-       if (lpm != NULL)
+
+       if (te != NULL) {
+               rte_errno = EEXIST;
                goto exit;
+       }
+
+       /* Determine the amount of memory to allocate. */
+       mem_size = sizeof(*i_lpm);
+       rules_size = sizeof(struct rte_lpm_rule) * config->max_rules;
+       tbl8s_size = sizeof(struct rte_lpm_tbl_entry) *
+                       RTE_LPM_TBL8_GROUP_NUM_ENTRIES * config->number_tbl8s;
+
+       /* allocate tailq entry */
+       te = rte_zmalloc("LPM_TAILQ_ENTRY", sizeof(*te), 0);
+       if (te == NULL) {
+               RTE_LOG(ERR, LPM, "Failed to allocate tailq entry\n");
+               rte_errno = ENOMEM;
+               goto exit;
+       }
 
        /* Allocate memory to store the LPM data structures. */
-       lpm = (struct rte_lpm *)rte_zmalloc_socket(mem_name, mem_size,
-                       CACHE_LINE_SIZE, socket_id);
-       if (lpm == NULL) {
+       i_lpm = rte_zmalloc_socket(mem_name, mem_size,
+                       RTE_CACHE_LINE_SIZE, socket_id);
+       if (i_lpm == NULL) {
                RTE_LOG(ERR, LPM, "LPM memory allocation failed\n");
+               rte_free(te);
+               rte_errno = ENOMEM;
+               goto exit;
+       }
+
+       i_lpm->rules_tbl = rte_zmalloc_socket(NULL,
+                       (size_t)rules_size, RTE_CACHE_LINE_SIZE, socket_id);
+
+       if (i_lpm->rules_tbl == NULL) {
+               RTE_LOG(ERR, LPM, "LPM rules_tbl memory allocation failed\n");
+               rte_free(i_lpm);
+               i_lpm = NULL;
+               rte_free(te);
+               rte_errno = ENOMEM;
+               goto exit;
+       }
+
+       i_lpm->lpm.tbl8 = rte_zmalloc_socket(NULL,
+                       (size_t)tbl8s_size, RTE_CACHE_LINE_SIZE, socket_id);
+
+       if (i_lpm->lpm.tbl8 == NULL) {
+               RTE_LOG(ERR, LPM, "LPM tbl8 memory allocation failed\n");
+               rte_free(i_lpm->rules_tbl);
+               rte_free(i_lpm);
+               i_lpm = NULL;
+               rte_free(te);
+               rte_errno = ENOMEM;
                goto exit;
        }
 
        /* Save user arguments. */
-       lpm->max_rules_per_depth = max_rules / RTE_LPM_MAX_DEPTH;
-       rte_snprintf(lpm->name, sizeof(lpm->name), "%s", name);
+       i_lpm->max_rules = config->max_rules;
+       i_lpm->number_tbl8s = config->number_tbl8s;
+       strlcpy(i_lpm->name, name, sizeof(i_lpm->name));
+
+       te->data = i_lpm;
+       lpm = &i_lpm->lpm;
 
-       TAILQ_INSERT_TAIL(lpm_list, lpm, next);
+       TAILQ_INSERT_TAIL(lpm_list, te, next);
 
-exit:  
-       rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
+exit:
+       rte_mcfg_tailq_write_unlock();
 
        return lpm;
 }
@@ -219,12 +258,101 @@ exit:
 void
 rte_lpm_free(struct rte_lpm *lpm)
 {
+       struct rte_lpm_list *lpm_list;
+       struct rte_tailq_entry *te;
+       struct __rte_lpm *i_lpm;
+
        /* Check user arguments. */
        if (lpm == NULL)
                return;
+       i_lpm = container_of(lpm, struct __rte_lpm, lpm);
+
+       lpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);
 
-       RTE_EAL_TAILQ_REMOVE(RTE_TAILQ_LPM, rte_lpm_list, lpm);
-       rte_free(lpm);
+       rte_mcfg_tailq_write_lock();
+
+       /* find our tailq entry */
+       TAILQ_FOREACH(te, lpm_list, next) {
+               if (te->data == (void *)i_lpm)
+                       break;
+       }
+       if (te != NULL)
+               TAILQ_REMOVE(lpm_list, te, next);
+
+       rte_mcfg_tailq_write_unlock();
+
+       if (i_lpm->dq != NULL)
+               rte_rcu_qsbr_dq_delete(i_lpm->dq);
+       rte_free(i_lpm->lpm.tbl8);
+       rte_free(i_lpm->rules_tbl);
+       rte_free(i_lpm);
+       rte_free(te);
+}
+
+static void
+__lpm_rcu_qsbr_free_resource(void *p, void *data, unsigned int n)
+{
+       struct rte_lpm_tbl_entry *tbl8 = ((struct __rte_lpm *)p)->lpm.tbl8;
+       struct rte_lpm_tbl_entry zero_tbl8_entry = {0};
+       uint32_t tbl8_group_index = *(uint32_t *)data;
+
+       RTE_SET_USED(n);
+       /* Set tbl8 group invalid */
+       __atomic_store(&tbl8[tbl8_group_index], &zero_tbl8_entry,
+               __ATOMIC_RELAXED);
+}
+
+/* Associate QSBR variable with an LPM object.
+ */
+int
+rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg)
+{
+       struct rte_rcu_qsbr_dq_parameters params = {0};
+       char rcu_dq_name[RTE_RCU_QSBR_DQ_NAMESIZE];
+       struct __rte_lpm *i_lpm;
+
+       if (lpm == NULL || cfg == NULL) {
+               rte_errno = EINVAL;
+               return 1;
+       }
+
+       i_lpm = container_of(lpm, struct __rte_lpm, lpm);
+       if (i_lpm->v != NULL) {
+               rte_errno = EEXIST;
+               return 1;
+       }
+
+       if (cfg->mode == RTE_LPM_QSBR_MODE_SYNC) {
+               /* No other things to do. */
+       } else if (cfg->mode == RTE_LPM_QSBR_MODE_DQ) {
+               /* Init QSBR defer queue. */
+               snprintf(rcu_dq_name, sizeof(rcu_dq_name),
+                               "LPM_RCU_%s", i_lpm->name);
+               params.name = rcu_dq_name;
+               params.size = cfg->dq_size;
+               if (params.size == 0)
+                       params.size = i_lpm->number_tbl8s;
+               params.trigger_reclaim_limit = cfg->reclaim_thd;
+               params.max_reclaim_size = cfg->reclaim_max;
+               if (params.max_reclaim_size == 0)
+                       params.max_reclaim_size = RTE_LPM_RCU_DQ_RECLAIM_MAX;
+               params.esize = sizeof(uint32_t);        /* tbl8 group index */
+               params.free_fn = __lpm_rcu_qsbr_free_resource;
+               params.p = i_lpm;
+               params.v = cfg->v;
+               i_lpm->dq = rte_rcu_qsbr_dq_create(&params);
+               if (i_lpm->dq == NULL) {
+                       RTE_LOG(ERR, LPM, "LPM defer queue creation failed\n");
+                       return 1;
+               }
+       } else {
+               rte_errno = EINVAL;
+               return 1;
+       }
+       i_lpm->rcu_mode = cfg->mode;
+       i_lpm->v = cfg->v;
+
+       return 0;
 }
 
 /*
@@ -237,45 +365,78 @@ rte_lpm_free(struct rte_lpm *lpm)
  * are stored in the rule table from 0 - 31.
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
-static inline int32_t
-rule_add(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
-       uint8_t next_hop)
+static int32_t
+rule_add(struct __rte_lpm *i_lpm, uint32_t ip_masked, uint8_t depth,
+       uint32_t next_hop)
 {
        uint32_t rule_gindex, rule_index, last_rule;
+       int i;
 
        VERIFY_DEPTH(depth);
 
-       /* rule_gindex stands for rule group index. */
-       rule_gindex = ((depth - 1) * lpm->max_rules_per_depth);
-       /* Initialise rule_index to point to start of rule group. */
-       rule_index = rule_gindex;
-       /* Last rule = Last used rule in this rule group. */
-       last_rule = rule_gindex + lpm->used_rules_at_depth[depth - 1];
-               
        /* Scan through rule group to see if rule already exists. */
-       for (rule_index = rule_gindex; rule_index < last_rule; rule_index++) {
+       if (i_lpm->rule_info[depth - 1].used_rules > 0) {
 
-               /* If rule already exists update its next_hop and return. */
-               if (lpm->rules_tbl[rule_index].ip == ip_masked) {
-                       lpm->rules_tbl[rule_index].next_hop = next_hop;
+               /* rule_gindex stands for rule group index. */
+               rule_gindex = i_lpm->rule_info[depth - 1].first_rule;
+               /* Initialise rule_index to point to start of rule group. */
+               rule_index = rule_gindex;
+               /* Last rule = Last used rule in this rule group. */
+               last_rule = rule_gindex + i_lpm->rule_info[depth - 1].used_rules;
 
-                       return rule_index;
+               for (; rule_index < last_rule; rule_index++) {
+
+                       /* If rule already exists update next hop and return. */
+                       if (i_lpm->rules_tbl[rule_index].ip == ip_masked) {
+
+                               if (i_lpm->rules_tbl[rule_index].next_hop
+                                               == next_hop)
+                                       return -EEXIST;
+                               i_lpm->rules_tbl[rule_index].next_hop = next_hop;
+
+                               return rule_index;
+                       }
                }
+
+               if (rule_index == i_lpm->max_rules)
+                       return -ENOSPC;
+       } else {
+               /* Calculate the position in which the rule will be stored. */
+               rule_index = 0;
+
+               for (i = depth - 1; i > 0; i--) {
+                       if (i_lpm->rule_info[i - 1].used_rules > 0) {
+                               rule_index = i_lpm->rule_info[i - 1].first_rule
+                                               + i_lpm->rule_info[i - 1].used_rules;
+                               break;
+                       }
+               }
+               if (rule_index == i_lpm->max_rules)
+                       return -ENOSPC;
+
+               i_lpm->rule_info[depth - 1].first_rule = rule_index;
        }
 
-       /*
-        * If rule does not exist check if there is space to add a new rule to
-        * this rule group. If there is no space return error. */
-       if (lpm->used_rules_at_depth[depth - 1] == lpm->max_rules_per_depth) {
-               return -ENOSPC;
+       /* Make room for the new rule in the array. */
+       for (i = RTE_LPM_MAX_DEPTH; i > depth; i--) {
+               if (i_lpm->rule_info[i - 1].first_rule
+                               + i_lpm->rule_info[i - 1].used_rules == i_lpm->max_rules)
+                       return -ENOSPC;
+
+               if (i_lpm->rule_info[i - 1].used_rules > 0) {
+                       i_lpm->rules_tbl[i_lpm->rule_info[i - 1].first_rule
+                               + i_lpm->rule_info[i - 1].used_rules]
+                                       = i_lpm->rules_tbl[i_lpm->rule_info[i - 1].first_rule];
+                       i_lpm->rule_info[i - 1].first_rule++;
+               }
        }
 
-       /* If there is space for the new rule add it. */
-       lpm->rules_tbl[rule_index].ip = ip_masked;
-       lpm->rules_tbl[rule_index].next_hop = next_hop;
+       /* Add the new rule. */
+       i_lpm->rules_tbl[rule_index].ip = ip_masked;
+       i_lpm->rules_tbl[rule_index].next_hop = next_hop;
 
        /* Increment the used rules counter for this rule group. */
-       lpm->used_rules_at_depth[depth - 1]++;
+       i_lpm->rule_info[depth - 1].used_rules++;
 
        return rule_index;
 }
@@ -284,74 +445,85 @@ rule_add(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
  * Delete a rule from the rule table.
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
-static inline void
-rule_delete(struct rte_lpm *lpm, int32_t rule_index, uint8_t depth)
+static void
+rule_delete(struct __rte_lpm *i_lpm, int32_t rule_index, uint8_t depth)
 {
-       uint32_t rule_gindex, last_rule_index;
+       int i;
 
        VERIFY_DEPTH(depth);
 
-       rule_gindex = ((depth - 1) * lpm->max_rules_per_depth);
-       last_rule_index = rule_gindex +
-                       (lpm->used_rules_at_depth[depth - 1]) - 1;
-       /*
-        * Overwrite redundant rule with last rule in group and decrement rule
-        * counter.
-        */
-       lpm->rules_tbl[rule_index] = lpm->rules_tbl[last_rule_index];
-       lpm->used_rules_at_depth[depth - 1]--;
-}
+       i_lpm->rules_tbl[rule_index] =
+                       i_lpm->rules_tbl[i_lpm->rule_info[depth - 1].first_rule
+                       + i_lpm->rule_info[depth - 1].used_rules - 1];
+
+       for (i = depth; i < RTE_LPM_MAX_DEPTH; i++) {
+               if (i_lpm->rule_info[i].used_rules > 0) {
+                       i_lpm->rules_tbl[i_lpm->rule_info[i].first_rule - 1] =
+                                       i_lpm->rules_tbl[i_lpm->rule_info[i].first_rule
+                                               + i_lpm->rule_info[i].used_rules - 1];
+                       i_lpm->rule_info[i].first_rule--;
+               }
+       }
 
+       i_lpm->rule_info[depth - 1].used_rules--;
+}
 
 /*
  * Finds a rule in rule table.
  * NOTE: Valid range for depth parameter is 1 .. 32 inclusive.
  */
-static inline int32_t
-rule_find(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth)
+static int32_t
+rule_find(struct __rte_lpm *i_lpm, uint32_t ip_masked, uint8_t depth)
 {
        uint32_t rule_gindex, last_rule, rule_index;
 
        VERIFY_DEPTH(depth);
 
-       rule_gindex = ((depth - 1) * lpm->max_rules_per_depth);
-       last_rule = rule_gindex + lpm->used_rules_at_depth[depth - 1];
+       rule_gindex = i_lpm->rule_info[depth - 1].first_rule;
+       last_rule = rule_gindex + i_lpm->rule_info[depth - 1].used_rules;
 
        /* Scan used rules at given depth to find rule. */
        for (rule_index = rule_gindex; rule_index < last_rule; rule_index++) {
                /* If rule is found return the rule index. */
-               if (lpm->rules_tbl[rule_index].ip == ip_masked)
-                       return (rule_index);
+               if (i_lpm->rules_tbl[rule_index].ip == ip_masked)
+                       return rule_index;
        }
 
-       /* If rule is not found return -E_RTE_NO_TAILQ. */
-       return -E_RTE_NO_TAILQ;
+       /* If rule is not found return -EINVAL. */
+       return -EINVAL;
 }
 
 /*
  * Find, clean and allocate a tbl8.
  */
-static inline int32_t
-tbl8_alloc(struct rte_lpm_tbl8_entry *tbl8)
+static int32_t
+_tbl8_alloc(struct __rte_lpm *i_lpm)
 {
-       uint32_t tbl8_gindex; /* tbl8 group index. */
-       struct rte_lpm_tbl8_entry *tbl8_entry;
+       uint32_t group_idx; /* tbl8 group index. */
+       struct rte_lpm_tbl_entry *tbl8_entry;
 
        /* Scan through tbl8 to find a free (i.e. INVALID) tbl8 group. */
-       for (tbl8_gindex = 0; tbl8_gindex < RTE_LPM_TBL8_NUM_GROUPS;
-                       tbl8_gindex++) {
-               tbl8_entry = &tbl8[tbl8_gindex *
-                                  RTE_LPM_TBL8_GROUP_NUM_ENTRIES];
+       for (group_idx = 0; group_idx < i_lpm->number_tbl8s; group_idx++) {
+               tbl8_entry = &i_lpm->lpm.tbl8[group_idx *
+                                       RTE_LPM_TBL8_GROUP_NUM_ENTRIES];
                /* If a free tbl8 group is found clean it and set as VALID. */
                if (!tbl8_entry->valid_group) {
+                       struct rte_lpm_tbl_entry new_tbl8_entry = {
+                               .next_hop = 0,
+                               .valid = INVALID,
+                               .depth = 0,
+                               .valid_group = VALID,
+                       };
+
                        memset(&tbl8_entry[0], 0,
                                        RTE_LPM_TBL8_GROUP_NUM_ENTRIES *
                                        sizeof(tbl8_entry[0]));
 
-                       tbl8_entry->valid_group = VALID;
+                       __atomic_store(tbl8_entry, &new_tbl8_entry,
+                                       __ATOMIC_RELAXED);
 
                        /* Return group index for allocated tbl8 group. */
-                       return tbl8_gindex;
+                       return group_idx;
                }
        }
 
@@ -359,17 +531,57 @@ tbl8_alloc(struct rte_lpm_tbl8_entry *tbl8)
        return -ENOSPC;
 }
 
-static inline void
-tbl8_free(struct rte_lpm_tbl8_entry *tbl8, uint32_t tbl8_group_start)
+static int32_t
+tbl8_alloc(struct __rte_lpm *i_lpm)
 {
-       /* Set tbl8 group invalid*/
-       tbl8[tbl8_group_start].valid_group = INVALID;
+       int32_t group_idx; /* tbl8 group index. */
+
+       group_idx = _tbl8_alloc(i_lpm);
+       if (group_idx == -ENOSPC && i_lpm->dq != NULL) {
+               /* If there are no tbl8 groups try to reclaim one. */
+               if (rte_rcu_qsbr_dq_reclaim(i_lpm->dq, 1,
+                               NULL, NULL, NULL) == 0)
+                       group_idx = _tbl8_alloc(i_lpm);
+       }
+
+       return group_idx;
 }
 
-static inline int32_t
-add_depth_small(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
-               uint8_t next_hop)
+static int32_t
+tbl8_free(struct __rte_lpm *i_lpm, uint32_t tbl8_group_start)
 {
+       struct rte_lpm_tbl_entry zero_tbl8_entry = {0};
+       int status;
+
+       if (i_lpm->v == NULL) {
+               /* Set tbl8 group invalid*/
+               __atomic_store(&i_lpm->lpm.tbl8[tbl8_group_start], &zero_tbl8_entry,
+                               __ATOMIC_RELAXED);
+       } else if (i_lpm->rcu_mode == RTE_LPM_QSBR_MODE_SYNC) {
+               /* Wait for quiescent state change. */
+               rte_rcu_qsbr_synchronize(i_lpm->v,
+                       RTE_QSBR_THRID_INVALID);
+               /* Set tbl8 group invalid*/
+               __atomic_store(&i_lpm->lpm.tbl8[tbl8_group_start], &zero_tbl8_entry,
+                               __ATOMIC_RELAXED);
+       } else if (i_lpm->rcu_mode == RTE_LPM_QSBR_MODE_DQ) {
+               /* Push into QSBR defer queue. */
+               status = rte_rcu_qsbr_dq_enqueue(i_lpm->dq,
+                               (void *)&tbl8_group_start);
+               if (status == 1) {
+                       RTE_LOG(ERR, LPM, "Failed to push QSBR FIFO\n");
+                       return -rte_errno;
+               }
+       }
+
+       return 0;
+}
+
+static __rte_noinline int32_t
+add_depth_small(struct __rte_lpm *i_lpm, uint32_t ip, uint8_t depth,
+               uint32_t next_hop)
+{
+#define group_idx next_hop
        uint32_t tbl24_index, tbl24_range, tbl8_index, tbl8_group_end, i, j;
 
        /* Calculate the index into Table24. */
@@ -381,57 +593,67 @@ add_depth_small(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
                 * For invalid OR valid and non-extended tbl 24 entries set
                 * entry.
                 */
-               if (!lpm->tbl24[i].valid || (lpm->tbl24[i].ext_entry == 0 &&
-                               lpm->tbl24[i].depth <= depth)) {
+               if (!i_lpm->lpm.tbl24[i].valid || (i_lpm->lpm.tbl24[i].valid_group == 0 &&
+                               i_lpm->lpm.tbl24[i].depth <= depth)) {
 
-                       struct rte_lpm_tbl24_entry new_tbl24_entry = {
-                               { .next_hop = next_hop, },
+                       struct rte_lpm_tbl_entry new_tbl24_entry = {
+                               .next_hop = next_hop,
                                .valid = VALID,
-                               .ext_entry = 0,
+                               .valid_group = 0,
                                .depth = depth,
                        };
 
                        /* Setting tbl24 entry in one go to avoid race
-                        * conditions */
-                       lpm->tbl24[i] = new_tbl24_entry;
+                        * conditions
+                        */
+                       __atomic_store(&i_lpm->lpm.tbl24[i], &new_tbl24_entry,
+                                       __ATOMIC_RELEASE);
 
                        continue;
                }
 
-               /* If tbl24 entry is valid and extended calculate the index
-                * into tbl8. */
-               tbl8_index = lpm->tbl24[tbl24_index].tbl8_gindex * 
-                               RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-               tbl8_group_end = tbl8_index + RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-
-               for (j = tbl8_index; j < tbl8_group_end; j++) {
-                       if (!lpm->tbl8[j].valid ||
-                                       lpm->tbl8[j].depth <= depth) {
-                               struct rte_lpm_tbl8_entry new_tbl8_entry = {
-                                       .valid = VALID,
-                                       .valid_group = VALID,
-                                       .depth = depth,
-                                       .next_hop = next_hop,
-                               };
-
-                               /*
-                                * Setting tbl8 entry in one go to avoid race
-                                * conditions
-                                */
-                               lpm->tbl8[j] = new_tbl8_entry;
-
-                               continue;
+               if (i_lpm->lpm.tbl24[i].valid_group == 1) {
+                       /* If tbl24 entry is valid and extended calculate the
+                        *  index into tbl8.
+                        */
+                       tbl8_index = i_lpm->lpm.tbl24[i].group_idx *
+                                       RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
+                       tbl8_group_end = tbl8_index +
+                                       RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
+
+                       for (j = tbl8_index; j < tbl8_group_end; j++) {
+                               if (!i_lpm->lpm.tbl8[j].valid ||
+                                               i_lpm->lpm.tbl8[j].depth <= depth) {
+                                       struct rte_lpm_tbl_entry
+                                               new_tbl8_entry = {
+                                               .valid = VALID,
+                                               .valid_group = VALID,
+                                               .depth = depth,
+                                               .next_hop = next_hop,
+                                       };
+
+                                       /*
+                                        * Setting tbl8 entry in one go to avoid
+                                        * race conditions
+                                        */
+                                       __atomic_store(&i_lpm->lpm.tbl8[j],
+                                               &new_tbl8_entry,
+                                               __ATOMIC_RELAXED);
+
+                                       continue;
+                               }
                        }
                }
        }
-
+#undef group_idx
        return 0;
 }
 
-static inline int32_t
-add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
-               uint8_t next_hop)
+static __rte_noinline int32_t
+add_depth_big(struct __rte_lpm *i_lpm, uint32_t ip_masked, uint8_t depth,
+               uint32_t next_hop)
 {
+#define group_idx next_hop
        uint32_t tbl24_index;
        int32_t tbl8_group_index, tbl8_group_start, tbl8_group_end, tbl8_index,
                tbl8_range, i;
@@ -439,9 +661,9 @@ add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
        tbl24_index = (ip_masked >> 8);
        tbl8_range = depth_to_range(depth);
 
-       if (!lpm->tbl24[tbl24_index].valid) {
+       if (!i_lpm->lpm.tbl24[tbl24_index].valid) {
                /* Search for a free tbl8 group. */
-               tbl8_group_index = tbl8_alloc(lpm->tbl8);
+               tbl8_group_index = tbl8_alloc(i_lpm);
 
                /* Check tbl8 allocation was successful. */
                if (tbl8_group_index < 0) {
@@ -455,9 +677,14 @@ add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 
                /* Set tbl8 entry. */
                for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-                       lpm->tbl8[i].depth = depth;
-                       lpm->tbl8[i].next_hop = next_hop;
-                       lpm->tbl8[i].valid = VALID;
+                       struct rte_lpm_tbl_entry new_tbl8_entry = {
+                               .valid = VALID,
+                               .depth = depth,
+                               .valid_group = i_lpm->lpm.tbl8[i].valid_group,
+                               .next_hop = next_hop,
+                       };
+                       __atomic_store(&i_lpm->lpm.tbl8[i], &new_tbl8_entry,
+                                       __ATOMIC_RELAXED);
                }
 
                /*
@@ -466,19 +693,23 @@ add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
                 * so assign whole structure in one go
                 */
 
-               struct rte_lpm_tbl24_entry new_tbl24_entry = {
-                       { .tbl8_gindex = (uint8_t)tbl8_group_index, },
+               struct rte_lpm_tbl_entry new_tbl24_entry = {
+                       .group_idx = tbl8_group_index,
                        .valid = VALID,
-                       .ext_entry = 1,
+                       .valid_group = 1,
                        .depth = 0,
                };
 
-               lpm->tbl24[tbl24_index] = new_tbl24_entry;
+               /* The tbl24 entry must be written only after the
+                * tbl8 entries are written.
+                */
+               __atomic_store(&i_lpm->lpm.tbl24[tbl24_index], &new_tbl24_entry,
+                               __ATOMIC_RELEASE);
 
-       }/* If valid entry but not extended calculate the index into Table8. */
-       else if (lpm->tbl24[tbl24_index].ext_entry == 0) {
+       } /* If valid entry but not extended calculate the index into Table8. */
+       else if (i_lpm->lpm.tbl24[tbl24_index].valid_group == 0) {
                /* Search for free tbl8 group. */
-               tbl8_group_index = tbl8_alloc(lpm->tbl8);
+               tbl8_group_index = tbl8_alloc(i_lpm);
 
                if (tbl8_group_index < 0) {
                        return tbl8_group_index;
@@ -491,24 +722,28 @@ add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
 
                /* Populate new tbl8 with tbl24 value. */
                for (i = tbl8_group_start; i < tbl8_group_end; i++) {
-                       lpm->tbl8[i].valid = VALID;
-                       lpm->tbl8[i].depth = lpm->tbl24[tbl24_index].depth;
-                       lpm->tbl8[i].next_hop =
-                                       lpm->tbl24[tbl24_index].next_hop;
+                       struct rte_lpm_tbl_entry new_tbl8_entry = {
+                               .valid = VALID,
+                               .depth = i_lpm->lpm.tbl24[tbl24_index].depth,
+                               .valid_group = i_lpm->lpm.tbl8[i].valid_group,
+                               .next_hop = i_lpm->lpm.tbl24[tbl24_index].next_hop,
+                       };
+                       __atomic_store(&i_lpm->lpm.tbl8[i], &new_tbl8_entry,
+                                       __ATOMIC_RELAXED);
                }
 
                tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
 
                /* Insert new rule into the tbl8 entry. */
                for (i = tbl8_index; i < tbl8_index + tbl8_range; i++) {
-                       if (!lpm->tbl8[i].valid ||
-                                       lpm->tbl8[i].depth <= depth) {
-                               lpm->tbl8[i].valid = VALID;
-                               lpm->tbl8[i].depth = depth;
-                               lpm->tbl8[i].next_hop = next_hop;
-
-                               continue;
-                       }
+                       struct rte_lpm_tbl_entry new_tbl8_entry = {
+                               .valid = VALID,
+                               .depth = depth,
+                               .valid_group = i_lpm->lpm.tbl8[i].valid_group,
+                               .next_hop = next_hop,
+                       };
+                       __atomic_store(&i_lpm->lpm.tbl8[i], &new_tbl8_entry,
+                                       __ATOMIC_RELAXED);
                }
 
                /*
@@ -517,45 +752,50 @@ add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
                 * so assign whole structure in one go.
                 */
 
-               struct rte_lpm_tbl24_entry new_tbl24_entry = {
-                               { .tbl8_gindex = (uint8_t)tbl8_group_index, },
+               struct rte_lpm_tbl_entry new_tbl24_entry = {
+                               .group_idx = tbl8_group_index,
                                .valid = VALID,
-                               .ext_entry = 1,
+                               .valid_group = 1,
                                .depth = 0,
                };
 
-               lpm->tbl24[tbl24_index] = new_tbl24_entry;
+               /* The tbl24 entry must be written only after the
+                * tbl8 entries are written.
+                */
+               __atomic_store(&i_lpm->lpm.tbl24[tbl24_index], &new_tbl24_entry,
+                               __ATOMIC_RELEASE);
 
-       }
-       else { /*
+       } else { /*
                * If it is valid, extended entry calculate the index into tbl8.
                */
-               tbl8_group_index = lpm->tbl24[tbl24_index].tbl8_gindex;
+               tbl8_group_index = i_lpm->lpm.tbl24[tbl24_index].group_idx;
                tbl8_group_start = tbl8_group_index *
                                RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
                tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
 
                for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
 
-                       if (!lpm->tbl8[i].valid ||
-                                       lpm->tbl8[i].depth <= depth) {
-                               struct rte_lpm_tbl8_entry new_tbl8_entry = {
+                       if (!i_lpm->lpm.tbl8[i].valid ||
+                                       i_lpm->lpm.tbl8[i].depth <= depth) {
+                               struct rte_lpm_tbl_entry new_tbl8_entry = {
                                        .valid = VALID,
                                        .depth = depth,
                                        .next_hop = next_hop,
+                                       .valid_group = i_lpm->lpm.tbl8[i].valid_group,
                                };
 
                                /*
                                 * Setting tbl8 entry in one go to avoid race
                                 * condition
                                 */
-                               lpm->tbl8[i] = new_tbl8_entry;
+                               __atomic_store(&i_lpm->lpm.tbl8[i], &new_tbl8_entry,
+                                               __ATOMIC_RELAXED);
 
                                continue;
                        }
                }
        }
-
+#undef group_idx
        return 0;
 }
 
@@ -564,19 +804,27 @@ add_depth_big(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
  */
 int
 rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
-               uint8_t next_hop)
+               uint32_t next_hop)
 {
        int32_t rule_index, status = 0;
+       struct __rte_lpm *i_lpm;
        uint32_t ip_masked;
 
        /* Check user arguments. */
        if ((lpm == NULL) || (depth < 1) || (depth > RTE_LPM_MAX_DEPTH))
                return -EINVAL;
 
+       i_lpm = container_of(lpm, struct __rte_lpm, lpm);
        ip_masked = ip & depth_to_mask(depth);
 
        /* Add the rule to the rule table. */
-       rule_index = rule_add(lpm, ip_masked, depth, next_hop);
+       rule_index = rule_add(i_lpm, ip_masked, depth, next_hop);
+
+       /* Skip table entries update if The rule is the same as
+        * the rule in the rules table.
+        */
+       if (rule_index == -EEXIST)
+               return 0;
 
        /* If the is no space available for new rule return error. */
        if (rule_index < 0) {
@@ -584,17 +832,16 @@ rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
        }
 
        if (depth <= MAX_DEPTH_TBL24) {
-               status = add_depth_small(lpm, ip_masked, depth, next_hop);
-       }
-       else { /* If depth > RTE_LPM_MAX_DEPTH_TBL24 */
-               status = add_depth_big(lpm, ip_masked, depth, next_hop);
+               status = add_depth_small(i_lpm, ip_masked, depth, next_hop);
+       } else { /* If depth > RTE_LPM_MAX_DEPTH_TBL24 */
+               status = add_depth_big(i_lpm, ip_masked, depth, next_hop);
 
                /*
                 * If add fails due to exhaustion of tbl8 extensions delete
                 * rule that was added to rule table.
                 */
                if (status < 0) {
-                       rule_delete(lpm, rule_index, depth);
+                       rule_delete(i_lpm, rule_index, depth);
 
                        return status;
                }
@@ -603,8 +850,40 @@ rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
        return 0;
 }
 
-static inline int32_t
-find_previous_rule(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
+/*
+ * Look for a rule in the high-level rules table
+ */
+int
+rte_lpm_is_rule_present(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
+uint32_t *next_hop)
+{
+       struct __rte_lpm *i_lpm;
+       uint32_t ip_masked;
+       int32_t rule_index;
+
+       /* Check user arguments. */
+       if ((lpm == NULL) ||
+               (next_hop == NULL) ||
+               (depth < 1) || (depth > RTE_LPM_MAX_DEPTH))
+               return -EINVAL;
+
+       /* Look for the rule using rule_find. */
+       i_lpm = container_of(lpm, struct __rte_lpm, lpm);
+       ip_masked = ip & depth_to_mask(depth);
+       rule_index = rule_find(i_lpm, ip_masked, depth);
+
+       if (rule_index >= 0) {
+               *next_hop = i_lpm->rules_tbl[rule_index].next_hop;
+               return 1;
+       }
+
+       /* If rule is not found return 0. */
+       return 0;
+}
+
+static int32_t
+find_previous_rule(struct __rte_lpm *i_lpm, uint32_t ip, uint8_t depth,
+               uint8_t *sub_rule_depth)
 {
        int32_t rule_index;
        uint32_t ip_masked;
@@ -613,25 +892,28 @@ find_previous_rule(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
        for (prev_depth = (uint8_t)(depth - 1); prev_depth > 0; prev_depth--) {
                ip_masked = ip & depth_to_mask(prev_depth);
 
-               rule_index = rule_find(lpm, ip_masked, prev_depth);
+               rule_index = rule_find(i_lpm, ip_masked, prev_depth);
 
-               if (rule_index >= 0)
+               if (rule_index >= 0) {
+                       *sub_rule_depth = prev_depth;
                        return rule_index;
+               }
        }
 
        return -1;
 }
 
-static inline int32_t
-delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,
-       uint8_t depth, int32_t sub_rule_index)
+static int32_t
+delete_depth_small(struct __rte_lpm *i_lpm, uint32_t ip_masked,
+       uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
 {
+#define group_idx next_hop
        uint32_t tbl24_range, tbl24_index, tbl8_group_index, tbl8_index, i, j;
-       uint8_t new_depth;
 
        /* Calculate the range and index into Table24. */
        tbl24_range = depth_to_range(depth);
        tbl24_index = (ip_masked >> 8);
+       struct rte_lpm_tbl_entry zero_tbl24_entry = {0};
 
        /*
         * Firstly check the sub_rule_index. A -1 indicates no replacement rule
@@ -643,82 +925,80 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,
                 * associated with this rule.
                 */
                for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
-                       
-                       if (lpm->tbl24[i].ext_entry == 0 &&
-                                       lpm->tbl24[i].depth <= depth ) {
-                               lpm->tbl24[i].valid = INVALID;
-                       }
-                       else {
+
+                       if (i_lpm->lpm.tbl24[i].valid_group == 0 &&
+                                       i_lpm->lpm.tbl24[i].depth <= depth) {
+                               __atomic_store(&i_lpm->lpm.tbl24[i],
+                                       &zero_tbl24_entry, __ATOMIC_RELEASE);
+                       } else if (i_lpm->lpm.tbl24[i].valid_group == 1) {
                                /*
                                 * If TBL24 entry is extended, then there has
                                 * to be a rule with depth >= 25 in the
                                 * associated TBL8 group.
                                 */
 
-                               tbl8_group_index = lpm->tbl24[i].tbl8_gindex;
+                               tbl8_group_index = i_lpm->lpm.tbl24[i].group_idx;
                                tbl8_index = tbl8_group_index *
                                                RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
 
                                for (j = tbl8_index; j < (tbl8_index +
                                        RTE_LPM_TBL8_GROUP_NUM_ENTRIES); j++) {
 
-                                       if (lpm->tbl8[j].depth <= depth)
-                                               lpm->tbl8[j].valid = INVALID;
+                                       if (i_lpm->lpm.tbl8[j].depth <= depth)
+                                               i_lpm->lpm.tbl8[j].valid = INVALID;
                                }
                        }
                }
-       }
-       else {
+       } else {
                /*
                 * If a replacement rule exists then modify entries
                 * associated with this rule.
                 */
 
-               /* Calculate depth of sub_rule. */
-               new_depth = (uint8_t) (sub_rule_index /
-                               lpm->max_rules_per_depth);
-
-               struct rte_lpm_tbl24_entry new_tbl24_entry = {
-                       {.next_hop = lpm->rules_tbl[sub_rule_index].next_hop,},
+               struct rte_lpm_tbl_entry new_tbl24_entry = {
+                       .next_hop = i_lpm->rules_tbl[sub_rule_index].next_hop,
                        .valid = VALID,
-                       .ext_entry = 0,
-                       .depth = new_depth,
+                       .valid_group = 0,
+                       .depth = sub_rule_depth,
                };
 
-               struct rte_lpm_tbl8_entry new_tbl8_entry = {
+               struct rte_lpm_tbl_entry new_tbl8_entry = {
                        .valid = VALID,
-                       .depth = new_depth,
-                       .next_hop = lpm->rules_tbl
+                       .valid_group = VALID,
+                       .depth = sub_rule_depth,
+                       .next_hop = i_lpm->rules_tbl
                        [sub_rule_index].next_hop,
                };
 
                for (i = tbl24_index; i < (tbl24_index + tbl24_range); i++) {
 
-                       if (lpm->tbl24[i].ext_entry == 0 &&
-                                       lpm->tbl24[i].depth <= depth ) {
-                               lpm->tbl24[i] = new_tbl24_entry;
-                       }
-                       else {
+                       if (i_lpm->lpm.tbl24[i].valid_group == 0 &&
+                                       i_lpm->lpm.tbl24[i].depth <= depth) {
+                               __atomic_store(&i_lpm->lpm.tbl24[i], &new_tbl24_entry,
+                                               __ATOMIC_RELEASE);
+                       } else  if (i_lpm->lpm.tbl24[i].valid_group == 1) {
                                /*
                                 * If TBL24 entry is extended, then there has
                                 * to be a rule with depth >= 25 in the
                                 * associated TBL8 group.
                                 */
 
-                               tbl8_group_index = lpm->tbl24[i].tbl8_gindex;
+                               tbl8_group_index = i_lpm->lpm.tbl24[i].group_idx;
                                tbl8_index = tbl8_group_index *
                                                RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
-                               
+
                                for (j = tbl8_index; j < (tbl8_index +
                                        RTE_LPM_TBL8_GROUP_NUM_ENTRIES); j++) {
 
-                                       if (lpm->tbl8[j].depth <= depth)
-                                               lpm->tbl8[j] = new_tbl8_entry;
+                                       if (i_lpm->lpm.tbl8[j].depth <= depth)
+                                               __atomic_store(&i_lpm->lpm.tbl8[j],
+                                                       &new_tbl8_entry,
+                                                       __ATOMIC_RELAXED);
                                }
                        }
                }
        }
-
+#undef group_idx
        return 0;
 }
 
@@ -730,8 +1010,9 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,
  * Return of value > -1 means tbl8 is in use but has all the same values and
  * thus can be recycled
  */
-static inline int32_t
-tbl8_recycle_check(struct rte_lpm_tbl8_entry *tbl8, uint32_t tbl8_group_start)
+static int32_t
+tbl8_recycle_check(struct rte_lpm_tbl_entry *tbl8,
+               uint32_t tbl8_group_start)
 {
        uint32_t tbl8_group_end, i;
        tbl8_group_end = tbl8_group_start + RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
@@ -748,7 +1029,7 @@ tbl8_recycle_check(struct rte_lpm_tbl8_entry *tbl8, uint32_t tbl8_group_start)
                 * and if so check the rest of the entries to verify that they
                 * are all of this depth.
                 */
-               if (tbl8[tbl8_group_start].depth < MAX_DEPTH_TBL24) {
+               if (tbl8[tbl8_group_start].depth <= MAX_DEPTH_TBL24) {
                        for (i = (tbl8_group_start + 1); i < tbl8_group_end;
                                        i++) {
 
@@ -776,14 +1057,14 @@ tbl8_recycle_check(struct rte_lpm_tbl8_entry *tbl8, uint32_t tbl8_group_start)
        return -EINVAL;
 }
 
-static inline int32_t
-delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
-       uint8_t depth, int32_t sub_rule_index)
+static int32_t
+delete_depth_big(struct __rte_lpm *i_lpm, uint32_t ip_masked,
+       uint8_t depth, int32_t sub_rule_index, uint8_t sub_rule_depth)
 {
+#define group_idx next_hop
        uint32_t tbl24_index, tbl8_group_index, tbl8_group_start, tbl8_index,
                        tbl8_range, i;
-       uint8_t new_depth;
-       int32_t tbl8_recycle_index;
+       int32_t tbl8_recycle_index, status = 0;
 
        /*
         * Calculate the index into tbl24 and range. Note: All depths larger
@@ -792,7 +1073,7 @@ delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
        tbl24_index = ip_masked >> 8;
 
        /* Calculate the index into tbl8 and range. */
-       tbl8_group_index = lpm->tbl24[tbl24_index].tbl8_gindex;
+       tbl8_group_index = i_lpm->lpm.tbl24[tbl24_index].group_idx;
        tbl8_group_start = tbl8_group_index * RTE_LPM_TBL8_GROUP_NUM_ENTRIES;
        tbl8_index = tbl8_group_start + (ip_masked & 0xFF);
        tbl8_range = depth_to_range(depth);
@@ -803,19 +1084,16 @@ delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
                 * rule_to_delete must be removed or modified.
                 */
                for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-                       if (lpm->tbl8[i].depth <= depth)
-                               lpm->tbl8[i].valid = INVALID;
+                       if (i_lpm->lpm.tbl8[i].depth <= depth)
+                               i_lpm->lpm.tbl8[i].valid = INVALID;
                }
-       }
-       else {
-               new_depth = (uint8_t)(sub_rule_index /
-                               lpm->max_rules_per_depth);
-
+       } else {
                /* Set new tbl8 entry. */
-               struct rte_lpm_tbl8_entry new_tbl8_entry = {
+               struct rte_lpm_tbl_entry new_tbl8_entry = {
                        .valid = VALID,
-                       .depth = new_depth,
-                       .next_hop = lpm->rules_tbl[sub_rule_index].next_hop,
+                       .depth = sub_rule_depth,
+                       .valid_group = i_lpm->lpm.tbl8[tbl8_group_start].valid_group,
+                       .next_hop = i_lpm->rules_tbl[sub_rule_index].next_hop,
                };
 
                /*
@@ -823,8 +1101,9 @@ delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
                 * rule_to_delete must be modified.
                 */
                for (i = tbl8_index; i < (tbl8_index + tbl8_range); i++) {
-                       if (lpm->tbl8[i].depth <= depth)
-                               lpm->tbl8[i] = new_tbl8_entry;
+                       if (i_lpm->lpm.tbl8[i].depth <= depth)
+                               __atomic_store(&i_lpm->lpm.tbl8[i], &new_tbl8_entry,
+                                               __ATOMIC_RELAXED);
                }
        }
 
@@ -834,28 +1113,34 @@ delete_depth_big(struct rte_lpm *lpm, uint32_t ip_masked,
         * associated tbl24 entry.
         */
 
-       tbl8_recycle_index = tbl8_recycle_check(lpm->tbl8, tbl8_group_start);
+       tbl8_recycle_index = tbl8_recycle_check(i_lpm->lpm.tbl8, tbl8_group_start);
 
-       if (tbl8_recycle_index == -EINVAL){
-               /* Set tbl24 before freeing tbl8 to avoid race condition. */
-               lpm->tbl24[tbl24_index].valid = 0;
-               tbl8_free(lpm->tbl8, tbl8_group_start);
-       }
-       else if (tbl8_recycle_index > -1) {
+       if (tbl8_recycle_index == -EINVAL) {
+               /* Set tbl24 before freeing tbl8 to avoid race condition.
+                * Prevent the free of the tbl8 group from hoisting.
+                */
+               i_lpm->lpm.tbl24[tbl24_index].valid = 0;
+               __atomic_thread_fence(__ATOMIC_RELEASE);
+               status = tbl8_free(i_lpm, tbl8_group_start);
+       } else if (tbl8_recycle_index > -1) {
                /* Update tbl24 entry. */
-               struct rte_lpm_tbl24_entry new_tbl24_entry = {
-                       { .next_hop = lpm->tbl8[tbl8_recycle_index].next_hop, },
+               struct rte_lpm_tbl_entry new_tbl24_entry = {
+                       .next_hop = i_lpm->lpm.tbl8[tbl8_recycle_index].next_hop,
                        .valid = VALID,
-                       .ext_entry = 0,
-                       .depth = lpm->tbl8[tbl8_recycle_index].depth,
+                       .valid_group = 0,
+                       .depth = i_lpm->lpm.tbl8[tbl8_recycle_index].depth,
                };
 
-               /* Set tbl24 before freeing tbl8 to avoid race condition. */
-               lpm->tbl24[tbl24_index] = new_tbl24_entry;
-               tbl8_free(lpm->tbl8, tbl8_group_start);
+               /* Set tbl24 before freeing tbl8 to avoid race condition.
+                * Prevent the free of the tbl8 group from hoisting.
+                */
+               __atomic_store(&i_lpm->lpm.tbl24[tbl24_index], &new_tbl24_entry,
+                               __ATOMIC_RELAXED);
+               __atomic_thread_fence(__ATOMIC_RELEASE);
+               status = tbl8_free(i_lpm, tbl8_group_start);
        }
-
-       return 0;
+#undef group_idx
+       return status;
 }
 
 /*
@@ -865,7 +1150,9 @@ int
 rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
 {
        int32_t rule_to_delete_index, sub_rule_index;
+       struct __rte_lpm *i_lpm;
        uint32_t ip_masked;
+       uint8_t sub_rule_depth;
        /*
         * Check input arguments. Note: IP must be a positive integer of 32
         * bits in length therefore it need not be checked.
@@ -874,41 +1161,43 @@ rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
                return -EINVAL;
        }
 
+       i_lpm = container_of(lpm, struct __rte_lpm, lpm);
        ip_masked = ip & depth_to_mask(depth);
 
        /*
         * Find the index of the input rule, that needs to be deleted, in the
         * rule table.
         */
-       rule_to_delete_index = rule_find(lpm, ip_masked, depth);
+       rule_to_delete_index = rule_find(i_lpm, ip_masked, depth);
 
        /*
         * Check if rule_to_delete_index was found. If no rule was found the
-        * function rule_find returns -E_RTE_NO_TAILQ.
+        * function rule_find returns -EINVAL.
         */
        if (rule_to_delete_index < 0)
-               return -E_RTE_NO_TAILQ;
+               return -EINVAL;
 
        /* Delete the rule from the rule table. */
-       rule_delete(lpm, rule_to_delete_index, depth);
+       rule_delete(i_lpm, rule_to_delete_index, depth);
 
        /*
         * Find rule to replace the rule_to_delete. If there is no rule to
         * replace the rule_to_delete we return -1 and invalidate the table
         * entries associated with this rule.
         */
-       sub_rule_index = find_previous_rule(lpm, ip, depth);
+       sub_rule_depth = 0;
+       sub_rule_index = find_previous_rule(i_lpm, ip, depth, &sub_rule_depth);
 
        /*
         * If the input depth value is less than 25 use function
         * delete_depth_small otherwise use delete_depth_big.
         */
        if (depth <= MAX_DEPTH_TBL24) {
-               return delete_depth_small(lpm, ip_masked, depth,
-                               sub_rule_index);
-       }
-       else { /* If depth > MAX_DEPTH_TBL24 */
-               return delete_depth_big(lpm, ip_masked, depth, sub_rule_index);
+               return delete_depth_small(i_lpm, ip_masked, depth,
+                               sub_rule_index, sub_rule_depth);
+       } else { /* If depth > MAX_DEPTH_TBL24 */
+               return delete_depth_big(i_lpm, ip_masked, depth, sub_rule_index,
+                               sub_rule_depth);
        }
 }
 
@@ -918,17 +1207,19 @@ rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)
 void
 rte_lpm_delete_all(struct rte_lpm *lpm)
 {
-       /* Zero used rules counter. */
-       memset(lpm->used_rules_at_depth, 0, sizeof(lpm->used_rules_at_depth));
+       struct __rte_lpm *i_lpm;
+
+       i_lpm = container_of(lpm, struct __rte_lpm, lpm);
+       /* Zero rule information. */
+       memset(i_lpm->rule_info, 0, sizeof(i_lpm->rule_info));
 
        /* Zero tbl24. */
-       memset(lpm->tbl24, 0, sizeof(lpm->tbl24));
+       memset(i_lpm->lpm.tbl24, 0, sizeof(i_lpm->lpm.tbl24));
 
        /* Zero tbl8. */
-       memset(lpm->tbl8, 0, sizeof(lpm->tbl8));
+       memset(i_lpm->lpm.tbl8, 0, sizeof(i_lpm->lpm.tbl8[0])
+                       * RTE_LPM_TBL8_GROUP_NUM_ENTRIES * i_lpm->number_tbl8s);
 
        /* Delete all rules form the rules table. */
-       memset(lpm->rules_tbl, 0, sizeof(lpm->rules_tbl[0]) *
-                       (lpm->max_rules_per_depth * RTE_LPM_MAX_DEPTH));
+       memset(i_lpm->rules_tbl, 0, sizeof(i_lpm->rules_tbl[0]) * i_lpm->max_rules);
 }
-