common/mlx5: fix user mode register access command
[dpdk.git] / lib / librte_table / rte_table_hash_key16.c
index 5ad63bc..2cca1c9 100644 (file)
@@ -1,34 +1,5 @@
-/*-
- *      BSD LICENSE
- *
- *      Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- *      All rights reserved.
- *
- *      Redistribution and use in source and binary forms, with or without
- *      modification, are permitted provided that the following conditions
- *      are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *              notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *              notice, this list of conditions and the following disclaimer in
- *              the documentation and/or other materials provided with the
- *              distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *              contributors may be used to endorse or promote products derived
- *              from this software without specific prior written permission.
- *
- *      THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *      "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *      LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *      A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *      OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *      SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *      LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *      DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *      THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *      (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *      OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2017 Intel Corporation
  */
 #include <string.h>
 #include <stdio.h>
@@ -42,7 +13,9 @@
 #include "rte_table_hash.h"
 #include "rte_lru.h"
 
-#define RTE_TABLE_HASH_KEY_SIZE                                                16
+#define KEY_SIZE                                               16
+
+#define KEYS_PER_BUCKET                                        4
 
 #define RTE_BUCKET_ENTRY_VALID                                         0x1LLU
 
@@ -79,11 +52,9 @@ struct rte_table_hash {
 
        /* Input parameters */
        uint32_t n_buckets;
-       uint32_t n_entries_per_bucket;
        uint32_t key_size;
        uint32_t entry_size;
        uint32_t bucket_size;
-       uint32_t signature_offset;
        uint32_t key_offset;
        uint64_t key_mask[2];
        rte_table_hash_op_hash f_hash;
@@ -99,17 +70,55 @@ struct rte_table_hash {
 };
 
 static int
-check_params_create_lru(struct rte_table_hash_key16_lru_params *params) {
-       /* n_entries */
-       if (params->n_entries == 0) {
-               RTE_LOG(ERR, TABLE, "%s: n_entries is zero\n", __func__);
+keycmp(void *a, void *b, void *b_mask)
+{
+       uint64_t *a64 = a, *b64 = b, *b_mask64 = b_mask;
+
+       return (a64[0] != (b64[0] & b_mask64[0])) ||
+               (a64[1] != (b64[1] & b_mask64[1]));
+}
+
+static void
+keycpy(void *dst, void *src, void *src_mask)
+{
+       uint64_t *dst64 = dst, *src64 = src, *src_mask64 = src_mask;
+
+       dst64[0] = src64[0] & src_mask64[0];
+       dst64[1] = src64[1] & src_mask64[1];
+}
+
+static int
+check_params_create(struct rte_table_hash_params *params)
+{
+       /* name */
+       if (params->name == NULL) {
+               RTE_LOG(ERR, TABLE, "%s: name invalid value\n", __func__);
+               return -EINVAL;
+       }
+
+       /* key_size */
+       if (params->key_size != KEY_SIZE) {
+               RTE_LOG(ERR, TABLE, "%s: key_size invalid value\n", __func__);
+               return -EINVAL;
+       }
+
+       /* n_keys */
+       if (params->n_keys == 0) {
+               RTE_LOG(ERR, TABLE, "%s: n_keys is zero\n", __func__);
+               return -EINVAL;
+       }
+
+       /* n_buckets */
+       if ((params->n_buckets == 0) ||
+               (!rte_is_power_of_2(params->n_buckets))) {
+               RTE_LOG(ERR, TABLE, "%s: n_buckets invalid value\n", __func__);
                return -EINVAL;
        }
 
        /* f_hash */
        if (params->f_hash == NULL) {
-               RTE_LOG(ERR, TABLE,
-                       "%s: f_hash function pointer is NULL\n", __func__);
+               RTE_LOG(ERR, TABLE, "%s: f_hash function pointer is NULL\n",
+                       __func__);
                return -EINVAL;
        }
 
@@ -121,46 +130,67 @@ rte_table_hash_create_key16_lru(void *params,
                int socket_id,
                uint32_t entry_size)
 {
-       struct rte_table_hash_key16_lru_params *p =
-                       (struct rte_table_hash_key16_lru_params *) params;
+       struct rte_table_hash_params *p = params;
        struct rte_table_hash *f;
-       uint32_t n_buckets, n_entries_per_bucket,
-                       key_size, bucket_size_cl, total_size, i;
+       uint64_t bucket_size, total_size;
+       uint32_t n_buckets, i;
 
        /* Check input parameters */
-       if ((check_params_create_lru(p) != 0) ||
+       if ((check_params_create(p) != 0) ||
                ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) ||
-               ((sizeof(struct rte_bucket_4_16) % RTE_CACHE_LINE_SIZE) != 0))
+               ((sizeof(struct rte_bucket_4_16) % 64) != 0))
                return NULL;
-       n_entries_per_bucket = 4;
-       key_size = 16;
+
+       /*
+        * Table dimensioning
+        *
+        * Objective: Pick the number of buckets (n_buckets) so that there a chance
+        * to store n_keys keys in the table.
+        *
+        * Note: Since the buckets do not get extended, it is not possible to
+        * guarantee that n_keys keys can be stored in the table at any time. In the
+        * worst case scenario when all the n_keys fall into the same bucket, only
+        * a maximum of KEYS_PER_BUCKET keys will be stored in the table. This case
+        * defeats the purpose of the hash table. It indicates unsuitable f_hash or
+        * n_keys to n_buckets ratio.
+        *
+        * MIN(n_buckets) = (n_keys + KEYS_PER_BUCKET - 1) / KEYS_PER_BUCKET
+        */
+       n_buckets = rte_align32pow2(
+               (p->n_keys + KEYS_PER_BUCKET - 1) / KEYS_PER_BUCKET);
+       n_buckets = RTE_MAX(n_buckets, p->n_buckets);
 
        /* Memory allocation */
-       n_buckets = rte_align32pow2((p->n_entries + n_entries_per_bucket - 1) /
-               n_entries_per_bucket);
-       bucket_size_cl = (sizeof(struct rte_bucket_4_16) + n_entries_per_bucket
-               * entry_size + RTE_CACHE_LINE_SIZE - 1) / RTE_CACHE_LINE_SIZE;
-       total_size = sizeof(struct rte_table_hash) + n_buckets *
-               bucket_size_cl * RTE_CACHE_LINE_SIZE;
-
-       f = rte_zmalloc_socket("TABLE", total_size, RTE_CACHE_LINE_SIZE, socket_id);
+       bucket_size = RTE_CACHE_LINE_ROUNDUP(sizeof(struct rte_bucket_4_16) +
+               KEYS_PER_BUCKET * entry_size);
+       total_size = sizeof(struct rte_table_hash) + n_buckets * bucket_size;
+
+       if (total_size > SIZE_MAX) {
+               RTE_LOG(ERR, TABLE, "%s: Cannot allocate %" PRIu64 " bytes "
+               "for hash table %s\n",
+               __func__, total_size, p->name);
+               return NULL;
+       }
+
+       f = rte_zmalloc_socket(p->name,
+               (size_t)total_size,
+               RTE_CACHE_LINE_SIZE,
+               socket_id);
        if (f == NULL) {
-               RTE_LOG(ERR, TABLE,
-               "%s: Cannot allocate %u bytes for hash table\n",
-               __func__, total_size);
+               RTE_LOG(ERR, TABLE, "%s: Cannot allocate %" PRIu64 " bytes "
+               "for hash table %s\n",
+               __func__, total_size, p->name);
                return NULL;
        }
-       RTE_LOG(INFO, TABLE,
-               "%s: Hash table memory footprint is %u bytes\n",
-               __func__, total_size);
+       RTE_LOG(INFO, TABLE, "%s: Hash table %s memory footprint "
+               "is %" PRIu64 " bytes\n",
+               __func__, p->name, total_size);
 
        /* Memory initialization */
        f->n_buckets = n_buckets;
-       f->n_entries_per_bucket = n_entries_per_bucket;
-       f->key_size = key_size;
+       f->key_size = KEY_SIZE;
        f->entry_size = entry_size;
-       f->bucket_size = bucket_size_cl * RTE_CACHE_LINE_SIZE;
-       f->signature_offset = p->signature_offset;
+       f->bucket_size = bucket_size;
        f->key_offset = p->key_offset;
        f->f_hash = p->f_hash;
        f->seed = p->seed;
@@ -187,7 +217,7 @@ rte_table_hash_create_key16_lru(void *params,
 static int
 rte_table_hash_free_key16_lru(void *table)
 {
-       struct rte_table_hash *f = (struct rte_table_hash *) table;
+       struct rte_table_hash *f = table;
 
        /* Check input parameters */
        if (f == NULL) {
@@ -207,24 +237,24 @@ rte_table_hash_entry_add_key16_lru(
        int *key_found,
        void **entry_ptr)
 {
-       struct rte_table_hash *f = (struct rte_table_hash *) table;
+       struct rte_table_hash *f = table;
        struct rte_bucket_4_16 *bucket;
        uint64_t signature, pos;
        uint32_t bucket_index, i;
 
-       signature = f->f_hash(key, f->key_size, f->seed);
+       signature = f->f_hash(key, f->key_mask, f->key_size, f->seed);
        bucket_index = signature & (f->n_buckets - 1);
        bucket = (struct rte_bucket_4_16 *)
-                       &f->memory[bucket_index * f->bucket_size];
+               &f->memory[bucket_index * f->bucket_size];
        signature |= RTE_BUCKET_ENTRY_VALID;
 
        /* Key is present in the bucket */
        for (i = 0; i < 4; i++) {
                uint64_t bucket_signature = bucket->signature[i];
-               uint8_t *bucket_key = (uint8_t *) bucket->key[i];
+               uint8_t *bucket_key = (uint8_t *) &bucket->key[i];
 
                if ((bucket_signature == signature) &&
-                               (memcmp(key, bucket_key, f->key_size) == 0)) {
+                       (keycmp(bucket_key, key, f->key_mask) == 0)) {
                        uint8_t *bucket_data = &bucket->data[i * f->entry_size];
 
                        memcpy(bucket_data, entry, f->entry_size);
@@ -238,13 +268,13 @@ rte_table_hash_entry_add_key16_lru(
        /* Key is not present in the bucket */
        for (i = 0; i < 4; i++) {
                uint64_t bucket_signature = bucket->signature[i];
-               uint8_t *bucket_key = (uint8_t *) bucket->key[i];
+               uint8_t *bucket_key = (uint8_t *) &bucket->key[i];
 
                if (bucket_signature == 0) {
                        uint8_t *bucket_data = &bucket->data[i * f->entry_size];
 
                        bucket->signature[i] = signature;
-                       memcpy(bucket_key, key, f->key_size);
+                       keycpy(bucket_key, key, f->key_mask);
                        memcpy(bucket_data, entry, f->entry_size);
                        lru_update(bucket, i);
                        *key_found = 0;
@@ -257,7 +287,7 @@ rte_table_hash_entry_add_key16_lru(
        /* Bucket full: replace LRU entry */
        pos = lru_pos(bucket);
        bucket->signature[pos] = signature;
-       memcpy(bucket->key[pos], key, f->key_size);
+       keycpy(&bucket->key[pos], key, f->key_mask);
        memcpy(&bucket->data[pos * f->entry_size], entry, f->entry_size);
        lru_update(bucket, pos);
        *key_found = 0;
@@ -273,24 +303,24 @@ rte_table_hash_entry_delete_key16_lru(
        int *key_found,
        void *entry)
 {
-       struct rte_table_hash *f = (struct rte_table_hash *) table;
+       struct rte_table_hash *f = table;
        struct rte_bucket_4_16 *bucket;
        uint64_t signature;
        uint32_t bucket_index, i;
 
-       signature = f->f_hash(key, f->key_size, f->seed);
+       signature = f->f_hash(key, f->key_mask, f->key_size, f->seed);
        bucket_index = signature & (f->n_buckets - 1);
        bucket = (struct rte_bucket_4_16 *)
-                       &f->memory[bucket_index * f->bucket_size];
+               &f->memory[bucket_index * f->bucket_size];
        signature |= RTE_BUCKET_ENTRY_VALID;
 
        /* Key is present in the bucket */
        for (i = 0; i < 4; i++) {
                uint64_t bucket_signature = bucket->signature[i];
-               uint8_t *bucket_key = (uint8_t *) bucket->key[i];
+               uint8_t *bucket_key = (uint8_t *) &bucket->key[i];
 
                if ((bucket_signature == signature) &&
-                               (memcmp(key, bucket_key, f->key_size) == 0)) {
+                       (keycmp(bucket_key, key, f->key_mask) == 0)) {
                        uint8_t *bucket_data = &bucket->data[i * f->entry_size];
 
                        bucket->signature[i] = 0;
@@ -306,81 +336,71 @@ rte_table_hash_entry_delete_key16_lru(
        return 0;
 }
 
-static int
-check_params_create_ext(struct rte_table_hash_key16_ext_params *params) {
-       /* n_entries */
-       if (params->n_entries == 0) {
-               RTE_LOG(ERR, TABLE, "%s: n_entries is zero\n", __func__);
-               return -EINVAL;
-       }
-
-       /* n_entries_ext */
-       if (params->n_entries_ext == 0) {
-               RTE_LOG(ERR, TABLE, "%s: n_entries_ext is zero\n", __func__);
-               return -EINVAL;
-       }
-
-       /* f_hash */
-       if (params->f_hash == NULL) {
-               RTE_LOG(ERR, TABLE,
-                       "%s: f_hash function pointer is NULL\n", __func__);
-               return -EINVAL;
-       }
-
-       return 0;
-}
-
 static void *
 rte_table_hash_create_key16_ext(void *params,
                int socket_id,
                uint32_t entry_size)
 {
-       struct rte_table_hash_key16_ext_params *p =
-                       (struct rte_table_hash_key16_ext_params *) params;
+       struct rte_table_hash_params *p = params;
        struct rte_table_hash *f;
-       uint32_t n_buckets, n_buckets_ext, n_entries_per_bucket, key_size,
-                       bucket_size_cl, stack_size_cl, total_size, i;
+       uint64_t bucket_size, stack_size, total_size;
+       uint32_t n_buckets_ext, i;
 
        /* Check input parameters */
-       if ((check_params_create_ext(p) != 0) ||
+       if ((check_params_create(p) != 0) ||
                ((sizeof(struct rte_table_hash) % RTE_CACHE_LINE_SIZE) != 0) ||
-               ((sizeof(struct rte_bucket_4_16) % RTE_CACHE_LINE_SIZE) != 0))
+               ((sizeof(struct rte_bucket_4_16) % 64) != 0))
                return NULL;
 
-       n_entries_per_bucket = 4;
-       key_size = 16;
+       /*
+        * Table dimensioning
+        *
+        * Objective: Pick the number of bucket extensions (n_buckets_ext) so that
+        * it is guaranteed that n_keys keys can be stored in the table at any time.
+        *
+        * The worst case scenario takes place when all the n_keys keys fall into
+        * the same bucket. Actually, due to the KEYS_PER_BUCKET scheme, the worst
+        * case takes place when (n_keys - KEYS_PER_BUCKET + 1) keys fall into the
+        * same bucket, while the remaining (KEYS_PER_BUCKET - 1) keys each fall
+        * into a different bucket. This case defeats the purpose of the hash table.
+        * It indicates unsuitable f_hash or n_keys to n_buckets ratio.
+        *
+        * n_buckets_ext = n_keys / KEYS_PER_BUCKET + KEYS_PER_BUCKET - 1
+        */
+       n_buckets_ext = p->n_keys / KEYS_PER_BUCKET + KEYS_PER_BUCKET - 1;
 
        /* Memory allocation */
-       n_buckets = rte_align32pow2((p->n_entries + n_entries_per_bucket - 1) /
-               n_entries_per_bucket);
-       n_buckets_ext = (p->n_entries_ext + n_entries_per_bucket - 1) /
-               n_entries_per_bucket;
-       bucket_size_cl = (sizeof(struct rte_bucket_4_16) + n_entries_per_bucket
-               * entry_size + RTE_CACHE_LINE_SIZE - 1) / RTE_CACHE_LINE_SIZE;
-       stack_size_cl = (n_buckets_ext * sizeof(uint32_t) + RTE_CACHE_LINE_SIZE - 1)
-               / RTE_CACHE_LINE_SIZE;
+       bucket_size = RTE_CACHE_LINE_ROUNDUP(sizeof(struct rte_bucket_4_16) +
+               KEYS_PER_BUCKET * entry_size);
+       stack_size = RTE_CACHE_LINE_ROUNDUP(n_buckets_ext * sizeof(uint32_t));
        total_size = sizeof(struct rte_table_hash) +
-               ((n_buckets + n_buckets_ext) * bucket_size_cl + stack_size_cl) *
-               RTE_CACHE_LINE_SIZE;
+               (p->n_buckets + n_buckets_ext) * bucket_size + stack_size;
+       if (total_size > SIZE_MAX) {
+               RTE_LOG(ERR, TABLE, "%s: Cannot allocate %" PRIu64 " bytes "
+                       "for hash table %s\n",
+                       __func__, total_size, p->name);
+               return NULL;
+       }
 
-       f = rte_zmalloc_socket("TABLE", total_size, RTE_CACHE_LINE_SIZE, socket_id);
+       f = rte_zmalloc_socket(p->name,
+               (size_t)total_size,
+               RTE_CACHE_LINE_SIZE,
+               socket_id);
        if (f == NULL) {
-               RTE_LOG(ERR, TABLE,
-                       "%s: Cannot allocate %u bytes for hash table\n",
-                       __func__, total_size);
+               RTE_LOG(ERR, TABLE, "%s: Cannot allocate %" PRIu64 " bytes "
+                       "for hash table %s\n",
+                       __func__, total_size, p->name);
                return NULL;
        }
-       RTE_LOG(INFO, TABLE,
-               "%s: Hash table memory footprint is %u bytes\n",
-               __func__, total_size);
+       RTE_LOG(INFO, TABLE, "%s: Hash table %s memory footprint "
+               "is %" PRIu64 " bytes\n",
+               __func__, p->name, total_size);
 
        /* Memory initialization */
-       f->n_buckets = n_buckets;
-       f->n_entries_per_bucket = n_entries_per_bucket;
-       f->key_size = key_size;
+       f->n_buckets = p->n_buckets;
+       f->key_size = KEY_SIZE;
        f->entry_size = entry_size;
-       f->bucket_size = bucket_size_cl * RTE_CACHE_LINE_SIZE;
-       f->signature_offset = p->signature_offset;
+       f->bucket_size = bucket_size;
        f->key_offset = p->key_offset;
        f->f_hash = p->f_hash;
        f->seed = p->seed;
@@ -388,10 +408,7 @@ rte_table_hash_create_key16_ext(void *params,
        f->n_buckets_ext = n_buckets_ext;
        f->stack_pos = n_buckets_ext;
        f->stack = (uint32_t *)
-               &f->memory[(n_buckets + n_buckets_ext) * f->bucket_size];
-
-       for (i = 0; i < n_buckets_ext; i++)
-               f->stack[i] = i;
+               &f->memory[(p->n_buckets + n_buckets_ext) * f->bucket_size];
 
        if (p->key_mask != NULL) {
                f->key_mask[0] = (((uint64_t *)p->key_mask)[0]);
@@ -401,13 +418,16 @@ rte_table_hash_create_key16_ext(void *params,
                f->key_mask[1] = 0xFFFFFFFFFFFFFFFFLLU;
        }
 
+       for (i = 0; i < n_buckets_ext; i++)
+               f->stack[i] = i;
+
        return f;
 }
 
 static int
 rte_table_hash_free_key16_ext(void *table)
 {
-       struct rte_table_hash *f = (struct rte_table_hash *) table;
+       struct rte_table_hash *f = table;
 
        /* Check input parameters */
        if (f == NULL) {
@@ -427,25 +447,25 @@ rte_table_hash_entry_add_key16_ext(
        int *key_found,
        void **entry_ptr)
 {
-       struct rte_table_hash *f = (struct rte_table_hash *) table;
+       struct rte_table_hash *f = table;
        struct rte_bucket_4_16 *bucket0, *bucket, *bucket_prev;
        uint64_t signature;
        uint32_t bucket_index, i;
 
-       signature = f->f_hash(key, f->key_size, f->seed);
+       signature = f->f_hash(key, f->key_mask, f->key_size, f->seed);
        bucket_index = signature & (f->n_buckets - 1);
        bucket0 = (struct rte_bucket_4_16 *)
-                       &f->memory[bucket_index * f->bucket_size];
+               &f->memory[bucket_index * f->bucket_size];
        signature |= RTE_BUCKET_ENTRY_VALID;
 
        /* Key is present in the bucket */
        for (bucket = bucket0; bucket != NULL; bucket = bucket->next)
                for (i = 0; i < 4; i++) {
                        uint64_t bucket_signature = bucket->signature[i];
-                       uint8_t *bucket_key = (uint8_t *) bucket->key[i];
+                       uint8_t *bucket_key = (uint8_t *) &bucket->key[i];
 
                        if ((bucket_signature == signature) &&
-                               (memcmp(key, bucket_key, f->key_size) == 0)) {
+                               (keycmp(bucket_key, key, f->key_mask) == 0)) {
                                uint8_t *bucket_data = &bucket->data[i *
                                        f->entry_size];
 
@@ -458,17 +478,17 @@ rte_table_hash_entry_add_key16_ext(
 
        /* Key is not present in the bucket */
        for (bucket_prev = NULL, bucket = bucket0; bucket != NULL;
-                        bucket_prev = bucket, bucket = bucket->next)
+               bucket_prev = bucket, bucket = bucket->next)
                for (i = 0; i < 4; i++) {
                        uint64_t bucket_signature = bucket->signature[i];
-                       uint8_t *bucket_key = (uint8_t *) bucket->key[i];
+                       uint8_t *bucket_key = (uint8_t *) &bucket->key[i];
 
                        if (bucket_signature == 0) {
                                uint8_t *bucket_data = &bucket->data[i *
                                        f->entry_size];
 
                                bucket->signature[i] = signature;
-                               memcpy(bucket_key, key, f->key_size);
+                               keycpy(bucket_key, key, f->key_mask);
                                memcpy(bucket_data, entry, f->entry_size);
                                *key_found = 0;
                                *entry_ptr = (void *) bucket_data;
@@ -487,7 +507,7 @@ rte_table_hash_entry_add_key16_ext(
                bucket_prev->next_valid = 1;
 
                bucket->signature[0] = signature;
-               memcpy(bucket->key[0], key, f->key_size);
+               keycpy(&bucket->key[0], key, f->key_mask);
                memcpy(&bucket->data[0], entry, f->entry_size);
                *key_found = 0;
                *entry_ptr = (void *) &bucket->data[0];
@@ -504,12 +524,12 @@ rte_table_hash_entry_delete_key16_ext(
        int *key_found,
        void *entry)
 {
-       struct rte_table_hash *f = (struct rte_table_hash *) table;
+       struct rte_table_hash *f = table;
        struct rte_bucket_4_16 *bucket0, *bucket, *bucket_prev;
        uint64_t signature;
        uint32_t bucket_index, i;
 
-       signature = f->f_hash(key, f->key_size, f->seed);
+       signature = f->f_hash(key, f->key_mask, f->key_size, f->seed);
        bucket_index = signature & (f->n_buckets - 1);
        bucket0 = (struct rte_bucket_4_16 *)
                &f->memory[bucket_index * f->bucket_size];
@@ -520,18 +540,17 @@ rte_table_hash_entry_delete_key16_ext(
                bucket_prev = bucket, bucket = bucket->next)
                for (i = 0; i < 4; i++) {
                        uint64_t bucket_signature = bucket->signature[i];
-                       uint8_t *bucket_key = (uint8_t *) bucket->key[i];
+                       uint8_t *bucket_key = (uint8_t *) &bucket->key[i];
 
                        if ((bucket_signature == signature) &&
-                               (memcmp(key, bucket_key, f->key_size) == 0)) {
+                               (keycmp(bucket_key, key, f->key_mask) == 0)) {
                                uint8_t *bucket_data = &bucket->data[i *
                                        f->entry_size];
 
                                bucket->signature[i] = 0;
                                *key_found = 1;
                                if (entry)
-                                       memcpy(entry, bucket_data,
-                                       f->entry_size);
+                                       memcpy(entry, bucket_data, f->entry_size);
 
                                if ((bucket->signature[0] == 0) &&
                                        (bucket->signature[1] == 0) &&
@@ -558,26 +577,28 @@ rte_table_hash_entry_delete_key16_ext(
        return 0;
 }
 
-#define lookup_key16_cmp(key_in, bucket, pos)                  \
+#define lookup_key16_cmp(key_in, bucket, pos, f)                       \
 {                                                              \
-       uint64_t xor[4][2], or[4], signature[4];                \
+       uint64_t xor[4][2], or[4], signature[4], k[2];          \
                                                                \
+       k[0] = key_in[0] & f->key_mask[0];                              \
+       k[1] = key_in[1] & f->key_mask[1];                              \
        signature[0] = (~bucket->signature[0]) & 1;             \
        signature[1] = (~bucket->signature[1]) & 1;             \
        signature[2] = (~bucket->signature[2]) & 1;             \
        signature[3] = (~bucket->signature[3]) & 1;             \
                                                                \
-       xor[0][0] = key_in[0] ^  bucket->key[0][0];             \
-       xor[0][1] = key_in[1] ^  bucket->key[0][1];             \
+       xor[0][0] = k[0] ^ bucket->key[0][0];                   \
+       xor[0][1] = k[1] ^ bucket->key[0][1];                   \
                                                                \
-       xor[1][0] = key_in[0] ^  bucket->key[1][0];             \
-       xor[1][1] = key_in[1] ^  bucket->key[1][1];             \
+       xor[1][0] = k[0] ^ bucket->key[1][0];                   \
+       xor[1][1] = k[1] ^ bucket->key[1][1];                   \
                                                                \
-       xor[2][0] = key_in[0] ^  bucket->key[2][0];             \
-       xor[2][1] = key_in[1] ^  bucket->key[2][1];             \
+       xor[2][0] = k[0] ^ bucket->key[2][0];                   \
+       xor[2][1] = k[1] ^ bucket->key[2][1];                   \
                                                                \
-       xor[3][0] = key_in[0] ^  bucket->key[3][0];             \
-       xor[3][1] = key_in[1] ^  bucket->key[3][1];             \
+       xor[3][0] = k[0] ^ bucket->key[3][0];                   \
+       xor[3][1] = k[1] ^ bucket->key[3][1];                   \
                                                                \
        or[0] = xor[0][0] | xor[0][1] | signature[0];           \
        or[1] = xor[1][0] | xor[1][1] | signature[1];           \
@@ -595,24 +616,28 @@ rte_table_hash_entry_delete_key16_ext(
                pos = 3;                                        \
 }
 
-#define lookup1_stage0(pkt0_index, mbuf0, pkts, pkts_mask)     \
+#define lookup1_stage0(pkt0_index, mbuf0, pkts, pkts_mask, f)  \
 {                                                              \
        uint64_t pkt_mask;                                      \
+       uint32_t key_offset = f->key_offset;\
                                                                \
        pkt0_index = __builtin_ctzll(pkts_mask);                \
        pkt_mask = 1LLU << pkt0_index;                          \
        pkts_mask &= ~pkt_mask;                                 \
                                                                \
        mbuf0 = pkts[pkt0_index];                               \
-       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf0, 0));   \
+       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf0, key_offset));\
 }
 
 #define lookup1_stage1(mbuf1, bucket1, f)                      \
 {                                                              \
-       uint64_t signature;                                     \
-       uint32_t bucket_index;                                  \
+       uint64_t *key;                                          \
+       uint64_t signature = 0;                         \
+       uint32_t bucket_index;                          \
+                                                               \
+       key = RTE_MBUF_METADATA_UINT64_PTR(mbuf1, f->key_offset);\
+       signature = f->f_hash(key, f->key_mask, KEY_SIZE, f->seed);     \
                                                                \
-       signature = RTE_MBUF_METADATA_UINT32(mbuf1, f->signature_offset);\
        bucket_index = signature & (f->n_buckets - 1);          \
        bucket1 = (struct rte_bucket_4_16 *)                    \
                &f->memory[bucket_index * f->bucket_size];      \
@@ -626,14 +651,10 @@ rte_table_hash_entry_delete_key16_ext(
        void *a;                                                \
        uint64_t pkt_mask;                                      \
        uint64_t *key;                                          \
-       uint64_t hash_key_buffer[2];            \
        uint32_t pos;                                           \
                                                                \
        key = RTE_MBUF_METADATA_UINT64_PTR(mbuf2, f->key_offset);\
-       hash_key_buffer[0] = key[0] & f->key_mask[0];   \
-       hash_key_buffer[1] = key[1] & f->key_mask[1];   \
-                                                               \
-       lookup_key16_cmp(hash_key_buffer, bucket2, pos);        \
+       lookup_key16_cmp(key, bucket2, pos, f);                 \
                                                                \
        pkt_mask = (bucket2->signature[pos] & 1LLU) << pkt2_index;\
        pkts_mask_out |= pkt_mask;                              \
@@ -651,14 +672,10 @@ rte_table_hash_entry_delete_key16_ext(
        void *a;                                                \
        uint64_t pkt_mask, bucket_mask;                         \
        uint64_t *key;                                          \
-       uint64_t hash_key_buffer[2];            \
        uint32_t pos;                                           \
                                                                \
        key = RTE_MBUF_METADATA_UINT64_PTR(mbuf2, f->key_offset);\
-       hash_key_buffer[0] = key[0] & f->key_mask[0];   \
-       hash_key_buffer[1] = key[1] & f->key_mask[1];   \
-                                                               \
-       lookup_key16_cmp(hash_key_buffer, bucket2, pos);        \
+       lookup_key16_cmp(key, bucket2, pos, f);                 \
                                                                \
        pkt_mask = (bucket2->signature[pos] & 1LLU) << pkt2_index;\
        pkts_mask_out |= pkt_mask;                              \
@@ -681,15 +698,11 @@ rte_table_hash_entry_delete_key16_ext(
        void *a;                                                \
        uint64_t pkt_mask, bucket_mask;                         \
        uint64_t *key;                                          \
-       uint64_t hash_key_buffer[2];            \
        uint32_t pos;                                           \
                                                                \
        bucket = buckets[pkt_index];                            \
        key = keys[pkt_index];                                  \
-       hash_key_buffer[0] = key[0] & f->key_mask[0];   \
-       hash_key_buffer[1] = key[1] & f->key_mask[1];   \
-                                                               \
-       lookup_key16_cmp(hash_key_buffer, bucket, pos); \
+       lookup_key16_cmp(key, bucket, pos, f);                  \
                                                                \
        pkt_mask = (bucket->signature[pos] & 1LLU) << pkt_index;\
        pkts_mask_out |= pkt_mask;                              \
@@ -708,36 +721,38 @@ rte_table_hash_entry_delete_key16_ext(
 }
 
 #define lookup2_stage0(pkt00_index, pkt01_index, mbuf00, mbuf01,\
-               pkts, pkts_mask)                                \
+               pkts, pkts_mask, f)                             \
 {                                                              \
        uint64_t pkt00_mask, pkt01_mask;                        \
+       uint32_t key_offset = f->key_offset;            \
                                                                \
        pkt00_index = __builtin_ctzll(pkts_mask);               \
        pkt00_mask = 1LLU << pkt00_index;                       \
        pkts_mask &= ~pkt00_mask;                               \
                                                                \
        mbuf00 = pkts[pkt00_index];                             \
-       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf00, 0));  \
+       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf00, key_offset));\
                                                                \
        pkt01_index = __builtin_ctzll(pkts_mask);               \
        pkt01_mask = 1LLU << pkt01_index;                       \
        pkts_mask &= ~pkt01_mask;                               \
                                                                \
        mbuf01 = pkts[pkt01_index];                             \
-       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf01, 0));  \
+       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf01, key_offset));\
 }
 
 #define lookup2_stage0_with_odd_support(pkt00_index, pkt01_index,\
-               mbuf00, mbuf01, pkts, pkts_mask)                \
+               mbuf00, mbuf01, pkts, pkts_mask, f)             \
 {                                                              \
        uint64_t pkt00_mask, pkt01_mask;                        \
+       uint32_t key_offset = f->key_offset;            \
                                                                \
        pkt00_index = __builtin_ctzll(pkts_mask);               \
        pkt00_mask = 1LLU << pkt00_index;                       \
        pkts_mask &= ~pkt00_mask;                               \
                                                                \
        mbuf00 = pkts[pkt00_index];                             \
-       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf00, 0));  \
+       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf00, key_offset)); \
                                                                \
        pkt01_index = __builtin_ctzll(pkts_mask);               \
        if (pkts_mask == 0)                                     \
@@ -746,22 +761,25 @@ rte_table_hash_entry_delete_key16_ext(
        pkts_mask &= ~pkt01_mask;                               \
                                                                \
        mbuf01 = pkts[pkt01_index];                             \
-       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf01, 0));  \
+       rte_prefetch0(RTE_MBUF_METADATA_UINT8_PTR(mbuf01, key_offset)); \
 }
 
 #define lookup2_stage1(mbuf10, mbuf11, bucket10, bucket11, f)  \
 {                                                              \
+       uint64_t *key10, *key11;                                        \
        uint64_t signature10, signature11;                      \
-       uint32_t bucket10_index, bucket11_index;                \
+       uint32_t bucket10_index, bucket11_index;        \
                                                                \
-       signature10 = RTE_MBUF_METADATA_UINT32(mbuf10, f->signature_offset);\
+       key10 = RTE_MBUF_METADATA_UINT64_PTR(mbuf10, f->key_offset);\
+       signature10 = f->f_hash(key10, f->key_mask,      KEY_SIZE, f->seed);\
        bucket10_index = signature10 & (f->n_buckets - 1);      \
-       bucket10 = (struct rte_bucket_4_16 *)                   \
+       bucket10 = (struct rte_bucket_4_16 *)                           \
                &f->memory[bucket10_index * f->bucket_size];    \
        rte_prefetch0(bucket10);                                \
        rte_prefetch0((void *)(((uintptr_t) bucket10) + RTE_CACHE_LINE_SIZE));\
                                                                \
-       signature11 = RTE_MBUF_METADATA_UINT32(mbuf11, f->signature_offset);\
+       key11 = RTE_MBUF_METADATA_UINT64_PTR(mbuf11, f->key_offset);\
+       signature11 = f->f_hash(key11, f->key_mask,      KEY_SIZE, f->seed);\
        bucket11_index = signature11 & (f->n_buckets - 1);      \
        bucket11 = (struct rte_bucket_4_16 *)                   \
                &f->memory[bucket11_index * f->bucket_size];    \
@@ -775,19 +793,13 @@ rte_table_hash_entry_delete_key16_ext(
        void *a20, *a21;                                        \
        uint64_t pkt20_mask, pkt21_mask;                        \
        uint64_t *key20, *key21;                                \
-       uint64_t hash_key_buffer20[2];                  \
-       uint64_t hash_key_buffer21[2];                  \
        uint32_t pos20, pos21;                                  \
                                                                \
        key20 = RTE_MBUF_METADATA_UINT64_PTR(mbuf20, f->key_offset);\
        key21 = RTE_MBUF_METADATA_UINT64_PTR(mbuf21, f->key_offset);\
-       hash_key_buffer20[0] = key20[0] & f->key_mask[0];       \
-       hash_key_buffer20[1] = key20[1] & f->key_mask[1];       \
-       hash_key_buffer21[0] = key21[0] & f->key_mask[0];       \
-       hash_key_buffer21[1] = key21[1] & f->key_mask[1];       \
                                                                \
-       lookup_key16_cmp(hash_key_buffer20, bucket20, pos20);   \
-       lookup_key16_cmp(hash_key_buffer21, bucket21, pos21);   \
+       lookup_key16_cmp(key20, bucket20, pos20, f);            \
+       lookup_key16_cmp(key21, bucket21, pos21, f);            \
                                                                \
        pkt20_mask = (bucket20->signature[pos20] & 1LLU) << pkt20_index;\
        pkt21_mask = (bucket21->signature[pos21] & 1LLU) << pkt21_index;\
@@ -810,19 +822,13 @@ rte_table_hash_entry_delete_key16_ext(
        void *a20, *a21;                                        \
        uint64_t pkt20_mask, pkt21_mask, bucket20_mask, bucket21_mask;\
        uint64_t *key20, *key21;                                \
-       uint64_t hash_key_buffer20[2];                  \
-       uint64_t hash_key_buffer21[2];                  \
        uint32_t pos20, pos21;                                  \
                                                                \
        key20 = RTE_MBUF_METADATA_UINT64_PTR(mbuf20, f->key_offset);\
        key21 = RTE_MBUF_METADATA_UINT64_PTR(mbuf21, f->key_offset);\
-       hash_key_buffer20[0] = key20[0] & f->key_mask[0];       \
-       hash_key_buffer20[1] = key20[1] & f->key_mask[1];       \
-       hash_key_buffer21[0] = key21[0] & f->key_mask[0];       \
-       hash_key_buffer21[1] = key21[1] & f->key_mask[1];       \
                                                                \
-       lookup_key16_cmp(hash_key_buffer20, bucket20, pos20);   \
-       lookup_key16_cmp(hash_key_buffer21, bucket21, pos21);   \
+       lookup_key16_cmp(key20, bucket20, pos20, f);    \
+       lookup_key16_cmp(key21, bucket21, pos21, f);    \
                                                                \
        pkt20_mask = (bucket20->signature[pos20] & 1LLU) << pkt20_index;\
        pkt21_mask = (bucket21->signature[pos21] & 1LLU) << pkt21_index;\
@@ -862,6 +868,7 @@ rte_table_hash_lookup_key16_lru(
        uint64_t pkts_mask_out = 0;
 
        __rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);
+
        RTE_TABLE_HASH_KEY16_STATS_PKTS_IN_ADD(f, n_pkts_in);
 
        /* Cannot run the pipeline with less than 5 packets */
@@ -871,14 +878,15 @@ rte_table_hash_lookup_key16_lru(
                        struct rte_mbuf *mbuf;
                        uint32_t pkt_index;
 
-                       lookup1_stage0(pkt_index, mbuf, pkts, pkts_mask);
+                       lookup1_stage0(pkt_index, mbuf, pkts, pkts_mask, f);
                        lookup1_stage1(mbuf, bucket, f);
                        lookup1_stage2_lru(pkt_index, mbuf, bucket,
                                pkts_mask_out, entries, f);
                }
 
                *lookup_hit_mask = pkts_mask_out;
-               RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));
+               RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in -
+                       __builtin_popcountll(pkts_mask_out));
                return 0;
        }
 
@@ -888,7 +896,7 @@ rte_table_hash_lookup_key16_lru(
         */
        /* Pipeline stage 0 */
        lookup2_stage0(pkt00_index, pkt01_index, mbuf00, mbuf01, pkts,
-               pkts_mask);
+               pkts_mask, f);
 
        /* Pipeline feed */
        mbuf10 = mbuf00;
@@ -898,7 +906,7 @@ rte_table_hash_lookup_key16_lru(
 
        /* Pipeline stage 0 */
        lookup2_stage0(pkt00_index, pkt01_index, mbuf00, mbuf01, pkts,
-               pkts_mask);
+               pkts_mask, f);
 
        /* Pipeline stage 1 */
        lookup2_stage1(mbuf10, mbuf11, bucket10, bucket11, f);
@@ -922,7 +930,7 @@ rte_table_hash_lookup_key16_lru(
 
                /* Pipeline stage 0 */
                lookup2_stage0_with_odd_support(pkt00_index, pkt01_index,
-                       mbuf00, mbuf01, pkts, pkts_mask);
+                       mbuf00, mbuf01, pkts, pkts_mask, f);
 
                /* Pipeline stage 1 */
                lookup2_stage1(mbuf10, mbuf11, bucket10, bucket11, f);
@@ -968,9 +976,10 @@ rte_table_hash_lookup_key16_lru(
                bucket20, bucket21, pkts_mask_out, entries, f);
 
        *lookup_hit_mask = pkts_mask_out;
-       RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));
+       RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in -
+               __builtin_popcountll(pkts_mask_out));
        return 0;
-} /* rte_table_hash_lookup_key16_lru() */
+} /* lookup LRU */
 
 static int
 rte_table_hash_lookup_key16_ext(
@@ -990,6 +999,7 @@ rte_table_hash_lookup_key16_ext(
        uint64_t *keys[RTE_PORT_IN_BURST_SIZE_MAX];
 
        __rte_unused uint32_t n_pkts_in = __builtin_popcountll(pkts_mask);
+
        RTE_TABLE_HASH_KEY16_STATS_PKTS_IN_ADD(f, n_pkts_in);
 
        /* Cannot run the pipeline with less than 5 packets */
@@ -999,7 +1009,7 @@ rte_table_hash_lookup_key16_ext(
                        struct rte_mbuf *mbuf;
                        uint32_t pkt_index;
 
-                       lookup1_stage0(pkt_index, mbuf, pkts, pkts_mask);
+                       lookup1_stage0(pkt_index, mbuf, pkts, pkts_mask, f);
                        lookup1_stage1(mbuf, bucket, f);
                        lookup1_stage2_ext(pkt_index, mbuf, bucket,
                                pkts_mask_out, entries, buckets_mask,
@@ -1015,7 +1025,7 @@ rte_table_hash_lookup_key16_ext(
         */
        /* Pipeline stage 0 */
        lookup2_stage0(pkt00_index, pkt01_index, mbuf00, mbuf01, pkts,
-               pkts_mask);
+               pkts_mask, f);
 
        /* Pipeline feed */
        mbuf10 = mbuf00;
@@ -1025,7 +1035,7 @@ rte_table_hash_lookup_key16_ext(
 
        /* Pipeline stage 0 */
        lookup2_stage0(pkt00_index, pkt01_index, mbuf00, mbuf01, pkts,
-               pkts_mask);
+               pkts_mask, f);
 
        /* Pipeline stage 1 */
        lookup2_stage1(mbuf10, mbuf11, bucket10, bucket11, f);
@@ -1049,7 +1059,7 @@ rte_table_hash_lookup_key16_ext(
 
                /* Pipeline stage 0 */
                lookup2_stage0_with_odd_support(pkt00_index, pkt01_index,
-                       mbuf00, mbuf01, pkts, pkts_mask);
+                       mbuf00, mbuf01, pkts, pkts_mask, f);
 
                /* Pipeline stage 1 */
                lookup2_stage1(mbuf10, mbuf11, bucket10, bucket11, f);
@@ -1118,14 +1128,15 @@ grind_next_buckets:
        }
 
        *lookup_hit_mask = pkts_mask_out;
-       RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in - __builtin_popcountll(pkts_mask_out));
+       RTE_TABLE_HASH_KEY16_STATS_PKTS_LOOKUP_MISS(f, n_pkts_in -
+               __builtin_popcountll(pkts_mask_out));
        return 0;
-} /* rte_table_hash_lookup_key16_ext() */
+} /* lookup EXT */
 
 static int
 rte_table_hash_key16_stats_read(void *table, struct rte_table_stats *stats, int clear)
 {
-       struct rte_table_hash *t = (struct rte_table_hash *) table;
+       struct rte_table_hash *t = table;
 
        if (stats != NULL)
                memcpy(stats, &t->stats, sizeof(t->stats));