Based on initial PMD implementations of the flow API, returning the error
structure which may be NULL is useless and always discarded.
Returning the error code instead appears to be much more convenient.
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
return -rte_errno;
if (likely(!!ops->validate))
return ops->validate(dev, attr, pattern, actions, error);
return -rte_errno;
if (likely(!!ops->validate))
return ops->validate(dev, attr, pattern, actions, error);
- rte_flow_error_set(error, ENOSYS, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
- NULL, rte_strerror(ENOSYS));
- return -rte_errno;
+ return -rte_flow_error_set(error, ENOSYS,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, rte_strerror(ENOSYS));
}
/* Create a flow rule on a given port. */
}
/* Create a flow rule on a given port. */
return -rte_errno;
if (likely(!!ops->destroy))
return ops->destroy(dev, flow, error);
return -rte_errno;
if (likely(!!ops->destroy))
return ops->destroy(dev, flow, error);
- rte_flow_error_set(error, ENOSYS, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
- NULL, rte_strerror(ENOSYS));
- return -rte_errno;
+ return -rte_flow_error_set(error, ENOSYS,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, rte_strerror(ENOSYS));
}
/* Destroy all flow rules associated with a port. */
}
/* Destroy all flow rules associated with a port. */
return -rte_errno;
if (likely(!!ops->flush))
return ops->flush(dev, error);
return -rte_errno;
if (likely(!!ops->flush))
return ops->flush(dev, error);
- rte_flow_error_set(error, ENOSYS, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
- NULL, rte_strerror(ENOSYS));
- return -rte_errno;
+ return -rte_flow_error_set(error, ENOSYS,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, rte_strerror(ENOSYS));
}
/* Query an existing flow rule. */
}
/* Query an existing flow rule. */
return -rte_errno;
if (likely(!!ops->query))
return ops->query(dev, flow, action, data, error);
return -rte_errno;
if (likely(!!ops->query))
return ops->query(dev, flow, action, data, error);
- rte_flow_error_set(error, ENOSYS, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
- NULL, rte_strerror(ENOSYS));
- return -rte_errno;
+ return -rte_flow_error_set(error, ENOSYS,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, rte_strerror(ENOSYS));
* Human-readable error message.
*
* @return
* Human-readable error message.
*
* @return
- * Pointer to flow error structure.
-static inline struct rte_flow_error *
rte_flow_error_set(struct rte_flow_error *error,
int code,
enum rte_flow_error_type type,
rte_flow_error_set(struct rte_flow_error *error,
int code,
enum rte_flow_error_type type,