summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
629bccc)
VLAN id is limited to MLX5_MAX_VLAN_IDS which is not verified by the code
before trying to add a new VLAN filter.
Fixes:
272733b5ebfd ("net/mlx5: use flow to enable unicast traffic")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
{
struct priv *priv = dev->data->dev_private;
unsigned int i;
{
struct priv *priv = dev->data->dev_private;
unsigned int i;
priv_lock(priv);
DEBUG("%p: %s VLAN filter ID %" PRIu16,
priv_lock(priv);
DEBUG("%p: %s VLAN filter ID %" PRIu16,
for (i = 0; (i != priv->vlan_filter_n); ++i)
if (priv->vlan_filter[i] == vlan_id)
break;
for (i = 0; (i != priv->vlan_filter_n); ++i)
if (priv->vlan_filter[i] == vlan_id)
break;
+ /* Check if there's room for another VLAN filter. */
+ if (i == RTE_DIM(priv->vlan_filter)) {
+ ret = -ENOMEM;
+ goto out;
+ }
if (i < priv->vlan_filter_n) {
assert(priv->vlan_filter_n != 0);
/* Enabling an existing VLAN filter has no effect. */
if (i < priv->vlan_filter_n) {
assert(priv->vlan_filter_n != 0);
/* Enabling an existing VLAN filter has no effect. */
priv_dev_traffic_restart(priv, dev);
out:
priv_unlock(priv);
priv_dev_traffic_restart(priv, dev);
out:
priv_unlock(priv);