eventdev: fix memory realloc check in port config
authorHarry van Haaren <harry.van.haaren@intel.com>
Mon, 17 Jul 2017 16:09:47 +0000 (17:09 +0100)
committerJerin Jacob <jerin.jacob@caviumnetworks.com>
Thu, 20 Jul 2017 04:19:47 +0000 (07:19 +0300)
This commit fixes the check to use the just reallocated
links_map variable, instead of stale dev->data->links_map.
Later the new variable is written to the dev->data->links_map,
so the stale-ness is only temporary.

Coverity issue: 143456
Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs")

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Reviewed-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
lib/librte_eventdev/rte_eventdev.c

index ca2900c..bbb3805 100644 (file)
@@ -298,7 +298,7 @@ rte_event_dev_port_config(struct rte_eventdev *dev, uint8_t nb_ports)
                        sizeof(dev->data->links_map[0]) * nb_ports *
                        RTE_EVENT_MAX_QUEUES_PER_DEV,
                        RTE_CACHE_LINE_SIZE);
                        sizeof(dev->data->links_map[0]) * nb_ports *
                        RTE_EVENT_MAX_QUEUES_PER_DEV,
                        RTE_CACHE_LINE_SIZE);
-               if (dev->data->links_map == NULL) {
+               if (links_map == NULL) {
                        dev->data->nb_ports = 0;
                        RTE_EDEV_LOG_ERR("failed to realloc mem for port_map,"
                                        "nb_ports %u", nb_ports);
                        dev->data->nb_ports = 0;
                        RTE_EDEV_LOG_ERR("failed to realloc mem for port_map,"
                                        "nb_ports %u", nb_ports);