flow_classify: fix leaking rules on delete
authorOwen Hilyard <ohilyard@iol.unh.edu>
Wed, 23 Jun 2021 17:07:07 +0000 (13:07 -0400)
committerDavid Marchand <david.marchand@redhat.com>
Thu, 24 Jun 2021 13:34:45 +0000 (15:34 +0200)
Rules in a classify table were not freed if the table
had a delete function.

Fixes: be41ac2a330f ("flow_classify: introduce flow classify library")
Cc: stable@dpdk.org
Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
lib/flow_classify/rte_flow_classify.c

index f125267..d3ba2ed 100644 (file)
@@ -579,12 +579,12 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
                                                &rule->u.key.key_del,
                                                &rule->key_found,
                                                &rule->entry);
-
+                               if (ret == 0)
+                                       free(rule);
                                return ret;
                        }
                }
        }
-       free(rule);
        return ret;
 }