test/atomic: fix 128-bit atomic test with many cores
authorDavid Christensen <drc@linux.vnet.ibm.com>
Wed, 8 Sep 2021 17:48:20 +0000 (10:48 -0700)
committerDavid Marchand <david.marchand@redhat.com>
Thu, 14 Oct 2021 15:20:49 +0000 (17:20 +0200)
When checking the results of the rte_atomic128_cmp_exchange() function,
current code compares the values of a uint32_t and a uint64_t variable.
If the number of lcores used by the test is large, or the value of the
iteration count N is increased, the variable size mismatch can cause a
false test failure.  Modify the comparison to compare uint64_t values.

Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange test")
Cc: stable@dpdk.org
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
app/test/test_atomic.c

index f10f555..ce0c259 100644 (file)
@@ -591,7 +591,7 @@ test_atomic(void)
        rte_atomic32_clear(&synchro);
 
        iterations = count128.val[0] - count128.val[1];
-       if (iterations != 4*N*(rte_lcore_count()-1)) {
+       if (iterations != (uint64_t)4*N*(rte_lcore_count()-1)) {
                printf("128-bit compare and swap failed\n");
                return -1;
        }