net/enic: add an assert macro
authorJohn Daley <johndale@cisco.com>
Fri, 3 Jun 2016 00:22:55 +0000 (17:22 -0700)
committerBruce Richardson <bruce.richardson@intel.com>
Wed, 15 Jun 2016 15:13:56 +0000 (17:13 +0200)
Add an ASSERT macro for the enic driver which is enabled when the log
level is >= RTE_LOG_DEBUG. Assert that number of mbufs to return to
the pool in the Tx function is never greater than the max allowed.

Signed-off-by: John Daley <johndale@cisco.com>
drivers/net/enic/enic.h
drivers/net/enic/enic_rxtx.c

index 4eb28ee..4b76e6d 100644 (file)
@@ -187,6 +187,18 @@ enic_ring_incr(uint32_t n_descriptors, uint32_t idx)
        return idx;
 }
 
+#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#define ENIC_ASSERT(cond)                              \
+       do {                                                            \
+               if (unlikely(!(cond))) {                                \
+                       rte_panic("line %d\tassert \"" #cond "\""       \
+                                       "failed\n", __LINE__);          \
+               }                                                       \
+       } while (0)
+#else
+#define ENIC_ASSERT(cond) do {} while (0)
+#endif
+
 extern void enic_fdir_stats_get(struct enic *enic,
        struct rte_eth_fdir_stats *stats);
 extern int enic_fdir_add_fltr(struct enic *enic,
index 98d93bb..b971325 100644 (file)
@@ -343,6 +343,7 @@ static inline void enic_free_wq_bufs(struct vnic_wq *wq, u16 completed_index)
                buf = &wq->bufs[tail_idx];
                m = (struct rte_mbuf *)(buf->mb);
                if (likely(m->pool == pool)) {
+                       ENIC_ASSERT(nb_free < ENIC_MAX_WQ_DESCS);
                        free[nb_free++] = m;
                } else {
                        rte_mempool_put_bulk(pool, (void *)free, nb_free);