drivers/qat: fix queue pair NUMA node
authorTomasz Jozwiak <tomaszx.jozwiak@intel.com>
Tue, 26 Mar 2019 14:20:48 +0000 (15:20 +0100)
committerAkhil Goyal <akhil.goyal@nxp.com>
Tue, 2 Apr 2019 14:50:24 +0000 (16:50 +0200)
This patch assigns QAT queue pair resources to the correct NUMA nodes.
Any DMA'able memory should use NUMA node of QAT device
rather than socket_id of the initializing process.

Fixes: 98c4a35c736f ("crypto/qat: move common qat files to common dir")
Fixes: a795248d740b ("compress/qat: add configure and clear functions")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
drivers/common/qat/qat_qp.c
drivers/compress/qat/qat_comp_pmd.c

index febc2ef..1312152 100644 (file)
@@ -212,16 +212,17 @@ int qat_qp_setup(struct qat_pci_device *qat_dev,
        }
 
        /* Allocate the queue pair data structure. */
-       qp = rte_zmalloc("qat PMD qp metadata",
-                       sizeof(*qp), RTE_CACHE_LINE_SIZE);
+       qp = rte_zmalloc_socket("qat PMD qp metadata",
+                               sizeof(*qp), RTE_CACHE_LINE_SIZE,
+                               qat_qp_conf->socket_id);
        if (qp == NULL) {
                QAT_LOG(ERR, "Failed to alloc mem for qp struct");
                return -ENOMEM;
        }
        qp->nb_descriptors = qat_qp_conf->nb_descriptors;
-       qp->op_cookies = rte_zmalloc("qat PMD op cookie pointer",
+       qp->op_cookies = rte_zmalloc_socket("qat PMD op cookie pointer",
                        qat_qp_conf->nb_descriptors * sizeof(*qp->op_cookies),
-                       RTE_CACHE_LINE_SIZE);
+                       RTE_CACHE_LINE_SIZE, qat_qp_conf->socket_id);
        if (qp->op_cookies == NULL) {
                QAT_LOG(ERR, "Failed to alloc mem for cookie");
                rte_free(qp);
@@ -261,7 +262,8 @@ int qat_qp_setup(struct qat_pci_device *qat_dev,
                qp->op_cookie_pool = rte_mempool_create(op_cookie_pool_name,
                                qp->nb_descriptors,
                                qat_qp_conf->cookie_size, 64, 0,
-                               NULL, NULL, NULL, NULL, qat_qp_conf->socket_id,
+                               NULL, NULL, NULL, NULL,
+                               qat_dev->pci_dev->device.numa_node,
                                0);
        if (!qp->op_cookie_pool) {
                QAT_LOG(ERR, "QAT PMD Cannot create"
@@ -390,7 +392,7 @@ qat_queue_create(struct qat_pci_device *qat_dev, struct qat_queue *queue,
                qp_conf->service_str, "qp_mem",
                queue->hw_bundle_number, queue->hw_queue_number);
        qp_mz = queue_dma_zone_reserve(queue->memz_name, queue_size_bytes,
-                       qp_conf->socket_id);
+                       qat_dev->pci_dev->device.numa_node);
        if (qp_mz == NULL) {
                QAT_LOG(ERR, "Failed to allocate ring memzone");
                return -ENOMEM;
index cf7a9e8..1d9d72e 100644 (file)
@@ -276,7 +276,8 @@ qat_comp_setup_inter_buffers(struct qat_comp_dev_private *comp_dev,
 
 static struct rte_mempool *
 qat_comp_create_xform_pool(struct qat_comp_dev_private *comp_dev,
-                             uint32_t num_elements)
+                          struct rte_compressdev_config *config,
+                          uint32_t num_elements)
 {
        char xform_pool_name[RTE_MEMPOOL_NAMESIZE];
        struct rte_mempool *mp;
@@ -301,7 +302,7 @@ qat_comp_create_xform_pool(struct qat_comp_dev_private *comp_dev,
                mp = rte_mempool_create(xform_pool_name,
                                num_elements,
                                qat_comp_xform_size(), 0, 0,
-                               NULL, NULL, NULL, NULL, rte_socket_id(),
+                               NULL, NULL, NULL, NULL, config->socket_id,
                                0);
        if (mp == NULL) {
                QAT_LOG(ERR, "Err creating mempool %s w %d elements of size %d",
@@ -357,7 +358,7 @@ qat_comp_dev_config(struct rte_compressdev *dev,
                }
        }
 
-       comp_dev->xformpool = qat_comp_create_xform_pool(comp_dev,
+       comp_dev->xformpool = qat_comp_create_xform_pool(comp_dev, config,
                                        config->max_nb_priv_xforms);
        if (comp_dev->xformpool == NULL) {