mem: fix alignment of requested virtual areas
authorDariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Wed, 13 Jun 2018 19:08:14 +0000 (21:08 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 12 Jul 2018 22:25:09 +0000 (00:25 +0200)
Although the alignment mechanism works as intended, the
`no_align` bool flag was set incorrectly. We were aligning
buffers that didn't need extra alignment, and weren't
aligning ones that really needed it.

Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
Cc: stable@dpdk.org
Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/common/eal_common_memory.c

index ecc5bb2..261fd77 100644 (file)
@@ -70,7 +70,7 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
         * system page size is the same as requested page size.
         */
        no_align = (requested_addr != NULL &&
-               ((uintptr_t)requested_addr & (page_sz - 1)) == 0) ||
+               ((uintptr_t)requested_addr & (page_sz - 1))) ||
                page_sz == system_page_sz;
 
        do {