net/virtio: fix indirect desc length
authorMarvin Liu <yong.liu@intel.com>
Thu, 15 Oct 2020 05:46:07 +0000 (13:46 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 16 Oct 2020 17:48:19 +0000 (19:48 +0200)
When transmitting indirect descriptors, first desc will store net_hdr
and following descs will be mapped to mbuf segments. Total desc number
will be seg_num plus one. Meaning of variable needed is the number of
used descs in packed ring. This value will always be two for indirect
desc. Now use mbuf segments number for calculating correct desc length.

Fixes: b473061b0e1d ("net/virtio: fix indirect descriptors in packed datapaths")
Cc: stable@dpdk.org
Signed-off-by: Marvin Liu <yong.liu@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
drivers/net/virtio/virtqueue.h

index 8c8ab98..42c4c98 100644 (file)
@@ -698,6 +698,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
        struct virtio_net_hdr *hdr;
        uint16_t prev;
        bool prepend_header = false;
+       uint16_t seg_num = cookie->nb_segs;
 
        id = in_order ? vq->vq_avail_idx : vq->vq_desc_head_idx;
 
@@ -732,7 +733,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
                 */
                start_dp[idx].addr  = txvq->virtio_net_hdr_mem +
                        RTE_PTR_DIFF(&txr[idx].tx_packed_indir, txr);
-               start_dp[idx].len   = (needed + 1) *
+               start_dp[idx].len   = (seg_num + 1) *
                        sizeof(struct vring_packed_desc);
                /* reset flags for indirect desc */
                head_flags = VRING_DESC_F_INDIRECT;