crypto/qat: fix access to uninitialized variable

QAT_LOG() has access to the uninitialized variable "name"

Fixes: 21792c443205 ("crypto/qat: add multi-process handling of driver ID")
Cc: stable@dpdk.org
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>

diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c
index ed8a2a5..a2c8aca 100644 (file)
--- a/drivers/crypto/qat/qat_asym_pmd.c
+++ b/drivers/crypto/qat/qat_asym_pmd.c
@@ -251,6 +251,10 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev,
        struct rte_cryptodev *cryptodev;
        struct qat_asym_dev_private *internals;
 
+       snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s",
+                       qat_pci_dev->name, "asym");
+       QAT_LOG(DEBUG, "Creating QAT ASYM device %s\n", name);
+
        if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
                qat_pci_dev->qat_asym_driver_id =
                                qat_asym_driver_id;
@@ -264,10 +268,6 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev,
                }
        }
 
-       snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s",
-                       qat_pci_dev->name, "asym");
-       QAT_LOG(DEBUG, "Creating QAT ASYM device %s\n", name);
-
        /* Populate subset device to use in cryptodev device creation */
        qat_dev_instance->asym_rte_dev.driver = &cryptodev_qat_asym_driver;
        qat_dev_instance->asym_rte_dev.numa_node =

diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c
index 6da9512..93666fd 100644 (file)
--- a/drivers/crypto/qat/qat_sym_pmd.c
+++ b/drivers/crypto/qat/qat_sym_pmd.c
@@ -330,6 +330,10 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
        const struct rte_cryptodev_capabilities *capabilities;
        uint64_t capa_size;
 
+       snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s",
+                       qat_pci_dev->name, "sym");
+       QAT_LOG(DEBUG, "Creating QAT SYM device %s", name);
+
        /*
         * All processes must use same driver id so they can share sessions.
         * Store driver_id so we can validate that all processes have the same
@@ -349,10 +353,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
                }
        }
 
-       snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s",
-                       qat_pci_dev->name, "sym");
-       QAT_LOG(DEBUG, "Creating QAT SYM device %s", name);
-
        /* Populate subset device to use in cryptodev device creation */
        qat_dev_instance->sym_rte_dev.driver = &cryptodev_qat_sym_driver;
        qat_dev_instance->sym_rte_dev.numa_node =