net/mlx5: fix flow query routine in Direct Verbs
authorViacheslav Ovsiienko <viacheslavo@mellanox.com>
Wed, 14 Nov 2018 13:47:19 +0000 (13:47 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 16 Nov 2018 09:45:38 +0000 (10:45 +0100)
The flow_dv_query() just returns -ENOTSUP value and does not
set provided error parameter structure, that crashes the
port_flow_query(). The patch fixes flow_db_query(), now it
sets an error parameter structure.

Fixes: 684dafe795d0 ("net/mlx5: add flow query abstraction interface")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
drivers/net/mlx5/mlx5_flow_dv.c

index a2edd16..9991cad 100644 (file)
@@ -2275,8 +2275,10 @@ flow_dv_query(struct rte_eth_dev *dev __rte_unused,
              void *data __rte_unused,
              struct rte_flow_error *error __rte_unused)
 {
-       rte_errno = ENOTSUP;
-       return -rte_errno;
+       return rte_flow_error_set(error, ENOTSUP,
+                                 RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+                                 NULL,
+                                 "flow query with DV is not supported");
 }