ethdev: remove error return on RSS hash check
authorFerruh Yigit <ferruh.yigit@intel.com>
Tue, 1 May 2018 13:33:43 +0000 (14:33 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 1 May 2018 15:55:15 +0000 (17:55 +0200)
Many sample applications fail because of
dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()

The sample applications need to be fixed/updated before returning error
on rte_eth_dev_configure() and rte_eth_dev_rss_hash_update().

This patch keeps the error logs but removes returning errors.

Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
lib/librte_ethdev/rte_ethdev.c

index 59810dd..e560524 100644 (file)
@@ -1148,7 +1148,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                                    port_id,
                                    dev_conf->rx_adv_conf.rss_conf.rss_hf,
                                    dev_info.flow_type_rss_offloads);
-               return -EINVAL;
        }
 
        /*
@@ -2789,7 +2788,6 @@ rte_eth_dev_rss_hash_update(uint16_t port_id,
                                    port_id,
                                    rss_conf->rss_hf,
                                    dev_info.flow_type_rss_offloads);
-               return -EINVAL;
        }
        RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rss_hash_update, -ENOTSUP);
        return eth_err(port_id, (*dev->dev_ops->rss_hash_update)(dev,