bbdev: use C11 atomics for device processing counter
authorPhil Yang <phil.yang@arm.com>
Thu, 24 Sep 2020 05:39:26 +0000 (13:39 +0800)
committerDavid Marchand <david.marchand@redhat.com>
Fri, 25 Sep 2020 13:37:55 +0000 (15:37 +0200)
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins
for device processing counter.

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
lib/librte_bbdev/rte_bbdev.c
lib/librte_bbdev/rte_bbdev.h

index a4fdb69..5ba891c 100644 (file)
@@ -210,7 +210,7 @@ rte_bbdev_allocate(const char *name)
                return NULL;
        }
 
-       rte_atomic16_inc(&bbdev->data->process_cnt);
+       __atomic_add_fetch(&bbdev->data->process_cnt, 1, __ATOMIC_RELAXED);
        bbdev->data->dev_id = dev_id;
        bbdev->state = RTE_BBDEV_INITIALIZED;
 
@@ -252,7 +252,8 @@ rte_bbdev_release(struct rte_bbdev *bbdev)
        }
 
        /* clear shared BBDev Data if no process is using the device anymore */
-       if (rte_atomic16_dec_and_test(&bbdev->data->process_cnt))
+       if (__atomic_sub_fetch(&bbdev->data->process_cnt, 1,
+                             __ATOMIC_RELAXED) == 0)
                memset(bbdev->data, 0, sizeof(*bbdev->data));
 
        memset(bbdev, 0, sizeof(*bbdev));
index 5729137..7017124 100644 (file)
@@ -33,7 +33,6 @@ extern "C" {
 #include <string.h>
 
 #include <rte_compat.h>
-#include <rte_atomic.h>
 #include <rte_bus.h>
 #include <rte_cpuflags.h>
 #include <rte_memory.h>
@@ -426,8 +425,7 @@ struct rte_bbdev_data {
        uint16_t dev_id;  /**< Device ID */
        int socket_id;  /**< NUMA socket that device is on */
        bool started;  /**< Device run-time state */
-       /** Counter of processes using the device */
-       rte_atomic16_t process_cnt;
+       uint16_t process_cnt;  /** Counter of processes using the device */
 };
 
 /* Forward declarations */