malloc: check size hint when reserving the biggest element
authorDarek Stojaczyk <dariusz.stojaczyk@intel.com>
Sun, 7 Oct 2018 19:31:47 +0000 (21:31 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Sun, 28 Oct 2018 10:59:02 +0000 (11:59 +0100)
RTE_MEMZONE_SIZE_HINT_ONLY wasn't checked in any way,
causing size hints to be parsed as hard requirements.
This resulted in some allocations being failed prematurely.

Fixes: 68b6092bd3c7 ("malloc: allow reserving biggest element")
Cc: stable@dpdk.org
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/common/malloc_heap.c

index 08ec753..363f306 100644 (file)
@@ -192,7 +192,9 @@ find_biggest_element(struct malloc_heap *heap, size_t *size,
                for (elem = LIST_FIRST(&heap->free_head[idx]);
                                !!elem; elem = LIST_NEXT(elem, free_list)) {
                        size_t cur_size;
-                       if (!check_hugepage_sz(flags, elem->msl->page_sz))
+                       if ((flags & RTE_MEMZONE_SIZE_HINT_ONLY) == 0 &&
+                                       !check_hugepage_sz(flags,
+                                               elem->msl->page_sz))
                                continue;
                        if (contig) {
                                cur_size =