test: skip tests when missing requirements

[dpdk.git] / app / test / test.c

diff --git a/app/test/test.c b/app/test/test.c
index 351c7f2..194a92a 100644 (file)
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -30,13 +30,15 @@ extern cmdline_parse_ctx_t main_ctx[];
 #endif
 
 #include "test.h"
+#ifdef RTE_LIBRTE_PDUMP
 #include "test_pdump.h"
+#endif
 
 #define RTE_LOGTYPE_APP RTE_LOGTYPE_USER1
 
 const char *prgname; /* to be set to argv[0] */
 
-static const char *recursive_call; /* used in linuxapp for MP and other tests */
+static const char *recursive_call; /* used in linux for MP and other tests */
 
 static int
 no_action(void){ return 0; }
@@ -50,7 +52,9 @@ do_recursive_call(void)
                int (*action_fn)(void);
        } actions[] =  {
                        { "run_secondary_instances", test_mp_secondary },
+#ifdef RTE_LIBRTE_PDUMP
                        { "run_pdump_server_tests", test_pdump },
+#endif
                        { "test_missing_c_flag", no_action },
                        { "test_master_lcore_flag", no_action },
                        { "test_invalid_n_flag", no_action },
@@ -63,6 +67,7 @@ do_recursive_call(void)
                        { "test_memory_flags", no_action },
                        { "test_file_prefix", no_action },
                        { "test_no_huge_flag", no_action },
+                       { "timer_secondary_spawn_wait", test_timer_secondary },
        };
 
        if (recursive_call == NULL)
@@ -126,7 +131,10 @@ main(int argc, char **argv)
        }
 
 #ifdef RTE_LIBRTE_TIMER
-       rte_timer_subsystem_init();
+       if (rte_timer_subsystem_init() < 0) {
+               ret = -1;
+               goto out;
+       }
 #endif
 
        if (commands_init() < 0) {
@@ -179,6 +187,9 @@ main(int argc, char **argv)
        ret = 0;
 
 out:
+#ifdef RTE_LIBRTE_TIMER
+       rte_timer_subsystem_finalize();
+#endif
        rte_eal_cleanup();
        return ret;
 }
@@ -197,14 +208,16 @@ unit_test_suite_runner(struct unit_test_suite *suite)
                printf(" + Test Suite : %s\n", suite->suite_name);
        }
 
-       if (suite->setup)
-               if (suite->setup() != 0) {
+       if (suite->setup) {
+               test_success = suite->setup();
+               if (test_success != 0) {
                        /*
-                        * setup failed, so count all enabled tests and mark
-                        * them as failed
+                        * setup did not pass, so count all enabled tests and
+                        * mark them as failed/skipped
                         */
                        while (suite->unit_test_cases[total].testcase) {
-                               if (!suite->unit_test_cases[total].enabled)
+                               if (!suite->unit_test_cases[total].enabled ||
+                                   test_success == TEST_SKIPPED)
                                        skipped++;
                                else
                                        failed++;
@@ -212,6 +225,7 @@ unit_test_suite_runner(struct unit_test_suite *suite)
                        }
                        goto suite_summary;
                }
+       }
 
        printf(" + ------------------------------------------------------- +\n");
 
@@ -235,6 +249,8 @@ unit_test_suite_runner(struct unit_test_suite *suite)
                        test_success = suite->unit_test_cases[total].testcase();
                        if (test_success == TEST_SUCCESS)
                                succeeded++;
+                       else if (test_success == TEST_SKIPPED)
+                               skipped++;
                        else if (test_success == -ENOTSUP)
                                unsupported++;
                        else
@@ -251,6 +267,8 @@ unit_test_suite_runner(struct unit_test_suite *suite)
 
                if (test_success == TEST_SUCCESS)
                        status = "succeeded";
+               else if (test_success == TEST_SKIPPED)
+                       status = "skipped";
                else if (test_success == -ENOTSUP)
                        status = "unsupported";
                else
@@ -282,7 +300,8 @@ suite_summary:
        last_test_result = failed;
 
        if (failed)
-               return -1;
-
-       return 0;
+               return TEST_FAILED;
+       if (total == skipped)
+               return TEST_SKIPPED;
+       return TEST_SUCCESS;
 }