buildtools: make experimental symbol check lighter

[dpdk.git] / buildtools / check-experimental-syms.sh

diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
index 7d21de3..47a06fc 100755 (executable)
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -5,28 +5,53 @@
 MAPFILE=$1
 OBJFILE=$2
 
+LIST_SYMBOL=$RTE_SDK/buildtools/map-list-symbol.sh
+
+# added check for "make -C test/" usage
+if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
+then
+       exit 0
+fi
+
 if [ -d $MAPFILE ]
 then
        exit 0
 fi
 
-for i in `awk 'BEGIN {found=0}
-               /.*EXPERIMENTAL.*/ {found=1}
-               /.*}.*;/ {found=0}
-               /.*;/ {if (found == 1) print $1}' $MAPFILE`
+DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
+trap 'rm -f "$DUMPFILE"' EXIT
+objdump -t $OBJFILE >$DUMPFILE
+
+ret=0
+for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE`
 do
-       SYM=`echo $i | sed -e"s/;//"`
-       objdump -t $OBJFILE | grep -q "\.text.*$SYM"
-       IN_TEXT=$?
-       objdump -t $OBJFILE | grep -q "\.text\.experimental.*$SYM"
-       IN_EXP=$?
-       if [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ]
+       if grep -q "\.text.*$SYM$" $DUMPFILE &&
+               ! grep -q "\.text\.experimental.*$SYM$" $DUMPFILE
        then
-               echo "$SYM is not flagged as experimental"
-               echo "but is listed in version map"
-               echo "Please add __rte_experimental to the definition of $SYM"
-               exit 1
+               cat >&2 <<- END_OF_MESSAGE
+               $SYM is not flagged as experimental
+               but is listed in version map
+               Please add __rte_experimental to the definition of $SYM
+               END_OF_MESSAGE
+               ret=1
        fi
 done
-exit 0
 
+# Filter out symbols suffixed with a . for icc
+for SYM in `awk '{
+       if ($2 != "l" && $4 == ".text.experimental" && !($NF ~ /\.$/)) {
+               print $NF
+       }
+}' $DUMPFILE`
+do
+       $LIST_SYMBOL -S EXPERIMENTAL -s $SYM -q $MAPFILE || {
+               cat >&2 <<- END_OF_MESSAGE
+               $SYM is flagged as experimental
+               but is not listed in version map
+               Please add $SYM to the version map
+               END_OF_MESSAGE
+               ret=1
+       }
+done
+
+exit $ret