buildtools: detect discrepancies for experimental symbols

[dpdk.git] / buildtools / check-experimental-syms.sh

diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
index 7d1f3a5..653756e 100755 (executable)
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -5,6 +5,8 @@
 MAPFILE=$1
 OBJFILE=$2
 
+LIST_SYMBOL=$RTE_SDK/buildtools/map-list-symbol.sh
+
 # added check for "make -C test/" usage
 if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
 then
@@ -16,12 +18,9 @@ then
        exit 0
 fi
 
-for i in `awk 'BEGIN {found=0}
-               /.*EXPERIMENTAL.*/ {found=1}
-               /.*}.*;/ {found=0}
-               /.*;/ {if (found == 1) print $1}' $MAPFILE`
+ret=0
+for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE`
 do
-       SYM=`echo $i | sed -e"s/;//"`
        objdump -t $OBJFILE | grep -q "\.text.*$SYM$"
        IN_TEXT=$?
        objdump -t $OBJFILE | grep -q "\.text\.experimental.*$SYM$"
@@ -33,8 +32,24 @@ do
                but is listed in version map
                Please add __rte_experimental to the definition of $SYM
                END_OF_MESSAGE
-               exit 1
+               ret=1
        fi
 done
-exit 0
 
+for SYM in `objdump -t $OBJFILE |awk '{
+       if ($2 != "l" && $4 == ".text.experimental") {
+               print $NF
+       }
+}'`
+do
+       $LIST_SYMBOL -S EXPERIMENTAL -s $SYM -q $MAPFILE || {
+               cat >&2 <<- END_OF_MESSAGE
+               $SYM is flagged as experimental
+               but is not listed in version map
+               Please add $SYM to the version map
+               END_OF_MESSAGE
+               ret=1
+       }
+done
+
+exit $ret