common/mlx5: fix user mode register access command
[dpdk.git] / drivers / common / mlx5 / mlx5_devx_cmds.c
index 4d94f92..7c81ae1 100644 (file)
@@ -5,17 +5,80 @@
 
 #include <rte_errno.h>
 #include <rte_malloc.h>
+#include <rte_eal_paging.h>
 
 #include "mlx5_prm.h"
 #include "mlx5_devx_cmds.h"
 #include "mlx5_common_utils.h"
+#include "mlx5_malloc.h"
 
 
+/**
+ * Perform read access to the registers. Reads data from register
+ * and writes ones to the specified buffer.
+ *
+ * @param[in] ctx
+ *   Context returned from mlx5 open_device() glue function.
+ * @param[in] reg_id
+ *   Register identifier according to the PRM.
+ * @param[in] arg
+ *   Register access auxiliary parameter according to the PRM.
+ * @param[out] data
+ *   Pointer to the buffer to store read data.
+ * @param[in] dw_cnt
+ *   Buffer size in double words.
+ *
+ * @return
+ *   0 on success, a negative value otherwise.
+ */
+int
+mlx5_devx_cmd_register_read(void *ctx, uint16_t reg_id, uint32_t arg,
+                           uint32_t *data, uint32_t dw_cnt)
+{
+       uint32_t in[MLX5_ST_SZ_DW(access_register_in)]   = {0};
+       uint32_t out[MLX5_ST_SZ_DW(access_register_out) +
+                    MLX5_ACCESS_REGISTER_DATA_DWORD_MAX] = {0};
+       int status, rc;
+
+       MLX5_ASSERT(data && dw_cnt);
+       MLX5_ASSERT(dw_cnt <= MLX5_ACCESS_REGISTER_DATA_DWORD_MAX);
+       if (dw_cnt  > MLX5_ACCESS_REGISTER_DATA_DWORD_MAX) {
+               DRV_LOG(ERR, "Not enough  buffer for register read data");
+               return -1;
+       }
+       MLX5_SET(access_register_in, in, opcode,
+                MLX5_CMD_OP_ACCESS_REGISTER_USER);
+       MLX5_SET(access_register_in, in, op_mod,
+                                       MLX5_ACCESS_REGISTER_IN_OP_MOD_READ);
+       MLX5_SET(access_register_in, in, register_id, reg_id);
+       MLX5_SET(access_register_in, in, argument, arg);
+       rc = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out,
+                                        MLX5_ST_SZ_DW(access_register_out) *
+                                        sizeof(uint32_t) + dw_cnt);
+       if (rc)
+               goto error;
+       status = MLX5_GET(access_register_out, out, status);
+       if (status) {
+               int syndrome = MLX5_GET(access_register_out, out, syndrome);
+
+               DRV_LOG(DEBUG, "Failed to access NIC register 0x%X, "
+                              "status %x, syndrome = %x",
+                              reg_id, status, syndrome);
+               return -1;
+       }
+       memcpy(data, &out[MLX5_ST_SZ_DW(access_register_out)],
+              dw_cnt * sizeof(uint32_t));
+       return 0;
+error:
+       rc = (rc > 0) ? -rc : rc;
+       return rc;
+}
+
 /**
  * Allocate flow counters via devx interface.
  *
  * @param[in] ctx
- *   ibv contexts returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param dcs
  *   Pointer to counters properties structure to be filled by the routine.
  * @param bulk_n_128
  *   rte_errno is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_flow_counter_alloc(struct ibv_context *ctx, uint32_t bulk_n_128)
+mlx5_devx_cmd_flow_counter_alloc(void *ctx, uint32_t bulk_n_128)
 {
-       struct mlx5_devx_obj *dcs = rte_zmalloc("dcs", sizeof(*dcs), 0);
+       struct mlx5_devx_obj *dcs = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*dcs),
+                                               0, SOCKET_ID_ANY);
        uint32_t in[MLX5_ST_SZ_DW(alloc_flow_counter_in)]   = {0};
        uint32_t out[MLX5_ST_SZ_DW(alloc_flow_counter_out)] = {0};
 
@@ -44,7 +108,7 @@ mlx5_devx_cmd_flow_counter_alloc(struct ibv_context *ctx, uint32_t bulk_n_128)
        if (!dcs->obj) {
                DRV_LOG(ERR, "Can't allocate counters - error %d", errno);
                rte_errno = errno;
-               rte_free(dcs);
+               mlx5_free(dcs);
                return NULL;
        }
        dcs->id = MLX5_GET(alloc_flow_counter_out, out, flow_counter_id);
@@ -81,7 +145,7 @@ mlx5_devx_cmd_flow_counter_query(struct mlx5_devx_obj *dcs,
                                 int clear, uint32_t n_counters,
                                 uint64_t *pkts, uint64_t *bytes,
                                 uint32_t mkey, void *addr,
-                                struct mlx5dv_devx_cmd_comp *cmd_comp,
+                                void *cmd_comp,
                                 uint64_t async_id)
 {
        int out_len = MLX5_ST_SZ_BYTES(query_flow_counter_out) +
@@ -130,7 +194,7 @@ mlx5_devx_cmd_flow_counter_query(struct mlx5_devx_obj *dcs,
  * Create a new mkey.
  *
  * @param[in] ctx
- *   ibv contexts returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param[in] attr
  *   Attributes of the requested mkey.
  *
@@ -139,13 +203,18 @@ mlx5_devx_cmd_flow_counter_query(struct mlx5_devx_obj *dcs,
  *   is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_mkey_create(struct ibv_context *ctx,
+mlx5_devx_cmd_mkey_create(void *ctx,
                          struct mlx5_devx_mkey_attr *attr)
 {
-       uint32_t in[MLX5_ST_SZ_DW(create_mkey_in)] = {0};
+       struct mlx5_klm *klm_array = attr->klm_array;
+       int klm_num = attr->klm_num;
+       int in_size_dw = MLX5_ST_SZ_DW(create_mkey_in) +
+                    (klm_num ? RTE_ALIGN(klm_num, 4) : 0) * MLX5_ST_SZ_DW(klm);
+       uint32_t in[in_size_dw];
        uint32_t out[MLX5_ST_SZ_DW(create_mkey_out)] = {0};
        void *mkc;
-       struct mlx5_devx_obj *mkey = rte_zmalloc("mkey", sizeof(*mkey), 0);
+       struct mlx5_devx_obj *mkey = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*mkey),
+                                                0, SOCKET_ID_ANY);
        size_t pgsize;
        uint32_t translation_size;
 
@@ -153,29 +222,64 @@ mlx5_devx_cmd_mkey_create(struct ibv_context *ctx,
                rte_errno = ENOMEM;
                return NULL;
        }
-       pgsize = sysconf(_SC_PAGESIZE);
-       translation_size = (RTE_ALIGN(attr->size, pgsize) * 8) / 16;
+       memset(in, 0, in_size_dw * 4);
+       pgsize = rte_mem_page_size();
+       if (pgsize == (size_t)-1) {
+               mlx5_free(mkey);
+               DRV_LOG(ERR, "Failed to get page size");
+               rte_errno = ENOMEM;
+               return NULL;
+       }
        MLX5_SET(create_mkey_in, in, opcode, MLX5_CMD_OP_CREATE_MKEY);
+       mkc = MLX5_ADDR_OF(create_mkey_in, in, memory_key_mkey_entry);
+       if (klm_num > 0) {
+               int i;
+               uint8_t *klm = (uint8_t *)MLX5_ADDR_OF(create_mkey_in, in,
+                                                      klm_pas_mtt);
+               translation_size = RTE_ALIGN(klm_num, 4);
+               for (i = 0; i < klm_num; i++) {
+                       MLX5_SET(klm, klm, byte_count, klm_array[i].byte_count);
+                       MLX5_SET(klm, klm, mkey, klm_array[i].mkey);
+                       MLX5_SET64(klm, klm, address, klm_array[i].address);
+                       klm += MLX5_ST_SZ_BYTES(klm);
+               }
+               for (; i < (int)translation_size; i++) {
+                       MLX5_SET(klm, klm, mkey, 0x0);
+                       MLX5_SET64(klm, klm, address, 0x0);
+                       klm += MLX5_ST_SZ_BYTES(klm);
+               }
+               MLX5_SET(mkc, mkc, access_mode_1_0, attr->log_entity_size ?
+                        MLX5_MKC_ACCESS_MODE_KLM_FBS :
+                        MLX5_MKC_ACCESS_MODE_KLM);
+               MLX5_SET(mkc, mkc, log_page_size, attr->log_entity_size);
+       } else {
+               translation_size = (RTE_ALIGN(attr->size, pgsize) * 8) / 16;
+               MLX5_SET(mkc, mkc, access_mode_1_0, MLX5_MKC_ACCESS_MODE_MTT);
+               MLX5_SET(mkc, mkc, log_page_size, rte_log2_u32(pgsize));
+       }
        MLX5_SET(create_mkey_in, in, translations_octword_actual_size,
                 translation_size);
        MLX5_SET(create_mkey_in, in, mkey_umem_id, attr->umem_id);
-       mkc = MLX5_ADDR_OF(create_mkey_in, in, memory_key_mkey_entry);
+       MLX5_SET(create_mkey_in, in, pg_access, attr->pg_access);
        MLX5_SET(mkc, mkc, lw, 0x1);
        MLX5_SET(mkc, mkc, lr, 0x1);
-       MLX5_SET(mkc, mkc, access_mode_1_0, MLX5_MKC_ACCESS_MODE_MTT);
        MLX5_SET(mkc, mkc, qpn, 0xffffff);
        MLX5_SET(mkc, mkc, pd, attr->pd);
        MLX5_SET(mkc, mkc, mkey_7_0, attr->umem_id & 0xFF);
        MLX5_SET(mkc, mkc, translations_octword_size, translation_size);
+       if (attr->relaxed_ordering == 1) {
+               MLX5_SET(mkc, mkc, relaxed_ordering_write, 0x1);
+               MLX5_SET(mkc, mkc, relaxed_ordering_read, 0x1);
+       }
        MLX5_SET64(mkc, mkc, start_addr, attr->addr);
        MLX5_SET64(mkc, mkc, len, attr->size);
-       MLX5_SET(mkc, mkc, log_page_size, rte_log2_u32(pgsize));
-       mkey->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out,
+       mkey->obj = mlx5_glue->devx_obj_create(ctx, in, in_size_dw * 4, out,
                                               sizeof(out));
        if (!mkey->obj) {
-               DRV_LOG(ERR, "Can't create mkey - error %d", errno);
+               DRV_LOG(ERR, "Can't create %sdirect mkey - error %d\n",
+                       klm_num ? "an in" : "a ", errno);
                rte_errno = errno;
-               rte_free(mkey);
+               mlx5_free(mkey);
                return NULL;
        }
        mkey->id = MLX5_GET(create_mkey_out, out, mkey_index);
@@ -227,7 +331,7 @@ mlx5_devx_cmd_destroy(struct mlx5_devx_obj *obj)
        if (!obj)
                return 0;
        ret =  mlx5_glue->devx_obj_destroy(obj->obj);
-       rte_free(obj);
+       mlx5_free(obj);
        return ret;
 }
 
@@ -246,7 +350,7 @@ mlx5_devx_cmd_destroy(struct mlx5_devx_obj *obj)
  *   0 on success, a negative value otherwise.
  */
 static int
-mlx5_devx_cmd_query_nic_vport_context(struct ibv_context *ctx,
+mlx5_devx_cmd_query_nic_vport_context(void *ctx,
                                      unsigned int vport,
                                      struct mlx5_hca_attr *attr)
 {
@@ -284,13 +388,254 @@ error:
        return rc;
 }
 
+/**
+ * Query NIC vDPA attributes.
+ *
+ * @param[in] ctx
+ *   Context returned from mlx5 open_device() glue function.
+ * @param[out] vdpa_attr
+ *   vDPA Attributes structure to fill.
+ */
+static void
+mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx,
+                                 struct mlx5_hca_vdpa_attr *vdpa_attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(query_hca_cap_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(query_hca_cap_out)] = {0};
+       void *hcattr = MLX5_ADDR_OF(query_hca_cap_out, out, capability);
+       int status, syndrome, rc;
+
+       MLX5_SET(query_hca_cap_in, in, opcode, MLX5_CMD_OP_QUERY_HCA_CAP);
+       MLX5_SET(query_hca_cap_in, in, op_mod,
+                MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION |
+                MLX5_HCA_CAP_OPMOD_GET_CUR);
+       rc = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out));
+       status = MLX5_GET(query_hca_cap_out, out, status);
+       syndrome = MLX5_GET(query_hca_cap_out, out, syndrome);
+       if (rc || status) {
+               RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA capabilities,"
+                       " status %x, syndrome = %x", status, syndrome);
+               vdpa_attr->valid = 0;
+       } else {
+               vdpa_attr->valid = 1;
+               vdpa_attr->desc_tunnel_offload_type =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                desc_tunnel_offload_type);
+               vdpa_attr->eth_frame_offload_type =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                eth_frame_offload_type);
+               vdpa_attr->virtio_version_1_0 =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                virtio_version_1_0);
+               vdpa_attr->tso_ipv4 = MLX5_GET(virtio_emulation_cap, hcattr,
+                                              tso_ipv4);
+               vdpa_attr->tso_ipv6 = MLX5_GET(virtio_emulation_cap, hcattr,
+                                              tso_ipv6);
+               vdpa_attr->tx_csum = MLX5_GET(virtio_emulation_cap, hcattr,
+                                             tx_csum);
+               vdpa_attr->rx_csum = MLX5_GET(virtio_emulation_cap, hcattr,
+                                             rx_csum);
+               vdpa_attr->event_mode = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                event_mode);
+               vdpa_attr->virtio_queue_type =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                virtio_queue_type);
+               vdpa_attr->log_doorbell_stride =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                log_doorbell_stride);
+               vdpa_attr->log_doorbell_bar_size =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                log_doorbell_bar_size);
+               vdpa_attr->doorbell_bar_offset =
+                       MLX5_GET64(virtio_emulation_cap, hcattr,
+                                  doorbell_bar_offset);
+               vdpa_attr->max_num_virtio_queues =
+                       MLX5_GET(virtio_emulation_cap, hcattr,
+                                max_num_virtio_queues);
+               vdpa_attr->umems[0].a = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                umem_1_buffer_param_a);
+               vdpa_attr->umems[0].b = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                umem_1_buffer_param_b);
+               vdpa_attr->umems[1].a = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                umem_2_buffer_param_a);
+               vdpa_attr->umems[1].b = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                umem_2_buffer_param_b);
+               vdpa_attr->umems[2].a = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                umem_3_buffer_param_a);
+               vdpa_attr->umems[2].b = MLX5_GET(virtio_emulation_cap, hcattr,
+                                                umem_3_buffer_param_b);
+       }
+}
+
+int
+mlx5_devx_cmd_query_parse_samples(struct mlx5_devx_obj *flex_obj,
+                                 uint32_t ids[], uint32_t num)
+{
+       uint32_t in[MLX5_ST_SZ_DW(general_obj_in_cmd_hdr)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(create_flex_parser_out)] = {0};
+       void *hdr = MLX5_ADDR_OF(create_flex_parser_out, in, hdr);
+       void *flex = MLX5_ADDR_OF(create_flex_parser_out, out, flex);
+       void *sample = MLX5_ADDR_OF(parse_graph_flex, flex, sample_table);
+       int ret;
+       uint32_t idx = 0;
+       uint32_t i;
+
+       if (num > MLX5_GRAPH_NODE_SAMPLE_NUM) {
+               rte_errno = EINVAL;
+               DRV_LOG(ERR, "Too many sample IDs to be fetched.");
+               return -rte_errno;
+       }
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_QUERY_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_FLEX_PARSE_GRAPH);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_id, flex_obj->id);
+       ret = mlx5_glue->devx_obj_query(flex_obj->obj, in, sizeof(in),
+                                       out, sizeof(out));
+       if (ret) {
+               rte_errno = ret;
+               DRV_LOG(ERR, "Failed to query sample IDs with object %p.",
+                       (void *)flex_obj);
+               return -rte_errno;
+       }
+       for (i = 0; i < MLX5_GRAPH_NODE_SAMPLE_NUM; i++) {
+               void *s_off = (void *)((char *)sample + i *
+                             MLX5_ST_SZ_BYTES(parse_graph_flow_match_sample));
+               uint32_t en;
+
+               en = MLX5_GET(parse_graph_flow_match_sample, s_off,
+                             flow_match_sample_en);
+               if (!en)
+                       continue;
+               ids[idx++] = MLX5_GET(parse_graph_flow_match_sample, s_off,
+                                 flow_match_sample_field_id);
+       }
+       if (num != idx) {
+               rte_errno = EINVAL;
+               DRV_LOG(ERR, "Number of sample IDs are not as expected.");
+               return -rte_errno;
+       }
+       return ret;
+}
+
+
+struct mlx5_devx_obj *
+mlx5_devx_cmd_create_flex_parser(void *ctx,
+                             struct mlx5_devx_graph_node_attr *data)
+{
+       uint32_t in[MLX5_ST_SZ_DW(create_flex_parser_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0};
+       void *hdr = MLX5_ADDR_OF(create_flex_parser_in, in, hdr);
+       void *flex = MLX5_ADDR_OF(create_flex_parser_in, in, flex);
+       void *sample = MLX5_ADDR_OF(parse_graph_flex, flex, sample_table);
+       void *in_arc = MLX5_ADDR_OF(parse_graph_flex, flex, input_arc);
+       void *out_arc = MLX5_ADDR_OF(parse_graph_flex, flex, output_arc);
+       struct mlx5_devx_obj *parse_flex_obj = NULL;
+       uint32_t i;
+
+       parse_flex_obj = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*parse_flex_obj), 0,
+                                    SOCKET_ID_ANY);
+       if (!parse_flex_obj) {
+               DRV_LOG(ERR, "Failed to allocate flex parser data");
+               rte_errno = ENOMEM;
+               mlx5_free(in);
+               return NULL;
+       }
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_CREATE_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_FLEX_PARSE_GRAPH);
+       MLX5_SET(parse_graph_flex, flex, header_length_mode,
+                data->header_length_mode);
+       MLX5_SET(parse_graph_flex, flex, header_length_base_value,
+                data->header_length_base_value);
+       MLX5_SET(parse_graph_flex, flex, header_length_field_offset,
+                data->header_length_field_offset);
+       MLX5_SET(parse_graph_flex, flex, header_length_field_shift,
+                data->header_length_field_shift);
+       MLX5_SET(parse_graph_flex, flex, header_length_field_mask,
+                data->header_length_field_mask);
+       for (i = 0; i < MLX5_GRAPH_NODE_SAMPLE_NUM; i++) {
+               struct mlx5_devx_match_sample_attr *s = &data->sample[i];
+               void *s_off = (void *)((char *)sample + i *
+                             MLX5_ST_SZ_BYTES(parse_graph_flow_match_sample));
+
+               if (!s->flow_match_sample_en)
+                       continue;
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_en, !!s->flow_match_sample_en);
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_field_offset,
+                        s->flow_match_sample_field_offset);
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_offset_mode,
+                        s->flow_match_sample_offset_mode);
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_field_offset_mask,
+                        s->flow_match_sample_field_offset_mask);
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_field_offset_shift,
+                        s->flow_match_sample_field_offset_shift);
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_field_base_offset,
+                        s->flow_match_sample_field_base_offset);
+               MLX5_SET(parse_graph_flow_match_sample, s_off,
+                        flow_match_sample_tunnel_mode,
+                        s->flow_match_sample_tunnel_mode);
+       }
+       for (i = 0; i < MLX5_GRAPH_NODE_ARC_NUM; i++) {
+               struct mlx5_devx_graph_arc_attr *ia = &data->in[i];
+               struct mlx5_devx_graph_arc_attr *oa = &data->out[i];
+               void *in_off = (void *)((char *)in_arc + i *
+                             MLX5_ST_SZ_BYTES(parse_graph_arc));
+               void *out_off = (void *)((char *)out_arc + i *
+                             MLX5_ST_SZ_BYTES(parse_graph_arc));
+
+               if (ia->arc_parse_graph_node != 0) {
+                       MLX5_SET(parse_graph_arc, in_off,
+                                compare_condition_value,
+                                ia->compare_condition_value);
+                       MLX5_SET(parse_graph_arc, in_off, start_inner_tunnel,
+                                ia->start_inner_tunnel);
+                       MLX5_SET(parse_graph_arc, in_off, arc_parse_graph_node,
+                                ia->arc_parse_graph_node);
+                       MLX5_SET(parse_graph_arc, in_off,
+                                parse_graph_node_handle,
+                                ia->parse_graph_node_handle);
+               }
+               if (oa->arc_parse_graph_node != 0) {
+                       MLX5_SET(parse_graph_arc, out_off,
+                                compare_condition_value,
+                                oa->compare_condition_value);
+                       MLX5_SET(parse_graph_arc, out_off, start_inner_tunnel,
+                                oa->start_inner_tunnel);
+                       MLX5_SET(parse_graph_arc, out_off, arc_parse_graph_node,
+                                oa->arc_parse_graph_node);
+                       MLX5_SET(parse_graph_arc, out_off,
+                                parse_graph_node_handle,
+                                oa->parse_graph_node_handle);
+               }
+       }
+       parse_flex_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in),
+                                                        out, sizeof(out));
+       if (!parse_flex_obj->obj) {
+               rte_errno = errno;
+               DRV_LOG(ERR, "Failed to create FLEX PARSE GRAPH object "
+                       "by using DevX.");
+               mlx5_free(parse_flex_obj);
+               return NULL;
+       }
+       parse_flex_obj->id = MLX5_GET(general_obj_out_cmd_hdr, out, obj_id);
+       return parse_flex_obj;
+}
+
 /**
  * Query HCA attributes.
  * Using those attributes we can check on run time if the device
  * is having the required capabilities.
  *
  * @param[in] ctx
- *   ibv contexts returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param[out] attr
  *   Attributes device values.
  *
@@ -298,13 +643,13 @@ error:
  *   0 on success, a negative value otherwise.
  */
 int
-mlx5_devx_cmd_query_hca_attr(struct ibv_context *ctx,
+mlx5_devx_cmd_query_hca_attr(void *ctx,
                             struct mlx5_hca_attr *attr)
 {
        uint32_t in[MLX5_ST_SZ_DW(query_hca_cap_in)] = {0};
        uint32_t out[MLX5_ST_SZ_DW(query_hca_cap_out)] = {0};
        void *hcattr;
-       int status, syndrome, rc;
+       int status, syndrome, rc, i;
 
        MLX5_SET(query_hca_cap_in, in, opcode, MLX5_CMD_OP_QUERY_HCA_CAP);
        MLX5_SET(query_hca_cap_in, in, op_mod,
@@ -328,6 +673,8 @@ mlx5_devx_cmd_query_hca_attr(struct ibv_context *ctx,
                        MLX5_GET(cmd_hca_cap, hcattr, flow_counter_bulk_alloc);
        attr->flow_counters_dump = MLX5_GET(cmd_hca_cap, hcattr,
                                            flow_counters_dump);
+       attr->log_max_rqt_size = MLX5_GET(cmd_hca_cap, hcattr,
+                                         log_max_rqt_size);
        attr->eswitch_manager = MLX5_GET(cmd_hca_cap, hcattr, eswitch_manager);
        attr->hairpin = MLX5_GET(cmd_hca_cap, hcattr, hairpin);
        attr->log_max_hairpin_queues = MLX5_GET(cmd_hca_cap, hcattr,
@@ -337,12 +684,40 @@ mlx5_devx_cmd_query_hca_attr(struct ibv_context *ctx,
        attr->log_max_hairpin_num_packets = MLX5_GET
                (cmd_hca_cap, hcattr, log_min_hairpin_wq_data_sz);
        attr->vhca_id = MLX5_GET(cmd_hca_cap, hcattr, vhca_id);
+       attr->relaxed_ordering_write = MLX5_GET(cmd_hca_cap, hcattr,
+                       relaxed_ordering_write);
+       attr->relaxed_ordering_read = MLX5_GET(cmd_hca_cap, hcattr,
+                       relaxed_ordering_read);
+       attr->access_register_user = MLX5_GET(cmd_hca_cap, hcattr,
+                       access_register_user);
        attr->eth_net_offloads = MLX5_GET(cmd_hca_cap, hcattr,
                                          eth_net_offloads);
        attr->eth_virt = MLX5_GET(cmd_hca_cap, hcattr, eth_virt);
        attr->flex_parser_protocols = MLX5_GET(cmd_hca_cap, hcattr,
                                               flex_parser_protocols);
        attr->qos.sup = MLX5_GET(cmd_hca_cap, hcattr, qos);
+       attr->vdpa.valid = !!(MLX5_GET64(cmd_hca_cap, hcattr,
+                                        general_obj_types) &
+                             MLX5_GENERAL_OBJ_TYPES_CAP_VIRTQ_NET_Q);
+       attr->vdpa.queue_counters_valid = !!(MLX5_GET64(cmd_hca_cap, hcattr,
+                                                       general_obj_types) &
+                                 MLX5_GENERAL_OBJ_TYPES_CAP_VIRTIO_Q_COUNTERS);
+       attr->parse_graph_flex_node = !!(MLX5_GET64(cmd_hca_cap, hcattr,
+                                        general_obj_types) &
+                             MLX5_GENERAL_OBJ_TYPES_CAP_PARSE_GRAPH_FLEX_NODE);
+       attr->wqe_index_ignore = MLX5_GET(cmd_hca_cap, hcattr,
+                                         wqe_index_ignore_cap);
+       attr->cross_channel = MLX5_GET(cmd_hca_cap, hcattr, cd);
+       attr->non_wire_sq = MLX5_GET(cmd_hca_cap, hcattr, non_wire_sq);
+       attr->log_max_static_sq_wq = MLX5_GET(cmd_hca_cap, hcattr,
+                                             log_max_static_sq_wq);
+       attr->dev_freq_khz = MLX5_GET(cmd_hca_cap, hcattr,
+                                     device_frequency_khz);
+       attr->scatter_fcs_w_decap_disable =
+               MLX5_GET(cmd_hca_cap, hcattr, scatter_fcs_w_decap_disable);
+       attr->regex = MLX5_GET(cmd_hca_cap, hcattr, regexp);
+       attr->regexp_num_of_engines = MLX5_GET(cmd_hca_cap, hcattr,
+                                              regexp_num_of_engines);
        if (attr->qos.sup) {
                MLX5_SET(query_hca_cap_in, in, op_mod,
                         MLX5_GET_HCA_CAP_OP_MOD_QOS_CAP |
@@ -363,10 +738,16 @@ mlx5_devx_cmd_query_hca_attr(struct ibv_context *ctx,
                attr->qos.log_max_flow_meter =
                                MLX5_GET(qos_cap, hcattr, log_max_flow_meter);
                attr->qos.flow_meter_reg_c_ids =
-                       MLX5_GET(qos_cap, hcattr, flow_meter_reg_id);
+                               MLX5_GET(qos_cap, hcattr, flow_meter_reg_id);
                attr->qos.flow_meter_reg_share =
-                       MLX5_GET(qos_cap, hcattr, flow_meter_reg_share);
+                               MLX5_GET(qos_cap, hcattr, flow_meter_reg_share);
+               attr->qos.packet_pacing =
+                               MLX5_GET(qos_cap, hcattr, packet_pacing);
+               attr->qos.wqe_rate_pp =
+                               MLX5_GET(qos_cap, hcattr, wqe_rate_pp);
        }
+       if (attr->vdpa.valid)
+               mlx5_devx_cmd_query_hca_vdpa_attr(ctx, &attr->vdpa);
        if (!attr->eth_net_offloads)
                return 0;
 
@@ -406,7 +787,7 @@ mlx5_devx_cmd_query_hca_attr(struct ibv_context *ctx,
        attr->lro_max_msg_sz_mode = MLX5_GET
                                        (per_protocol_networking_offload_caps,
                                         hcattr, lro_max_msg_sz_mode);
-       for (int i = 0 ; i < MLX5_LRO_NUM_SUPP_PERIODS ; i++) {
+       for (i = 0 ; i < MLX5_LRO_NUM_SUPP_PERIODS ; i++) {
                attr->lro_timer_supported_periods[i] =
                        MLX5_GET(per_protocol_networking_offload_caps, hcattr,
                                 lro_timer_supported_periods[i]);
@@ -451,9 +832,10 @@ error:
  *   0 on success, a negative value otherwise.
  */
 int
-mlx5_devx_cmd_qp_query_tis_td(struct ibv_qp *qp, uint32_t tis_num,
+mlx5_devx_cmd_qp_query_tis_td(void *qp, uint32_t tis_num,
                              uint32_t *tis_td)
 {
+#ifdef HAVE_IBV_FLOW_DV_SUPPORT
        uint32_t in[MLX5_ST_SZ_DW(query_tis_in)] = {0};
        uint32_t out[MLX5_ST_SZ_DW(query_tis_out)] = {0};
        int rc;
@@ -469,6 +851,12 @@ mlx5_devx_cmd_qp_query_tis_td(struct ibv_qp *qp, uint32_t tis_num,
        tis_ctx = MLX5_ADDR_OF(query_tis_out, out, tis_context);
        *tis_td = MLX5_GET(tisc, tis_ctx, transport_domain);
        return 0;
+#else
+       (void)qp;
+       (void)tis_num;
+       (void)tis_td;
+       return -ENOTSUP;
+#endif
 }
 
 /**
@@ -518,7 +906,7 @@ devx_cmd_fill_wq_data(void *wq_ctx, struct mlx5_devx_wq_attr *wq_attr)
  * Create RQ using DevX API.
  *
  * @param[in] ctx
- *   ibv_context returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param [in] rq_attr
  *   Pointer to create RQ attributes structure.
  * @param [in] socket
@@ -528,7 +916,7 @@ devx_cmd_fill_wq_data(void *wq_ctx, struct mlx5_devx_wq_attr *wq_attr)
  *   The DevX object created, NULL otherwise and rte_errno is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_create_rq(struct ibv_context *ctx,
+mlx5_devx_cmd_create_rq(void *ctx,
                        struct mlx5_devx_create_rq_attr *rq_attr,
                        int socket)
 {
@@ -538,7 +926,7 @@ mlx5_devx_cmd_create_rq(struct ibv_context *ctx,
        struct mlx5_devx_wq_attr *wq_attr;
        struct mlx5_devx_obj *rq = NULL;
 
-       rq = rte_calloc_socket(__func__, 1, sizeof(*rq), 0, socket);
+       rq = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*rq), 0, socket);
        if (!rq) {
                DRV_LOG(ERR, "Failed to allocate RQ data");
                rte_errno = ENOMEM;
@@ -566,7 +954,7 @@ mlx5_devx_cmd_create_rq(struct ibv_context *ctx,
        if (!rq->obj) {
                DRV_LOG(ERR, "Failed to create RQ using DevX");
                rte_errno = errno;
-               rte_free(rq);
+               mlx5_free(rq);
                return NULL;
        }
        rq->id = MLX5_GET(create_rq_out, out, rqn);
@@ -627,7 +1015,7 @@ mlx5_devx_cmd_modify_rq(struct mlx5_devx_obj *rq,
  * Create TIR using DevX API.
  *
  * @param[in] ctx
- *   ibv_context returned from mlx5dv_open_device.
+ *  Context returned from mlx5 open_device() glue function.
  * @param [in] tir_attr
  *   Pointer to TIR attributes structure.
  *
@@ -635,16 +1023,15 @@ mlx5_devx_cmd_modify_rq(struct mlx5_devx_obj *rq,
  *   The DevX object created, NULL otherwise and rte_errno is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_create_tir(struct ibv_context *ctx,
+mlx5_devx_cmd_create_tir(void *ctx,
                         struct mlx5_devx_tir_attr *tir_attr)
 {
        uint32_t in[MLX5_ST_SZ_DW(create_tir_in)] = {0};
        uint32_t out[MLX5_ST_SZ_DW(create_tir_out)] = {0};
-       void *tir_ctx, *outer, *inner;
+       void *tir_ctx, *outer, *inner, *rss_key;
        struct mlx5_devx_obj *tir = NULL;
-       int i;
 
-       tir = rte_calloc(__func__, 1, sizeof(*tir), 0);
+       tir = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*tir), 0, SOCKET_ID_ANY);
        if (!tir) {
                DRV_LOG(ERR, "Failed to allocate TIR data");
                rte_errno = ENOMEM;
@@ -665,10 +1052,8 @@ mlx5_devx_cmd_create_tir(struct ibv_context *ctx,
        MLX5_SET(tirc, tir_ctx, rx_hash_fn, tir_attr->rx_hash_fn);
        MLX5_SET(tirc, tir_ctx, self_lb_block, tir_attr->self_lb_block);
        MLX5_SET(tirc, tir_ctx, transport_domain, tir_attr->transport_domain);
-       for (i = 0; i < 10; i++) {
-               MLX5_SET(tirc, tir_ctx, rx_hash_toeplitz_key[i],
-                        tir_attr->rx_hash_toeplitz_key[i]);
-       }
+       rss_key = MLX5_ADDR_OF(tirc, tir_ctx, rx_hash_toeplitz_key);
+       memcpy(rss_key, tir_attr->rx_hash_toeplitz_key, MLX5_RSS_HASH_KEY_LEN);
        outer = MLX5_ADDR_OF(tirc, tir_ctx, rx_hash_field_selector_outer);
        MLX5_SET(rx_hash_field_select, outer, l3_prot_type,
                 tir_attr->rx_hash_field_selector_outer.l3_prot_type);
@@ -688,7 +1073,7 @@ mlx5_devx_cmd_create_tir(struct ibv_context *ctx,
        if (!tir->obj) {
                DRV_LOG(ERR, "Failed to create TIR using DevX");
                rte_errno = errno;
-               rte_free(tir);
+               mlx5_free(tir);
                return NULL;
        }
        tir->id = MLX5_GET(create_tir_out, out, tirn);
@@ -699,7 +1084,7 @@ mlx5_devx_cmd_create_tir(struct ibv_context *ctx,
  * Create RQT using DevX API.
  *
  * @param[in] ctx
- *   ibv_context returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param [in] rqt_attr
  *   Pointer to RQT attributes structure.
  *
@@ -707,7 +1092,7 @@ mlx5_devx_cmd_create_tir(struct ibv_context *ctx,
  *   The DevX object created, NULL otherwise and rte_errno is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_create_rqt(struct ibv_context *ctx,
+mlx5_devx_cmd_create_rqt(void *ctx,
                         struct mlx5_devx_rqt_attr *rqt_attr)
 {
        uint32_t *in = NULL;
@@ -718,42 +1103,90 @@ mlx5_devx_cmd_create_rqt(struct ibv_context *ctx,
        struct mlx5_devx_obj *rqt = NULL;
        int i;
 
-       in = rte_calloc(__func__, 1, inlen, 0);
+       in = mlx5_malloc(MLX5_MEM_ZERO, inlen, 0, SOCKET_ID_ANY);
        if (!in) {
                DRV_LOG(ERR, "Failed to allocate RQT IN data");
                rte_errno = ENOMEM;
                return NULL;
        }
-       rqt = rte_calloc(__func__, 1, sizeof(*rqt), 0);
+       rqt = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*rqt), 0, SOCKET_ID_ANY);
        if (!rqt) {
                DRV_LOG(ERR, "Failed to allocate RQT data");
                rte_errno = ENOMEM;
-               rte_free(in);
+               mlx5_free(in);
                return NULL;
        }
        MLX5_SET(create_rqt_in, in, opcode, MLX5_CMD_OP_CREATE_RQT);
        rqt_ctx = MLX5_ADDR_OF(create_rqt_in, in, rqt_context);
+       MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type);
        MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size);
        MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size);
        for (i = 0; i < rqt_attr->rqt_actual_size; i++)
                MLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]);
        rqt->obj = mlx5_glue->devx_obj_create(ctx, in, inlen, out, sizeof(out));
-       rte_free(in);
+       mlx5_free(in);
        if (!rqt->obj) {
                DRV_LOG(ERR, "Failed to create RQT using DevX");
                rte_errno = errno;
-               rte_free(rqt);
+               mlx5_free(rqt);
                return NULL;
        }
        rqt->id = MLX5_GET(create_rqt_out, out, rqtn);
        return rqt;
 }
 
+/**
+ * Modify RQT using DevX API.
+ *
+ * @param[in] rqt
+ *   Pointer to RQT DevX object structure.
+ * @param [in] rqt_attr
+ *   Pointer to RQT attributes structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+int
+mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt,
+                        struct mlx5_devx_rqt_attr *rqt_attr)
+{
+       uint32_t inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) +
+                        rqt_attr->rqt_actual_size * sizeof(uint32_t);
+       uint32_t out[MLX5_ST_SZ_DW(modify_rqt_out)] = {0};
+       uint32_t *in = mlx5_malloc(MLX5_MEM_ZERO, inlen, 0, SOCKET_ID_ANY);
+       void *rqt_ctx;
+       int i;
+       int ret;
+
+       if (!in) {
+               DRV_LOG(ERR, "Failed to allocate RQT modify IN data.");
+               rte_errno = ENOMEM;
+               return -ENOMEM;
+       }
+       MLX5_SET(modify_rqt_in, in, opcode, MLX5_CMD_OP_MODIFY_RQT);
+       MLX5_SET(modify_rqt_in, in, rqtn, rqt->id);
+       MLX5_SET64(modify_rqt_in, in, modify_bitmask, 0x1);
+       rqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context);
+       MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type);
+       MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size);
+       MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size);
+       for (i = 0; i < rqt_attr->rqt_actual_size; i++)
+               MLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]);
+       ret = mlx5_glue->devx_obj_modify(rqt->obj, in, inlen, out, sizeof(out));
+       mlx5_free(in);
+       if (ret) {
+               DRV_LOG(ERR, "Failed to modify RQT using DevX.");
+               rte_errno = errno;
+               return -rte_errno;
+       }
+       return ret;
+}
+
 /**
  * Create SQ using DevX API.
  *
  * @param[in] ctx
- *   ibv_context returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param [in] sq_attr
  *   Pointer to SQ attributes structure.
  * @param [in] socket
@@ -763,7 +1196,7 @@ mlx5_devx_cmd_create_rqt(struct ibv_context *ctx,
  *   The DevX object created, NULL otherwise and rte_errno is set.
  **/
 struct mlx5_devx_obj *
-mlx5_devx_cmd_create_sq(struct ibv_context *ctx,
+mlx5_devx_cmd_create_sq(void *ctx,
                        struct mlx5_devx_create_sq_attr *sq_attr)
 {
        uint32_t in[MLX5_ST_SZ_DW(create_sq_in)] = {0};
@@ -773,7 +1206,7 @@ mlx5_devx_cmd_create_sq(struct ibv_context *ctx,
        struct mlx5_devx_wq_attr *wq_attr;
        struct mlx5_devx_obj *sq = NULL;
 
-       sq = rte_calloc(__func__, 1, sizeof(*sq), 0);
+       sq = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*sq), 0, SOCKET_ID_ANY);
        if (!sq) {
                DRV_LOG(ERR, "Failed to allocate SQ data");
                rte_errno = ENOMEM;
@@ -793,6 +1226,8 @@ mlx5_devx_cmd_create_sq(struct ibv_context *ctx,
        MLX5_SET(sqc, sq_ctx, reg_umr, sq_attr->reg_umr);
        MLX5_SET(sqc, sq_ctx, allow_swp, sq_attr->allow_swp);
        MLX5_SET(sqc, sq_ctx, hairpin, sq_attr->hairpin);
+       MLX5_SET(sqc, sq_ctx, non_wire, sq_attr->non_wire);
+       MLX5_SET(sqc, sq_ctx, static_sq_wq, sq_attr->static_sq_wq);
        MLX5_SET(sqc, sq_ctx, user_index, sq_attr->user_index);
        MLX5_SET(sqc, sq_ctx, cqn, sq_attr->cqn);
        MLX5_SET(sqc, sq_ctx, packet_pacing_rate_limit_index,
@@ -807,7 +1242,7 @@ mlx5_devx_cmd_create_sq(struct ibv_context *ctx,
        if (!sq->obj) {
                DRV_LOG(ERR, "Failed to create SQ using DevX");
                rte_errno = errno;
-               rte_free(sq);
+               mlx5_free(sq);
                return NULL;
        }
        sq->id = MLX5_GET(create_sq_out, out, sqn);
@@ -846,7 +1281,7 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,
        if (ret) {
                DRV_LOG(ERR, "Failed to modify SQ using DevX");
                rte_errno = errno;
-               return -errno;
+               return -rte_errno;
        }
        return ret;
 }
@@ -855,7 +1290,7 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,
  * Create TIS using DevX API.
  *
  * @param[in] ctx
- *   ibv_context returned from mlx5dv_open_device.
+ *   Context returned from mlx5 open_device() glue function.
  * @param [in] tis_attr
  *   Pointer to TIS attributes structure.
  *
@@ -863,7 +1298,7 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,
  *   The DevX object created, NULL otherwise and rte_errno is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_create_tis(struct ibv_context *ctx,
+mlx5_devx_cmd_create_tis(void *ctx,
                         struct mlx5_devx_tis_attr *tis_attr)
 {
        uint32_t in[MLX5_ST_SZ_DW(create_tis_in)] = {0};
@@ -871,7 +1306,7 @@ mlx5_devx_cmd_create_tis(struct ibv_context *ctx,
        struct mlx5_devx_obj *tis = NULL;
        void *tis_ctx;
 
-       tis = rte_calloc(__func__, 1, sizeof(*tis), 0);
+       tis = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*tis), 0, SOCKET_ID_ANY);
        if (!tis) {
                DRV_LOG(ERR, "Failed to allocate TIS object");
                rte_errno = ENOMEM;
@@ -891,7 +1326,7 @@ mlx5_devx_cmd_create_tis(struct ibv_context *ctx,
        if (!tis->obj) {
                DRV_LOG(ERR, "Failed to create TIS using DevX");
                rte_errno = errno;
-               rte_free(tis);
+               mlx5_free(tis);
                return NULL;
        }
        tis->id = MLX5_GET(create_tis_out, out, tisn);
@@ -902,19 +1337,18 @@ mlx5_devx_cmd_create_tis(struct ibv_context *ctx,
  * Create transport domain using DevX API.
  *
  * @param[in] ctx
- *   ibv_context returned from mlx5dv_open_device.
- *
+ *   Context returned from mlx5 open_device() glue function.
  * @return
  *   The DevX object created, NULL otherwise and rte_errno is set.
  */
 struct mlx5_devx_obj *
-mlx5_devx_cmd_create_td(struct ibv_context *ctx)
+mlx5_devx_cmd_create_td(void *ctx)
 {
        uint32_t in[MLX5_ST_SZ_DW(alloc_transport_domain_in)] = {0};
        uint32_t out[MLX5_ST_SZ_DW(alloc_transport_domain_out)] = {0};
        struct mlx5_devx_obj *td = NULL;
 
-       td = rte_calloc(__func__, 1, sizeof(*td), 0);
+       td = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*td), 0, SOCKET_ID_ANY);
        if (!td) {
                DRV_LOG(ERR, "Failed to allocate TD object");
                rte_errno = ENOMEM;
@@ -927,7 +1361,7 @@ mlx5_devx_cmd_create_td(struct ibv_context *ctx)
        if (!td->obj) {
                DRV_LOG(ERR, "Failed to create TIS using DevX");
                rte_errno = errno;
-               rte_free(td);
+               mlx5_free(td);
                return NULL;
        }
        td->id = MLX5_GET(alloc_transport_domain_out, out,
@@ -963,14 +1397,484 @@ mlx5_devx_cmd_flow_dump(void *fdb_domain __rte_unused,
                if (ret)
                        return ret;
        }
-       assert(rx_domain);
+       MLX5_ASSERT(rx_domain);
        ret = mlx5_glue->dr_dump_domain(file, rx_domain);
        if (ret)
                return ret;
-       assert(tx_domain);
+       MLX5_ASSERT(tx_domain);
        ret = mlx5_glue->dr_dump_domain(file, tx_domain);
 #else
        ret = ENOTSUP;
 #endif
        return -ret;
 }
+
+/*
+ * Create CQ using DevX API.
+ *
+ * @param[in] ctx
+ *   Context returned from mlx5 open_device() glue function.
+ * @param [in] attr
+ *   Pointer to CQ attributes structure.
+ *
+ * @return
+ *   The DevX object created, NULL otherwise and rte_errno is set.
+ */
+struct mlx5_devx_obj *
+mlx5_devx_cmd_create_cq(void *ctx, struct mlx5_devx_cq_attr *attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(create_cq_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(create_cq_out)] = {0};
+       struct mlx5_devx_obj *cq_obj = mlx5_malloc(MLX5_MEM_ZERO,
+                                                  sizeof(*cq_obj),
+                                                  0, SOCKET_ID_ANY);
+       void *cqctx = MLX5_ADDR_OF(create_cq_in, in, cq_context);
+
+       if (!cq_obj) {
+               DRV_LOG(ERR, "Failed to allocate CQ object memory.");
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+       MLX5_SET(create_cq_in, in, opcode, MLX5_CMD_OP_CREATE_CQ);
+       if (attr->db_umem_valid) {
+               MLX5_SET(cqc, cqctx, dbr_umem_valid, attr->db_umem_valid);
+               MLX5_SET(cqc, cqctx, dbr_umem_id, attr->db_umem_id);
+               MLX5_SET64(cqc, cqctx, dbr_addr, attr->db_umem_offset);
+       } else {
+               MLX5_SET64(cqc, cqctx, dbr_addr, attr->db_addr);
+       }
+       MLX5_SET(cqc, cqctx, cqe_sz, attr->cqe_size);
+       MLX5_SET(cqc, cqctx, cc, attr->use_first_only);
+       MLX5_SET(cqc, cqctx, oi, attr->overrun_ignore);
+       MLX5_SET(cqc, cqctx, log_cq_size, attr->log_cq_size);
+       MLX5_SET(cqc, cqctx, log_page_size, attr->log_page_size -
+                MLX5_ADAPTER_PAGE_SHIFT);
+       MLX5_SET(cqc, cqctx, c_eqn, attr->eqn);
+       MLX5_SET(cqc, cqctx, uar_page, attr->uar_page_id);
+       MLX5_SET(cqc, cqctx, cqe_comp_en, attr->cqe_comp_en);
+       MLX5_SET(cqc, cqctx, mini_cqe_res_format, attr->mini_cqe_res_format);
+       MLX5_SET(cqc, cqctx, cqe_sz, attr->cqe_size);
+       if (attr->q_umem_valid) {
+               MLX5_SET(create_cq_in, in, cq_umem_valid, attr->q_umem_valid);
+               MLX5_SET(create_cq_in, in, cq_umem_id, attr->q_umem_id);
+               MLX5_SET64(create_cq_in, in, cq_umem_offset,
+                          attr->q_umem_offset);
+       }
+       cq_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out,
+                                                sizeof(out));
+       if (!cq_obj->obj) {
+               rte_errno = errno;
+               DRV_LOG(ERR, "Failed to create CQ using DevX errno=%d.", errno);
+               mlx5_free(cq_obj);
+               return NULL;
+       }
+       cq_obj->id = MLX5_GET(create_cq_out, out, cqn);
+       return cq_obj;
+}
+
+/**
+ * Create VIRTQ using DevX API.
+ *
+ * @param[in] ctx
+ *   Context returned from mlx5 open_device() glue function.
+ * @param [in] attr
+ *   Pointer to VIRTQ attributes structure.
+ *
+ * @return
+ *   The DevX object created, NULL otherwise and rte_errno is set.
+ */
+struct mlx5_devx_obj *
+mlx5_devx_cmd_create_virtq(void *ctx,
+                          struct mlx5_devx_virtq_attr *attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(create_virtq_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0};
+       struct mlx5_devx_obj *virtq_obj = mlx5_malloc(MLX5_MEM_ZERO,
+                                                    sizeof(*virtq_obj),
+                                                    0, SOCKET_ID_ANY);
+       void *virtq = MLX5_ADDR_OF(create_virtq_in, in, virtq);
+       void *hdr = MLX5_ADDR_OF(create_virtq_in, in, hdr);
+       void *virtctx = MLX5_ADDR_OF(virtio_net_q, virtq, virtio_q_context);
+
+       if (!virtq_obj) {
+               DRV_LOG(ERR, "Failed to allocate virtq data.");
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_CREATE_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_VIRTQ);
+       MLX5_SET16(virtio_net_q, virtq, hw_available_index,
+                  attr->hw_available_index);
+       MLX5_SET16(virtio_net_q, virtq, hw_used_index, attr->hw_used_index);
+       MLX5_SET16(virtio_net_q, virtq, tso_ipv4, attr->tso_ipv4);
+       MLX5_SET16(virtio_net_q, virtq, tso_ipv6, attr->tso_ipv6);
+       MLX5_SET16(virtio_net_q, virtq, tx_csum, attr->tx_csum);
+       MLX5_SET16(virtio_net_q, virtq, rx_csum, attr->rx_csum);
+       MLX5_SET16(virtio_q, virtctx, virtio_version_1_0,
+                  attr->virtio_version_1_0);
+       MLX5_SET16(virtio_q, virtctx, event_mode, attr->event_mode);
+       MLX5_SET(virtio_q, virtctx, event_qpn_or_msix, attr->qp_id);
+       MLX5_SET64(virtio_q, virtctx, desc_addr, attr->desc_addr);
+       MLX5_SET64(virtio_q, virtctx, used_addr, attr->used_addr);
+       MLX5_SET64(virtio_q, virtctx, available_addr, attr->available_addr);
+       MLX5_SET16(virtio_q, virtctx, queue_index, attr->queue_index);
+       MLX5_SET16(virtio_q, virtctx, queue_size, attr->q_size);
+       MLX5_SET(virtio_q, virtctx, virtio_q_mkey, attr->mkey);
+       MLX5_SET(virtio_q, virtctx, umem_1_id, attr->umems[0].id);
+       MLX5_SET(virtio_q, virtctx, umem_1_size, attr->umems[0].size);
+       MLX5_SET64(virtio_q, virtctx, umem_1_offset, attr->umems[0].offset);
+       MLX5_SET(virtio_q, virtctx, umem_2_id, attr->umems[1].id);
+       MLX5_SET(virtio_q, virtctx, umem_2_size, attr->umems[1].size);
+       MLX5_SET64(virtio_q, virtctx, umem_2_offset, attr->umems[1].offset);
+       MLX5_SET(virtio_q, virtctx, umem_3_id, attr->umems[2].id);
+       MLX5_SET(virtio_q, virtctx, umem_3_size, attr->umems[2].size);
+       MLX5_SET64(virtio_q, virtctx, umem_3_offset, attr->umems[2].offset);
+       MLX5_SET(virtio_q, virtctx, counter_set_id, attr->counters_obj_id);
+       MLX5_SET(virtio_q, virtctx, pd, attr->pd);
+       MLX5_SET(virtio_net_q, virtq, tisn_or_qpn, attr->tis_id);
+       virtq_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out,
+                                                   sizeof(out));
+       if (!virtq_obj->obj) {
+               rte_errno = errno;
+               DRV_LOG(ERR, "Failed to create VIRTQ Obj using DevX.");
+               mlx5_free(virtq_obj);
+               return NULL;
+       }
+       virtq_obj->id = MLX5_GET(general_obj_out_cmd_hdr, out, obj_id);
+       return virtq_obj;
+}
+
+/**
+ * Modify VIRTQ using DevX API.
+ *
+ * @param[in] virtq_obj
+ *   Pointer to virtq object structure.
+ * @param [in] attr
+ *   Pointer to modify virtq attributes structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+int
+mlx5_devx_cmd_modify_virtq(struct mlx5_devx_obj *virtq_obj,
+                          struct mlx5_devx_virtq_attr *attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(create_virtq_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0};
+       void *virtq = MLX5_ADDR_OF(create_virtq_in, in, virtq);
+       void *hdr = MLX5_ADDR_OF(create_virtq_in, in, hdr);
+       void *virtctx = MLX5_ADDR_OF(virtio_net_q, virtq, virtio_q_context);
+       int ret;
+
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_MODIFY_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_VIRTQ);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_id, virtq_obj->id);
+       MLX5_SET64(virtio_net_q, virtq, modify_field_select, attr->type);
+       MLX5_SET16(virtio_q, virtctx, queue_index, attr->queue_index);
+       switch (attr->type) {
+       case MLX5_VIRTQ_MODIFY_TYPE_STATE:
+               MLX5_SET16(virtio_net_q, virtq, state, attr->state);
+               break;
+       case MLX5_VIRTQ_MODIFY_TYPE_DIRTY_BITMAP_PARAMS:
+               MLX5_SET(virtio_net_q, virtq, dirty_bitmap_mkey,
+                        attr->dirty_bitmap_mkey);
+               MLX5_SET64(virtio_net_q, virtq, dirty_bitmap_addr,
+                        attr->dirty_bitmap_addr);
+               MLX5_SET(virtio_net_q, virtq, dirty_bitmap_size,
+                        attr->dirty_bitmap_size);
+               break;
+       case MLX5_VIRTQ_MODIFY_TYPE_DIRTY_BITMAP_DUMP_ENABLE:
+               MLX5_SET(virtio_net_q, virtq, dirty_bitmap_dump_enable,
+                        attr->dirty_bitmap_dump_enable);
+               break;
+       default:
+               rte_errno = EINVAL;
+               return -rte_errno;
+       }
+       ret = mlx5_glue->devx_obj_modify(virtq_obj->obj, in, sizeof(in),
+                                        out, sizeof(out));
+       if (ret) {
+               DRV_LOG(ERR, "Failed to modify VIRTQ using DevX.");
+               rte_errno = errno;
+               return -rte_errno;
+       }
+       return ret;
+}
+
+/**
+ * Query VIRTQ using DevX API.
+ *
+ * @param[in] virtq_obj
+ *   Pointer to virtq object structure.
+ * @param [in/out] attr
+ *   Pointer to virtq attributes structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+int
+mlx5_devx_cmd_query_virtq(struct mlx5_devx_obj *virtq_obj,
+                          struct mlx5_devx_virtq_attr *attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(general_obj_in_cmd_hdr)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(query_virtq_out)] = {0};
+       void *hdr = MLX5_ADDR_OF(query_virtq_out, in, hdr);
+       void *virtq = MLX5_ADDR_OF(query_virtq_out, out, virtq);
+       int ret;
+
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_QUERY_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_VIRTQ);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_id, virtq_obj->id);
+       ret = mlx5_glue->devx_obj_query(virtq_obj->obj, in, sizeof(in),
+                                        out, sizeof(out));
+       if (ret) {
+               DRV_LOG(ERR, "Failed to modify VIRTQ using DevX.");
+               rte_errno = errno;
+               return -errno;
+       }
+       attr->hw_available_index = MLX5_GET16(virtio_net_q, virtq,
+                                             hw_available_index);
+       attr->hw_used_index = MLX5_GET16(virtio_net_q, virtq, hw_used_index);
+       return ret;
+}
+
+/**
+ * Create QP using DevX API.
+ *
+ * @param[in] ctx
+ *   Context returned from mlx5 open_device() glue function.
+ * @param [in] attr
+ *   Pointer to QP attributes structure.
+ *
+ * @return
+ *   The DevX object created, NULL otherwise and rte_errno is set.
+ */
+struct mlx5_devx_obj *
+mlx5_devx_cmd_create_qp(void *ctx,
+                       struct mlx5_devx_qp_attr *attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(create_qp_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(create_qp_out)] = {0};
+       struct mlx5_devx_obj *qp_obj = mlx5_malloc(MLX5_MEM_ZERO,
+                                                  sizeof(*qp_obj),
+                                                  0, SOCKET_ID_ANY);
+       void *qpc = MLX5_ADDR_OF(create_qp_in, in, qpc);
+
+       if (!qp_obj) {
+               DRV_LOG(ERR, "Failed to allocate QP data.");
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+       MLX5_SET(create_qp_in, in, opcode, MLX5_CMD_OP_CREATE_QP);
+       MLX5_SET(qpc, qpc, st, MLX5_QP_ST_RC);
+       MLX5_SET(qpc, qpc, pd, attr->pd);
+       if (attr->uar_index) {
+               MLX5_SET(qpc, qpc, pm_state, MLX5_QP_PM_MIGRATED);
+               MLX5_SET(qpc, qpc, uar_page, attr->uar_index);
+               MLX5_SET(qpc, qpc, log_page_size, attr->log_page_size -
+                        MLX5_ADAPTER_PAGE_SHIFT);
+               if (attr->sq_size) {
+                       MLX5_ASSERT(RTE_IS_POWER_OF_2(attr->sq_size));
+                       MLX5_SET(qpc, qpc, cqn_snd, attr->cqn);
+                       MLX5_SET(qpc, qpc, log_sq_size,
+                                rte_log2_u32(attr->sq_size));
+               } else {
+                       MLX5_SET(qpc, qpc, no_sq, 1);
+               }
+               if (attr->rq_size) {
+                       MLX5_ASSERT(RTE_IS_POWER_OF_2(attr->rq_size));
+                       MLX5_SET(qpc, qpc, cqn_rcv, attr->cqn);
+                       MLX5_SET(qpc, qpc, log_rq_stride, attr->log_rq_stride -
+                                MLX5_LOG_RQ_STRIDE_SHIFT);
+                       MLX5_SET(qpc, qpc, log_rq_size,
+                                rte_log2_u32(attr->rq_size));
+                       MLX5_SET(qpc, qpc, rq_type, MLX5_NON_ZERO_RQ);
+               } else {
+                       MLX5_SET(qpc, qpc, rq_type, MLX5_ZERO_LEN_RQ);
+               }
+               if (attr->dbr_umem_valid) {
+                       MLX5_SET(qpc, qpc, dbr_umem_valid,
+                                attr->dbr_umem_valid);
+                       MLX5_SET(qpc, qpc, dbr_umem_id, attr->dbr_umem_id);
+               }
+               MLX5_SET64(qpc, qpc, dbr_addr, attr->dbr_address);
+               MLX5_SET64(create_qp_in, in, wq_umem_offset,
+                          attr->wq_umem_offset);
+               MLX5_SET(create_qp_in, in, wq_umem_id, attr->wq_umem_id);
+               MLX5_SET(create_qp_in, in, wq_umem_valid, 1);
+       } else {
+               /* Special QP to be managed by FW - no SQ\RQ\CQ\UAR\DB rec. */
+               MLX5_SET(qpc, qpc, rq_type, MLX5_ZERO_LEN_RQ);
+               MLX5_SET(qpc, qpc, no_sq, 1);
+       }
+       qp_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out,
+                                                sizeof(out));
+       if (!qp_obj->obj) {
+               rte_errno = errno;
+               DRV_LOG(ERR, "Failed to create QP Obj using DevX.");
+               mlx5_free(qp_obj);
+               return NULL;
+       }
+       qp_obj->id = MLX5_GET(create_qp_out, out, qpn);
+       return qp_obj;
+}
+
+/**
+ * Modify QP using DevX API.
+ * Currently supports only force loop-back QP.
+ *
+ * @param[in] qp
+ *   Pointer to QP object structure.
+ * @param [in] qp_st_mod_op
+ *   The QP state modification operation.
+ * @param [in] remote_qp_id
+ *   The remote QP ID for MLX5_CMD_OP_INIT2RTR_QP operation.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+int
+mlx5_devx_cmd_modify_qp_state(struct mlx5_devx_obj *qp, uint32_t qp_st_mod_op,
+                             uint32_t remote_qp_id)
+{
+       union {
+               uint32_t rst2init[MLX5_ST_SZ_DW(rst2init_qp_in)];
+               uint32_t init2rtr[MLX5_ST_SZ_DW(init2rtr_qp_in)];
+               uint32_t rtr2rts[MLX5_ST_SZ_DW(rtr2rts_qp_in)];
+       } in;
+       union {
+               uint32_t rst2init[MLX5_ST_SZ_DW(rst2init_qp_out)];
+               uint32_t init2rtr[MLX5_ST_SZ_DW(init2rtr_qp_out)];
+               uint32_t rtr2rts[MLX5_ST_SZ_DW(rtr2rts_qp_out)];
+       } out;
+       void *qpc;
+       int ret;
+       unsigned int inlen;
+       unsigned int outlen;
+
+       memset(&in, 0, sizeof(in));
+       memset(&out, 0, sizeof(out));
+       MLX5_SET(rst2init_qp_in, &in, opcode, qp_st_mod_op);
+       switch (qp_st_mod_op) {
+       case MLX5_CMD_OP_RST2INIT_QP:
+               MLX5_SET(rst2init_qp_in, &in, qpn, qp->id);
+               qpc = MLX5_ADDR_OF(rst2init_qp_in, &in, qpc);
+               MLX5_SET(qpc, qpc, primary_address_path.vhca_port_num, 1);
+               MLX5_SET(qpc, qpc, rre, 1);
+               MLX5_SET(qpc, qpc, rwe, 1);
+               MLX5_SET(qpc, qpc, pm_state, MLX5_QP_PM_MIGRATED);
+               inlen = sizeof(in.rst2init);
+               outlen = sizeof(out.rst2init);
+               break;
+       case MLX5_CMD_OP_INIT2RTR_QP:
+               MLX5_SET(init2rtr_qp_in, &in, qpn, qp->id);
+               qpc = MLX5_ADDR_OF(init2rtr_qp_in, &in, qpc);
+               MLX5_SET(qpc, qpc, primary_address_path.fl, 1);
+               MLX5_SET(qpc, qpc, primary_address_path.vhca_port_num, 1);
+               MLX5_SET(qpc, qpc, mtu, 1);
+               MLX5_SET(qpc, qpc, log_msg_max, 30);
+               MLX5_SET(qpc, qpc, remote_qpn, remote_qp_id);
+               MLX5_SET(qpc, qpc, min_rnr_nak, 0);
+               inlen = sizeof(in.init2rtr);
+               outlen = sizeof(out.init2rtr);
+               break;
+       case MLX5_CMD_OP_RTR2RTS_QP:
+               qpc = MLX5_ADDR_OF(rtr2rts_qp_in, &in, qpc);
+               MLX5_SET(rtr2rts_qp_in, &in, qpn, qp->id);
+               MLX5_SET(qpc, qpc, primary_address_path.ack_timeout, 14);
+               MLX5_SET(qpc, qpc, log_ack_req_freq, 0);
+               MLX5_SET(qpc, qpc, retry_count, 7);
+               MLX5_SET(qpc, qpc, rnr_retry, 7);
+               inlen = sizeof(in.rtr2rts);
+               outlen = sizeof(out.rtr2rts);
+               break;
+       default:
+               DRV_LOG(ERR, "Invalid or unsupported QP modify op %u.",
+                       qp_st_mod_op);
+               rte_errno = EINVAL;
+               return -rte_errno;
+       }
+       ret = mlx5_glue->devx_obj_modify(qp->obj, &in, inlen, &out, outlen);
+       if (ret) {
+               DRV_LOG(ERR, "Failed to modify QP using DevX.");
+               rte_errno = errno;
+               return -rte_errno;
+       }
+       return ret;
+}
+
+struct mlx5_devx_obj *
+mlx5_devx_cmd_create_virtio_q_counters(void *ctx)
+{
+       uint32_t in[MLX5_ST_SZ_DW(create_virtio_q_counters_in)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0};
+       struct mlx5_devx_obj *couners_obj = mlx5_malloc(MLX5_MEM_ZERO,
+                                                      sizeof(*couners_obj), 0,
+                                                      SOCKET_ID_ANY);
+       void *hdr = MLX5_ADDR_OF(create_virtio_q_counters_in, in, hdr);
+
+       if (!couners_obj) {
+               DRV_LOG(ERR, "Failed to allocate virtio queue counters data.");
+               rte_errno = ENOMEM;
+               return NULL;
+       }
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_CREATE_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_VIRTIO_Q_COUNTERS);
+       couners_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out,
+                                                     sizeof(out));
+       if (!couners_obj->obj) {
+               rte_errno = errno;
+               DRV_LOG(ERR, "Failed to create virtio queue counters Obj using"
+                       " DevX.");
+               mlx5_free(couners_obj);
+               return NULL;
+       }
+       couners_obj->id = MLX5_GET(general_obj_out_cmd_hdr, out, obj_id);
+       return couners_obj;
+}
+
+int
+mlx5_devx_cmd_query_virtio_q_counters(struct mlx5_devx_obj *couners_obj,
+                                  struct mlx5_devx_virtio_q_couners_attr *attr)
+{
+       uint32_t in[MLX5_ST_SZ_DW(general_obj_in_cmd_hdr)] = {0};
+       uint32_t out[MLX5_ST_SZ_DW(query_virtio_q_counters_out)] = {0};
+       void *hdr = MLX5_ADDR_OF(query_virtio_q_counters_out, in, hdr);
+       void *virtio_q_counters = MLX5_ADDR_OF(query_virtio_q_counters_out, out,
+                                              virtio_q_counters);
+       int ret;
+
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,
+                MLX5_CMD_OP_QUERY_GENERAL_OBJECT);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type,
+                MLX5_GENERAL_OBJ_TYPE_VIRTIO_Q_COUNTERS);
+       MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_id, couners_obj->id);
+       ret = mlx5_glue->devx_obj_query(couners_obj->obj, in, sizeof(in), out,
+                                       sizeof(out));
+       if (ret) {
+               DRV_LOG(ERR, "Failed to query virtio q counters using DevX.");
+               rte_errno = errno;
+               return -errno;
+       }
+       attr->received_desc = MLX5_GET64(virtio_q_counters, virtio_q_counters,
+                                        received_desc);
+       attr->completed_desc = MLX5_GET64(virtio_q_counters, virtio_q_counters,
+                                         completed_desc);
+       attr->error_cqes = MLX5_GET(virtio_q_counters, virtio_q_counters,
+                                   error_cqes);
+       attr->bad_desc_errors = MLX5_GET(virtio_q_counters, virtio_q_counters,
+                                        bad_desc_errors);
+       attr->exceed_max_chain = MLX5_GET(virtio_q_counters, virtio_q_counters,
+                                         exceed_max_chain);
+       attr->invalid_buffer = MLX5_GET(virtio_q_counters, virtio_q_counters,
+                                       invalid_buffer);
+       return ret;
+}