cryptodev: change queue pair configure structure
[dpdk.git] / drivers / crypto / aesni_mb / rte_aesni_mb_pmd.c
index 05f08a6..2699e41 100644 (file)
@@ -86,7 +86,8 @@ aesni_mb_get_chain_order(const struct rte_crypto_sym_xform *xform)
        }
 
        if (xform->type == RTE_CRYPTO_SYM_XFORM_AEAD) {
-               if (xform->aead.algo == RTE_CRYPTO_AEAD_AES_CCM) {
+               if (xform->aead.algo == RTE_CRYPTO_AEAD_AES_CCM ||
+                               xform->aead.algo == RTE_CRYPTO_AEAD_AES_GCM) {
                        if (xform->aead.op == RTE_CRYPTO_AEAD_OP_ENCRYPT)
                                return AESNI_MB_OP_AEAD_CIPHER_HASH;
                        else
@@ -99,13 +100,14 @@ aesni_mb_get_chain_order(const struct rte_crypto_sym_xform *xform)
 
 /** Set session authentication parameters */
 static int
-aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,
+aesni_mb_set_session_auth_parameters(const MB_MGR *mb_mgr,
                struct aesni_mb_session *sess,
                const struct rte_crypto_sym_xform *xform)
 {
        hash_one_block_t hash_oneblock_fn;
        unsigned int key_larger_block_size = 0;
        uint8_t hashed_key[HMAC_MAX_BLOCK_SIZE] = { 0 };
+       uint32_t auth_precompute = 1;
 
        if (xform == NULL) {
                sess->auth.algo = NULL_HASH;
@@ -134,13 +136,16 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,
                        return -EINVAL;
                }
                sess->auth.gen_digest_len = sess->auth.req_digest_len;
-               (*mb_ops->aux.keyexp.aes_xcbc)(xform->auth.key.data,
+
+               IMB_AES_XCBC_KEYEXP(mb_mgr, xform->auth.key.data,
                                sess->auth.xcbc.k1_expanded,
                                sess->auth.xcbc.k2, sess->auth.xcbc.k3);
                return 0;
        }
 
        if (xform->auth.algo == RTE_CRYPTO_AUTH_AES_CMAC) {
+               uint32_t dust[4*15];
+
                sess->auth.algo = AES_CMAC;
 
                uint16_t cmac_digest_len = get_digest_byte_length(AES_CMAC);
@@ -157,94 +162,145 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,
                 * (16 bytes) in a temporary location and then memcpy
                 * the requested number of bytes.
                 */
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
                if (sess->auth.req_digest_len < 4)
-#else
-               uint16_t cmac_trunc_digest_len =
-                               get_truncated_digest_byte_length(AES_CMAC);
-               if (sess->auth.req_digest_len != cmac_digest_len &&
-                               sess->auth.req_digest_len != cmac_trunc_digest_len)
-#endif
                        sess->auth.gen_digest_len = cmac_digest_len;
                else
                        sess->auth.gen_digest_len = sess->auth.req_digest_len;
-               (*mb_ops->aux.keyexp.aes_cmac_expkey)(xform->auth.key.data,
-                               sess->auth.cmac.expkey);
 
-               (*mb_ops->aux.keyexp.aes_cmac_subkey)(sess->auth.cmac.expkey,
+               IMB_AES_KEYEXP_128(mb_mgr, xform->auth.key.data,
+                               sess->auth.cmac.expkey, dust);
+               IMB_AES_CMAC_SUBKEY_GEN_128(mb_mgr, sess->auth.cmac.expkey,
                                sess->auth.cmac.skey1, sess->auth.cmac.skey2);
                return 0;
        }
 
+       if (xform->auth.algo == RTE_CRYPTO_AUTH_AES_GMAC) {
+               if (xform->auth.op == RTE_CRYPTO_AUTH_OP_GENERATE) {
+                       sess->cipher.direction = ENCRYPT;
+                       sess->chain_order = CIPHER_HASH;
+               } else
+                       sess->cipher.direction = DECRYPT;
+
+               sess->auth.algo = AES_GMAC;
+               /*
+                * Multi-buffer lib supports 8, 12 and 16 bytes of digest.
+                * If size requested is different, generate the full digest
+                * (16 bytes) in a temporary location and then memcpy
+                * the requested number of bytes.
+                */
+               if (sess->auth.req_digest_len != 16 &&
+                               sess->auth.req_digest_len != 12 &&
+                               sess->auth.req_digest_len != 8) {
+                       sess->auth.gen_digest_len = 16;
+               } else {
+                       sess->auth.gen_digest_len = sess->auth.req_digest_len;
+               }
+               sess->iv.length = xform->auth.iv.length;
+               sess->iv.offset = xform->auth.iv.offset;
+
+               switch (xform->auth.key.length) {
+               case AES_128_BYTES:
+                       IMB_AES128_GCM_PRE(mb_mgr, xform->auth.key.data,
+                               &sess->cipher.gcm_key);
+                       sess->cipher.key_length_in_bytes = AES_128_BYTES;
+                       break;
+               case AES_192_BYTES:
+                       IMB_AES192_GCM_PRE(mb_mgr, xform->auth.key.data,
+                               &sess->cipher.gcm_key);
+                       sess->cipher.key_length_in_bytes = AES_192_BYTES;
+                       break;
+               case AES_256_BYTES:
+                       IMB_AES256_GCM_PRE(mb_mgr, xform->auth.key.data,
+                               &sess->cipher.gcm_key);
+                       sess->cipher.key_length_in_bytes = AES_256_BYTES;
+                       break;
+               default:
+                       RTE_LOG(ERR, PMD, "failed to parse test type\n");
+                       return -EINVAL;
+               }
+
+               return 0;
+       }
+
        switch (xform->auth.algo) {
        case RTE_CRYPTO_AUTH_MD5_HMAC:
                sess->auth.algo = MD5;
-               hash_oneblock_fn = mb_ops->aux.one_block.md5;
+               hash_oneblock_fn = mb_mgr->md5_one_block;
                break;
        case RTE_CRYPTO_AUTH_SHA1_HMAC:
                sess->auth.algo = SHA1;
-               hash_oneblock_fn = mb_ops->aux.one_block.sha1;
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
+               hash_oneblock_fn = mb_mgr->sha1_one_block;
                if (xform->auth.key.length > get_auth_algo_blocksize(SHA1)) {
-                       mb_ops->aux.multi_block.sha1(
+                       IMB_SHA1(mb_mgr,
                                xform->auth.key.data,
                                xform->auth.key.length,
                                hashed_key);
                        key_larger_block_size = 1;
                }
-#endif
+               break;
+       case RTE_CRYPTO_AUTH_SHA1:
+               sess->auth.algo = PLAIN_SHA1;
+               auth_precompute = 0;
                break;
        case RTE_CRYPTO_AUTH_SHA224_HMAC:
                sess->auth.algo = SHA_224;
-               hash_oneblock_fn = mb_ops->aux.one_block.sha224;
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
+               hash_oneblock_fn = mb_mgr->sha224_one_block;
                if (xform->auth.key.length > get_auth_algo_blocksize(SHA_224)) {
-                       mb_ops->aux.multi_block.sha224(
+                       IMB_SHA224(mb_mgr,
                                xform->auth.key.data,
                                xform->auth.key.length,
                                hashed_key);
                        key_larger_block_size = 1;
                }
-#endif
+               break;
+       case RTE_CRYPTO_AUTH_SHA224:
+               sess->auth.algo = PLAIN_SHA_224;
+               auth_precompute = 0;
                break;
        case RTE_CRYPTO_AUTH_SHA256_HMAC:
                sess->auth.algo = SHA_256;
-               hash_oneblock_fn = mb_ops->aux.one_block.sha256;
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
+               hash_oneblock_fn = mb_mgr->sha256_one_block;
                if (xform->auth.key.length > get_auth_algo_blocksize(SHA_256)) {
-                       mb_ops->aux.multi_block.sha256(
+                       IMB_SHA256(mb_mgr,
                                xform->auth.key.data,
                                xform->auth.key.length,
                                hashed_key);
                        key_larger_block_size = 1;
                }
-#endif
+               break;
+       case RTE_CRYPTO_AUTH_SHA256:
+               sess->auth.algo = PLAIN_SHA_256;
+               auth_precompute = 0;
                break;
        case RTE_CRYPTO_AUTH_SHA384_HMAC:
                sess->auth.algo = SHA_384;
-               hash_oneblock_fn = mb_ops->aux.one_block.sha384;
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
+               hash_oneblock_fn = mb_mgr->sha384_one_block;
                if (xform->auth.key.length > get_auth_algo_blocksize(SHA_384)) {
-                       mb_ops->aux.multi_block.sha384(
+                       IMB_SHA384(mb_mgr,
                                xform->auth.key.data,
                                xform->auth.key.length,
                                hashed_key);
                        key_larger_block_size = 1;
                }
-#endif
+               break;
+       case RTE_CRYPTO_AUTH_SHA384:
+               sess->auth.algo = PLAIN_SHA_384;
+               auth_precompute = 0;
                break;
        case RTE_CRYPTO_AUTH_SHA512_HMAC:
                sess->auth.algo = SHA_512;
-               hash_oneblock_fn = mb_ops->aux.one_block.sha512;
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
+               hash_oneblock_fn = mb_mgr->sha512_one_block;
                if (xform->auth.key.length > get_auth_algo_blocksize(SHA_512)) {
-                       mb_ops->aux.multi_block.sha512(
+                       IMB_SHA512(mb_mgr,
                                xform->auth.key.data,
                                xform->auth.key.length,
                                hashed_key);
                        key_larger_block_size = 1;
                }
-#endif
+               break;
+       case RTE_CRYPTO_AUTH_SHA512:
+               sess->auth.algo = PLAIN_SHA_512;
+               auth_precompute = 0;
                break;
        default:
                AESNI_MB_LOG(ERR, "Unsupported authentication algorithm selection");
@@ -255,12 +311,8 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,
        uint16_t full_digest_size =
                        get_digest_byte_length(sess->auth.algo);
 
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
        if (sess->auth.req_digest_len > full_digest_size ||
                        sess->auth.req_digest_len == 0) {
-#else
-       if (sess->auth.req_digest_len != trunc_digest_size) {
-#endif
                AESNI_MB_LOG(ERR, "Invalid digest size\n");
                return -EINVAL;
        }
@@ -271,6 +323,10 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,
        else
                sess->auth.gen_digest_len = sess->auth.req_digest_len;
 
+       /* Plain SHA does not require precompute key */
+       if (auth_precompute == 0)
+               return 0;
+
        /* Calculate Authentication precomputes */
        if (key_larger_block_size) {
                calculate_auth_precomputes(hash_oneblock_fn,
@@ -291,13 +347,12 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,
 
 /** Set session cipher parameters */
 static int
-aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
+aesni_mb_set_session_cipher_parameters(const MB_MGR *mb_mgr,
                struct aesni_mb_session *sess,
                const struct rte_crypto_sym_xform *xform)
 {
        uint8_t is_aes = 0;
        uint8_t is_3DES = 0;
-       aes_keyexp_t aes_keyexp_fn;
 
        if (xform == NULL) {
                sess->cipher.mode = NULL_CIPHER;
@@ -360,26 +415,26 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
                switch (xform->cipher.key.length) {
                case AES_128_BYTES:
                        sess->cipher.key_length_in_bytes = AES_128_BYTES;
-                       aes_keyexp_fn = mb_ops->aux.keyexp.aes128;
+                       IMB_AES_KEYEXP_128(mb_mgr, xform->cipher.key.data,
+                                       sess->cipher.expanded_aes_keys.encode,
+                                       sess->cipher.expanded_aes_keys.decode);
                        break;
                case AES_192_BYTES:
                        sess->cipher.key_length_in_bytes = AES_192_BYTES;
-                       aes_keyexp_fn = mb_ops->aux.keyexp.aes192;
+                       IMB_AES_KEYEXP_192(mb_mgr, xform->cipher.key.data,
+                                       sess->cipher.expanded_aes_keys.encode,
+                                       sess->cipher.expanded_aes_keys.decode);
                        break;
                case AES_256_BYTES:
                        sess->cipher.key_length_in_bytes = AES_256_BYTES;
-                       aes_keyexp_fn = mb_ops->aux.keyexp.aes256;
+                       IMB_AES_KEYEXP_256(mb_mgr, xform->cipher.key.data,
+                                       sess->cipher.expanded_aes_keys.encode,
+                                       sess->cipher.expanded_aes_keys.decode);
                        break;
                default:
                        AESNI_MB_LOG(ERR, "Invalid cipher key length");
                        return -EINVAL;
                }
-
-               /* Expanded cipher keys */
-               (*aes_keyexp_fn)(xform->cipher.key.data,
-                               sess->cipher.expanded_aes_keys.encode,
-                               sess->cipher.expanded_aes_keys.decode);
-
        } else if (is_3DES) {
                uint64_t *keys[3] = {sess->cipher.exp_3des_keys.key[0],
                                sess->cipher.exp_3des_keys.key[1],
@@ -387,9 +442,12 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
 
                switch (xform->cipher.key.length) {
                case  24:
-                       des_key_schedule(keys[0], xform->cipher.key.data);
-                       des_key_schedule(keys[1], xform->cipher.key.data+8);
-                       des_key_schedule(keys[2], xform->cipher.key.data+16);
+                       IMB_DES_KEYSCHED(mb_mgr, keys[0],
+                                       xform->cipher.key.data);
+                       IMB_DES_KEYSCHED(mb_mgr, keys[1],
+                                       xform->cipher.key.data + 8);
+                       IMB_DES_KEYSCHED(mb_mgr, keys[2],
+                                       xform->cipher.key.data + 16);
 
                        /* Initialize keys - 24 bytes: [K1-K2-K3] */
                        sess->cipher.exp_3des_keys.ks_ptr[0] = keys[0];
@@ -397,16 +455,18 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
                        sess->cipher.exp_3des_keys.ks_ptr[2] = keys[2];
                        break;
                case 16:
-                       des_key_schedule(keys[0], xform->cipher.key.data);
-                       des_key_schedule(keys[1], xform->cipher.key.data+8);
-
+                       IMB_DES_KEYSCHED(mb_mgr, keys[0],
+                                       xform->cipher.key.data);
+                       IMB_DES_KEYSCHED(mb_mgr, keys[1],
+                                       xform->cipher.key.data + 8);
                        /* Initialize keys - 16 bytes: [K1=K1,K2=K2,K3=K1] */
                        sess->cipher.exp_3des_keys.ks_ptr[0] = keys[0];
                        sess->cipher.exp_3des_keys.ks_ptr[1] = keys[1];
                        sess->cipher.exp_3des_keys.ks_ptr[2] = keys[0];
                        break;
                case 8:
-                       des_key_schedule(keys[0], xform->cipher.key.data);
+                       IMB_DES_KEYSCHED(mb_mgr, keys[0],
+                                       xform->cipher.key.data);
 
                        /* Initialize keys - 8 bytes: [K1 = K2 = K3] */
                        sess->cipher.exp_3des_keys.ks_ptr[0] = keys[0];
@@ -418,11 +478,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
                        return -EINVAL;
                }
 
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
                sess->cipher.key_length_in_bytes = 24;
-#else
-               sess->cipher.key_length_in_bytes = 8;
-#endif
        } else {
                if (xform->cipher.key.length != 8) {
                        AESNI_MB_LOG(ERR, "Invalid cipher key length");
@@ -430,9 +486,11 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
                }
                sess->cipher.key_length_in_bytes = 8;
 
-               des_key_schedule((uint64_t *)sess->cipher.expanded_aes_keys.encode,
+               IMB_DES_KEYSCHED(mb_mgr,
+                       (uint64_t *)sess->cipher.expanded_aes_keys.encode,
                                xform->cipher.key.data);
-               des_key_schedule((uint64_t *)sess->cipher.expanded_aes_keys.decode,
+               IMB_DES_KEYSCHED(mb_mgr,
+                       (uint64_t *)sess->cipher.expanded_aes_keys.decode,
                                xform->cipher.key.data);
        }
 
@@ -440,12 +498,10 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,
 }
 
 static int
-aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,
+aesni_mb_set_session_aead_parameters(const MB_MGR *mb_mgr,
                struct aesni_mb_session *sess,
                const struct rte_crypto_sym_xform *xform)
 {
-       aes_keyexp_t aes_keyexp_fn;
-
        switch (xform->aead.op) {
        case RTE_CRYPTO_AEAD_OP_ENCRYPT:
                sess->cipher.direction = ENCRYPT;
@@ -464,7 +520,49 @@ aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,
        case RTE_CRYPTO_AEAD_AES_CCM:
                sess->cipher.mode = CCM;
                sess->auth.algo = AES_CCM;
+
+               /* Check key length and choose key expansion function for AES */
+               switch (xform->aead.key.length) {
+               case AES_128_BYTES:
+                       sess->cipher.key_length_in_bytes = AES_128_BYTES;
+                       IMB_AES_KEYEXP_128(mb_mgr, xform->aead.key.data,
+                                       sess->cipher.expanded_aes_keys.encode,
+                                       sess->cipher.expanded_aes_keys.decode);
+                       break;
+               default:
+                       AESNI_MB_LOG(ERR, "Invalid cipher key length");
+                       return -EINVAL;
+               }
+
                break;
+
+       case RTE_CRYPTO_AEAD_AES_GCM:
+               sess->cipher.mode = GCM;
+               sess->auth.algo = AES_GMAC;
+
+               switch (xform->aead.key.length) {
+               case AES_128_BYTES:
+                       sess->cipher.key_length_in_bytes = AES_128_BYTES;
+                       IMB_AES128_GCM_PRE(mb_mgr, xform->aead.key.data,
+                               &sess->cipher.gcm_key);
+                       break;
+               case AES_192_BYTES:
+                       sess->cipher.key_length_in_bytes = AES_192_BYTES;
+                       IMB_AES192_GCM_PRE(mb_mgr, xform->aead.key.data,
+                               &sess->cipher.gcm_key);
+                       break;
+               case AES_256_BYTES:
+                       sess->cipher.key_length_in_bytes = AES_256_BYTES;
+                       IMB_AES256_GCM_PRE(mb_mgr, xform->aead.key.data,
+                               &sess->cipher.gcm_key);
+                       break;
+               default:
+                       AESNI_MB_LOG(ERR, "Invalid cipher key length");
+                       return -EINVAL;
+               }
+
+               break;
+
        default:
                AESNI_MB_LOG(ERR, "Unsupported aead mode parameter");
                return -ENOTSUP;
@@ -484,29 +582,12 @@ aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,
        }
        sess->auth.gen_digest_len = sess->auth.req_digest_len;
 
-       /* Check key length and choose key expansion function for AES */
-
-       switch (xform->aead.key.length) {
-       case AES_128_BYTES:
-               sess->cipher.key_length_in_bytes = AES_128_BYTES;
-               aes_keyexp_fn = mb_ops->aux.keyexp.aes128;
-               break;
-       default:
-               AESNI_MB_LOG(ERR, "Invalid cipher key length");
-               return -EINVAL;
-       }
-
-       /* Expanded cipher keys */
-       (*aes_keyexp_fn)(xform->aead.key.data,
-                       sess->cipher.expanded_aes_keys.encode,
-                       sess->cipher.expanded_aes_keys.decode);
-
        return 0;
 }
 
 /** Parse crypto xform chain and set private session parameters */
 int
-aesni_mb_set_session_parameters(const struct aesni_mb_op_fns *mb_ops,
+aesni_mb_set_session_parameters(const MB_MGR *mb_mgr,
                struct aesni_mb_session *sess,
                const struct rte_crypto_sym_xform *xform)
 {
@@ -565,13 +646,13 @@ aesni_mb_set_session_parameters(const struct aesni_mb_op_fns *mb_ops,
        /* Default IV length = 0 */
        sess->iv.length = 0;
 
-       ret = aesni_mb_set_session_auth_parameters(mb_ops, sess, auth_xform);
+       ret = aesni_mb_set_session_auth_parameters(mb_mgr, sess, auth_xform);
        if (ret != 0) {
                AESNI_MB_LOG(ERR, "Invalid/unsupported authentication parameters");
                return ret;
        }
 
-       ret = aesni_mb_set_session_cipher_parameters(mb_ops, sess,
+       ret = aesni_mb_set_session_cipher_parameters(mb_mgr, sess,
                        cipher_xform);
        if (ret != 0) {
                AESNI_MB_LOG(ERR, "Invalid/unsupported cipher parameters");
@@ -579,7 +660,7 @@ aesni_mb_set_session_parameters(const struct aesni_mb_op_fns *mb_ops,
        }
 
        if (aead_xform) {
-               ret = aesni_mb_set_session_aead_parameters(mb_ops, sess,
+               ret = aesni_mb_set_session_aead_parameters(mb_mgr, sess,
                                aead_xform);
                if (ret != 0) {
                        AESNI_MB_LOG(ERR, "Invalid/unsupported aead parameters");
@@ -635,15 +716,16 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_op *op)
                if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
                        return NULL;
 
-               if (rte_mempool_get(qp->sess_mp, (void **)&_sess_private_data))
+               if (rte_mempool_get(qp->sess_mp_priv,
+                               (void **)&_sess_private_data))
                        return NULL;
 
                sess = (struct aesni_mb_session *)_sess_private_data;
 
-               if (unlikely(aesni_mb_set_session_parameters(qp->op_fns,
+               if (unlikely(aesni_mb_set_session_parameters(qp->mb_mgr,
                                sess, op->sym->xform) != 0)) {
                        rte_mempool_put(qp->sess_mp, _sess);
-                       rte_mempool_put(qp->sess_mp, _sess_private_data);
+                       rte_mempool_put(qp->sess_mp_priv, _sess_private_data);
                        sess = NULL;
                }
                op->sym->session = (struct rte_cryptodev_sym_session *)_sess;
@@ -692,38 +774,70 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
 
        job->aes_key_len_in_bytes = session->cipher.key_length_in_bytes;
 
-       if (job->cipher_mode == DES3) {
-               job->aes_enc_key_expanded =
-                       session->cipher.exp_3des_keys.ks_ptr;
-               job->aes_dec_key_expanded =
-                       session->cipher.exp_3des_keys.ks_ptr;
-       } else {
-               job->aes_enc_key_expanded =
-                       session->cipher.expanded_aes_keys.encode;
-               job->aes_dec_key_expanded =
-                       session->cipher.expanded_aes_keys.decode;
-       }
-
-
-
-
        /* Set authentication parameters */
        job->hash_alg = session->auth.algo;
-       if (job->hash_alg == AES_XCBC) {
+
+       switch (job->hash_alg) {
+       case AES_XCBC:
                job->u.XCBC._k1_expanded = session->auth.xcbc.k1_expanded;
                job->u.XCBC._k2 = session->auth.xcbc.k2;
                job->u.XCBC._k3 = session->auth.xcbc.k3;
-       } else if (job->hash_alg == AES_CCM) {
+
+               job->aes_enc_key_expanded =
+                               session->cipher.expanded_aes_keys.encode;
+               job->aes_dec_key_expanded =
+                               session->cipher.expanded_aes_keys.decode;
+               break;
+
+       case AES_CCM:
                job->u.CCM.aad = op->sym->aead.aad.data + 18;
                job->u.CCM.aad_len_in_bytes = session->aead.aad_len;
-       } else if (job->hash_alg == AES_CMAC) {
+               job->aes_enc_key_expanded =
+                               session->cipher.expanded_aes_keys.encode;
+               job->aes_dec_key_expanded =
+                               session->cipher.expanded_aes_keys.decode;
+               break;
+
+       case AES_CMAC:
                job->u.CMAC._key_expanded = session->auth.cmac.expkey;
                job->u.CMAC._skey1 = session->auth.cmac.skey1;
                job->u.CMAC._skey2 = session->auth.cmac.skey2;
+               job->aes_enc_key_expanded =
+                               session->cipher.expanded_aes_keys.encode;
+               job->aes_dec_key_expanded =
+                               session->cipher.expanded_aes_keys.decode;
+               break;
 
-       } else {
+       case AES_GMAC:
+               if (session->cipher.mode == GCM) {
+                       job->u.GCM.aad = op->sym->aead.aad.data;
+                       job->u.GCM.aad_len_in_bytes = session->aead.aad_len;
+               } else {
+                       /* For GMAC */
+                       job->u.GCM.aad = rte_pktmbuf_mtod_offset(m_src,
+                                       uint8_t *, op->sym->auth.data.offset);
+                       job->u.GCM.aad_len_in_bytes = op->sym->auth.data.length;
+                       job->cipher_mode = GCM;
+               }
+               job->aes_enc_key_expanded = &session->cipher.gcm_key;
+               job->aes_dec_key_expanded = &session->cipher.gcm_key;
+               break;
+
+       default:
                job->u.HMAC._hashed_auth_key_xor_ipad = session->auth.pads.inner;
                job->u.HMAC._hashed_auth_key_xor_opad = session->auth.pads.outer;
+
+               if (job->cipher_mode == DES3) {
+                       job->aes_enc_key_expanded =
+                               session->cipher.exp_3des_keys.ks_ptr;
+                       job->aes_dec_key_expanded =
+                               session->cipher.exp_3des_keys.ks_ptr;
+               } else {
+                       job->aes_enc_key_expanded =
+                               session->cipher.expanded_aes_keys.encode;
+                       job->aes_dec_key_expanded =
+                               session->cipher.expanded_aes_keys.decode;
+               }
        }
 
        /* Mutable crypto operation parameters */
@@ -744,7 +858,8 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
                                rte_pktmbuf_data_len(op->sym->m_src));
        } else {
                m_dst = m_src;
-               if (job->hash_alg == AES_CCM)
+               if (job->hash_alg == AES_CCM || (job->hash_alg == AES_GMAC &&
+                               session->cipher.mode == GCM))
                        m_offset = op->sym->aead.data.offset;
                else
                        m_offset = op->sym->cipher.data.offset;
@@ -756,7 +871,8 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
                job->auth_tag_output = qp->temp_digests[*digest_idx];
                *digest_idx = (*digest_idx + 1) % MAX_JOBS;
        } else {
-               if (job->hash_alg == AES_CCM)
+               if (job->hash_alg == AES_CCM || (job->hash_alg == AES_GMAC &&
+                               session->cipher.mode == GCM))
                        job->auth_tag_output = op->sym->aead.digest.data;
                else
                        job->auth_tag_output = op->sym->auth.digest.data;
@@ -766,6 +882,10 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
                        *digest_idx = (*digest_idx + 1) % MAX_JOBS;
                }
        }
+       /*
+        * Multi-buffer library current only support returning a truncated
+        * digest length as specified in the relevant IPsec RFCs
+        */
 
        /* Set digest length */
        job->auth_tag_output_len_in_bytes = session->auth.gen_digest_len;
@@ -777,7 +897,8 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
        job->src = rte_pktmbuf_mtod(m_src, uint8_t *);
        job->dst = rte_pktmbuf_mtod_offset(m_dst, uint8_t *, m_offset);
 
-       if (job->hash_alg == AES_CCM) {
+       switch (job->hash_alg) {
+       case AES_CCM:
                job->cipher_start_src_offset_in_bytes =
                                op->sym->aead.data.offset;
                job->msg_len_to_cipher_in_bytes = op->sym->aead.data.length;
@@ -786,7 +907,32 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
 
                job->iv = rte_crypto_op_ctod_offset(op, uint8_t *,
                        session->iv.offset + 1);
-       } else {
+               break;
+
+       case AES_GMAC:
+               if (session->cipher.mode == GCM) {
+                       job->cipher_start_src_offset_in_bytes =
+                                       op->sym->aead.data.offset;
+                       job->hash_start_src_offset_in_bytes =
+                                       op->sym->aead.data.offset;
+                       job->msg_len_to_cipher_in_bytes =
+                                       op->sym->aead.data.length;
+                       job->msg_len_to_hash_in_bytes =
+                                       op->sym->aead.data.length;
+               } else {
+                       job->cipher_start_src_offset_in_bytes =
+                                       op->sym->auth.data.offset;
+                       job->hash_start_src_offset_in_bytes =
+                                       op->sym->auth.data.offset;
+                       job->msg_len_to_cipher_in_bytes = 0;
+                       job->msg_len_to_hash_in_bytes = 0;
+               }
+
+               job->iv = rte_crypto_op_ctod_offset(op, uint8_t *,
+                               session->iv.offset);
+               break;
+
+       default:
                job->cipher_start_src_offset_in_bytes =
                                op->sym->cipher.data.offset;
                job->msg_len_to_cipher_in_bytes = op->sym->cipher.data.length;
@@ -805,19 +951,11 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,
 }
 
 static inline void
-verify_digest(JOB_AES_HMAC *job, struct rte_crypto_op *op,
-               struct aesni_mb_session *sess)
+verify_digest(JOB_AES_HMAC *job, void *digest, uint16_t len, uint8_t *status)
 {
        /* Verify digest if required */
-       if (job->hash_alg == AES_CCM) {
-               if (memcmp(job->auth_tag_output, op->sym->aead.digest.data,
-                               sess->auth.req_digest_len) != 0)
-                       op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
-       } else {
-               if (memcmp(job->auth_tag_output, op->sym->auth.digest.data,
-                               sess->auth.req_digest_len) != 0)
-                       op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
-       }
+       if (memcmp(job->auth_tag_output, digest, len) != 0)
+               *status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
 }
 
 static inline void
@@ -859,13 +997,24 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job)
                case STS_COMPLETED:
                        op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
 
-                       if (job->hash_alg != NULL_HASH) {
-                               if (sess->auth.operation ==
-                                               RTE_CRYPTO_AUTH_OP_VERIFY)
-                                       verify_digest(job, op, sess);
+                       if (job->hash_alg == NULL_HASH)
+                               break;
+
+                       if (sess->auth.operation == RTE_CRYPTO_AUTH_OP_VERIFY) {
+                               if (job->hash_alg == AES_CCM ||
+                                       (job->hash_alg == AES_GMAC &&
+                                               sess->cipher.mode == GCM))
+                                       verify_digest(job,
+                                               op->sym->aead.digest.data,
+                                               sess->auth.req_digest_len,
+                                               &op->status);
                                else
-                                       generate_digest(job, op, sess);
-                       }
+                                       verify_digest(job,
+                                               op->sym->auth.digest.data,
+                                               sess->auth.req_digest_len,
+                                               &op->status);
+                       } else
+                               generate_digest(job, op, sess);
                        break;
                default:
                        op->status = RTE_CRYPTO_OP_STATUS_ERROR;
@@ -877,7 +1026,7 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job)
                memset(sess, 0, sizeof(struct aesni_mb_session));
                memset(op->sym->session, 0,
                                rte_cryptodev_sym_get_header_session_size());
-               rte_mempool_put(qp->sess_mp, sess);
+               rte_mempool_put(qp->sess_mp_priv, sess);
                rte_mempool_put(qp->sess_mp, op->sym->session);
                op->sym->session = NULL;
        }
@@ -915,7 +1064,7 @@ handle_completed_jobs(struct aesni_mb_qp *qp, JOB_AES_HMAC *job,
                if (processed_jobs == nb_ops)
                        break;
 
-               job = (*qp->op_fns->job.get_completed_job)(qp->mb_mgr);
+               job = IMB_GET_COMPLETED_JOB(qp->mb_mgr);
        }
 
        return processed_jobs;
@@ -928,7 +1077,7 @@ flush_mb_mgr(struct aesni_mb_qp *qp, struct rte_crypto_op **ops,
        int processed_ops = 0;
 
        /* Flush the remaining jobs */
-       JOB_AES_HMAC *job = (*qp->op_fns->job.flush_job)(qp->mb_mgr);
+       JOB_AES_HMAC *job = IMB_FLUSH_JOB(qp->mb_mgr);
 
        if (job)
                processed_ops += handle_completed_jobs(qp, job,
@@ -968,7 +1117,7 @@ aesni_mb_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,
        uint8_t digest_idx = qp->digest_idx;
        do {
                /* Get next free mb job struct from mb manager */
-               job = (*qp->op_fns->job.get_next)(qp->mb_mgr);
+               job = IMB_GET_NEXT_JOB(qp->mb_mgr);
                if (unlikely(job == NULL)) {
                        /* if no free mb job structs we need to flush mb_mgr */
                        processed_jobs += flush_mb_mgr(qp,
@@ -978,7 +1127,7 @@ aesni_mb_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,
                        if (nb_ops == processed_jobs)
                                break;
 
-                       job = (*qp->op_fns->job.get_next)(qp->mb_mgr);
+                       job = IMB_GET_NEXT_JOB(qp->mb_mgr);
                }
 
                /*
@@ -998,8 +1147,11 @@ aesni_mb_pmd_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,
                }
 
                /* Submit job to multi-buffer for processing */
-               job = (*qp->op_fns->job.submit)(qp->mb_mgr);
-
+#ifdef RTE_LIBRTE_PMD_AESNI_MB_DEBUG
+               job = IMB_SUBMIT_JOB(qp->mb_mgr);
+#else
+               job = IMB_SUBMIT_JOB_NOCHECK(qp->mb_mgr);
+#endif
                /*
                 * If submit returns a processed job then handle it,
                 * before submitting subsequent jobs
@@ -1031,6 +1183,7 @@ cryptodev_aesni_mb_create(const char *name,
        struct rte_cryptodev *dev;
        struct aesni_mb_private *internals;
        enum aesni_mb_vector_mode vector_mode;
+       MB_MGR *mb_mgr;
 
        /* Check CPU for support for AES instruction set */
        if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_AES)) {
@@ -1065,21 +1218,30 @@ cryptodev_aesni_mb_create(const char *name,
                        RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
                        RTE_CRYPTODEV_FF_CPU_AESNI;
 
+       mb_mgr = alloc_mb_mgr(0);
+       if (mb_mgr == NULL)
+               return -ENOMEM;
+
        switch (vector_mode) {
        case RTE_AESNI_MB_SSE:
                dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_SSE;
+               init_mb_mgr_sse(mb_mgr);
                break;
        case RTE_AESNI_MB_AVX:
                dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX;
+               init_mb_mgr_avx(mb_mgr);
                break;
        case RTE_AESNI_MB_AVX2:
                dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX2;
+               init_mb_mgr_avx2(mb_mgr);
                break;
        case RTE_AESNI_MB_AVX512:
                dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;
+               init_mb_mgr_avx512(mb_mgr);
                break;
        default:
-               break;
+               AESNI_MB_LOG(ERR, "Unsupported vector mode %u\n", vector_mode);
+               goto error_exit;
        }
 
        /* Set vector instructions mode supported */
@@ -1087,15 +1249,20 @@ cryptodev_aesni_mb_create(const char *name,
 
        internals->vector_mode = vector_mode;
        internals->max_nb_queue_pairs = init_params->max_nb_queue_pairs;
+       internals->mb_mgr = mb_mgr;
 
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 50, 0)
        AESNI_MB_LOG(INFO, "IPSec Multi-buffer library version used: %s\n",
                        imb_get_version_str());
-#else
-       AESNI_MB_LOG(INFO, "IPSec Multi-buffer library version used: 0.49.0\n");
-#endif
 
        return 0;
+
+error_exit:
+       if (mb_mgr)
+               free_mb_mgr(mb_mgr);
+
+       rte_cryptodev_pmd_destroy(dev);
+
+       return -1;
 }
 
 static int
@@ -1130,6 +1297,7 @@ static int
 cryptodev_aesni_mb_remove(struct rte_vdev_device *vdev)
 {
        struct rte_cryptodev *cryptodev;
+       struct aesni_mb_private *internals;
        const char *name;
 
        name = rte_vdev_device_name(vdev);
@@ -1140,6 +1308,10 @@ cryptodev_aesni_mb_remove(struct rte_vdev_device *vdev)
        if (cryptodev == NULL)
                return -ENODEV;
 
+       internals = cryptodev->data->dev_private;
+
+       free_mb_mgr(internals->mb_mgr);
+
        return rte_cryptodev_pmd_destroy(cryptodev);
 }