net/bnxt: fix duplicate creation of ntuple filter
[dpdk.git] / drivers / net / bnxt / bnxt_ethdev.c
index 4b5ebd8..dc437b4 100644 (file)
@@ -145,7 +145,7 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
        ETH_RSS_NONFRAG_IPV6_TCP |      \
        ETH_RSS_NONFRAG_IPV6_UDP)
 
-static void bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
+static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
 
 /***********************/
 
@@ -202,8 +202,16 @@ static int bnxt_init_chip(struct bnxt *bp)
 {
        unsigned int i, rss_idx, fw_idx;
        struct rte_eth_link new;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(bp->eth_dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
+       uint32_t intr_vector = 0;
+       uint32_t queue_id, base = BNXT_MISC_VEC_ID;
+       uint32_t vec = BNXT_MISC_VEC_ID;
        int rc;
 
+       /* disable uio/vfio intr/eventfd mapping */
+       rte_intr_disable(intr_handle);
+
        if (bp->eth_dev->data->mtu > ETHER_MTU) {
                bp->eth_dev->data->dev_conf.rxmode.jumbo_frame = 1;
                bp->flags |= BNXT_FLAG_JUMBO;
@@ -306,6 +314,48 @@ static int bnxt_init_chip(struct bnxt *bp)
                goto err_out;
        }
 
+       /* check and configure queue intr-vector mapping */
+       if ((rte_intr_cap_multiple(intr_handle) ||
+            !RTE_ETH_DEV_SRIOV(bp->eth_dev).active) &&
+           bp->eth_dev->data->dev_conf.intr_conf.rxq != 0) {
+               intr_vector = bp->eth_dev->data->nb_rx_queues;
+               RTE_LOG(INFO, PMD, "%s(): intr_vector = %d\n", __func__,
+                       intr_vector);
+               if (intr_vector > bp->rx_cp_nr_rings) {
+                       RTE_LOG(ERR, PMD, "At most %d intr queues supported",
+                                       bp->rx_cp_nr_rings);
+                       return -ENOTSUP;
+               }
+               if (rte_intr_efd_enable(intr_handle, intr_vector))
+                       return -1;
+       }
+
+       if (rte_intr_dp_is_en(intr_handle) && !intr_handle->intr_vec) {
+               intr_handle->intr_vec =
+                       rte_zmalloc("intr_vec",
+                                   bp->eth_dev->data->nb_rx_queues *
+                                   sizeof(int), 0);
+               if (intr_handle->intr_vec == NULL) {
+                       RTE_LOG(ERR, PMD, "Failed to allocate %d rx_queues"
+                               " intr_vec", bp->eth_dev->data->nb_rx_queues);
+                       return -ENOMEM;
+               }
+               RTE_LOG(DEBUG, PMD, "%s(): intr_handle->intr_vec = %p "
+                       "intr_handle->nb_efd = %d intr_handle->max_intr = %d\n",
+                        __func__, intr_handle->intr_vec, intr_handle->nb_efd,
+                       intr_handle->max_intr);
+       }
+
+       for (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues;
+            queue_id++) {
+               intr_handle->intr_vec[queue_id] = vec;
+               if (vec < base + intr_handle->nb_efd - 1)
+                       vec++;
+       }
+
+       /* enable uio/vfio intr/eventfd mapping */
+       rte_intr_enable(intr_handle);
+
        rc = bnxt_get_hwrm_link_config(bp, &new);
        if (rc) {
                RTE_LOG(ERR, PMD, "HWRM Get link config failure rc: %x\n", rc);
@@ -366,7 +416,7 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
        dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
 
        /* MAC Specifics */
-       dev_info->max_mac_addrs = MAX_NUM_MAC_ADDR;
+       dev_info->max_mac_addrs = bp->max_l2_ctx;
        dev_info->max_hash_mac_addrs = 0;
 
        /* PF/VF specifics */
@@ -386,8 +436,13 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
        dev_info->min_rx_bufsize = 1;
        dev_info->max_rx_pktlen = BNXT_MAX_MTU + ETHER_HDR_LEN + ETHER_CRC_LEN
                                  + VLAN_TAG_SIZE;
-       dev_info->rx_offload_capa = 0;
-       dev_info->tx_offload_capa = DEV_TX_OFFLOAD_IPV4_CKSUM |
+       dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |
+                                       DEV_RX_OFFLOAD_IPV4_CKSUM |
+                                       DEV_RX_OFFLOAD_UDP_CKSUM |
+                                       DEV_RX_OFFLOAD_TCP_CKSUM |
+                                       DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
+       dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |
+                                       DEV_TX_OFFLOAD_IPV4_CKSUM |
                                        DEV_TX_OFFLOAD_TCP_CKSUM |
                                        DEV_TX_OFFLOAD_UDP_CKSUM |
                                        DEV_TX_OFFLOAD_TCP_TSO |
@@ -421,6 +476,8 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
        };
        eth_dev->data->dev_conf.intr_conf.lsc = 1;
 
+       eth_dev->data->dev_conf.intr_conf.rxq = 1;
+
        /* *INDENT-ON* */
 
        /*
@@ -496,13 +553,13 @@ static void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
 
        if (link->link_status)
                RTE_LOG(INFO, PMD, "Port %d Link Up - speed %u Mbps - %s\n",
-                       (uint8_t)(eth_dev->data->port_id),
+                       eth_dev->data->port_id,
                        (uint32_t)link->link_speed,
                        (link->link_duplex == ETH_LINK_FULL_DUPLEX) ?
                        ("full-duplex") : ("half-duplex\n"));
        else
                RTE_LOG(INFO, PMD, "Port %d Link Down\n",
-                       (uint8_t)(eth_dev->data->port_id));
+                       eth_dev->data->port_id);
 }
 
 static int bnxt_dev_lsc_intr_setup(struct rte_eth_dev *eth_dev)
@@ -517,6 +574,11 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
        int vlan_mask = 0;
        int rc;
 
+       if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {
+               RTE_LOG(ERR, PMD,
+                       "RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
+                       bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);
+       }
        bp->dev_stopped = 0;
 
        rc = bnxt_init_nic(bp);
@@ -529,7 +591,9 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
                vlan_mask |= ETH_VLAN_FILTER_MASK;
        if (eth_dev->data->dev_conf.rxmode.hw_vlan_strip)
                vlan_mask |= ETH_VLAN_STRIP_MASK;
-       bnxt_vlan_offload_set_op(eth_dev, vlan_mask);
+       rc = bnxt_vlan_offload_set_op(eth_dev, vlan_mask);
+       if (rc)
+               goto error;
 
        return 0;
 
@@ -600,13 +664,14 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,
        uint64_t pool_mask = eth_dev->data->mac_pool_sel[index];
        struct bnxt_vnic_info *vnic;
        struct bnxt_filter_info *filter, *temp_filter;
-       int i;
+       uint32_t pool = RTE_MIN(MAX_FF_POOLS, ETH_64_POOLS);
+       uint32_t i;
 
        /*
         * Loop through all VNICs from the specified filter flow pools to
         * remove the corresponding MAC addr filter
         */
-       for (i = 0; i < MAX_FF_POOLS; i++) {
+       for (i = 0; i < pool; i++) {
                if (!(pool_mask & (1ULL << i)))
                        continue;
 
@@ -1287,7 +1352,7 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev,
                return bnxt_del_vlan_filter(bp, vlan_id);
 }
 
-static void
+static int
 bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask)
 {
        struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
@@ -1319,6 +1384,8 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask)
 
        if (mask & ETH_VLAN_EXTEND_MASK)
                RTE_LOG(ERR, PMD, "Extend VLAN Not supported\n");
+
+       return 0;
 }
 
 static void
@@ -1552,7 +1619,7 @@ bnxt_rx_queue_count_op(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                        goto nothing_to_do;
                valid = FLIP_VALID(cons, cpr->cp_ring_struct->ring_mask, valid);
                cmp_type = CMP_TYPE(rxcmp);
-               if (cmp_type == RX_PKT_CMPL_TYPE_RX_L2_TPA_END) {
+               if (cmp_type == RX_TPA_END_CMPL_TYPE_RX_TPA_END) {
                        cmp = (rte_le_to_cpu_32(
                                        ((struct rx_tpa_end_cmpl *)
                                         (rxcmp))->agg_bufs_v1) &
@@ -1665,10 +1732,12 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
                RTE_LOG(ERR, PMD, "unsupported ether_type(0x%04x) in"
                        " ethertype filter.", efilter->ether_type);
                *ret = -EINVAL;
+               goto exit;
        }
        if (efilter->queue >= bp->rx_nr_rings) {
                RTE_LOG(ERR, PMD, "Invalid queue %d\n", efilter->queue);
                *ret = -EINVAL;
+               goto exit;
        }
 
        vnic0 = STAILQ_FIRST(&bp->ff_pool[0]);
@@ -1676,6 +1745,7 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
        if (vnic == NULL) {
                RTE_LOG(ERR, PMD, "Invalid queue %d\n", efilter->queue);
                *ret = -EINVAL;
+               goto exit;
        }
 
        if (efilter->flags & RTE_ETHTYPE_FLAGS_DROP) {
@@ -1704,6 +1774,7 @@ bnxt_match_and_validate_ether_filter(struct bnxt *bp,
        if (match)
                *ret = -EEXIST;
 
+exit:
        return mfilter;
 }
 
@@ -1799,6 +1870,618 @@ error:
        return ret;
 }
 
+static inline int
+parse_ntuple_filter(struct bnxt *bp,
+                   struct rte_eth_ntuple_filter *nfilter,
+                   struct bnxt_filter_info *bfilter)
+{
+       uint32_t en = 0;
+
+       if (nfilter->queue >= bp->rx_nr_rings) {
+               RTE_LOG(ERR, PMD, "Invalid queue %d\n", nfilter->queue);
+               return -EINVAL;
+       }
+
+       switch (nfilter->dst_port_mask) {
+       case UINT16_MAX:
+               bfilter->dst_port_mask = -1;
+               bfilter->dst_port = nfilter->dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT |
+                       NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "invalid dst_port mask.");
+               return -EINVAL;
+       }
+
+       bfilter->ip_addr_type = NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+       en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+
+       switch (nfilter->proto_mask) {
+       case UINT8_MAX:
+               if (nfilter->proto == 17) /* IPPROTO_UDP */
+                       bfilter->ip_protocol = 17;
+               else if (nfilter->proto == 6) /* IPPROTO_TCP */
+                       bfilter->ip_protocol = 6;
+               else
+                       return -EINVAL;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "invalid protocol mask.");
+               return -EINVAL;
+       }
+
+       switch (nfilter->dst_ip_mask) {
+       case UINT32_MAX:
+               bfilter->dst_ipaddr_mask[0] = -1;
+               bfilter->dst_ipaddr[0] = nfilter->dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR |
+                       NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "invalid dst_ip mask.");
+               return -EINVAL;
+       }
+
+       switch (nfilter->src_ip_mask) {
+       case UINT32_MAX:
+               bfilter->src_ipaddr_mask[0] = -1;
+               bfilter->src_ipaddr[0] = nfilter->src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
+                       NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "invalid src_ip mask.");
+               return -EINVAL;
+       }
+
+       switch (nfilter->src_port_mask) {
+       case UINT16_MAX:
+               bfilter->src_port_mask = -1;
+               bfilter->src_port = nfilter->src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
+                       NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "invalid src_port mask.");
+               return -EINVAL;
+       }
+
+       //TODO Priority
+       //nfilter->priority = (uint8_t)filter->priority;
+
+       bfilter->enables = en;
+       return 0;
+}
+
+static struct bnxt_filter_info*
+bnxt_match_ntuple_filter(struct bnxt *bp,
+                        struct bnxt_filter_info *bfilter)
+{
+       struct bnxt_filter_info *mfilter = NULL;
+       int i;
+
+       for (i = bp->nr_vnics - 1; i >= 0; i--) {
+               struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
+               STAILQ_FOREACH(mfilter, &vnic->filter, next) {
+                       if (bfilter->src_ipaddr[0] == mfilter->src_ipaddr[0] &&
+                           bfilter->src_ipaddr_mask[0] ==
+                           mfilter->src_ipaddr_mask[0] &&
+                           bfilter->src_port == mfilter->src_port &&
+                           bfilter->src_port_mask == mfilter->src_port_mask &&
+                           bfilter->dst_ipaddr[0] == mfilter->dst_ipaddr[0] &&
+                           bfilter->dst_ipaddr_mask[0] ==
+                           mfilter->dst_ipaddr_mask[0] &&
+                           bfilter->dst_port == mfilter->dst_port &&
+                           bfilter->dst_port_mask == mfilter->dst_port_mask &&
+                           bfilter->flags == mfilter->flags &&
+                           bfilter->enables == mfilter->enables)
+                               return mfilter;
+               }
+       }
+       return NULL;
+}
+
+static int
+bnxt_cfg_ntuple_filter(struct bnxt *bp,
+                      struct rte_eth_ntuple_filter *nfilter,
+                      enum rte_filter_op filter_op)
+{
+       struct bnxt_filter_info *bfilter, *mfilter, *filter1;
+       struct bnxt_vnic_info *vnic, *vnic0;
+       int ret;
+
+       if (nfilter->flags != RTE_5TUPLE_FLAGS) {
+               RTE_LOG(ERR, PMD, "only 5tuple is supported.");
+               return -EINVAL;
+       }
+
+       if (nfilter->flags & RTE_NTUPLE_FLAGS_TCP_FLAG) {
+               RTE_LOG(ERR, PMD, "Ntuple filter: TCP flags not supported\n");
+               return -EINVAL;
+       }
+
+       bfilter = bnxt_get_unused_filter(bp);
+       if (bfilter == NULL) {
+               RTE_LOG(ERR, PMD,
+                       "Not enough resources for a new filter.\n");
+               return -ENOMEM;
+       }
+       ret = parse_ntuple_filter(bp, nfilter, bfilter);
+       if (ret < 0)
+               goto free_filter;
+
+       vnic = STAILQ_FIRST(&bp->ff_pool[nfilter->queue]);
+       vnic0 = STAILQ_FIRST(&bp->ff_pool[0]);
+       filter1 = STAILQ_FIRST(&vnic0->filter);
+       if (filter1 == NULL) {
+               ret = -1;
+               goto free_filter;
+       }
+
+       bfilter->dst_id = vnic->fw_vnic_id;
+       bfilter->fw_l2_filter_id = filter1->fw_l2_filter_id;
+       bfilter->enables |=
+               HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
+       bfilter->ethertype = 0x800;
+       bfilter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+
+       mfilter = bnxt_match_ntuple_filter(bp, bfilter);
+
+       if (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD) {
+               RTE_LOG(ERR, PMD, "filter exists.");
+               ret = -EEXIST;
+               goto free_filter;
+       }
+       if (mfilter == NULL && filter_op == RTE_ETH_FILTER_DELETE) {
+               RTE_LOG(ERR, PMD, "filter doesn't exist.");
+               ret = -ENOENT;
+               goto free_filter;
+       }
+
+       if (filter_op == RTE_ETH_FILTER_ADD) {
+               bfilter->filter_type = HWRM_CFA_NTUPLE_FILTER;
+               ret = bnxt_hwrm_set_ntuple_filter(bp, bfilter->dst_id, bfilter);
+               if (ret)
+                       goto free_filter;
+               STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next);
+       } else {
+               if (mfilter == NULL) {
+                       /* This should not happen. But for Coverity! */
+                       ret = -ENOENT;
+                       goto free_filter;
+               }
+               ret = bnxt_hwrm_clear_ntuple_filter(bp, mfilter);
+
+               STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info,
+                             next);
+               bnxt_free_filter(bp, mfilter);
+               bfilter->fw_l2_filter_id = -1;
+               bnxt_free_filter(bp, bfilter);
+       }
+
+       return 0;
+free_filter:
+       bfilter->fw_l2_filter_id = -1;
+       bnxt_free_filter(bp, bfilter);
+       return ret;
+}
+
+static int
+bnxt_ntuple_filter(struct rte_eth_dev *dev,
+                       enum rte_filter_op filter_op,
+                       void *arg)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       int ret;
+
+       if (filter_op == RTE_ETH_FILTER_NOP)
+               return 0;
+
+       if (arg == NULL) {
+               RTE_LOG(ERR, PMD, "arg shouldn't be NULL for operation %u.",
+                           filter_op);
+               return -EINVAL;
+       }
+
+       switch (filter_op) {
+       case RTE_ETH_FILTER_ADD:
+               ret = bnxt_cfg_ntuple_filter(bp,
+                       (struct rte_eth_ntuple_filter *)arg,
+                       filter_op);
+               break;
+       case RTE_ETH_FILTER_DELETE:
+               ret = bnxt_cfg_ntuple_filter(bp,
+                       (struct rte_eth_ntuple_filter *)arg,
+                       filter_op);
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "unsupported operation %u.", filter_op);
+               ret = -EINVAL;
+               break;
+       }
+       return ret;
+}
+
+static int
+bnxt_parse_fdir_filter(struct bnxt *bp,
+                      struct rte_eth_fdir_filter *fdir,
+                      struct bnxt_filter_info *filter)
+{
+       enum rte_fdir_mode fdir_mode =
+               bp->eth_dev->data->dev_conf.fdir_conf.mode;
+       struct bnxt_vnic_info *vnic0, *vnic;
+       struct bnxt_filter_info *filter1;
+       uint32_t en = 0;
+       int i;
+
+       if (fdir_mode == RTE_FDIR_MODE_PERFECT_TUNNEL)
+               return -EINVAL;
+
+       filter->l2_ovlan = fdir->input.flow_ext.vlan_tci;
+       en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
+
+       switch (fdir->input.flow_type) {
+       case RTE_ETH_FLOW_IPV4:
+       case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
+               /* FALLTHROUGH */
+               filter->src_ipaddr[0] = fdir->input.flow.ip4_flow.src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               filter->dst_ipaddr[0] = fdir->input.flow.ip4_flow.dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               filter->ip_protocol = fdir->input.flow.ip4_flow.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+               filter->src_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->dst_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               filter->ethertype = 0x800;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV4_TCP:
+               filter->src_port = fdir->input.flow.tcp4_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.tcp4_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->src_ipaddr[0] = fdir->input.flow.tcp4_flow.ip.src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               filter->dst_ipaddr[0] = fdir->input.flow.tcp4_flow.ip.dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               filter->ip_protocol = 6;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+               filter->src_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->dst_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               filter->ethertype = 0x800;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV4_UDP:
+               filter->src_port = fdir->input.flow.udp4_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.udp4_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->src_ipaddr[0] = fdir->input.flow.udp4_flow.ip.src_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               filter->dst_ipaddr[0] = fdir->input.flow.udp4_flow.ip.dst_ip;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               filter->ip_protocol = 17;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
+               filter->src_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->dst_ipaddr_mask[0] = 0xffffffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               filter->ethertype = 0x800;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_IPV6:
+       case RTE_ETH_FLOW_NONFRAG_IPV6_OTHER:
+               /* FALLTHROUGH */
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
+               filter->ip_protocol = fdir->input.flow.ipv6_flow.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               rte_memcpy(filter->src_ipaddr,
+                          fdir->input.flow.ipv6_flow.src_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               rte_memcpy(filter->dst_ipaddr,
+                          fdir->input.flow.ipv6_flow.dst_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               memset(filter->dst_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               memset(filter->src_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->ethertype = 0x86dd;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV6_TCP:
+               filter->src_port = fdir->input.flow.tcp6_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.tcp6_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
+               filter->ip_protocol = fdir->input.flow.tcp6_flow.ip.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               rte_memcpy(filter->src_ipaddr,
+                          fdir->input.flow.tcp6_flow.ip.src_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               rte_memcpy(filter->dst_ipaddr,
+                          fdir->input.flow.tcp6_flow.ip.dst_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               memset(filter->dst_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               memset(filter->src_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->ethertype = 0x86dd;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_NONFRAG_IPV6_UDP:
+               filter->src_port = fdir->input.flow.udp6_flow.src_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
+               filter->dst_port = fdir->input.flow.udp6_flow.dst_port;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
+               filter->dst_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
+               filter->src_port_mask = 0xffff;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
+               filter->ip_addr_type =
+                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
+               filter->ip_protocol = fdir->input.flow.udp6_flow.ip.proto;
+               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
+               rte_memcpy(filter->src_ipaddr,
+                          fdir->input.flow.udp6_flow.ip.src_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
+               rte_memcpy(filter->dst_ipaddr,
+                          fdir->input.flow.udp6_flow.ip.dst_ip, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
+               memset(filter->dst_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
+               memset(filter->src_ipaddr_mask, 0xff, 16);
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
+               filter->ethertype = 0x86dd;
+               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_L2_PAYLOAD:
+               filter->ethertype = fdir->input.flow.l2_flow.ether_type;
+               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
+               break;
+       case RTE_ETH_FLOW_VXLAN:
+               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
+                       return -EINVAL;
+               filter->vni = fdir->input.flow.tunnel_flow.tunnel_id;
+               filter->tunnel_type =
+                       CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
+               en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_TUNNEL_TYPE;
+               break;
+       case RTE_ETH_FLOW_NVGRE:
+               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
+                       return -EINVAL;
+               filter->vni = fdir->input.flow.tunnel_flow.tunnel_id;
+               filter->tunnel_type =
+                       CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
+               en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_TUNNEL_TYPE;
+               break;
+       case RTE_ETH_FLOW_UNKNOWN:
+       case RTE_ETH_FLOW_RAW:
+       case RTE_ETH_FLOW_FRAG_IPV4:
+       case RTE_ETH_FLOW_NONFRAG_IPV4_SCTP:
+       case RTE_ETH_FLOW_FRAG_IPV6:
+       case RTE_ETH_FLOW_NONFRAG_IPV6_SCTP:
+       case RTE_ETH_FLOW_IPV6_EX:
+       case RTE_ETH_FLOW_IPV6_TCP_EX:
+       case RTE_ETH_FLOW_IPV6_UDP_EX:
+       case RTE_ETH_FLOW_GENEVE:
+               /* FALLTHROUGH */
+       default:
+               return -EINVAL;
+       }
+
+       vnic0 = STAILQ_FIRST(&bp->ff_pool[0]);
+       vnic = STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);
+       if (vnic == NULL) {
+               RTE_LOG(ERR, PMD, "Invalid queue %d\n", fdir->action.rx_queue);
+               return -EINVAL;
+       }
+
+
+       if (fdir_mode == RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
+               rte_memcpy(filter->dst_macaddr,
+                       fdir->input.flow.mac_vlan_flow.mac_addr.addr_bytes, 6);
+                       en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR;
+       }
+
+       if (fdir->action.behavior == RTE_ETH_FDIR_REJECT) {
+               filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
+               filter1 = STAILQ_FIRST(&vnic0->filter);
+               //filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
+       } else {
+               filter->dst_id = vnic->fw_vnic_id;
+               for (i = 0; i < ETHER_ADDR_LEN; i++)
+                       if (filter->dst_macaddr[i] == 0x00)
+                               filter1 = STAILQ_FIRST(&vnic0->filter);
+                       else
+                               filter1 = bnxt_get_l2_filter(bp, filter, vnic);
+       }
+
+       if (filter1 == NULL)
+               return -EINVAL;
+
+       en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
+       filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
+
+       filter->enables = en;
+
+       return 0;
+}
+
+static struct bnxt_filter_info *
+bnxt_match_fdir(struct bnxt *bp, struct bnxt_filter_info *nf)
+{
+       struct bnxt_filter_info *mf = NULL;
+       int i;
+
+       for (i = bp->nr_vnics - 1; i >= 0; i--) {
+               struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
+
+               STAILQ_FOREACH(mf, &vnic->filter, next) {
+                       if (mf->filter_type == nf->filter_type &&
+                           mf->flags == nf->flags &&
+                           mf->src_port == nf->src_port &&
+                           mf->src_port_mask == nf->src_port_mask &&
+                           mf->dst_port == nf->dst_port &&
+                           mf->dst_port_mask == nf->dst_port_mask &&
+                           mf->ip_protocol == nf->ip_protocol &&
+                           mf->ip_addr_type == nf->ip_addr_type &&
+                           mf->ethertype == nf->ethertype &&
+                           mf->vni == nf->vni &&
+                           mf->tunnel_type == nf->tunnel_type &&
+                           mf->l2_ovlan == nf->l2_ovlan &&
+                           mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
+                           mf->l2_ivlan == nf->l2_ivlan &&
+                           mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
+                           !memcmp(mf->l2_addr, nf->l2_addr, ETHER_ADDR_LEN) &&
+                           !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
+                                   ETHER_ADDR_LEN) &&
+                           !memcmp(mf->src_macaddr, nf->src_macaddr,
+                                   ETHER_ADDR_LEN) &&
+                           !memcmp(mf->dst_macaddr, nf->dst_macaddr,
+                                   ETHER_ADDR_LEN) &&
+                           !memcmp(mf->src_ipaddr, nf->src_ipaddr,
+                                   sizeof(nf->src_ipaddr)) &&
+                           !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
+                                   sizeof(nf->src_ipaddr_mask)) &&
+                           !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
+                                   sizeof(nf->dst_ipaddr)) &&
+                           !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
+                                   sizeof(nf->dst_ipaddr_mask)))
+                               return mf;
+               }
+       }
+       return NULL;
+}
+
+static int
+bnxt_fdir_filter(struct rte_eth_dev *dev,
+                enum rte_filter_op filter_op,
+                void *arg)
+{
+       struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
+       struct rte_eth_fdir_filter *fdir  = (struct rte_eth_fdir_filter *)arg;
+       struct bnxt_filter_info *filter, *match;
+       struct bnxt_vnic_info *vnic;
+       int ret = 0, i;
+
+       if (filter_op == RTE_ETH_FILTER_NOP)
+               return 0;
+
+       if (arg == NULL && filter_op != RTE_ETH_FILTER_FLUSH)
+               return -EINVAL;
+
+       switch (filter_op) {
+       case RTE_ETH_FILTER_ADD:
+       case RTE_ETH_FILTER_DELETE:
+               /* FALLTHROUGH */
+               filter = bnxt_get_unused_filter(bp);
+               if (filter == NULL) {
+                       RTE_LOG(ERR, PMD,
+                               "Not enough resources for a new flow.\n");
+                       return -ENOMEM;
+               }
+
+               ret = bnxt_parse_fdir_filter(bp, fdir, filter);
+               if (ret != 0)
+                       goto free_filter;
+               filter->filter_type = HWRM_CFA_NTUPLE_FILTER;
+
+               match = bnxt_match_fdir(bp, filter);
+               if (match != NULL && filter_op == RTE_ETH_FILTER_ADD) {
+                       RTE_LOG(ERR, PMD, "Flow already exists.\n");
+                       ret = -EEXIST;
+                       goto free_filter;
+               }
+               if (match == NULL && filter_op == RTE_ETH_FILTER_DELETE) {
+                       RTE_LOG(ERR, PMD, "Flow does not exist.\n");
+                       ret = -ENOENT;
+                       goto free_filter;
+               }
+
+               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
+                       vnic = STAILQ_FIRST(&bp->ff_pool[0]);
+               else
+                       vnic =
+                       STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);
+
+               if (filter_op == RTE_ETH_FILTER_ADD) {
+                       ret = bnxt_hwrm_set_ntuple_filter(bp,
+                                                         filter->dst_id,
+                                                         filter);
+                       if (ret)
+                               goto free_filter;
+                       STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
+               } else {
+                       ret = bnxt_hwrm_clear_ntuple_filter(bp, match);
+                       STAILQ_REMOVE(&vnic->filter, match,
+                                     bnxt_filter_info, next);
+                       bnxt_free_filter(bp, match);
+                       filter->fw_l2_filter_id = -1;
+                       bnxt_free_filter(bp, filter);
+               }
+               break;
+       case RTE_ETH_FILTER_FLUSH:
+               for (i = bp->nr_vnics - 1; i >= 0; i--) {
+                       struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
+
+                       STAILQ_FOREACH(filter, &vnic->filter, next) {
+                               if (filter->filter_type ==
+                                   HWRM_CFA_NTUPLE_FILTER) {
+                                       ret =
+                                       bnxt_hwrm_clear_ntuple_filter(bp,
+                                                                     filter);
+                                       STAILQ_REMOVE(&vnic->filter, filter,
+                                                     bnxt_filter_info, next);
+                               }
+                       }
+               }
+               return ret;
+       case RTE_ETH_FILTER_UPDATE:
+       case RTE_ETH_FILTER_STATS:
+       case RTE_ETH_FILTER_INFO:
+               /* FALLTHROUGH */
+               RTE_LOG(ERR, PMD, "operation %u not implemented", filter_op);
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "unknown operation %u", filter_op);
+               ret = -EINVAL;
+               break;
+       }
+       return ret;
+
+free_filter:
+       filter->fw_l2_filter_id = -1;
+       bnxt_free_filter(bp, filter);
+       return ret;
+}
+
 static int
 bnxt_filter_ctrl_op(struct rte_eth_dev *dev __rte_unused,
                    enum rte_filter_type filter_type,
@@ -1807,13 +2490,16 @@ bnxt_filter_ctrl_op(struct rte_eth_dev *dev __rte_unused,
        int ret = 0;
 
        switch (filter_type) {
-       case RTE_ETH_FILTER_NTUPLE:
-       case RTE_ETH_FILTER_FDIR:
        case RTE_ETH_FILTER_TUNNEL:
-               /* FALLTHROUGH */
                RTE_LOG(ERR, PMD,
                        "filter type: %d: To be implemented\n", filter_type);
                break;
+       case RTE_ETH_FILTER_FDIR:
+               ret = bnxt_fdir_filter(dev, filter_op, arg);
+               break;
+       case RTE_ETH_FILTER_NTUPLE:
+               ret = bnxt_ntuple_filter(dev, filter_op, arg);
+               break;
        case RTE_ETH_FILTER_ETHERTYPE:
                ret = bnxt_ethertype_filter(dev, filter_op, arg);
                break;
@@ -2009,6 +2695,8 @@ static const struct eth_dev_ops bnxt_dev_ops = {
        .rx_queue_release = bnxt_rx_queue_release_op,
        .tx_queue_setup = bnxt_tx_queue_setup_op,
        .tx_queue_release = bnxt_tx_queue_release_op,
+       .rx_queue_intr_enable = bnxt_rx_queue_intr_enable_op,
+       .rx_queue_intr_disable = bnxt_rx_queue_intr_disable_op,
        .reta_update = bnxt_reta_update_op,
        .reta_query = bnxt_reta_query_op,
        .rss_hash_update = bnxt_rss_hash_update_op,
@@ -2112,7 +2800,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
        const struct rte_memzone *mz = NULL;
        static int version_printed;
        uint32_t total_alloc_len;
-       phys_addr_t mz_phys_addr;
+       rte_iova_t mz_phys_addr;
        struct bnxt *bp;
        int rc;
 
@@ -2120,7 +2808,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
                RTE_LOG(INFO, PMD, "%s\n", bnxt_version);
 
        rte_eth_copy_pci_info(eth_dev, pci_dev);
-       eth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;
 
        bp = eth_dev->data->dev_private;
 
@@ -2164,13 +2851,13 @@ skip_init:
                                return -ENOMEM;
                }
                memset(mz->addr, 0, mz->len);
-               mz_phys_addr = mz->phys_addr;
+               mz_phys_addr = mz->iova;
                if ((unsigned long)mz->addr == mz_phys_addr) {
                        RTE_LOG(WARNING, PMD,
                                "Memzone physical address same as virtual.\n");
                        RTE_LOG(WARNING, PMD,
-                               "Using rte_mem_virt2phy()\n");
-                       mz_phys_addr = rte_mem_virt2phy(mz->addr);
+                               "Using rte_mem_virt2iova()\n");
+                       mz_phys_addr = rte_mem_virt2iova(mz->addr);
                        if (mz_phys_addr == 0) {
                                RTE_LOG(ERR, PMD,
                                "unable to map address to physical memory\n");
@@ -2199,13 +2886,13 @@ skip_init:
                                return -ENOMEM;
                }
                memset(mz->addr, 0, mz->len);
-               mz_phys_addr = mz->phys_addr;
+               mz_phys_addr = mz->iova;
                if ((unsigned long)mz->addr == mz_phys_addr) {
                        RTE_LOG(WARNING, PMD,
                                "Memzone physical address same as virtual.\n");
                        RTE_LOG(WARNING, PMD,
-                               "Using rte_mem_virt2phy()\n");
-                       mz_phys_addr = rte_mem_virt2phy(mz->addr);
+                               "Using rte_mem_virt2iova()\n");
+                       mz_phys_addr = rte_mem_virt2iova(mz->addr);
                        if (mz_phys_addr == 0) {
                                RTE_LOG(ERR, PMD,
                                "unable to map address to physical memory\n");
@@ -2245,11 +2932,11 @@ skip_init:
                goto error_free;
        }
        eth_dev->data->mac_addrs = rte_zmalloc("bnxt_mac_addr_tbl",
-                                       ETHER_ADDR_LEN * MAX_NUM_MAC_ADDR, 0);
+                                       ETHER_ADDR_LEN * bp->max_l2_ctx, 0);
        if (eth_dev->data->mac_addrs == NULL) {
                RTE_LOG(ERR, PMD,
                        "Failed to alloc %u bytes needed to store MAC addr tbl",
-                       ETHER_ADDR_LEN * MAX_NUM_MAC_ADDR);
+                       ETHER_ADDR_LEN * bp->max_l2_ctx);
                rc = -ENOMEM;
                goto error_free;
        }
@@ -2288,6 +2975,8 @@ skip_init:
        ALLOW_FUNC(HWRM_VNIC_RSS_COS_LB_CTX_FREE);
        ALLOW_FUNC(HWRM_CFA_L2_FILTER_FREE);
        ALLOW_FUNC(HWRM_STAT_CTX_FREE);
+       ALLOW_FUNC(HWRM_PORT_PHY_QCFG);
+       ALLOW_FUNC(HWRM_VNIC_TPA_CFG);
        rc = bnxt_hwrm_func_driver_register(bp);
        if (rc) {
                RTE_LOG(ERR, PMD,