net: add rte prefix to ether defines
[dpdk.git] / drivers / net / bnxt / bnxt_ring.c
index 67b009a..51fe35f 100644 (file)
@@ -1,42 +1,19 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) Broadcom Limited.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Broadcom Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2014-2018 Broadcom
+ * All rights reserved.
  */
 
+#include <rte_bitmap.h>
 #include <rte_memzone.h>
+#include <unistd.h>
 
 #include "bnxt.h"
 #include "bnxt_cpr.h"
+#include "bnxt_hwrm.h"
 #include "bnxt_ring.h"
+#include "bnxt_rxq.h"
 #include "bnxt_rxr.h"
+#include "bnxt_txq.h"
 #include "bnxt_txr.h"
 
 #include "hsi_struct_def_dpdk.h"
 
 void bnxt_free_ring(struct bnxt_ring *ring)
 {
+       if (!ring)
+               return;
+
        if (ring->vmem_size && *ring->vmem) {
                memset((char *)*ring->vmem, 0, ring->vmem_size);
                *ring->vmem = NULL;
        }
-       rte_memzone_free((const struct rte_memzone *)ring->mem_zone);
+       ring->mem_zone = NULL;
+}
+
+/*
+ * Ring groups
+ */
+
+int bnxt_init_ring_grps(struct bnxt *bp)
+{
+       unsigned int i;
+
+       for (i = 0; i < bp->max_ring_grps; i++)
+               memset(&bp->grp_info[i], (uint8_t)HWRM_NA_SIGNATURE,
+                      sizeof(struct bnxt_ring_grp_info));
+
+       return 0;
 }
 
 /*
@@ -69,20 +64,26 @@ void bnxt_free_ring(struct bnxt_ring *ring)
  * rx bd ring - Only non-zero length if rx_ring_info is not NULL
  */
 int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
-                           struct bnxt_tx_ring_info *tx_ring_info,
-                           struct bnxt_rx_ring_info *rx_ring_info,
+                           struct bnxt_tx_queue *txq,
+                           struct bnxt_rx_queue *rxq,
                            struct bnxt_cp_ring_info *cp_ring_info,
                            const char *suffix)
 {
        struct bnxt_ring *cp_ring = cp_ring_info->cp_ring_struct;
+       struct bnxt_rx_ring_info *rx_ring_info = rxq ? rxq->rx_ring : NULL;
+       struct bnxt_tx_ring_info *tx_ring_info = txq ? txq->tx_ring : NULL;
        struct bnxt_ring *tx_ring;
        struct bnxt_ring *rx_ring;
        struct rte_pci_device *pdev = bp->pdev;
+       uint64_t rx_offloads = bp->eth_dev->data->dev_conf.rxmode.offloads;
        const struct rte_memzone *mz = NULL;
        char mz_name[RTE_MEMZONE_NAMESIZE];
+       rte_iova_t mz_phys_addr;
+       int sz;
 
        int stats_len = (tx_ring_info || rx_ring_info) ?
-           RTE_CACHE_LINE_ROUNDUP(sizeof(struct ctx_hw_stats64)) : 0;
+           RTE_CACHE_LINE_ROUNDUP(sizeof(struct hwrm_stat_ctx_query_output) -
+                                  sizeof (struct hwrm_resp_hdr)) : 0;
 
        int cp_vmem_start = stats_len;
        int cp_vmem_len = RTE_CACHE_LINE_ROUNDUP(cp_ring->vmem_size);
@@ -96,8 +97,15 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
        int rx_vmem_len = rx_ring_info ?
                RTE_CACHE_LINE_ROUNDUP(rx_ring_info->
                                                rx_ring_struct->vmem_size) : 0;
+       int ag_vmem_start = 0;
+       int ag_vmem_len = 0;
+       int cp_ring_start =  0;
+
+       ag_vmem_start = rx_vmem_start + rx_vmem_len;
+       ag_vmem_len = rx_ring_info ? RTE_CACHE_LINE_ROUNDUP(
+                               rx_ring_info->ag_ring_struct->vmem_size) : 0;
+       cp_ring_start = ag_vmem_start + ag_vmem_len;
 
-       int cp_ring_start = rx_vmem_start + rx_vmem_len;
        int cp_ring_len = RTE_CACHE_LINE_ROUNDUP(cp_ring->ring_size *
                                                 sizeof(struct cmpl_base));
 
@@ -111,7 +119,23 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
                RTE_CACHE_LINE_ROUNDUP(rx_ring_info->rx_ring_struct->ring_size *
                sizeof(struct rx_prod_pkt_bd)) : 0;
 
-       int total_alloc_len = rx_ring_start + rx_ring_len;
+       int ag_ring_start = rx_ring_start + rx_ring_len;
+       int ag_ring_len = rx_ring_len * AGG_RING_SIZE_FACTOR;
+
+       int ag_bitmap_start = ag_ring_start + ag_ring_len;
+       int ag_bitmap_len =  rx_ring_info ?
+               RTE_CACHE_LINE_ROUNDUP(rte_bitmap_get_memory_footprint(
+                       rx_ring_info->rx_ring_struct->ring_size *
+                       AGG_RING_SIZE_FACTOR)) : 0;
+
+       int tpa_info_start = ag_bitmap_start + ag_bitmap_len;
+       int tpa_info_len = rx_ring_info ?
+               RTE_CACHE_LINE_ROUNDUP(BNXT_TPA_MAX *
+                                      sizeof(struct bnxt_tpa_info)) : 0;
+
+       int total_alloc_len = tpa_info_start;
+       if (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO)
+               total_alloc_len += tpa_info_len;
 
        snprintf(mz_name, RTE_MEMZONE_NAMESIZE,
                 "bnxt_%04x:%02x:%02x:%02x-%04x_%s", pdev->addr.domain,
@@ -120,21 +144,39 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
        mz_name[RTE_MEMZONE_NAMESIZE - 1] = 0;
        mz = rte_memzone_lookup(mz_name);
        if (!mz) {
-               mz = rte_memzone_reserve(mz_name, total_alloc_len,
-                                        SOCKET_ID_ANY,
-                                        RTE_MEMZONE_2MB |
-                                        RTE_MEMZONE_SIZE_HINT_ONLY);
+               mz = rte_memzone_reserve_aligned(mz_name, total_alloc_len,
+                               SOCKET_ID_ANY,
+                               RTE_MEMZONE_2MB |
+                               RTE_MEMZONE_SIZE_HINT_ONLY |
+                               RTE_MEMZONE_IOVA_CONTIG,
+                               getpagesize());
                if (mz == NULL)
                        return -ENOMEM;
        }
        memset(mz->addr, 0, mz->len);
+       mz_phys_addr = mz->iova;
+       if ((unsigned long)mz->addr == mz_phys_addr) {
+               PMD_DRV_LOG(WARNING,
+                       "Memzone physical address same as virtual.\n");
+               PMD_DRV_LOG(WARNING,
+                       "Using rte_mem_virt2iova()\n");
+               for (sz = 0; sz < total_alloc_len; sz += getpagesize())
+                       rte_mem_lock_page(((char *)mz->addr) + sz);
+               mz_phys_addr = rte_mem_virt2iova(mz->addr);
+               if (mz_phys_addr == 0) {
+                       PMD_DRV_LOG(ERR,
+                       "unable to map ring address to physical memory\n");
+                       return -ENOMEM;
+               }
+       }
 
        if (tx_ring_info) {
+               txq->mz = mz;
                tx_ring = tx_ring_info->tx_ring_struct;
 
                tx_ring->bd = ((char *)mz->addr + tx_ring_start);
                tx_ring_info->tx_desc_ring = (struct tx_bd_long *)tx_ring->bd;
-               tx_ring->bd_dma = mz->phys_addr + tx_ring_start;
+               tx_ring->bd_dma = mz_phys_addr + tx_ring_start;
                tx_ring_info->tx_desc_mapping = tx_ring->bd_dma;
                tx_ring->mem_zone = (const void *)mz;
 
@@ -149,12 +191,13 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
        }
 
        if (rx_ring_info) {
+               rxq->mz = mz;
                rx_ring = rx_ring_info->rx_ring_struct;
 
                rx_ring->bd = ((char *)mz->addr + rx_ring_start);
                rx_ring_info->rx_desc_ring =
                    (struct rx_prod_pkt_bd *)rx_ring->bd;
-               rx_ring->bd_dma = mz->phys_addr + rx_ring_start;
+               rx_ring->bd_dma = mz_phys_addr + rx_ring_start;
                rx_ring_info->rx_desc_mapping = rx_ring->bd_dma;
                rx_ring->mem_zone = (const void *)mz;
 
@@ -166,10 +209,39 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
                        rx_ring_info->rx_buf_ring =
                            (struct bnxt_sw_rx_bd *)rx_ring->vmem;
                }
+
+               rx_ring = rx_ring_info->ag_ring_struct;
+
+               rx_ring->bd = ((char *)mz->addr + ag_ring_start);
+               rx_ring_info->ag_desc_ring =
+                   (struct rx_prod_pkt_bd *)rx_ring->bd;
+               rx_ring->bd_dma = mz->iova + ag_ring_start;
+               rx_ring_info->ag_desc_mapping = rx_ring->bd_dma;
+               rx_ring->mem_zone = (const void *)mz;
+
+               if (!rx_ring->bd)
+                       return -ENOMEM;
+               if (rx_ring->vmem_size) {
+                       rx_ring->vmem =
+                           (void **)((char *)mz->addr + ag_vmem_start);
+                       rx_ring_info->ag_buf_ring =
+                           (struct bnxt_sw_rx_bd *)rx_ring->vmem;
+               }
+
+               rx_ring_info->ag_bitmap =
+                   rte_bitmap_init(rx_ring_info->rx_ring_struct->ring_size *
+                                   AGG_RING_SIZE_FACTOR, (uint8_t *)mz->addr +
+                                   ag_bitmap_start, ag_bitmap_len);
+
+               /* TPA info */
+               if (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO)
+                       rx_ring_info->tpa_info =
+                               ((struct bnxt_tpa_info *)((char *)mz->addr +
+                                                         tpa_info_start));
        }
 
        cp_ring->bd = ((char *)mz->addr + cp_ring_start);
-       cp_ring->bd_dma = mz->phys_addr + cp_ring_start;
+       cp_ring->bd_dma = mz_phys_addr + cp_ring_start;
        cp_ring_info->cp_desc_ring = cp_ring->bd;
        cp_ring_info->cp_desc_mapping = cp_ring->bd_dma;
        cp_ring->mem_zone = (const void *)mz;
@@ -180,8 +252,250 @@ int bnxt_alloc_rings(struct bnxt *bp, uint16_t qidx,
                *cp_ring->vmem = ((char *)mz->addr + stats_len);
        if (stats_len) {
                cp_ring_info->hw_stats = mz->addr;
-               cp_ring_info->hw_stats_map = mz->phys_addr;
+               cp_ring_info->hw_stats_map = mz_phys_addr;
        }
        cp_ring_info->hw_stats_ctx_id = HWRM_NA_SIGNATURE;
        return 0;
 }
+
+static void bnxt_init_dflt_coal(struct bnxt_coal *coal)
+{
+       /* Tick values in micro seconds.
+        * 1 coal_buf x bufs_per_record = 1 completion record.
+        */
+       coal->num_cmpl_aggr_int = BNXT_NUM_CMPL_AGGR_INT;
+       /* This is a 6-bit value and must not be 0, or we'll get non stop IRQ */
+       coal->num_cmpl_dma_aggr = BNXT_NUM_CMPL_DMA_AGGR;
+       /* This is a 6-bit value and must not be 0, or we'll get non stop IRQ */
+       coal->num_cmpl_dma_aggr_during_int = BNXT_NUM_CMPL_DMA_AGGR_DURING_INT;
+       coal->int_lat_tmr_max = BNXT_INT_LAT_TMR_MAX;
+       /* min timer set to 1/2 of interrupt timer */
+       coal->int_lat_tmr_min = BNXT_INT_LAT_TMR_MIN;
+       /* buf timer set to 1/4 of interrupt timer */
+       coal->cmpl_aggr_dma_tmr = BNXT_CMPL_AGGR_DMA_TMR;
+       coal->cmpl_aggr_dma_tmr_during_int = BNXT_CMPL_AGGR_DMA_TMR_DURING_INT;
+}
+
+int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)
+{
+       struct rte_pci_device *pci_dev = bp->pdev;
+       struct bnxt_rx_queue *rxq = bp->rx_queues[queue_index];
+       struct bnxt_cp_ring_info *cpr = rxq->cp_ring;
+       struct bnxt_ring *cp_ring = cpr->cp_ring_struct;
+       struct bnxt_rx_ring_info *rxr = rxq->rx_ring;
+       struct bnxt_ring *ring = rxr->rx_ring_struct;
+       unsigned int map_idx = queue_index + bp->rx_cp_nr_rings;
+       int rc = 0;
+
+       bp->grp_info[queue_index].fw_stats_ctx = cpr->hw_stats_ctx_id;
+
+       /* Rx cmpl */
+       rc = bnxt_hwrm_ring_alloc(bp, cp_ring,
+                                 HWRM_RING_ALLOC_INPUT_RING_TYPE_L2_CMPL,
+                                 queue_index, HWRM_NA_SIGNATURE,
+                                 HWRM_NA_SIGNATURE);
+       if (rc)
+               goto err_out;
+
+       cpr->cp_doorbell = (char *)pci_dev->mem_resource[2].addr +
+               queue_index * BNXT_DB_SIZE;
+       bp->grp_info[queue_index].cp_fw_ring_id = cp_ring->fw_ring_id;
+       B_CP_DIS_DB(cpr, cpr->cp_raw_cons);
+
+       if (!queue_index) {
+               /*
+                * In order to save completion resources, use the first
+                * completion ring from PF or VF as the default completion ring
+                * for async event and HWRM forward response handling.
+                */
+               bp->def_cp_ring = cpr;
+               rc = bnxt_hwrm_set_async_event_cr(bp);
+               if (rc)
+                       goto err_out;
+       }
+       /* Rx ring */
+       rc = bnxt_hwrm_ring_alloc(bp, ring, HWRM_RING_ALLOC_INPUT_RING_TYPE_RX,
+                                 queue_index, cpr->hw_stats_ctx_id,
+                                 cp_ring->fw_ring_id);
+       if (rc)
+               goto err_out;
+
+       rxr->rx_prod = 0;
+       rxr->rx_doorbell = (char *)pci_dev->mem_resource[2].addr +
+               queue_index * BNXT_DB_SIZE;
+       bp->grp_info[queue_index].rx_fw_ring_id = ring->fw_ring_id;
+       B_RX_DB(rxr->rx_doorbell, rxr->rx_prod);
+
+       ring = rxr->ag_ring_struct;
+       /* Agg ring */
+       if (!ring)
+               PMD_DRV_LOG(ERR, "Alloc AGG Ring is NULL!\n");
+
+       rc = bnxt_hwrm_ring_alloc(bp, ring, HWRM_RING_ALLOC_INPUT_RING_TYPE_RX,
+                                 map_idx, HWRM_NA_SIGNATURE,
+                                 cp_ring->fw_ring_id);
+       if (rc)
+               goto err_out;
+
+       PMD_DRV_LOG(DEBUG, "Alloc AGG Done!\n");
+       rxr->ag_prod = 0;
+       rxr->ag_doorbell = (char *)pci_dev->mem_resource[2].addr +
+               map_idx * BNXT_DB_SIZE;
+       bp->grp_info[queue_index].ag_fw_ring_id = ring->fw_ring_id;
+       B_RX_DB(rxr->ag_doorbell, rxr->ag_prod);
+
+       rxq->rx_buf_use_size = BNXT_MAX_MTU + RTE_ETHER_HDR_LEN +
+               RTE_ETHER_CRC_LEN + (2 * VLAN_TAG_SIZE);
+
+       if (bp->eth_dev->data->rx_queue_state[queue_index] ==
+           RTE_ETH_QUEUE_STATE_STARTED) {
+               if (bnxt_init_one_rx_ring(rxq)) {
+                       RTE_LOG(ERR, PMD,
+                               "bnxt_init_one_rx_ring failed!\n");
+                       bnxt_rx_queue_release_op(rxq);
+                       rc = -ENOMEM;
+                       goto err_out;
+               }
+               B_RX_DB(rxr->rx_doorbell, rxr->rx_prod);
+               B_RX_DB(rxr->ag_doorbell, rxr->ag_prod);
+       }
+       rxq->index = queue_index;
+       PMD_DRV_LOG(INFO,
+                   "queue %d, rx_deferred_start %d, state %d!\n",
+                   queue_index, rxq->rx_deferred_start,
+                   bp->eth_dev->data->rx_queue_state[queue_index]);
+
+err_out:
+       return rc;
+}
+/* ring_grp usage:
+ * [0] = default completion ring
+ * [1 -> +rx_cp_nr_rings] = rx_cp, rx rings
+ * [1+rx_cp_nr_rings + 1 -> +tx_cp_nr_rings] = tx_cp, tx rings
+ */
+int bnxt_alloc_hwrm_rings(struct bnxt *bp)
+{
+       struct bnxt_coal coal;
+       unsigned int i;
+       int rc = 0;
+
+       bnxt_init_dflt_coal(&coal);
+
+       for (i = 0; i < bp->rx_cp_nr_rings; i++) {
+               struct bnxt_rx_queue *rxq = bp->rx_queues[i];
+               struct bnxt_cp_ring_info *cpr = rxq->cp_ring;
+               struct bnxt_ring *cp_ring = cpr->cp_ring_struct;
+               struct bnxt_rx_ring_info *rxr = rxq->rx_ring;
+               struct bnxt_ring *ring = rxr->rx_ring_struct;
+               unsigned int map_idx = i + bp->rx_cp_nr_rings;
+
+               bp->grp_info[i].fw_stats_ctx = cpr->hw_stats_ctx_id;
+
+               /* Rx cmpl */
+               rc = bnxt_hwrm_ring_alloc
+                       (bp,
+                        cp_ring,
+                        HWRM_RING_ALLOC_INPUT_RING_TYPE_L2_CMPL,
+                        i,
+                        HWRM_NA_SIGNATURE,
+                        HWRM_NA_SIGNATURE);
+               if (rc)
+                       goto err_out;
+               cpr->cp_doorbell = (char *)bp->doorbell_base + i * 0x80;
+               bp->grp_info[i].cp_fw_ring_id = cp_ring->fw_ring_id;
+               B_CP_DIS_DB(cpr, cpr->cp_raw_cons);
+               bnxt_hwrm_set_ring_coal(bp, &coal, cp_ring->fw_ring_id);
+
+               if (!i) {
+                       /*
+                        * In order to save completion resource, use the first
+                        * completion ring from PF or VF as the default
+                        * completion ring for async event & HWRM
+                        * forward response handling.
+                        */
+                       bp->def_cp_ring = cpr;
+                       rc = bnxt_hwrm_set_async_event_cr(bp);
+                       if (rc)
+                               goto err_out;
+               }
+
+               /* Rx ring */
+               rc = bnxt_hwrm_ring_alloc(bp,
+                                         ring,
+                                         HWRM_RING_ALLOC_INPUT_RING_TYPE_RX,
+                                         i,
+                                         cpr->hw_stats_ctx_id,
+                                         cp_ring->fw_ring_id);
+               if (rc)
+                       goto err_out;
+               rxr->rx_prod = 0;
+               rxr->rx_doorbell = (char *)bp->doorbell_base + i * 0x80;
+               bp->grp_info[i].rx_fw_ring_id = ring->fw_ring_id;
+               B_RX_DB(rxr->rx_doorbell, rxr->rx_prod);
+
+               ring = rxr->ag_ring_struct;
+               /* Agg ring */
+               if (ring == NULL) {
+                       PMD_DRV_LOG(ERR, "Alloc AGG Ring is NULL!\n");
+                       goto err_out;
+               }
+
+               rc = bnxt_hwrm_ring_alloc(bp, ring,
+                               HWRM_RING_ALLOC_INPUT_RING_TYPE_RX,
+                               map_idx, HWRM_NA_SIGNATURE,
+                               cp_ring->fw_ring_id);
+               if (rc)
+                       goto err_out;
+               PMD_DRV_LOG(DEBUG, "Alloc AGG Done!\n");
+               rxr->ag_prod = 0;
+               rxr->ag_doorbell = (char *)bp->doorbell_base + map_idx * 0x80;
+               bp->grp_info[i].ag_fw_ring_id = ring->fw_ring_id;
+               B_RX_DB(rxr->ag_doorbell, rxr->ag_prod);
+
+               rxq->rx_buf_use_size = BNXT_MAX_MTU + RTE_ETHER_HDR_LEN +
+                                       RTE_ETHER_CRC_LEN + (2 * VLAN_TAG_SIZE);
+               if (bnxt_init_one_rx_ring(rxq)) {
+                       PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring failed!\n");
+                       bnxt_rx_queue_release_op(rxq);
+                       return -ENOMEM;
+               }
+               B_RX_DB(rxr->rx_doorbell, rxr->rx_prod);
+               B_RX_DB(rxr->ag_doorbell, rxr->ag_prod);
+               rxq->index = i;
+       }
+
+       for (i = 0; i < bp->tx_cp_nr_rings; i++) {
+               struct bnxt_tx_queue *txq = bp->tx_queues[i];
+               struct bnxt_cp_ring_info *cpr = txq->cp_ring;
+               struct bnxt_ring *cp_ring = cpr->cp_ring_struct;
+               struct bnxt_tx_ring_info *txr = txq->tx_ring;
+               struct bnxt_ring *ring = txr->tx_ring_struct;
+               unsigned int idx = i + bp->rx_cp_nr_rings;
+
+               /* Tx cmpl */
+               rc = bnxt_hwrm_ring_alloc(bp, cp_ring,
+                                       HWRM_RING_ALLOC_INPUT_RING_TYPE_L2_CMPL,
+                                       idx, HWRM_NA_SIGNATURE,
+                                       HWRM_NA_SIGNATURE);
+               if (rc)
+                       goto err_out;
+
+               cpr->cp_doorbell = (char *)bp->doorbell_base + idx * 0x80;
+               B_CP_DIS_DB(cpr, cpr->cp_raw_cons);
+
+               /* Tx ring */
+               rc = bnxt_hwrm_ring_alloc(bp, ring,
+                                       HWRM_RING_ALLOC_INPUT_RING_TYPE_TX,
+                                       idx, cpr->hw_stats_ctx_id,
+                                       cp_ring->fw_ring_id);
+               if (rc)
+                       goto err_out;
+
+               txr->tx_doorbell = (char *)bp->doorbell_base + idx * 0x80;
+               txq->index = idx;
+               bnxt_hwrm_set_ring_coal(bp, &coal, cp_ring->fw_ring_id);
+       }
+
+err_out:
+       return rc;
+}