net/bnxt: limit queue count for NS3/Stingray devices
[dpdk.git] / drivers / net / bnxt / bnxt_rxq.c
index d5c3173..fa11bec 100644 (file)
@@ -1,34 +1,6 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) Broadcom Limited.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Broadcom Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2014-2018 Broadcom
+ * All rights reserved.
  */
 
 #include <inttypes.h>
@@ -40,6 +12,7 @@
 #include "bnxt_hwrm.h"
 #include "bnxt_ring.h"
 #include "bnxt_rxq.h"
+#include "bnxt_rxr.h"
 #include "bnxt_vnic.h"
 #include "hsi_struct_def_dpdk.h"
 
 
 void bnxt_free_rxq_stats(struct bnxt_rx_queue *rxq)
 {
-       struct bnxt_cp_ring_info *cpr = rxq->cp_ring;
-
-       /* 'Unreserve' rte_memzone */
-
-       if (cpr->hw_stats)
-               cpr->hw_stats = NULL;
+       if (rxq && rxq->cp_ring && rxq->cp_ring->hw_stats)
+               rxq->cp_ring->hw_stats = NULL;
 }
 
 int bnxt_mq_rx_configure(struct bnxt *bp)
 {
        struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
-       unsigned int i, j, nb_q_per_grp, ring_idx;
-       int start_grp_id, end_grp_id, rc = 0;
+       const struct rte_eth_vmdq_rx_conf *conf =
+                   &dev_conf->rx_adv_conf.vmdq_rx_conf;
+       unsigned int i, j, nb_q_per_grp = 1, ring_idx = 0;
+       int start_grp_id, end_grp_id = 1, rc = 0;
        struct bnxt_vnic_info *vnic;
        struct bnxt_filter_info *filter;
+       enum rte_eth_nb_pools pools = bp->rx_cp_nr_rings, max_pools = 0;
        struct bnxt_rx_queue *rxq;
 
        bp->nr_vnics = 0;
 
        /* Single queue mode */
        if (bp->rx_cp_nr_rings < 2) {
-               vnic = bnxt_alloc_vnic(bp);
+               vnic = &bp->vnic_info[0];
                if (!vnic) {
-                       RTE_LOG(ERR, PMD, "VNIC alloc failed\n");
+                       PMD_DRV_LOG(ERR, "VNIC alloc failed\n");
                        rc = -ENOMEM;
                        goto err_out;
                }
-               STAILQ_INSERT_TAIL(&bp->ff_pool[0], vnic, next);
+               vnic->flags |= BNXT_VNIC_INFO_BCAST;
                bp->nr_vnics++;
 
                rxq = bp->eth_dev->data->rx_queues[0];
                rxq->vnic = vnic;
 
                vnic->func_default = true;
-               vnic->ff_pool_idx = 0;
-               vnic->start_grp_id = 1;
-               vnic->end_grp_id = vnic->start_grp_id +
-                                  bp->rx_cp_nr_rings - 1;
+               vnic->start_grp_id = 0;
+               vnic->end_grp_id = vnic->start_grp_id;
                filter = bnxt_alloc_filter(bp);
                if (!filter) {
-                       RTE_LOG(ERR, PMD, "L2 filter alloc failed\n");
+                       PMD_DRV_LOG(ERR, "L2 filter alloc failed\n");
                        rc = -ENOMEM;
                        goto err_out;
                }
+               filter->mac_index = 0;
+               filter->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
                STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
                goto out;
        }
 
        /* Multi-queue mode */
-       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG) {
+       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB_RSS) {
                /* VMDq ONLY, VMDq+RSS, VMDq+DCB, VMDq+DCB+RSS */
-               enum rte_eth_nb_pools pools;
 
                switch (dev_conf->rxmode.mq_mode) {
                case ETH_MQ_RX_VMDQ_RSS:
                case ETH_MQ_RX_VMDQ_ONLY:
-                       {
-                               const struct rte_eth_vmdq_rx_conf *conf =
-                                   &dev_conf->rx_adv_conf.vmdq_rx_conf;
-
-                               /* ETH_8/64_POOLs */
-                               pools = conf->nb_queue_pools;
-                               break;
-                       }
+               case ETH_MQ_RX_VMDQ_DCB_RSS:
+                       /* FALLTHROUGH */
+                       /* ETH_8/64_POOLs */
+                       pools = conf->nb_queue_pools;
+                       /* For each pool, allocate MACVLAN CFA rule & VNIC */
+                       max_pools = RTE_MIN(bp->max_vnics,
+                                           RTE_MIN(bp->max_l2_ctx,
+                                           RTE_MIN(bp->max_rsscos_ctx,
+                                                   ETH_64_POOLS)));
+                       PMD_DRV_LOG(DEBUG,
+                                   "pools = %u max_pools = %u\n",
+                                   pools, max_pools);
+                       if (pools > max_pools)
+                               pools = max_pools;
+                       break;
+               case ETH_MQ_RX_RSS:
+                       pools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : 1;
+                       break;
                default:
-                       RTE_LOG(ERR, PMD, "Unsupported mq_mod %d\n",
+                       PMD_DRV_LOG(ERR, "Unsupported mq_mod %d\n",
                                dev_conf->rxmode.mq_mode);
                        rc = -EINVAL;
                        goto err_out;
                }
-               /* For each pool, allocate MACVLAN CFA rule & VNIC */
-               if (!pools) {
-                       RTE_LOG(ERR, PMD,
-                               "VMDq pool not set, defaulted to 64\n");
-                       pools = ETH_64_POOLS;
+       }
+       nb_q_per_grp = bp->rx_cp_nr_rings / pools;
+       bp->rx_num_qs_per_vnic = nb_q_per_grp;
+       PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
+                   pools, nb_q_per_grp);
+       start_grp_id = 0;
+       end_grp_id = nb_q_per_grp;
+
+       for (i = 0; i < pools; i++) {
+               vnic = &bp->vnic_info[i];
+               if (!vnic) {
+                       PMD_DRV_LOG(ERR, "VNIC alloc failed\n");
+                       rc = -ENOMEM;
+                       goto err_out;
                }
-               nb_q_per_grp = bp->rx_cp_nr_rings / pools;
-               start_grp_id = 1;
-               end_grp_id = start_grp_id + nb_q_per_grp - 1;
-
-               ring_idx = 0;
-               for (i = 0; i < pools; i++) {
-                       vnic = bnxt_alloc_vnic(bp);
-                       if (!vnic) {
-                               RTE_LOG(ERR, PMD,
-                                       "VNIC alloc failed\n");
-                               rc = -ENOMEM;
-                               goto err_out;
-                       }
-                       STAILQ_INSERT_TAIL(&bp->ff_pool[i], vnic, next);
-                       bp->nr_vnics++;
+               vnic->flags |= BNXT_VNIC_INFO_BCAST;
+               bp->nr_vnics++;
 
-                       for (j = 0; j < nb_q_per_grp; j++, ring_idx++) {
-                               rxq = bp->eth_dev->data->rx_queues[ring_idx];
-                               rxq->vnic = vnic;
-                       }
-                       if (i == 0)
-                               vnic->func_default = true;
-                       vnic->ff_pool_idx = i;
-                       vnic->start_grp_id = start_grp_id;
-                       vnic->end_grp_id = end_grp_id;
-
-                       filter = bnxt_alloc_filter(bp);
-                       if (!filter) {
-                               RTE_LOG(ERR, PMD,
-                                       "L2 filter alloc failed\n");
-                               rc = -ENOMEM;
-                               goto err_out;
+               for (j = 0; j < nb_q_per_grp; j++, ring_idx++) {
+                       rxq = bp->eth_dev->data->rx_queues[ring_idx];
+                       rxq->vnic = vnic;
+                       PMD_DRV_LOG(DEBUG,
+                                   "rxq[%d] = %p vnic[%d] = %p\n",
+                                   ring_idx, rxq, i, vnic);
+               }
+               if (i == 0) {
+                       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB) {
+                               bp->eth_dev->data->promiscuous = 1;
+                               vnic->flags |= BNXT_VNIC_INFO_PROMISC;
                        }
-                       /*
-                        * TODO: Configure & associate CFA rule for
-                        * each VNIC for each VMDq with MACVLAN, MACVLAN+TC
-                        */
-                       STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-
-                       start_grp_id = end_grp_id + 1;
-                       end_grp_id += nb_q_per_grp;
+                       vnic->func_default = true;
                }
-               goto out;
-       }
+               vnic->start_grp_id = start_grp_id;
+               vnic->end_grp_id = end_grp_id;
+
+               if (i) {
+                       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB ||
+                           !(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS))
+                               vnic->rss_dflt_cr = true;
+                       goto skip_filter_allocation;
+               }
+               filter = bnxt_alloc_filter(bp);
+               if (!filter) {
+                       PMD_DRV_LOG(ERR, "L2 filter alloc failed\n");
+                       rc = -ENOMEM;
+                       goto err_out;
+               }
+               filter->mac_index = 0;
+               filter->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
+               /*
+                * TODO: Configure & associate CFA rule for
+                * each VNIC for each VMDq with MACVLAN, MACVLAN+TC
+                */
+               STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
 
-       /* Non-VMDq mode - RSS, DCB, RSS+DCB */
-       /* Init default VNIC for RSS or DCB only */
-       vnic = bnxt_alloc_vnic(bp);
-       if (!vnic) {
-               RTE_LOG(ERR, PMD, "VNIC alloc failed\n");
-               rc = -ENOMEM;
-               goto err_out;
+skip_filter_allocation:
+               start_grp_id = end_grp_id;
+               end_grp_id += nb_q_per_grp;
        }
-       /* Partition the rx queues for the single pool */
-       for (i = 0; i < bp->rx_cp_nr_rings; i++) {
-               rxq = bp->eth_dev->data->rx_queues[i];
-               rxq->vnic = vnic;
-       }
-       STAILQ_INSERT_TAIL(&bp->ff_pool[0], vnic, next);
-       bp->nr_vnics++;
-
-       vnic->func_default = true;
-       vnic->ff_pool_idx = 0;
-       vnic->start_grp_id = 1;
-       vnic->end_grp_id = vnic->start_grp_id +
-                          bp->rx_cp_nr_rings - 1;
-       filter = bnxt_alloc_filter(bp);
-       if (!filter) {
-               RTE_LOG(ERR, PMD, "L2 filter alloc failed\n");
-               rc = -ENOMEM;
-               goto err_out;
-       }
-       STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-
-       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-               vnic->hash_type =
-                       HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV4 |
-                       HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV6;
 
 out:
+       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
+               struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;
+
+               if (bp->flags & BNXT_FLAG_UPDATE_HASH) {
+                       rss = &bp->rss_conf;
+                       bp->flags &= ~BNXT_FLAG_UPDATE_HASH;
+               }
+
+               for (i = 0; i < bp->nr_vnics; i++) {
+                       vnic = &bp->vnic_info[i];
+                       vnic->hash_type =
+                               bnxt_rte_to_hwrm_hash_types(rss->rss_hf);
+
+                       /*
+                        * Use the supplied key if the key length is
+                        * acceptable and the rss_key is not NULL
+                        */
+                       if (rss->rss_key &&
+                           rss->rss_key_len <= HW_HASH_KEY_SIZE)
+                               memcpy(vnic->rss_hash_key,
+                                      rss->rss_key, rss->rss_key_len);
+               }
+       }
+
        return rc;
 
 err_out:
@@ -213,9 +193,53 @@ err_out:
        return rc;
 }
 
-static void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq __rte_unused)
+void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq)
 {
-       /* TODO: Requires interaction with TX ring */
+       struct bnxt_sw_rx_bd *sw_ring;
+       struct bnxt_tpa_info *tpa_info;
+       uint16_t i;
+
+       if (!rxq)
+               return;
+
+       rte_spinlock_lock(&rxq->lock);
+
+       sw_ring = rxq->rx_ring->rx_buf_ring;
+       if (sw_ring) {
+               for (i = 0;
+                    i < rxq->rx_ring->rx_ring_struct->ring_size; i++) {
+                       if (sw_ring[i].mbuf) {
+                               rte_pktmbuf_free_seg(sw_ring[i].mbuf);
+                               sw_ring[i].mbuf = NULL;
+                       }
+               }
+       }
+       /* Free up mbufs in Agg ring */
+       sw_ring = rxq->rx_ring->ag_buf_ring;
+       if (sw_ring) {
+               for (i = 0;
+                    i < rxq->rx_ring->ag_ring_struct->ring_size; i++) {
+                       if (sw_ring[i].mbuf) {
+                               rte_pktmbuf_free_seg(sw_ring[i].mbuf);
+                               sw_ring[i].mbuf = NULL;
+                       }
+               }
+       }
+
+       /* Free up mbufs in TPA */
+       tpa_info = rxq->rx_ring->tpa_info;
+       if (tpa_info) {
+               int max_aggs = BNXT_TPA_MAX_AGGS(rxq->bp);
+
+               for (i = 0; i < max_aggs; i++) {
+                       if (tpa_info[i].mbuf) {
+                               rte_pktmbuf_free_seg(tpa_info[i].mbuf);
+                               tpa_info[i].mbuf = NULL;
+                       }
+               }
+       }
+
+       rte_spinlock_unlock(&rxq->lock);
 }
 
 void bnxt_free_rx_mbufs(struct bnxt *bp)
@@ -234,9 +258,22 @@ void bnxt_rx_queue_release_op(void *rx_queue)
        struct bnxt_rx_queue *rxq = (struct bnxt_rx_queue *)rx_queue;
 
        if (rxq) {
+               if (is_bnxt_in_error(rxq->bp))
+                       return;
+
                bnxt_rx_queue_release_mbufs(rxq);
 
-               /* TODO: Free ring and stats here */
+               /* Free RX ring hardware descriptors */
+               bnxt_free_ring(rxq->rx_ring->rx_ring_struct);
+               /* Free RX Agg ring hardware descriptors */
+               bnxt_free_ring(rxq->rx_ring->ag_ring_struct);
+
+               /* Free RX completion ring hardware descriptors */
+               bnxt_free_ring(rxq->cp_ring->cp_ring_struct);
+
+               bnxt_free_rxq_stats(rxq);
+               rte_memzone_free(rxq->mz);
+               rxq->mz = NULL;
 
                rte_free(rxq);
        }
@@ -249,14 +286,29 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
                               const struct rte_eth_rxconf *rx_conf,
                               struct rte_mempool *mp)
 {
-       struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;
+       struct bnxt *bp = eth_dev->data->dev_private;
+       uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;
        struct bnxt_rx_queue *rxq;
+       int rc = 0;
+       uint8_t queue_state;
 
-       if (!nb_desc || nb_desc > MAX_RX_DESC_CNT) {
-               RTE_LOG(ERR, PMD, "nb_desc %d is invalid", nb_desc);
+       rc = is_bnxt_in_error(bp);
+       if (rc)
+               return rc;
+
+       if (queue_idx >= BNXT_MAX_RINGS(bp)) {
+               PMD_DRV_LOG(ERR,
+                       "Cannot create Rx ring %d. Only %d rings available\n",
+                       queue_idx, bp->max_rx_rings);
                return -EINVAL;
        }
 
+       if (!nb_desc || nb_desc > MAX_RX_DESC_CNT) {
+               PMD_DRV_LOG(ERR, "nb_desc %d is invalid\n", nb_desc);
+               rc = -EINVAL;
+               goto out;
+       }
+
        if (eth_dev->data->rx_queues) {
                rxq = eth_dev->data->rx_queues[queue_idx];
                if (rxq)
@@ -265,23 +317,249 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
        rxq = rte_zmalloc_socket("bnxt_rx_queue", sizeof(struct bnxt_rx_queue),
                                 RTE_CACHE_LINE_SIZE, socket_id);
        if (!rxq) {
-               RTE_LOG(ERR, PMD, "bnxt_rx_queue allocation failed!");
-               return -ENOMEM;
+               PMD_DRV_LOG(ERR, "bnxt_rx_queue allocation failed!\n");
+               rc = -ENOMEM;
+               goto out;
        }
        rxq->bp = bp;
        rxq->mb_pool = mp;
        rxq->nb_rx_desc = nb_desc;
        rxq->rx_free_thresh = rx_conf->rx_free_thresh;
 
-       /* TODO: Initialize ring structure */
+       PMD_DRV_LOG(DEBUG, "RX Buf MTU %d\n", eth_dev->data->mtu);
+
+       rc = bnxt_init_rx_ring_struct(rxq, socket_id);
+       if (rc)
+               goto out;
 
+       PMD_DRV_LOG(DEBUG, "RX Buf size is %d\n", rxq->rx_buf_size);
        rxq->queue_id = queue_idx;
        rxq->port_id = eth_dev->data->port_id;
-       rxq->crc_len = (uint8_t)((eth_dev->data->dev_conf.rxmode.hw_strip_crc) ?
-                               0 : ETHER_CRC_LEN);
+       if (rx_offloads & DEV_RX_OFFLOAD_KEEP_CRC)
+               rxq->crc_len = RTE_ETHER_CRC_LEN;
+       else
+               rxq->crc_len = 0;
 
        eth_dev->data->rx_queues[queue_idx] = rxq;
-       /* TODO: Allocate RX ring hardware descriptors */
+       /* Allocate RX ring hardware descriptors */
+       if (bnxt_alloc_rings(bp, queue_idx, NULL, rxq, rxq->cp_ring, NULL,
+                            "rxr")) {
+               PMD_DRV_LOG(ERR,
+                       "ring_dma_zone_reserve for rx_ring failed!\n");
+               bnxt_rx_queue_release_op(rxq);
+               rc = -ENOMEM;
+               goto out;
+       }
+       rte_atomic64_init(&rxq->rx_mbuf_alloc_fail);
+
+       /* rxq 0 must not be stopped when used as async CPR */
+       if (!BNXT_NUM_ASYNC_CPR(bp) && queue_idx == 0)
+               rxq->rx_deferred_start = false;
+       else
+               rxq->rx_deferred_start = rx_conf->rx_deferred_start;
+
+       if (rxq->rx_deferred_start) {
+               queue_state = RTE_ETH_QUEUE_STATE_STOPPED;
+               rxq->rx_started = false;
+       } else {
+               queue_state = RTE_ETH_QUEUE_STATE_STARTED;
+               rxq->rx_started = true;
+       }
+       eth_dev->data->rx_queue_state[queue_idx] = queue_state;
+       rte_spinlock_init(&rxq->lock);
+
+       /* Configure mtu if it is different from what was configured before */
+       if (!queue_idx)
+               bnxt_mtu_set_op(eth_dev, eth_dev->data->mtu);
+
+out:
+       return rc;
+}
+
+int
+bnxt_rx_queue_intr_enable_op(struct rte_eth_dev *eth_dev, uint16_t queue_id)
+{
+       struct bnxt *bp = eth_dev->data->dev_private;
+       struct bnxt_rx_queue *rxq;
+       struct bnxt_cp_ring_info *cpr;
+       int rc = 0;
+
+       rc = is_bnxt_in_error(bp);
+       if (rc)
+               return rc;
+
+       if (eth_dev->data->rx_queues) {
+               rxq = eth_dev->data->rx_queues[queue_id];
+               if (!rxq)
+                       return -EINVAL;
+
+               cpr = rxq->cp_ring;
+               B_CP_DB_REARM(cpr, cpr->cp_raw_cons);
+       }
+       return rc;
+}
+
+int
+bnxt_rx_queue_intr_disable_op(struct rte_eth_dev *eth_dev, uint16_t queue_id)
+{
+       struct bnxt *bp = eth_dev->data->dev_private;
+       struct bnxt_rx_queue *rxq;
+       struct bnxt_cp_ring_info *cpr;
+       int rc = 0;
+
+       rc = is_bnxt_in_error(bp);
+       if (rc)
+               return rc;
+
+       if (eth_dev->data->rx_queues) {
+               rxq = eth_dev->data->rx_queues[queue_id];
+               if (!rxq)
+                       return -EINVAL;
+
+               cpr = rxq->cp_ring;
+               B_CP_DB_DISARM(cpr);
+       }
+       return rc;
+}
+
+int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+       struct bnxt *bp = dev->data->dev_private;
+       struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
+       struct bnxt_rx_queue *rxq = bp->rx_queues[rx_queue_id];
+       struct bnxt_vnic_info *vnic = NULL;
+       int rc = 0;
+
+       rc = is_bnxt_in_error(bp);
+       if (rc)
+               return rc;
+
+       if (rxq == NULL) {
+               PMD_DRV_LOG(ERR, "Invalid Rx queue %d\n", rx_queue_id);
+               return -EINVAL;
+       }
 
-       return 0;
+       /* Set the queue state to started here.
+        * We check the status of the queue while posting buffer.
+        * If queue is it started, we do not post buffers for Rx.
+        */
+       rxq->rx_started = true;
+       dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
+
+       bnxt_free_hwrm_rx_ring(bp, rx_queue_id);
+       rc = bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id);
+       if (rc)
+               return rc;
+
+       if (BNXT_CHIP_THOR(bp)) {
+               /* Reconfigure default receive ring and MRU. */
+               bnxt_hwrm_vnic_cfg(bp, rxq->vnic);
+       }
+       PMD_DRV_LOG(INFO, "Rx queue started %d\n", rx_queue_id);
+
+       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
+               vnic = rxq->vnic;
+
+               if (BNXT_HAS_RING_GRPS(bp)) {
+                       if (vnic->fw_grp_ids[rx_queue_id] != INVALID_HW_RING_ID)
+                               return 0;
+
+                       vnic->fw_grp_ids[rx_queue_id] =
+                                       bp->grp_info[rx_queue_id].fw_grp_id;
+                       PMD_DRV_LOG(DEBUG,
+                                   "vnic = %p fw_grp_id = %d\n",
+                                   vnic, bp->grp_info[rx_queue_id].fw_grp_id);
+               }
+
+               PMD_DRV_LOG(DEBUG, "Rx Queue Count %d\n", vnic->rx_queue_cnt);
+               rc = bnxt_vnic_rss_configure(bp, vnic);
+       }
+
+       if (rc != 0) {
+               dev->data->rx_queue_state[rx_queue_id] =
+                               RTE_ETH_QUEUE_STATE_STOPPED;
+               rxq->rx_started = false;
+       }
+
+       PMD_DRV_LOG(INFO,
+                   "queue %d, rx_deferred_start %d, state %d!\n",
+                   rx_queue_id, rxq->rx_deferred_start,
+                   bp->eth_dev->data->rx_queue_state[rx_queue_id]);
+
+       return rc;
+}
+
+int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+       struct bnxt *bp = dev->data->dev_private;
+       struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
+       struct bnxt_vnic_info *vnic = NULL;
+       struct bnxt_rx_queue *rxq = NULL;
+       int active_queue_cnt = 0;
+       int i, rc = 0;
+
+       rc = is_bnxt_in_error(bp);
+       if (rc)
+               return rc;
+
+       /* For the stingray platform and other platforms needing tighter
+        * control of resource utilization, Rx CQ 0 also works as
+        * Default CQ for async notifications
+        */
+       if (!BNXT_NUM_ASYNC_CPR(bp) && !rx_queue_id) {
+               PMD_DRV_LOG(ERR, "Cannot stop Rx queue id %d\n", rx_queue_id);
+               return -EINVAL;
+       }
+
+       rxq = bp->rx_queues[rx_queue_id];
+       vnic = rxq->vnic;
+
+       if (!rxq || !vnic) {
+               PMD_DRV_LOG(ERR, "Invalid Rx queue %d\n", rx_queue_id);
+               return -EINVAL;
+       }
+
+       dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;
+       rxq->rx_started = false;
+       PMD_DRV_LOG(DEBUG, "Rx queue stopped\n");
+
+       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
+               if (BNXT_HAS_RING_GRPS(bp))
+                       vnic->fw_grp_ids[rx_queue_id] = INVALID_HW_RING_ID;
+
+               PMD_DRV_LOG(DEBUG, "Rx Queue Count %d\n", vnic->rx_queue_cnt);
+               rc = bnxt_vnic_rss_configure(bp, vnic);
+       }
+
+       if (BNXT_CHIP_THOR(bp)) {
+               /* Compute current number of active receive queues. */
+               for (i = vnic->start_grp_id; i < vnic->end_grp_id; i++)
+                       if (bp->rx_queues[i]->rx_started)
+                               active_queue_cnt++;
+
+               /*
+                * For Thor, we need to ensure that the VNIC default receive
+                * ring corresponds to an active receive queue. When no queue
+                * is active, we need to temporarily set the MRU to zero so
+                * that packets are dropped early in the receive pipeline in
+                * order to prevent the VNIC default receive ring from being
+                * accessed.
+                */
+               if (active_queue_cnt == 0) {
+                       uint16_t saved_mru = vnic->mru;
+
+                       vnic->mru = 0;
+                       /* Reconfigure default receive ring and MRU. */
+                       bnxt_hwrm_vnic_cfg(bp, vnic);
+                       vnic->mru = saved_mru;
+               } else {
+                       /* Reconfigure default receive ring. */
+                       bnxt_hwrm_vnic_cfg(bp, vnic);
+               }
+       }
+
+       if (rc == 0)
+               bnxt_rx_queue_release_mbufs(rxq);
+
+       return rc;
 }