net/bnxt: fix Rx checksum flags
[dpdk.git] / drivers / net / bnxt / bnxt_rxr.c
index bf9f78a..b384b6e 100644 (file)
@@ -65,17 +65,17 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,
 {
        struct rx_prod_pkt_bd *rxbd = &rxr->rx_desc_ring[prod];
        struct bnxt_sw_rx_bd *rx_buf = &rxr->rx_buf_ring[prod];
-       struct rte_mbuf *data;
+       struct rte_mbuf *mbuf;
 
-       data = __bnxt_alloc_rx_data(rxq->mb_pool);
-       if (!data) {
+       mbuf = __bnxt_alloc_rx_data(rxq->mb_pool);
+       if (!mbuf) {
                rte_atomic64_inc(&rxq->bp->rx_mbuf_alloc_fail);
                return -ENOMEM;
        }
 
-       rx_buf->mbuf = data;
+       rx_buf->mbuf = mbuf;
 
-       rxbd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(rx_buf->mbuf));
+       rxbd->addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbuf));
 
        return 0;
 }
@@ -86,23 +86,23 @@ static inline int bnxt_alloc_ag_data(struct bnxt_rx_queue *rxq,
 {
        struct rx_prod_pkt_bd *rxbd = &rxr->ag_desc_ring[prod];
        struct bnxt_sw_rx_bd *rx_buf = &rxr->ag_buf_ring[prod];
-       struct rte_mbuf *data;
+       struct rte_mbuf *mbuf;
 
-       data = __bnxt_alloc_rx_data(rxq->mb_pool);
-       if (!data) {
+       mbuf = __bnxt_alloc_rx_data(rxq->mb_pool);
+       if (!mbuf) {
                rte_atomic64_inc(&rxq->bp->rx_mbuf_alloc_fail);
                return -ENOMEM;
        }
 
        if (rxbd == NULL)
-               RTE_LOG(ERR, PMD, "Jumbo Frame. rxbd is NULL\n");
+               PMD_DRV_LOG(ERR, "Jumbo Frame. rxbd is NULL\n");
        if (rx_buf == NULL)
-               RTE_LOG(ERR, PMD, "Jumbo Frame. rx_buf is NULL\n");
+               PMD_DRV_LOG(ERR, "Jumbo Frame. rx_buf is NULL\n");
 
 
-       rx_buf->mbuf = data;
+       rx_buf->mbuf = mbuf;
 
-       rxbd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(rx_buf->mbuf));
+       rxbd->addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbuf));
 
        return 0;
 }
@@ -123,7 +123,7 @@ static inline void bnxt_reuse_rx_mbuf(struct bnxt_rx_ring_info *rxr,
 
        prod_bd = &rxr->rx_desc_ring[prod];
 
-       prod_bd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(mbuf));
+       prod_bd->addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mbuf));
 
        rxr->rx_prod = prod;
 }
@@ -199,7 +199,7 @@ static void bnxt_tpa_start(struct bnxt_rx_queue *rxq,
        if (tpa_start1->flags2 &
            rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS2_META_FORMAT_VLAN)) {
                mbuf->vlan_tci = rte_le_to_cpu_32(tpa_start1->metadata);
-               mbuf->ol_flags |= PKT_RX_VLAN_PKT;
+               mbuf->ol_flags |= PKT_RX_VLAN;
        }
        if (likely(tpa_start1->flags2 &
                   rte_cpu_to_le_32(RX_TPA_START_CMPL_FLAGS2_L4_CS_CALC)))
@@ -219,6 +219,9 @@ static int bnxt_agg_bufs_valid(struct bnxt_cp_ring_info *cpr,
        raw_cp_cons = ADV_RAW_CMP(raw_cp_cons, agg_bufs);
        last_cp_cons = RING_CMP(cpr->cp_ring_struct, raw_cp_cons);
        agg_cmpl = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[last_cp_cons];
+       cpr->valid = FLIP_VALID(raw_cp_cons,
+                               cpr->cp_ring_struct->ring_mask,
+                               cpr->valid);
        return CMP_VALID(agg_cmpl, raw_cp_cons, cpr->cp_ring_struct);
 }
 
@@ -231,7 +234,7 @@ static int bnxt_prod_ag_mbuf(struct bnxt_rx_queue *rxq)
        /* TODO batch allocation for better performance */
        while (rte_bitmap_get(rxr->ag_bitmap, next)) {
                if (unlikely(bnxt_alloc_ag_data(rxq, rxr, next))) {
-                       RTE_LOG(ERR, PMD,
+                       PMD_DRV_LOG(ERR,
                                "agg mbuf alloc failed: prod=0x%x\n", next);
                        break;
                }
@@ -332,6 +335,48 @@ static inline struct rte_mbuf *bnxt_tpa_end(
        return mbuf;
 }
 
+static uint32_t
+bnxt_parse_pkt_type(struct rx_pkt_cmpl *rxcmp, struct rx_pkt_cmpl_hi *rxcmp1)
+{
+       uint32_t pkt_type = 0;
+       uint32_t t_ipcs = 0, ip = 0, ip6 = 0;
+       uint32_t tcp = 0, udp = 0, icmp = 0;
+       uint32_t vlan = 0;
+
+       vlan = !!(rxcmp1->flags2 &
+               rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN));
+       t_ipcs = !!(rxcmp1->flags2 &
+               rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC));
+       ip6 = !!(rxcmp1->flags2 &
+                rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_IP_TYPE));
+       icmp = !!(rxcmp->flags_type &
+                 rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_ICMP));
+       tcp = !!(rxcmp->flags_type &
+                rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_TCP));
+       udp = !!(rxcmp->flags_type &
+                rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_UDP));
+       ip = !!(rxcmp->flags_type &
+               rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_IP));
+
+       pkt_type |= ((ip || tcp || udp || icmp) && !t_ipcs && !ip6) ?
+               RTE_PTYPE_L3_IPV4_EXT_UNKNOWN : 0;
+       pkt_type |= ((ip || tcp || udp || icmp) && !t_ipcs && ip6) ?
+               RTE_PTYPE_L3_IPV6_EXT_UNKNOWN : 0;
+       pkt_type |= (!t_ipcs &&  icmp) ? RTE_PTYPE_L4_ICMP : 0;
+       pkt_type |= (!t_ipcs &&  udp) ? RTE_PTYPE_L4_UDP : 0;
+       pkt_type |= (!t_ipcs &&  tcp) ? RTE_PTYPE_L4_TCP : 0;
+       pkt_type |= ((ip || tcp || udp || icmp) && t_ipcs && !ip6) ?
+               RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN : 0;
+       pkt_type |= ((ip || tcp || udp || icmp) && t_ipcs && ip6) ?
+               RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN : 0;
+       pkt_type |= (t_ipcs &&  icmp) ? RTE_PTYPE_INNER_L4_ICMP : 0;
+       pkt_type |= (t_ipcs &&  udp) ? RTE_PTYPE_INNER_L4_UDP : 0;
+       pkt_type |= (t_ipcs &&  tcp) ? RTE_PTYPE_INNER_L4_TCP : 0;
+       pkt_type |= vlan ? RTE_PTYPE_L2_ETHER_VLAN : 0;
+
+       return pkt_type;
+}
+
 static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
                            struct bnxt_rx_queue *rxq, uint32_t *raw_cons)
 {
@@ -360,13 +405,17 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
        if (!CMP_VALID(rxcmp1, tmp_raw_cons, cpr->cp_ring_struct))
                return -EBUSY;
 
+       cpr->valid = FLIP_VALID(cp_cons,
+                               cpr->cp_ring_struct->ring_mask,
+                               cpr->valid);
+
        cmp_type = CMP_TYPE(rxcmp);
-       if (cmp_type == RX_PKT_CMPL_TYPE_RX_L2_TPA_START) {
+       if (cmp_type == RX_TPA_START_CMPL_TYPE_RX_TPA_START) {
                bnxt_tpa_start(rxq, (struct rx_tpa_start_cmpl *)rxcmp,
                               (struct rx_tpa_start_cmpl_hi *)rxcmp1);
                rc = -EINVAL; /* Continue w/o new mbuf */
                goto next_rx;
-       } else if (cmp_type == RX_PKT_CMPL_TYPE_RX_L2_TPA_END) {
+       } else if (cmp_type == RX_TPA_END_CMPL_TYPE_RX_TPA_END) {
                mbuf = bnxt_tpa_end(rxq, &tmp_raw_cons,
                                   (struct rx_tpa_end_cmpl *)rxcmp,
                                   (struct rx_tpa_end_cmpl_hi *)rxcmp1);
@@ -388,11 +437,12 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
 
        cons = rxcmp->opaque;
        mbuf = bnxt_consume_rx_buf(rxr, cons);
-       rte_prefetch0(mbuf);
-
        if (mbuf == NULL)
                return -EBUSY;
 
+       rte_prefetch0(mbuf);
+
+       mbuf->data_off = RTE_PKTMBUF_HEADROOM;
        mbuf->nb_segs = 1;
        mbuf->next = NULL;
        mbuf->pkt_len = rxcmp->len;
@@ -407,6 +457,10 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
                mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
        }
 
+       if ((rxcmp->flags_type & rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_MASK)) ==
+            RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)
+               mbuf->ol_flags |= PKT_RX_IEEE1588_PTP | PKT_RX_IEEE1588_TMST;
+
        if (agg_buf)
                bnxt_rx_pages(rxq, mbuf, &tmp_raw_cons, agg_buf);
 
@@ -415,9 +469,21 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
                        (RX_PKT_CMPL_METADATA_VID_MASK |
                        RX_PKT_CMPL_METADATA_DE |
                        RX_PKT_CMPL_METADATA_PRI_MASK);
-               mbuf->ol_flags |= PKT_RX_VLAN_PKT;
+               mbuf->ol_flags |= PKT_RX_VLAN;
        }
 
+       if (likely(RX_CMP_IP_CS_OK(rxcmp1)))
+               mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
+       else
+               mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
+
+       if (likely(RX_CMP_L4_CS_OK(rxcmp1)))
+               mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
+       else
+               mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
+
+       mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1);
+
 #ifdef BNXT_DEBUG
        if (rxcmp1->errors_v2 & RX_CMP_L2_ERRORS) {
                /* Re-install the mbuf back to the rx ring */
@@ -446,7 +512,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
         */
        prod = RING_NEXT(rxr->rx_ring_struct, prod);
        if (bnxt_alloc_rx_data(rxq, rxr, prod)) {
-               RTE_LOG(ERR, PMD, "mbuf alloc failed with prod=0x%x\n", prod);
+               PMD_DRV_LOG(ERR, "mbuf alloc failed with prod=0x%x\n", prod);
                rc = -ENOMEM;
                goto rx;
        }
@@ -479,16 +545,21 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
        uint16_t ag_prod = rxr->ag_prod;
        int rc = 0;
 
+       /* If Rx Q was stopped return */
+       if (rxq->rx_deferred_start)
+               return 0;
+
        /* Handle RX burst request */
        while (1) {
-               int rc;
-
                cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
                rte_prefetch0(&cpr->cp_desc_ring[cons]);
                rxcmp = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[cons];
 
                if (!CMP_VALID(rxcmp, raw_cons, cpr->cp_ring_struct))
                        break;
+               cpr->valid = FLIP_VALID(cons,
+                                       cpr->cp_ring_struct->ring_mask,
+                                       cpr->valid);
 
                /* TODO: Avoid magic numbers... */
                if ((CMP_TYPE(rxcmp) & 0x30) == 0x10) {
@@ -534,7 +605,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                                rxr->rx_prod = i;
                                B_RX_DB(rxr->rx_doorbell, rxr->rx_prod);
                        } else {
-                               RTE_LOG(ERR, PMD, "Alloc  mbuf failed\n");
+                               PMD_DRV_LOG(ERR, "Alloc  mbuf failed\n");
                                break;
                        }
                }
@@ -677,7 +748,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
        prod = rxr->rx_prod;
        for (i = 0; i < ring->ring_size; i++) {
                if (bnxt_alloc_rx_data(rxq, rxr, prod) != 0) {
-                       RTE_LOG(WARNING, PMD,
+                       PMD_DRV_LOG(WARNING,
                                "init'ed rx ring %d with %d/%d mbufs only\n",
                                rxq->queue_id, i, ring->ring_size);
                        break;
@@ -685,7 +756,6 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
                rxr->rx_prod = prod;
                prod = RING_NEXT(rxr->rx_ring_struct, prod);
        }
-       RTE_LOG(DEBUG, PMD, "%s\n", __func__);
 
        ring = rxr->ag_ring_struct;
        type = RX_PROD_AGG_BD_TYPE_RX_PROD_AGG;
@@ -694,7 +764,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
 
        for (i = 0; i < ring->ring_size; i++) {
                if (bnxt_alloc_ag_data(rxq, rxr, prod) != 0) {
-                       RTE_LOG(WARNING, PMD,
+                       PMD_DRV_LOG(WARNING,
                        "init'ed AG ring %d with %d/%d mbufs only\n",
                        rxq->queue_id, i, ring->ring_size);
                        break;
@@ -702,7 +772,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
                rxr->ag_prod = prod;
                prod = RING_NEXT(rxr->ag_ring_struct, prod);
        }
-       RTE_LOG(DEBUG, PMD, "%s AGG Done!\n", __func__);
+       PMD_DRV_LOG(DEBUG, "AGG Done!\n");
 
        if (rxr->tpa_info) {
                for (i = 0; i < BNXT_TPA_MAX; i++) {
@@ -714,7 +784,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
                        }
                }
        }
-       RTE_LOG(DEBUG, PMD, "%s TPA alloc Done!\n", __func__);
+       PMD_DRV_LOG(DEBUG, "TPA alloc Done!\n");
 
        return 0;
 }