net/bnxt: add core changes for EM and EEM lookups
[dpdk.git] / drivers / net / bnxt / tf_core / tf_em.c
index 38f7fe4..fcbbd7e 100644 (file)
 
 #include "bnxt.h"
 
-/* Enable EEM table dump
- */
-#define TF_EEM_DUMP
-
-static struct tf_eem_64b_entry zero_key_entry;
 
 static uint32_t tf_em_get_key_mask(int num_entries)
 {
@@ -36,326 +31,22 @@ static uint32_t tf_em_get_key_mask(int num_entries)
        return mask;
 }
 
-/* CRC32i support for Key0 hash */
-#define ucrc32(ch, crc) (crc32tbl[((crc) ^ (ch)) & 0xff] ^ ((crc) >> 8))
-#define crc32(x, y) crc32i(~0, x, y)
-
-static const uint32_t crc32tbl[] = {   /* CRC polynomial 0xedb88320 */
-0x00000000, 0x77073096, 0xee0e612c, 0x990951ba,
-0x076dc419, 0x706af48f, 0xe963a535, 0x9e6495a3,
-0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988,
-0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91,
-0x1db71064, 0x6ab020f2, 0xf3b97148, 0x84be41de,
-0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7,
-0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec,
-0x14015c4f, 0x63066cd9, 0xfa0f3d63, 0x8d080df5,
-0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172,
-0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b,
-0x35b5a8fa, 0x42b2986c, 0xdbbbc9d6, 0xacbcf940,
-0x32d86ce3, 0x45df5c75, 0xdcd60dcf, 0xabd13d59,
-0x26d930ac, 0x51de003a, 0xc8d75180, 0xbfd06116,
-0x21b4f4b5, 0x56b3c423, 0xcfba9599, 0xb8bda50f,
-0x2802b89e, 0x5f058808, 0xc60cd9b2, 0xb10be924,
-0x2f6f7c87, 0x58684c11, 0xc1611dab, 0xb6662d3d,
-0x76dc4190, 0x01db7106, 0x98d220bc, 0xefd5102a,
-0x71b18589, 0x06b6b51f, 0x9fbfe4a5, 0xe8b8d433,
-0x7807c9a2, 0x0f00f934, 0x9609a88e, 0xe10e9818,
-0x7f6a0dbb, 0x086d3d2d, 0x91646c97, 0xe6635c01,
-0x6b6b51f4, 0x1c6c6162, 0x856530d8, 0xf262004e,
-0x6c0695ed, 0x1b01a57b, 0x8208f4c1, 0xf50fc457,
-0x65b0d9c6, 0x12b7e950, 0x8bbeb8ea, 0xfcb9887c,
-0x62dd1ddf, 0x15da2d49, 0x8cd37cf3, 0xfbd44c65,
-0x4db26158, 0x3ab551ce, 0xa3bc0074, 0xd4bb30e2,
-0x4adfa541, 0x3dd895d7, 0xa4d1c46d, 0xd3d6f4fb,
-0x4369e96a, 0x346ed9fc, 0xad678846, 0xda60b8d0,
-0x44042d73, 0x33031de5, 0xaa0a4c5f, 0xdd0d7cc9,
-0x5005713c, 0x270241aa, 0xbe0b1010, 0xc90c2086,
-0x5768b525, 0x206f85b3, 0xb966d409, 0xce61e49f,
-0x5edef90e, 0x29d9c998, 0xb0d09822, 0xc7d7a8b4,
-0x59b33d17, 0x2eb40d81, 0xb7bd5c3b, 0xc0ba6cad,
-0xedb88320, 0x9abfb3b6, 0x03b6e20c, 0x74b1d29a,
-0xead54739, 0x9dd277af, 0x04db2615, 0x73dc1683,
-0xe3630b12, 0x94643b84, 0x0d6d6a3e, 0x7a6a5aa8,
-0xe40ecf0b, 0x9309ff9d, 0x0a00ae27, 0x7d079eb1,
-0xf00f9344, 0x8708a3d2, 0x1e01f268, 0x6906c2fe,
-0xf762575d, 0x806567cb, 0x196c3671, 0x6e6b06e7,
-0xfed41b76, 0x89d32be0, 0x10da7a5a, 0x67dd4acc,
-0xf9b9df6f, 0x8ebeeff9, 0x17b7be43, 0x60b08ed5,
-0xd6d6a3e8, 0xa1d1937e, 0x38d8c2c4, 0x4fdff252,
-0xd1bb67f1, 0xa6bc5767, 0x3fb506dd, 0x48b2364b,
-0xd80d2bda, 0xaf0a1b4c, 0x36034af6, 0x41047a60,
-0xdf60efc3, 0xa867df55, 0x316e8eef, 0x4669be79,
-0xcb61b38c, 0xbc66831a, 0x256fd2a0, 0x5268e236,
-0xcc0c7795, 0xbb0b4703, 0x220216b9, 0x5505262f,
-0xc5ba3bbe, 0xb2bd0b28, 0x2bb45a92, 0x5cb36a04,
-0xc2d7ffa7, 0xb5d0cf31, 0x2cd99e8b, 0x5bdeae1d,
-0x9b64c2b0, 0xec63f226, 0x756aa39c, 0x026d930a,
-0x9c0906a9, 0xeb0e363f, 0x72076785, 0x05005713,
-0x95bf4a82, 0xe2b87a14, 0x7bb12bae, 0x0cb61b38,
-0x92d28e9b, 0xe5d5be0d, 0x7cdcefb7, 0x0bdbdf21,
-0x86d3d2d4, 0xf1d4e242, 0x68ddb3f8, 0x1fda836e,
-0x81be16cd, 0xf6b9265b, 0x6fb077e1, 0x18b74777,
-0x88085ae6, 0xff0f6a70, 0x66063bca, 0x11010b5c,
-0x8f659eff, 0xf862ae69, 0x616bffd3, 0x166ccf45,
-0xa00ae278, 0xd70dd2ee, 0x4e048354, 0x3903b3c2,
-0xa7672661, 0xd06016f7, 0x4969474d, 0x3e6e77db,
-0xaed16a4a, 0xd9d65adc, 0x40df0b66, 0x37d83bf0,
-0xa9bcae53, 0xdebb9ec5, 0x47b2cf7f, 0x30b5ffe9,
-0xbdbdf21c, 0xcabac28a, 0x53b39330, 0x24b4a3a6,
-0xbad03605, 0xcdd70693, 0x54de5729, 0x23d967bf,
-0xb3667a2e, 0xc4614ab8, 0x5d681b02, 0x2a6f2b94,
-0xb40bbe37, 0xc30c8ea1, 0x5a05df1b, 0x2d02ef8d
-};
-
-static uint32_t crc32i(uint32_t crc, const uint8_t *buf, size_t len)
-{
-       int l;
-
-       for (l = (len - 1); l >= 0; l--)
-               crc = ucrc32(buf[l], crc);
-
-       return ~crc;
-}
-
-static uint32_t tf_em_lkup_get_crc32_hash(struct tf_session *session,
-                                         uint8_t *key,
-                                         enum tf_dir dir)
-{
-       int i;
-       uint32_t index;
-       uint32_t val1, val2;
-       uint8_t temp[4];
-       uint8_t *kptr = key;
-
-       /* Do byte-wise XOR of the 52-byte HASH key first. */
-       index = *key;
-       kptr--;
-
-       for (i = TF_HW_EM_KEY_MAX_SIZE - 2; i >= 0; i--) {
-               index = index ^ *kptr;
-               kptr--;
-       }
-
-       /* Get seeds */
-       val1 = session->lkup_em_seed_mem[dir][index * 2];
-       val2 = session->lkup_em_seed_mem[dir][index * 2 + 1];
-
-       temp[3] = (uint8_t)(val1 >> 24);
-       temp[2] = (uint8_t)(val1 >> 16);
-       temp[1] = (uint8_t)(val1 >> 8);
-       temp[0] = (uint8_t)(val1 & 0xff);
-       val1 = 0;
-
-       /* Start with seed */
-       if (!(val2 & 0x1))
-               val1 = crc32i(~val1, temp, 4);
-
-       val1 = crc32i(~val1,
-                     (key - (TF_HW_EM_KEY_MAX_SIZE - 1)),
-                     TF_HW_EM_KEY_MAX_SIZE);
-
-       /* End with seed */
-       if (val2 & 0x1)
-               val1 = crc32i(~val1, temp, 4);
-
-       return val1;
-}
-
-static uint32_t tf_em_lkup_get_lookup3_hash(uint32_t lookup3_init_value,
-                                           uint8_t *in_key)
-{
-       uint32_t val1;
-
-       val1 = hashword(((uint32_t *)in_key) + 1,
-                        TF_HW_EM_KEY_MAX_SIZE / (sizeof(uint32_t)),
-                        lookup3_init_value);
-
-       return val1;
-}
-
-void *tf_em_get_table_page(struct tf_tbl_scope_cb *tbl_scope_cb,
-                          enum tf_dir dir,
-                          uint32_t offset,
-                          enum tf_em_table_type table_type)
-{
-       int level = 0;
-       int page = offset / TF_EM_PAGE_SIZE;
-       void *addr = NULL;
-       struct tf_em_ctx_mem_info *ctx = &tbl_scope_cb->em_ctx_info[dir];
-
-       if (ctx == NULL)
-               return NULL;
-
-       if (dir != TF_DIR_RX && dir != TF_DIR_TX)
-               return NULL;
-
-       if (table_type < TF_KEY0_TABLE || table_type > TF_EFC_TABLE)
-               return NULL;
-
-       /*
-        * Use the level according to the num_level of page table
-        */
-       level = ctx->em_tables[table_type].num_lvl - 1;
-
-       addr = (void *)ctx->em_tables[table_type].pg_tbl[level].pg_va_tbl[page];
-
-       return addr;
-}
-
-/** Read Key table entry
- *
- * Entry is read in to entry
- */
-static int tf_em_read_entry(struct tf_tbl_scope_cb *tbl_scope_cb,
-                                struct tf_eem_64b_entry *entry,
-                                uint32_t entry_size,
-                                uint32_t index,
-                                enum tf_em_table_type table_type,
-                                enum tf_dir dir)
-{
-       void *page;
-       uint32_t entry_offset = (index * entry_size) % TF_EM_PAGE_SIZE;
-
-       page = tf_em_get_table_page(tbl_scope_cb,
-                                   dir,
-                                   (index * entry_size),
-                                   table_type);
-
-       if (page == NULL)
-               return -EINVAL;
-
-       memcpy((uint8_t *)entry, (uint8_t *)page + entry_offset, entry_size);
-       return 0;
-}
-
-static int tf_em_write_entry(struct tf_tbl_scope_cb *tbl_scope_cb,
-                                struct tf_eem_64b_entry *entry,
-                                uint32_t entry_size,
-                                uint32_t index,
-                                enum tf_em_table_type table_type,
-                                enum tf_dir dir)
-{
-       void *page;
-       uint32_t entry_offset = (index * entry_size) % TF_EM_PAGE_SIZE;
-
-       page = tf_em_get_table_page(tbl_scope_cb,
-                                   dir,
-                                   (index * entry_size),
-                                   table_type);
-
-       if (page == NULL)
-               return -EINVAL;
-
-       memcpy((uint8_t *)page + entry_offset, entry, entry_size);
-
-       return 0;
-}
-
-static int tf_em_entry_exists(struct tf_tbl_scope_cb *tbl_scope_cb,
-                              struct tf_eem_64b_entry *entry,
-                              uint32_t index,
-                              enum tf_em_table_type table_type,
-                              enum tf_dir dir)
-{
-       int rc;
-       struct tf_eem_64b_entry table_entry;
-
-       rc = tf_em_read_entry(tbl_scope_cb,
-                             &table_entry,
-                             TF_EM_KEY_RECORD_SIZE,
-                             index,
-                             table_type,
-                             dir);
-
-       if (rc != 0)
-               return -EINVAL;
-
-       if (table_entry.hdr.word1 & (1 << TF_LKUP_RECORD_VALID_SHIFT)) {
-               if (entry != NULL) {
-                       if (memcmp(&table_entry,
-                                  entry,
-                                  TF_EM_KEY_RECORD_SIZE) == 0)
-                               return -EEXIST;
-               } else {
-                       return -EEXIST;
-               }
-
-               return -EBUSY;
-       }
-
-       return 0;
-}
-
-static void tf_em_create_key_entry(struct tf_eem_entry_hdr *result,
-                                   uint8_t *in_key,
-                                   struct tf_eem_64b_entry *key_entry)
+static void tf_em_create_key_entry(struct cfa_p4_eem_entry_hdr *result,
+                                  uint8_t             *in_key,
+                                  struct cfa_p4_eem_64b_entry *key_entry)
 {
        key_entry->hdr.word1 = result->word1;
 
-       if (result->word1 & TF_LKUP_RECORD_ACT_REC_INT_MASK)
+       if (result->word1 & CFA_P4_EEM_ENTRY_ACT_REC_INT_MASK)
                key_entry->hdr.pointer = result->pointer;
        else
                key_entry->hdr.pointer = result->pointer;
 
        memcpy(key_entry->key, in_key, TF_HW_EM_KEY_MAX_SIZE + 4);
-}
-
-/* tf_em_select_inject_table
- *
- * Returns:
- * 0 - Key does not exist in either table and can be inserted
- *             at "index" in table "table".
- * EEXIST  - Key does exist in table at "index" in table "table".
- * TF_ERR     - Something went horribly wrong.
- */
-static int tf_em_select_inject_table(struct tf_tbl_scope_cb *tbl_scope_cb,
-                                         enum tf_dir dir,
-                                         struct tf_eem_64b_entry *entry,
-                                         uint32_t key0_hash,
-                                         uint32_t key1_hash,
-                                         uint32_t *index,
-                                         enum tf_em_table_type *table)
-{
-       int key0_entry;
-       int key1_entry;
-
-       /*
-        * Check KEY0 table.
-        */
-       key0_entry = tf_em_entry_exists(tbl_scope_cb,
-                                        entry,
-                                        key0_hash,
-                                        TF_KEY0_TABLE,
-                                        dir);
 
-       /*
-        * Check KEY1 table.
-        */
-       key1_entry = tf_em_entry_exists(tbl_scope_cb,
-                                        entry,
-                                        key1_hash,
-                                        TF_KEY1_TABLE,
-                                        dir);
-
-       if (key0_entry == -EEXIST) {
-               *table = TF_KEY0_TABLE;
-               *index = key0_hash;
-               return -EEXIST;
-       } else if (key1_entry == -EEXIST) {
-               *table = TF_KEY1_TABLE;
-               *index = key1_hash;
-               return -EEXIST;
-       } else if (key0_entry == 0) {
-               *table = TF_KEY0_TABLE;
-               *index = key0_hash;
-               return 0;
-       } else if (key1_entry == 0) {
-               *table = TF_KEY1_TABLE;
-               *index = key1_hash;
-               return 0;
-       }
-
-       return -EINVAL;
+#ifdef TF_EEM_DEBUG
+       dump_raw((uint8_t *)key_entry, TF_EM_KEY_RECORD_SIZE, "Create raw:");
+#endif
 }
 
 /** insert EEM entry API
@@ -368,20 +59,24 @@ static int tf_em_select_inject_table(struct tf_tbl_scope_cb *tbl_scope_cb,
  *   0
  *   TF_ERR_EM_DUP  - key is already in table
  */
-int tf_insert_eem_entry(struct tf_session *session,
-                       struct tf_tbl_scope_cb *tbl_scope_cb,
-                       struct tf_insert_em_entry_parms *parms)
+static int tf_insert_eem_entry(struct tf_tbl_scope_cb     *tbl_scope_cb,
+                              struct tf_insert_em_entry_parms *parms)
 {
        uint32_t           mask;
        uint32_t           key0_hash;
        uint32_t           key1_hash;
        uint32_t           key0_index;
        uint32_t           key1_index;
-       struct tf_eem_64b_entry key_entry;
+       struct cfa_p4_eem_64b_entry key_entry;
        uint32_t           index;
-       enum tf_em_table_type table_type;
+       enum hcapi_cfa_em_table_type table_type;
        uint32_t           gfid;
-       int                num_of_entry;
+       struct hcapi_cfa_hwop op;
+       struct hcapi_cfa_key_tbl key_tbl;
+       struct hcapi_cfa_key_data key_obj;
+       struct hcapi_cfa_key_loc key_loc;
+       uint64_t big_hash;
+       int rc;
 
        /* Get mask to use on hash */
        mask = tf_em_get_key_mask(tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE].num_entries);
@@ -389,72 +84,84 @@ int tf_insert_eem_entry(struct tf_session *session,
        if (!mask)
                return -EINVAL;
 
-       num_of_entry = TF_HW_EM_KEY_MAX_SIZE + 4;
+#ifdef TF_EEM_DEBUG
+       dump_raw((uint8_t *)parms->key, TF_HW_EM_KEY_MAX_SIZE + 4, "In Key");
+#endif
 
-       key0_hash = tf_em_lkup_get_crc32_hash(session,
-                                             &parms->key[num_of_entry] - 1,
-                                             parms->dir);
-       key0_index = key0_hash & mask;
+       big_hash = hcapi_cfa_key_hash((uint64_t *)parms->key,
+                                     (TF_HW_EM_KEY_MAX_SIZE + 4) * 8);
+       key0_hash = (uint32_t)(big_hash >> 32);
+       key1_hash = (uint32_t)(big_hash & 0xFFFFFFFF);
 
-       key1_hash =
-          tf_em_lkup_get_lookup3_hash(session->lkup_lkup3_init_cfg[parms->dir],
-                                      parms->key);
+       key0_index = key0_hash & mask;
        key1_index = key1_hash & mask;
 
+#ifdef TF_EEM_DEBUG
+       TFP_DRV_LOG(DEBUG, "Key0 hash:0x%08x\n", key0_hash);
+       TFP_DRV_LOG(DEBUG, "Key1 hash:0x%08x\n", key1_hash);
+#endif
        /*
         * Use the "result" arg to populate all of the key entry then
         * store the byte swapped "raw" entry in a local copy ready
         * for insertion in to the table.
         */
-       tf_em_create_key_entry((struct tf_eem_entry_hdr *)parms->em_record,
+       tf_em_create_key_entry((struct cfa_p4_eem_entry_hdr *)parms->em_record,
                                ((uint8_t *)parms->key),
                                &key_entry);
 
        /*
-        * Find which table to use
+        * Try to add to Key0 table, if that does not work then
+        * try the key1 table.
         */
-       if (tf_em_select_inject_table(tbl_scope_cb,
-                                     parms->dir,
-                                     &key_entry,
-                                     key0_index,
-                                     key1_index,
-                                     &index,
-                                     &table_type) == 0) {
-               if (table_type == TF_KEY0_TABLE) {
-                       TF_SET_GFID(gfid,
-                                   key0_index,
-                                   TF_KEY0_TABLE);
-               } else {
-                       TF_SET_GFID(gfid,
-                                   key1_index,
-                                   TF_KEY1_TABLE);
-               }
-
-               /*
-                * Inject
-                */
-               if (tf_em_write_entry(tbl_scope_cb,
-                                     &key_entry,
-                                     TF_EM_KEY_RECORD_SIZE,
-                                     index,
-                                     table_type,
-                                     parms->dir) == 0) {
-                       TF_SET_FLOW_ID(parms->flow_id,
-                                      gfid,
-                                      TF_GFID_TABLE_EXTERNAL,
-                                      parms->dir);
-                       TF_SET_FIELDS_IN_FLOW_HANDLE(parms->flow_handle,
-                                                    0,
-                                                    0,
-                                                    0,
-                                                    index,
-                                                    0,
-                                                    table_type);
-                       return 0;
-               }
+       index = key0_index;
+       op.opcode = HCAPI_CFA_HWOPS_ADD;
+       key_tbl.base0 = (uint8_t *)
+       &tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE];
+       key_obj.offset = (index * TF_EM_KEY_RECORD_SIZE) % TF_EM_PAGE_SIZE;
+       key_obj.data = (uint8_t *)&key_entry;
+       key_obj.size = TF_EM_KEY_RECORD_SIZE;
+
+       rc = hcapi_cfa_key_hw_op(&op,
+                                &key_tbl,
+                                &key_obj,
+                                &key_loc);
+
+       if (rc == 0) {
+               table_type = TF_KEY0_TABLE;
+       } else {
+               index = key1_index;
+
+               key_tbl.base0 = (uint8_t *)
+               &tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY1_TABLE];
+               key_obj.offset =
+                       (index * TF_EM_KEY_RECORD_SIZE) % TF_EM_PAGE_SIZE;
+
+               rc = hcapi_cfa_key_hw_op(&op,
+                                        &key_tbl,
+                                        &key_obj,
+                                        &key_loc);
+               if (rc != 0)
+                       return rc;
+
+               table_type = TF_KEY1_TABLE;
        }
 
-       return -EINVAL;
+       TF_SET_GFID(gfid,
+                   index,
+                   table_type);
+       TF_SET_FLOW_ID(parms->flow_id,
+                      gfid,
+                      TF_GFID_TABLE_EXTERNAL,
+                      parms->dir);
+       TF_SET_FIELDS_IN_FLOW_HANDLE(parms->flow_handle,
+                                    0,
+                                    0,
+                                    0,
+                                    index,
+                                    0,
+                                    table_type);
+
+       return 0;
 }
 
 /**
@@ -463,8 +170,8 @@ int tf_insert_eem_entry(struct tf_session *session,
  *  returns:
  *     0 - Success
  */
-int tf_insert_em_internal_entry(struct tf *tfp,
-                               struct tf_insert_em_entry_parms *parms)
+static int tf_insert_em_internal_entry(struct tf                       *tfp,
+                                      struct tf_insert_em_entry_parms *parms)
 {
        int       rc;
        uint32_t  gfid;
@@ -494,7 +201,7 @@ int tf_insert_em_internal_entry(struct tf *tfp,
        if (rc != 0)
                return -1;
 
-       TFP_DRV_LOG(INFO,
+       PMD_DRV_LOG(ERR,
                   "Internal entry @ Index:%d rptr_index:0x%x rptr_entry:0x%x num_of_entries:%d\n",
                   index * TF_SESSION_EM_ENTRY_SIZE,
                   rptr_index,
@@ -527,8 +234,8 @@ int tf_insert_em_internal_entry(struct tf *tfp,
  * 0
  * -EINVAL
  */
-int tf_delete_em_internal_entry(struct tf *tfp,
-                               struct tf_delete_em_entry_parms *parms)
+static int tf_delete_em_internal_entry(struct tf                       *tfp,
+                                      struct tf_delete_em_entry_parms *parms)
 {
        int rc;
        struct tf_session *session =
@@ -558,46 +265,96 @@ int tf_delete_em_internal_entry(struct tf *tfp,
  *   0
  *   TF_NO_EM_MATCH - entry not found
  */
-int tf_delete_eem_entry(struct tf *tfp,
-                       struct tf_delete_em_entry_parms *parms)
+static int tf_delete_eem_entry(struct tf_tbl_scope_cb *tbl_scope_cb,
+                              struct tf_delete_em_entry_parms *parms)
 {
-       struct tf_session          *session;
-       struct tf_tbl_scope_cb     *tbl_scope_cb;
-       enum tf_em_table_type hash_type;
+       enum hcapi_cfa_em_table_type hash_type;
        uint32_t index;
+       struct hcapi_cfa_hwop op;
+       struct hcapi_cfa_key_tbl key_tbl;
+       struct hcapi_cfa_key_data key_obj;
+       struct hcapi_cfa_key_loc key_loc;
+       int rc;
 
-       if (parms == NULL)
+       if (parms->flow_handle == 0)
                return -EINVAL;
 
-       session = (struct tf_session *)tfp->session->core_data;
-       if (session == NULL)
-               return -EINVAL;
+       TF_GET_HASH_TYPE_FROM_FLOW_HANDLE(parms->flow_handle, hash_type);
+       TF_GET_INDEX_FROM_FLOW_HANDLE(parms->flow_handle, index);
 
-       tbl_scope_cb = tbl_scope_cb_find(session,
-                                        parms->tbl_scope_id);
-       if (tbl_scope_cb == NULL)
-               return -EINVAL;
+       op.opcode = HCAPI_CFA_HWOPS_DEL;
+       key_tbl.base0 = (uint8_t *)
+       &tbl_scope_cb->em_ctx_info[parms->dir].em_tables[(hash_type == 0 ?
+                                                         TF_KEY0_TABLE :
+                                                         TF_KEY1_TABLE)];
+       key_obj.offset = (index * TF_EM_KEY_RECORD_SIZE) % TF_EM_PAGE_SIZE;
+       key_obj.data = NULL;
+       key_obj.size = TF_EM_KEY_RECORD_SIZE;
+
+       rc = hcapi_cfa_key_hw_op(&op,
+                                &key_tbl,
+                                &key_obj,
+                                &key_loc);
+
+       if (!rc)
+               return rc;
 
-       if (parms->flow_handle == 0)
+       return 0;
+}
+
+/** insert EM hash entry API
+ *
+ *    returns:
+ *    0       - Success
+ *    -EINVAL - Error
+ */
+int tf_em_insert_entry(struct tf *tfp,
+                      struct tf_insert_em_entry_parms *parms)
+{
+       struct tf_tbl_scope_cb *tbl_scope_cb;
+
+       tbl_scope_cb = tbl_scope_cb_find
+               ((struct tf_session *)(tfp->session->core_data),
+               parms->tbl_scope_id);
+       if (tbl_scope_cb == NULL) {
+               TFP_DRV_LOG(ERR, "Invalid tbl_scope_cb\n");
                return -EINVAL;
+       }
 
-       TF_GET_HASH_TYPE_FROM_FLOW_HANDLE(parms->flow_handle, hash_type);
-       TF_GET_INDEX_FROM_FLOW_HANDLE(parms->flow_handle, index);
+       /* Process the EM entry per Table Scope type */
+       if (parms->mem == TF_MEM_EXTERNAL)
+               /* External EEM */
+               return tf_insert_eem_entry
+                       (tbl_scope_cb, parms);
+       else if (parms->mem == TF_MEM_INTERNAL)
+               /* Internal EM */
+               return tf_insert_em_internal_entry(tfp, parms);
 
-       if (tf_em_entry_exists(tbl_scope_cb,
-                              NULL,
-                              index,
-                              hash_type,
-                              parms->dir) == -EEXIST) {
-               tf_em_write_entry(tbl_scope_cb,
-                                 &zero_key_entry,
-                                 TF_EM_KEY_RECORD_SIZE,
-                                 index,
-                                 hash_type,
-                                 parms->dir);
+       return -EINVAL;
+}
 
-               return 0;
+/** Delete EM hash entry API
+ *
+ *    returns:
+ *    0       - Success
+ *    -EINVAL - Error
+ */
+int tf_em_delete_entry(struct tf *tfp,
+                      struct tf_delete_em_entry_parms *parms)
+{
+       struct tf_tbl_scope_cb *tbl_scope_cb;
+
+       tbl_scope_cb = tbl_scope_cb_find
+               ((struct tf_session *)(tfp->session->core_data),
+               parms->tbl_scope_id);
+       if (tbl_scope_cb == NULL) {
+               TFP_DRV_LOG(ERR, "Invalid tbl_scope_cb\n");
+               return -EINVAL;
        }
+       if (parms->mem == TF_MEM_EXTERNAL)
+               return tf_delete_eem_entry(tbl_scope_cb, parms);
+       else if (parms->mem == TF_MEM_INTERNAL)
+               return tf_delete_em_internal_entry(tfp, parms);
 
        return -EINVAL;
 }