net: add rte prefix to ether defines
[dpdk.git] / drivers / net / bonding / rte_eth_bond_8023ad.c
index ee2964a..d764dad 100644 (file)
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2015 Intel Corporation
  */
 
 #include <stddef.h>
 #include <rte_malloc.h>
 #include <rte_errno.h>
 #include <rte_cycles.h>
+#include <rte_compat.h>
 
 #include "rte_eth_bond_private.h"
 
+static void bond_mode_8023ad_ext_periodic_cb(void *arg);
 #ifdef RTE_LIBRTE_BOND_DEBUG_8023AD
-#define MODE4_DEBUG(fmt, ...) RTE_LOG(DEBUG, PMD, "%6u [Port %u: %s] " fmt, \
-                       bond_dbg_get_time_diff_ms(), slave_id, \
-                       __func__, ##__VA_ARGS__)
+
+#define MODE4_DEBUG(fmt, ...)                          \
+       rte_log(RTE_LOG_DEBUG, bond_logtype,            \
+               "%6u [Port %u: %s] " fmt,               \
+               bond_dbg_get_time_diff_ms(), slave_id,  \
+               __func__, ##__VA_ARGS__)
 
 static uint64_t start_time;
 
@@ -104,55 +80,57 @@ bond_print_lacp(struct lacpdu *l)
        if (p_len && p_state[p_len-1] == ' ')
                p_state[p_len-1] = '\0';
 
-       RTE_LOG(DEBUG, PMD, "LACP: {\n"\
-                       "  subtype= %02X\n"\
-                       "  ver_num=%02X\n"\
-                       "  actor={ tlv=%02X, len=%02X\n"\
-                       "    pri=%04X, system=%s, key=%04X, p_pri=%04X p_num=%04X\n"\
-                       "       state={ %s }\n"\
-                       "  }\n"\
-                       "  partner={ tlv=%02X, len=%02X\n"\
-                       "    pri=%04X, system=%s, key=%04X, p_pri=%04X p_num=%04X\n"\
-                       "       state={ %s }\n"\
-                       "  }\n"\
-                       "  collector={info=%02X, length=%02X, max_delay=%04X\n, " \
-                                                       "type_term=%02X, terminator_length = %02X}\n",\
-                       l->subtype,\
-                       l->version_number,\
-                       l->actor.tlv_type_info,\
-                       l->actor.info_length,\
-                       l->actor.port_params.system_priority,\
-                       a_address,\
-                       l->actor.port_params.key,\
-                       l->actor.port_params.port_priority,\
-                       l->actor.port_params.port_number,\
-                       a_state,\
-                       l->partner.tlv_type_info,\
-                       l->partner.info_length,\
-                       l->partner.port_params.system_priority,\
-                       p_address,\
-                       l->partner.port_params.key,\
-                       l->partner.port_params.port_priority,\
-                       l->partner.port_params.port_number,\
-                       p_state,\
-                       l->tlv_type_collector_info,\
-                       l->collector_info_length,\
-                       l->collector_max_delay,\
-                       l->tlv_type_terminator,\
-                       l->terminator_length);
+       RTE_BOND_LOG(DEBUG,
+                    "LACP: {\n"
+                    "  subtype= %02X\n"
+                    "  ver_num=%02X\n"
+                    "  actor={ tlv=%02X, len=%02X\n"
+                    "    pri=%04X, system=%s, key=%04X, p_pri=%04X p_num=%04X\n"
+                    "       state={ %s }\n"
+                    "  }\n"
+                    "  partner={ tlv=%02X, len=%02X\n"
+                    "    pri=%04X, system=%s, key=%04X, p_pri=%04X p_num=%04X\n"
+                    "       state={ %s }\n"
+                    "  }\n"
+                    "  collector={info=%02X, length=%02X, max_delay=%04X\n, "
+                    "type_term=%02X, terminator_length = %02X }",
+                    l->subtype,
+                    l->version_number,
+                    l->actor.tlv_type_info,
+                    l->actor.info_length,
+                    l->actor.port_params.system_priority,
+                    a_address,
+                    l->actor.port_params.key,
+                    l->actor.port_params.port_priority,
+                    l->actor.port_params.port_number,
+                    a_state,
+                    l->partner.tlv_type_info,
+                    l->partner.info_length,
+                    l->partner.port_params.system_priority,
+                    p_address,
+                    l->partner.port_params.key,
+                    l->partner.port_params.port_priority,
+                    l->partner.port_params.port_number,
+                    p_state,
+                    l->tlv_type_collector_info,
+                    l->collector_info_length,
+                    l->collector_max_delay,
+                    l->tlv_type_terminator,
+                    l->terminator_length);
 
 }
+
 #define BOND_PRINT_LACP(lacpdu) bond_print_lacp(lacpdu)
 #else
 #define BOND_PRINT_LACP(lacpdu) do { } while (0)
 #define MODE4_DEBUG(fmt, ...) do { } while (0)
 #endif
 
-static const struct ether_addr lacp_mac_addr = {
+static const struct rte_ether_addr lacp_mac_addr = {
        .addr_bytes = { 0x01, 0x80, 0xC2, 0x00, 0x00, 0x02 }
 };
 
-struct port mode_8023ad_ports[RTE_MAX_ETHPORTS];
+struct port bond_mode_8023ad_ports[RTE_MAX_ETHPORTS];
 
 static void
 timer_cancel(uint64_t *timer)
@@ -207,9 +185,9 @@ set_warning_flags(struct port *port, uint16_t flags)
 }
 
 static void
-show_warnings(uint8_t slave_id)
+show_warnings(uint16_t slave_id)
 {
-       struct port *port = &mode_8023ad_ports[slave_id];
+       struct port *port = &bond_mode_8023ad_ports[slave_id];
        uint8_t warnings;
 
        do {
@@ -227,31 +205,34 @@ show_warnings(uint8_t slave_id)
                        rte_get_tsc_hz() / 1000);
 
        if (warnings & WRN_RX_QUEUE_FULL) {
-               RTE_LOG(DEBUG, PMD,
-                       "Slave %u: failed to enqueue LACP packet into RX ring.\n"
-                       "Receive and transmit functions must be invoked on bonded\n"
-                       "interface at least 10 times per second or LACP will not\n"
-                       "work correctly\n", slave_id);
+               RTE_BOND_LOG(DEBUG,
+                            "Slave %u: failed to enqueue LACP packet into RX ring.\n"
+                            "Receive and transmit functions must be invoked on bonded"
+                            "interface at least 10 times per second or LACP will notwork correctly",
+                            slave_id);
        }
 
        if (warnings & WRN_TX_QUEUE_FULL) {
-               RTE_LOG(DEBUG, PMD,
-                       "Slave %u: failed to enqueue LACP packet into TX ring.\n"
-                       "Receive and transmit functions must be invoked on bonded\n"
-                       "interface at least 10 times per second or LACP will not\n"
-                       "work correctly\n", slave_id);
+               RTE_BOND_LOG(DEBUG,
+                            "Slave %u: failed to enqueue LACP packet into TX ring.\n"
+                            "Receive and transmit functions must be invoked on bonded"
+                            "interface at least 10 times per second or LACP will not work correctly",
+                            slave_id);
        }
 
        if (warnings & WRN_RX_MARKER_TO_FAST)
-               RTE_LOG(INFO, PMD, "Slave %u: marker to early - ignoring.\n", slave_id);
+               RTE_BOND_LOG(INFO, "Slave %u: marker to early - ignoring.",
+                            slave_id);
 
        if (warnings & WRN_UNKNOWN_SLOW_TYPE) {
-               RTE_LOG(INFO, PMD,
-                       "Slave %u: ignoring unknown slow protocol frame type", slave_id);
+               RTE_BOND_LOG(INFO,
+                       "Slave %u: ignoring unknown slow protocol frame type",
+                            slave_id);
        }
 
        if (warnings & WRN_UNKNOWN_MARKER_TYPE)
-               RTE_LOG(INFO, PMD, "Slave %u: ignoring unknown marker type", slave_id);
+               RTE_BOND_LOG(INFO, "Slave %u: ignoring unknown marker type",
+                            slave_id);
 
        if (warnings & WRN_NOT_LACP_CAPABLE)
                MODE4_DEBUG("Port %u is not LACP capable!\n", slave_id);
@@ -276,10 +257,10 @@ record_default(struct port *port)
  * @param port                 Port on which LACPDU was received.
  */
 static void
-rx_machine(struct bond_dev_private *internals, uint8_t slave_id,
+rx_machine(struct bond_dev_private *internals, uint16_t slave_id,
                struct lacpdu *lacp)
 {
-       struct port *agg, *port = &mode_8023ad_ports[slave_id];
+       struct port *agg, *port = &bond_mode_8023ad_ports[slave_id];
        uint64_t timeout;
 
        if (SM_FLAG(port, BEGIN)) {
@@ -338,10 +319,10 @@ rx_machine(struct bond_dev_private *internals, uint8_t slave_id,
                ACTOR_STATE_CLR(port, DEFAULTED);
 
                /* If LACP partner params match this port actor params */
-               agg = &mode_8023ad_ports[port->aggregator_port_id];
+               agg = &bond_mode_8023ad_ports[port->aggregator_port_id];
                bool match = port->actor.system_priority ==
                        lacp->partner.port_params.system_priority &&
-                       is_same_ether_addr(&agg->actor.system,
+                       rte_is_same_ether_addr(&agg->actor.system,
                        &lacp->partner.port_params.system) &&
                        port->actor.port_priority ==
                        lacp->partner.port_params.port_priority &&
@@ -397,9 +378,9 @@ rx_machine(struct bond_dev_private *internals, uint8_t slave_id,
  * @param port                 Port to handle state machine.
  */
 static void
-periodic_machine(struct bond_dev_private *internals, uint8_t slave_id)
+periodic_machine(struct bond_dev_private *internals, uint16_t slave_id)
 {
-       struct port *port = &mode_8023ad_ports[slave_id];
+       struct port *port = &bond_mode_8023ad_ports[slave_id];
        /* Calculate if either site is LACP enabled */
        uint64_t timeout;
        uint8_t active = ACTOR_STATE(port, LACP_ACTIVE) ||
@@ -432,7 +413,7 @@ periodic_machine(struct bond_dev_private *internals, uint8_t slave_id)
                         * In other case (was fast and now it is slow) just switch
                         * timeout to slow without forcing send of LACP (because standard
                         * say so)*/
-                       if (!is_partner_fast)
+                       if (is_partner_fast)
                                SM_FLAG_SET(port, NTT);
                } else
                        return; /* Nothing changed */
@@ -459,9 +440,9 @@ periodic_machine(struct bond_dev_private *internals, uint8_t slave_id)
  * @param port                 Port to handle state machine.
  */
 static void
-mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
+mux_machine(struct bond_dev_private *internals, uint16_t slave_id)
 {
-       struct port *port = &mode_8023ad_ports[slave_id];
+       struct port *port = &bond_mode_8023ad_ports[slave_id];
 
        /* Save current state for later use */
        const uint8_t state_mask = STATE_SYNCHRONIZATION | STATE_DISTRIBUTING |
@@ -512,7 +493,7 @@ mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
 
        if (!ACTOR_STATE(port, SYNCHRONIZATION)) {
                /* attach mux to aggregator */
-               RTE_VERIFY((port->actor_state & (STATE_COLLECTING |
+               RTE_ASSERT((port->actor_state & (STATE_COLLECTING |
                        STATE_DISTRIBUTING)) == 0);
 
                ACTOR_STATE_SET(port, SYNCHRONIZATION);
@@ -534,8 +515,8 @@ mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
                                ACTOR_STATE_SET(port, DISTRIBUTING);
                                SM_FLAG_SET(port, NTT);
                                MODE4_DEBUG("COLLECTING -> DISTRIBUTING\n");
-                               RTE_LOG(INFO, PMD,
-                                       "Bond %u: slave id %u distributing started.\n",
+                               RTE_BOND_LOG(INFO,
+                                       "Bond %u: slave id %u distributing started.",
                                        internals->port_id, slave_id);
                        }
                } else {
@@ -545,8 +526,8 @@ mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
                                ACTOR_STATE_CLR(port, DISTRIBUTING);
                                SM_FLAG_SET(port, NTT);
                                MODE4_DEBUG("DISTRIBUTING -> COLLECTING\n");
-                               RTE_LOG(INFO, PMD,
-                                       "Bond %u: slave id %u distributing stopped.\n",
+                               RTE_BOND_LOG(INFO,
+                                       "Bond %u: slave id %u distributing stopped.",
                                        internals->port_id, slave_id);
                        }
                }
@@ -562,9 +543,9 @@ mux_machine(struct bond_dev_private *internals, uint8_t slave_id)
  * @param port
  */
 static void
-tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
+tx_machine(struct bond_dev_private *internals, uint16_t slave_id)
 {
-       struct port *agg, *port = &mode_8023ad_ports[slave_id];
+       struct port *agg, *port = &bond_mode_8023ad_ports[slave_id];
 
        struct rte_mbuf *lacp_pkt = NULL;
        struct lacpdu_header *hdr;
@@ -584,7 +565,7 @@ tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
 
        lacp_pkt = rte_pktmbuf_alloc(port->mbuf_pool);
        if (lacp_pkt == NULL) {
-               RTE_LOG(ERR, PMD, "Failed to allocate LACP packet from pool\n");
+               RTE_BOND_LOG(ERR, "Failed to allocate LACP packet from pool");
                return;
        }
 
@@ -594,9 +575,9 @@ tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
        hdr = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);
 
        /* Source and destination MAC */
-       ether_addr_copy(&lacp_mac_addr, &hdr->eth_hdr.d_addr);
+       rte_ether_addr_copy(&lacp_mac_addr, &hdr->eth_hdr.d_addr);
        rte_eth_macaddr_get(slave_id, &hdr->eth_hdr.s_addr);
-       hdr->eth_hdr.ether_type = rte_cpu_to_be_16(ETHER_TYPE_SLOW);
+       hdr->eth_hdr.ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_SLOW);
 
        lacpdu = &hdr->lacpdu;
        memset(lacpdu, 0, sizeof(*lacpdu));
@@ -610,8 +591,9 @@ tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
        lacpdu->actor.info_length = sizeof(struct lacpdu_actor_partner_params);
        memcpy(&hdr->lacpdu.actor.port_params, &port->actor,
                        sizeof(port->actor));
-       agg = &mode_8023ad_ports[port->aggregator_port_id];
-       ether_addr_copy(&agg->actor.system, &hdr->lacpdu.actor.port_params.system);
+       agg = &bond_mode_8023ad_ports[port->aggregator_port_id];
+       rte_ether_addr_copy(&agg->actor.system,
+                       &hdr->lacpdu.actor.port_params.system);
        lacpdu->actor.state = port->actor_state;
 
        /* PARTNER */
@@ -629,21 +611,53 @@ tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
        lacpdu->tlv_type_terminator = TLV_TYPE_TERMINATOR_INFORMATION;
        lacpdu->terminator_length = 0;
 
-       if (rte_ring_enqueue(port->tx_ring, lacp_pkt) == -ENOBUFS) {
-               /* If TX ring full, drop packet and free message. Retransmission
-                * will happen in next function call. */
-               rte_pktmbuf_free(lacp_pkt);
-               set_warning_flags(port, WRN_TX_QUEUE_FULL);
-               return;
+       MODE4_DEBUG("Sending LACP frame\n");
+       BOND_PRINT_LACP(lacpdu);
+
+       if (internals->mode4.dedicated_queues.enabled == 0) {
+               int retval = rte_ring_enqueue(port->tx_ring, lacp_pkt);
+               if (retval != 0) {
+                       /* If TX ring full, drop packet and free message.
+                          Retransmission will happen in next function call. */
+                       rte_pktmbuf_free(lacp_pkt);
+                       set_warning_flags(port, WRN_TX_QUEUE_FULL);
+                       return;
+               }
+       } else {
+               uint16_t pkts_sent = rte_eth_tx_burst(slave_id,
+                               internals->mode4.dedicated_queues.tx_qid,
+                               &lacp_pkt, 1);
+               if (pkts_sent != 1) {
+                       rte_pktmbuf_free(lacp_pkt);
+                       set_warning_flags(port, WRN_TX_QUEUE_FULL);
+                       return;
+               }
        }
 
-       MODE4_DEBUG("sending LACP frame\n");
-       BOND_PRINT_LACP(lacpdu);
 
        timer_set(&port->tx_machine_timer, internals->mode4.tx_period_timeout);
        SM_FLAG_CLR(port, NTT);
 }
 
+static uint8_t
+max_index(uint64_t *a, int n)
+{
+       if (n <= 0)
+               return -1;
+
+       int i, max_i = 0;
+       uint64_t max = a[0];
+
+       for (i = 1; i < n; ++i) {
+               if (a[i] > max) {
+                       max = a[i];
+                       max_i = i;
+               }
+       }
+
+       return max_i;
+}
+
 /**
  * Function assigns port to aggregator.
  *
@@ -651,42 +665,73 @@ tx_machine(struct bond_dev_private *internals, uint8_t slave_id)
  * @param port_pos                     Port to assign.
  */
 static void
-selection_logic(struct bond_dev_private *internals, uint8_t slave_id)
+selection_logic(struct bond_dev_private *internals, uint16_t slave_id)
 {
        struct port *agg, *port;
-       uint8_t slaves_count, new_agg_id, i;
-       uint8_t *slaves;
+       uint16_t slaves_count, new_agg_id, i, j = 0;
+       uint16_t *slaves;
+       uint64_t agg_bandwidth[8] = {0};
+       uint64_t agg_count[8] = {0};
+       uint16_t default_slave = 0;
+       uint8_t mode_count_id, mode_band_id;
+       struct rte_eth_link link_info;
 
        slaves = internals->active_slaves;
        slaves_count = internals->active_slave_count;
-       port = &mode_8023ad_ports[slave_id];
+       port = &bond_mode_8023ad_ports[slave_id];
 
        /* Search for aggregator suitable for this port */
        for (i = 0; i < slaves_count; ++i) {
-               agg = &mode_8023ad_ports[slaves[i]];
+               agg = &bond_mode_8023ad_ports[slaves[i]];
                /* Skip ports that are not aggreagators */
                if (agg->aggregator_port_id != slaves[i])
                        continue;
 
+               agg_count[agg->aggregator_port_id] += 1;
+               rte_eth_link_get_nowait(slaves[i], &link_info);
+               agg_bandwidth[agg->aggregator_port_id] += link_info.link_speed;
+
                /* Actors system ID is not checked since all slave device have the same
                 * ID (MAC address). */
                if ((agg->actor.key == port->actor.key &&
                        agg->partner.system_priority == port->partner.system_priority &&
-                       is_same_ether_addr(&agg->partner.system, &port->partner.system) == 1
+                       rte_is_same_ether_addr(&agg->partner.system,
+                                       &port->partner.system) == 1
                        && (agg->partner.key == port->partner.key)) &&
-                       is_zero_ether_addr(&port->partner.system) != 1 &&
+                       rte_is_zero_ether_addr(&port->partner.system) != 1 &&
                        (agg->actor.key &
                                rte_cpu_to_be_16(BOND_LINK_FULL_DUPLEX_KEY)) != 0) {
 
-                       break;
+                       if (j == 0)
+                               default_slave = i;
+                       j++;
                }
        }
 
-       /* By default, port uses it self as agregator */
-       if (i == slaves_count)
-               new_agg_id = slave_id;
-       else
-               new_agg_id = slaves[i];
+       switch (internals->mode4.agg_selection) {
+       case AGG_COUNT:
+               mode_count_id = max_index(
+                               (uint64_t *)agg_count, slaves_count);
+               new_agg_id = mode_count_id;
+               break;
+       case AGG_BANDWIDTH:
+               mode_band_id = max_index(
+                               (uint64_t *)agg_bandwidth, slaves_count);
+               new_agg_id = mode_band_id;
+               break;
+       case AGG_STABLE:
+               if (default_slave == slaves_count)
+                       new_agg_id = slave_id;
+               else
+                       new_agg_id = slaves[default_slave];
+               break;
+       default:
+               if (default_slave == slaves_count)
+                       new_agg_id = slave_id;
+               else
+                       new_agg_id = slaves[default_slave];
+               break;
+       }
 
        if (new_agg_id != port->aggregator_port_id) {
                port->aggregator_port_id = new_agg_id;
@@ -708,25 +753,25 @@ link_speed_key(uint16_t speed) {
        uint16_t key_speed;
 
        switch (speed) {
-       case ETH_LINK_SPEED_AUTONEG:
+       case ETH_SPEED_NUM_NONE:
                key_speed = 0x00;
                break;
-       case ETH_LINK_SPEED_10:
+       case ETH_SPEED_NUM_10M:
                key_speed = BOND_LINK_SPEED_KEY_10M;
                break;
-       case ETH_LINK_SPEED_100:
+       case ETH_SPEED_NUM_100M:
                key_speed = BOND_LINK_SPEED_KEY_100M;
                break;
-       case ETH_LINK_SPEED_1000:
+       case ETH_SPEED_NUM_1G:
                key_speed = BOND_LINK_SPEED_KEY_1000M;
                break;
-       case ETH_LINK_SPEED_10G:
+       case ETH_SPEED_NUM_10G:
                key_speed = BOND_LINK_SPEED_KEY_10G;
                break;
-       case ETH_LINK_SPEED_20G:
+       case ETH_SPEED_NUM_20G:
                key_speed = BOND_LINK_SPEED_KEY_20G;
                break;
-       case ETH_LINK_SPEED_40G:
+       case ETH_SPEED_NUM_40G:
                key_speed = BOND_LINK_SPEED_KEY_40G;
                break;
        default:
@@ -737,6 +782,29 @@ link_speed_key(uint16_t speed) {
        return key_speed;
 }
 
+static void
+rx_machine_update(struct bond_dev_private *internals, uint16_t slave_id,
+               struct rte_mbuf *lacp_pkt) {
+       struct lacpdu_header *lacp;
+       struct lacpdu_actor_partner_params *partner;
+
+       if (lacp_pkt != NULL) {
+               lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);
+               RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
+
+               partner = &lacp->lacpdu.partner;
+               if (rte_is_same_ether_addr(&partner->port_params.system,
+                       &internals->mode4.mac_addr)) {
+                       /* This LACP frame is sending to the bonding port
+                        * so pass it to rx_machine.
+                        */
+                       rx_machine(internals, slave_id, &lacp->lacpdu);
+               }
+               rte_pktmbuf_free(lacp_pkt);
+       } else
+               rx_machine(internals, slave_id, NULL);
+}
+
 static void
 bond_mode_8023ad_periodic_cb(void *arg)
 {
@@ -744,10 +812,10 @@ bond_mode_8023ad_periodic_cb(void *arg)
        struct bond_dev_private *internals = bond_dev->data->dev_private;
        struct port *port;
        struct rte_eth_link link_info;
-       struct ether_addr slave_addr;
-
-       void *pkt = NULL;
-       uint8_t i, slave_id;
+       struct rte_ether_addr slave_addr;
+       struct rte_mbuf *lacp_pkt = NULL;
+       uint16_t slave_id;
+       uint16_t i;
 
 
        /* Update link status on each port */
@@ -755,7 +823,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
                uint16_t key;
 
                slave_id = internals->active_slaves[i];
-               rte_eth_link_get(slave_id, &link_info);
+               rte_eth_link_get_nowait(slave_id, &link_info);
                rte_eth_macaddr_get(slave_id, &slave_addr);
 
                if (link_info.link_status != 0) {
@@ -765,7 +833,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
                } else
                        key = 0;
 
-               port = &mode_8023ad_ports[slave_id];
+               port = &bond_mode_8023ad_ports[slave_id];
 
                key = rte_cpu_to_be_16(key);
                if (key != port->actor.key) {
@@ -776,8 +844,8 @@ bond_mode_8023ad_periodic_cb(void *arg)
                        SM_FLAG_SET(port, NTT);
                }
 
-               if (!is_same_ether_addr(&port->actor.system, &slave_addr)) {
-                       ether_addr_copy(&slave_addr, &port->actor.system);
+               if (!rte_is_same_ether_addr(&port->actor.system, &slave_addr)) {
+                       rte_ether_addr_copy(&slave_addr, &port->actor.system);
                        if (port->aggregator_port_id == slave_id)
                                SM_FLAG_SET(port, NTT);
                }
@@ -785,7 +853,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
 
        for (i = 0; i < internals->active_slave_count; i++) {
                slave_id = internals->active_slaves[i];
-               port = &mode_8023ad_ports[slave_id];
+               port = &bond_mode_8023ad_ports[slave_id];
 
                if ((port->actor.key &
                                rte_cpu_to_be_16(BOND_LINK_FULL_DUPLEX_KEY)) == 0) {
@@ -806,20 +874,28 @@ bond_mode_8023ad_periodic_cb(void *arg)
 
                SM_FLAG_SET(port, LACP_ENABLED);
 
-               /* Find LACP packet to this port. Do not check subtype, it is done in
-                * function that queued packet */
-               if (rte_ring_dequeue(port->rx_ring, &pkt) == 0) {
-                       struct rte_mbuf *lacp_pkt = pkt;
-                       struct lacpdu_header *lacp;
+               if (internals->mode4.dedicated_queues.enabled == 0) {
+                       /* Find LACP packet to this port. Do not check subtype,
+                        * it is done in function that queued packet
+                        */
+                       int retval = rte_ring_dequeue(port->rx_ring,
+                                       (void **)&lacp_pkt);
 
-                       lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);
-                       RTE_VERIFY(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
+                       if (retval != 0)
+                               lacp_pkt = NULL;
 
-                       /* This is LACP frame so pass it to rx_machine */
-                       rx_machine(internals, slave_id, &lacp->lacpdu);
-                       rte_pktmbuf_free(lacp_pkt);
-               } else
-                       rx_machine(internals, slave_id, NULL);
+                       rx_machine_update(internals, slave_id, lacp_pkt);
+               } else {
+                       uint16_t rx_count = rte_eth_rx_burst(slave_id,
+                                       internals->mode4.dedicated_queues.rx_qid,
+                                       &lacp_pkt, 1);
+
+                       if (rx_count == 1)
+                               bond_mode_8023ad_handle_slow_pkt(internals,
+                                               slave_id, lacp_pkt);
+                       else
+                               rx_machine_update(internals, slave_id, NULL);
+               }
 
                periodic_machine(internals, slave_id);
                mux_machine(internals, slave_id);
@@ -835,11 +911,12 @@ bond_mode_8023ad_periodic_cb(void *arg)
 }
 
 void
-bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
+bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,
+                               uint16_t slave_id)
 {
        struct bond_dev_private *internals = bond_dev->data->dev_private;
 
-       struct port *port = &mode_8023ad_ports[slave_id];
+       struct port *port = &bond_mode_8023ad_ports[slave_id];
        struct port_params initial = {
                        .system = { { 0 } },
                        .system_priority = rte_cpu_to_be_16(0xFFFF),
@@ -851,21 +928,25 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
        char mem_name[RTE_ETH_NAME_MAX_LEN];
        int socket_id;
        unsigned element_size;
+       uint32_t total_tx_desc;
+       struct bond_tx_queue *bd_tx_q;
+       uint16_t q_id;
 
        /* Given slave mus not be in active list */
-       RTE_VERIFY(find_slave_by_id(internals->active_slaves,
+       RTE_ASSERT(find_slave_by_id(internals->active_slaves,
        internals->active_slave_count, slave_id) == internals->active_slave_count);
+       RTE_SET_USED(internals); /* used only for assert when enabled */
 
        memcpy(&port->actor, &initial, sizeof(struct port_params));
        /* Standard requires that port ID must be grater than 0.
         * Add 1 do get corresponding port_number */
-       port->actor.port_number = rte_cpu_to_be_16((uint16_t)slave_id + 1);
+       port->actor.port_number = rte_cpu_to_be_16(slave_id + 1);
 
        memcpy(&port->partner, &initial, sizeof(struct port_params));
 
        /* default states */
        port->actor_state = STATE_AGGREGATION | STATE_LACP_ACTIVE | STATE_DEFAULTED;
-       port->partner_state = STATE_LACP_ACTIVE;
+       port->partner_state = STATE_LACP_ACTIVE | STATE_AGGREGATION;
        port->sm_flags = SM_FLAGS_BEGIN;
 
        /* use this port as agregator */
@@ -877,26 +958,31 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
        if (port->mbuf_pool != NULL)
                return;
 
-       RTE_VERIFY(port->rx_ring == NULL);
-       RTE_VERIFY(port->tx_ring == NULL);
-       socket_id = rte_eth_devices[slave_id].data->numa_node;
+       RTE_ASSERT(port->rx_ring == NULL);
+       RTE_ASSERT(port->tx_ring == NULL);
+
+       socket_id = rte_eth_dev_socket_id(slave_id);
+       if (socket_id == (int)LCORE_ID_ANY)
+               socket_id = rte_socket_id();
 
-       element_size = sizeof(struct slow_protocol_frame) + sizeof(struct rte_mbuf)
-                               + RTE_PKTMBUF_HEADROOM;
+       element_size = sizeof(struct slow_protocol_frame) +
+                               RTE_PKTMBUF_HEADROOM;
+
+       /* The size of the mempool should be at least:
+        * the sum of the TX descriptors + BOND_MODE_8023AX_SLAVE_TX_PKTS */
+       total_tx_desc = BOND_MODE_8023AX_SLAVE_TX_PKTS;
+       for (q_id = 0; q_id < bond_dev->data->nb_tx_queues; q_id++) {
+               bd_tx_q = (struct bond_tx_queue*)bond_dev->data->tx_queues[q_id];
+               total_tx_desc += bd_tx_q->nb_tx_desc;
+       }
 
-        /* How big memory pool should be? If driver will not
-         * free packets quick enough there will be ENOMEM in tx_machine.
-         * For now give 511 pkts * max number of queued TX packets per slave.
-         * Hope it will be enough. */
        snprintf(mem_name, RTE_DIM(mem_name), "slave_port%u_pool", slave_id);
-       port->mbuf_pool = rte_mempool_create(mem_name,
-               BOND_MODE_8023AX_SLAVE_TX_PKTS * 512 - 1,
-               element_size,
-               RTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ? 32 : RTE_MEMPOOL_CACHE_MAX_SIZE,
-               sizeof(struct rte_pktmbuf_pool_private), rte_pktmbuf_pool_init,
-               NULL, rte_pktmbuf_init, NULL, socket_id, MEMPOOL_F_NO_SPREAD);
-
-       /* Any memory allocation failure in initalization is critical because
+       port->mbuf_pool = rte_pktmbuf_pool_create(mem_name, total_tx_desc,
+               RTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ?
+                       32 : RTE_MEMPOOL_CACHE_MAX_SIZE,
+               0, element_size, socket_id);
+
+       /* Any memory allocation failure in initialization is critical because
         * resources can't be free, so reinitialization is impossible. */
        if (port->mbuf_pool == NULL) {
                rte_panic("Slave %u: Failed to create memory pool '%s': %s\n",
@@ -924,37 +1010,30 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 }
 
 int
-bond_mode_8023ad_deactivate_slave(struct rte_eth_dev *bond_dev,
-               uint8_t slave_id)
+bond_mode_8023ad_deactivate_slave(struct rte_eth_dev *bond_dev __rte_unused,
+               uint16_t slave_id)
 {
-       struct bond_dev_private *internals = bond_dev->data->dev_private;
        void *pkt = NULL;
-       struct port *port;
-       uint8_t i;
+       struct port *port = NULL;
+       uint8_t old_partner_state;
 
-       /* Given slave mus be in active list */
-       RTE_VERIFY(find_slave_by_id(internals->active_slaves,
-       internals->active_slave_count, slave_id) < internals->active_slave_count);
+       port = &bond_mode_8023ad_ports[slave_id];
 
-       /* Exclude slave from transmit policy. If this slave is an aggregator
-        * make all aggregated slaves unselected to force sellection logic
-        * to select suitable aggregator for this port. */
-       for (i = 0; i < internals->active_slave_count; i++) {
-               port = &mode_8023ad_ports[internals->active_slaves[i]];
-               if (port->aggregator_port_id != slave_id)
-                       continue;
+       ACTOR_STATE_CLR(port, AGGREGATION);
+       port->selected = UNSELECTED;
 
-               port->selected = UNSELECTED;
+       old_partner_state = port->partner_state;
+       record_default(port);
 
-               /* Use default aggregator */
-               port->aggregator_port_id = internals->active_slaves[i];
-       }
+       /* If partner timeout state changes then disable timer */
+       if (!((old_partner_state ^ port->partner_state) &
+                       STATE_LACP_SHORT_TIMEOUT))
+               timer_cancel(&port->current_while_timer);
 
-       port = &mode_8023ad_ports[slave_id];
-       port->selected = UNSELECTED;
-       port->actor_state &= ~(STATE_SYNCHRONIZATION | STATE_DISTRIBUTING |
-                       STATE_COLLECTING);
+       PARTNER_STATE_CLR(port, AGGREGATION);
+       ACTOR_STATE_CLR(port, EXPIRED);
 
+       /* flush rx/tx rings */
        while (rte_ring_dequeue(port->rx_ring, &pkt) == 0)
                rte_pktmbuf_free((struct rte_mbuf *)pkt);
 
@@ -967,28 +1046,28 @@ void
 bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev)
 {
        struct bond_dev_private *internals = bond_dev->data->dev_private;
-       struct ether_addr slave_addr;
+       struct rte_ether_addr slave_addr;
        struct port *slave, *agg_slave;
-       uint8_t slave_id, i, j;
+       uint16_t slave_id, i, j;
 
        bond_mode_8023ad_stop(bond_dev);
 
        for (i = 0; i < internals->active_slave_count; i++) {
                slave_id = internals->active_slaves[i];
-               slave = &mode_8023ad_ports[slave_id];
+               slave = &bond_mode_8023ad_ports[slave_id];
                rte_eth_macaddr_get(slave_id, &slave_addr);
 
-               if (is_same_ether_addr(&slave_addr, &slave->actor.system))
+               if (rte_is_same_ether_addr(&slave_addr, &slave->actor.system))
                        continue;
 
-               ether_addr_copy(&slave_addr, &slave->actor.system);
+               rte_ether_addr_copy(&slave_addr, &slave->actor.system);
                /* Do nothing if this port is not an aggregator. In other case
                 * Set NTT flag on every port that use this aggregator. */
                if (slave->aggregator_port_id != slave_id)
                        continue;
 
                for (j = 0; j < internals->active_slave_count; j++) {
-                       agg_slave = &mode_8023ad_ports[internals->active_slaves[j]];
+                       agg_slave = &bond_mode_8023ad_ports[internals->active_slaves[j]];
                        if (agg_slave->aggregator_port_id == slave_id)
                                SM_FLAG_SET(agg_slave, NTT);
                }
@@ -998,7 +1077,7 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev)
                bond_mode_8023ad_start(bond_dev);
 }
 
-void
+static void
 bond_mode_8023ad_conf_get(struct rte_eth_dev *dev,
                struct rte_eth_bond_8023ad_conf *conf)
 {
@@ -1013,29 +1092,32 @@ bond_mode_8023ad_conf_get(struct rte_eth_dev *dev,
        conf->aggregate_wait_timeout_ms = mode4->aggregate_wait_timeout / ms_ticks;
        conf->tx_period_ms = mode4->tx_period_timeout / ms_ticks;
        conf->update_timeout_ms = mode4->update_timeout_us / 1000;
+       conf->rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks;
+       conf->slowrx_cb = mode4->slowrx_cb;
+       conf->agg_selection = mode4->agg_selection;
 }
 
-void
-bond_mode_8023ad_setup(struct rte_eth_dev *dev,
+static void
+bond_mode_8023ad_conf_get_default(struct rte_eth_bond_8023ad_conf *conf)
+{
+       conf->fast_periodic_ms = BOND_8023AD_FAST_PERIODIC_MS;
+       conf->slow_periodic_ms = BOND_8023AD_SLOW_PERIODIC_MS;
+       conf->short_timeout_ms = BOND_8023AD_SHORT_TIMEOUT_MS;
+       conf->long_timeout_ms = BOND_8023AD_LONG_TIMEOUT_MS;
+       conf->aggregate_wait_timeout_ms = BOND_8023AD_AGGREGATE_WAIT_TIMEOUT_MS;
+       conf->tx_period_ms = BOND_8023AD_TX_MACHINE_PERIOD_MS;
+       conf->rx_marker_period_ms = BOND_8023AD_RX_MARKER_PERIOD_MS;
+       conf->update_timeout_ms = BOND_MODE_8023AX_UPDATE_TIMEOUT_MS;
+       conf->slowrx_cb = NULL;
+       conf->agg_selection = AGG_STABLE;
+}
+
+static void
+bond_mode_8023ad_conf_assign(struct mode8023ad_private *mode4,
                struct rte_eth_bond_8023ad_conf *conf)
 {
-       struct rte_eth_bond_8023ad_conf def_conf;
-       struct bond_dev_private *internals = dev->data->dev_private;
-       struct mode8023ad_private *mode4 = &internals->mode4;
        uint64_t ms_ticks = rte_get_tsc_hz() / 1000;
 
-       if (conf == NULL) {
-               conf = &def_conf;
-               conf->fast_periodic_ms = BOND_8023AD_FAST_PERIODIC_MS;
-               conf->slow_periodic_ms = BOND_8023AD_SLOW_PERIODIC_MS;
-               conf->short_timeout_ms = BOND_8023AD_SHORT_TIMEOUT_MS;
-               conf->long_timeout_ms = BOND_8023AD_LONG_TIMEOUT_MS;
-               conf->aggregate_wait_timeout_ms = BOND_8023AD_AGGREGATE_WAIT_TIMEOUT_MS;
-               conf->tx_period_ms = BOND_8023AD_TX_MACHINE_PERIOD_MS;
-               conf->rx_marker_period_ms = BOND_8023AD_RX_MARKER_PERIOD_MS;
-               conf->update_timeout_ms = BOND_MODE_8023AX_UPDATE_TIMEOUT_MS;
-       }
-
        mode4->fast_periodic_timeout = conf->fast_periodic_ms * ms_ticks;
        mode4->slow_periodic_timeout = conf->slow_periodic_ms * ms_ticks;
        mode4->short_timeout = conf->short_timeout_ms * ms_ticks;
@@ -1044,16 +1126,43 @@ bond_mode_8023ad_setup(struct rte_eth_dev *dev,
        mode4->tx_period_timeout = conf->tx_period_ms * ms_ticks;
        mode4->rx_marker_timeout = conf->rx_marker_period_ms * ms_ticks;
        mode4->update_timeout_us = conf->update_timeout_ms * 1000;
+
+       mode4->dedicated_queues.enabled = 0;
+       mode4->dedicated_queues.rx_qid = UINT16_MAX;
+       mode4->dedicated_queues.tx_qid = UINT16_MAX;
+}
+
+void
+bond_mode_8023ad_setup(struct rte_eth_dev *dev,
+               struct rte_eth_bond_8023ad_conf *conf)
+{
+       struct rte_eth_bond_8023ad_conf def_conf;
+       struct bond_dev_private *internals = dev->data->dev_private;
+       struct mode8023ad_private *mode4 = &internals->mode4;
+
+       if (conf == NULL) {
+               conf = &def_conf;
+               bond_mode_8023ad_conf_get_default(conf);
+       }
+
+       bond_mode_8023ad_stop(dev);
+       bond_mode_8023ad_conf_assign(mode4, conf);
+       mode4->slowrx_cb = conf->slowrx_cb;
+       mode4->agg_selection = AGG_STABLE;
+
+       if (dev->data->dev_started)
+               bond_mode_8023ad_start(dev);
 }
 
 int
 bond_mode_8023ad_enable(struct rte_eth_dev *bond_dev)
 {
        struct bond_dev_private *internals = bond_dev->data->dev_private;
-       uint8_t i;
+       uint16_t i;
 
        for (i = 0; i < internals->active_slave_count; i++)
-               bond_mode_8023ad_activate_slave(bond_dev, i);
+               bond_mode_8023ad_activate_slave(bond_dev,
+                               internals->active_slaves[i]);
 
        return 0;
 }
@@ -1061,22 +1170,38 @@ bond_mode_8023ad_enable(struct rte_eth_dev *bond_dev)
 int
 bond_mode_8023ad_start(struct rte_eth_dev *bond_dev)
 {
-       return rte_eal_alarm_set(BOND_MODE_8023AX_UPDATE_TIMEOUT_MS * 1000,
-                       &bond_mode_8023ad_periodic_cb, bond_dev);
+       struct bond_dev_private *internals = bond_dev->data->dev_private;
+       struct mode8023ad_private *mode4 = &internals->mode4;
+       static const uint64_t us = BOND_MODE_8023AX_UPDATE_TIMEOUT_MS * 1000;
+
+       rte_eth_macaddr_get(internals->port_id, &mode4->mac_addr);
+       if (mode4->slowrx_cb)
+               return rte_eal_alarm_set(us, &bond_mode_8023ad_ext_periodic_cb,
+                                        bond_dev);
+
+       return rte_eal_alarm_set(us, &bond_mode_8023ad_periodic_cb, bond_dev);
 }
 
 void
 bond_mode_8023ad_stop(struct rte_eth_dev *bond_dev)
 {
+       struct bond_dev_private *internals = bond_dev->data->dev_private;
+       struct mode8023ad_private *mode4 = &internals->mode4;
+
+       if (mode4->slowrx_cb) {
+               rte_eal_alarm_cancel(&bond_mode_8023ad_ext_periodic_cb,
+                                    bond_dev);
+               return;
+       }
        rte_eal_alarm_cancel(&bond_mode_8023ad_periodic_cb, bond_dev);
 }
 
 void
 bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals,
-       uint8_t slave_id, struct rte_mbuf *pkt)
+                                 uint16_t slave_id, struct rte_mbuf *pkt)
 {
        struct mode8023ad_private *mode4 = &internals->mode4;
-       struct port *port = &mode_8023ad_ports[slave_id];
+       struct port *port = &bond_mode_8023ad_ports[slave_id];
        struct marker_header *m_hdr;
        uint64_t marker_timer, old_marker_timer;
        int retval;
@@ -1095,7 +1220,7 @@ bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals,
                        goto free_out;
                }
 
-               /* Setup marker timer. Do it in loop in case concurent access. */
+               /* Setup marker timer. Do it in loop in case concurrent access. */
                do {
                        old_marker_timer = port->rx_marker_timer;
                        if (!timer_is_expired(&old_marker_timer)) {
@@ -1111,18 +1236,36 @@ bond_mode_8023ad_handle_slow_pkt(struct bond_dev_private *internals,
                m_hdr->marker.tlv_type_marker = MARKER_TLV_TYPE_RESP;
                rte_eth_macaddr_get(slave_id, &m_hdr->eth_hdr.s_addr);
 
-               if (unlikely(rte_ring_enqueue(port->tx_ring, pkt) == -ENOBUFS)) {
-                       /* reset timer */
-                       port->rx_marker_timer = 0;
-                       wrn = WRN_TX_QUEUE_FULL;
-                       goto free_out;
+               if (internals->mode4.dedicated_queues.enabled == 0) {
+                       int retval = rte_ring_enqueue(port->tx_ring, pkt);
+                       if (retval != 0) {
+                               /* reset timer */
+                               port->rx_marker_timer = 0;
+                               wrn = WRN_TX_QUEUE_FULL;
+                               goto free_out;
+                       }
+               } else {
+                       /* Send packet directly to the slow queue */
+                       uint16_t tx_count = rte_eth_tx_burst(slave_id,
+                                       internals->mode4.dedicated_queues.tx_qid,
+                                       &pkt, 1);
+                       if (tx_count != 1) {
+                               /* reset timer */
+                               port->rx_marker_timer = 0;
+                               wrn = WRN_TX_QUEUE_FULL;
+                               goto free_out;
+                       }
                }
        } else if (likely(subtype == SLOW_SUBTYPE_LACP)) {
-               if (unlikely(rte_ring_enqueue(port->rx_ring, pkt) == -ENOBUFS)) {
-                       /* If RX fing full free lacpdu message and drop packet */
-                       wrn = WRN_RX_QUEUE_FULL;
-                       goto free_out;
-               }
+               if (internals->mode4.dedicated_queues.enabled == 0) {
+                       int retval = rte_ring_enqueue(port->rx_ring, pkt);
+                       if (retval != 0) {
+                               /* If RX fing full free lacpdu message and drop packet */
+                               wrn = WRN_RX_QUEUE_FULL;
+                               goto free_out;
+                       }
+               } else
+                       rx_machine_update(internals, slave_id, pkt);
        } else {
                wrn = WRN_UNKNOWN_SLOW_TYPE;
                goto free_out;
@@ -1136,7 +1279,7 @@ free_out:
 }
 
 int
-rte_eth_bond_8023ad_conf_get(uint8_t port_id,
+rte_eth_bond_8023ad_conf_get(uint16_t port_id,
                struct rte_eth_bond_8023ad_conf *conf)
 {
        struct rte_eth_dev *bond_dev;
@@ -1153,11 +1296,52 @@ rte_eth_bond_8023ad_conf_get(uint8_t port_id,
 }
 
 int
-rte_eth_bond_8023ad_setup(uint8_t port_id,
-               struct rte_eth_bond_8023ad_conf *conf)
+rte_eth_bond_8023ad_agg_selection_set(uint16_t port_id,
+               enum rte_bond_8023ad_agg_selection agg_selection)
 {
        struct rte_eth_dev *bond_dev;
+       struct bond_dev_private *internals;
+       struct mode8023ad_private *mode4;
+
+       bond_dev = &rte_eth_devices[port_id];
+       internals = bond_dev->data->dev_private;
+
+       if (valid_bonded_port_id(port_id) != 0)
+               return -EINVAL;
+       if (internals->mode != 4)
+               return -EINVAL;
+
+       mode4 = &internals->mode4;
+       if (agg_selection == AGG_COUNT || agg_selection == AGG_BANDWIDTH
+                       || agg_selection == AGG_STABLE)
+               mode4->agg_selection = agg_selection;
+       return 0;
+}
+
+int rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id)
+{
+       struct rte_eth_dev *bond_dev;
+       struct bond_dev_private *internals;
+       struct mode8023ad_private *mode4;
+
+       bond_dev = &rte_eth_devices[port_id];
+       internals = bond_dev->data->dev_private;
+
+       if (valid_bonded_port_id(port_id) != 0)
+               return -EINVAL;
+       if (internals->mode != 4)
+               return -EINVAL;
+       mode4 = &internals->mode4;
+
+       return mode4->agg_selection;
+}
+
+
 
+static int
+bond_8023ad_setup_validate(uint16_t port_id,
+               struct rte_eth_bond_8023ad_conf *conf)
+{
        if (valid_bonded_port_id(port_id) != 0)
                return -EINVAL;
 
@@ -1171,19 +1355,38 @@ rte_eth_bond_8023ad_setup(uint8_t port_id,
                                conf->tx_period_ms == 0 ||
                                conf->rx_marker_period_ms == 0 ||
                                conf->update_timeout_ms == 0) {
-                       RTE_LOG(ERR, PMD, "given mode 4 configuration is invalid\n");
+                       RTE_BOND_LOG(ERR, "given mode 4 configuration is invalid");
                        return -EINVAL;
                }
        }
 
+       return 0;
+}
+
+
+int
+rte_eth_bond_8023ad_setup(uint16_t port_id,
+               struct rte_eth_bond_8023ad_conf *conf)
+{
+       struct rte_eth_dev *bond_dev;
+       int err;
+
+       err = bond_8023ad_setup_validate(port_id, conf);
+       if (err != 0)
+               return err;
+
        bond_dev = &rte_eth_devices[port_id];
        bond_mode_8023ad_setup(bond_dev, conf);
 
        return 0;
 }
 
+
+
+
+
 int
-rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
+rte_eth_bond_8023ad_slave_info(uint16_t port_id, uint16_t slave_id,
                struct rte_eth_bond_8023ad_slave_info *info)
 {
        struct rte_eth_dev *bond_dev;
@@ -1202,7 +1405,7 @@ rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
                                internals->active_slave_count)
                return -EINVAL;
 
-       port = &mode_8023ad_ports[slave_id];
+       port = &bond_mode_8023ad_ports[slave_id];
        info->selected = port->selected;
 
        info->actor_state = port->actor_state;
@@ -1214,3 +1417,208 @@ rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
        info->agg_port_id = port->aggregator_port_id;
        return 0;
 }
+
+static int
+bond_8023ad_ext_validate(uint16_t port_id, uint16_t slave_id)
+{
+       struct rte_eth_dev *bond_dev;
+       struct bond_dev_private *internals;
+       struct mode8023ad_private *mode4;
+
+       if (rte_eth_bond_mode_get(port_id) != BONDING_MODE_8023AD)
+               return -EINVAL;
+
+       bond_dev = &rte_eth_devices[port_id];
+
+       if (!bond_dev->data->dev_started)
+               return -EINVAL;
+
+       internals = bond_dev->data->dev_private;
+       if (find_slave_by_id(internals->active_slaves,
+                       internals->active_slave_count, slave_id) ==
+                               internals->active_slave_count)
+               return -EINVAL;
+
+       mode4 = &internals->mode4;
+       if (mode4->slowrx_cb == NULL)
+               return -EINVAL;
+
+       return 0;
+}
+
+int
+rte_eth_bond_8023ad_ext_collect(uint16_t port_id, uint16_t slave_id,
+                               int enabled)
+{
+       struct port *port;
+       int res;
+
+       res = bond_8023ad_ext_validate(port_id, slave_id);
+       if (res != 0)
+               return res;
+
+       port = &bond_mode_8023ad_ports[slave_id];
+
+       if (enabled)
+               ACTOR_STATE_SET(port, COLLECTING);
+       else
+               ACTOR_STATE_CLR(port, COLLECTING);
+
+       return 0;
+}
+
+int
+rte_eth_bond_8023ad_ext_distrib(uint16_t port_id, uint16_t slave_id,
+                               int enabled)
+{
+       struct port *port;
+       int res;
+
+       res = bond_8023ad_ext_validate(port_id, slave_id);
+       if (res != 0)
+               return res;
+
+       port = &bond_mode_8023ad_ports[slave_id];
+
+       if (enabled)
+               ACTOR_STATE_SET(port, DISTRIBUTING);
+       else
+               ACTOR_STATE_CLR(port, DISTRIBUTING);
+
+       return 0;
+}
+
+int
+rte_eth_bond_8023ad_ext_distrib_get(uint16_t port_id, uint16_t slave_id)
+{
+       struct port *port;
+       int err;
+
+       err = bond_8023ad_ext_validate(port_id, slave_id);
+       if (err != 0)
+               return err;
+
+       port = &bond_mode_8023ad_ports[slave_id];
+       return ACTOR_STATE(port, DISTRIBUTING);
+}
+
+int
+rte_eth_bond_8023ad_ext_collect_get(uint16_t port_id, uint16_t slave_id)
+{
+       struct port *port;
+       int err;
+
+       err = bond_8023ad_ext_validate(port_id, slave_id);
+       if (err != 0)
+               return err;
+
+       port = &bond_mode_8023ad_ports[slave_id];
+       return ACTOR_STATE(port, COLLECTING);
+}
+
+int
+rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t slave_id,
+               struct rte_mbuf *lacp_pkt)
+{
+       struct port *port;
+       int res;
+
+       res = bond_8023ad_ext_validate(port_id, slave_id);
+       if (res != 0)
+               return res;
+
+       port = &bond_mode_8023ad_ports[slave_id];
+
+       if (rte_pktmbuf_pkt_len(lacp_pkt) < sizeof(struct lacpdu_header))
+               return -EINVAL;
+
+       struct lacpdu_header *lacp;
+
+       /* only enqueue LACPDUs */
+       lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);
+       if (lacp->lacpdu.subtype != SLOW_SUBTYPE_LACP)
+               return -EINVAL;
+
+       MODE4_DEBUG("sending LACP frame\n");
+
+       return rte_ring_enqueue(port->tx_ring, lacp_pkt);
+}
+
+static void
+bond_mode_8023ad_ext_periodic_cb(void *arg)
+{
+       struct rte_eth_dev *bond_dev = arg;
+       struct bond_dev_private *internals = bond_dev->data->dev_private;
+       struct mode8023ad_private *mode4 = &internals->mode4;
+       struct port *port;
+       void *pkt = NULL;
+       uint16_t i, slave_id;
+
+       for (i = 0; i < internals->active_slave_count; i++) {
+               slave_id = internals->active_slaves[i];
+               port = &bond_mode_8023ad_ports[slave_id];
+
+               if (rte_ring_dequeue(port->rx_ring, &pkt) == 0) {
+                       struct rte_mbuf *lacp_pkt = pkt;
+                       struct lacpdu_header *lacp;
+
+                       lacp = rte_pktmbuf_mtod(lacp_pkt,
+                                               struct lacpdu_header *);
+                       RTE_VERIFY(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
+
+                       /* This is LACP frame so pass it to rx callback.
+                        * Callback is responsible for freeing mbuf.
+                        */
+                       mode4->slowrx_cb(slave_id, lacp_pkt);
+               }
+       }
+
+       rte_eal_alarm_set(internals->mode4.update_timeout_us,
+                       bond_mode_8023ad_ext_periodic_cb, arg);
+}
+
+int
+rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
+{
+       int retval = 0;
+       struct rte_eth_dev *dev = &rte_eth_devices[port];
+       struct bond_dev_private *internals = (struct bond_dev_private *)
+               dev->data->dev_private;
+
+       if (check_for_bonded_ethdev(dev) != 0)
+               return -1;
+
+       if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
+               return -1;
+
+       /* Device must be stopped to set up slow queue */
+       if (dev->data->dev_started)
+               return -1;
+
+       internals->mode4.dedicated_queues.enabled = 1;
+
+       bond_ethdev_mode_set(dev, internals->mode);
+       return retval;
+}
+
+int
+rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
+{
+       int retval = 0;
+       struct rte_eth_dev *dev = &rte_eth_devices[port];
+       struct bond_dev_private *internals = (struct bond_dev_private *)
+               dev->data->dev_private;
+
+       if (check_for_bonded_ethdev(dev) != 0)
+               return -1;
+
+       /* Device must be stopped to set up slow queue */
+       if (dev->data->dev_started)
+               return -1;
+
+       internals->mode4.dedicated_queues.enabled = 0;
+
+       bond_ethdev_mode_set(dev, internals->mode);
+
+       return retval;
+}