net: add rte prefix to ether structures
[dpdk.git] / drivers / net / bonding / rte_eth_bond_pmd.c
index 23cec25..9950635 100644 (file)
 static uint64_t tlb_last_obytets[RTE_MAX_ETHPORTS];
 
 static inline size_t
-get_vlan_offset(struct ether_hdr *eth_hdr, uint16_t *proto)
+get_vlan_offset(struct rte_ether_hdr *eth_hdr, uint16_t *proto)
 {
        size_t vlan_offset = 0;
 
        if (rte_cpu_to_be_16(ETHER_TYPE_VLAN) == *proto ||
                rte_cpu_to_be_16(ETHER_TYPE_QINQ) == *proto) {
-               struct vlan_hdr *vlan_hdr = (struct vlan_hdr *)(eth_hdr + 1);
+               struct rte_vlan_hdr *vlan_hdr =
+                       (struct rte_vlan_hdr *)(eth_hdr + 1);
 
-               vlan_offset = sizeof(struct vlan_hdr);
+               vlan_offset = sizeof(struct rte_vlan_hdr);
                *proto = vlan_hdr->eth_proto;
 
                if (rte_cpu_to_be_16(ETHER_TYPE_VLAN) == *proto) {
                        vlan_hdr = vlan_hdr + 1;
                        *proto = vlan_hdr->eth_proto;
-                       vlan_offset += sizeof(struct vlan_hdr);
+                       vlan_offset += sizeof(struct rte_vlan_hdr);
                }
        }
        return vlan_offset;
@@ -84,7 +85,7 @@ bond_ethdev_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                        active_slave = 0;
        }
 
-       if (++internals->active_slave == slave_count)
+       if (++internals->active_slave >= slave_count)
                internals->active_slave = 0;
        return num_rx_total;
 }
@@ -288,7 +289,7 @@ bond_ethdev_rx_burst_8023ad_fast_queue(void *queue, struct rte_mbuf **bufs,
                        active_slave = 0;
        }
 
-       if (++internals->active_slave == slave_count)
+       if (++internals->active_slave >= slave_count)
                internals->active_slave = 0;
 
        return num_rx_total;
@@ -353,7 +354,7 @@ bond_ethdev_tx_burst_8023ad_fast_queue(void *queue, struct rte_mbuf **bufs,
 
        for (i = 0; i < nb_bufs; i++) {
                /* Populate slave mbuf arrays with mbufs for that slave. */
-               uint8_t slave_idx = bufs_slave_port_idxs[i];
+               uint16_t slave_idx = bufs_slave_port_idxs[i];
 
                slave_bufs[slave_idx][slave_nb_bufs[slave_idx]++] = bufs[i];
        }
@@ -394,8 +395,8 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
        struct bond_dev_private *internals = bd_rx_q->dev_private;
        struct rte_eth_dev *bonded_eth_dev =
                                        &rte_eth_devices[internals->port_id];
-       struct ether_addr *bond_mac = bonded_eth_dev->data->mac_addrs;
-       struct ether_hdr *hdr;
+       struct rte_ether_addr *bond_mac = bonded_eth_dev->data->mac_addrs;
+       struct rte_ether_hdr *hdr;
 
        const uint16_t ether_type_slow_be = rte_be_to_cpu_16(ETHER_TYPE_SLOW);
        uint16_t num_rx_total = 0;      /* Total number of received packets */
@@ -404,8 +405,10 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
 
        uint8_t collecting;  /* current slave collecting status */
        const uint8_t promisc = internals->promiscuous_en;
-       uint8_t i, j, k;
        uint8_t subtype;
+       uint16_t i;
+       uint16_t j;
+       uint16_t k;
 
        /* Copy slave list to protect against slave up/down changes during tx
         * bursting */
@@ -442,7 +445,7 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
                        if (j + 3 < num_rx_total)
                                rte_prefetch0(rte_pktmbuf_mtod(bufs[j + 3], void *));
 
-                       hdr = rte_pktmbuf_mtod(bufs[j], struct ether_hdr *);
+                       hdr = rte_pktmbuf_mtod(bufs[j], struct rte_ether_hdr *);
                        subtype = ((struct slow_protocol_frame *)hdr)->slow_protocol.subtype;
 
                        /* Remove packet from array if it is slow packet or slave is not
@@ -474,7 +477,7 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
                        idx = 0;
        }
 
-       if (++internals->active_slave == slave_count)
+       if (++internals->active_slave >= slave_count)
                internals->active_slave = 0;
 
        return num_rx_total;
@@ -487,35 +490,31 @@ uint32_t burstnumberTX;
 #ifdef RTE_LIBRTE_BOND_DEBUG_ALB
 
 static void
-arp_op_name(uint16_t arp_op, char *buf)
+arp_op_name(uint16_t arp_op, char *buf, size_t buf_len)
 {
        switch (arp_op) {
-       case ARP_OP_REQUEST:
-               snprintf(buf, sizeof("ARP Request"), "%s", "ARP Request");
+       case RTE_ARP_OP_REQUEST:
+               strlcpy(buf, "ARP Request", buf_len);
                return;
-       case ARP_OP_REPLY:
-               snprintf(buf, sizeof("ARP Reply"), "%s", "ARP Reply");
+       case RTE_ARP_OP_REPLY:
+               strlcpy(buf, "ARP Reply", buf_len);
                return;
-       case ARP_OP_REVREQUEST:
-               snprintf(buf, sizeof("Reverse ARP Request"), "%s",
-                               "Reverse ARP Request");
+       case RTE_ARP_OP_REVREQUEST:
+               strlcpy(buf, "Reverse ARP Request", buf_len);
                return;
-       case ARP_OP_REVREPLY:
-               snprintf(buf, sizeof("Reverse ARP Reply"), "%s",
-                               "Reverse ARP Reply");
+       case RTE_ARP_OP_REVREPLY:
+               strlcpy(buf, "Reverse ARP Reply", buf_len);
                return;
-       case ARP_OP_INVREQUEST:
-               snprintf(buf, sizeof("Peer Identify Request"), "%s",
-                               "Peer Identify Request");
+       case RTE_ARP_OP_INVREQUEST:
+               strlcpy(buf, "Peer Identify Request", buf_len);
                return;
-       case ARP_OP_INVREPLY:
-               snprintf(buf, sizeof("Peer Identify Reply"), "%s",
-                               "Peer Identify Reply");
+       case RTE_ARP_OP_INVREPLY:
+               strlcpy(buf, "Peer Identify Reply", buf_len);
                return;
        default:
                break;
        }
-       snprintf(buf, sizeof("Unknown"), "%s", "Unknown");
+       strlcpy(buf, "Unknown", buf_len);
        return;
 }
 #endif
@@ -586,12 +585,13 @@ update_client_stats(uint32_t addr, uint16_t port, uint32_t *TXorRXindicator)
 #endif
 
 static void
-mode6_debug(const char __attribute__((unused)) *info, struct ether_hdr *eth_h,
-               uint16_t port, uint32_t __attribute__((unused)) *burstnumber)
+mode6_debug(const char __attribute__((unused)) *info,
+       struct rte_ether_hdr *eth_h, uint16_t port,
+       uint32_t __attribute__((unused)) *burstnumber)
 {
        struct ipv4_hdr *ipv4_h;
 #ifdef RTE_LIBRTE_BOND_DEBUG_ALB
-       struct arp_hdr *arp_h;
+       struct rte_arp_hdr *arp_h;
        char dst_ip[16];
        char ArpOp[24];
        char buf[16];
@@ -616,10 +616,11 @@ mode6_debug(const char __attribute__((unused)) *info, struct ether_hdr *eth_h,
        }
 #ifdef RTE_LIBRTE_BOND_DEBUG_ALB
        else if (ether_type == rte_cpu_to_be_16(ETHER_TYPE_ARP)) {
-               arp_h = (struct arp_hdr *)((char *)(eth_h + 1) + offset);
+               arp_h = (struct rte_arp_hdr *)((char *)(eth_h + 1) + offset);
                ipv4_addr_to_dot(arp_h->arp_data.arp_sip, src_ip, MaxIPv4String);
                ipv4_addr_to_dot(arp_h->arp_data.arp_tip, dst_ip, MaxIPv4String);
-               arp_op_name(rte_be_to_cpu_16(arp_h->arp_op), ArpOp);
+               arp_op_name(rte_be_to_cpu_16(arp_h->arp_opcode),
+                               ArpOp, sizeof(ArpOp));
                MODE6_DEBUG(buf, src_ip, dst_ip, eth_h, ArpOp, port, *burstnumber);
        }
 #endif
@@ -631,7 +632,7 @@ bond_ethdev_rx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
        struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;
        struct bond_dev_private *internals = bd_tx_q->dev_private;
-       struct ether_hdr *eth_h;
+       struct rte_ether_hdr *eth_h;
        uint16_t ether_type, offset;
        uint16_t nb_recv_pkts;
        int i;
@@ -639,7 +640,7 @@ bond_ethdev_rx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        nb_recv_pkts = bond_ethdev_rx_burst(queue, bufs, nb_pkts);
 
        for (i = 0; i < nb_recv_pkts; i++) {
-               eth_h = rte_pktmbuf_mtod(bufs[i], struct ether_hdr *);
+               eth_h = rte_pktmbuf_mtod(bufs[i], struct rte_ether_hdr *);
                ether_type = eth_h->ether_type;
                offset = get_vlan_offset(eth_h, &ether_type);
 
@@ -739,7 +740,7 @@ bond_ethdev_tx_burst_active_backup(void *queue,
 }
 
 static inline uint16_t
-ether_hash(struct ether_hdr *eth_hdr)
+ether_hash(struct rte_ether_hdr *eth_hdr)
 {
        unaligned_uint16_t *word_src_addr =
                (unaligned_uint16_t *)eth_hdr->s_addr.addr_bytes;
@@ -774,14 +775,14 @@ ipv6_hash(struct ipv6_hdr *ipv6_hdr)
 
 void
 burst_xmit_l2_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
-               uint8_t slave_count, uint16_t *slaves)
+               uint16_t slave_count, uint16_t *slaves)
 {
-       struct ether_hdr *eth_hdr;
+       struct rte_ether_hdr *eth_hdr;
        uint32_t hash;
        int i;
 
        for (i = 0; i < nb_pkts; i++) {
-               eth_hdr = rte_pktmbuf_mtod(buf[i], struct ether_hdr *);
+               eth_hdr = rte_pktmbuf_mtod(buf[i], struct rte_ether_hdr *);
 
                hash = ether_hash(eth_hdr);
 
@@ -791,16 +792,16 @@ burst_xmit_l2_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
 
 void
 burst_xmit_l23_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
-               uint8_t slave_count, uint16_t *slaves)
+               uint16_t slave_count, uint16_t *slaves)
 {
        uint16_t i;
-       struct ether_hdr *eth_hdr;
+       struct rte_ether_hdr *eth_hdr;
        uint16_t proto;
        size_t vlan_offset;
        uint32_t hash, l3hash;
 
        for (i = 0; i < nb_pkts; i++) {
-               eth_hdr = rte_pktmbuf_mtod(buf[i], struct ether_hdr *);
+               eth_hdr = rte_pktmbuf_mtod(buf[i], struct rte_ether_hdr *);
                l3hash = 0;
 
                proto = eth_hdr->ether_type;
@@ -829,9 +830,9 @@ burst_xmit_l23_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
 
 void
 burst_xmit_l34_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
-               uint8_t slave_count, uint16_t *slaves)
+               uint16_t slave_count, uint16_t *slaves)
 {
-       struct ether_hdr *eth_hdr;
+       struct rte_ether_hdr *eth_hdr;
        uint16_t proto;
        size_t vlan_offset;
        int i;
@@ -841,7 +842,8 @@ burst_xmit_l34_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
        uint32_t hash, l3hash, l4hash;
 
        for (i = 0; i < nb_pkts; i++) {
-               eth_hdr = rte_pktmbuf_mtod(buf[i], struct ether_hdr *);
+               eth_hdr = rte_pktmbuf_mtod(buf[i], struct rte_ether_hdr *);
+               size_t pkt_end = (size_t)eth_hdr + rte_pktmbuf_data_len(buf[i]);
                proto = eth_hdr->ether_type;
                vlan_offset = get_vlan_offset(eth_hdr, &proto);
                l3hash = 0;
@@ -865,13 +867,17 @@ burst_xmit_l34_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
                                        tcp_hdr = (struct tcp_hdr *)
                                                ((char *)ipv4_hdr +
                                                        ip_hdr_offset);
-                                       l4hash = HASH_L4_PORTS(tcp_hdr);
+                                       if ((size_t)tcp_hdr + sizeof(*tcp_hdr)
+                                                       < pkt_end)
+                                               l4hash = HASH_L4_PORTS(tcp_hdr);
                                } else if (ipv4_hdr->next_proto_id ==
                                                                IPPROTO_UDP) {
                                        udp_hdr = (struct udp_hdr *)
                                                ((char *)ipv4_hdr +
                                                        ip_hdr_offset);
-                                       l4hash = HASH_L4_PORTS(udp_hdr);
+                                       if ((size_t)udp_hdr + sizeof(*udp_hdr)
+                                                       < pkt_end)
+                                               l4hash = HASH_L4_PORTS(udp_hdr);
                                }
                        }
                } else if  (rte_cpu_to_be_16(ETHER_TYPE_IPv6) == proto) {
@@ -899,7 +905,7 @@ burst_xmit_l34_hash(struct rte_mbuf **buf, uint16_t nb_pkts,
 struct bwg_slave {
        uint64_t bwg_left_int;
        uint64_t bwg_left_remainder;
-       uint8_t slave;
+       uint16_t slave;
 };
 
 void
@@ -952,11 +958,12 @@ bond_ethdev_update_tlb_slave_cb(void *arg)
        struct bond_dev_private *internals = arg;
        struct rte_eth_stats slave_stats;
        struct bwg_slave bwg_array[RTE_MAX_ETHPORTS];
-       uint8_t slave_count;
+       uint16_t slave_count;
        uint64_t tx_bytes;
 
        uint8_t update_stats = 0;
-       uint8_t i, slave_id;
+       uint16_t slave_id;
+       uint16_t i;
 
        internals->slave_update_idx++;
 
@@ -1003,9 +1010,9 @@ bond_ethdev_tx_burst_tlb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        uint16_t num_of_slaves = internals->active_slave_count;
        uint16_t slaves[RTE_MAX_ETHPORTS];
 
-       struct ether_hdr *ether_hdr;
-       struct ether_addr primary_slave_addr;
-       struct ether_addr active_slave_addr;
+       struct rte_ether_hdr *ether_hdr;
+       struct rte_ether_addr primary_slave_addr;
+       struct rte_ether_addr active_slave_addr;
 
        if (num_of_slaves < 1)
                return num_tx_total;
@@ -1027,7 +1034,8 @@ bond_ethdev_tx_burst_tlb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                        if (j + 3 < nb_pkts)
                                rte_prefetch0(rte_pktmbuf_mtod(bufs[j+3], void*));
 
-                       ether_hdr = rte_pktmbuf_mtod(bufs[j], struct ether_hdr *);
+                       ether_hdr = rte_pktmbuf_mtod(bufs[j],
+                                               struct rte_ether_hdr *);
                        if (is_same_ether_addr(&ether_hdr->s_addr, &primary_slave_addr))
                                ether_addr_copy(&active_slave_addr, &ether_hdr->s_addr);
 #if defined(RTE_LIBRTE_BOND_DEBUG_ALB) || defined(RTE_LIBRTE_BOND_DEBUG_ALB_L1)
@@ -1063,7 +1071,7 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;
        struct bond_dev_private *internals = bd_tx_q->dev_private;
 
-       struct ether_hdr *eth_h;
+       struct rte_ether_hdr *eth_h;
        uint16_t ether_type, offset;
 
        struct client_data *client_info;
@@ -1093,7 +1101,7 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 
        /* Search tx buffer for ARP packets and forward them to alb */
        for (i = 0; i < nb_pkts; i++) {
-               eth_h = rte_pktmbuf_mtod(bufs[i], struct ether_hdr *);
+               eth_h = rte_pktmbuf_mtod(bufs[i], struct rte_ether_hdr *);
                ether_type = eth_h->ether_type;
                offset = get_vlan_offset(eth_h, &ether_type);
 
@@ -1127,8 +1135,10 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                                                     "Failed to allocate ARP packet from pool");
                                        continue;
                                }
-                               pkt_size = sizeof(struct ether_hdr) + sizeof(struct arp_hdr)
-                                               + client_info->vlan_count * sizeof(struct vlan_hdr);
+                               pkt_size = sizeof(struct rte_ether_hdr) +
+                                       sizeof(struct rte_arp_hdr) +
+                                       client_info->vlan_count *
+                                       sizeof(struct rte_vlan_hdr);
                                upd_pkt->data_len = pkt_size;
                                upd_pkt->pkt_len = pkt_size;
 
@@ -1159,7 +1169,8 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 #if defined(RTE_LIBRTE_BOND_DEBUG_ALB) || defined(RTE_LIBRTE_BOND_DEBUG_ALB_L1)
        /* Print TX stats including update packets */
                        for (j = 0; j < slave_bufs_pkts[i]; j++) {
-                               eth_h = rte_pktmbuf_mtod(slave_bufs[i][j], struct ether_hdr *);
+                               eth_h = rte_pktmbuf_mtod(slave_bufs[i][j],
+                                                       struct rte_ether_hdr *);
                                mode6_debug("TX ARP:", eth_h, i, &burstnumberTX);
                        }
 #endif
@@ -1176,7 +1187,8 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                        }
 #if defined(RTE_LIBRTE_BOND_DEBUG_ALB) || defined(RTE_LIBRTE_BOND_DEBUG_ALB_L1)
                        for (j = 0; j < update_bufs_pkts[i]; j++) {
-                               eth_h = rte_pktmbuf_mtod(update_bufs[i][j], struct ether_hdr *);
+                               eth_h = rte_pktmbuf_mtod(update_bufs[i][j],
+                                                       struct rte_ether_hdr *);
                                mode6_debug("TX ARPupd:", eth_h, i, &burstnumberTX);
                        }
 #endif
@@ -1243,7 +1255,7 @@ bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs,
 
        for (i = 0; i < nb_bufs; i++) {
                /* Populate slave mbuf arrays with mbufs for that slave. */
-               uint8_t slave_idx = bufs_slave_port_idxs[i];
+               uint16_t slave_idx = bufs_slave_port_idxs[i];
 
                slave_bufs[slave_idx][slave_nb_bufs[slave_idx]++] = bufs[i];
        }
@@ -1298,9 +1310,6 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
 
        uint16_t i;
 
-       if (unlikely(nb_bufs == 0))
-               return 0;
-
        /* Copy slave list to protect against slave up/down changes during tx
         * bursting */
        slave_count = internals->active_slave_count;
@@ -1310,6 +1319,30 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
        memcpy(slave_port_ids, internals->active_slaves,
                        sizeof(slave_port_ids[0]) * slave_count);
 
+       /* Check for LACP control packets and send if available */
+       for (i = 0; i < slave_count; i++) {
+               struct port *port = &bond_mode_8023ad_ports[slave_port_ids[i]];
+               struct rte_mbuf *ctrl_pkt = NULL;
+
+               if (likely(rte_ring_empty(port->tx_ring)))
+                       continue;
+
+               if (rte_ring_dequeue(port->tx_ring,
+                                    (void **)&ctrl_pkt) != -ENOENT) {
+                       slave_tx_count = rte_eth_tx_burst(slave_port_ids[i],
+                                       bd_tx_q->queue_id, &ctrl_pkt, 1);
+                       /*
+                        * re-enqueue LAG control plane packets to buffering
+                        * ring if transmission fails so the packet isn't lost.
+                        */
+                       if (slave_tx_count != 1)
+                               rte_ring_enqueue(port->tx_ring, ctrl_pkt);
+               }
+       }
+
+       if (unlikely(nb_bufs == 0))
+               return 0;
+
        dist_slave_count = 0;
        for (i = 0; i < slave_count; i++) {
                struct port *port = &bond_mode_8023ad_ports[slave_port_ids[i]];
@@ -1319,7 +1352,7 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
                                        slave_port_ids[i];
        }
 
-       if (likely(dist_slave_count > 1)) {
+       if (likely(dist_slave_count > 0)) {
 
                /*
                 * Populate slaves mbuf with the packets which are to be sent
@@ -1333,7 +1366,7 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
                         * Populate slave mbuf arrays with mbufs for that
                         * slave
                         */
-                       uint8_t slave_idx = bufs_slave_port_idxs[i];
+                       uint16_t slave_idx = bufs_slave_port_idxs[i];
 
                        slave_bufs[slave_idx][slave_nb_bufs[slave_idx]++] =
                                        bufs[i];
@@ -1365,27 +1398,6 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
                }
        }
 
-       /* Check for LACP control packets and send if available */
-       for (i = 0; i < slave_count; i++) {
-               struct port *port = &bond_mode_8023ad_ports[slave_port_ids[i]];
-               struct rte_mbuf *ctrl_pkt = NULL;
-
-               if (likely(rte_ring_empty(port->tx_ring)))
-                       continue;
-
-               if (rte_ring_dequeue(port->tx_ring,
-                                    (void **)&ctrl_pkt) != -ENOENT) {
-                       slave_tx_count = rte_eth_tx_burst(slave_port_ids[i],
-                                       bd_tx_q->queue_id, &ctrl_pkt, 1);
-                       /*
-                        * re-enqueue LAG control plane packets to buffering
-                        * ring if transmission fails so the packet isn't lost.
-                        */
-                       if (slave_tx_count != 1)
-                               rte_ring_enqueue(port->tx_ring, ctrl_pkt);
-               }
-       }
-
        return total_tx_count;
 }
 
@@ -1396,8 +1408,9 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs,
        struct bond_dev_private *internals;
        struct bond_tx_queue *bd_tx_q;
 
-       uint8_t tx_failed_flag = 0, num_of_slaves;
        uint16_t slaves[RTE_MAX_ETHPORTS];
+       uint8_t tx_failed_flag = 0;
+       uint16_t num_of_slaves;
 
        uint16_t max_nb_of_tx_pkts = 0;
 
@@ -1449,7 +1462,7 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs,
        return max_nb_of_tx_pkts;
 }
 
-void
+static void
 link_properties_set(struct rte_eth_dev *ethdev, struct rte_eth_link *slave_link)
 {
        struct bond_dev_private *bond_ctx = ethdev->data->dev_private;
@@ -1474,7 +1487,7 @@ link_properties_set(struct rte_eth_dev *ethdev, struct rte_eth_link *slave_link)
        }
 }
 
-int
+static int
 link_properties_valid(struct rte_eth_dev *ethdev,
                struct rte_eth_link *slave_link)
 {
@@ -1493,9 +1506,10 @@ link_properties_valid(struct rte_eth_dev *ethdev,
 }
 
 int
-mac_address_get(struct rte_eth_dev *eth_dev, struct ether_addr *dst_mac_addr)
+mac_address_get(struct rte_eth_dev *eth_dev,
+               struct rte_ether_addr *dst_mac_addr)
 {
-       struct ether_addr *mac_addr;
+       struct rte_ether_addr *mac_addr;
 
        if (eth_dev == NULL) {
                RTE_BOND_LOG(ERR, "NULL pointer eth_dev specified");
@@ -1514,9 +1528,10 @@ mac_address_get(struct rte_eth_dev *eth_dev, struct ether_addr *dst_mac_addr)
 }
 
 int
-mac_address_set(struct rte_eth_dev *eth_dev, struct ether_addr *new_mac_addr)
+mac_address_set(struct rte_eth_dev *eth_dev,
+               struct rte_ether_addr *new_mac_addr)
 {
-       struct ether_addr *mac_addr;
+       struct rte_ether_addr *mac_addr;
 
        if (eth_dev == NULL) {
                RTE_BOND_LOG(ERR, "NULL pointer eth_dev specified");
@@ -1537,7 +1552,7 @@ mac_address_set(struct rte_eth_dev *eth_dev, struct ether_addr *new_mac_addr)
        return 0;
 }
 
-static const struct ether_addr null_mac_addr;
+static const struct rte_ether_addr null_mac_addr;
 
 /*
  * Add additional MAC addresses to the slave
@@ -1547,7 +1562,7 @@ slave_add_mac_addresses(struct rte_eth_dev *bonded_eth_dev,
                uint16_t slave_port_id)
 {
        int i, ret;
-       struct ether_addr *mac_addr;
+       struct rte_ether_addr *mac_addr;
 
        for (i = 1; i < BOND_MAX_MAC_ADDRS; i++) {
                mac_addr = &bonded_eth_dev->data->mac_addrs[i];
@@ -1575,7 +1590,7 @@ slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev,
                uint16_t slave_port_id)
 {
        int i, rc, ret;
-       struct ether_addr *mac_addr;
+       struct rte_ether_addr *mac_addr;
 
        rc = 0;
        for (i = 1; i < BOND_MAX_MAC_ADDRS; i++) {
@@ -1948,7 +1963,7 @@ void
 slave_remove(struct bond_dev_private *internals,
                struct rte_eth_dev *slave_eth_dev)
 {
-       uint8_t i;
+       uint16_t i;
 
        for (i = 0; i < internals->slave_count; i++)
                if (internals->slaves[i].port_id ==
@@ -1998,7 +2013,7 @@ slave_add(struct bond_dev_private *internals,
        slave_details->link_status_wait_to_complete = 0;
        /* clean tlb_last_obytes when adding port for bonding device */
        memcpy(&(slave_details->persisted_mac_addr), slave_eth_dev->data->mac_addrs,
-                       sizeof(struct ether_addr));
+                       sizeof(struct rte_ether_addr));
 }
 
 void
@@ -2044,7 +2059,7 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
        }
 
        if (internals->user_defined_mac == 0) {
-               struct ether_addr *new_mac_addr = NULL;
+               struct rte_ether_addr *new_mac_addr = NULL;
 
                for (i = 0; i < internals->slave_count; i++)
                        if (internals->slaves[i].port_id == internals->primary_port)
@@ -2124,7 +2139,7 @@ out_err:
 static void
 bond_ethdev_free_queues(struct rte_eth_dev *dev)
 {
-       uint8_t i;
+       uint16_t i;
 
        if (dev->data->rx_queues != NULL) {
                for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -2147,7 +2162,7 @@ void
 bond_ethdev_stop(struct rte_eth_dev *eth_dev)
 {
        struct bond_dev_private *internals = eth_dev->data->dev_private;
-       uint8_t i;
+       uint16_t i;
 
        if (internals->mode == BONDING_MODE_8023AD) {
                struct port *port;
@@ -2196,7 +2211,7 @@ void
 bond_ethdev_close(struct rte_eth_dev *dev)
 {
        struct bond_dev_private *internals = dev->data->dev_private;
-       uint8_t bond_port_id = internals->port_id;
+       uint16_t bond_port_id = internals->port_id;
        int skipped = 0;
        struct rte_flow_error ferror;
 
@@ -2243,7 +2258,7 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
         */
        if (internals->slave_count > 0) {
                struct rte_eth_dev_info slave_info;
-               uint8_t idx;
+               uint16_t idx;
 
                for (idx = 0; idx < internals->slave_count; idx++) {
                        rte_eth_dev_info_get(internals->slaves[idx].port_id,
@@ -2599,6 +2614,9 @@ bond_ethdev_promiscuous_enable(struct rte_eth_dev *eth_dev)
        case BONDING_MODE_TLB:
        case BONDING_MODE_ALB:
        default:
+               /* Do not touch promisc when there cannot be primary ports */
+               if (internals->slave_count == 0)
+                       break;
                rte_eth_promiscuous_enable(internals->current_primary_port);
        }
 }
@@ -2627,6 +2645,9 @@ bond_ethdev_promiscuous_disable(struct rte_eth_dev *dev)
        case BONDING_MODE_TLB:
        case BONDING_MODE_ALB:
        default:
+               /* Do not touch promisc when there cannot be primary ports */
+               if (internals->slave_count == 0)
+                       break;
                rte_eth_promiscuous_disable(internals->current_primary_port);
        }
 }
@@ -2650,14 +2671,15 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type,
        struct rte_eth_link link;
        int rc = -1;
 
-       int i, valid_slave = 0;
-       uint8_t active_pos;
        uint8_t lsc_flag = 0;
+       int valid_slave = 0;
+       uint16_t active_pos;
+       uint16_t i;
 
        if (type != RTE_ETH_EVENT_INTR_LSC || param == NULL)
                return rc;
 
-       bonded_eth_dev = &rte_eth_devices[*(uint8_t *)param];
+       bonded_eth_dev = &rte_eth_devices[*(uint16_t *)param];
 
        if (check_for_bonded_ethdev(bonded_eth_dev))
                return rc;
@@ -2693,16 +2715,6 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type,
                if (active_pos < internals->active_slave_count)
                        goto link_update;
 
-               /* if no active slave ports then set this port to be primary port */
-               if (internals->active_slave_count < 1) {
-                       /* If first active slave, then change link status */
-                       bonded_eth_dev->data->dev_link.link_status = ETH_LINK_UP;
-                       internals->current_primary_port = port_id;
-                       lsc_flag = 1;
-
-                       mac_address_slaves_update(bonded_eth_dev);
-               }
-
                /* check link state properties if bonded link is up*/
                if (bonded_eth_dev->data->dev_link.link_status == ETH_LINK_UP) {
                        if (link_properties_valid(bonded_eth_dev, &link) != 0)
@@ -2714,9 +2726,24 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type,
                        link_properties_set(bonded_eth_dev, &link);
                }
 
+               /* If no active slave ports then set this port to be
+                * the primary port.
+                */
+               if (internals->active_slave_count < 1) {
+                       /* If first active slave, then change link status */
+                       bonded_eth_dev->data->dev_link.link_status =
+                                                               ETH_LINK_UP;
+                       internals->current_primary_port = port_id;
+                       lsc_flag = 1;
+
+                       mac_address_slaves_update(bonded_eth_dev);
+               }
+
                activate_slave(bonded_eth_dev, port_id);
 
-               /* If user has defined the primary port then default to using it */
+               /* If the user has defined the primary port then default to
+                * using it.
+                */
                if (internals->user_defined_primary_port &&
                                internals->primary_port == port_id)
                        bond_ethdev_primary_set(internals, port_id);
@@ -2918,7 +2945,8 @@ bond_ethdev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 }
 
 static int
-bond_ethdev_mac_address_set(struct rte_eth_dev *dev, struct ether_addr *addr)
+bond_ethdev_mac_address_set(struct rte_eth_dev *dev,
+                       struct rte_ether_addr *addr)
 {
        if (mac_address_set(dev, addr)) {
                RTE_BOND_LOG(ERR, "Failed to update MAC address");
@@ -2940,8 +2968,9 @@ bond_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
 }
 
 static int
-bond_ethdev_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
-                               __rte_unused uint32_t index, uint32_t vmdq)
+bond_ethdev_mac_addr_add(struct rte_eth_dev *dev,
+                       struct rte_ether_addr *mac_addr,
+                       __rte_unused uint32_t index, uint32_t vmdq)
 {
        struct rte_eth_dev *slave_eth_dev;
        struct bond_dev_private *internals = dev->data->dev_private;
@@ -2991,7 +3020,7 @@ bond_ethdev_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)
                        goto end;
        }
 
-       struct ether_addr *mac_addr = &dev->data->mac_addrs[index];
+       struct rte_ether_addr *mac_addr = &dev->data->mac_addrs[index];
 
        for (i = 0; i < internals->slave_count; i++)
                rte_eth_dev_mac_addr_remove(internals->slaves[i].port_id,
@@ -3369,7 +3398,7 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
        /* Parse MAC address for bonded device */
        arg_count = rte_kvargs_count(kvlist, PMD_BOND_MAC_ADDR_KVARG);
        if (arg_count == 1) {
-               struct ether_addr bond_mac;
+               struct rte_ether_addr bond_mac;
 
                if (rte_kvargs_process(kvlist, PMD_BOND_MAC_ADDR_KVARG,
                                       &bond_ethdev_parse_bond_mac_addr_kvarg, &bond_mac) < 0) {