net: add rte prefix to ether structures
[dpdk.git] / drivers / net / dpaa2 / dpaa2_ethdev.c
index 429b3a0..ae4d7e1 100644 (file)
@@ -1,41 +1,15 @@
-/*-
- *   BSD LICENSE
+/* * SPDX-License-Identifier: BSD-3-Clause
  *
  *   Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.
- *   Copyright 2016 NXP.
+ *   Copyright 2016 NXP
  *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Freescale Semiconductor, Inc nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include <time.h>
 #include <net/if.h>
 
 #include <rte_mbuf.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
 #include <rte_string_fns.h>
 #include <rte_kvargs.h>
 #include <rte_dev.h>
 #include <rte_fslmc.h>
+#include <rte_flow_driver.h>
 
-#include <fslmc_logs.h>
+#include "dpaa2_pmd_logs.h"
 #include <fslmc_vfio.h>
 #include <dpaa2_hw_pvt.h>
 #include <dpaa2_hw_mempool.h>
 #include <dpaa2_hw_dpio.h>
 #include <mc/fsl_dpmng.h>
 #include "dpaa2_ethdev.h"
+#include <fsl_qbman_debug.h>
+
+#define DRIVER_LOOPBACK_MODE "drv_loopback"
+
+/* Supported Rx offloads */
+static uint64_t dev_rx_offloads_sup =
+               DEV_RX_OFFLOAD_VLAN_STRIP |
+               DEV_RX_OFFLOAD_IPV4_CKSUM |
+               DEV_RX_OFFLOAD_UDP_CKSUM |
+               DEV_RX_OFFLOAD_TCP_CKSUM |
+               DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+               DEV_RX_OFFLOAD_VLAN_FILTER |
+               DEV_RX_OFFLOAD_JUMBO_FRAME;
+
+/* Rx offloads which cannot be disabled */
+static uint64_t dev_rx_offloads_nodis =
+               DEV_RX_OFFLOAD_SCATTER;
+
+/* Supported Tx offloads */
+static uint64_t dev_tx_offloads_sup =
+               DEV_TX_OFFLOAD_VLAN_INSERT |
+               DEV_TX_OFFLOAD_IPV4_CKSUM |
+               DEV_TX_OFFLOAD_UDP_CKSUM |
+               DEV_TX_OFFLOAD_TCP_CKSUM |
+               DEV_TX_OFFLOAD_SCTP_CKSUM |
+               DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
+
+/* Tx offloads which cannot be disabled */
+static uint64_t dev_tx_offloads_nodis =
+               DEV_TX_OFFLOAD_MULTI_SEGS |
+               DEV_TX_OFFLOAD_MT_LOCKFREE |
+               DEV_TX_OFFLOAD_MBUF_FAST_FREE;
+
+/* enable timestamp in mbuf */
+enum pmd_dpaa2_ts dpaa2_enable_ts;
+
+struct rte_dpaa2_xstats_name_off {
+       char name[RTE_ETH_XSTATS_NAME_SIZE];
+       uint8_t page_id; /* dpni statistics page id */
+       uint8_t stats_id; /* stats id in the given page */
+};
+
+static const struct rte_dpaa2_xstats_name_off dpaa2_xstats_strings[] = {
+       {"ingress_multicast_frames", 0, 2},
+       {"ingress_multicast_bytes", 0, 3},
+       {"ingress_broadcast_frames", 0, 4},
+       {"ingress_broadcast_bytes", 0, 5},
+       {"egress_multicast_frames", 1, 2},
+       {"egress_multicast_bytes", 1, 3},
+       {"egress_broadcast_frames", 1, 4},
+       {"egress_broadcast_bytes", 1, 5},
+       {"ingress_filtered_frames", 2, 0},
+       {"ingress_discarded_frames", 2, 1},
+       {"ingress_nobuffer_discards", 2, 2},
+       {"egress_discarded_frames", 2, 3},
+       {"egress_confirmed_frames", 2, 4},
+};
+
+static const enum rte_filter_op dpaa2_supported_filter_ops[] = {
+       RTE_ETH_FILTER_ADD,
+       RTE_ETH_FILTER_DELETE,
+       RTE_ETH_FILTER_UPDATE,
+       RTE_ETH_FILTER_FLUSH,
+       RTE_ETH_FILTER_GET
+};
 
 static struct rte_dpaa2_driver rte_dpaa2_pmd;
 static int dpaa2_dev_uninit(struct rte_eth_dev *eth_dev);
+static int dpaa2_dev_link_update(struct rte_eth_dev *dev,
+                                int wait_to_complete);
 static int dpaa2_dev_set_link_up(struct rte_eth_dev *dev);
 static int dpaa2_dev_set_link_down(struct rte_eth_dev *dev);
 static int dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 
-/**
- * Atomically reads the link status information from global
- * structure rte_eth_dev.
- *
- * @param dev
- *   - Pointer to the structure rte_eth_dev to read from.
- *   - Pointer to the buffer to be saved with the link status.
- *
- * @return
- *   - On success, zero.
- *   - On failure, negative value.
- */
-static inline int
-dpaa2_dev_atomic_read_link_status(struct rte_eth_dev *dev,
-                                 struct rte_eth_link *link)
-{
-       struct rte_eth_link *dst = link;
-       struct rte_eth_link *src = &dev->data->dev_link;
-
-       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
-                               *(uint64_t *)src) == 0)
-               return -1;
-
-       return 0;
-}
+int dpaa2_logtype_pmd;
 
-/**
- * Atomically writes the link status information into global
- * structure rte_eth_dev.
- *
- * @param dev
- *   - Pointer to the structure rte_eth_dev to read from.
- *   - Pointer to the buffer to be saved with the link status.
- *
- * @return
- *   - On success, zero.
- *   - On failure, negative value.
- */
-static inline int
-dpaa2_dev_atomic_write_link_status(struct rte_eth_dev *dev,
-                                  struct rte_eth_link *link)
+__rte_experimental void
+rte_pmd_dpaa2_set_timestamp(enum pmd_dpaa2_ts enable)
 {
-       struct rte_eth_link *dst = &dev->data->dev_link;
-       struct rte_eth_link *src = link;
-
-       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
-                               *(uint64_t *)src) == 0)
-               return -1;
-
-       return 0;
+       dpaa2_enable_ts = enable;
 }
 
 static int
@@ -120,7 +118,7 @@ dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return -1;
        }
 
@@ -132,13 +130,13 @@ dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
                                          priv->token, vlan_id);
 
        if (ret < 0)
-               PMD_DRV_LOG(ERR, "ret = %d Unable to add/rem vlan %d hwid =%d",
-                           ret, vlan_id, priv->hw_id);
+               DPAA2_PMD_ERR("ret = %d Unable to add/rem vlan %d hwid =%d",
+                             ret, vlan_id, priv->hw_id);
 
        return ret;
 }
 
-static void
+static int
 dpaa2_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
@@ -148,16 +146,68 @@ dpaa2_vlan_offload_set(struct rte_eth_dev *dev, int mask)
        PMD_INIT_FUNC_TRACE();
 
        if (mask & ETH_VLAN_FILTER_MASK) {
-               if (dev->data->dev_conf.rxmode.hw_vlan_filter)
+               /* VLAN Filter not avaialble */
+               if (!priv->max_vlan_filters) {
+                       DPAA2_PMD_INFO("VLAN filter not available");
+                       goto next_mask;
+               }
+
+               if (dev->data->dev_conf.rxmode.offloads &
+                       DEV_RX_OFFLOAD_VLAN_FILTER)
                        ret = dpni_enable_vlan_filter(dpni, CMD_PRI_LOW,
                                                      priv->token, true);
                else
                        ret = dpni_enable_vlan_filter(dpni, CMD_PRI_LOW,
                                                      priv->token, false);
                if (ret < 0)
-                       RTE_LOG(ERR, PMD, "Unable to set vlan filter = %d\n",
-                               ret);
+                       DPAA2_PMD_INFO("Unable to set vlan filter = %d", ret);
+       }
+next_mask:
+       if (mask & ETH_VLAN_EXTEND_MASK) {
+               if (dev->data->dev_conf.rxmode.offloads &
+                       DEV_RX_OFFLOAD_VLAN_EXTEND)
+                       DPAA2_PMD_INFO("VLAN extend offload not supported");
+       }
+
+       return 0;
+}
+
+static int
+dpaa2_vlan_tpid_set(struct rte_eth_dev *dev,
+                     enum rte_vlan_type vlan_type __rte_unused,
+                     uint16_t tpid)
+{
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = priv->hw;
+       int ret = -ENOTSUP;
+
+       PMD_INIT_FUNC_TRACE();
+
+       /* nothing to be done for standard vlan tpids */
+       if (tpid == 0x8100 || tpid == 0x88A8)
+               return 0;
+
+       ret = dpni_add_custom_tpid(dpni, CMD_PRI_LOW,
+                                  priv->token, tpid);
+       if (ret < 0)
+               DPAA2_PMD_INFO("Unable to set vlan tpid = %d", ret);
+       /* if already configured tpids, remove them first */
+       if (ret == -EBUSY) {
+               struct dpni_custom_tpid_cfg tpid_list = {0};
+
+               ret = dpni_get_custom_tpid(dpni, CMD_PRI_LOW,
+                                  priv->token, &tpid_list);
+               if (ret < 0)
+                       goto fail;
+               ret = dpni_remove_custom_tpid(dpni, CMD_PRI_LOW,
+                                  priv->token, tpid_list.tpid1);
+               if (ret < 0)
+                       goto fail;
+               ret = dpni_add_custom_tpid(dpni, CMD_PRI_LOW,
+                                          priv->token, tpid);
        }
+fail:
+       return ret;
 }
 
 static int
@@ -174,10 +224,10 @@ dpaa2_fw_version_get(struct rte_eth_dev *dev,
        PMD_INIT_FUNC_TRACE();
 
        if (mc_get_soc_version(dpni, CMD_PRI_LOW, &mc_plat_info))
-               RTE_LOG(WARNING, PMD, "\tmc_get_soc_version failed\n");
+               DPAA2_PMD_WARN("\tmc_get_soc_version failed");
 
        if (mc_get_version(dpni, CMD_PRI_LOW, &mc_ver_info))
-               RTE_LOG(WARNING, PMD, "\tmc_get_version failed\n");
+               DPAA2_PMD_WARN("\tmc_get_version failed");
 
        ret = snprintf(fw_version, fw_size,
                       "%x-%d.%d.%d",
@@ -207,20 +257,18 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->min_rx_bufsize = DPAA2_MIN_RX_BUF_SIZE;
        dev_info->max_rx_queues = (uint16_t)priv->nb_rx_queues;
        dev_info->max_tx_queues = (uint16_t)priv->nb_tx_queues;
-       dev_info->rx_offload_capa =
-               DEV_RX_OFFLOAD_IPV4_CKSUM |
-               DEV_RX_OFFLOAD_UDP_CKSUM |
-               DEV_RX_OFFLOAD_TCP_CKSUM |
-               DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
-       dev_info->tx_offload_capa =
-               DEV_TX_OFFLOAD_IPV4_CKSUM |
-               DEV_TX_OFFLOAD_UDP_CKSUM |
-               DEV_TX_OFFLOAD_TCP_CKSUM |
-               DEV_TX_OFFLOAD_SCTP_CKSUM |
-               DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
+       dev_info->rx_offload_capa = dev_rx_offloads_sup |
+                                       dev_rx_offloads_nodis;
+       dev_info->tx_offload_capa = dev_tx_offloads_sup |
+                                       dev_tx_offloads_nodis;
        dev_info->speed_capa = ETH_LINK_SPEED_1G |
                        ETH_LINK_SPEED_2_5G |
                        ETH_LINK_SPEED_10G;
+
+       dev_info->max_hash_mac_addrs = 0;
+       dev_info->max_vfs = 0;
+       dev_info->max_vmdq_pools = ETH_16_POOLS;
+       dev_info->flow_type_rss_offloads = DPAA2_RSS_OFFLOAD_ALL;
 }
 
 static int
@@ -229,6 +277,7 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev)
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        uint16_t dist_idx;
        uint32_t vq_id;
+       uint8_t num_rxqueue_per_tc;
        struct dpaa2_queue *mc_q, *mcq;
        uint32_t tot_queues;
        int i;
@@ -236,16 +285,17 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE();
 
+       num_rxqueue_per_tc = (priv->nb_rx_queues / priv->num_rx_tc);
        tot_queues = priv->nb_rx_queues + priv->nb_tx_queues;
        mc_q = rte_malloc(NULL, sizeof(struct dpaa2_queue) * tot_queues,
                          RTE_CACHE_LINE_SIZE);
        if (!mc_q) {
-               PMD_INIT_LOG(ERR, "malloc failed for rx/tx queues\n");
+               DPAA2_PMD_ERR("Memory allocation failed for rx/tx queues");
                return -1;
        }
 
        for (i = 0; i < priv->nb_rx_queues; i++) {
-               mc_q->dev = dev;
+               mc_q->eth_data = dev->data;
                priv->rx_vq[i] = mc_q++;
                dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i];
                dpaa2_q->q_storage = rte_malloc("dq_storage",
@@ -261,7 +311,7 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev)
        }
 
        for (i = 0; i < priv->nb_tx_queues; i++) {
-               mc_q->dev = dev;
+               mc_q->eth_data = dev->data;
                mc_q->flow_id = 0xffff;
                priv->tx_vq[i] = mc_q++;
                dpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];
@@ -274,8 +324,8 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev)
        vq_id = 0;
        for (dist_idx = 0; dist_idx < priv->nb_rx_queues; dist_idx++) {
                mcq = (struct dpaa2_queue *)priv->rx_vq[vq_id];
-               mcq->tc_index = DPAA2_DEF_TC;
-               mcq->flow_id = dist_idx;
+               mcq->tc_index = dist_idx / num_rxqueue_per_tc;
+               mcq->flow_id = dist_idx % num_rxqueue_per_tc;
                vq_id++;
        }
 
@@ -301,22 +351,73 @@ fail:
        return -1;
 }
 
+static void
+dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
+{
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct dpaa2_queue *dpaa2_q;
+       int i;
+
+       PMD_INIT_FUNC_TRACE();
+
+       /* Queue allocation base */
+       if (priv->rx_vq[0]) {
+               /* cleaning up queue storage */
+               for (i = 0; i < priv->nb_rx_queues; i++) {
+                       dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i];
+                       if (dpaa2_q->q_storage)
+                               rte_free(dpaa2_q->q_storage);
+               }
+               /* cleanup tx queue cscn */
+               for (i = 0; i < priv->nb_tx_queues; i++) {
+                       dpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];
+                       rte_free(dpaa2_q->cscn);
+               }
+               /*free memory for all queues (RX+TX) */
+               rte_free(priv->rx_vq[0]);
+               priv->rx_vq[0] = NULL;
+       }
+}
+
 static int
 dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
 {
-       struct rte_eth_dev_data *data = dev->data;
-       struct rte_eth_conf *eth_conf = &data->dev_conf;
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = priv->hw;
+       struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
+       uint64_t rx_offloads = eth_conf->rxmode.offloads;
+       uint64_t tx_offloads = eth_conf->txmode.offloads;
+       int rx_l3_csum_offload = false;
+       int rx_l4_csum_offload = false;
+       int tx_l3_csum_offload = false;
+       int tx_l4_csum_offload = false;
        int ret;
 
        PMD_INIT_FUNC_TRACE();
 
-       if (eth_conf->rxmode.jumbo_frame == 1) {
+       /* Rx offloads validation */
+       if (dev_rx_offloads_nodis & ~rx_offloads) {
+               DPAA2_PMD_WARN(
+               "Rx offloads non configurable - requested 0x%" PRIx64
+               " ignored 0x%" PRIx64,
+                       rx_offloads, dev_rx_offloads_nodis);
+       }
+
+       /* Tx offloads validation */
+       if (dev_tx_offloads_nodis & ~tx_offloads) {
+               DPAA2_PMD_WARN(
+               "Tx offloads non configurable - requested 0x%" PRIx64
+               " ignored 0x%" PRIx64,
+                       tx_offloads, dev_tx_offloads_nodis);
+       }
+
+       if (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
                if (eth_conf->rxmode.max_rx_pkt_len <= DPAA2_MAX_RX_PKT_LEN) {
-                       ret = dpaa2_dev_mtu_set(dev,
-                                       eth_conf->rxmode.max_rx_pkt_len);
+                       ret = dpni_set_max_frame_length(dpni, CMD_PRI_LOW,
+                               priv->token, eth_conf->rxmode.max_rx_pkt_len);
                        if (ret) {
-                               PMD_INIT_LOG(ERR,
-                                            "unable to set mtu. check config\n");
+                               DPAA2_PMD_ERR(
+                                       "Unable to set mtu. check config");
                                return ret;
                        }
                } else {
@@ -324,26 +425,80 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
                }
        }
 
-       /* Check for correct configuration */
-       if (eth_conf->rxmode.mq_mode != ETH_MQ_RX_RSS &&
-           data->nb_rx_queues > 1) {
-               PMD_INIT_LOG(ERR, "Distribution is not enabled, "
-                           "but Rx queues more than 1\n");
-               return -1;
-       }
-
        if (eth_conf->rxmode.mq_mode == ETH_MQ_RX_RSS) {
-               /* Return in case number of Rx queues is 1 */
-               if (data->nb_rx_queues == 1)
-                       return 0;
                ret = dpaa2_setup_flow_dist(dev,
                                eth_conf->rx_adv_conf.rss_conf.rss_hf);
                if (ret) {
-                       PMD_INIT_LOG(ERR, "unable to set flow distribution."
-                                    "please check queue config\n");
+                       DPAA2_PMD_ERR("Unable to set flow distribution."
+                                     "Check queue config");
+                       return ret;
+               }
+       }
+
+       if (rx_offloads & DEV_RX_OFFLOAD_IPV4_CKSUM)
+               rx_l3_csum_offload = true;
+
+       if ((rx_offloads & DEV_RX_OFFLOAD_UDP_CKSUM) ||
+               (rx_offloads & DEV_RX_OFFLOAD_TCP_CKSUM))
+               rx_l4_csum_offload = true;
+
+       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
+                              DPNI_OFF_RX_L3_CSUM, rx_l3_csum_offload);
+       if (ret) {
+               DPAA2_PMD_ERR("Error to set RX l3 csum:Error = %d", ret);
+               return ret;
+       }
+
+       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
+                              DPNI_OFF_RX_L4_CSUM, rx_l4_csum_offload);
+       if (ret) {
+               DPAA2_PMD_ERR("Error to get RX l4 csum:Error = %d", ret);
+               return ret;
+       }
+
+       if (tx_offloads & DEV_TX_OFFLOAD_IPV4_CKSUM)
+               tx_l3_csum_offload = true;
+
+       if ((tx_offloads & DEV_TX_OFFLOAD_UDP_CKSUM) ||
+               (tx_offloads & DEV_TX_OFFLOAD_TCP_CKSUM) ||
+               (tx_offloads & DEV_TX_OFFLOAD_SCTP_CKSUM))
+               tx_l4_csum_offload = true;
+
+       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
+                              DPNI_OFF_TX_L3_CSUM, tx_l3_csum_offload);
+       if (ret) {
+               DPAA2_PMD_ERR("Error to set TX l3 csum:Error = %d", ret);
+               return ret;
+       }
+
+       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
+                              DPNI_OFF_TX_L4_CSUM, tx_l4_csum_offload);
+       if (ret) {
+               DPAA2_PMD_ERR("Error to get TX l4 csum:Error = %d", ret);
+               return ret;
+       }
+
+       /* Enabling hash results in FD requires setting DPNI_FLCTYPE_HASH in
+        * dpni_set_offload API. Setting this FLCTYPE for DPNI sets the FD[SC]
+        * to 0 for LS2 in the hardware thus disabling data/annotation
+        * stashing. For LX2 this is fixed in hardware and thus hash result and
+        * parse results can be received in FD using this option.
+        */
+       if (dpaa2_svr_family == SVR_LX2160A) {
+               ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
+                                      DPNI_FLCTYPE_HASH, true);
+               if (ret) {
+                       DPAA2_PMD_ERR("Error setting FLCTYPE: Err = %d", ret);
                        return ret;
                }
        }
+
+       if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
+               dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
+
+       /* update the current status */
+       dpaa2_dev_link_update(dev, 0);
+
        return 0;
 }
 
@@ -360,7 +515,6 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
-       struct mc_soc_version mc_plat_info = {0};
        struct dpaa2_queue *dpaa2_q;
        struct dpni_queue cfg;
        uint8_t options = 0;
@@ -370,8 +524,8 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
 
        PMD_INIT_FUNC_TRACE();
 
-       PMD_INIT_LOG(DEBUG, "dev =%p, queue =%d, pool = %p, conf =%p",
-                    dev, rx_queue_id, mb_pool, rx_conf);
+       DPAA2_PMD_DEBUG("dev =%p, queue =%d, pool = %p, conf =%p",
+                       dev, rx_queue_id, mb_pool, rx_conf);
 
        if (!priv->bp_list || priv->bp_list->mp != mb_pool) {
                bpid = mempool_to_bpid(mb_pool);
@@ -382,33 +536,36 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
        }
        dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[rx_queue_id];
        dpaa2_q->mb_pool = mb_pool; /**< mbuf pool to populate RX ring. */
+       dpaa2_q->bp_array = rte_dpaa2_bpid_info;
 
        /*Get the flow id from given VQ id*/
        flow_id = rx_queue_id % priv->nb_rx_queues;
        memset(&cfg, 0, sizeof(struct dpni_queue));
 
        options = options | DPNI_QUEUE_OPT_USER_CTX;
-       cfg.user_context = (uint64_t)(dpaa2_q);
+       cfg.user_context = (size_t)(dpaa2_q);
 
        /*if ls2088 or rev2 device, enable the stashing */
 
-       if (mc_get_soc_version(dpni, CMD_PRI_LOW, &mc_plat_info))
-               PMD_INIT_LOG(ERR, "\tmc_get_soc_version failed\n");
-
-       if ((mc_plat_info.svr & 0xffff0000) != SVR_LS2080A) {
+       if ((dpaa2_svr_family & 0xffff0000) != SVR_LS2080A) {
                options |= DPNI_QUEUE_OPT_FLC;
                cfg.flc.stash_control = true;
                cfg.flc.value &= 0xFFFFFFFFFFFFFFC0;
                /* 00 00 00 - last 6 bit represent annotation, context stashing,
-                * data stashing setting 01 01 00 (0x14) to enable
-                * 1 line data, 1 line annotation
+                * data stashing setting 01 01 00 (0x14)
+                * (in following order ->DS AS CS)
+                * to enable 1 line data, 1 line annotation.
+                * For LX2, this setting should be 01 00 00 (0x10)
                 */
-               cfg.flc.value |= 0x14;
+               if ((dpaa2_svr_family & 0xffff0000) == SVR_LX2160A)
+                       cfg.flc.value |= 0x10;
+               else
+                       cfg.flc.value |= 0x14;
        }
        ret = dpni_set_queue(dpni, CMD_PRI_LOW, priv->token, DPNI_QUEUE_RX,
                             dpaa2_q->tc_index, flow_id, options, &cfg);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Error in setting the rx flow: = %d\n", ret);
+               DPAA2_PMD_ERR("Error in setting the rx flow: = %d", ret);
                return -1;
        }
 
@@ -419,14 +576,15 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
                /*enabling per rx queue congestion control */
                taildrop.threshold = CONG_THRESHOLD_RX_Q;
                taildrop.units = DPNI_CONGESTION_UNIT_BYTES;
-               PMD_INIT_LOG(DEBUG, "Enabling Early Drop on queue = %d",
-                            rx_queue_id);
+               taildrop.oal = CONG_RX_OAL;
+               DPAA2_PMD_DEBUG("Enabling Early Drop on queue = %d",
+                               rx_queue_id);
                ret = dpni_set_taildrop(dpni, CMD_PRI_LOW, priv->token,
                                        DPNI_CP_QUEUE, DPNI_QUEUE_RX,
                                        dpaa2_q->tc_index, flow_id, &taildrop);
                if (ret) {
-                       PMD_INIT_LOG(ERR, "Error in setting the rx flow"
-                                    " err : = %d\n", ret);
+                       DPAA2_PMD_ERR("Error in setting taildrop. err=(%d)",
+                                     ret);
                        return -1;
                }
        }
@@ -455,8 +613,10 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
        PMD_INIT_FUNC_TRACE();
 
        /* Return if queue already configured */
-       if (dpaa2_q->flow_id != 0xffff)
+       if (dpaa2_q->flow_id != 0xffff) {
+               dev->data->tx_queues[tx_queue_id] = dpaa2_q;
                return 0;
+       }
 
        memset(&tx_conf_cfg, 0, sizeof(struct dpni_queue));
        memset(&tx_flow_cfg, 0, sizeof(struct dpni_queue));
@@ -467,9 +627,9 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
        ret = dpni_set_queue(dpni, CMD_PRI_LOW, priv->token, DPNI_QUEUE_TX,
                             tc_id, flow_id, options, &tx_flow_cfg);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Error in setting the tx flow: "
-                            "tc_id=%d, flow =%d ErrorCode = %x\n",
-                            tc_id, flow_id, -ret);
+               DPAA2_PMD_ERR("Error in setting the tx flow: "
+                             "tc_id=%d, flow=%d err=%d",
+                             tc_id, flow_id, ret);
                        return -1;
        }
 
@@ -481,8 +641,8 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
                                                    priv->token,
                                                    DPNI_CONF_DISABLE);
                if (ret) {
-                       PMD_INIT_LOG(ERR, "Error in set tx conf mode settings"
-                                    " ErrorCode = %x", ret);
+                       DPAA2_PMD_ERR("Error in set tx conf mode settings: "
+                                     "err=%d", ret);
                        return -1;
                }
        }
@@ -498,12 +658,14 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
                 */
                cong_notif_cfg.threshold_exit = CONG_EXIT_TX_THRESHOLD;
                cong_notif_cfg.message_ctx = 0;
-               cong_notif_cfg.message_iova = (uint64_t)dpaa2_q->cscn;
+               cong_notif_cfg.message_iova =
+                               (size_t)DPAA2_VADDR_TO_IOVA(dpaa2_q->cscn);
                cong_notif_cfg.dest_cfg.dest_type = DPNI_DEST_NONE;
                cong_notif_cfg.notification_mode =
                                         DPNI_CONG_OPT_WRITE_MEM_ON_ENTER |
                                         DPNI_CONG_OPT_WRITE_MEM_ON_EXIT |
                                         DPNI_CONG_OPT_COHERENT_WRITE;
+               cong_notif_cfg.cg_point = DPNI_CP_QUEUE;
 
                ret = dpni_set_congestion_notification(dpni, CMD_PRI_LOW,
                                                       priv->token,
@@ -511,12 +673,13 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
                                                       tc_id,
                                                       &cong_notif_cfg);
                if (ret) {
-                       PMD_INIT_LOG(ERR,
-                          "Error in setting tx congestion notification: = %d",
-                          -ret);
+                       DPAA2_PMD_ERR(
+                          "Error in setting tx congestion notification: "
+                          "err=%d", ret);
                        return -ret;
                }
        }
+       dpaa2_q->cb_eqresp_free = dpaa2_dev_free_eqresp_buf;
        dev->data->tx_queues[tx_queue_id] = dpaa2_q;
        return 0;
 }
@@ -533,6 +696,37 @@ dpaa2_dev_tx_queue_release(void *q __rte_unused)
        PMD_INIT_FUNC_TRACE();
 }
 
+static uint32_t
+dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+       int32_t ret;
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct dpaa2_queue *dpaa2_q;
+       struct qbman_swp *swp;
+       struct qbman_fq_query_np_rslt state;
+       uint32_t frame_cnt = 0;
+
+       PMD_INIT_FUNC_TRACE();
+
+       if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
+               ret = dpaa2_affine_qbman_swp();
+               if (ret) {
+                       DPAA2_PMD_ERR("Failure in affining portal");
+                       return -EINVAL;
+               }
+       }
+       swp = DPAA2_PER_LCORE_PORTAL;
+
+       dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[rx_queue_id];
+
+       if (qbman_fq_query_state(swp, dpaa2_q->fqid, &state) == 0) {
+               frame_cnt = qbman_fq_state_frame_count(&state);
+               DPAA2_PMD_DEBUG("RX frame count for q(%d) is %u",
+                               rx_queue_id, frame_cnt);
+       }
+       return frame_cnt;
+}
+
 static const uint32_t *
 dpaa2_supported_ptypes_get(struct rte_eth_dev *dev)
 {
@@ -550,14 +744,93 @@ dpaa2_supported_ptypes_get(struct rte_eth_dev *dev)
                RTE_PTYPE_UNKNOWN
        };
 
-       if (dev->rx_pkt_burst == dpaa2_dev_prefetch_rx)
+       if (dev->rx_pkt_burst == dpaa2_dev_prefetch_rx ||
+               dev->rx_pkt_burst == dpaa2_dev_loopback_rx)
                return ptypes;
        return NULL;
 }
 
+/**
+ * Dpaa2 link Interrupt handler
+ *
+ * @param param
+ *  The address of parameter (struct rte_eth_dev *) regsitered before.
+ *
+ * @return
+ *  void
+ */
+static void
+dpaa2_interrupt_handler(void *param)
+{
+       struct rte_eth_dev *dev = param;
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       int ret;
+       int irq_index = DPNI_IRQ_INDEX;
+       unsigned int status = 0, clear = 0;
+
+       PMD_INIT_FUNC_TRACE();
+
+       if (dpni == NULL) {
+               DPAA2_PMD_ERR("dpni is NULL");
+               return;
+       }
+
+       ret = dpni_get_irq_status(dpni, CMD_PRI_LOW, priv->token,
+                                 irq_index, &status);
+       if (unlikely(ret)) {
+               DPAA2_PMD_ERR("Can't get irq status (err %d)", ret);
+               clear = 0xffffffff;
+               goto out;
+       }
+
+       if (status & DPNI_IRQ_EVENT_LINK_CHANGED) {
+               clear = DPNI_IRQ_EVENT_LINK_CHANGED;
+               dpaa2_dev_link_update(dev, 0);
+               /* calling all the apps registered for link status event */
+               _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC,
+                                             NULL);
+       }
+out:
+       ret = dpni_clear_irq_status(dpni, CMD_PRI_LOW, priv->token,
+                                   irq_index, clear);
+       if (unlikely(ret))
+               DPAA2_PMD_ERR("Can't clear irq status (err %d)", ret);
+}
+
+static int
+dpaa2_eth_setup_irqs(struct rte_eth_dev *dev, int enable)
+{
+       int err = 0;
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       int irq_index = DPNI_IRQ_INDEX;
+       unsigned int mask = DPNI_IRQ_EVENT_LINK_CHANGED;
+
+       PMD_INIT_FUNC_TRACE();
+
+       err = dpni_set_irq_mask(dpni, CMD_PRI_LOW, priv->token,
+                               irq_index, mask);
+       if (err < 0) {
+               DPAA2_PMD_ERR("Error: dpni_set_irq_mask():%d (%s)", err,
+                             strerror(-err));
+               return err;
+       }
+
+       err = dpni_set_irq_enable(dpni, CMD_PRI_LOW, priv->token,
+                                 irq_index, enable);
+       if (err < 0)
+               DPAA2_PMD_ERR("Error: dpni_set_irq_enable():%d (%s)", err,
+                             strerror(-err));
+
+       return err;
+}
+
 static int
 dpaa2_dev_start(struct rte_eth_dev *dev)
 {
+       struct rte_device *rdev = dev->device;
+       struct rte_dpaa2_device *dpaa2_dev;
        struct rte_eth_dev_data *data = dev->data;
        struct dpaa2_dev_priv *priv = data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
@@ -567,23 +840,27 @@ dpaa2_dev_start(struct rte_eth_dev *dev)
        struct dpni_queue_id qid;
        struct dpaa2_queue *dpaa2_q;
        int ret, i;
+       struct rte_intr_handle *intr_handle;
+
+       dpaa2_dev = container_of(rdev, struct rte_dpaa2_device, device);
+       intr_handle = &dpaa2_dev->intr_handle;
 
        PMD_INIT_FUNC_TRACE();
 
        ret = dpni_enable(dpni, CMD_PRI_LOW, priv->token);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Failure %d in enabling dpni %d device\n",
-                            ret, priv->hw_id);
+               DPAA2_PMD_ERR("Failure in enabling dpni %d device: err=%d",
+                             priv->hw_id, ret);
                return ret;
        }
 
-       /* Power up the phy. Needed to make the link go Up */
+       /* Power up the phy. Needed to make the link go UP */
        dpaa2_dev_set_link_up(dev);
 
        ret = dpni_get_qdid(dpni, CMD_PRI_LOW, priv->token,
                            DPNI_QUEUE_TX, &qdid);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Error to get qdid:ErrorCode = %d\n", ret);
+               DPAA2_PMD_ERR("Error in getting qdid: err=%d", ret);
                return ret;
        }
        priv->qdid = qdid;
@@ -594,43 +871,16 @@ dpaa2_dev_start(struct rte_eth_dev *dev)
                                     DPNI_QUEUE_RX, dpaa2_q->tc_index,
                                       dpaa2_q->flow_id, &cfg, &qid);
                if (ret) {
-                       PMD_INIT_LOG(ERR, "Error to get flow "
-                                    "information Error code = %d\n", ret);
+                       DPAA2_PMD_ERR("Error in getting flow information: "
+                                     "err=%d", ret);
                        return ret;
                }
                dpaa2_q->fqid = qid.fqid;
        }
 
-       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
-                              DPNI_OFF_RX_L3_CSUM, true);
-       if (ret) {
-               PMD_INIT_LOG(ERR, "Error to set RX l3 csum:Error = %d\n", ret);
-               return ret;
-       }
-
-       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
-                              DPNI_OFF_RX_L4_CSUM, true);
-       if (ret) {
-               PMD_INIT_LOG(ERR, "Error to get RX l4 csum:Error = %d\n", ret);
-               return ret;
-       }
-
-       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
-                              DPNI_OFF_TX_L3_CSUM, true);
-       if (ret) {
-               PMD_INIT_LOG(ERR, "Error to set TX l3 csum:Error = %d\n", ret);
-               return ret;
-       }
-
-       ret = dpni_set_offload(dpni, CMD_PRI_LOW, priv->token,
-                              DPNI_OFF_TX_L4_CSUM, true);
-       if (ret) {
-               PMD_INIT_LOG(ERR, "Error to get TX l4 csum:Error = %d\n", ret);
-               return ret;
-       }
-
        /*checksum errors, send them to normal path and set it in annotation */
        err_cfg.errors = DPNI_ERROR_L3CE | DPNI_ERROR_L4CE;
+       err_cfg.errors |= DPNI_ERROR_PHE;
 
        err_cfg.error_action = DPNI_ERROR_ACTION_CONTINUE;
        err_cfg.set_frame_annotation = true;
@@ -638,13 +888,32 @@ dpaa2_dev_start(struct rte_eth_dev *dev)
        ret = dpni_set_errors_behavior(dpni, CMD_PRI_LOW,
                                       priv->token, &err_cfg);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Error to dpni_set_errors_behavior:"
-                            "code = %d\n", ret);
+               DPAA2_PMD_ERR("Error to dpni_set_errors_behavior: code = %d",
+                             ret);
                return ret;
        }
-       /* VLAN Offload Settings */
-       if (priv->max_vlan_filters)
-               dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
+
+       /* if the interrupts were configured on this devices*/
+       if (intr_handle && (intr_handle->fd) &&
+           (dev->data->dev_conf.intr_conf.lsc != 0)) {
+               /* Registering LSC interrupt handler */
+               rte_intr_callback_register(intr_handle,
+                                          dpaa2_interrupt_handler,
+                                          (void *)dev);
+
+               /* enable vfio intr/eventfd mapping
+                * Interrupt index 0 is required, so we can not use
+                * rte_intr_enable.
+                */
+               rte_dpaa2_intr_enable(intr_handle, DPNI_IRQ_INDEX);
+
+               /* enable dpni_irqs */
+               dpaa2_eth_setup_irqs(dev, 1);
+       }
+
+       /* Change the tx burst function if ordered queues are used */
+       if (priv->en_ordered)
+               dev->tx_pkt_burst = dpaa2_dev_tx_ordered;
 
        return 0;
 }
@@ -660,53 +929,60 @@ dpaa2_dev_stop(struct rte_eth_dev *dev)
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
        int ret;
        struct rte_eth_link link;
+       struct rte_intr_handle *intr_handle = dev->intr_handle;
 
        PMD_INIT_FUNC_TRACE();
 
+       /* reset interrupt callback  */
+       if (intr_handle && (intr_handle->fd) &&
+           (dev->data->dev_conf.intr_conf.lsc != 0)) {
+               /*disable dpni irqs */
+               dpaa2_eth_setup_irqs(dev, 0);
+
+               /* disable vfio intr before callback unregister */
+               rte_dpaa2_intr_disable(intr_handle, DPNI_IRQ_INDEX);
+
+               /* Unregistering LSC interrupt handler */
+               rte_intr_callback_unregister(intr_handle,
+                                            dpaa2_interrupt_handler,
+                                            (void *)dev);
+       }
+
        dpaa2_dev_set_link_down(dev);
 
        ret = dpni_disable(dpni, CMD_PRI_LOW, priv->token);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Failure (ret %d) in disabling dpni %d dev\n",
-                            ret, priv->hw_id);
+               DPAA2_PMD_ERR("Failure (ret %d) in disabling dpni %d dev",
+                             ret, priv->hw_id);
                return;
        }
 
        /* clear the recorded link status */
        memset(&link, 0, sizeof(link));
-       dpaa2_dev_atomic_write_link_status(dev, &link);
+       rte_eth_linkstatus_set(dev, &link);
 }
 
 static void
 dpaa2_dev_close(struct rte_eth_dev *dev)
 {
-       struct rte_eth_dev_data *data = dev->data;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
-       int i, ret;
+       int ret;
        struct rte_eth_link link;
-       struct dpaa2_queue *dpaa2_q;
 
        PMD_INIT_FUNC_TRACE();
 
-       for (i = 0; i < data->nb_tx_queues; i++) {
-               dpaa2_q = (struct dpaa2_queue *)data->tx_queues[i];
-               if (!dpaa2_q->cscn) {
-                       rte_free(dpaa2_q->cscn);
-                       dpaa2_q->cscn = NULL;
-               }
-       }
+       dpaa2_flow_clean(dev);
 
        /* Clean the device first */
        ret = dpni_reset(dpni, CMD_PRI_LOW, priv->token);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Failure cleaning dpni device with"
-                            " error code %d\n", ret);
+               DPAA2_PMD_ERR("Failure cleaning dpni device: err=%d", ret);
                return;
        }
 
        memset(&link, 0, sizeof(link));
-       dpaa2_dev_atomic_write_link_status(dev, &link);
+       rte_eth_linkstatus_set(dev, &link);
 }
 
 static void
@@ -720,17 +996,17 @@ dpaa2_dev_promiscuous_enable(
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return;
        }
 
        ret = dpni_set_unicast_promisc(dpni, CMD_PRI_LOW, priv->token, true);
        if (ret < 0)
-               RTE_LOG(ERR, PMD, "Unable to enable U promisc mode %d\n", ret);
+               DPAA2_PMD_ERR("Unable to enable U promisc mode %d", ret);
 
        ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, true);
        if (ret < 0)
-               RTE_LOG(ERR, PMD, "Unable to enable M promisc mode %d\n", ret);
+               DPAA2_PMD_ERR("Unable to enable M promisc mode %d", ret);
 }
 
 static void
@@ -744,21 +1020,20 @@ dpaa2_dev_promiscuous_disable(
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return;
        }
 
        ret = dpni_set_unicast_promisc(dpni, CMD_PRI_LOW, priv->token, false);
        if (ret < 0)
-               RTE_LOG(ERR, PMD, "Unable to disable U promisc mode %d\n", ret);
+               DPAA2_PMD_ERR("Unable to disable U promisc mode %d", ret);
 
        if (dev->data->all_multicast == 0) {
                ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW,
                                                 priv->token, false);
                if (ret < 0)
-                       RTE_LOG(ERR, PMD,
-                               "Unable to disable M promisc mode %d\n",
-                               ret);
+                       DPAA2_PMD_ERR("Unable to disable M promisc mode %d",
+                                     ret);
        }
 }
 
@@ -773,13 +1048,13 @@ dpaa2_dev_allmulticast_enable(
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return;
        }
 
        ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, true);
        if (ret < 0)
-               RTE_LOG(ERR, PMD, "Unable to enable multicast mode %d\n", ret);
+               DPAA2_PMD_ERR("Unable to enable multicast mode %d", ret);
 }
 
 static void
@@ -792,7 +1067,7 @@ dpaa2_dev_allmulticast_disable(struct rte_eth_dev *dev)
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return;
        }
 
@@ -802,7 +1077,7 @@ dpaa2_dev_allmulticast_disable(struct rte_eth_dev *dev)
 
        ret = dpni_set_multicast_promisc(dpni, CMD_PRI_LOW, priv->token, false);
        if (ret < 0)
-               RTE_LOG(ERR, PMD, "Unable to disable multicast mode %d\n", ret);
+               DPAA2_PMD_ERR("Unable to disable multicast mode %d", ret);
 }
 
 static int
@@ -811,12 +1086,13 @@ dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
-       uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;
+       uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN
+                               + VLAN_TAG_SIZE;
 
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return -EINVAL;
        }
 
@@ -825,26 +1101,30 @@ dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                return -EINVAL;
 
        if (frame_size > ETHER_MAX_LEN)
-               dev->data->dev_conf.rxmode.jumbo_frame = 1;
+               dev->data->dev_conf.rxmode.offloads &=
+                                               DEV_RX_OFFLOAD_JUMBO_FRAME;
        else
-               dev->data->dev_conf.rxmode.jumbo_frame = 0;
+               dev->data->dev_conf.rxmode.offloads &=
+                                               ~DEV_RX_OFFLOAD_JUMBO_FRAME;
+
+       dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
 
        /* Set the Max Rx frame length as 'mtu' +
         * Maximum Ethernet header length
         */
        ret = dpni_set_max_frame_length(dpni, CMD_PRI_LOW, priv->token,
-                                       mtu + ETH_VLAN_HLEN);
+                                       frame_size);
        if (ret) {
-               PMD_DRV_LOG(ERR, "setting the max frame length failed");
+               DPAA2_PMD_ERR("Setting the max frame length failed");
                return -1;
        }
-       PMD_DRV_LOG(INFO, "MTU is configured %d for the device\n", mtu);
+       DPAA2_PMD_INFO("MTU configured for the device: %d", mtu);
        return 0;
 }
 
 static int
 dpaa2_dev_add_mac_addr(struct rte_eth_dev *dev,
-                      struct ether_addr *addr,
+                      struct rte_ether_addr *addr,
                       __rte_unused uint32_t index,
                       __rte_unused uint32_t pool)
 {
@@ -855,15 +1135,15 @@ dpaa2_dev_add_mac_addr(struct rte_eth_dev *dev,
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return -1;
        }
 
        ret = dpni_add_mac_addr(dpni, CMD_PRI_LOW,
                                priv->token, addr->addr_bytes);
        if (ret)
-               RTE_LOG(ERR, PMD,
-                       "error: Adding the MAC ADDR failed: err = %d\n", ret);
+               DPAA2_PMD_ERR(
+                       "error: Adding the MAC ADDR failed: err = %d", ret);
        return 0;
 }
 
@@ -875,27 +1155,27 @@ dpaa2_dev_remove_mac_addr(struct rte_eth_dev *dev,
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
        struct rte_eth_dev_data *data = dev->data;
-       struct ether_addr *macaddr;
+       struct rte_ether_addr *macaddr;
 
        PMD_INIT_FUNC_TRACE();
 
        macaddr = &data->mac_addrs[index];
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return;
        }
 
        ret = dpni_remove_mac_addr(dpni, CMD_PRI_LOW,
                                   priv->token, macaddr->addr_bytes);
        if (ret)
-               RTE_LOG(ERR, PMD,
-                       "error: Removing the MAC ADDR failed: err = %d\n", ret);
+               DPAA2_PMD_ERR(
+                       "error: Removing the MAC ADDR failed: err = %d", ret);
 }
 
-static void
+static int
 dpaa2_dev_set_mac_addr(struct rte_eth_dev *dev,
-                      struct ether_addr *addr)
+                      struct rte_ether_addr *addr)
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
@@ -904,19 +1184,22 @@ dpaa2_dev_set_mac_addr(struct rte_eth_dev *dev,
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
-               return;
+               DPAA2_PMD_ERR("dpni is NULL");
+               return -EINVAL;
        }
 
        ret = dpni_set_primary_mac_addr(dpni, CMD_PRI_LOW,
                                        priv->token, addr->addr_bytes);
 
        if (ret)
-               RTE_LOG(ERR, PMD,
-                       "error: Setting the MAC ADDR failed %d\n", ret);
+               DPAA2_PMD_ERR(
+                       "error: Setting the MAC ADDR failed %d", ret);
+
+       return ret;
 }
+
 static
-void dpaa2_dev_stats_get(struct rte_eth_dev *dev,
+int dpaa2_dev_stats_get(struct rte_eth_dev *dev,
                         struct rte_eth_stats *stats)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
@@ -924,24 +1207,26 @@ void dpaa2_dev_stats_get(struct rte_eth_dev *dev,
        int32_t  retcode;
        uint8_t page0 = 0, page1 = 1, page2 = 2;
        union dpni_statistics value;
+       int i;
+       struct dpaa2_queue *dpaa2_rxq, *dpaa2_txq;
 
        memset(&value, 0, sizeof(union dpni_statistics));
 
        PMD_INIT_FUNC_TRACE();
 
        if (!dpni) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
-               return;
+               DPAA2_PMD_ERR("dpni is NULL");
+               return -EINVAL;
        }
 
        if (!stats) {
-               RTE_LOG(ERR, PMD, "stats is NULL\n");
-               return;
+               DPAA2_PMD_ERR("stats is NULL");
+               return -EINVAL;
        }
 
        /*Get Counters from page_0*/
        retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
-                                     page0, &value);
+                                     page0, 0, &value);
        if (retcode)
                goto err;
 
@@ -950,7 +1235,7 @@ void dpaa2_dev_stats_get(struct rte_eth_dev *dev,
 
        /*Get Counters from page_1*/
        retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
-                                     page1, &value);
+                                     page1, 0, &value);
        if (retcode)
                goto err;
 
@@ -959,7 +1244,7 @@ void dpaa2_dev_stats_get(struct rte_eth_dev *dev,
 
        /*Get Counters from page_2*/
        retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
-                                     page2, &value);
+                                     page2, 0, &value);
        if (retcode)
                goto err;
 
@@ -971,24 +1256,186 @@ void dpaa2_dev_stats_get(struct rte_eth_dev *dev,
        stats->oerrors = value.page_2.egress_discarded_frames;
        stats->imissed = value.page_2.ingress_nobuffer_discards;
 
-       return;
+       /* Fill in per queue stats */
+       for (i = 0; (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) &&
+               (i < priv->nb_rx_queues || i < priv->nb_tx_queues); ++i) {
+               dpaa2_rxq = (struct dpaa2_queue *)priv->rx_vq[i];
+               dpaa2_txq = (struct dpaa2_queue *)priv->tx_vq[i];
+               if (dpaa2_rxq)
+                       stats->q_ipackets[i] = dpaa2_rxq->rx_pkts;
+               if (dpaa2_txq)
+                       stats->q_opackets[i] = dpaa2_txq->tx_pkts;
+
+               /* Byte counting is not implemented */
+               stats->q_ibytes[i]   = 0;
+               stats->q_obytes[i]   = 0;
+       }
+
+       return 0;
 
 err:
-       RTE_LOG(ERR, PMD, "Operation not completed:Error Code = %d\n", retcode);
-       return;
+       DPAA2_PMD_ERR("Operation not completed:Error Code = %d", retcode);
+       return retcode;
 };
 
-static
-void dpaa2_dev_stats_reset(struct rte_eth_dev *dev)
+static int
+dpaa2_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
+                    unsigned int n)
+{
+       struct dpaa2_dev_priv *priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       int32_t  retcode;
+       union dpni_statistics value[3] = {};
+       unsigned int i = 0, num = RTE_DIM(dpaa2_xstats_strings);
+
+       if (n < num)
+               return num;
+
+       if (xstats == NULL)
+               return 0;
+
+       /* Get Counters from page_0*/
+       retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
+                                     0, 0, &value[0]);
+       if (retcode)
+               goto err;
+
+       /* Get Counters from page_1*/
+       retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
+                                     1, 0, &value[1]);
+       if (retcode)
+               goto err;
+
+       /* Get Counters from page_2*/
+       retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
+                                     2, 0, &value[2]);
+       if (retcode)
+               goto err;
+
+       for (i = 0; i < num; i++) {
+               xstats[i].id = i;
+               xstats[i].value = value[dpaa2_xstats_strings[i].page_id].
+                       raw.counter[dpaa2_xstats_strings[i].stats_id];
+       }
+       return i;
+err:
+       DPAA2_PMD_ERR("Error in obtaining extended stats (%d)", retcode);
+       return retcode;
+}
+
+static int
+dpaa2_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
+                      struct rte_eth_xstat_name *xstats_names,
+                      unsigned int limit)
+{
+       unsigned int i, stat_cnt = RTE_DIM(dpaa2_xstats_strings);
+
+       if (limit < stat_cnt)
+               return stat_cnt;
+
+       if (xstats_names != NULL)
+               for (i = 0; i < stat_cnt; i++)
+                       strlcpy(xstats_names[i].name,
+                               dpaa2_xstats_strings[i].name,
+                               sizeof(xstats_names[i].name));
+
+       return stat_cnt;
+}
+
+static int
+dpaa2_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
+                      uint64_t *values, unsigned int n)
+{
+       unsigned int i, stat_cnt = RTE_DIM(dpaa2_xstats_strings);
+       uint64_t values_copy[stat_cnt];
+
+       if (!ids) {
+               struct dpaa2_dev_priv *priv = dev->data->dev_private;
+               struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+               int32_t  retcode;
+               union dpni_statistics value[3] = {};
+
+               if (n < stat_cnt)
+                       return stat_cnt;
+
+               if (!values)
+                       return 0;
+
+               /* Get Counters from page_0*/
+               retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
+                                             0, 0, &value[0]);
+               if (retcode)
+                       return 0;
+
+               /* Get Counters from page_1*/
+               retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
+                                             1, 0, &value[1]);
+               if (retcode)
+                       return 0;
+
+               /* Get Counters from page_2*/
+               retcode = dpni_get_statistics(dpni, CMD_PRI_LOW, priv->token,
+                                             2, 0, &value[2]);
+               if (retcode)
+                       return 0;
+
+               for (i = 0; i < stat_cnt; i++) {
+                       values[i] = value[dpaa2_xstats_strings[i].page_id].
+                               raw.counter[dpaa2_xstats_strings[i].stats_id];
+               }
+               return stat_cnt;
+       }
+
+       dpaa2_xstats_get_by_id(dev, NULL, values_copy, stat_cnt);
+
+       for (i = 0; i < n; i++) {
+               if (ids[i] >= stat_cnt) {
+                       DPAA2_PMD_ERR("xstats id value isn't valid");
+                       return -1;
+               }
+               values[i] = values_copy[ids[i]];
+       }
+       return n;
+}
+
+static int
+dpaa2_xstats_get_names_by_id(
+       struct rte_eth_dev *dev,
+       struct rte_eth_xstat_name *xstats_names,
+       const uint64_t *ids,
+       unsigned int limit)
+{
+       unsigned int i, stat_cnt = RTE_DIM(dpaa2_xstats_strings);
+       struct rte_eth_xstat_name xstats_names_copy[stat_cnt];
+
+       if (!ids)
+               return dpaa2_xstats_get_names(dev, xstats_names, limit);
+
+       dpaa2_xstats_get_names(dev, xstats_names_copy, limit);
+
+       for (i = 0; i < limit; i++) {
+               if (ids[i] >= stat_cnt) {
+                       DPAA2_PMD_ERR("xstats id value isn't valid");
+                       return -1;
+               }
+               strcpy(xstats_names[i].name, xstats_names_copy[ids[i]].name);
+       }
+       return limit;
+}
+
+static void
+dpaa2_dev_stats_reset(struct rte_eth_dev *dev)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
        int32_t  retcode;
+       int i;
+       struct dpaa2_queue *dpaa2_q;
 
        PMD_INIT_FUNC_TRACE();
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return;
        }
 
@@ -996,10 +1443,23 @@ void dpaa2_dev_stats_reset(struct rte_eth_dev *dev)
        if (retcode)
                goto error;
 
+       /* Reset the per queue stats in dpaa2_queue structure */
+       for (i = 0; i < priv->nb_rx_queues; i++) {
+               dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i];
+               if (dpaa2_q)
+                       dpaa2_q->rx_pkts = 0;
+       }
+
+       for (i = 0; i < priv->nb_tx_queues; i++) {
+               dpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];
+               if (dpaa2_q)
+                       dpaa2_q->tx_pkts = 0;
+       }
+
        return;
 
 error:
-       RTE_LOG(ERR, PMD, "Operation not completed:Error Code = %d\n", retcode);
+       DPAA2_PMD_ERR("Operation not completed:Error Code = %d", retcode);
        return;
 };
 
@@ -1011,26 +1471,17 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev,
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
-       struct rte_eth_link link, old;
+       struct rte_eth_link link;
        struct dpni_link_state state = {0};
 
-       PMD_INIT_FUNC_TRACE();
-
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return 0;
        }
-       memset(&old, 0, sizeof(old));
-       dpaa2_dev_atomic_read_link_status(dev, &old);
 
        ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state);
        if (ret < 0) {
-               RTE_LOG(ERR, PMD, "error: dpni_get_link_state %d\n", ret);
-               return -1;
-       }
-
-       if ((old.link_status == state.up) && (old.link_speed == state.rate)) {
-               RTE_LOG(DEBUG, PMD, "No change in status\n");
+               DPAA2_PMD_DEBUG("error: dpni_get_link_state %d", ret);
                return -1;
        }
 
@@ -1043,13 +1494,14 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev,
        else
                link.link_duplex = ETH_LINK_FULL_DUPLEX;
 
-       dpaa2_dev_atomic_write_link_status(dev, &link);
-
-       if (link.link_status)
-               PMD_DRV_LOG(INFO, "Port %d Link is Up\n", dev->data->port_id);
+       ret = rte_eth_linkstatus_set(dev, &link);
+       if (ret == -1)
+               DPAA2_PMD_DEBUG("No change in status");
        else
-               PMD_DRV_LOG(INFO, "Port %d Link is Down\n", dev->data->port_id);
-       return 0;
+               DPAA2_PMD_INFO("Port %d Link is %s\n", dev->data->port_id,
+                              link.link_status ? "Up" : "Down");
+
+       return ret;
 }
 
 /**
@@ -1063,14 +1515,13 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
        struct dpaa2_dev_priv *priv;
        struct fsl_mc_io *dpni;
        int en = 0;
-
-       PMD_INIT_FUNC_TRACE();
+       struct dpni_link_state state = {0};
 
        priv = dev->data->dev_private;
        dpni = (struct fsl_mc_io *)priv->hw;
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "DPNI is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return ret;
        }
 
@@ -1078,7 +1529,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
        ret = dpni_is_enabled(dpni, CMD_PRI_LOW, priv->token, &en);
        if (ret) {
                /* Unable to obtain dpni status; Not continuing */
-               PMD_DRV_LOG(ERR, "Interface Link UP failed (%d)", ret);
+               DPAA2_PMD_ERR("Interface Link UP failed (%d)", ret);
                return -EINVAL;
        }
 
@@ -1086,15 +1537,24 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
        if (!en) {
                ret = dpni_enable(dpni, CMD_PRI_LOW, priv->token);
                if (ret) {
-                       PMD_DRV_LOG(ERR, "Interface Link UP failed (%d)", ret);
+                       DPAA2_PMD_ERR("Interface Link UP failed (%d)", ret);
                        return -EINVAL;
                }
        }
+       ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state);
+       if (ret < 0) {
+               DPAA2_PMD_DEBUG("Unable to get link state (%d)", ret);
+               return -1;
+       }
+
        /* changing tx burst function to start enqueues */
        dev->tx_pkt_burst = dpaa2_dev_tx;
-       dev->data->dev_link.link_status = 1;
+       dev->data->dev_link.link_status = state.up;
 
-       PMD_DRV_LOG(INFO, "Port %d Link UP successful", dev->data->port_id);
+       if (state.up)
+               DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);
+       else
+               DPAA2_PMD_INFO("Port %d Link is Down", dev->data->port_id);
        return ret;
 }
 
@@ -1117,7 +1577,7 @@ dpaa2_dev_set_link_down(struct rte_eth_dev *dev)
        dpni = (struct fsl_mc_io *)priv->hw;
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "Device has not yet been configured\n");
+               DPAA2_PMD_ERR("Device has not yet been configured");
                return ret;
        }
 
@@ -1130,12 +1590,12 @@ dpaa2_dev_set_link_down(struct rte_eth_dev *dev)
        do {
                ret = dpni_disable(dpni, 0, priv->token);
                if (ret) {
-                       PMD_DRV_LOG(ERR, "dpni disable failed (%d)", ret);
+                       DPAA2_PMD_ERR("dpni disable failed (%d)", ret);
                        return ret;
                }
                ret = dpni_is_enabled(dpni, 0, priv->token, &dpni_enabled);
                if (ret) {
-                       PMD_DRV_LOG(ERR, "dpni_is_enabled failed (%d)", ret);
+                       DPAA2_PMD_ERR("dpni enable check failed (%d)", ret);
                        return ret;
                }
                if (dpni_enabled)
@@ -1144,12 +1604,12 @@ dpaa2_dev_set_link_down(struct rte_eth_dev *dev)
        } while (dpni_enabled && --retries);
 
        if (!retries) {
-               PMD_DRV_LOG(WARNING, "Retry count exceeded disabling DPNI\n");
+               DPAA2_PMD_WARN("Retry count exceeded disabling dpni");
                /* todo- we may have to manually cleanup queues.
                 */
        } else {
-               PMD_DRV_LOG(INFO, "Port %d Link DOWN successful",
-                           dev->data->port_id);
+               DPAA2_PMD_INFO("Port %d Link DOWN successful",
+                              dev->data->port_id);
        }
 
        dev->data->dev_link.link_status = 0;
@@ -1171,13 +1631,13 @@ dpaa2_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        dpni = (struct fsl_mc_io *)priv->hw;
 
        if (dpni == NULL || fc_conf == NULL) {
-               RTE_LOG(ERR, PMD, "device not configured\n");
+               DPAA2_PMD_ERR("device not configured");
                return ret;
        }
 
        ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state);
        if (ret) {
-               RTE_LOG(ERR, PMD, "error: dpni_get_link_state %d\n", ret);
+               DPAA2_PMD_ERR("error: dpni_get_link_state %d", ret);
                return ret;
        }
 
@@ -1227,7 +1687,7 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        dpni = (struct fsl_mc_io *)priv->hw;
 
        if (dpni == NULL) {
-               RTE_LOG(ERR, PMD, "dpni is NULL\n");
+               DPAA2_PMD_ERR("dpni is NULL");
                return ret;
        }
 
@@ -1237,7 +1697,7 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
         */
        ret = dpni_get_link_state(dpni, CMD_PRI_LOW, priv->token, &state);
        if (ret) {
-               RTE_LOG(ERR, PMD, "Unable to get link state (err=%d)\n", ret);
+               DPAA2_PMD_ERR("Unable to get link state (err=%d)", ret);
                return -1;
        }
 
@@ -1282,16 +1742,15 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
                cfg.options &= ~DPNI_LINK_OPT_ASYM_PAUSE;
                break;
        default:
-               RTE_LOG(ERR, PMD, "Incorrect Flow control flag (%d)\n",
-                       fc_conf->mode);
+               DPAA2_PMD_ERR("Incorrect Flow control flag (%d)",
+                             fc_conf->mode);
                return -1;
        }
 
        ret = dpni_set_link_cfg(dpni, CMD_PRI_LOW, priv->token, &cfg);
        if (ret)
-               RTE_LOG(ERR, PMD,
-                       "Unable to set Link configuration (err=%d)\n",
-                       ret);
+               DPAA2_PMD_ERR("Unable to set Link configuration (err=%d)",
+                             ret);
 
        /* Enable link */
        dpaa2_dev_set_link_up(dev);
@@ -1299,6 +1758,193 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        return ret;
 }
 
+static int
+dpaa2_dev_rss_hash_update(struct rte_eth_dev *dev,
+                         struct rte_eth_rss_conf *rss_conf)
+{
+       struct rte_eth_dev_data *data = dev->data;
+       struct rte_eth_conf *eth_conf = &data->dev_conf;
+       int ret;
+
+       PMD_INIT_FUNC_TRACE();
+
+       if (rss_conf->rss_hf) {
+               ret = dpaa2_setup_flow_dist(dev, rss_conf->rss_hf);
+               if (ret) {
+                       DPAA2_PMD_ERR("Unable to set flow dist");
+                       return ret;
+               }
+       } else {
+               ret = dpaa2_remove_flow_dist(dev, 0);
+               if (ret) {
+                       DPAA2_PMD_ERR("Unable to remove flow dist");
+                       return ret;
+               }
+       }
+       eth_conf->rx_adv_conf.rss_conf.rss_hf = rss_conf->rss_hf;
+       return 0;
+}
+
+static int
+dpaa2_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
+                           struct rte_eth_rss_conf *rss_conf)
+{
+       struct rte_eth_dev_data *data = dev->data;
+       struct rte_eth_conf *eth_conf = &data->dev_conf;
+
+       /* dpaa2 does not support rss_key, so length should be 0*/
+       rss_conf->rss_key_len = 0;
+       rss_conf->rss_hf = eth_conf->rx_adv_conf.rss_conf.rss_hf;
+       return 0;
+}
+
+int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev,
+               int eth_rx_queue_id,
+               uint16_t dpcon_id,
+               const struct rte_event_eth_rx_adapter_queue_conf *queue_conf)
+{
+       struct dpaa2_dev_priv *eth_priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)eth_priv->hw;
+       struct dpaa2_queue *dpaa2_ethq = eth_priv->rx_vq[eth_rx_queue_id];
+       uint8_t flow_id = dpaa2_ethq->flow_id;
+       struct dpni_queue cfg;
+       uint8_t options;
+       int ret;
+
+       if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_PARALLEL)
+               dpaa2_ethq->cb = dpaa2_dev_process_parallel_event;
+       else if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_ATOMIC)
+               dpaa2_ethq->cb = dpaa2_dev_process_atomic_event;
+       else if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_ORDERED)
+               dpaa2_ethq->cb = dpaa2_dev_process_ordered_event;
+       else
+               return -EINVAL;
+
+       memset(&cfg, 0, sizeof(struct dpni_queue));
+       options = DPNI_QUEUE_OPT_DEST;
+       cfg.destination.type = DPNI_DEST_DPCON;
+       cfg.destination.id = dpcon_id;
+       cfg.destination.priority = queue_conf->ev.priority;
+
+       if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_ATOMIC) {
+               options |= DPNI_QUEUE_OPT_HOLD_ACTIVE;
+               cfg.destination.hold_active = 1;
+       }
+
+       if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_ORDERED &&
+                       !eth_priv->en_ordered) {
+               struct opr_cfg ocfg;
+
+               /* Restoration window size = 256 frames */
+               ocfg.oprrws = 3;
+               /* Restoration window size = 512 frames for LX2 */
+               if (dpaa2_svr_family == SVR_LX2160A)
+                       ocfg.oprrws = 4;
+               /* Auto advance NESN window enabled */
+               ocfg.oa = 1;
+               /* Late arrival window size disabled */
+               ocfg.olws = 0;
+               /* ORL resource exhaustaion advance NESN disabled */
+               ocfg.oeane = 0;
+               /* Loose ordering enabled */
+               ocfg.oloe = 1;
+               eth_priv->en_loose_ordered = 1;
+               /* Strict ordering enabled if explicitly set */
+               if (getenv("DPAA2_STRICT_ORDERING_ENABLE")) {
+                       ocfg.oloe = 0;
+                       eth_priv->en_loose_ordered = 0;
+               }
+
+               ret = dpni_set_opr(dpni, CMD_PRI_LOW, eth_priv->token,
+                                  dpaa2_ethq->tc_index, flow_id,
+                                  OPR_OPT_CREATE, &ocfg);
+               if (ret) {
+                       DPAA2_PMD_ERR("Error setting opr: ret: %d\n", ret);
+                       return ret;
+               }
+
+               eth_priv->en_ordered = 1;
+       }
+
+       options |= DPNI_QUEUE_OPT_USER_CTX;
+       cfg.user_context = (size_t)(dpaa2_ethq);
+
+       ret = dpni_set_queue(dpni, CMD_PRI_LOW, eth_priv->token, DPNI_QUEUE_RX,
+                            dpaa2_ethq->tc_index, flow_id, options, &cfg);
+       if (ret) {
+               DPAA2_PMD_ERR("Error in dpni_set_queue: ret: %d", ret);
+               return ret;
+       }
+
+       memcpy(&dpaa2_ethq->ev, &queue_conf->ev, sizeof(struct rte_event));
+
+       return 0;
+}
+
+int dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev,
+               int eth_rx_queue_id)
+{
+       struct dpaa2_dev_priv *eth_priv = dev->data->dev_private;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)eth_priv->hw;
+       struct dpaa2_queue *dpaa2_ethq = eth_priv->rx_vq[eth_rx_queue_id];
+       uint8_t flow_id = dpaa2_ethq->flow_id;
+       struct dpni_queue cfg;
+       uint8_t options;
+       int ret;
+
+       memset(&cfg, 0, sizeof(struct dpni_queue));
+       options = DPNI_QUEUE_OPT_DEST;
+       cfg.destination.type = DPNI_DEST_NONE;
+
+       ret = dpni_set_queue(dpni, CMD_PRI_LOW, eth_priv->token, DPNI_QUEUE_RX,
+                            dpaa2_ethq->tc_index, flow_id, options, &cfg);
+       if (ret)
+               DPAA2_PMD_ERR("Error in dpni_set_queue: ret: %d", ret);
+
+       return ret;
+}
+
+static inline int
+dpaa2_dev_verify_filter_ops(enum rte_filter_op filter_op)
+{
+       unsigned int i;
+
+       for (i = 0; i < RTE_DIM(dpaa2_supported_filter_ops); i++) {
+               if (dpaa2_supported_filter_ops[i] == filter_op)
+                       return 0;
+       }
+       return -ENOTSUP;
+}
+
+static int
+dpaa2_dev_flow_ctrl(struct rte_eth_dev *dev,
+                   enum rte_filter_type filter_type,
+                                enum rte_filter_op filter_op,
+                                void *arg)
+{
+       int ret = 0;
+
+       if (!dev)
+               return -ENODEV;
+
+       switch (filter_type) {
+       case RTE_ETH_FILTER_GENERIC:
+               if (dpaa2_dev_verify_filter_ops(filter_op) < 0) {
+                       ret = -ENOTSUP;
+                       break;
+               }
+               *(const void **)arg = &dpaa2_flow_ops;
+               dpaa2_filter_type |= filter_type;
+               break;
+       default:
+               RTE_LOG(ERR, PMD, "Filter type (%d) not supported",
+                       filter_type);
+               ret = -ENOTSUP;
+               break;
+       }
+       return ret;
+}
+
 static struct eth_dev_ops dpaa2_ethdev_ops = {
        .dev_configure    = dpaa2_eth_dev_configure,
        .dev_start            = dpaa2_dev_start,
@@ -1312,24 +1958,140 @@ static struct eth_dev_ops dpaa2_ethdev_ops = {
        .dev_set_link_down    = dpaa2_dev_set_link_down,
        .link_update       = dpaa2_dev_link_update,
        .stats_get             = dpaa2_dev_stats_get,
+       .xstats_get            = dpaa2_dev_xstats_get,
+       .xstats_get_by_id     = dpaa2_xstats_get_by_id,
+       .xstats_get_names_by_id = dpaa2_xstats_get_names_by_id,
+       .xstats_get_names      = dpaa2_xstats_get_names,
        .stats_reset       = dpaa2_dev_stats_reset,
+       .xstats_reset         = dpaa2_dev_stats_reset,
        .fw_version_get    = dpaa2_fw_version_get,
        .dev_infos_get     = dpaa2_dev_info_get,
        .dev_supported_ptypes_get = dpaa2_supported_ptypes_get,
        .mtu_set           = dpaa2_dev_mtu_set,
        .vlan_filter_set      = dpaa2_vlan_filter_set,
        .vlan_offload_set     = dpaa2_vlan_offload_set,
+       .vlan_tpid_set        = dpaa2_vlan_tpid_set,
        .rx_queue_setup    = dpaa2_dev_rx_queue_setup,
        .rx_queue_release  = dpaa2_dev_rx_queue_release,
        .tx_queue_setup    = dpaa2_dev_tx_queue_setup,
        .tx_queue_release  = dpaa2_dev_tx_queue_release,
+       .rx_queue_count       = dpaa2_dev_rx_queue_count,
        .flow_ctrl_get        = dpaa2_flow_ctrl_get,
        .flow_ctrl_set        = dpaa2_flow_ctrl_set,
        .mac_addr_add         = dpaa2_dev_add_mac_addr,
        .mac_addr_remove      = dpaa2_dev_remove_mac_addr,
        .mac_addr_set         = dpaa2_dev_set_mac_addr,
+       .rss_hash_update      = dpaa2_dev_rss_hash_update,
+       .rss_hash_conf_get    = dpaa2_dev_rss_hash_conf_get,
+       .filter_ctrl          = dpaa2_dev_flow_ctrl,
 };
 
+/* Populate the mac address from physically available (u-boot/firmware) and/or
+ * one set by higher layers like MC (restool) etc.
+ * Returns the table of MAC entries (multiple entries)
+ */
+static int
+populate_mac_addr(struct fsl_mc_io *dpni_dev, struct dpaa2_dev_priv *priv,
+                 struct rte_ether_addr *mac_entry)
+{
+       int ret;
+       struct rte_ether_addr phy_mac, prime_mac;
+
+       memset(&phy_mac, 0, sizeof(struct rte_ether_addr));
+       memset(&prime_mac, 0, sizeof(struct rte_ether_addr));
+
+       /* Get the physical device MAC address */
+       ret = dpni_get_port_mac_addr(dpni_dev, CMD_PRI_LOW, priv->token,
+                                    phy_mac.addr_bytes);
+       if (ret) {
+               DPAA2_PMD_ERR("DPNI get physical port MAC failed: %d", ret);
+               goto cleanup;
+       }
+
+       ret = dpni_get_primary_mac_addr(dpni_dev, CMD_PRI_LOW, priv->token,
+                                       prime_mac.addr_bytes);
+       if (ret) {
+               DPAA2_PMD_ERR("DPNI get Prime port MAC failed: %d", ret);
+               goto cleanup;
+       }
+
+       /* Now that both MAC have been obtained, do:
+        *  if not_empty_mac(phy) && phy != Prime, overwrite prime with Phy
+        *     and return phy
+        *  If empty_mac(phy), return prime.
+        *  if both are empty, create random MAC, set as prime and return
+        */
+       if (!is_zero_ether_addr(&phy_mac)) {
+               /* If the addresses are not same, overwrite prime */
+               if (!is_same_ether_addr(&phy_mac, &prime_mac)) {
+                       ret = dpni_set_primary_mac_addr(dpni_dev, CMD_PRI_LOW,
+                                                       priv->token,
+                                                       phy_mac.addr_bytes);
+                       if (ret) {
+                               DPAA2_PMD_ERR("Unable to set MAC Address: %d",
+                                             ret);
+                               goto cleanup;
+                       }
+                       memcpy(&prime_mac, &phy_mac,
+                               sizeof(struct rte_ether_addr));
+               }
+       } else if (is_zero_ether_addr(&prime_mac)) {
+               /* In case phys and prime, both are zero, create random MAC */
+               eth_random_addr(prime_mac.addr_bytes);
+               ret = dpni_set_primary_mac_addr(dpni_dev, CMD_PRI_LOW,
+                                               priv->token,
+                                               prime_mac.addr_bytes);
+               if (ret) {
+                       DPAA2_PMD_ERR("Unable to set MAC Address: %d", ret);
+                       goto cleanup;
+               }
+       }
+
+       /* prime_mac the final MAC address */
+       memcpy(mac_entry, &prime_mac, sizeof(struct rte_ether_addr));
+       return 0;
+
+cleanup:
+       return -1;
+}
+
+static int
+check_devargs_handler(__rte_unused const char *key, const char *value,
+                     __rte_unused void *opaque)
+{
+       if (strcmp(value, "1"))
+               return -1;
+
+       return 0;
+}
+
+static int
+dpaa2_get_devargs(struct rte_devargs *devargs, const char *key)
+{
+       struct rte_kvargs *kvlist;
+
+       if (!devargs)
+               return 0;
+
+       kvlist = rte_kvargs_parse(devargs->args, NULL);
+       if (!kvlist)
+               return 0;
+
+       if (!rte_kvargs_count(kvlist, key)) {
+               rte_kvargs_free(kvlist);
+               return 0;
+       }
+
+       if (rte_kvargs_process(kvlist, key,
+                              check_devargs_handler, NULL) < 0) {
+               rte_kvargs_free(kvlist);
+               return 0;
+       }
+       rte_kvargs_free(kvlist);
+
+       return 1;
+}
+
 static int
 dpaa2_dev_init(struct rte_eth_dev *eth_dev)
 {
@@ -1339,13 +2101,23 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
        struct dpni_attr attr;
        struct dpaa2_dev_priv *priv = eth_dev->data->dev_private;
        struct dpni_buffer_layout layout;
-       int ret, hw_id;
+       int ret, hw_id, i;
 
        PMD_INIT_FUNC_TRACE();
 
        /* For secondary processes, the primary has done all the work */
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               /* In case of secondary, only burst and ops API need to be
+                * plugged.
+                */
+               eth_dev->dev_ops = &dpaa2_ethdev_ops;
+               if (dpaa2_get_devargs(dev->devargs, DRIVER_LOOPBACK_MODE))
+                       eth_dev->rx_pkt_burst = dpaa2_dev_loopback_rx;
+               else
+                       eth_dev->rx_pkt_burst = dpaa2_dev_prefetch_rx;
+               eth_dev->tx_pkt_burst = dpaa2_dev_tx;
                return 0;
+       }
 
        dpaa2_dev = container_of(dev, struct rte_dpaa2_device, device);
 
@@ -1353,15 +2125,15 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
 
        dpni_dev = rte_malloc(NULL, sizeof(struct fsl_mc_io), 0);
        if (!dpni_dev) {
-               PMD_INIT_LOG(ERR, "malloc failed for dpni device\n");
+               DPAA2_PMD_ERR("Memory allocation failed for dpni device");
                return -1;
        }
 
        dpni_dev->regs = rte_mcp_ptr_list[0];
        ret = dpni_open(dpni_dev, CMD_PRI_LOW, hw_id, &priv->token);
        if (ret) {
-               PMD_INIT_LOG(ERR,
-                            "Failure in opening dpni@%d with err code %d\n",
+               DPAA2_PMD_ERR(
+                            "Failure in opening dpni@%d with err code %d",
                             hw_id, ret);
                rte_free(dpni_dev);
                return -1;
@@ -1370,36 +2142,30 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
        /* Clean the device first */
        ret = dpni_reset(dpni_dev, CMD_PRI_LOW, priv->token);
        if (ret) {
-               PMD_INIT_LOG(ERR,
-                            "Failure cleaning dpni@%d with err code %d\n",
-                            hw_id, ret);
+               DPAA2_PMD_ERR("Failure cleaning dpni@%d with err code %d",
+                             hw_id, ret);
                goto init_err;
        }
 
        ret = dpni_get_attributes(dpni_dev, CMD_PRI_LOW, priv->token, &attr);
        if (ret) {
-               PMD_INIT_LOG(ERR,
-                            "Failure in get dpni@%d attribute, err code %d\n",
+               DPAA2_PMD_ERR(
+                            "Failure in get dpni@%d attribute, err code %d",
                             hw_id, ret);
                goto init_err;
        }
 
-       priv->num_tc = attr.num_tcs;
+       priv->num_rx_tc = attr.num_rx_tcs;
 
-       /* Resetting the "num_rx_vqueues" to equal number of queues in first TC
-        * as only one TC is supported on Rx Side. Once Multiple TCs will be
-        * in use for Rx processing then this will be changed or removed.
-        */
-       priv->nb_rx_queues = attr.num_queues;
+       for (i = 0; i < attr.num_rx_tcs; i++)
+               priv->nb_rx_queues += attr.num_queues;
 
-       /* TODO:Using hard coded value for number of TX queues due to dependency
-        * in MC.
-        */
-       priv->nb_tx_queues = 8;
+       /* Using number of TX queues as number of TX TCs */
+       priv->nb_tx_queues = attr.num_tx_tcs;
 
-       PMD_INIT_LOG(DEBUG, "num TC - RX %d", priv->num_tc);
-       PMD_INIT_LOG(DEBUG, "nb_tx_queues %d", priv->nb_tx_queues);
-       PMD_INIT_LOG(DEBUG, "nb_rx_queues %d", priv->nb_rx_queues);
+       DPAA2_PMD_DEBUG("RX-TC= %d, nb_rx_queues= %d, nb_tx_queues=%d",
+                       priv->num_rx_tc, priv->nb_rx_queues,
+                       priv->nb_tx_queues);
 
        priv->hw = dpni_dev;
        priv->hw_id = hw_id;
@@ -1411,27 +2177,29 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
        /* Allocate memory for hardware structure for queues */
        ret = dpaa2_alloc_rx_tx_queues(eth_dev);
        if (ret) {
-               PMD_INIT_LOG(ERR, "dpaa2_alloc_rx_tx_queuesFailed\n");
+               DPAA2_PMD_ERR("Queue allocation Failed");
                goto init_err;
        }
 
-       /* Allocate memory for storing MAC addresses */
+       /* Allocate memory for storing MAC addresses.
+        * Table of mac_filter_entries size is allocated so that RTE ether lib
+        * can add MAC entries when rte_eth_dev_mac_addr_add is called.
+        */
        eth_dev->data->mac_addrs = rte_zmalloc("dpni",
                ETHER_ADDR_LEN * attr.mac_filter_entries, 0);
        if (eth_dev->data->mac_addrs == NULL) {
-               PMD_INIT_LOG(ERR,
+               DPAA2_PMD_ERR(
                   "Failed to allocate %d bytes needed to store MAC addresses",
-                            ETHER_ADDR_LEN * attr.mac_filter_entries);
+                  ETHER_ADDR_LEN * attr.mac_filter_entries);
                ret = -ENOMEM;
                goto init_err;
        }
 
-       ret = dpni_get_primary_mac_addr(dpni_dev, CMD_PRI_LOW,
-                                       priv->token,
-                       (uint8_t *)(eth_dev->data->mac_addrs[0].addr_bytes));
+       ret = populate_mac_addr(dpni_dev, priv, &eth_dev->data->mac_addrs[0]);
        if (ret) {
-               PMD_INIT_LOG(ERR, "DPNI get mac address failed:Err Code = %d\n",
-                            ret);
+               DPAA2_PMD_ERR("Unable to fetch MAC Address for device");
+               rte_free(eth_dev->data->mac_addrs);
+               eth_dev->data->mac_addrs = NULL;
                goto init_err;
        }
 
@@ -1442,8 +2210,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
        ret = dpni_set_buffer_layout(dpni_dev, CMD_PRI_LOW, priv->token,
                                     DPNI_QUEUE_TX, &layout);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Error (%d) in setting tx buffer layout",
-                            ret);
+               DPAA2_PMD_ERR("Error (%d) in setting tx buffer layout", ret);
                goto init_err;
        }
 
@@ -1454,17 +2221,42 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
        ret = dpni_set_buffer_layout(dpni_dev, CMD_PRI_LOW, priv->token,
                                     DPNI_QUEUE_TX_CONFIRM, &layout);
        if (ret) {
-               PMD_INIT_LOG(ERR, "Error (%d) in setting tx-conf buffer layout",
+               DPAA2_PMD_ERR("Error (%d) in setting tx-conf buffer layout",
                             ret);
                goto init_err;
        }
 
        eth_dev->dev_ops = &dpaa2_ethdev_ops;
 
-       eth_dev->rx_pkt_burst = dpaa2_dev_prefetch_rx;
+       if (dpaa2_get_devargs(dev->devargs, DRIVER_LOOPBACK_MODE)) {
+               eth_dev->rx_pkt_burst = dpaa2_dev_loopback_rx;
+               DPAA2_PMD_INFO("Loopback mode");
+       } else {
+               eth_dev->rx_pkt_burst = dpaa2_dev_prefetch_rx;
+       }
        eth_dev->tx_pkt_burst = dpaa2_dev_tx;
-       rte_fslmc_vfio_dmamap();
 
+       /*Init fields w.r.t. classficaition*/
+       memset(&priv->extract.qos_key_cfg, 0, sizeof(struct dpkg_profile_cfg));
+       priv->extract.qos_extract_param = (size_t)rte_malloc(NULL, 256, 64);
+       if (!priv->extract.qos_extract_param) {
+               DPAA2_PMD_ERR(" Error(%d) in allocation resources for flow "
+                           " classificaiton ", ret);
+               goto init_err;
+       }
+       for (i = 0; i < MAX_TCS; i++) {
+               memset(&priv->extract.fs_key_cfg[i], 0,
+                       sizeof(struct dpkg_profile_cfg));
+               priv->extract.fs_extract_param[i] =
+                       (size_t)rte_malloc(NULL, 256, 64);
+               if (!priv->extract.fs_extract_param[i]) {
+                       DPAA2_PMD_ERR(" Error(%d) in allocation resources for flow classificaiton",
+                                    ret);
+                       goto init_err;
+               }
+       }
+
+       RTE_LOG(INFO, PMD, "%s: netdev created\n", eth_dev->data->name);
        return 0;
 init_err:
        dpaa2_dev_uninit(eth_dev);
@@ -1477,7 +2269,6 @@ dpaa2_dev_uninit(struct rte_eth_dev *eth_dev)
        struct dpaa2_dev_priv *priv = eth_dev->data->dev_private;
        struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
        int i, ret;
-       struct dpaa2_queue *dpaa2_q;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1485,35 +2276,19 @@ dpaa2_dev_uninit(struct rte_eth_dev *eth_dev)
                return 0;
 
        if (!dpni) {
-               PMD_INIT_LOG(WARNING, "Already closed or not started");
+               DPAA2_PMD_WARN("Already closed or not started");
                return -1;
        }
 
        dpaa2_dev_close(eth_dev);
 
-       if (priv->rx_vq[0]) {
-               /* cleaning up queue storage */
-               for (i = 0; i < priv->nb_rx_queues; i++) {
-                       dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i];
-                       if (dpaa2_q->q_storage)
-                               rte_free(dpaa2_q->q_storage);
-               }
-               /*free the all queue memory */
-               rte_free(priv->rx_vq[0]);
-               priv->rx_vq[0] = NULL;
-       }
-
-       /* free memory for storing MAC addresses */
-       if (eth_dev->data->mac_addrs) {
-               rte_free(eth_dev->data->mac_addrs);
-               eth_dev->data->mac_addrs = NULL;
-       }
+       dpaa2_free_rx_tx_queues(eth_dev);
 
        /* Close the device at underlying layer*/
        ret = dpni_close(dpni, CMD_PRI_LOW, priv->token);
        if (ret) {
-               PMD_INIT_LOG(ERR,
-                            "Failure closing dpni device with err code %d\n",
+               DPAA2_PMD_ERR(
+                            "Failure closing dpni device with err code %d",
                             ret);
        }
 
@@ -1521,10 +2296,19 @@ dpaa2_dev_uninit(struct rte_eth_dev *eth_dev)
        priv->hw = NULL;
        rte_free(dpni);
 
+       for (i = 0; i < MAX_TCS; i++) {
+               if (priv->extract.fs_extract_param[i])
+                       rte_free((void *)(size_t)priv->extract.fs_extract_param[i]);
+       }
+
+       if (priv->extract.qos_extract_param)
+               rte_free((void *)(size_t)priv->extract.qos_extract_param);
+
        eth_dev->dev_ops = NULL;
        eth_dev->rx_pkt_burst = NULL;
        eth_dev->tx_pkt_burst = NULL;
 
+       DPAA2_PMD_INFO("%s: netdev deleted", eth_dev->data->name);
        return 0;
 }
 
@@ -1544,8 +2328,8 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,
                                                sizeof(struct dpaa2_dev_priv),
                                                RTE_CACHE_LINE_SIZE);
                if (eth_dev->data->dev_private == NULL) {
-                       PMD_INIT_LOG(CRIT, "Cannot allocate memzone for"
-                                    " private port data\n");
+                       DPAA2_PMD_CRIT(
+                               "Unable to allocate memory for private data");
                        rte_eth_dev_release_port(eth_dev);
                        return -ENOMEM;
                }
@@ -1556,18 +2340,20 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,
        }
 
        eth_dev->device = &dpaa2_dev->device;
-       eth_dev->device->driver = &dpaa2_drv->driver;
 
        dpaa2_dev->eth_dev = eth_dev;
        eth_dev->data->rx_mbuf_alloc_failed = 0;
 
+       if (dpaa2_drv->drv_flags & RTE_DPAA2_DRV_INTR_LSC)
+               eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
+
        /* Invoke PMD device initialization function */
        diag = dpaa2_dev_init(eth_dev);
-       if (diag == 0)
+       if (diag == 0) {
+               rte_eth_dev_probing_finish(eth_dev);
                return 0;
+       }
 
-       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-               rte_free(eth_dev->data->dev_private);
        rte_eth_dev_release_port(eth_dev);
        return diag;
 }
@@ -1580,17 +2366,24 @@ rte_dpaa2_remove(struct rte_dpaa2_device *dpaa2_dev)
        eth_dev = dpaa2_dev->eth_dev;
        dpaa2_dev_uninit(eth_dev);
 
-       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-               rte_free(eth_dev->data->dev_private);
        rte_eth_dev_release_port(eth_dev);
 
        return 0;
 }
 
 static struct rte_dpaa2_driver rte_dpaa2_pmd = {
-       .drv_type = DPAA2_MC_DPNI_DEVID,
+       .drv_flags = RTE_DPAA2_DRV_INTR_LSC | RTE_DPAA2_DRV_IOVA_AS_VA,
+       .drv_type = DPAA2_ETH,
        .probe = rte_dpaa2_probe,
        .remove = rte_dpaa2_remove,
 };
 
 RTE_PMD_REGISTER_DPAA2(net_dpaa2, rte_dpaa2_pmd);
+RTE_PMD_REGISTER_PARAM_STRING(net_dpaa2,
+               DRIVER_LOOPBACK_MODE "=<int>");
+RTE_INIT(dpaa2_pmd_init_log)
+{
+       dpaa2_logtype_pmd = rte_log_register("pmd.net.dpaa2");
+       if (dpaa2_logtype_pmd >= 0)
+               rte_log_set_level(dpaa2_logtype_pmd, RTE_LOG_NOTICE);
+}