fm10k: get descriptor limits
[dpdk.git] / drivers / net / fm10k / fm10k_ethdev.c
index 5159cc8..caa1272 100644 (file)
@@ -45,6 +45,8 @@
 #define FM10K_MBXLOCK_DELAY_US 20
 #define UINT64_LOWER_32BITS_MASK 0x00000000ffffffffULL
 
+#define MAIN_VSI_POOL_NUMBER 0
+
 /* Max try times to acquire switch status */
 #define MAX_QUERY_SWITCH_STATE_TIMES 10
 /* Wait interval to get switch status */
@@ -61,10 +63,8 @@ static void fm10k_dev_allmulticast_disable(struct rte_eth_dev *dev);
 static inline int fm10k_glort_valid(struct fm10k_hw *hw);
 static int
 fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on);
-static void
-fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add);
-static void
-fm10k_MACVLAN_remove_all(struct rte_eth_dev *dev);
+static void fm10k_MAC_filter_set(struct rte_eth_dev *dev,
+       const u8 *mac, bool add, uint32_t pool);
 static void fm10k_tx_queue_release(void *queue);
 static void fm10k_rx_queue_release(void *queue);
 
@@ -182,7 +182,7 @@ rx_queue_disable(struct fm10k_hw *hw, uint16_t qnum)
        /* Wait 100us at most */
        for (i = 0; i < FM10K_QUEUE_DISABLE_TIMEOUT; i++) {
                rte_delay_us(1);
-               reg = FM10K_READ_REG(hw, FM10K_RXQCTL(i));
+               reg = FM10K_READ_REG(hw, FM10K_RXQCTL(qnum));
                if (!(reg & FM10K_RXQCTL_ENABLE))
                        break;
        }
@@ -271,7 +271,7 @@ tx_queue_disable(struct fm10k_hw *hw, uint16_t qnum)
        /* Wait 100us at most */
        for (i = 0; i < FM10K_QUEUE_DISABLE_TIMEOUT; i++) {
                rte_delay_us(1);
-               reg = FM10K_READ_REG(hw, FM10K_TXDCTL(i));
+               reg = FM10K_READ_REG(hw, FM10K_TXDCTL(qnum));
                if (!(reg & FM10K_TXDCTL_ENABLE))
                        break;
        }
@@ -282,19 +282,96 @@ tx_queue_disable(struct fm10k_hw *hw, uint16_t qnum)
        return 0;
 }
 
+static int
+fm10k_check_mq_mode(struct rte_eth_dev *dev)
+{
+       enum rte_eth_rx_mq_mode rx_mq_mode = dev->data->dev_conf.rxmode.mq_mode;
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct rte_eth_vmdq_rx_conf *vmdq_conf;
+       uint16_t nb_rx_q = dev->data->nb_rx_queues;
+
+       vmdq_conf = &dev->data->dev_conf.rx_adv_conf.vmdq_rx_conf;
+
+       if (rx_mq_mode & ETH_MQ_RX_DCB_FLAG) {
+               PMD_INIT_LOG(ERR, "DCB mode is not supported.");
+               return -EINVAL;
+       }
+
+       if (!(rx_mq_mode & ETH_MQ_RX_VMDQ_FLAG))
+               return 0;
+
+       if (hw->mac.type == fm10k_mac_vf) {
+               PMD_INIT_LOG(ERR, "VMDQ mode is not supported in VF.");
+               return -EINVAL;
+       }
+
+       /* Check VMDQ queue pool number */
+       if (vmdq_conf->nb_queue_pools >
+                       sizeof(vmdq_conf->pool_map[0].pools) * CHAR_BIT ||
+                       vmdq_conf->nb_queue_pools > nb_rx_q) {
+               PMD_INIT_LOG(ERR, "Too many of queue pools: %d",
+                       vmdq_conf->nb_queue_pools);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
 static int
 fm10k_dev_configure(struct rte_eth_dev *dev)
 {
+       int ret;
+
        PMD_INIT_FUNC_TRACE();
 
        if (dev->data->dev_conf.rxmode.hw_strip_crc == 0)
                PMD_INIT_LOG(WARNING, "fm10k always strip CRC");
+       /* multipe queue mode checking */
+       ret  = fm10k_check_mq_mode(dev);
+       if (ret != 0) {
+               PMD_DRV_LOG(ERR, "fm10k_check_mq_mode fails with %d.",
+                           ret);
+               return ret;
+       }
 
        return 0;
 }
 
+/* fls = find last set bit = 32 minus the number of leading zeros */
+#ifndef fls
+#define fls(x) (((x) == 0) ? 0 : (32 - __builtin_clz((x))))
+#endif
+
 static void
-fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
+fm10k_dev_vmdq_rx_configure(struct rte_eth_dev *dev)
+{
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct rte_eth_vmdq_rx_conf *vmdq_conf;
+       uint32_t i;
+
+       vmdq_conf = &dev->data->dev_conf.rx_adv_conf.vmdq_rx_conf;
+
+       for (i = 0; i < vmdq_conf->nb_pool_maps; i++) {
+               if (!vmdq_conf->pool_map[i].pools)
+                       continue;
+               fm10k_mbx_lock(hw);
+               fm10k_update_vlan(hw, vmdq_conf->pool_map[i].vlan_id, 0, true);
+               fm10k_mbx_unlock(hw);
+       }
+}
+
+static void
+fm10k_dev_pf_main_vsi_reset(struct rte_eth_dev *dev)
+{
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       /* Add default mac address */
+       fm10k_MAC_filter_set(dev, hw->mac.addr, true,
+               MAIN_VSI_POOL_NUMBER);
+}
+
+static void
+fm10k_dev_rss_configure(struct rte_eth_dev *dev)
 {
        struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
@@ -365,6 +442,78 @@ fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
        FM10K_WRITE_REG(hw, FM10K_MRQC(0), mrqc);
 }
 
+static void
+fm10k_dev_logic_port_update(struct rte_eth_dev *dev,
+       uint16_t nb_lport_old, uint16_t nb_lport_new)
+{
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint32_t i;
+
+       fm10k_mbx_lock(hw);
+       /* Disable previous logic ports */
+       if (nb_lport_old)
+               hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
+                       nb_lport_old, false);
+       /* Enable new logic ports */
+       hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
+               nb_lport_new, true);
+       fm10k_mbx_unlock(hw);
+
+       for (i = 0; i < nb_lport_new; i++) {
+               /* Set unicast mode by default. App can change
+                * to other mode in other API func.
+                */
+               fm10k_mbx_lock(hw);
+               hw->mac.ops.update_xcast_mode(hw, hw->mac.dglort_map + i,
+                       FM10K_XCAST_MODE_NONE);
+               fm10k_mbx_unlock(hw);
+       }
+}
+
+static void
+fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
+{
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct rte_eth_vmdq_rx_conf *vmdq_conf;
+       struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
+       struct fm10k_macvlan_filter_info *macvlan;
+       uint16_t nb_queue_pools = 0; /* pool number in configuration */
+       uint16_t nb_lport_new, nb_lport_old;
+
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+       vmdq_conf = &dev->data->dev_conf.rx_adv_conf.vmdq_rx_conf;
+
+       fm10k_dev_rss_configure(dev);
+
+       /* only PF supports VMDQ */
+       if (hw->mac.type != fm10k_mac_pf)
+               return;
+
+       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG)
+               nb_queue_pools = vmdq_conf->nb_queue_pools;
+
+       /* no pool number change, no need to update logic port and VLAN/MAC */
+       if (macvlan->nb_queue_pools == nb_queue_pools)
+               return;
+
+       nb_lport_old = macvlan->nb_queue_pools ? macvlan->nb_queue_pools : 1;
+       nb_lport_new = nb_queue_pools ? nb_queue_pools : 1;
+       fm10k_dev_logic_port_update(dev, nb_lport_old, nb_lport_new);
+
+       /* reset MAC/VLAN as it's based on VMDQ or PF main VSI */
+       memset(dev->data->mac_addrs, 0,
+               ETHER_ADDR_LEN * FM10K_MAX_MACADDR_NUM);
+       ether_addr_copy((const struct ether_addr *)hw->mac.addr,
+               &dev->data->mac_addrs[0]);
+       memset(macvlan, 0, sizeof(*macvlan));
+       macvlan->nb_queue_pools = nb_queue_pools;
+
+       if (nb_queue_pools)
+               fm10k_dev_vmdq_rx_configure(dev);
+       else
+               fm10k_dev_pf_main_vsi_reset(dev);
+}
+
 static int
 fm10k_dev_tx_init(struct rte_eth_dev *dev)
 {
@@ -473,7 +622,7 @@ fm10k_dev_rx_init(struct rte_eth_dev *dev)
                FM10K_WRITE_FLUSH(hw);
        }
 
-       /* Configure RSS if applicable */
+       /* Configure VMDQ/RSS if applicable */
        fm10k_dev_mq_rx_configure(dev);
        return 0;
 }
@@ -703,10 +852,32 @@ fm10k_dev_allmulticast_disable(struct rte_eth_dev *dev)
                PMD_INIT_LOG(ERR, "Failed to disable allmulticast mode");
 }
 
-/* fls = find last set bit = 32 minus the number of leading zeros */
-#ifndef fls
-#define fls(x) (((x) == 0) ? 0 : (32 - __builtin_clz((x))))
-#endif
+static void
+fm10k_dev_dglort_map_configure(struct rte_eth_dev *dev)
+{
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint32_t dglortdec, pool_len, rss_len, i;
+       uint16_t nb_queue_pools;
+       struct fm10k_macvlan_filter_info *macvlan;
+
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+       nb_queue_pools = macvlan->nb_queue_pools;
+       pool_len = nb_queue_pools ? fls(nb_queue_pools - 1) : 0;
+       rss_len = fls(dev->data->nb_rx_queues - 1) - pool_len;
+       dglortdec = (rss_len << FM10K_DGLORTDEC_RSSLENGTH_SHIFT) | pool_len;
+
+       /* Establish only MAP 0 as valid */
+       FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(0), FM10K_DGLORTMAP_ANY);
+
+       /* Configure VMDQ/RSS DGlort Decoder */
+       FM10K_WRITE_REG(hw, FM10K_DGLORTDEC(0), dglortdec);
+
+       /* Invalidate all other GLORT entries */
+       for (i = 1; i < FM10K_DGLORT_COUNT; i++)
+               FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(i),
+                               FM10K_DGLORTMAP_NONE);
+}
+
 #define BSIZEPKT_ROUNDUP ((1 << FM10K_SRRCTL_BSIZEPKT_SHIFT) - 1)
 static int
 fm10k_dev_start(struct rte_eth_dev *dev)
@@ -747,20 +918,8 @@ fm10k_dev_start(struct rte_eth_dev *dev)
                return diag;
        }
 
-       if (hw->mac.type == fm10k_mac_pf) {
-               /* Establish only VSI 0 as valid */
-               FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(0), FM10K_DGLORTMAP_ANY);
-
-               /* Configure RSS bits used in RETA table */
-               FM10K_WRITE_REG(hw, FM10K_DGLORTDEC(0),
-                               fls(dev->data->nb_rx_queues - 1) <<
-                               FM10K_DGLORTDEC_RSSLENGTH_SHIFT);
-
-               /* Invalidate all other GLORT entries */
-               for (i = 1; i < FM10K_DGLORT_COUNT; i++)
-                       FM10K_WRITE_REG(hw, FM10K_DGLORTMAP(i),
-                                       FM10K_DGLORTMAP_NONE);
-       }
+       if (hw->mac.type == fm10k_mac_pf)
+               fm10k_dev_dglort_map_configure(dev);
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                struct fm10k_rx_queue *rxq;
@@ -786,14 +945,16 @@ fm10k_dev_start(struct rte_eth_dev *dev)
                diag = fm10k_dev_tx_queue_start(dev, i);
                if (diag != 0) {
                        int j;
+                       for (j = 0; j < i; ++j)
+                               tx_queue_clean(dev->data->tx_queues[j]);
                        for (j = 0; j < dev->data->nb_rx_queues; ++j)
                                rx_queue_clean(dev->data->rx_queues[j]);
                        return diag;
                }
        }
 
-       /* Update default vlan */
-       if (hw->mac.default_vid && hw->mac.default_vid <= ETHER_MAX_VLAN_ID)
+       /* Update default vlan when not in VMDQ mode */
+       if (!(dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_VMDQ_FLAG))
                fm10k_vlan_filter_set(dev, hw->mac.default_vid, true);
 
        return 0;
@@ -837,10 +998,17 @@ static void
 fm10k_dev_close(struct rte_eth_dev *dev)
 {
        struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint16_t nb_lport;
+       struct fm10k_macvlan_filter_info *macvlan;
 
        PMD_INIT_FUNC_TRACE();
 
-       fm10k_MACVLAN_remove_all(dev);
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+       nb_lport = macvlan->nb_queue_pools ? macvlan->nb_queue_pools : 1;
+       fm10k_mbx_lock(hw);
+       hw->mac.ops.update_lport_state(hw, hw->mac.dglort_map,
+               nb_lport, false);
+       fm10k_mbx_unlock(hw);
 
        /* Stop mailbox service first */
        fm10k_close_mbx_service(hw);
@@ -925,7 +1093,10 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
        dev_info->max_mac_addrs      = FM10K_MAX_MACADDR_NUM;
        dev_info->max_hash_mac_addrs = 0;
        dev_info->max_vfs            = dev->pci_dev->max_vfs;
-       dev_info->max_vmdq_pools     = ETH_64_POOLS;
+       dev_info->vmdq_pool_base     = 0;
+       dev_info->vmdq_queue_base    = 0;
+       dev_info->max_vmdq_pools     = ETH_32_POOLS;
+       dev_info->vmdq_queue_num     = FM10K_MAX_QUEUES_PF;
        dev_info->rx_offload_capa =
                DEV_RX_OFFLOAD_VLAN_STRIP |
                DEV_RX_OFFLOAD_IPV4_CKSUM |
@@ -935,7 +1106,8 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
                DEV_TX_OFFLOAD_VLAN_INSERT |
                DEV_TX_OFFLOAD_IPV4_CKSUM  |
                DEV_TX_OFFLOAD_UDP_CKSUM   |
-               DEV_TX_OFFLOAD_TCP_CKSUM;
+               DEV_TX_OFFLOAD_TCP_CKSUM   |
+               DEV_TX_OFFLOAD_TCP_TSO;
 
        dev_info->hash_key_size = FM10K_RSSRK_SIZE * sizeof(uint32_t);
        dev_info->reta_size = FM10K_MAX_RSS_INDICES;
@@ -962,6 +1134,17 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
                                ETH_TXQ_FLAGS_NOOFFLOADS,
        };
 
+       dev_info->rx_desc_lim = (struct rte_eth_desc_lim) {
+               .nb_max = FM10K_MAX_RX_DESC,
+               .nb_min = FM10K_MIN_RX_DESC,
+               .nb_align = FM10K_MULT_RX_DESC,
+       };
+
+       dev_info->tx_desc_lim = (struct rte_eth_desc_lim) {
+               .nb_max = FM10K_MAX_TX_DESC,
+               .nb_min = FM10K_MIN_TX_DESC,
+               .nb_align = FM10K_MULT_TX_DESC,
+       };
 }
 
 static int
@@ -977,6 +1160,11 @@ fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
 
+       if (macvlan->nb_queue_pools > 0) { /* VMDQ mode */
+               PMD_INIT_LOG(ERR, "Cannot change VLAN filter in VMDQ mode");
+               return (-EINVAL);
+       }
+
        if (vlan_id > ETH_VLAN_ID_MAX) {
                PMD_INIT_LOG(ERR, "Invalid vlan_id: must be < 4096");
                return (-EINVAL);
@@ -1054,38 +1242,80 @@ fm10k_vlan_offload_set(__rte_unused struct rte_eth_dev *dev, int mask)
        }
 }
 
-/* Add/Remove a MAC address, and update filters */
-static void
-fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add)
+/* Add/Remove a MAC address, and update filters to main VSI */
+static void fm10k_MAC_filter_set_main_vsi(struct rte_eth_dev *dev,
+               const u8 *mac, bool add, uint32_t pool)
 {
-       uint32_t i, j, k;
-       struct fm10k_hw *hw;
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct fm10k_macvlan_filter_info *macvlan;
+       uint32_t i, j, k;
 
-       hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
 
-       i = 0;
-       for (j = 0; j < FM10K_VFTA_SIZE; j++) {
-               if (macvlan->vfta[j]) {
-                       for (k = 0; k < FM10K_UINT32_BIT_SIZE; k++) {
-                               if (macvlan->vfta[j] & (1 << k)) {
-                                       if (i + 1 > macvlan->vlan_num) {
-                                               PMD_INIT_LOG(ERR, "vlan number "
-                                                               "not match");
-                                               return;
-                                       }
-                                       fm10k_mbx_lock(hw);
-                                       fm10k_update_uc_addr(hw,
-                                               hw->mac.dglort_map, mac,
-                                               j * FM10K_UINT32_BIT_SIZE + k,
-                                               add, 0);
-                                       fm10k_mbx_unlock(hw);
-                                       i++;
-                               }
+       if (pool != MAIN_VSI_POOL_NUMBER) {
+               PMD_DRV_LOG(ERR, "VMDQ not enabled, can't set "
+                       "mac to pool %u", pool);
+               return;
+       }
+       for (i = 0, j = 0; j < FM10K_VFTA_SIZE; j++) {
+               if (!macvlan->vfta[j])
+                       continue;
+               for (k = 0; k < FM10K_UINT32_BIT_SIZE; k++) {
+                       if (!(macvlan->vfta[j] & (1 << k)))
+                               continue;
+                       if (i + 1 > macvlan->vlan_num) {
+                               PMD_INIT_LOG(ERR, "vlan number not match");
+                               return;
                        }
+                       fm10k_mbx_lock(hw);
+                       fm10k_update_uc_addr(hw, hw->mac.dglort_map, mac,
+                               j * FM10K_UINT32_BIT_SIZE + k, add, 0);
+                       fm10k_mbx_unlock(hw);
+                       i++;
                }
        }
+}
+
+/* Add/Remove a MAC address, and update filters to VMDQ */
+static void fm10k_MAC_filter_set_vmdq(struct rte_eth_dev *dev,
+               const u8 *mac, bool add, uint32_t pool)
+{
+       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct fm10k_macvlan_filter_info *macvlan;
+       struct rte_eth_vmdq_rx_conf *vmdq_conf;
+       uint32_t i;
+
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+       vmdq_conf = &dev->data->dev_conf.rx_adv_conf.vmdq_rx_conf;
+
+       if (pool > macvlan->nb_queue_pools) {
+               PMD_DRV_LOG(ERR, "Pool number %u invalid."
+                       " Max pool is %u",
+                       pool, macvlan->nb_queue_pools);
+               return;
+       }
+       for (i = 0; i < vmdq_conf->nb_pool_maps; i++) {
+               if (!(vmdq_conf->pool_map[i].pools & (1UL << pool)))
+                       continue;
+               fm10k_mbx_lock(hw);
+               fm10k_update_uc_addr(hw, hw->mac.dglort_map + pool, mac,
+                       vmdq_conf->pool_map[i].vlan_id, add, 0);
+               fm10k_mbx_unlock(hw);
+       }
+}
+
+/* Add/Remove a MAC address, and update filters */
+static void fm10k_MAC_filter_set(struct rte_eth_dev *dev,
+               const u8 *mac, bool add, uint32_t pool)
+{
+       struct fm10k_macvlan_filter_info *macvlan;
+
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+
+       if (macvlan->nb_queue_pools > 0) /* VMDQ mode */
+               fm10k_MAC_filter_set_vmdq(dev, mac, add, pool);
+       else
+               fm10k_MAC_filter_set_main_vsi(dev, mac, add, pool);
 
        if (add)
                macvlan->mac_num++;
@@ -1096,11 +1326,15 @@ fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add)
 /* Add a MAC address, and update filters */
 static void
 fm10k_macaddr_add(struct rte_eth_dev *dev,
-                struct ether_addr *mac_addr,
-                __rte_unused uint32_t index,
-                __rte_unused uint32_t pool)
+               struct ether_addr *mac_addr,
+               uint32_t index,
+               uint32_t pool)
 {
-       fm10k_MAC_filter_set(dev, mac_addr->addr_bytes, TRUE);
+       struct fm10k_macvlan_filter_info *macvlan;
+
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+       fm10k_MAC_filter_set(dev, mac_addr->addr_bytes, TRUE, pool);
+       macvlan->mac_vmdq_id[index] = pool;
 }
 
 /* Remove a MAC address, and update filters */
@@ -1108,29 +1342,12 @@ static void
 fm10k_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
 {
        struct rte_eth_dev_data *data = dev->data;
-
-       if (index < FM10K_MAX_MACADDR_NUM)
-               fm10k_MAC_filter_set(dev, data->mac_addrs[index].addr_bytes,
-                               FALSE);
-}
-
-/* Remove all VLAN and MAC address table entries */
-static void
-fm10k_MACVLAN_remove_all(struct rte_eth_dev *dev)
-{
-       uint32_t j, k;
        struct fm10k_macvlan_filter_info *macvlan;
 
        macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
-       for (j = 0; j < FM10K_VFTA_SIZE; j++) {
-               if (macvlan->vfta[j]) {
-                       for (k = 0; k < FM10K_UINT32_BIT_SIZE; k++) {
-                               if (macvlan->vfta[j] & (1 << k))
-                                       fm10k_vlan_filter_set(dev,
-                                               j * FM10K_UINT32_BIT_SIZE + k, false);
-                       }
-               }
-       }
+       fm10k_MAC_filter_set(dev, data->mac_addrs[index].addr_bytes,
+                       FALSE, macvlan->mac_vmdq_id[index]);
+       macvlan->mac_vmdq_id[index] = 0;
 }
 
 static inline int
@@ -2220,7 +2437,8 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
        fm10k_mbx_unlock(hw);
 
        /* Add default mac address */
-       fm10k_MAC_filter_set(dev, hw->mac.addr, true);
+       fm10k_MAC_filter_set(dev, hw->mac.addr, true,
+               MAIN_VSI_POOL_NUMBER);
 
        return 0;
 }