net/i40evf: add multicast MAC address filtering
[dpdk.git] / drivers / net / i40e / i40e_ethdev_vf.c
index 6b7b350..750d849 100644 (file)
@@ -1,34 +1,5 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2016 Intel Corporation
  */
 
 #include <sys/queue.h>
 #include <rte_log.h>
 #include <rte_debug.h>
 #include <rte_pci.h>
+#include <rte_bus_pci.h>
 #include <rte_atomic.h>
 #include <rte_branch_prediction.h>
 #include <rte_memory.h>
-#include <rte_memzone.h>
 #include <rte_eal.h>
 #include <rte_alarm.h>
 #include <rte_ether.h>
-#include <rte_ethdev.h>
-#include <rte_atomic.h>
+#include <rte_ethdev_driver.h>
+#include <rte_ethdev_pci.h>
 #include <rte_malloc.h>
 #include <rte_dev.h>
 
 #include "i40e_rxtx.h"
 #include "i40e_ethdev.h"
 #include "i40e_pf.h"
-#define I40EVF_VSI_DEFAULT_MSIX_INTR     1
-#define I40EVF_VSI_DEFAULT_MSIX_INTR_LNX 0
 
 /* busy wait delay in msec */
 #define I40EVF_BUSY_WAIT_DELAY 10
 #define I40EVF_BUSY_WAIT_COUNT 50
 #define MAX_RESET_WAIT_CNT     20
-/*ITR index for NOITR*/
-#define I40E_QINT_RQCTL_MSIX_INDX_NOITR     3
 
 struct i40evf_arq_msg_info {
-       enum i40e_virtchnl_ops ops;
+       enum virtchnl_ops ops;
        enum i40e_status_code result;
        uint16_t buf_len;
        uint16_t msg_len;
@@ -86,7 +53,7 @@ struct i40evf_arq_msg_info {
 };
 
 struct vf_cmd_info {
-       enum i40e_virtchnl_ops ops;
+       enum virtchnl_ops ops;
        uint8_t *in_args;
        uint32_t in_args_size;
        uint8_t *out_buffer;
@@ -103,33 +70,30 @@ enum i40evf_aq_result {
        I40EVF_MSG_CMD,      /* Read async command result */
 };
 
-/* A share buffer to store the command result from PF driver */
-static uint8_t cmd_result_buffer[I40E_AQ_BUF_SZ];
-
 static int i40evf_dev_configure(struct rte_eth_dev *dev);
 static int i40evf_dev_start(struct rte_eth_dev *dev);
 static void i40evf_dev_stop(struct rte_eth_dev *dev);
 static void i40evf_dev_info_get(struct rte_eth_dev *dev,
                                struct rte_eth_dev_info *dev_info);
 static int i40evf_dev_link_update(struct rte_eth_dev *dev,
-                                 __rte_unused int wait_to_complete);
-static void i40evf_dev_stats_get(struct rte_eth_dev *dev,
+                                 int wait_to_complete);
+static int i40evf_dev_stats_get(struct rte_eth_dev *dev,
                                struct rte_eth_stats *stats);
 static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,
-                                struct rte_eth_xstats *xstats, unsigned n);
+                                struct rte_eth_xstat *xstats, unsigned n);
+static int i40evf_dev_xstats_get_names(struct rte_eth_dev *dev,
+                                      struct rte_eth_xstat_name *xstats_names,
+                                      unsigned limit);
 static void i40evf_dev_xstats_reset(struct rte_eth_dev *dev);
 static int i40evf_vlan_filter_set(struct rte_eth_dev *dev,
                                  uint16_t vlan_id, int on);
-static void i40evf_vlan_offload_set(struct rte_eth_dev *dev, int mask);
-static int i40evf_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t pvid,
-                               int on);
+static int i40evf_vlan_offload_set(struct rte_eth_dev *dev, int mask);
 static void i40evf_dev_close(struct rte_eth_dev *dev);
+static int  i40evf_dev_reset(struct rte_eth_dev *dev);
 static void i40evf_dev_promiscuous_enable(struct rte_eth_dev *dev);
 static void i40evf_dev_promiscuous_disable(struct rte_eth_dev *dev);
 static void i40evf_dev_allmulticast_enable(struct rte_eth_dev *dev);
 static void i40evf_dev_allmulticast_disable(struct rte_eth_dev *dev);
-static int i40evf_get_link_status(struct rte_eth_dev *dev,
-                                 struct rte_eth_link *link);
 static int i40evf_init_vlan(struct rte_eth_dev *dev);
 static int i40evf_dev_rx_queue_start(struct rte_eth_dev *dev,
                                     uint16_t rx_queue_id);
@@ -139,10 +103,10 @@ static int i40evf_dev_tx_queue_start(struct rte_eth_dev *dev,
                                     uint16_t tx_queue_id);
 static int i40evf_dev_tx_queue_stop(struct rte_eth_dev *dev,
                                    uint16_t tx_queue_id);
-static void i40evf_add_mac_addr(struct rte_eth_dev *dev,
-                               struct ether_addr *addr,
-                               uint32_t index,
-                               uint32_t pool);
+static int i40evf_add_mac_addr(struct rte_eth_dev *dev,
+                              struct ether_addr *addr,
+                              uint32_t index,
+                              uint32_t pool);
 static void i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index);
 static int i40evf_dev_rss_reta_update(struct rte_eth_dev *dev,
                        struct rte_eth_rss_reta_entry64 *reta_conf,
@@ -155,10 +119,24 @@ static int i40evf_dev_rss_hash_update(struct rte_eth_dev *dev,
                                      struct rte_eth_rss_conf *rss_conf);
 static int i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
                                        struct rte_eth_rss_conf *rss_conf);
+static int i40evf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
+static void i40evf_set_default_mac_addr(struct rte_eth_dev *dev,
+                                       struct ether_addr *mac_addr);
 static int
 i40evf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id);
 static int
 i40evf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id);
+static void i40evf_handle_pf_event(struct rte_eth_dev *dev,
+                                  uint8_t *msg,
+                                  uint16_t msglen);
+
+static int
+i40evf_add_del_mc_addr_list(struct rte_eth_dev *dev,
+                       struct ether_addr *mc_addr_set,
+                       uint32_t nb_mc_addr, bool add);
+static int
+i40evf_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *mc_addr_set,
+                       uint32_t nb_mc_addr);
 
 /* Default hash key buffer for RSS */
 static uint32_t rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1];
@@ -177,11 +155,11 @@ static const struct rte_i40evf_xstats_name_off rte_i40evf_stats_strings[] = {
        {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
                rx_unknown_protocol)},
        {"tx_bytes", offsetof(struct i40e_eth_stats, tx_bytes)},
-       {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
-       {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
-       {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
-       {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
-       {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
+       {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)},
+       {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)},
+       {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_broadcast)},
+       {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)},
+       {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_errors)},
 };
 
 #define I40EVF_NB_XSTATS (sizeof(rte_i40evf_stats_strings) / \
@@ -197,13 +175,16 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
        .allmulticast_disable = i40evf_dev_allmulticast_disable,
        .link_update          = i40evf_dev_link_update,
        .stats_get            = i40evf_dev_stats_get,
+       .stats_reset          = i40evf_dev_xstats_reset,
        .xstats_get           = i40evf_dev_xstats_get,
+       .xstats_get_names     = i40evf_dev_xstats_get_names,
        .xstats_reset         = i40evf_dev_xstats_reset,
        .dev_close            = i40evf_dev_close,
+       .dev_reset            = i40evf_dev_reset,
        .dev_infos_get        = i40evf_dev_info_get,
+       .dev_supported_ptypes_get = i40e_dev_supported_ptypes_get,
        .vlan_filter_set      = i40evf_vlan_filter_set,
        .vlan_offload_set     = i40evf_vlan_offload_set,
-       .vlan_pvid_set        = i40evf_vlan_pvid_set,
        .rx_queue_start       = i40evf_dev_rx_queue_start,
        .rx_queue_stop        = i40evf_dev_rx_queue_stop,
        .tx_queue_start       = i40evf_dev_tx_queue_start,
@@ -213,56 +194,72 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
        .rx_queue_intr_enable = i40evf_dev_rx_queue_intr_enable,
        .rx_queue_intr_disable = i40evf_dev_rx_queue_intr_disable,
        .rx_descriptor_done   = i40e_dev_rx_descriptor_done,
+       .rx_descriptor_status = i40e_dev_rx_descriptor_status,
+       .tx_descriptor_status = i40e_dev_tx_descriptor_status,
        .tx_queue_setup       = i40e_dev_tx_queue_setup,
        .tx_queue_release     = i40e_dev_tx_queue_release,
+       .rx_queue_count       = i40e_dev_rx_queue_count,
+       .rxq_info_get         = i40e_rxq_info_get,
+       .txq_info_get         = i40e_txq_info_get,
        .mac_addr_add         = i40evf_add_mac_addr,
        .mac_addr_remove      = i40evf_del_mac_addr,
+       .set_mc_addr_list     = i40evf_set_mc_addr_list,
        .reta_update          = i40evf_dev_rss_reta_update,
        .reta_query           = i40evf_dev_rss_reta_query,
        .rss_hash_update      = i40evf_dev_rss_hash_update,
        .rss_hash_conf_get    = i40evf_dev_rss_hash_conf_get,
+       .mtu_set              = i40evf_dev_mtu_set,
+       .mac_addr_set         = i40evf_set_default_mac_addr,
 };
 
 /*
- * Parse admin queue message.
- *
- * return value:
- *  < 0: meet error
- *  0: read sys msg
- *  > 0: read cmd result
+ * Read data in admin queue to get msg from pf driver
  */
 static enum i40evf_aq_result
-i40evf_parse_pfmsg(struct i40e_vf *vf,
-                  struct i40e_arq_event_info *event,
-                  struct i40evf_arq_msg_info *data)
+i40evf_read_pfmsg(struct rte_eth_dev *dev, struct i40evf_arq_msg_info *data)
 {
-       enum i40e_virtchnl_ops opcode = (enum i40e_virtchnl_ops)\
-                       rte_le_to_cpu_32(event->desc.cookie_high);
-       enum i40e_status_code retval = (enum i40e_status_code)\
-                       rte_le_to_cpu_32(event->desc.cookie_low);
-       enum i40evf_aq_result ret = I40EVF_MSG_CMD;
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_arq_event_info event;
+       enum virtchnl_ops opcode;
+       enum i40e_status_code retval;
+       int ret;
+       enum i40evf_aq_result result = I40EVF_MSG_NON;
 
+       event.buf_len = data->buf_len;
+       event.msg_buf = data->msg;
+       ret = i40e_clean_arq_element(hw, &event, NULL);
+       /* Can't read any msg from adminQ */
+       if (ret) {
+               if (ret != I40E_ERR_ADMIN_QUEUE_NO_WORK)
+                       result = I40EVF_MSG_ERR;
+               return result;
+       }
+
+       opcode = (enum virtchnl_ops)rte_le_to_cpu_32(event.desc.cookie_high);
+       retval = (enum i40e_status_code)rte_le_to_cpu_32(event.desc.cookie_low);
        /* pf sys event */
-       if (opcode == I40E_VIRTCHNL_OP_EVENT) {
-               struct i40e_virtchnl_pf_event *vpe =
-                       (struct i40e_virtchnl_pf_event *)event->msg_buf;
+       if (opcode == VIRTCHNL_OP_EVENT) {
+               struct virtchnl_pf_event *vpe =
+                       (struct virtchnl_pf_event *)event.msg_buf;
 
-               /* Initialize ret to sys event */
-               ret = I40EVF_MSG_SYS;
+               result = I40EVF_MSG_SYS;
                switch (vpe->event) {
-               case I40E_VIRTCHNL_EVENT_LINK_CHANGE:
+               case VIRTCHNL_EVENT_LINK_CHANGE:
                        vf->link_up =
                                vpe->event_data.link_event.link_status;
+                       vf->link_speed =
+                               vpe->event_data.link_event.link_speed;
                        vf->pend_msg |= PFMSG_LINK_CHANGE;
                        PMD_DRV_LOG(INFO, "Link status update:%s",
                                    vf->link_up ? "up" : "down");
                        break;
-               case I40E_VIRTCHNL_EVENT_RESET_IMPENDING:
+               case VIRTCHNL_EVENT_RESET_IMPENDING:
                        vf->vf_reset = true;
                        vf->pend_msg |= PFMSG_RESET_IMPENDING;
                        PMD_DRV_LOG(INFO, "vf is reseting");
                        break;
-               case I40E_VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
+               case VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
                        vf->dev_closed = true;
                        vf->pend_msg |= PFMSG_DRIVER_CLOSE;
                        PMD_DRV_LOG(INFO, "PF driver closed");
@@ -273,74 +270,17 @@ i40evf_parse_pfmsg(struct i40e_vf *vf,
                }
        } else {
                /* async reply msg on command issued by vf previously */
-               ret = I40EVF_MSG_CMD;
+               result = I40EVF_MSG_CMD;
                /* Actual data length read from PF */
-               data->msg_len = event->msg_len;
+               data->msg_len = event.msg_len;
        }
-       /* fill the ops and result to notify VF */
+
        data->result = retval;
        data->ops = opcode;
 
-       return ret;
-}
-
-/*
- * Read data in admin queue to get msg from pf driver
- */
-static enum i40evf_aq_result
-i40evf_read_pfmsg(struct rte_eth_dev *dev, struct i40evf_arq_msg_info *data)
-{
-       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_arq_event_info event;
-       int ret;
-       enum i40evf_aq_result result = I40EVF_MSG_NON;
-
-       event.buf_len = data->buf_len;
-       event.msg_buf = data->msg;
-       ret = i40e_clean_arq_element(hw, &event, NULL);
-       /* Can't read any msg from adminQ */
-       if (ret) {
-               if (ret == I40E_ERR_ADMIN_QUEUE_NO_WORK)
-                       result = I40EVF_MSG_NON;
-               else
-                       result = I40EVF_MSG_ERR;
-               return result;
-       }
-
-       /* Parse the event */
-       result = i40evf_parse_pfmsg(vf, &event, data);
-
        return result;
 }
 
-/*
- * Polling read until command result return from pf driver or meet error.
- */
-static int
-i40evf_wait_cmd_done(struct rte_eth_dev *dev,
-                    struct i40evf_arq_msg_info *data)
-{
-       int i = 0;
-       enum i40evf_aq_result ret;
-
-#define MAX_TRY_TIMES 20
-#define ASQ_DELAY_MS  100
-       do {
-               /* Delay some time first */
-               rte_delay_ms(ASQ_DELAY_MS);
-               ret = i40evf_read_pfmsg(dev, data);
-               if (ret == I40EVF_MSG_CMD)
-                       return 0;
-               else if (ret == I40EVF_MSG_ERR)
-                       return -1;
-
-               /* If don't read msg or read sys event, continue */
-       } while(i++ < MAX_TRY_TIMES);
-
-       return -1;
-}
-
 /**
  * clear current command. Only call in case execute
  * _atomic_set_cmd successfully.
@@ -349,17 +289,17 @@ static inline void
 _clear_cmd(struct i40e_vf *vf)
 {
        rte_wmb();
-       vf->pend_cmd = I40E_VIRTCHNL_OP_UNKNOWN;
+       vf->pend_cmd = VIRTCHNL_OP_UNKNOWN;
 }
 
 /*
  * Check there is pending cmd in execution. If none, set new command.
  */
 static inline int
-_atomic_set_cmd(struct i40e_vf *vf, enum i40e_virtchnl_ops ops)
+_atomic_set_cmd(struct i40e_vf *vf, enum virtchnl_ops ops)
 {
        int ret = rte_atomic32_cmpset(&vf->pend_cmd,
-                       I40E_VIRTCHNL_OP_UNKNOWN, ops);
+                       VIRTCHNL_OP_UNKNOWN, ops);
 
        if (!ret)
                PMD_DRV_LOG(ERR, "There is incomplete cmd %d", vf->pend_cmd);
@@ -367,20 +307,24 @@ _atomic_set_cmd(struct i40e_vf *vf, enum i40e_virtchnl_ops ops)
        return !ret;
 }
 
+#define MAX_TRY_TIMES 200
+#define ASQ_DELAY_MS  10
+
 static int
 i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct vf_cmd_info *args)
 {
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       int err = -1;
        struct i40evf_arq_msg_info info;
+       enum i40evf_aq_result ret;
+       int err, i = 0;
 
        if (_atomic_set_cmd(vf, args->ops))
                return -1;
 
        info.msg = args->out_buffer;
        info.buf_len = args->out_size;
-       info.ops = I40E_VIRTCHNL_OP_UNKNOWN;
+       info.ops = VIRTCHNL_OP_UNKNOWN;
        info.result = I40E_SUCCESS;
 
        err = i40e_aq_send_msg_to_pf(hw, args->ops, I40E_SUCCESS,
@@ -391,19 +335,49 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct vf_cmd_info *args)
                return err;
        }
 
-       err = i40evf_wait_cmd_done(dev, &info);
-       /* read message and it's expected one */
-       if (!err && args->ops == info.ops)
-               _clear_cmd(vf);
-       else if (err) {
-               PMD_DRV_LOG(ERR, "Failed to read message from AdminQ");
+       switch (args->ops) {
+       case VIRTCHNL_OP_RESET_VF:
+               /*no need to process in this function */
+               err = 0;
+               break;
+       case VIRTCHNL_OP_VERSION:
+       case VIRTCHNL_OP_GET_VF_RESOURCES:
+               /* for init adminq commands, need to poll the response */
+               err = -1;
+               do {
+                       ret = i40evf_read_pfmsg(dev, &info);
+                       vf->cmd_retval = info.result;
+                       if (ret == I40EVF_MSG_CMD) {
+                               err = 0;
+                               break;
+                       } else if (ret == I40EVF_MSG_ERR)
+                               break;
+                       rte_delay_ms(ASQ_DELAY_MS);
+                       /* If don't read msg or read sys event, continue */
+               } while (i++ < MAX_TRY_TIMES);
                _clear_cmd(vf);
+               break;
+
+       default:
+               /* for other adminq in running time, waiting the cmd done flag */
+               err = -1;
+               do {
+                       if (vf->pend_cmd == VIRTCHNL_OP_UNKNOWN) {
+                               err = 0;
+                               break;
+                       }
+                       rte_delay_ms(ASQ_DELAY_MS);
+                       /* If don't read msg or read sys event, continue */
+               } while (i++ < MAX_TRY_TIMES);
+               /* If there's no response is received, clear command */
+               if (i >= MAX_TRY_TIMES) {
+                       PMD_DRV_LOG(WARNING, "No response for %d", args->ops);
+                       _clear_cmd(vf);
+               }
+               break;
        }
-       else if (args->ops != info.ops)
-               PMD_DRV_LOG(ERR, "command mismatch, expect %u, get %u",
-                           args->ops, info.ops);
 
-       return err | info.result;
+       return err | vf->cmd_retval;
 }
 
 /*
@@ -412,18 +386,18 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct vf_cmd_info *args)
 static int
 i40evf_check_api_version(struct rte_eth_dev *dev)
 {
-       struct i40e_virtchnl_version_info version, *pver;
+       struct virtchnl_version_info version, *pver;
        int err;
        struct vf_cmd_info args;
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-       version.major = I40E_VIRTCHNL_VERSION_MAJOR;
-       version.minor = I40E_VIRTCHNL_VERSION_MINOR;
+       version.major = VIRTCHNL_VERSION_MAJOR;
+       version.minor = VIRTCHNL_VERSION_MINOR;
 
-       args.ops = I40E_VIRTCHNL_OP_VERSION;
+       args.ops = VIRTCHNL_OP_VERSION;
        args.in_args = (uint8_t *)&version;
        args.in_args_size = sizeof(version);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -432,19 +406,17 @@ i40evf_check_api_version(struct rte_eth_dev *dev)
                return err;
        }
 
-       pver = (struct i40e_virtchnl_version_info *)args.out_buffer;
+       pver = (struct virtchnl_version_info *)args.out_buffer;
        vf->version_major = pver->major;
        vf->version_minor = pver->minor;
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               PMD_DRV_LOG(INFO, "Peer is DPDK PF host");
-       else if ((vf->version_major == I40E_VIRTCHNL_VERSION_MAJOR) &&
-               (vf->version_minor <= I40E_VIRTCHNL_VERSION_MINOR))
+       if ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&
+               (vf->version_minor <= VIRTCHNL_VERSION_MINOR))
                PMD_DRV_LOG(INFO, "Peer is Linux PF host");
        else {
                PMD_INIT_LOG(ERR, "PF/VF API version mismatch:(%u.%u)-(%u.%u)",
                                        vf->version_major, vf->version_minor,
-                                               I40E_VIRTCHNL_VERSION_MAJOR,
-                                               I40E_VIRTCHNL_VERSION_MINOR);
+                                               VIRTCHNL_VERSION_MAJOR,
+                                               VIRTCHNL_VERSION_MINOR);
                return -1;
        }
 
@@ -460,15 +432,15 @@ i40evf_get_vf_resource(struct rte_eth_dev *dev)
        struct vf_cmd_info args;
        uint32_t caps, len;
 
-       args.ops = I40E_VIRTCHNL_OP_GET_VF_RESOURCES;
-       args.out_buffer = cmd_result_buffer;
+       args.ops = VIRTCHNL_OP_GET_VF_RESOURCES;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        if (PF_IS_V11(vf)) {
-               caps = I40E_VIRTCHNL_VF_OFFLOAD_L2 |
-                      I40E_VIRTCHNL_VF_OFFLOAD_RSS_AQ |
-                      I40E_VIRTCHNL_VF_OFFLOAD_RSS_REG |
-                      I40E_VIRTCHNL_VF_OFFLOAD_VLAN |
-                      I40E_VIRTCHNL_VF_OFFLOAD_RX_POLLING;
+               caps = VIRTCHNL_VF_OFFLOAD_L2 |
+                      VIRTCHNL_VF_OFFLOAD_RSS_AQ |
+                      VIRTCHNL_VF_OFFLOAD_RSS_REG |
+                      VIRTCHNL_VF_OFFLOAD_VLAN |
+                      VIRTCHNL_VF_OFFLOAD_RX_POLLING;
                args.in_args = (uint8_t *)&caps;
                args.in_args_size = sizeof(caps);
        } else {
@@ -482,10 +454,10 @@ i40evf_get_vf_resource(struct rte_eth_dev *dev)
                return err;
        }
 
-       len =  sizeof(struct i40e_virtchnl_vf_resource) +
-               I40E_MAX_VF_VSI * sizeof(struct i40e_virtchnl_vsi_resource);
+       len =  sizeof(struct virtchnl_vf_resource) +
+               I40E_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource);
 
-       (void)rte_memcpy(vf->vf_res, args.out_buffer,
+       rte_memcpy(vf->vf_res, args.out_buffer,
                        RTE_MIN(args.out_size, len));
        i40e_vf_parse_hw_config(hw, vf->vf_res);
 
@@ -500,21 +472,21 @@ i40evf_config_promisc(struct rte_eth_dev *dev,
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        int err;
        struct vf_cmd_info args;
-       struct i40e_virtchnl_promisc_info promisc;
+       struct virtchnl_promisc_info promisc;
 
        promisc.flags = 0;
        promisc.vsi_id = vf->vsi_res->vsi_id;
 
        if (enable_unicast)
-               promisc.flags |= I40E_FLAG_VF_UNICAST_PROMISC;
+               promisc.flags |= FLAG_VF_UNICAST_PROMISC;
 
        if (enable_multicast)
-               promisc.flags |= I40E_FLAG_VF_MULTICAST_PROMISC;
+               promisc.flags |= FLAG_VF_MULTICAST_PROMISC;
 
-       args.ops = I40E_VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE;
+       args.ops = VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE;
        args.in_args = (uint8_t *)&promisc;
        args.in_args_size = sizeof(promisc);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -525,65 +497,50 @@ i40evf_config_promisc(struct rte_eth_dev *dev,
        return err;
 }
 
-/* Configure vlan and double vlan offload. Use flag to specify which part to configure */
 static int
-i40evf_config_vlan_offload(struct rte_eth_dev *dev,
-                               bool enable_vlan_strip)
+i40evf_enable_vlan_strip(struct rte_eth_dev *dev)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       int err;
        struct vf_cmd_info args;
-       struct i40e_virtchnl_vlan_offload_info offload;
-
-       offload.vsi_id = vf->vsi_res->vsi_id;
-       offload.enable_vlan_strip = enable_vlan_strip;
+       int ret;
 
-       args.ops = (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_CFG_VLAN_OFFLOAD;
-       args.in_args = (uint8_t *)&offload;
-       args.in_args_size = sizeof(offload);
-       args.out_buffer = cmd_result_buffer;
+       memset(&args, 0, sizeof(args));
+       args.ops = VIRTCHNL_OP_ENABLE_VLAN_STRIPPING;
+       args.in_args = NULL;
+       args.in_args_size = 0;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
+       ret = i40evf_execute_vf_cmd(dev, &args);
+       if (ret)
+               PMD_DRV_LOG(ERR, "Failed to execute command of "
+                           "VIRTCHNL_OP_ENABLE_VLAN_STRIPPING");
 
-       err = i40evf_execute_vf_cmd(dev, &args);
-       if (err)
-               PMD_DRV_LOG(ERR, "fail to execute command CFG_VLAN_OFFLOAD");
-
-       return err;
+       return ret;
 }
 
 static int
-i40evf_config_vlan_pvid(struct rte_eth_dev *dev,
-                               struct i40e_vsi_vlan_pvid_info *info)
+i40evf_disable_vlan_strip(struct rte_eth_dev *dev)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       int err;
        struct vf_cmd_info args;
-       struct i40e_virtchnl_pvid_info tpid_info;
-
-       if (dev == NULL || info == NULL) {
-               PMD_DRV_LOG(ERR, "invalid parameters");
-               return I40E_ERR_PARAM;
-       }
-
-       memset(&tpid_info, 0, sizeof(tpid_info));
-       tpid_info.vsi_id = vf->vsi_res->vsi_id;
-       (void)rte_memcpy(&tpid_info.info, info, sizeof(*info));
+       int ret;
 
-       args.ops = (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_CFG_VLAN_PVID;
-       args.in_args = (uint8_t *)&tpid_info;
-       args.in_args_size = sizeof(tpid_info);
-       args.out_buffer = cmd_result_buffer;
+       memset(&args, 0, sizeof(args));
+       args.ops = VIRTCHNL_OP_DISABLE_VLAN_STRIPPING;
+       args.in_args = NULL;
+       args.in_args_size = 0;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
+       ret = i40evf_execute_vf_cmd(dev, &args);
+       if (ret)
+               PMD_DRV_LOG(ERR, "Failed to execute command of "
+                           "VIRTCHNL_OP_DISABLE_VLAN_STRIPPING");
 
-       err = i40evf_execute_vf_cmd(dev, &args);
-       if (err)
-               PMD_DRV_LOG(ERR, "fail to execute command CFG_VLAN_PVID");
-
-       return err;
+       return ret;
 }
 
 static void
-i40evf_fill_virtchnl_vsi_txq_info(struct i40e_virtchnl_txq_info *txq_info,
+i40evf_fill_virtchnl_vsi_txq_info(struct virtchnl_txq_info *txq_info,
                                  uint16_t vsi_id,
                                  uint16_t queue_id,
                                  uint16_t nb_txq,
@@ -598,7 +555,7 @@ i40evf_fill_virtchnl_vsi_txq_info(struct i40e_virtchnl_txq_info *txq_info,
 }
 
 static void
-i40evf_fill_virtchnl_vsi_rxq_info(struct i40e_virtchnl_rxq_info *rxq_info,
+i40evf_fill_virtchnl_vsi_rxq_info(struct virtchnl_rxq_info *rxq_info,
                                  uint16_t vsi_id,
                                  uint16_t queue_id,
                                  uint16_t nb_rxq,
@@ -617,7 +574,6 @@ i40evf_fill_virtchnl_vsi_rxq_info(struct i40e_virtchnl_rxq_info *rxq_info,
        }
 }
 
-/* It configures VSI queues to co-work with Linux PF host */
 static int
 i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
 {
@@ -626,8 +582,8 @@ i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
                (struct i40e_rx_queue **)dev->data->rx_queues;
        struct i40e_tx_queue **txq =
                (struct i40e_tx_queue **)dev->data->tx_queues;
-       struct i40e_virtchnl_vsi_queue_config_info *vc_vqci;
-       struct i40e_virtchnl_queue_pair_info *vc_qpi;
+       struct virtchnl_vsi_queue_config_info *vc_vqci;
+       struct virtchnl_queue_pair_info *vc_qpi;
        struct vf_cmd_info args;
        uint16_t i, nb_qp = vf->num_queue_pairs;
        const uint32_t size =
@@ -636,7 +592,7 @@ i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
        int ret;
 
        memset(buff, 0, sizeof(buff));
-       vc_vqci = (struct i40e_virtchnl_vsi_queue_config_info *)buff;
+       vc_vqci = (struct virtchnl_vsi_queue_config_info *)buff;
        vc_vqci->vsi_id = vf->vsi_res->vsi_id;
        vc_vqci->num_queue_pairs = nb_qp;
 
@@ -648,109 +604,41 @@ i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
                                        vf->max_pkt_len, rxq[i]);
        }
        memset(&args, 0, sizeof(args));
-       args.ops = I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES;
+       args.ops = VIRTCHNL_OP_CONFIG_VSI_QUEUES;
        args.in_args = (uint8_t *)vc_vqci;
        args.in_args_size = size;
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        ret = i40evf_execute_vf_cmd(dev, &args);
        if (ret)
                PMD_DRV_LOG(ERR, "Failed to execute command of "
-                       "I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES\n");
+                       "VIRTCHNL_OP_CONFIG_VSI_QUEUES");
 
        return ret;
 }
 
-/* It configures VSI queues to co-work with DPDK PF host */
-static int
-i40evf_configure_vsi_queues_ext(struct rte_eth_dev *dev)
-{
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_rx_queue **rxq =
-               (struct i40e_rx_queue **)dev->data->rx_queues;
-       struct i40e_tx_queue **txq =
-               (struct i40e_tx_queue **)dev->data->tx_queues;
-       struct i40e_virtchnl_vsi_queue_config_ext_info *vc_vqcei;
-       struct i40e_virtchnl_queue_pair_ext_info *vc_qpei;
-       struct vf_cmd_info args;
-       uint16_t i, nb_qp = vf->num_queue_pairs;
-       const uint32_t size =
-               I40E_VIRTCHNL_CONFIG_VSI_QUEUES_SIZE(vc_vqcei, nb_qp);
-       uint8_t buff[size];
-       int ret;
-
-       memset(buff, 0, sizeof(buff));
-       vc_vqcei = (struct i40e_virtchnl_vsi_queue_config_ext_info *)buff;
-       vc_vqcei->vsi_id = vf->vsi_res->vsi_id;
-       vc_vqcei->num_queue_pairs = nb_qp;
-       vc_qpei = vc_vqcei->qpair;
-       for (i = 0; i < nb_qp; i++, vc_qpei++) {
-               i40evf_fill_virtchnl_vsi_txq_info(&vc_qpei->txq,
-                       vc_vqcei->vsi_id, i, dev->data->nb_tx_queues, txq[i]);
-               i40evf_fill_virtchnl_vsi_rxq_info(&vc_qpei->rxq,
-                       vc_vqcei->vsi_id, i, dev->data->nb_rx_queues,
-                                       vf->max_pkt_len, rxq[i]);
-               if (i < dev->data->nb_rx_queues)
-                       /*
-                        * It adds extra info for configuring VSI queues, which
-                        * is needed to enable the configurable crc stripping
-                        * in VF.
-                        */
-                       vc_qpei->rxq_ext.crcstrip =
-                               dev->data->dev_conf.rxmode.hw_strip_crc;
-       }
-       memset(&args, 0, sizeof(args));
-       args.ops =
-               (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT;
-       args.in_args = (uint8_t *)vc_vqcei;
-       args.in_args_size = size;
-       args.out_buffer = cmd_result_buffer;
-       args.out_size = I40E_AQ_BUF_SZ;
-       ret = i40evf_execute_vf_cmd(dev, &args);
-       if (ret)
-               PMD_DRV_LOG(ERR, "Failed to execute command of "
-                       "I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT\n");
-
-       return ret;
-}
-
-static int
-i40evf_configure_queues(struct rte_eth_dev *dev)
-{
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               /* To support DPDK PF host */
-               return i40evf_configure_vsi_queues_ext(dev);
-       else
-               /* To support Linux PF host */
-               return i40evf_configure_vsi_queues(dev);
-}
-
 static int
 i40evf_config_irq_map(struct rte_eth_dev *dev)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct vf_cmd_info args;
-       uint8_t cmd_buffer[sizeof(struct i40e_virtchnl_irq_map_info) + \
-               sizeof(struct i40e_virtchnl_vector_map)];
-       struct i40e_virtchnl_irq_map_info *map_info;
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       uint8_t cmd_buffer[sizeof(struct virtchnl_irq_map_info) + \
+               sizeof(struct virtchnl_vector_map)];
+       struct virtchnl_irq_map_info *map_info;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
        uint32_t vector_id;
        int i, err;
 
-       if (rte_intr_allow_others(intr_handle)) {
-               if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-                       vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR;
-               else
-                       vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR_LNX;
-       } else {
+       if (dev->data->dev_conf.intr_conf.rxq != 0 &&
+           rte_intr_allow_others(intr_handle))
+               vector_id = I40E_RX_VEC_START;
+       else
                vector_id = I40E_MISC_VEC_ID;
-       }
 
-       map_info = (struct i40e_virtchnl_irq_map_info *)cmd_buffer;
+       map_info = (struct virtchnl_irq_map_info *)cmd_buffer;
        map_info->num_vectors = 1;
-       map_info->vecmap[0].rxitr_idx = I40E_QINT_RQCTL_MSIX_INDX_NOITR;
+       map_info->vecmap[0].rxitr_idx = I40E_ITR_INDEX_DEFAULT;
        map_info->vecmap[0].vsi_id = vf->vsi_res->vsi_id;
        /* Alway use default dynamic MSIX interrupt */
        map_info->vecmap[0].vector_id = vector_id;
@@ -763,10 +651,10 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
                        intr_handle->intr_vec[i] = vector_id;
        }
 
-       args.ops = I40E_VIRTCHNL_OP_CONFIG_IRQ_MAP;
+       args.ops = VIRTCHNL_OP_CONFIG_IRQ_MAP;
        args.in_args = (u8 *)cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -780,7 +668,7 @@ i40evf_switch_queue(struct rte_eth_dev *dev, bool isrx, uint16_t qid,
                                bool on)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_virtchnl_queue_select queue_select;
+       struct virtchnl_queue_select queue_select;
        int err;
        struct vf_cmd_info args;
        memset(&queue_select, 0, sizeof(queue_select));
@@ -792,12 +680,12 @@ i40evf_switch_queue(struct rte_eth_dev *dev, bool isrx, uint16_t qid,
                queue_select.tx_queues |= 1 << qid;
 
        if (on)
-               args.ops = I40E_VIRTCHNL_OP_ENABLE_QUEUES;
+               args.ops = VIRTCHNL_OP_ENABLE_QUEUES;
        else
-               args.ops = I40E_VIRTCHNL_OP_DISABLE_QUEUES;
+               args.ops = VIRTCHNL_OP_DISABLE_QUEUES;
        args.in_args = (u8 *)&queue_select;
        args.in_args_size = sizeof(queue_select);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -862,60 +750,59 @@ i40evf_stop_queues(struct rte_eth_dev *dev)
        return 0;
 }
 
-static void
+static int
 i40evf_add_mac_addr(struct rte_eth_dev *dev,
                    struct ether_addr *addr,
                    __rte_unused uint32_t index,
                    __rte_unused uint32_t pool)
 {
-       struct i40e_virtchnl_ether_addr_list *list;
+       struct virtchnl_ether_addr_list *list;
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       uint8_t cmd_buffer[sizeof(struct i40e_virtchnl_ether_addr_list) + \
-                       sizeof(struct i40e_virtchnl_ether_addr)];
+       uint8_t cmd_buffer[sizeof(struct virtchnl_ether_addr_list) + \
+                       sizeof(struct virtchnl_ether_addr)];
        int err;
        struct vf_cmd_info args;
 
-       if (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {
+       if (is_zero_ether_addr(addr)) {
                PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
                            addr->addr_bytes[0], addr->addr_bytes[1],
                            addr->addr_bytes[2], addr->addr_bytes[3],
                            addr->addr_bytes[4], addr->addr_bytes[5]);
-               return;
+               return I40E_ERR_INVALID_MAC_ADDR;
        }
 
-       list = (struct i40e_virtchnl_ether_addr_list *)cmd_buffer;
+       list = (struct virtchnl_ether_addr_list *)cmd_buffer;
        list->vsi_id = vf->vsi_res->vsi_id;
        list->num_elements = 1;
-       (void)rte_memcpy(list->list[0].addr, addr->addr_bytes,
+       rte_memcpy(list->list[0].addr, addr->addr_bytes,
                                        sizeof(addr->addr_bytes));
 
-       args.ops = I40E_VIRTCHNL_OP_ADD_ETHER_ADDRESS;
+       args.ops = VIRTCHNL_OP_ADD_ETH_ADDR;
        args.in_args = cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
                PMD_DRV_LOG(ERR, "fail to execute command "
                            "OP_ADD_ETHER_ADDRESS");
+       else
+               vf->vsi.mac_num++;
 
-       return;
+       return err;
 }
 
 static void
-i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)
+i40evf_del_mac_addr_by_addr(struct rte_eth_dev *dev,
+                           struct ether_addr *addr)
 {
-       struct i40e_virtchnl_ether_addr_list *list;
+       struct virtchnl_ether_addr_list *list;
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct rte_eth_dev_data *data = dev->data;
-       struct ether_addr *addr;
-       uint8_t cmd_buffer[sizeof(struct i40e_virtchnl_ether_addr_list) + \
-                       sizeof(struct i40e_virtchnl_ether_addr)];
+       uint8_t cmd_buffer[sizeof(struct virtchnl_ether_addr_list) + \
+                       sizeof(struct virtchnl_ether_addr)];
        int err;
        struct vf_cmd_info args;
 
-       addr = &(data->mac_addrs[index]);
-
        if (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {
                PMD_DRV_LOG(ERR, "Invalid mac:%x-%x-%x-%x-%x-%x",
                            addr->addr_bytes[0], addr->addr_bytes[1],
@@ -924,38 +811,51 @@ i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)
                return;
        }
 
-       list = (struct i40e_virtchnl_ether_addr_list *)cmd_buffer;
+       list = (struct virtchnl_ether_addr_list *)cmd_buffer;
        list->vsi_id = vf->vsi_res->vsi_id;
        list->num_elements = 1;
-       (void)rte_memcpy(list->list[0].addr, addr->addr_bytes,
+       rte_memcpy(list->list[0].addr, addr->addr_bytes,
                        sizeof(addr->addr_bytes));
 
-       args.ops = I40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS;
+       args.ops = VIRTCHNL_OP_DEL_ETH_ADDR;
        args.in_args = cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
                PMD_DRV_LOG(ERR, "fail to execute command "
                            "OP_DEL_ETHER_ADDRESS");
+       else
+               vf->vsi.mac_num--;
        return;
 }
 
+static void
+i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)
+{
+       struct rte_eth_dev_data *data = dev->data;
+       struct ether_addr *addr;
+
+       addr = &data->mac_addrs[index];
+
+       i40evf_del_mac_addr_by_addr(dev, addr);
+}
+
 static int
-i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats)
+i40evf_query_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_virtchnl_queue_select q_stats;
+       struct virtchnl_queue_select q_stats;
        int err;
        struct vf_cmd_info args;
 
        memset(&q_stats, 0, sizeof(q_stats));
        q_stats.vsi_id = vf->vsi_res->vsi_id;
-       args.ops = I40E_VIRTCHNL_OP_GET_STATS;
+       args.ops = VIRTCHNL_OP_GET_STATS;
        args.in_args = (u8 *)&q_stats;
        args.in_args_size = sizeof(q_stats);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -968,62 +868,114 @@ i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats)
        return 0;
 }
 
-static int
-i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
+static void
+i40evf_stat_update_48(uint64_t *offset,
+                  uint64_t *stat)
 {
-       int ret;
-       struct i40e_eth_stats *pstats = NULL;
+       if (*stat >= *offset)
+               *stat = *stat - *offset;
+       else
+               *stat = (uint64_t)((*stat +
+                       ((uint64_t)1 << I40E_48_BIT_WIDTH)) - *offset);
 
-       ret = i40evf_update_stats(dev, &pstats);
-       if (ret != 0)
-               return 0;
+       *stat &= I40E_48_BIT_MASK;
+}
 
-       stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
-                                               pstats->rx_broadcast;
-       stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
-                                               pstats->tx_unicast;
-       stats->ierrors = pstats->rx_discards;
-       stats->oerrors = pstats->tx_errors + pstats->tx_discards;
-       stats->ibytes = pstats->rx_bytes;
-       stats->obytes = pstats->tx_bytes;
+static void
+i40evf_stat_update_32(uint64_t *offset,
+                  uint64_t *stat)
+{
+       if (*stat >= *offset)
+               *stat = (uint64_t)(*stat - *offset);
+       else
+               *stat = (uint64_t)((*stat +
+                       ((uint64_t)1 << I40E_32_BIT_WIDTH)) - *offset);
+}
 
-       return 0;
+static void
+i40evf_update_stats(struct i40e_vsi *vsi,
+                                       struct i40e_eth_stats *nes)
+{
+       struct i40e_eth_stats *oes = &vsi->eth_stats_offset;
+
+       i40evf_stat_update_48(&oes->rx_bytes,
+                           &nes->rx_bytes);
+       i40evf_stat_update_48(&oes->rx_unicast,
+                           &nes->rx_unicast);
+       i40evf_stat_update_48(&oes->rx_multicast,
+                           &nes->rx_multicast);
+       i40evf_stat_update_48(&oes->rx_broadcast,
+                           &nes->rx_broadcast);
+       i40evf_stat_update_32(&oes->rx_discards,
+                               &nes->rx_discards);
+       i40evf_stat_update_32(&oes->rx_unknown_protocol,
+                           &nes->rx_unknown_protocol);
+       i40evf_stat_update_48(&oes->tx_bytes,
+                           &nes->tx_bytes);
+       i40evf_stat_update_48(&oes->tx_unicast,
+                           &nes->tx_unicast);
+       i40evf_stat_update_48(&oes->tx_multicast,
+                           &nes->tx_multicast);
+       i40evf_stat_update_48(&oes->tx_broadcast,
+                           &nes->tx_broadcast);
+       i40evf_stat_update_32(&oes->tx_errors, &nes->tx_errors);
+       i40evf_stat_update_32(&oes->tx_discards, &nes->tx_discards);
 }
 
 static void
 i40evf_dev_xstats_reset(struct rte_eth_dev *dev)
 {
+       int ret;
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_eth_stats *pstats = NULL;
 
        /* read stat values to clear hardware registers */
-       i40evf_update_stats(dev, &pstats);
+       ret = i40evf_query_stats(dev, &pstats);
 
        /* set stats offset base on current values */
-       vf->vsi.eth_stats_offset = vf->vsi.eth_stats;
+       if (ret == 0)
+               vf->vsi.eth_stats_offset = *pstats;
+}
+
+static int i40evf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
+                                     struct rte_eth_xstat_name *xstats_names,
+                                     __rte_unused unsigned limit)
+{
+       unsigned i;
+
+       if (xstats_names != NULL)
+               for (i = 0; i < I40EVF_NB_XSTATS; i++) {
+                       snprintf(xstats_names[i].name,
+                               sizeof(xstats_names[i].name),
+                               "%s", rte_i40evf_stats_strings[i].name);
+               }
+       return I40EVF_NB_XSTATS;
 }
 
 static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,
-                                struct rte_eth_xstats *xstats, unsigned n)
+                                struct rte_eth_xstat *xstats, unsigned n)
 {
        int ret;
        unsigned i;
        struct i40e_eth_stats *pstats = NULL;
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_vsi *vsi = &vf->vsi;
 
        if (n < I40EVF_NB_XSTATS)
                return I40EVF_NB_XSTATS;
 
-       ret = i40evf_update_stats(dev, &pstats);
+       ret = i40evf_query_stats(dev, &pstats);
        if (ret != 0)
                return 0;
 
        if (!xstats)
                return 0;
 
+       i40evf_update_stats(vsi, pstats);
+
        /* loop over xstats array and values from pstats */
        for (i = 0; i < I40EVF_NB_XSTATS; i++) {
-               snprintf(xstats[i].name, sizeof(xstats[i].name),
-                        "%s", rte_i40evf_stats_strings[i].name);
+               xstats[i].id = i;
                xstats[i].value = *(uint64_t *)(((char *)pstats) +
                        rte_i40evf_stats_strings[i].offset);
        }
@@ -1035,21 +987,21 @@ static int
 i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vlanid)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_virtchnl_vlan_filter_list *vlan_list;
-       uint8_t cmd_buffer[sizeof(struct i40e_virtchnl_vlan_filter_list) +
+       struct virtchnl_vlan_filter_list *vlan_list;
+       uint8_t cmd_buffer[sizeof(struct virtchnl_vlan_filter_list) +
                                                        sizeof(uint16_t)];
        int err;
        struct vf_cmd_info args;
 
-       vlan_list = (struct i40e_virtchnl_vlan_filter_list *)cmd_buffer;
+       vlan_list = (struct virtchnl_vlan_filter_list *)cmd_buffer;
        vlan_list->vsi_id = vf->vsi_res->vsi_id;
        vlan_list->num_elements = 1;
        vlan_list->vlan_id[0] = vlanid;
 
-       args.ops = I40E_VIRTCHNL_OP_ADD_VLAN;
+       args.ops = VIRTCHNL_OP_ADD_VLAN;
        args.in_args = (u8 *)&cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -1062,21 +1014,21 @@ static int
 i40evf_del_vlan(struct rte_eth_dev *dev, uint16_t vlanid)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_virtchnl_vlan_filter_list *vlan_list;
-       uint8_t cmd_buffer[sizeof(struct i40e_virtchnl_vlan_filter_list) +
+       struct virtchnl_vlan_filter_list *vlan_list;
+       uint8_t cmd_buffer[sizeof(struct virtchnl_vlan_filter_list) +
                                                        sizeof(uint16_t)];
        int err;
        struct vf_cmd_info args;
 
-       vlan_list = (struct i40e_virtchnl_vlan_filter_list *)cmd_buffer;
+       vlan_list = (struct virtchnl_vlan_filter_list *)cmd_buffer;
        vlan_list->vsi_id = vf->vsi_res->vsi_id;
        vlan_list->num_elements = 1;
        vlan_list->vlan_id[0] = vlanid;
 
-       args.ops = I40E_VIRTCHNL_OP_DEL_VLAN;
+       args.ops = VIRTCHNL_OP_DEL_VLAN;
        args.in_args = (u8 *)&cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -1085,54 +1037,70 @@ i40evf_del_vlan(struct rte_eth_dev *dev, uint16_t vlanid)
        return err;
 }
 
-static int
-i40evf_get_link_status(struct rte_eth_dev *dev, struct rte_eth_link *link)
+static const struct rte_pci_id pci_id_i40evf_map[] = {
+       { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_VF) },
+       { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_VF_HV) },
+       { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_X722_A0_VF) },
+       { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_X722_VF) },
+       { .vendor_id = 0, /* sentinel */ },
+};
+
+/* Disable IRQ0 */
+static inline void
+i40evf_disable_irq0(struct i40e_hw *hw)
 {
-       int err;
-       struct vf_cmd_info args;
-       struct rte_eth_link *new_link;
+       /* Disable all interrupt types */
+       I40E_WRITE_REG(hw, I40E_VFINT_ICR0_ENA1, 0);
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                      I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
+       I40EVF_WRITE_FLUSH(hw);
+}
 
-       args.ops = (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_GET_LINK_STAT;
-       args.in_args = NULL;
-       args.in_args_size = 0;
-       args.out_buffer = cmd_result_buffer;
-       args.out_size = I40E_AQ_BUF_SZ;
-       err = i40evf_execute_vf_cmd(dev, &args);
-       if (err) {
-               PMD_DRV_LOG(ERR, "fail to execute command OP_GET_LINK_STAT");
-               return err;
-       }
+/* Enable IRQ0 */
+static inline void
+i40evf_enable_irq0(struct i40e_hw *hw)
+{
+       /* Enable admin queue interrupt trigger */
+       uint32_t val;
 
-       new_link = (struct rte_eth_link *)args.out_buffer;
-       (void)rte_memcpy(link, new_link, sizeof(*link));
+       i40evf_disable_irq0(hw);
+       val = I40E_READ_REG(hw, I40E_VFINT_ICR0_ENA1);
+       val |= I40E_VFINT_ICR0_ENA1_ADMINQ_MASK |
+               I40E_VFINT_ICR0_ENA1_LINK_STAT_CHANGE_MASK;
+       I40E_WRITE_REG(hw, I40E_VFINT_ICR0_ENA1, val);
 
-       return 0;
-}
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+               I40E_VFINT_DYN_CTL01_INTENA_MASK |
+               I40E_VFINT_DYN_CTL01_CLEARPBA_MASK |
+               I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
 
-static const struct rte_pci_id pci_id_i40evf_map[] = {
-#define RTE_PCI_DEV_ID_DECL_I40EVF(vend, dev) {RTE_PCI_DEVICE(vend, dev)},
-#include "rte_pci_dev_ids.h"
-{ .vendor_id = 0, /* sentinel */ },
-};
+       I40EVF_WRITE_FLUSH(hw);
+}
 
-static inline int
-i40evf_dev_atomic_write_link_status(struct rte_eth_dev *dev,
-                                   struct rte_eth_link *link)
+static int
+i40evf_check_vf_reset_done(struct i40e_hw *hw)
 {
-       struct rte_eth_link *dst = &(dev->data->dev_link);
-       struct rte_eth_link *src = link;
+       int i, reset;
 
-       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
-                                       *(uint64_t *)src) == 0)
+       for (i = 0; i < MAX_RESET_WAIT_CNT; i++) {
+               reset = I40E_READ_REG(hw, I40E_VFGEN_RSTAT) &
+                       I40E_VFGEN_RSTAT_VFR_STATE_MASK;
+               reset = reset >> I40E_VFGEN_RSTAT_VFR_STATE_SHIFT;
+               if (reset == VIRTCHNL_VFR_VFACTIVE ||
+                   reset == VIRTCHNL_VFR_COMPLETED)
+                       break;
+               rte_delay_ms(50);
+       }
+
+       if (i >= MAX_RESET_WAIT_CNT)
                return -1;
 
        return 0;
 }
-
 static int
 i40evf_reset_vf(struct i40e_hw *hw)
 {
-       int i, reset;
+       int ret;
 
        if (i40e_vf_reset(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "Reset VF NIC failed");
@@ -1149,19 +1117,10 @@ i40evf_reset_vf(struct i40e_hw *hw)
          */
        rte_delay_ms(200);
 
-       for (i = 0; i < MAX_RESET_WAIT_CNT; i++) {
-               reset = rd32(hw, I40E_VFGEN_RSTAT) &
-                       I40E_VFGEN_RSTAT_VFR_STATE_MASK;
-               reset = reset >> I40E_VFGEN_RSTAT_VFR_STATE_SHIFT;
-               if (I40E_VFR_COMPLETED == reset || I40E_VFR_VFACTIVE == reset)
-                       break;
-               else
-                       rte_delay_ms(50);
-       }
-
-       if (i >= MAX_RESET_WAIT_CNT) {
-               PMD_INIT_LOG(ERR, "Reset VF NIC failed");
-               return -1;
+       ret = i40evf_check_vf_reset_done(hw);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "VF is still resetting");
+               return ret;
        }
 
        return 0;
@@ -1173,7 +1132,8 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        int i, err, bufsz;
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct ether_addr *p_mac_addr;
+       uint16_t interval =
+               i40e_calc_itr_interval(RTE_LIBRTE_I40E_ITR_INTERVAL, 0, 0);
 
        vf->adapter = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
        vf->dev_data = dev->data;
@@ -1183,6 +1143,10 @@ i40evf_init_vf(struct rte_eth_dev *dev)
                goto err;
        }
 
+       err = i40evf_check_vf_reset_done(hw);
+       if (err)
+               goto err;
+
        i40e_init_adminq_parameter(hw);
        err = i40e_init_adminq(hw);
        if (err) {
@@ -1190,7 +1154,6 @@ i40evf_init_vf(struct rte_eth_dev *dev)
                goto err;
        }
 
-
        /* Reset VF and wait until it's complete */
        if (i40evf_reset_vf(hw)) {
                PMD_INIT_LOG(ERR, "reset NIC failed");
@@ -1200,24 +1163,30 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        /* VF reset, shutdown admin queue and initialize again */
        if (i40e_shutdown_adminq(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "i40e_shutdown_adminq failed");
-               return -1;
+               goto err;
        }
 
        i40e_init_adminq_parameter(hw);
        if (i40e_init_adminq(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "init_adminq failed");
-               return -1;
+               goto err;
+       }
+
+       vf->aq_resp = rte_zmalloc("vf_aq_resp", I40E_AQ_BUF_SZ, 0);
+       if (!vf->aq_resp) {
+               PMD_INIT_LOG(ERR, "unable to allocate vf_aq_resp memory");
+               goto err_aq;
        }
        if (i40evf_check_api_version(dev) != 0) {
                PMD_INIT_LOG(ERR, "check_api version failed");
-               goto err_aq;
+               goto err_api;
        }
-       bufsz = sizeof(struct i40e_virtchnl_vf_resource) +
-               (I40E_MAX_VF_VSI * sizeof(struct i40e_virtchnl_vsi_resource));
+       bufsz = sizeof(struct virtchnl_vf_resource) +
+               (I40E_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource));
        vf->vf_res = rte_zmalloc("vf_res", bufsz, 0);
        if (!vf->vf_res) {
                PMD_INIT_LOG(ERR, "unable to allocate vf_res memory");
-                       goto err_aq;
+               goto err_api;
        }
 
        if (i40evf_get_vf_resource(dev) != 0) {
@@ -1227,7 +1196,7 @@ i40evf_init_vf(struct rte_eth_dev *dev)
 
        /* got VF config message back from PF, now we can parse it */
        for (i = 0; i < vf->vf_res->num_vsis; i++) {
-               if (vf->vf_res->vsi_res[i].vsi_type == I40E_VSI_SRIOV)
+               if (vf->vf_res->vsi_res[i].vsi_type == VIRTCHNL_VSI_SRIOV)
                        vf->vsi_res = &vf->vf_res->vsi_res[i];
        }
 
@@ -1239,21 +1208,38 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        if (hw->mac.type == I40E_MAC_X722_VF)
                vf->flags = I40E_FLAG_RSS_AQ_CAPABLE;
        vf->vsi.vsi_id = vf->vsi_res->vsi_id;
-       vf->vsi.type = vf->vsi_res->vsi_type;
+
+       switch (vf->vsi_res->vsi_type) {
+       case VIRTCHNL_VSI_SRIOV:
+               vf->vsi.type = I40E_VSI_SRIOV;
+               break;
+       default:
+               vf->vsi.type = I40E_VSI_TYPE_UNKNOWN;
+               break;
+       }
        vf->vsi.nb_qps = vf->vsi_res->num_queue_pairs;
        vf->vsi.adapter = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
 
        /* Store the MAC address configured by host, or generate random one */
-       p_mac_addr = (struct ether_addr *)(vf->vsi_res->default_mac_addr);
-       if (is_valid_assigned_ether_addr(p_mac_addr)) /* Configured by host */
-               ether_addr_copy(p_mac_addr, (struct ether_addr *)hw->mac.addr);
+       if (is_valid_assigned_ether_addr((struct ether_addr *)hw->mac.addr))
+               vf->flags |= I40E_FLAG_VF_MAC_BY_PF;
        else
                eth_random_addr(hw->mac.addr); /* Generate a random one */
 
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                      (I40E_ITR_INDEX_DEFAULT <<
+                       I40E_VFINT_DYN_CTL0_ITR_INDX_SHIFT) |
+                      (interval <<
+                       I40E_VFINT_DYN_CTL0_INTERVAL_SHIFT));
+       I40EVF_WRITE_FLUSH(hw);
+
        return 0;
 
 err_alloc:
        rte_free(vf->vf_res);
+       vf->vsi_res = NULL;
+err_api:
+       rte_free(vf->aq_resp);
 err_aq:
        i40e_shutdown_adminq(hw); /* ignore error */
 err:
@@ -1272,15 +1258,155 @@ i40evf_uninit_vf(struct rte_eth_dev *dev)
                i40evf_dev_close(dev);
        rte_free(vf->vf_res);
        vf->vf_res = NULL;
+       rte_free(vf->aq_resp);
+       vf->aq_resp = NULL;
 
        return 0;
 }
 
+static void
+i40evf_handle_pf_event(struct rte_eth_dev *dev, uint8_t *msg,
+               __rte_unused uint16_t msglen)
+{
+       struct virtchnl_pf_event *pf_msg =
+                       (struct virtchnl_pf_event *)msg;
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+
+       switch (pf_msg->event) {
+       case VIRTCHNL_EVENT_RESET_IMPENDING:
+               PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event");
+               _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET,
+                                             NULL);
+               break;
+       case VIRTCHNL_EVENT_LINK_CHANGE:
+               PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event");
+               vf->link_up = pf_msg->event_data.link_event.link_status;
+               vf->link_speed = pf_msg->event_data.link_event.link_speed;
+               break;
+       case VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
+               PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_PF_DRIVER_CLOSE event");
+               break;
+       default:
+               PMD_DRV_LOG(ERR, " unknown event received %u", pf_msg->event);
+               break;
+       }
+}
+
+static void
+i40evf_handle_aq_msg(struct rte_eth_dev *dev)
+{
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_arq_event_info info;
+       uint16_t pending, aq_opc;
+       enum virtchnl_ops msg_opc;
+       enum i40e_status_code msg_ret;
+       int ret;
+
+       info.buf_len = I40E_AQ_BUF_SZ;
+       if (!vf->aq_resp) {
+               PMD_DRV_LOG(ERR, "Buffer for adminq resp should not be NULL");
+               return;
+       }
+       info.msg_buf = vf->aq_resp;
+
+       pending = 1;
+       while (pending) {
+               ret = i40e_clean_arq_element(hw, &info, &pending);
+
+               if (ret != I40E_SUCCESS) {
+                       PMD_DRV_LOG(INFO, "Failed to read msg from AdminQ,"
+                                   "ret: %d", ret);
+                       break;
+               }
+               aq_opc = rte_le_to_cpu_16(info.desc.opcode);
+               /* For the message sent from pf to vf, opcode is stored in
+                * cookie_high of struct i40e_aq_desc, while return error code
+                * are stored in cookie_low, Which is done by
+                * i40e_aq_send_msg_to_vf in PF driver.*/
+               msg_opc = (enum virtchnl_ops)rte_le_to_cpu_32(
+                                                 info.desc.cookie_high);
+               msg_ret = (enum i40e_status_code)rte_le_to_cpu_32(
+                                                 info.desc.cookie_low);
+               switch (aq_opc) {
+               case i40e_aqc_opc_send_msg_to_vf:
+                       if (msg_opc == VIRTCHNL_OP_EVENT)
+                               /* process event*/
+                               i40evf_handle_pf_event(dev, info.msg_buf,
+                                                      info.msg_len);
+                       else {
+                               /* read message and it's expected one */
+                               if (msg_opc == vf->pend_cmd) {
+                                       vf->cmd_retval = msg_ret;
+                                       /* prevent compiler reordering */
+                                       rte_compiler_barrier();
+                                       _clear_cmd(vf);
+                               } else
+                                       PMD_DRV_LOG(ERR, "command mismatch,"
+                                               "expect %u, get %u",
+                                               vf->pend_cmd, msg_opc);
+                               PMD_DRV_LOG(DEBUG, "adminq response is received,"
+                                            " opcode = %d", msg_opc);
+                       }
+                       break;
+               default:
+                       PMD_DRV_LOG(ERR, "Request %u is not supported yet",
+                                   aq_opc);
+                       break;
+               }
+       }
+}
+
+/**
+ * Interrupt handler triggered by NIC  for handling
+ * specific interrupt. Only adminq interrupt is processed in VF.
+ *
+ * @param handle
+ *  Pointer to interrupt handle.
+ * @param param
+ *  The address of parameter (struct rte_eth_dev *) regsitered before.
+ *
+ * @return
+ *  void
+ */
+static void
+i40evf_dev_interrupt_handler(void *param)
+{
+       struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint32_t icr0;
+
+       i40evf_disable_irq0(hw);
+
+       /* read out interrupt causes */
+       icr0 = I40E_READ_REG(hw, I40E_VFINT_ICR01);
+
+       /* No interrupt event indicated */
+       if (!(icr0 & I40E_VFINT_ICR01_INTEVENT_MASK)) {
+               PMD_DRV_LOG(DEBUG, "No interrupt event, nothing to do");
+               goto done;
+       }
+
+       if (icr0 & I40E_VFINT_ICR01_ADMINQ_MASK) {
+               PMD_DRV_LOG(DEBUG, "ICR01_ADMINQ is reported");
+               i40evf_handle_aq_msg(dev);
+       }
+
+       /* Link Status Change interrupt */
+       if (icr0 & I40E_VFINT_ICR01_LINK_STAT_CHANGE_MASK)
+               PMD_DRV_LOG(DEBUG, "LINK_STAT_CHANGE is reported,"
+                                  " do nothing");
+
+done:
+       i40evf_enable_irq0(hw);
+}
+
 static int
 i40evf_dev_init(struct rte_eth_dev *eth_dev)
 {
-       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(\
-                       eth_dev->data->dev_private);
+       struct i40e_hw *hw
+               = I40E_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1298,16 +1424,17 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)
                i40e_set_tx_function(eth_dev);
                return 0;
        }
-
-       rte_eth_copy_pci_info(eth_dev, eth_dev->pci_dev);
-
-       hw->vendor_id = eth_dev->pci_dev->id.vendor_id;
-       hw->device_id = eth_dev->pci_dev->id.device_id;
-       hw->subsystem_vendor_id = eth_dev->pci_dev->id.subsystem_vendor_id;
-       hw->subsystem_device_id = eth_dev->pci_dev->id.subsystem_device_id;
-       hw->bus.device = eth_dev->pci_dev->addr.devid;
-       hw->bus.func = eth_dev->pci_dev->addr.function;
-       hw->hw_addr = (void *)eth_dev->pci_dev->mem_resource[0].addr;
+       i40e_set_default_ptype_table(eth_dev);
+       i40e_set_default_pctype_table(eth_dev);
+       rte_eth_copy_pci_info(eth_dev, pci_dev);
+
+       hw->vendor_id = pci_dev->id.vendor_id;
+       hw->device_id = pci_dev->id.device_id;
+       hw->subsystem_vendor_id = pci_dev->id.subsystem_vendor_id;
+       hw->subsystem_device_id = pci_dev->id.subsystem_device_id;
+       hw->bus.device = pci_dev->addr.devid;
+       hw->bus.func = pci_dev->addr.function;
+       hw->hw_addr = (void *)pci_dev->mem_resource[0].addr;
        hw->adapter_stopped = 0;
 
        if(i40evf_init_vf(eth_dev) != 0) {
@@ -1315,7 +1442,17 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)
                return -1;
        }
 
-       /* allocate memory for mac addr storage */
+       /* register callback func to eal lib */
+       rte_intr_callback_register(&pci_dev->intr_handle,
+               i40evf_dev_interrupt_handler, (void *)eth_dev);
+
+       /* enable uio intr after callback register */
+       rte_intr_enable(&pci_dev->intr_handle);
+
+       /* configure and enable device interrupt */
+       i40evf_enable_irq0(hw);
+
+       /* copy mac addr */
        eth_dev->data->mac_addrs = rte_zmalloc("i40evf_mac",
                                        ETHER_ADDR_LEN * I40E_NUM_MACADDR_MAX,
                                        0);
@@ -1353,48 +1490,40 @@ i40evf_dev_uninit(struct rte_eth_dev *eth_dev)
 
        return 0;
 }
-/*
- * virtual function driver struct
- */
-static struct eth_driver rte_i40evf_pmd = {
-       .pci_drv = {
-               .name = "rte_i40evf_pmd",
-               .id_table = pci_id_i40evf_map,
-               .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,
-       },
-       .eth_dev_init = i40evf_dev_init,
-       .eth_dev_uninit = i40evf_dev_uninit,
-       .dev_private_size = sizeof(struct i40e_adapter),
-};
 
-/*
- * VF Driver initialization routine.
- * Invoked one at EAL init time.
- * Register itself as the [Virtual Poll Mode] Driver of PCI Fortville devices.
- */
-static int
-rte_i40evf_pmd_init(const char *name __rte_unused,
-                   const char *params __rte_unused)
+static int eth_i40evf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
+       struct rte_pci_device *pci_dev)
 {
-       PMD_INIT_FUNC_TRACE();
-
-       rte_eth_driver_register(&rte_i40evf_pmd);
+       return rte_eth_dev_pci_generic_probe(pci_dev,
+               sizeof(struct i40e_adapter), i40evf_dev_init);
+}
 
-       return 0;
+static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
+{
+       return rte_eth_dev_pci_generic_remove(pci_dev, i40evf_dev_uninit);
 }
 
-static struct rte_driver rte_i40evf_driver = {
-       .type = PMD_PDEV,
-       .init = rte_i40evf_pmd_init,
+/*
+ * virtual function driver struct
+ */
+static struct rte_pci_driver rte_i40evf_pmd = {
+       .id_table = pci_id_i40evf_map,
+       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,
+       .probe = eth_i40evf_pci_probe,
+       .remove = eth_i40evf_pci_remove,
 };
 
-PMD_REGISTER_DRIVER(rte_i40evf_driver);
+RTE_PMD_REGISTER_PCI(net_i40e_vf, rte_i40evf_pmd);
+RTE_PMD_REGISTER_PCI_TABLE(net_i40e_vf, pci_id_i40evf_map);
+RTE_PMD_REGISTER_KMOD_DEP(net_i40e_vf, "* igb_uio | vfio-pci");
 
 static int
 i40evf_dev_configure(struct rte_eth_dev *dev)
 {
        struct i40e_adapter *ad =
                I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+       struct rte_eth_conf *conf = &dev->data->dev_conf;
+       struct i40e_vf *vf;
 
        /* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
         * allocation or vector Rx preconditions we will reset it.
@@ -1404,67 +1533,47 @@ i40evf_dev_configure(struct rte_eth_dev *dev)
        ad->tx_simple_allowed = true;
        ad->tx_vec_allowed = true;
 
+       /* For non-DPDK PF drivers, VF has no ability to disable HW
+        * CRC strip, and is implicitly enabled by the PF.
+        */
+       if (!conf->rxmode.hw_strip_crc) {
+               vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+               if ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&
+                   (vf->version_minor <= VIRTCHNL_VERSION_MINOR)) {
+                       /* Peer is running non-DPDK PF driver. */
+                       PMD_INIT_LOG(ERR, "VF can't disable HW CRC Strip");
+                       return -EINVAL;
+               }
+       }
+
        return i40evf_init_vlan(dev);
 }
 
 static int
 i40evf_init_vlan(struct rte_eth_dev *dev)
 {
-       struct rte_eth_dev_data *data = dev->data;
-       int ret;
-
        /* Apply vlan offload setting */
        i40evf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK);
 
-       /* Apply pvid setting */
-       ret = i40evf_vlan_pvid_set(dev, data->dev_conf.txmode.pvid,
-                               data->dev_conf.txmode.hw_vlan_insert_pvid);
-       return ret;
+       return 0;
 }
 
-static void
+static int
 i40evf_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 {
-       bool enable_vlan_strip = 0;
        struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-       /* Linux pf host doesn't support vlan offload yet */
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR) {
-               /* Vlan stripping setting */
-               if (mask & ETH_VLAN_STRIP_MASK) {
-                       /* Enable or disable VLAN stripping */
-                       if (dev_conf->rxmode.hw_vlan_strip)
-                               enable_vlan_strip = 1;
-                       else
-                               enable_vlan_strip = 0;
-
-                       i40evf_config_vlan_offload(dev, enable_vlan_strip);
-               }
-       }
-}
-
-static int
-i40evf_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t pvid, int on)
-{
-       struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
-       struct i40e_vsi_vlan_pvid_info info;
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN))
+               return -ENOTSUP;
 
-       memset(&info, 0, sizeof(info));
-       info.on = on;
-
-       /* Linux pf host don't support vlan offload yet */
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR) {
-               if (info.on)
-                       info.config.pvid = pvid;
-               else {
-                       info.config.reject.tagged =
-                               dev_conf->txmode.hw_vlan_reject_tagged;
-                       info.config.reject.untagged =
-                               dev_conf->txmode.hw_vlan_reject_untagged;
-               }
-               return i40evf_config_vlan_pvid(dev, &info);
+       /* Vlan stripping setting */
+       if (mask & ETH_VLAN_STRIP_MASK) {
+               /* Enable or disable VLAN stripping */
+               if (dev_conf->rxmode.hw_vlan_strip)
+                       i40evf_enable_vlan_strip(dev);
+               else
+                       i40evf_disable_vlan_strip(dev);
        }
 
        return 0;
@@ -1686,65 +1795,48 @@ i40evf_tx_init(struct rte_eth_dev *dev)
 static inline void
 i40evf_enable_queues_intr(struct rte_eth_dev *dev)
 {
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
 
        if (!rte_intr_allow_others(intr_handle)) {
                I40E_WRITE_REG(hw,
                               I40E_VFINT_DYN_CTL01,
                               I40E_VFINT_DYN_CTL01_INTENA_MASK |
-                              I40E_VFINT_DYN_CTL01_CLEARPBA_MASK);
+                              I40E_VFINT_DYN_CTL01_CLEARPBA_MASK |
+                              I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
                I40EVF_WRITE_FLUSH(hw);
                return;
        }
 
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               /* To support DPDK PF host */
-               I40E_WRITE_REG(hw,
-                       I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR - 1),
-                       I40E_VFINT_DYN_CTLN1_INTENA_MASK |
-                       I40E_VFINT_DYN_CTLN_CLEARPBA_MASK);
-       else
-               /* To support Linux PF host */
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
-                               I40E_VFINT_DYN_CTL01_INTENA_MASK |
-                               I40E_VFINT_DYN_CTL01_CLEARPBA_MASK);
-
        I40EVF_WRITE_FLUSH(hw);
 }
 
 static inline void
 i40evf_disable_queues_intr(struct rte_eth_dev *dev)
 {
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
 
        if (!rte_intr_allow_others(intr_handle)) {
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01, 0);
+               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                              I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
                I40EVF_WRITE_FLUSH(hw);
                return;
        }
 
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               I40E_WRITE_REG(hw,
-                              I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR
-                                                   - 1),
-                              0);
-       else
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01, 0);
-
        I40EVF_WRITE_FLUSH(hw);
 }
 
 static int
 i40evf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        uint16_t interval =
-               i40e_calc_itr_interval(RTE_LIBRTE_I40E_ITR_INTERVAL);
+               i40e_calc_itr_interval(RTE_LIBRTE_I40E_ITR_INTERVAL, 0, 0);
        uint16_t msix_intr;
 
        msix_intr = intr_handle->intr_vec[queue_id];
@@ -1767,7 +1859,7 @@ i40evf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 
        I40EVF_WRITE_FLUSH(hw);
 
-       rte_intr_enable(&dev->pci_dev->intr_handle);
+       rte_intr_enable(&pci_dev->intr_handle);
 
        return 0;
 }
@@ -1775,7 +1867,8 @@ i40evf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 static int
 i40evf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        uint16_t msix_intr;
 
@@ -1796,7 +1889,7 @@ i40evf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)
 static void
 i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
 {
-       struct i40e_virtchnl_ether_addr_list *list;
+       struct virtchnl_ether_addr_list *list;
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        int err, i, j;
        int next_begin = 0;
@@ -1807,11 +1900,11 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
 
        do {
                j = 0;
-               len = sizeof(struct i40e_virtchnl_ether_addr_list);
+               len = sizeof(struct virtchnl_ether_addr_list);
                for (i = begin; i < I40E_NUM_MACADDR_MAX; i++, next_begin++) {
                        if (is_zero_ether_addr(&dev->data->mac_addrs[i]))
                                continue;
-                       len += sizeof(struct i40e_virtchnl_ether_addr);
+                       len += sizeof(struct virtchnl_ether_addr);
                        if (len >= I40E_AQ_BUF_SZ) {
                                next_begin = i + 1;
                                break;
@@ -1819,12 +1912,16 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
                }
 
                list = rte_zmalloc("i40evf_del_mac_buffer", len, 0);
+               if (!list) {
+                       PMD_DRV_LOG(ERR, "fail to allocate memory");
+                       return;
+               }
 
                for (i = begin; i < next_begin; i++) {
                        addr = &dev->data->mac_addrs[i];
                        if (is_zero_ether_addr(addr))
                                continue;
-                       (void)rte_memcpy(list->list[j].addr, addr->addr_bytes,
+                       rte_memcpy(list->list[j].addr, addr->addr_bytes,
                                         sizeof(addr->addr_bytes));
                        PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
                                    addr->addr_bytes[0], addr->addr_bytes[1],
@@ -1834,17 +1931,23 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
                }
                list->vsi_id = vf->vsi_res->vsi_id;
                list->num_elements = j;
-               args.ops = add ? I40E_VIRTCHNL_OP_ADD_ETHER_ADDRESS :
-                          I40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS;
+               args.ops = add ? VIRTCHNL_OP_ADD_ETH_ADDR :
+                          VIRTCHNL_OP_DEL_ETH_ADDR;
                args.in_args = (uint8_t *)list;
                args.in_args_size = len;
-               args.out_buffer = cmd_result_buffer;
+               args.out_buffer = vf->aq_resp;
                args.out_size = I40E_AQ_BUF_SZ;
                err = i40evf_execute_vf_cmd(dev, &args);
-               if (err)
+               if (err) {
                        PMD_DRV_LOG(ERR, "fail to execute command %s",
                                    add ? "OP_ADD_ETHER_ADDRESS" :
                                    "OP_DEL_ETHER_ADDRESS");
+               } else {
+                       if (add)
+                               vf->vsi.mac_num++;
+                       else
+                               vf->vsi.mac_num--;
+               }
                rte_free(list);
                begin = next_begin;
        } while (begin < I40E_NUM_MACADDR_MAX);
@@ -1855,7 +1958,8 @@ i40evf_dev_start(struct rte_eth_dev *dev)
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
        uint32_t intr_vector = 0;
 
        PMD_INIT_FUNC_TRACE();
@@ -1867,7 +1971,8 @@ i40evf_dev_start(struct rte_eth_dev *dev)
                                        dev->data->nb_tx_queues);
 
        /* check and configure queue intr-vector mapping */
-       if (dev->data->dev_conf.intr_conf.rxq != 0) {
+       if (rte_intr_cap_multiple(intr_handle) &&
+           dev->data->dev_conf.intr_conf.rxq) {
                intr_vector = dev->data->nb_rx_queues;
                if (rte_intr_efd_enable(intr_handle, intr_vector))
                        return -1;
@@ -1879,7 +1984,7 @@ i40evf_dev_start(struct rte_eth_dev *dev)
                                    dev->data->nb_rx_queues * sizeof(int), 0);
                if (!intr_handle->intr_vec) {
                        PMD_INIT_LOG(ERR, "Failed to allocate %d rx_queues"
-                                    " intr_vec\n", dev->data->nb_rx_queues);
+                                    " intr_vec", dev->data->nb_rx_queues);
                        return -ENOMEM;
                }
        }
@@ -1891,7 +1996,7 @@ i40evf_dev_start(struct rte_eth_dev *dev)
 
        i40evf_tx_init(dev);
 
-       if (i40evf_configure_queues(dev) != 0) {
+       if (i40evf_configure_vsi_queues(dev) != 0) {
                PMD_DRV_LOG(ERR, "configure queues failed");
                goto err_queue;
        }
@@ -1902,21 +2007,35 @@ i40evf_dev_start(struct rte_eth_dev *dev)
 
        /* Set all mac addrs */
        i40evf_add_del_all_mac_addr(dev, TRUE);
+       /* Set all multicast addresses */
+       i40evf_add_del_mc_addr_list(dev, vf->mc_addrs, vf->mc_addrs_num,
+                               TRUE);
 
        if (i40evf_start_queues(dev) != 0) {
                PMD_DRV_LOG(ERR, "enable queues failed");
                goto err_mac;
        }
 
-       /* vf don't allow intr except for rxq intr */
-       if (dev->data->dev_conf.intr_conf.rxq != 0)
+       /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt
+        * is mapped to VFIO vector 0 in i40evf_dev_init( ).
+        * If previous VFIO interrupt mapping set in i40evf_dev_init( ) is
+        * not cleared, it will fail when rte_intr_enable( ) tries to map Rx
+        * queue interrupt to other VFIO vectors.
+        * So clear uio/vfio intr/evevnfd first to avoid failure.
+        */
+       if (dev->data->dev_conf.intr_conf.rxq != 0) {
+               rte_intr_disable(intr_handle);
                rte_intr_enable(intr_handle);
+       }
 
        i40evf_enable_queues_intr(dev);
+
        return 0;
 
 err_mac:
        i40evf_add_del_all_mac_addr(dev, FALSE);
+       i40evf_add_del_mc_addr_list(dev, vf->mc_addrs, vf->mc_addrs_num,
+                               FALSE);
 err_queue:
        return -1;
 }
@@ -1924,10 +2043,15 @@ err_queue:
 static void
 i40evf_dev_stop(struct rte_eth_dev *dev)
 {
-       struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
        PMD_INIT_FUNC_TRACE();
 
+       if (hw->adapter_stopped == 1)
+               return;
        i40evf_stop_queues(dev);
        i40evf_disable_queues_intr(dev);
        i40e_dev_clear_queues(dev);
@@ -1940,6 +2064,10 @@ i40evf_dev_stop(struct rte_eth_dev *dev)
        }
        /* remove all mac addrs */
        i40evf_add_del_all_mac_addr(dev, FALSE);
+       /* remove all multicast addresses */
+       i40evf_add_del_mc_addr_list(dev, vf->mc_addrs, vf->mc_addrs_num,
+                               FALSE);
+       hw->adapter_stopped = 1;
 
 }
 
@@ -1953,17 +2081,40 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,
         * DPDK pf host provide interfacet to acquire link status
         * while Linux driver does not
         */
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               i40evf_get_link_status(dev, &new_link);
-       else {
-               /* Always assume it's up, for Linux driver PF host */
-               new_link.link_duplex = ETH_LINK_AUTONEG_DUPLEX;
-               new_link.link_speed  = ETH_LINK_SPEED_10000;
-               new_link.link_status = 1;
-       }
-       i40evf_dev_atomic_write_link_status(dev, &new_link);
 
-       return 0;
+       memset(&new_link, 0, sizeof(new_link));
+       /* Linux driver PF host */
+       switch (vf->link_speed) {
+       case I40E_LINK_SPEED_100MB:
+               new_link.link_speed = ETH_SPEED_NUM_100M;
+               break;
+       case I40E_LINK_SPEED_1GB:
+               new_link.link_speed = ETH_SPEED_NUM_1G;
+               break;
+       case I40E_LINK_SPEED_10GB:
+               new_link.link_speed = ETH_SPEED_NUM_10G;
+               break;
+       case I40E_LINK_SPEED_20GB:
+               new_link.link_speed = ETH_SPEED_NUM_20G;
+               break;
+       case I40E_LINK_SPEED_25GB:
+               new_link.link_speed = ETH_SPEED_NUM_25G;
+               break;
+       case I40E_LINK_SPEED_40GB:
+               new_link.link_speed = ETH_SPEED_NUM_40G;
+               break;
+       default:
+               new_link.link_speed = ETH_SPEED_NUM_100M;
+               break;
+       }
+       /* full duplex only */
+       new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
+       new_link.link_status = vf->link_up ? ETH_LINK_UP :
+                                            ETH_LINK_DOWN;
+       new_link.link_autoneg =
+               dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED;
+
+       return rte_eth_linkstatus_set(dev, &new_link);
 }
 
 static void
@@ -2032,27 +2183,36 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
        memset(dev_info, 0, sizeof(*dev_info));
+       dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
        dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
        dev_info->min_rx_bufsize = I40E_BUF_SIZE_MIN;
        dev_info->max_rx_pktlen = I40E_FRAME_SIZE_MAX;
        dev_info->hash_key_size = (I40E_VFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t);
        dev_info->reta_size = ETH_RSS_RETA_SIZE_64;
-       dev_info->flow_type_rss_offloads = I40E_RSS_OFFLOAD_ALL;
+       dev_info->flow_type_rss_offloads = vf->adapter->flow_types_mask;
        dev_info->max_mac_addrs = I40E_NUM_MACADDR_MAX;
        dev_info->rx_offload_capa =
                DEV_RX_OFFLOAD_VLAN_STRIP |
                DEV_RX_OFFLOAD_QINQ_STRIP |
                DEV_RX_OFFLOAD_IPV4_CKSUM |
                DEV_RX_OFFLOAD_UDP_CKSUM |
-               DEV_RX_OFFLOAD_TCP_CKSUM;
+               DEV_RX_OFFLOAD_TCP_CKSUM |
+               DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+               DEV_RX_OFFLOAD_CRC_STRIP;
        dev_info->tx_offload_capa =
                DEV_TX_OFFLOAD_VLAN_INSERT |
                DEV_TX_OFFLOAD_QINQ_INSERT |
                DEV_TX_OFFLOAD_IPV4_CKSUM |
                DEV_TX_OFFLOAD_UDP_CKSUM |
                DEV_TX_OFFLOAD_TCP_CKSUM |
-               DEV_TX_OFFLOAD_SCTP_CKSUM;
+               DEV_TX_OFFLOAD_SCTP_CKSUM |
+               DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+               DEV_TX_OFFLOAD_TCP_TSO |
+               DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
+               DEV_TX_OFFLOAD_GRE_TNL_TSO |
+               DEV_TX_OFFLOAD_IPIP_TNL_TSO |
+               DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
 
        dev_info->default_rxconf = (struct rte_eth_rxconf) {
                .rx_thresh = {
@@ -2089,23 +2249,67 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        };
 }
 
-static void
+static int
 i40evf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-       if (i40evf_get_statics(dev, stats))
-               PMD_DRV_LOG(ERR, "Get statics failed");
+       int ret;
+       struct i40e_eth_stats *pstats = NULL;
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_vsi *vsi = &vf->vsi;
+
+       ret = i40evf_query_stats(dev, &pstats);
+       if (ret == 0) {
+               i40evf_update_stats(vsi, pstats);
+
+               stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
+                                               pstats->rx_broadcast;
+               stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
+                                               pstats->tx_unicast;
+               stats->imissed = pstats->rx_discards;
+               stats->oerrors = pstats->tx_errors + pstats->tx_discards;
+               stats->ibytes = pstats->rx_bytes;
+               stats->obytes = pstats->tx_bytes;
+       } else {
+               PMD_DRV_LOG(ERR, "Get statistics failed");
+       }
+       return ret;
 }
 
 static void
 i40evf_dev_close(struct rte_eth_dev *dev)
 {
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
 
        i40evf_dev_stop(dev);
-       hw->adapter_stopped = 1;
        i40e_dev_free_queues(dev);
        i40evf_reset_vf(hw);
        i40e_shutdown_adminq(hw);
+       /* disable uio intr before callback unregister */
+       rte_intr_disable(intr_handle);
+
+       /* unregister callback func from eal lib */
+       rte_intr_callback_unregister(intr_handle,
+                                    i40evf_dev_interrupt_handler, dev);
+       i40evf_disable_irq0(hw);
+}
+
+/*
+ * Reset VF device only to re-initialize resources in PMD layer
+ */
+static int
+i40evf_dev_reset(struct rte_eth_dev *dev)
+{
+       int ret;
+
+       ret = i40evf_dev_uninit(dev);
+       if (ret)
+               return ret;
+
+       ret = i40evf_dev_init(dev);
+
+       return ret;
 }
 
 static int
@@ -2139,13 +2343,16 @@ i40evf_get_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size)
 static int
 i40evf_set_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size)
 {
-       struct i40e_vf *vf = I40E_VSI_TO_VF(vsi);
-       struct i40e_hw *hw = I40E_VSI_TO_HW(vsi);
+       struct i40e_vf *vf;
+       struct i40e_hw *hw;
        int ret;
 
        if (!vsi || !lut)
                return -EINVAL;
 
+       vf = I40E_VSI_TO_VF(vsi);
+       hw = I40E_VSI_TO_HW(vsi);
+
        if (vf->flags & I40E_FLAG_RSS_AQ_CAPABLE) {
                ret = i40e_aq_set_rss_lut(hw, vsi->vsi_id, FALSE,
                                          lut, lut_size);
@@ -2178,7 +2385,7 @@ i40evf_dev_rss_reta_update(struct rte_eth_dev *dev,
        if (reta_size != ETH_RSS_RETA_SIZE_64) {
                PMD_DRV_LOG(ERR, "The size of hash lookup table configured "
                        "(%d) doesn't match the number of hardware can "
-                       "support (%d)\n", reta_size, ETH_RSS_RETA_SIZE_64);
+                       "support (%d)", reta_size, ETH_RSS_RETA_SIZE_64);
                return -EINVAL;
        }
 
@@ -2217,7 +2424,7 @@ i40evf_dev_rss_reta_query(struct rte_eth_dev *dev,
        if (reta_size != ETH_RSS_RETA_SIZE_64) {
                PMD_DRV_LOG(ERR, "The size of hash lookup table configured "
                        "(%d) doesn't match the number of hardware can "
-                       "support (%d)\n", reta_size, ETH_RSS_RETA_SIZE_64);
+                       "support (%d)", reta_size, ETH_RSS_RETA_SIZE_64);
                return -EINVAL;
        }
 
@@ -2312,7 +2519,7 @@ static int
 i40evf_hw_rss_hash_set(struct i40e_vf *vf, struct rte_eth_rss_conf *rss_conf)
 {
        struct i40e_hw *hw = I40E_VF_TO_HW(vf);
-       uint64_t rss_hf, hena;
+       uint64_t hena;
        int ret;
 
        ret = i40evf_set_rss_key(&vf->vsi, rss_conf->rss_key,
@@ -2320,11 +2527,7 @@ i40evf_hw_rss_hash_set(struct i40e_vf *vf, struct rte_eth_rss_conf *rss_conf)
        if (ret)
                return ret;
 
-       rss_hf = rss_conf->rss_hf;
-       hena = (uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(0));
-       hena |= ((uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(1))) << 32;
-       hena &= ~I40E_RSS_HENA_ALL;
-       hena |= i40e_config_hena(rss_hf);
+       hena = i40e_config_hena(vf->adapter, rss_conf->rss_hf);
        i40e_write_rx_ctl(hw, I40E_VFQF_HENA(0), (uint32_t)hena);
        i40e_write_rx_ctl(hw, I40E_VFQF_HENA(1), (uint32_t)(hena >> 32));
        I40EVF_WRITE_FLUSH(hw);
@@ -2336,13 +2539,9 @@ static void
 i40evf_disable_rss(struct i40e_vf *vf)
 {
        struct i40e_hw *hw = I40E_VF_TO_HW(vf);
-       uint64_t hena;
 
-       hena = (uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(0));
-       hena |= ((uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(1))) << 32;
-       hena &= ~I40E_RSS_HENA_ALL;
-       i40e_write_rx_ctl(hw, I40E_VFQF_HENA(0), (uint32_t)hena);
-       i40e_write_rx_ctl(hw, I40E_VFQF_HENA(1), (uint32_t)(hena >> 32));
+       i40e_write_rx_ctl(hw, I40E_VFQF_HENA(0), 0);
+       i40e_write_rx_ctl(hw, I40E_VFQF_HENA(1), 0);
        I40EVF_WRITE_FLUSH(hw);
 }
 
@@ -2356,7 +2555,7 @@ i40evf_config_rss(struct i40e_vf *vf)
 
        if (vf->dev_data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {
                i40evf_disable_rss(vf);
-               PMD_DRV_LOG(DEBUG, "RSS not configured\n");
+               PMD_DRV_LOG(DEBUG, "RSS not configured");
                return 0;
        }
 
@@ -2371,9 +2570,9 @@ i40evf_config_rss(struct i40e_vf *vf)
        }
 
        rss_conf = vf->dev_data->dev_conf.rx_adv_conf.rss_conf;
-       if ((rss_conf.rss_hf & I40E_RSS_OFFLOAD_ALL) == 0) {
+       if ((rss_conf.rss_hf & vf->adapter->flow_types_mask) == 0) {
                i40evf_disable_rss(vf);
-               PMD_DRV_LOG(DEBUG, "No hash flag is set\n");
+               PMD_DRV_LOG(DEBUG, "No hash flag is set");
                return 0;
        }
 
@@ -2396,12 +2595,13 @@ i40evf_dev_rss_hash_update(struct rte_eth_dev *dev,
 {
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint64_t rss_hf = rss_conf->rss_hf & I40E_RSS_OFFLOAD_ALL;
+       uint64_t rss_hf = rss_conf->rss_hf & vf->adapter->flow_types_mask;
        uint64_t hena;
 
        hena = (uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(0));
        hena |= ((uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(1))) << 32;
-       if (!(hena & I40E_RSS_HENA_ALL)) { /* RSS disabled */
+
+       if (!(hena & vf->adapter->pctypes_mask)) { /* RSS disabled */
                if (rss_hf != 0) /* Enable RSS */
                        return -EINVAL;
                return 0;
@@ -2427,7 +2627,140 @@ i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 
        hena = (uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(0));
        hena |= ((uint64_t)i40e_read_rx_ctl(hw, I40E_VFQF_HENA(1))) << 32;
-       rss_conf->rss_hf = i40e_parse_hena(hena);
+       rss_conf->rss_hf = i40e_parse_hena(vf->adapter, hena);
+
+       return 0;
+}
+
+static int
+i40evf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
+{
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct rte_eth_dev_data *dev_data = vf->dev_data;
+       uint32_t frame_size = mtu + I40E_ETH_OVERHEAD;
+       int ret = 0;
+
+       /* check if mtu is within the allowed range */
+       if ((mtu < ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX))
+               return -EINVAL;
+
+       /* mtu setting is forbidden if port is start */
+       if (dev_data->dev_started) {
+               PMD_DRV_LOG(ERR, "port %d must be stopped before configuration",
+                           dev_data->port_id);
+               return -EBUSY;
+       }
+
+       if (frame_size > ETHER_MAX_LEN)
+               dev_data->dev_conf.rxmode.jumbo_frame = 1;
+       else
+               dev_data->dev_conf.rxmode.jumbo_frame = 0;
+
+       dev_data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
+
+       return ret;
+}
+
+static void
+i40evf_set_default_mac_addr(struct rte_eth_dev *dev,
+                           struct ether_addr *mac_addr)
+{
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (!is_valid_assigned_ether_addr(mac_addr)) {
+               PMD_DRV_LOG(ERR, "Tried to set invalid MAC address.");
+               return;
+       }
+
+       if (vf->flags & I40E_FLAG_VF_MAC_BY_PF)
+               return;
+
+       i40evf_del_mac_addr_by_addr(dev, (struct ether_addr *)hw->mac.addr);
+
+       i40evf_add_mac_addr(dev, mac_addr, 0, 0);
+
+       ether_addr_copy(mac_addr, (struct ether_addr *)hw->mac.addr);
+}
+
+static int
+i40evf_add_del_mc_addr_list(struct rte_eth_dev *dev,
+                       struct ether_addr *mc_addrs,
+                       uint32_t mc_addrs_num, bool add)
+{
+       struct virtchnl_ether_addr_list *list;
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       uint8_t cmd_buffer[sizeof(struct virtchnl_ether_addr_list) +
+               (I40E_NUM_MACADDR_MAX * sizeof(struct virtchnl_ether_addr))];
+       uint32_t i;
+       int err;
+       struct vf_cmd_info args;
+
+       if (mc_addrs == NULL || mc_addrs_num == 0)
+               return 0;
+
+       if (mc_addrs_num > I40E_NUM_MACADDR_MAX)
+               return -EINVAL;
+
+       list = (struct virtchnl_ether_addr_list *)cmd_buffer;
+       list->vsi_id = vf->vsi_res->vsi_id;
+       list->num_elements = mc_addrs_num;
+
+       for (i = 0; i < mc_addrs_num; i++) {
+               if (!I40E_IS_MULTICAST(mc_addrs[i].addr_bytes)) {
+                       PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
+                                   mc_addrs[i].addr_bytes[0],
+                                   mc_addrs[i].addr_bytes[1],
+                                   mc_addrs[i].addr_bytes[2],
+                                   mc_addrs[i].addr_bytes[3],
+                                   mc_addrs[i].addr_bytes[4],
+                                   mc_addrs[i].addr_bytes[5]);
+                       return -EINVAL;
+               }
+
+               memcpy(list->list[i].addr, mc_addrs[i].addr_bytes,
+                       sizeof(list->list[i].addr));
+       }
+
+       args.ops = add ? VIRTCHNL_OP_ADD_ETH_ADDR : VIRTCHNL_OP_DEL_ETH_ADDR;
+       args.in_args = cmd_buffer;
+       args.in_args_size = sizeof(struct virtchnl_ether_addr_list) +
+               i * sizeof(struct virtchnl_ether_addr);
+       args.out_buffer = vf->aq_resp;
+       args.out_size = I40E_AQ_BUF_SZ;
+       err = i40evf_execute_vf_cmd(dev, &args);
+       if (err) {
+               PMD_DRV_LOG(ERR, "fail to execute command %s",
+                       add ? "OP_ADD_ETH_ADDR" : "OP_DEL_ETH_ADDR");
+               return err;
+       }
+
+       return 0;
+}
+
+static int
+i40evf_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *mc_addrs,
+                       uint32_t mc_addrs_num)
+{
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       int err;
+
+       /* flush previous addresses */
+       err = i40evf_add_del_mc_addr_list(dev, vf->mc_addrs, vf->mc_addrs_num,
+                               FALSE);
+       if (err)
+               return err;
+
+       vf->mc_addrs_num = 0;
+
+       /* add new ones */
+       err = i40evf_add_del_mc_addr_list(dev, mc_addrs, mc_addrs_num,
+                                       TRUE);
+       if (err)
+               return err;
+
+       vf->mc_addrs_num = mc_addrs_num;
+       memcpy(vf->mc_addrs, mc_addrs, mc_addrs_num * sizeof(*mc_addrs));
 
        return 0;
 }