net/mlx5: fix allocation when no memory on device NUMA node
[dpdk.git] / drivers / net / mlx5 / mlx5.c
index 7aea5a4..bc4b6ba 100644 (file)
 #endif
 
 #include <rte_malloc.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
 #include <rte_ethdev_pci.h>
 #include <rte_pci.h>
+#include <rte_bus_pci.h>
 #include <rte_common.h>
 #include <rte_kvargs.h>
 
 /* Device parameter to limit the size of inlining packet. */
 #define MLX5_TXQ_MAX_INLINE_LEN "txq_max_inline_len"
 
-/* Device parameter to enable hardware TSO offload. */
-#define MLX5_TSO "tso"
-
 /* Device parameter to enable hardware Tx vector. */
 #define MLX5_TX_VEC_EN "tx_vec_en"
 
 /* Device parameter to enable hardware Rx vector. */
 #define MLX5_RX_VEC_EN "rx_vec_en"
 
-/* Default PMD specific parameter value. */
-#define MLX5_ARG_UNSET (-1)
-
 #ifndef HAVE_IBV_MLX5_MOD_MPW
 #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2)
 #define MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW (1 << 3)
 #endif
 
-struct mlx5_args {
-       int cqe_comp;
-       int txq_inline;
-       int txqs_inline;
-       int mps;
-       int mpw_hdr_dseg;
-       int inline_max_packet_sz;
-       int tso;
-       int tx_vec_en;
-       int rx_vec_en;
-};
+#ifndef HAVE_IBV_MLX5_MOD_CQE_128B_COMP
+#define MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP (1 << 4)
+#endif
+
 /**
  * Retrieve integer value from environment variable.
  *
@@ -151,11 +139,20 @@ mlx5_alloc_verbs_buf(size_t size, void *data)
        struct priv *priv = data;
        void *ret;
        size_t alignment = sysconf(_SC_PAGESIZE);
+       unsigned int socket = SOCKET_ID_ANY;
 
+       if (priv->verbs_alloc_ctx.type == MLX5_VERBS_ALLOC_TYPE_TX_QUEUE) {
+               const struct mlx5_txq_ctrl *ctrl = priv->verbs_alloc_ctx.obj;
+
+               socket = ctrl->socket;
+       } else if (priv->verbs_alloc_ctx.type ==
+                  MLX5_VERBS_ALLOC_TYPE_RX_QUEUE) {
+               const struct mlx5_rxq_ctrl *ctrl = priv->verbs_alloc_ctx.obj;
+
+               socket = ctrl->socket;
+       }
        assert(data != NULL);
-       assert(!mlx5_is_secondary());
-       ret = rte_malloc_socket(__func__, size, alignment,
-                               priv->dev->device->numa_node);
+       ret = rte_malloc_socket(__func__, size, alignment, socket);
        DEBUG("Extern alloc size: %lu, align: %lu: %p", size, alignment, ret);
        return ret;
 }
@@ -172,7 +169,6 @@ static void
 mlx5_free_verbs_buf(void *ptr, void *data __rte_unused)
 {
        assert(data != NULL);
-       assert(!mlx5_is_secondary());
        DEBUG("Extern free request: %p", ptr);
        rte_free(ptr);
 }
@@ -188,8 +184,9 @@ mlx5_free_verbs_buf(void *ptr, void *data __rte_unused)
 static void
 mlx5_dev_close(struct rte_eth_dev *dev)
 {
-       struct priv *priv = mlx5_get_priv(dev);
+       struct priv *priv = dev->data->dev_private;
        unsigned int i;
+       int ret;
 
        priv_lock(priv);
        DEBUG("%p: closing device \"%s\"",
@@ -197,44 +194,23 @@ mlx5_dev_close(struct rte_eth_dev *dev)
              ((priv->ctx != NULL) ? priv->ctx->device->name : ""));
        /* In case mlx5_dev_stop() has not been called. */
        priv_dev_interrupt_handler_uninstall(priv, dev);
-       priv_special_flow_disable_all(priv);
-       priv_mac_addrs_disable(priv);
-       priv_destroy_hash_rxqs(priv);
-
+       priv_dev_traffic_disable(priv, dev);
        /* Prevent crashes when queues are still in use. */
        dev->rx_pkt_burst = removed_rx_burst;
        dev->tx_pkt_burst = removed_tx_burst;
        if (priv->rxqs != NULL) {
                /* XXX race condition if mlx5_rx_burst() is still running. */
                usleep(1000);
-               for (i = 0; (i != priv->rxqs_n); ++i) {
-                       struct mlx5_rxq_data *rxq = (*priv->rxqs)[i];
-                       struct mlx5_rxq_ctrl *rxq_ctrl;
-
-                       if (rxq == NULL)
-                               continue;
-                       rxq_ctrl = container_of(rxq, struct mlx5_rxq_ctrl, rxq);
-                       (*priv->rxqs)[i] = NULL;
-                       mlx5_rxq_cleanup(rxq_ctrl);
-                       rte_free(rxq_ctrl);
-               }
+               for (i = 0; (i != priv->rxqs_n); ++i)
+                       mlx5_priv_rxq_release(priv, i);
                priv->rxqs_n = 0;
                priv->rxqs = NULL;
        }
        if (priv->txqs != NULL) {
                /* XXX race condition if mlx5_tx_burst() is still running. */
                usleep(1000);
-               for (i = 0; (i != priv->txqs_n); ++i) {
-                       struct mlx5_txq_data *txq = (*priv->txqs)[i];
-                       struct mlx5_txq_ctrl *txq_ctrl;
-
-                       if (txq == NULL)
-                               continue;
-                       txq_ctrl = container_of(txq, struct mlx5_txq_ctrl, txq);
-                       (*priv->txqs)[i] = NULL;
-                       mlx5_txq_cleanup(txq_ctrl);
-                       rte_free(txq_ctrl);
-               }
+               for (i = 0; (i != priv->txqs_n); ++i)
+                       mlx5_priv_txq_release(priv, i);
                priv->txqs_n = 0;
                priv->txqs = NULL;
        }
@@ -244,19 +220,40 @@ mlx5_dev_close(struct rte_eth_dev *dev)
                claim_zero(ibv_close_device(priv->ctx));
        } else
                assert(priv->ctx == NULL);
-       if (priv->rss_conf != NULL) {
-               for (i = 0; (i != hash_rxq_init_n); ++i)
-                       rte_free((*priv->rss_conf)[i]);
-               rte_free(priv->rss_conf);
-       }
+       if (priv->rss_conf.rss_key != NULL)
+               rte_free(priv->rss_conf.rss_key);
        if (priv->reta_idx != NULL)
                rte_free(priv->reta_idx);
        priv_socket_uninit(priv);
+       ret = mlx5_priv_hrxq_ibv_verify(priv);
+       if (ret)
+               WARN("%p: some Hash Rx queue still remain", (void *)priv);
+       ret = mlx5_priv_ind_table_ibv_verify(priv);
+       if (ret)
+               WARN("%p: some Indirection table still remain", (void *)priv);
+       ret = mlx5_priv_rxq_ibv_verify(priv);
+       if (ret)
+               WARN("%p: some Verbs Rx queue still remain", (void *)priv);
+       ret = mlx5_priv_rxq_verify(priv);
+       if (ret)
+               WARN("%p: some Rx Queues still remain", (void *)priv);
+       ret = mlx5_priv_txq_ibv_verify(priv);
+       if (ret)
+               WARN("%p: some Verbs Tx queue still remain", (void *)priv);
+       ret = mlx5_priv_txq_verify(priv);
+       if (ret)
+               WARN("%p: some Tx Queues still remain", (void *)priv);
+       ret = priv_flow_verify(priv);
+       if (ret)
+               WARN("%p: some flows still remain", (void *)priv);
+       ret = priv_mr_verify(priv);
+       if (ret)
+               WARN("%p: some Memory Region still remain", (void *)priv);
        priv_unlock(priv);
        memset(priv, 0, sizeof(*priv));
 }
 
-static const struct eth_dev_ops mlx5_dev_ops = {
+const struct eth_dev_ops mlx5_dev_ops = {
        .dev_configure = mlx5_dev_configure,
        .dev_start = mlx5_dev_start,
        .dev_stop = mlx5_dev_stop,
@@ -297,9 +294,9 @@ static const struct eth_dev_ops mlx5_dev_ops = {
        .tx_descriptor_status = mlx5_tx_descriptor_status,
        .rx_queue_intr_enable = mlx5_rx_intr_enable,
        .rx_queue_intr_disable = mlx5_rx_intr_disable,
+       .is_removed = mlx5_is_removed,
 };
 
-
 static const struct eth_dev_ops mlx5_dev_sec_ops = {
        .stats_get = mlx5_stats_get,
        .stats_reset = mlx5_stats_reset,
@@ -311,6 +308,43 @@ static const struct eth_dev_ops mlx5_dev_sec_ops = {
        .tx_descriptor_status = mlx5_tx_descriptor_status,
 };
 
+/* Available operators in flow isolated mode. */
+const struct eth_dev_ops mlx5_dev_ops_isolate = {
+       .dev_configure = mlx5_dev_configure,
+       .dev_start = mlx5_dev_start,
+       .dev_stop = mlx5_dev_stop,
+       .dev_set_link_down = mlx5_set_link_down,
+       .dev_set_link_up = mlx5_set_link_up,
+       .dev_close = mlx5_dev_close,
+       .link_update = mlx5_link_update,
+       .stats_get = mlx5_stats_get,
+       .stats_reset = mlx5_stats_reset,
+       .xstats_get = mlx5_xstats_get,
+       .xstats_reset = mlx5_xstats_reset,
+       .xstats_get_names = mlx5_xstats_get_names,
+       .dev_infos_get = mlx5_dev_infos_get,
+       .dev_supported_ptypes_get = mlx5_dev_supported_ptypes_get,
+       .vlan_filter_set = mlx5_vlan_filter_set,
+       .rx_queue_setup = mlx5_rx_queue_setup,
+       .tx_queue_setup = mlx5_tx_queue_setup,
+       .rx_queue_release = mlx5_rx_queue_release,
+       .tx_queue_release = mlx5_tx_queue_release,
+       .flow_ctrl_get = mlx5_dev_get_flow_ctrl,
+       .flow_ctrl_set = mlx5_dev_set_flow_ctrl,
+       .mac_addr_remove = mlx5_mac_addr_remove,
+       .mac_addr_add = mlx5_mac_addr_add,
+       .mac_addr_set = mlx5_mac_addr_set,
+       .mtu_set = mlx5_dev_set_mtu,
+       .vlan_strip_queue_set = mlx5_vlan_strip_queue_set,
+       .vlan_offload_set = mlx5_vlan_offload_set,
+       .filter_ctrl = mlx5_dev_filter_ctrl,
+       .rx_descriptor_status = mlx5_rx_descriptor_status,
+       .tx_descriptor_status = mlx5_tx_descriptor_status,
+       .rx_queue_intr_enable = mlx5_rx_intr_enable,
+       .rx_queue_intr_disable = mlx5_rx_intr_disable,
+       .is_removed = mlx5_is_removed,
+};
+
 static struct {
        struct rte_pci_addr pci_addr; /* associated PCI address */
        uint32_t ports; /* physical ports bitfield. */
@@ -360,7 +394,7 @@ mlx5_dev_idx(struct rte_pci_addr *pci_addr)
 static int
 mlx5_args_check(const char *key, const char *val, void *opaque)
 {
-       struct mlx5_args *args = opaque;
+       struct mlx5_dev_config *config = opaque;
        unsigned long tmp;
 
        errno = 0;
@@ -370,23 +404,21 @@ mlx5_args_check(const char *key, const char *val, void *opaque)
                return errno;
        }
        if (strcmp(MLX5_RXQ_CQE_COMP_EN, key) == 0) {
-               args->cqe_comp = !!tmp;
+               config->cqe_comp = !!tmp;
        } else if (strcmp(MLX5_TXQ_INLINE, key) == 0) {
-               args->txq_inline = tmp;
+               config->txq_inline = tmp;
        } else if (strcmp(MLX5_TXQS_MIN_INLINE, key) == 0) {
-               args->txqs_inline = tmp;
+               config->txqs_inline = tmp;
        } else if (strcmp(MLX5_TXQ_MPW_EN, key) == 0) {
-               args->mps = !!tmp;
+               config->mps = !!tmp ? config->mps : 0;
        } else if (strcmp(MLX5_TXQ_MPW_HDR_DSEG_EN, key) == 0) {
-               args->mpw_hdr_dseg = !!tmp;
+               config->mpw_hdr_dseg = !!tmp;
        } else if (strcmp(MLX5_TXQ_MAX_INLINE_LEN, key) == 0) {
-               args->inline_max_packet_sz = tmp;
-       } else if (strcmp(MLX5_TSO, key) == 0) {
-               args->tso = !!tmp;
+               config->inline_max_packet_sz = tmp;
        } else if (strcmp(MLX5_TX_VEC_EN, key) == 0) {
-               args->tx_vec_en = !!tmp;
+               config->tx_vec_en = !!tmp;
        } else if (strcmp(MLX5_RX_VEC_EN, key) == 0) {
-               args->rx_vec_en = !!tmp;
+               config->rx_vec_en = !!tmp;
        } else {
                WARN("%s: unknown parameter", key);
                return -EINVAL;
@@ -397,8 +429,8 @@ mlx5_args_check(const char *key, const char *val, void *opaque)
 /**
  * Parse device parameters.
  *
- * @param priv
- *   Pointer to private structure.
+ * @param config
+ *   Pointer to device configuration structure.
  * @param devargs
  *   Device arguments structure.
  *
@@ -406,7 +438,7 @@ mlx5_args_check(const char *key, const char *val, void *opaque)
  *   0 on success, errno value on failure.
  */
 static int
-mlx5_args(struct mlx5_args *args, struct rte_devargs *devargs)
+mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs)
 {
        const char **params = (const char *[]){
                MLX5_RXQ_CQE_COMP_EN,
@@ -415,7 +447,6 @@ mlx5_args(struct mlx5_args *args, struct rte_devargs *devargs)
                MLX5_TXQ_MPW_EN,
                MLX5_TXQ_MPW_HDR_DSEG_EN,
                MLX5_TXQ_MAX_INLINE_LEN,
-               MLX5_TSO,
                MLX5_TX_VEC_EN,
                MLX5_RX_VEC_EN,
                NULL,
@@ -434,7 +465,7 @@ mlx5_args(struct mlx5_args *args, struct rte_devargs *devargs)
        for (i = 0; (params[i] != NULL); ++i) {
                if (rte_kvargs_count(kvlist, params[i])) {
                        ret = rte_kvargs_process(kvlist, params[i],
-                                                mlx5_args_check, args);
+                                                mlx5_args_check, config);
                        if (ret != 0) {
                                rte_kvargs_free(kvlist);
                                return ret;
@@ -447,38 +478,6 @@ mlx5_args(struct mlx5_args *args, struct rte_devargs *devargs)
 
 static struct rte_pci_driver mlx5_driver;
 
-/**
- * Assign parameters from args into priv, only non default
- * values are considered.
- *
- * @param[out] priv
- *   Pointer to private structure.
- * @param[in] args
- *   Pointer to args values.
- */
-static void
-mlx5_args_assign(struct priv *priv, struct mlx5_args *args)
-{
-       if (args->cqe_comp != MLX5_ARG_UNSET)
-               priv->cqe_comp = args->cqe_comp;
-       if (args->txq_inline != MLX5_ARG_UNSET)
-               priv->txq_inline = args->txq_inline;
-       if (args->txqs_inline != MLX5_ARG_UNSET)
-               priv->txqs_inline = args->txqs_inline;
-       if (args->mps != MLX5_ARG_UNSET)
-               priv->mps = args->mps ? priv->mps : 0;
-       if (args->mpw_hdr_dseg != MLX5_ARG_UNSET)
-               priv->mpw_hdr_dseg = args->mpw_hdr_dseg;
-       if (args->inline_max_packet_sz != MLX5_ARG_UNSET)
-               priv->inline_max_packet_sz = args->inline_max_packet_sz;
-       if (args->tso != MLX5_ARG_UNSET)
-               priv->tso = args->tso;
-       if (args->tx_vec_en != MLX5_ARG_UNSET)
-               priv->tx_vec_en = args->tx_vec_en;
-       if (args->rx_vec_en != MLX5_ARG_UNSET)
-               priv->rx_vec_en = args->rx_vec_en;
-}
-
 /**
  * DPDK callback to register a PCI device.
  *
@@ -503,10 +502,14 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
        struct ibv_device_attr_ex device_attr;
        unsigned int sriov;
        unsigned int mps;
+       unsigned int cqe_comp;
        unsigned int tunnel_en = 0;
        int idx;
        int i;
        struct mlx5dv_context attrs_out;
+#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
+       struct ibv_counter_set_description cs_desc;
+#endif
 
        (void)pci_drv;
        assert(pci_drv == &mlx5_driver);
@@ -595,17 +598,23 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
         * as all ConnectX-5 devices.
         */
        mlx5dv_query_device(attr_ctx, &attrs_out);
-       if (attrs_out.flags & (MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW |
-                              MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED)) {
-               INFO("Enhanced MPW is detected\n");
-               mps = MLX5_MPW_ENHANCED;
-       } else if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) {
-               INFO("MPW is detected\n");
-               mps = MLX5_MPW;
+       if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) {
+               if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW) {
+                       DEBUG("Enhanced MPW is supported");
+                       mps = MLX5_MPW_ENHANCED;
+               } else {
+                       DEBUG("MPW is supported");
+                       mps = MLX5_MPW;
+               }
        } else {
-               INFO("MPW is disabled\n");
+               DEBUG("MPW isn't supported");
                mps = MLX5_MPW_DISABLED;
        }
+       if (RTE_CACHE_LINE_SIZE == 128 &&
+           !(attrs_out.flags & MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP))
+               cqe_comp = 0;
+       else
+               cqe_comp = 1;
        if (ibv_query_device_ex(attr_ctx, NULL, &device_attr))
                goto error;
        INFO("%u port(s) detected", device_attr.orig_attr.phys_port_cnt);
@@ -621,21 +630,22 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                struct ibv_device_attr_ex device_attr_ex;
                struct ether_addr mac;
                uint16_t num_vfs = 0;
-               struct mlx5_args args = {
-                       .cqe_comp = MLX5_ARG_UNSET,
+               struct ibv_device_attr_ex device_attr;
+               struct mlx5_dev_config config = {
+                       .cqe_comp = cqe_comp,
+                       .mps = mps,
+                       .tunnel_en = tunnel_en,
+                       .tx_vec_en = 1,
+                       .rx_vec_en = 1,
+                       .mpw_hdr_dseg = 0,
                        .txq_inline = MLX5_ARG_UNSET,
                        .txqs_inline = MLX5_ARG_UNSET,
-                       .mps = MLX5_ARG_UNSET,
-                       .mpw_hdr_dseg = MLX5_ARG_UNSET,
                        .inline_max_packet_sz = MLX5_ARG_UNSET,
-                       .tso = MLX5_ARG_UNSET,
-                       .tx_vec_en = MLX5_ARG_UNSET,
-                       .rx_vec_en = MLX5_ARG_UNSET,
                };
 
                mlx5_dev[idx].ports |= test;
 
-               if (mlx5_is_secondary()) {
+               if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
                        /* from rte_ethdev.c */
                        char name[RTE_ETH_NAME_MAX_LEN];
 
@@ -662,8 +672,15 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                                err = -err;
                                goto error;
                        }
-                       priv_dev_select_rx_function(priv, eth_dev);
-                       priv_dev_select_tx_function(priv, eth_dev);
+                       /*
+                        * Ethdev pointer is still required as input since
+                        * the primary device is not accessible from the
+                        * secondary process.
+                        */
+                       eth_dev->rx_pkt_burst =
+                               priv_select_rx_function(priv, eth_dev);
+                       eth_dev->tx_pkt_burst =
+                               priv_select_tx_function(priv, eth_dev);
                        continue;
                }
 
@@ -675,6 +692,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                        goto port_error;
                }
 
+               ibv_query_device_ex(ctx, NULL, &device_attr);
                /* Check port status. */
                err = ibv_query_port(ctx, port, &port_attr);
                if (err) {
@@ -721,109 +739,84 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                priv->port = port;
                priv->pd = pd;
                priv->mtu = ETHER_MTU;
-               priv->mps = mps; /* Enable MPW by default if supported. */
-               priv->cqe_comp = 1; /* Enable compression by default. */
-               priv->tunnel_en = tunnel_en;
-               /* Enable vector by default if supported. */
-               priv->tx_vec_en = 1;
-               priv->rx_vec_en = 1;
-               err = mlx5_args(&args, pci_dev->device.devargs);
+               err = mlx5_args(&config, pci_dev->device.devargs);
                if (err) {
                        ERROR("failed to process device arguments: %s",
                              strerror(err));
                        goto port_error;
                }
-               mlx5_args_assign(priv, &args);
                if (ibv_query_device_ex(ctx, NULL, &device_attr_ex)) {
                        ERROR("ibv_query_device_ex() failed");
                        goto port_error;
                }
 
-               priv->hw_csum =
-                       !!(device_attr_ex.device_cap_flags_ex &
-                          IBV_DEVICE_RAW_IP_CSUM);
+               config.hw_csum = !!(device_attr_ex.device_cap_flags_ex &
+                                   IBV_DEVICE_RAW_IP_CSUM);
                DEBUG("checksum offloading is %ssupported",
-                     (priv->hw_csum ? "" : "not "));
+                     (config.hw_csum ? "" : "not "));
 
 #ifdef HAVE_IBV_DEVICE_VXLAN_SUPPORT
-               priv->hw_csum_l2tun = !!(exp_device_attr.exp_device_cap_flags &
-                                        IBV_DEVICE_VXLAN_SUPPORT);
+               config.hw_csum_l2tun =
+                               !!(exp_device_attr.exp_device_cap_flags &
+                                  IBV_DEVICE_VXLAN_SUPPORT);
 #endif
-               DEBUG("L2 tunnel checksum offloads are %ssupported",
-                     (priv->hw_csum_l2tun ? "" : "not "));
-
-               priv->ind_table_max_size =
+               DEBUG("Rx L2 tunnel checksum offloads are %ssupported",
+                     (config.hw_csum_l2tun ? "" : "not "));
+
+#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
+               config.flow_counter_en = !!(device_attr.max_counter_sets);
+               ibv_describe_counter_set(ctx, 0, &cs_desc);
+               DEBUG("counter type = %d, num of cs = %ld, attributes = %d",
+                     cs_desc.counter_type, cs_desc.num_of_cs,
+                     cs_desc.attributes);
+#endif
+               config.ind_table_max_size =
                        device_attr_ex.rss_caps.max_rwq_indirection_table_size;
                /* Remove this check once DPDK supports larger/variable
                 * indirection tables. */
-               if (priv->ind_table_max_size >
+               if (config.ind_table_max_size >
                                (unsigned int)ETH_RSS_RETA_SIZE_512)
-                       priv->ind_table_max_size = ETH_RSS_RETA_SIZE_512;
+                       config.ind_table_max_size = ETH_RSS_RETA_SIZE_512;
                DEBUG("maximum RX indirection table size is %u",
-                     priv->ind_table_max_size);
-               priv->hw_vlan_strip = !!(device_attr_ex.raw_packet_caps &
+                     config.ind_table_max_size);
+               config.hw_vlan_strip = !!(device_attr_ex.raw_packet_caps &
                                         IBV_RAW_PACKET_CAP_CVLAN_STRIPPING);
                DEBUG("VLAN stripping is %ssupported",
-                     (priv->hw_vlan_strip ? "" : "not "));
+                     (config.hw_vlan_strip ? "" : "not "));
 
-               priv->hw_fcs_strip =
+               config.hw_fcs_strip =
                                !!(device_attr_ex.orig_attr.device_cap_flags &
                                IBV_WQ_FLAGS_SCATTER_FCS);
                DEBUG("FCS stripping configuration is %ssupported",
-                     (priv->hw_fcs_strip ? "" : "not "));
+                     (config.hw_fcs_strip ? "" : "not "));
 
 #ifdef HAVE_IBV_WQ_FLAG_RX_END_PADDING
-               priv->hw_padding = !!device_attr_ex.rx_pad_end_addr_align;
+               config.hw_padding = !!device_attr_ex.rx_pad_end_addr_align;
 #endif
                DEBUG("hardware RX end alignment padding is %ssupported",
-                     (priv->hw_padding ? "" : "not "));
+                     (config.hw_padding ? "" : "not "));
 
                priv_get_num_vfs(priv, &num_vfs);
-               priv->sriov = (num_vfs || sriov);
-               priv->tso = ((priv->tso) &&
-                           (device_attr_ex.tso_caps.max_tso > 0) &&
-                           (device_attr_ex.tso_caps.supported_qpts &
-                           (1 << IBV_QPT_RAW_PACKET)));
-               if (priv->tso)
-                       priv->max_tso_payload_sz =
-                               device_attr_ex.tso_caps.max_tso;
-               if (priv->mps && !mps) {
+               config.sriov = (num_vfs || sriov);
+               config.tso = ((device_attr_ex.tso_caps.max_tso > 0) &&
+                             (device_attr_ex.tso_caps.supported_qpts &
+                             (1 << IBV_QPT_RAW_PACKET)));
+               if (config.tso)
+                       config.tso_max_payload_sz =
+                                       device_attr_ex.tso_caps.max_tso;
+               if (config.mps && !mps) {
                        ERROR("multi-packet send not supported on this device"
                              " (" MLX5_TXQ_MPW_EN ")");
                        err = ENOTSUP;
                        goto port_error;
-               } else if (priv->mps && priv->tso) {
-                       WARN("multi-packet send not supported in conjunction "
-                             "with TSO. MPS disabled");
-                       priv->mps = 0;
                }
                INFO("%sMPS is %s",
-                    priv->mps == MLX5_MPW_ENHANCED ? "Enhanced " : "",
-                    priv->mps != MLX5_MPW_DISABLED ? "enabled" : "disabled");
-               /* Set default values for Enhanced MPW, a.k.a MPWv2. */
-               if (priv->mps == MLX5_MPW_ENHANCED) {
-                       if (args.txqs_inline == MLX5_ARG_UNSET)
-                               priv->txqs_inline = MLX5_EMPW_MIN_TXQS;
-                       if (args.inline_max_packet_sz == MLX5_ARG_UNSET)
-                               priv->inline_max_packet_sz =
-                                       MLX5_EMPW_MAX_INLINE_LEN;
-                       if (args.txq_inline == MLX5_ARG_UNSET)
-                               priv->txq_inline = MLX5_WQE_SIZE_MAX -
-                                                  MLX5_WQE_SIZE;
-               }
-               /* Allocate and register default RSS hash keys. */
-               priv->rss_conf = rte_calloc(__func__, hash_rxq_init_n,
-                                           sizeof((*priv->rss_conf)[0]), 0);
-               if (priv->rss_conf == NULL) {
-                       err = ENOMEM;
-                       goto port_error;
+                    config.mps == MLX5_MPW_ENHANCED ? "Enhanced " : "",
+                    config.mps != MLX5_MPW_DISABLED ? "enabled" : "disabled");
+               if (config.cqe_comp && !cqe_comp) {
+                       WARN("Rx CQE compression isn't supported");
+                       config.cqe_comp = 0;
                }
-               err = rss_hash_rss_conf_new_key(priv,
-                                               rss_hash_default_key,
-                                               rss_hash_default_key_len,
-                                               ETH_RSS_PROTO_MASK);
-               if (err)
-                       goto port_error;
                /* Configure the first MAC address by default. */
                if (priv_get_mac(priv, &mac.addr_bytes)) {
                        ERROR("cannot get MAC address, is mlx5_en loaded?"
@@ -836,10 +829,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                     mac.addr_bytes[0], mac.addr_bytes[1],
                     mac.addr_bytes[2], mac.addr_bytes[3],
                     mac.addr_bytes[4], mac.addr_bytes[5]);
-               /* Register MAC address. */
-               claim_zero(priv_mac_addr_add(priv, 0,
-                                            (const uint8_t (*)[ETHER_ADDR_LEN])
-                                            mac.addr_bytes));
 #ifndef NDEBUG
                {
                        char ifname[IF_NAMESIZE];
@@ -872,11 +861,13 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                eth_dev->data->mac_addrs = priv->mac;
                eth_dev->device = &pci_dev->device;
                rte_eth_copy_pci_info(eth_dev, pci_dev);
-               eth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;
                eth_dev->device->driver = &mlx5_driver.driver;
                priv->dev = eth_dev;
                eth_dev->dev_ops = &mlx5_dev_ops;
+               /* Register MAC address. */
+               claim_zero(mlx5_mac_addr_add(eth_dev, &mac, 0, 0));
                TAILQ_INIT(&priv->flows);
+               TAILQ_INIT(&priv->ctrl_flows);
 
                /* Hint libmlx5 to use PMD allocator for data plane resources */
                struct mlx5dv_ctx_allocators alctr = {
@@ -890,14 +881,13 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
                /* Bring Ethernet device up. */
                DEBUG("forcing Ethernet interface up");
                priv_set_flags(priv, ~IFF_UP, IFF_UP);
-               mlx5_link_update(priv->dev, 1);
+               /* Store device configuration on private structure. */
+               priv->config = config;
                continue;
 
 port_error:
-               if (priv) {
-                       rte_free(priv->rss_conf);
+               if (priv)
                        rte_free(priv);
-               }
                if (pd)
                        claim_zero(ibv_dealloc_pd(pd));
                if (ctx)
@@ -990,8 +980,9 @@ rte_mlx5_pmd_init(void)
         * using this PMD, which is not supported in forked processes.
         */
        setenv("RDMAV_HUGEPAGES_SAFE", "1", 1);
-       /* Don't map UAR to WC if BlueFlame is not used.*/
-       setenv("MLX5_SHUT_UP_BF", "1", 1);
+       /* Match the size of Rx completion entry to the size of a cacheline. */
+       if (RTE_CACHE_LINE_SIZE == 128)
+               setenv("MLX5_CQE_SIZE", "128", 0);
        ibv_fork_init();
        rte_pci_register(&mlx5_driver);
 }