remove extra parentheses in return statement
[dpdk.git] / drivers / net / nfp / nfp_net.c
index a9be403..ffa5730 100644 (file)
 /* Prototypes */
 static void nfp_net_close(struct rte_eth_dev *dev);
 static int nfp_net_configure(struct rte_eth_dev *dev);
+static void nfp_net_dev_interrupt_handler(struct rte_intr_handle *handle,
+                                         void *param);
+static void nfp_net_dev_interrupt_delayed_handler(void *param);
+static int nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
+static void nfp_net_infos_get(struct rte_eth_dev *dev,
+                             struct rte_eth_dev_info *dev_info);
 static int nfp_net_init(struct rte_eth_dev *eth_dev);
+static int nfp_net_link_update(struct rte_eth_dev *dev, int wait_to_complete);
+static void nfp_net_promisc_enable(struct rte_eth_dev *dev);
+static void nfp_net_promisc_disable(struct rte_eth_dev *dev);
 static int nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq);
 static uint32_t nfp_net_rx_queue_count(struct rte_eth_dev *dev,
                                       uint16_t queue_idx);
@@ -90,6 +99,9 @@ static int nfp_net_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                                  uint16_t nb_desc, unsigned int socket_id,
                                  const struct rte_eth_txconf *tx_conf);
 static int nfp_net_start(struct rte_eth_dev *dev);
+static void nfp_net_stats_get(struct rte_eth_dev *dev,
+                             struct rte_eth_stats *stats);
+static void nfp_net_stats_reset(struct rte_eth_dev *dev);
 static void nfp_net_stop(struct rte_eth_dev *dev);
 static uint16_t nfp_net_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
                                  uint16_t nb_pkts);
@@ -223,6 +235,57 @@ ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
                                           NFP_MEMZONE_ALIGN);
 }
 
+/*
+ * Atomically reads link status information from global structure rte_eth_dev.
+ *
+ * @param dev
+ *   - Pointer to the structure rte_eth_dev to read from.
+ *   - Pointer to the buffer to be saved with the link status.
+ *
+ * @return
+ *   - On success, zero.
+ *   - On failure, negative value.
+ */
+static inline int
+nfp_net_dev_atomic_read_link_status(struct rte_eth_dev *dev,
+                                   struct rte_eth_link *link)
+{
+       struct rte_eth_link *dst = link;
+       struct rte_eth_link *src = &dev->data->dev_link;
+
+       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+                               *(uint64_t *)src) == 0)
+               return -1;
+
+       return 0;
+}
+
+/*
+ * Atomically writes the link status information into global
+ * structure rte_eth_dev.
+ *
+ * @param dev
+ *   - Pointer to the structure rte_eth_dev to read from.
+ *   - Pointer to the buffer to be saved with the link status.
+ *
+ * @return
+ *   - On success, zero.
+ *   - On failure, negative value.
+ */
+static inline int
+nfp_net_dev_atomic_write_link_status(struct rte_eth_dev *dev,
+                                    struct rte_eth_link *link)
+{
+       struct rte_eth_link *dst = &dev->data->dev_link;
+       struct rte_eth_link *src = link;
+
+       if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+                               *(uint64_t *)src) == 0)
+               return -1;
+
+       return 0;
+}
+
 static void
 nfp_net_rx_queue_release_mbufs(struct nfp_net_rxq *rxq)
 {
@@ -671,6 +734,7 @@ nfp_net_close(struct rte_eth_dev *dev)
 
        nfp_net_stop(dev);
 
+       rte_intr_disable(&dev->pci_dev->intr_handle);
        nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff);
 
        /*
@@ -679,6 +743,338 @@ nfp_net_close(struct rte_eth_dev *dev)
         */
 }
 
+static void
+nfp_net_promisc_enable(struct rte_eth_dev *dev)
+{
+       uint32_t new_ctrl, update = 0;
+       struct nfp_net_hw *hw;
+
+       PMD_DRV_LOG(DEBUG, "Promiscuous mode enable\n");
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (!(hw->cap & NFP_NET_CFG_CTRL_PROMISC)) {
+               PMD_INIT_LOG(INFO, "Promiscuous mode not supported\n");
+               return;
+       }
+
+       if (hw->ctrl & NFP_NET_CFG_CTRL_PROMISC) {
+               PMD_DRV_LOG(INFO, "Promiscuous mode already enabled\n");
+               return;
+       }
+
+       new_ctrl = hw->ctrl | NFP_NET_CFG_CTRL_PROMISC;
+       update = NFP_NET_CFG_UPDATE_GEN;
+
+       /*
+        * DPDK sets promiscuous mode on just after this call assuming
+        * it can not fail ...
+        */
+       if (nfp_net_reconfig(hw, new_ctrl, update) < 0)
+               return;
+
+       hw->ctrl = new_ctrl;
+}
+
+static void
+nfp_net_promisc_disable(struct rte_eth_dev *dev)
+{
+       uint32_t new_ctrl, update = 0;
+       struct nfp_net_hw *hw;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if ((hw->ctrl & NFP_NET_CFG_CTRL_PROMISC) == 0) {
+               PMD_DRV_LOG(INFO, "Promiscuous mode already disabled\n");
+               return;
+       }
+
+       new_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_PROMISC;
+       update = NFP_NET_CFG_UPDATE_GEN;
+
+       /*
+        * DPDK sets promiscuous mode off just before this call
+        * assuming it can not fail ...
+        */
+       if (nfp_net_reconfig(hw, new_ctrl, update) < 0)
+               return;
+
+       hw->ctrl = new_ctrl;
+}
+
+/*
+ * return 0 means link status changed, -1 means not changed
+ *
+ * Wait to complete is needed as it can take up to 9 seconds to get the Link
+ * status.
+ */
+static int
+nfp_net_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)
+{
+       struct nfp_net_hw *hw;
+       struct rte_eth_link link, old;
+       uint32_t nn_link_status;
+
+       PMD_DRV_LOG(DEBUG, "Link update\n");
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       memset(&old, 0, sizeof(old));
+       nfp_net_dev_atomic_read_link_status(dev, &old);
+
+       nn_link_status = nn_cfg_readl(hw, NFP_NET_CFG_STS);
+
+       memset(&link, 0, sizeof(struct rte_eth_link));
+
+       if (nn_link_status & NFP_NET_CFG_STS_LINK)
+               link.link_status = 1;
+
+       link.link_duplex = ETH_LINK_FULL_DUPLEX;
+       /* Other cards can limit the tx and rx rate per VF */
+       link.link_speed = ETH_LINK_SPEED_40G;
+
+       if (old.link_status != link.link_status) {
+               nfp_net_dev_atomic_write_link_status(dev, &link);
+               if (link.link_status)
+                       PMD_DRV_LOG(INFO, "NIC Link is Up\n");
+               else
+                       PMD_DRV_LOG(INFO, "NIC Link is Down\n");
+               return 0;
+       }
+
+       return -1;
+}
+
+static void
+nfp_net_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
+{
+       int i;
+       struct nfp_net_hw *hw;
+       struct rte_eth_stats nfp_dev_stats;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       /* RTE_ETHDEV_QUEUE_STAT_CNTRS default value is 16 */
+
+       /* reading per RX ring stats */
+       for (i = 0; i < dev->data->nb_rx_queues; i++) {
+               if (i == RTE_ETHDEV_QUEUE_STAT_CNTRS)
+                       break;
+
+               nfp_dev_stats.q_ipackets[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_RXR_STATS(i));
+
+               nfp_dev_stats.q_ipackets[i] -=
+                       hw->eth_stats_base.q_ipackets[i];
+
+               nfp_dev_stats.q_ibytes[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_RXR_STATS(i) + 0x8);
+
+               nfp_dev_stats.q_ibytes[i] -=
+                       hw->eth_stats_base.q_ibytes[i];
+       }
+
+       /* reading per TX ring stats */
+       for (i = 0; i < dev->data->nb_tx_queues; i++) {
+               if (i == RTE_ETHDEV_QUEUE_STAT_CNTRS)
+                       break;
+
+               nfp_dev_stats.q_opackets[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_TXR_STATS(i));
+
+               nfp_dev_stats.q_opackets[i] -=
+                       hw->eth_stats_base.q_opackets[i];
+
+               nfp_dev_stats.q_obytes[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_TXR_STATS(i) + 0x8);
+
+               nfp_dev_stats.q_obytes[i] -=
+                       hw->eth_stats_base.q_obytes[i];
+       }
+
+       nfp_dev_stats.ipackets =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_FRAMES);
+
+       nfp_dev_stats.ipackets -= hw->eth_stats_base.ipackets;
+
+       nfp_dev_stats.ibytes =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_OCTETS);
+
+       nfp_dev_stats.ibytes -= hw->eth_stats_base.ibytes;
+
+       nfp_dev_stats.opackets =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_TX_FRAMES);
+
+       nfp_dev_stats.opackets -= hw->eth_stats_base.opackets;
+
+       nfp_dev_stats.obytes =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_TX_OCTETS);
+
+       nfp_dev_stats.obytes -= hw->eth_stats_base.obytes;
+
+       nfp_dev_stats.imcasts =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_MC_FRAMES);
+
+       nfp_dev_stats.imcasts -= hw->eth_stats_base.imcasts;
+
+       /* reading general device stats */
+       nfp_dev_stats.ierrors =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_ERRORS);
+
+       nfp_dev_stats.ierrors -= hw->eth_stats_base.ierrors;
+
+       nfp_dev_stats.oerrors =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_TX_ERRORS);
+
+       nfp_dev_stats.oerrors -= hw->eth_stats_base.oerrors;
+
+       /* Multicast frames received */
+       nfp_dev_stats.imcasts =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_MC_FRAMES);
+
+       nfp_dev_stats.imcasts -= hw->eth_stats_base.imcasts;
+
+       /* RX ring mbuf allocation failures */
+       nfp_dev_stats.rx_nombuf = dev->data->rx_mbuf_alloc_failed;
+
+       nfp_dev_stats.imissed =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_DISCARDS);
+
+       nfp_dev_stats.imissed -= hw->eth_stats_base.imissed;
+
+       if (stats)
+               memcpy(stats, &nfp_dev_stats, sizeof(*stats));
+}
+
+static void
+nfp_net_stats_reset(struct rte_eth_dev *dev)
+{
+       int i;
+       struct nfp_net_hw *hw;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       /*
+        * hw->eth_stats_base records the per counter starting point.
+        * Lets update it now
+        */
+
+       /* reading per RX ring stats */
+       for (i = 0; i < dev->data->nb_rx_queues; i++) {
+               if (i == RTE_ETHDEV_QUEUE_STAT_CNTRS)
+                       break;
+
+               hw->eth_stats_base.q_ipackets[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_RXR_STATS(i));
+
+               hw->eth_stats_base.q_ibytes[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_RXR_STATS(i) + 0x8);
+       }
+
+       /* reading per TX ring stats */
+       for (i = 0; i < dev->data->nb_tx_queues; i++) {
+               if (i == RTE_ETHDEV_QUEUE_STAT_CNTRS)
+                       break;
+
+               hw->eth_stats_base.q_opackets[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_TXR_STATS(i));
+
+               hw->eth_stats_base.q_obytes[i] =
+                       nn_cfg_readq(hw, NFP_NET_CFG_TXR_STATS(i) + 0x8);
+       }
+
+       hw->eth_stats_base.ipackets =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_FRAMES);
+
+       hw->eth_stats_base.ibytes =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_OCTETS);
+
+       hw->eth_stats_base.opackets =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_TX_FRAMES);
+
+       hw->eth_stats_base.obytes =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_TX_OCTETS);
+
+       hw->eth_stats_base.imcasts =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_MC_FRAMES);
+
+       /* reading general device stats */
+       hw->eth_stats_base.ierrors =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_ERRORS);
+
+       hw->eth_stats_base.oerrors =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_TX_ERRORS);
+
+       /* Multicast frames received */
+       hw->eth_stats_base.imcasts =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_MC_FRAMES);
+
+       /* RX ring mbuf allocation failures */
+       dev->data->rx_mbuf_alloc_failed = 0;
+
+       hw->eth_stats_base.imissed =
+               nn_cfg_readq(hw, NFP_NET_CFG_STATS_RX_DISCARDS);
+}
+
+static void
+nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
+{
+       struct nfp_net_hw *hw;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       dev_info->driver_name = dev->driver->pci_drv.name;
+       dev_info->max_rx_queues = (uint16_t)hw->max_rx_queues;
+       dev_info->max_tx_queues = (uint16_t)hw->max_tx_queues;
+       dev_info->min_rx_bufsize = ETHER_MIN_MTU;
+       dev_info->max_rx_pktlen = hw->mtu;
+       /* Next should change when PF support is implemented */
+       dev_info->max_mac_addrs = 1;
+
+       if (hw->cap & NFP_NET_CFG_CTRL_RXVLAN)
+               dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP;
+
+       if (hw->cap & NFP_NET_CFG_CTRL_RXCSUM)
+               dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_IPV4_CKSUM |
+                                            DEV_RX_OFFLOAD_UDP_CKSUM |
+                                            DEV_RX_OFFLOAD_TCP_CKSUM;
+
+       if (hw->cap & NFP_NET_CFG_CTRL_TXVLAN)
+               dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT;
+
+       if (hw->cap & NFP_NET_CFG_CTRL_TXCSUM)
+               dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_IPV4_CKSUM |
+                                            DEV_RX_OFFLOAD_UDP_CKSUM |
+                                            DEV_RX_OFFLOAD_TCP_CKSUM;
+
+       dev_info->default_rxconf = (struct rte_eth_rxconf) {
+               .rx_thresh = {
+                       .pthresh = DEFAULT_RX_PTHRESH,
+                       .hthresh = DEFAULT_RX_HTHRESH,
+                       .wthresh = DEFAULT_RX_WTHRESH,
+               },
+               .rx_free_thresh = DEFAULT_RX_FREE_THRESH,
+               .rx_drop_en = 0,
+       };
+
+       dev_info->default_txconf = (struct rte_eth_txconf) {
+               .tx_thresh = {
+                       .pthresh = DEFAULT_TX_PTHRESH,
+                       .hthresh = DEFAULT_TX_HTHRESH,
+                       .wthresh = DEFAULT_TX_WTHRESH,
+               },
+               .tx_free_thresh = DEFAULT_TX_FREE_THRESH,
+               .tx_rs_thresh = DEFAULT_TX_RSBIT_THRESH,
+               .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
+                            ETH_TXQ_FLAGS_NOOFFLOADS,
+       };
+
+       dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ;
+#if RTE_VER_MAJOR == 2 && RTE_VER_MINOR >= 1
+       dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
+#endif
+}
+
 static uint32_t
 nfp_net_rx_queue_count(struct rte_eth_dev *dev, uint16_t queue_idx)
 {
@@ -723,6 +1119,142 @@ nfp_net_rx_queue_count(struct rte_eth_dev *dev, uint16_t queue_idx)
        return count;
 }
 
+static void
+nfp_net_dev_link_status_print(struct rte_eth_dev *dev)
+{
+       struct rte_eth_link link;
+
+       memset(&link, 0, sizeof(link));
+       nfp_net_dev_atomic_read_link_status(dev, &link);
+       if (link.link_status)
+               RTE_LOG(INFO, PMD, "Port %d: Link Up - speed %u Mbps - %s\n",
+                       (int)(dev->data->port_id), (unsigned)link.link_speed,
+                       link.link_duplex == ETH_LINK_FULL_DUPLEX
+                       ? "full-duplex" : "half-duplex");
+       else
+               RTE_LOG(INFO, PMD, " Port %d: Link Down\n",
+                       (int)(dev->data->port_id));
+
+       RTE_LOG(INFO, PMD, "PCI Address: %04d:%02d:%02d:%d\n",
+               dev->pci_dev->addr.domain, dev->pci_dev->addr.bus,
+               dev->pci_dev->addr.devid, dev->pci_dev->addr.function);
+}
+
+/* Interrupt configuration and handling */
+
+/*
+ * nfp_net_irq_unmask - Unmask an interrupt
+ *
+ * If MSI-X auto-masking is enabled clear the mask bit, otherwise
+ * clear the ICR for the entry.
+ */
+static void
+nfp_net_irq_unmask(struct rte_eth_dev *dev)
+{
+       struct nfp_net_hw *hw;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (hw->ctrl & NFP_NET_CFG_CTRL_MSIXAUTO) {
+               /* If MSI-X auto-masking is used, clear the entry */
+               rte_wmb();
+               rte_intr_enable(&dev->pci_dev->intr_handle);
+       } else {
+               /* Make sure all updates are written before un-masking */
+               rte_wmb();
+               nn_cfg_writeb(hw, NFP_NET_CFG_ICR(NFP_NET_IRQ_LSC_IDX),
+                             NFP_NET_CFG_ICR_UNMASKED);
+       }
+}
+
+static void
+nfp_net_dev_interrupt_handler(__rte_unused struct rte_intr_handle *handle,
+                             void *param)
+{
+       int64_t timeout;
+       struct rte_eth_link link;
+       struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
+
+       PMD_DRV_LOG(DEBUG, "We got a LSC interrupt!!!\n");
+
+       /* get the link status */
+       memset(&link, 0, sizeof(link));
+       nfp_net_dev_atomic_read_link_status(dev, &link);
+
+       nfp_net_link_update(dev, 0);
+
+       /* likely to up */
+       if (!link.link_status) {
+               /* handle it 1 sec later, wait it being stable */
+               timeout = NFP_NET_LINK_UP_CHECK_TIMEOUT;
+               /* likely to down */
+       } else {
+               /* handle it 4 sec later, wait it being stable */
+               timeout = NFP_NET_LINK_DOWN_CHECK_TIMEOUT;
+       }
+
+       if (rte_eal_alarm_set(timeout * 1000,
+                             nfp_net_dev_interrupt_delayed_handler,
+                             (void *)dev) < 0) {
+               RTE_LOG(ERR, PMD, "Error setting alarm");
+               /* Unmasking */
+               nfp_net_irq_unmask(dev);
+       }
+}
+
+/*
+ * Interrupt handler which shall be registered for alarm callback for delayed
+ * handling specific interrupt to wait for the stable nic state. As the NIC
+ * interrupt state is not stable for nfp after link is just down, it needs
+ * to wait 4 seconds to get the stable status.
+ *
+ * @param handle   Pointer to interrupt handle.
+ * @param param    The address of parameter (struct rte_eth_dev *)
+ *
+ * @return  void
+ */
+static void
+nfp_net_dev_interrupt_delayed_handler(void *param)
+{
+       struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
+
+       nfp_net_link_update(dev, 0);
+       _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC);
+
+       nfp_net_dev_link_status_print(dev);
+
+       /* Unmasking */
+       nfp_net_irq_unmask(dev);
+}
+
+static int
+nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
+{
+       struct nfp_net_hw *hw;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       /* check that mtu is within the allowed range */
+       if ((mtu < ETHER_MIN_MTU) || ((uint32_t)mtu > hw->max_mtu))
+               return -EINVAL;
+
+       /* switch to jumbo mode if needed */
+       if ((uint32_t)mtu > ETHER_MAX_LEN)
+               dev->data->dev_conf.rxmode.jumbo_frame = 1;
+       else
+               dev->data->dev_conf.rxmode.jumbo_frame = 0;
+
+       /* update max frame size */
+       dev->data->dev_conf.rxmode.max_rx_pkt_len = (uint32_t)mtu;
+
+       /* writing to configuration space */
+       nn_cfg_writel(hw, NFP_NET_CFG_MTU, (uint32_t)mtu);
+
+       hw->mtu = mtu;
+
+       return 0;
+}
+
 static int
 nfp_net_rx_queue_setup(struct rte_eth_dev *dev,
                       uint16_t queue_idx, uint16_t nb_desc,
@@ -743,7 +1275,7 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,
            (nb_desc > NFP_NET_MAX_RX_DESC) ||
            (nb_desc < NFP_NET_MIN_RX_DESC)) {
                RTE_LOG(ERR, PMD, "Wrong nb_desc value\n");
-               return (-EINVAL);
+               return -EINVAL;
        }
 
        /*
@@ -759,7 +1291,7 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,
        rxq = rte_zmalloc_socket("ethdev RX queue", sizeof(struct nfp_net_rxq),
                                 RTE_CACHE_LINE_SIZE, socket_id);
        if (rxq == NULL)
-               return (-ENOMEM);
+               return -ENOMEM;
 
        /* Hw queues mapping based on firmware confifguration */
        rxq->qidx = queue_idx;
@@ -796,7 +1328,7 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,
        if (tz == NULL) {
                RTE_LOG(ERR, PMD, "Error allocatig rx dma\n");
                nfp_net_rx_queue_release(rxq);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        /* Saving physical and virtual addresses for the RX ring */
@@ -809,7 +1341,7 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,
                                         RTE_CACHE_LINE_SIZE, socket_id);
        if (rxq->rxbufs == NULL) {
                nfp_net_rx_queue_release(rxq);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        PMD_RX_LOG(DEBUG, "rxbufs=%p hw_ring=%p dma_addr=0x%" PRIx64 "\n",
@@ -847,7 +1379,7 @@ nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq)
                if (mbuf == NULL) {
                        RTE_LOG(ERR, PMD, "RX mbuf alloc failed queue_id=%u\n",
                                (unsigned)rxq->qidx);
-                       return (-ENOMEM);
+                       return -ENOMEM;
                }
 
                dma_addr = rte_cpu_to_le_64(RTE_MBUF_DMA_ADDR_DEFAULT(mbuf));
@@ -925,7 +1457,7 @@ nfp_net_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                                 RTE_CACHE_LINE_SIZE, socket_id);
        if (txq == NULL) {
                RTE_LOG(ERR, PMD, "Error allocating tx dma\n");
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        /*
@@ -939,7 +1471,7 @@ nfp_net_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
        if (tz == NULL) {
                RTE_LOG(ERR, PMD, "Error allocating tx dma\n");
                nfp_net_tx_queue_release(txq);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
 
        txq->tx_count = nb_desc;
@@ -967,7 +1499,7 @@ nfp_net_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
                                         RTE_CACHE_LINE_SIZE, socket_id);
        if (txq->txbufs == NULL) {
                nfp_net_tx_queue_release(txq);
-               return (-ENOMEM);
+               return -ENOMEM;
        }
        PMD_TX_LOG(DEBUG, "txbufs=%p hw_ring=%p dma_addr=0x%" PRIx64 "\n",
                   txq->txbufs, txq->txds, (unsigned long int)txq->dma);
@@ -1501,6 +2033,41 @@ xmit_end:
        return i;
 }
 
+static void
+nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask)
+{
+       uint32_t new_ctrl, update;
+       struct nfp_net_hw *hw;
+
+       hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       new_ctrl = 0;
+
+       if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
+           (mask & ETH_VLAN_FILTER_OFFLOAD))
+               RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
+                       " ETH_VLAN_FILTER_EXTEND");
+
+       /* Enable vlan strip if it is not configured yet */
+       if ((mask & ETH_VLAN_STRIP_OFFLOAD) &&
+           !(hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN))
+               new_ctrl = hw->ctrl | NFP_NET_CFG_CTRL_RXVLAN;
+
+       /* Disable vlan strip just if it is configured */
+       if (!(mask & ETH_VLAN_STRIP_OFFLOAD) &&
+           (hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN))
+               new_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_RXVLAN;
+
+       if (new_ctrl == 0)
+               return;
+
+       update = NFP_NET_CFG_UPDATE_GEN;
+
+       if (nfp_net_reconfig(hw, new_ctrl, update) < 0)
+               return;
+
+       hw->ctrl = new_ctrl;
+}
+
 /* Update Redirection Table(RETA) of Receive Side Scaling of Ethernet device */
 static int
 nfp_net_reta_update(struct rte_eth_dev *dev,
@@ -1721,6 +2288,14 @@ static struct eth_dev_ops nfp_net_eth_dev_ops = {
        .dev_start              = nfp_net_start,
        .dev_stop               = nfp_net_stop,
        .dev_close              = nfp_net_close,
+       .promiscuous_enable     = nfp_net_promisc_enable,
+       .promiscuous_disable    = nfp_net_promisc_disable,
+       .link_update            = nfp_net_link_update,
+       .stats_get              = nfp_net_stats_get,
+       .stats_reset            = nfp_net_stats_reset,
+       .dev_infos_get          = nfp_net_infos_get,
+       .mtu_set                = nfp_net_dev_mtu_set,
+       .vlan_offload_set       = nfp_net_vlan_offload_set,
        .reta_update            = nfp_net_reta_update,
        .reta_query             = nfp_net_reta_query,
        .rss_hash_update        = nfp_net_rss_hash_update,
@@ -1852,6 +2427,20 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
                     hw->mac_addr[0], hw->mac_addr[1], hw->mac_addr[2],
                     hw->mac_addr[3], hw->mac_addr[4], hw->mac_addr[5]);
 
+       /* Registering LSC interrupt handler */
+       rte_intr_callback_register(&pci_dev->intr_handle,
+                                  nfp_net_dev_interrupt_handler,
+                                  (void *)eth_dev);
+
+       /* enable uio intr after callback register */
+       rte_intr_enable(&pci_dev->intr_handle);
+
+       /* Telling the firmware about the LSC interrupt entry */
+       nn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);
+
+       /* Recording current stats counters values */
+       nfp_net_stats_reset(eth_dev);
+
        return 0;
 }