net/nfp: fix possible memory leak

[dpdk.git] / drivers / net / nfp / nfp_nspu.c

diff --git a/drivers/net/nfp/nfp_nspu.c b/drivers/net/nfp/nfp_nspu.c
index 3c8cdad..f908983 100644 (file)
--- a/drivers/net/nfp/nfp_nspu.c
+++ b/drivers/net/nfp/nfp_nspu.c
@@ -341,7 +341,12 @@ nfp_fw_upload(nspu_desc_t *nspu_desc)
                return -ENOENT;
        }
 
-       fstat(fw_f, &file_stat);
+       if (fstat(fw_f, &file_stat) < 0) {
+               RTE_LOG(INFO, PMD, "Firmware file %s/%s size is unknown",
+                       DEFAULT_FW_PATH, DEFAULT_FW_FILENAME);
+               close(fw_f);
+               return -ENOENT;
+       }
 
        fsize = file_stat.st_size;
        RTE_LOG(DEBUG, PMD, "Firmware file with size: %" PRIu64 "\n",
@@ -561,6 +566,7 @@ nfp_nsp_eth_config(nspu_desc_t *desc, int port, int up)
                           NSP_ETH_TABLE_SIZE, 0);
        if (ret) {
                rte_spinlock_unlock(&desc->nsp_lock);
+               free(entries);
                return ret;
        }
 
@@ -581,6 +587,7 @@ nfp_nsp_eth_config(nspu_desc_t *desc, int port, int up)
 
        if (i == NSP_ETH_MAX_COUNT) {
                rte_spinlock_unlock(&desc->nsp_lock);
+               free(entries);
                return -EINVAL;
        }
 
@@ -605,6 +612,7 @@ nfp_nsp_eth_config(nspu_desc_t *desc, int port, int up)
                                "Hw ethernet port %d configure failed\n", port);
        }
        rte_spinlock_unlock(&desc->nsp_lock);
+       free(entries);
        return ret;
 }
 
@@ -613,10 +621,14 @@ nfp_nsp_eth_read_table(nspu_desc_t *desc, union eth_table_entry **table)
 {
        int ret;
 
+       if (!table)
+               return -EINVAL;
+
        RTE_LOG(INFO, PMD, "Reading hw ethernet table...\n");
+
        /* port 0 allocates the eth table and read it using NSPU */
        *table = malloc(NSP_ETH_TABLE_SIZE);
-       if (!table)
+       if (!*table)
                return -ENOMEM;
 
        ret = nspu_command(desc, NSP_CMD_READ_ETH_TABLE, 1, 0, *table,