ethdev: return diagnostic when setting MAC address
[dpdk.git] / drivers / net / null / rte_eth_null.c
index bf81b1b..74dde95 100644 (file)
  */
 
 #include <rte_mbuf.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
+#include <rte_ethdev_vdev.h>
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
-#include <rte_dev.h>
+#include <rte_bus_vdev.h>
 #include <rte_kvargs.h>
+#include <rte_spinlock.h>
 
 #define ETH_NULL_PACKET_SIZE_ARG       "size"
 #define ETH_NULL_PACKET_COPY_ARG       "copy"
@@ -66,22 +68,28 @@ struct null_queue {
 struct pmd_internals {
        unsigned packet_size;
        unsigned packet_copy;
-       unsigned numa_node;
-
-       unsigned nb_rx_queues;
-       unsigned nb_tx_queues;
+       uint16_t port_id;
 
        struct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];
        struct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT];
-};
 
+       struct ether_addr eth_addr;
+       /** Bit mask of RSS offloads, the bit offset also means flow type */
+       uint64_t flow_type_rss_offloads;
+
+       rte_spinlock_t rss_lock;
 
-static struct ether_addr eth_addr = { .addr_bytes = {0} };
-static const char *drivername = "Null PMD";
+       uint16_t reta_size;
+       struct rte_eth_rss_reta_entry64 reta_conf[ETH_RSS_RETA_SIZE_128 /
+                       RTE_RETA_GROUP_SIZE];
+
+       uint8_t rss_key[40];                /**< 40-byte hash key. */
+};
 static struct rte_eth_link pmd_link = {
-       .link_speed = 10000,
+       .link_speed = ETH_SPEED_NUM_10G,
        .link_duplex = ETH_LINK_FULL_DUPLEX,
-       .link_status = 0
+       .link_status = ETH_LINK_DOWN,
+       .link_autoneg = ETH_LINK_AUTONEG,
 };
 
 static uint16_t
@@ -95,14 +103,13 @@ eth_null_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
                return 0;
 
        packet_size = h->internals->packet_size;
+       if (rte_pktmbuf_alloc_bulk(h->mb_pool, bufs, nb_bufs) != 0)
+               return 0;
+
        for (i = 0; i < nb_bufs; i++) {
-               bufs[i] = rte_pktmbuf_alloc(h->mb_pool);
-               if (!bufs[i])
-                       break;
                bufs[i]->data_len = (uint16_t)packet_size;
                bufs[i]->pkt_len = packet_size;
-               bufs[i]->nb_segs = 1;
-               bufs[i]->next = NULL;
+               bufs[i]->port = h->internals->port_id;
        }
 
        rte_atomic64_add(&(h->rx_pkts), i);
@@ -121,16 +128,15 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
                return 0;
 
        packet_size = h->internals->packet_size;
+       if (rte_pktmbuf_alloc_bulk(h->mb_pool, bufs, nb_bufs) != 0)
+               return 0;
+
        for (i = 0; i < nb_bufs; i++) {
-               bufs[i] = rte_pktmbuf_alloc(h->mb_pool);
-               if (!bufs[i])
-                       break;
                rte_memcpy(rte_pktmbuf_mtod(bufs[i], void *), h->dummy_packet,
                                        packet_size);
                bufs[i]->data_len = (uint16_t)packet_size;
                bufs[i]->pkt_len = packet_size;
-               bufs[i]->nb_segs = 1;
-               bufs[i]->next = NULL;
+               bufs[i]->port = h->internals->port_id;
        }
 
        rte_atomic64_add(&(h->rx_pkts), i);
@@ -178,13 +184,8 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 }
 
 static int
-eth_dev_configure(struct rte_eth_dev *dev) {
-       struct pmd_internals *internals;
-
-       internals = dev->data->dev_private;
-       internals->nb_rx_queues = dev->data->nb_rx_queues;
-       internals->nb_tx_queues = dev->data->nb_tx_queues;
-
+eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
+{
        return 0;
 }
 
@@ -194,7 +195,7 @@ eth_dev_start(struct rte_eth_dev *dev)
        if (dev == NULL)
                return -EINVAL;
 
-       dev->data->dev_link.link_status = 1;
+       dev->data->dev_link.link_status = ETH_LINK_UP;
        return 0;
 }
 
@@ -204,7 +205,7 @@ eth_dev_stop(struct rte_eth_dev *dev)
        if (dev == NULL)
                return;
 
-       dev->data->dev_link.link_status = 0;
+       dev->data->dev_link.link_status = ETH_LINK_DOWN;
 }
 
 static int
@@ -223,7 +224,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
 
        internals = dev->data->dev_private;
 
-       if (rx_queue_id >= internals->nb_rx_queues)
+       if (rx_queue_id >= dev->data->nb_rx_queues)
                return -ENODEV;
 
        packet_size = internals->packet_size;
@@ -232,7 +233,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
        dev->data->rx_queues[rx_queue_id] =
                &internals->rx_null_queues[rx_queue_id];
        dummy_packet = rte_zmalloc_socket(NULL,
-                       packet_size, 0, internals->numa_node);
+                       packet_size, 0, dev->data->numa_node);
        if (dummy_packet == NULL)
                return -ENOMEM;
 
@@ -257,7 +258,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
 
        internals = dev->data->dev_private;
 
-       if (tx_queue_id >= internals->nb_tx_queues)
+       if (tx_queue_id >= dev->data->nb_tx_queues)
                return -ENODEV;
 
        packet_size = internals->packet_size;
@@ -265,7 +266,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
        dev->data->tx_queues[tx_queue_id] =
                &internals->tx_null_queues[tx_queue_id];
        dummy_packet = rte_zmalloc_socket(NULL,
-                       packet_size, 0, internals->numa_node);
+                       packet_size, 0, dev->data->numa_node);
        if (dummy_packet == NULL)
                return -ENOMEM;
 
@@ -275,6 +276,11 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
        return 0;
 }
 
+static int
+eth_mtu_set(struct rte_eth_dev *dev __rte_unused, uint16_t mtu __rte_unused)
+{
+       return 0;
+}
 
 static void
 eth_dev_info(struct rte_eth_dev *dev,
@@ -286,16 +292,16 @@ eth_dev_info(struct rte_eth_dev *dev,
                return;
 
        internals = dev->data->dev_private;
-       dev_info->driver_name = drivername;
        dev_info->max_mac_addrs = 1;
        dev_info->max_rx_pktlen = (uint32_t)-1;
        dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);
        dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);
        dev_info->min_rx_bufsize = 0;
-       dev_info->pci_dev = NULL;
+       dev_info->reta_size = internals->reta_size;
+       dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads;
 }
 
-static void
+static int
 eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 {
        unsigned i, num_stats;
@@ -303,11 +309,11 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
        const struct pmd_internals *internal;
 
        if ((dev == NULL) || (igb_stats == NULL))
-               return;
+               return -EINVAL;
 
        internal = dev->data->dev_private;
        num_stats = RTE_MIN((unsigned)RTE_ETHDEV_QUEUE_STAT_CNTRS,
-                       RTE_MIN(internal->nb_rx_queues,
+                       RTE_MIN(dev->data->nb_rx_queues,
                                RTE_DIM(internal->rx_null_queues)));
        for (i = 0; i < num_stats; i++) {
                igb_stats->q_ipackets[i] =
@@ -316,7 +322,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
        }
 
        num_stats = RTE_MIN((unsigned)RTE_ETHDEV_QUEUE_STAT_CNTRS,
-                       RTE_MIN(internal->nb_tx_queues,
+                       RTE_MIN(dev->data->nb_tx_queues,
                                RTE_DIM(internal->tx_null_queues)));
        for (i = 0; i < num_stats; i++) {
                igb_stats->q_opackets[i] =
@@ -330,6 +336,8 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
        igb_stats->ipackets = rx_total;
        igb_stats->opackets = tx_total;
        igb_stats->oerrors = tx_err_total;
+
+       return 0;
 }
 
 static void
@@ -350,13 +358,6 @@ eth_stats_reset(struct rte_eth_dev *dev)
        }
 }
 
-static struct eth_driver rte_null_pmd = {
-       .pci_drv = {
-               .name = "rte_null_pmd",
-               .drv_flags = RTE_PCI_DRV_DETACHABLE,
-       },
-};
-
 static void
 eth_queue_release(void *q)
 {
@@ -373,6 +374,98 @@ static int
 eth_link_update(struct rte_eth_dev *dev __rte_unused,
                int wait_to_complete __rte_unused) { return 0; }
 
+static int
+eth_rss_reta_update(struct rte_eth_dev *dev,
+               struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size)
+{
+       int i, j;
+       struct pmd_internals *internal = dev->data->dev_private;
+
+       if (reta_size != internal->reta_size)
+               return -EINVAL;
+
+       rte_spinlock_lock(&internal->rss_lock);
+
+       /* Copy RETA table */
+       for (i = 0; i < (internal->reta_size / RTE_RETA_GROUP_SIZE); i++) {
+               internal->reta_conf[i].mask = reta_conf[i].mask;
+               for (j = 0; j < RTE_RETA_GROUP_SIZE; j++)
+                       if ((reta_conf[i].mask >> j) & 0x01)
+                               internal->reta_conf[i].reta[j] = reta_conf[i].reta[j];
+       }
+
+       rte_spinlock_unlock(&internal->rss_lock);
+
+       return 0;
+}
+
+static int
+eth_rss_reta_query(struct rte_eth_dev *dev,
+               struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size)
+{
+       int i, j;
+       struct pmd_internals *internal = dev->data->dev_private;
+
+       if (reta_size != internal->reta_size)
+               return -EINVAL;
+
+       rte_spinlock_lock(&internal->rss_lock);
+
+       /* Copy RETA table */
+       for (i = 0; i < (internal->reta_size / RTE_RETA_GROUP_SIZE); i++) {
+               for (j = 0; j < RTE_RETA_GROUP_SIZE; j++)
+                       if ((reta_conf[i].mask >> j) & 0x01)
+                               reta_conf[i].reta[j] = internal->reta_conf[i].reta[j];
+       }
+
+       rte_spinlock_unlock(&internal->rss_lock);
+
+       return 0;
+}
+
+static int
+eth_rss_hash_update(struct rte_eth_dev *dev, struct rte_eth_rss_conf *rss_conf)
+{
+       struct pmd_internals *internal = dev->data->dev_private;
+
+       rte_spinlock_lock(&internal->rss_lock);
+
+       if ((rss_conf->rss_hf & internal->flow_type_rss_offloads) != 0)
+               dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf =
+                               rss_conf->rss_hf & internal->flow_type_rss_offloads;
+
+       if (rss_conf->rss_key)
+               rte_memcpy(internal->rss_key, rss_conf->rss_key, 40);
+
+       rte_spinlock_unlock(&internal->rss_lock);
+
+       return 0;
+}
+
+static int
+eth_rss_hash_conf_get(struct rte_eth_dev *dev,
+               struct rte_eth_rss_conf *rss_conf)
+{
+       struct pmd_internals *internal = dev->data->dev_private;
+
+       rte_spinlock_lock(&internal->rss_lock);
+
+       rss_conf->rss_hf = dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf;
+       if (rss_conf->rss_key)
+               rte_memcpy(rss_conf->rss_key, internal->rss_key, 40);
+
+       rte_spinlock_unlock(&internal->rss_lock);
+
+       return 0;
+}
+
+static int
+eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
+                   __rte_unused struct ether_addr *addr)
+{
+       return 0;
+}
+
 static const struct eth_dev_ops ops = {
        .dev_start = eth_dev_start,
        .dev_stop = eth_dev_stop,
@@ -382,81 +475,84 @@ static const struct eth_dev_ops ops = {
        .tx_queue_setup = eth_tx_queue_setup,
        .rx_queue_release = eth_queue_release,
        .tx_queue_release = eth_queue_release,
+       .mtu_set = eth_mtu_set,
        .link_update = eth_link_update,
+       .mac_addr_set = eth_mac_address_set,
        .stats_get = eth_stats_get,
        .stats_reset = eth_stats_reset,
+       .reta_update = eth_rss_reta_update,
+       .reta_query = eth_rss_reta_query,
+       .rss_hash_update = eth_rss_hash_update,
+       .rss_hash_conf_get = eth_rss_hash_conf_get
 };
 
+static struct rte_vdev_driver pmd_null_drv;
+
 static int
-eth_dev_null_create(const char *name,
-               const unsigned numa_node,
+eth_dev_null_create(struct rte_vdev_device *dev,
                unsigned packet_size,
                unsigned packet_copy)
 {
        const unsigned nb_rx_queues = 1;
        const unsigned nb_tx_queues = 1;
        struct rte_eth_dev_data *data = NULL;
-       struct rte_pci_device *pci_dev = NULL;
        struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
 
-       if (name == NULL)
-               return -EINVAL;
+       static const uint8_t default_rss_key[40] = {
+               0x6D, 0x5A, 0x56, 0xDA, 0x25, 0x5B, 0x0E, 0xC2, 0x41, 0x67, 0x25, 0x3D,
+               0x43, 0xA3, 0x8F, 0xB0, 0xD0, 0xCA, 0x2B, 0xCB, 0xAE, 0x7B, 0x30, 0xB4,
+               0x77, 0xCB, 0x2D, 0xA3, 0x80, 0x30, 0xF2, 0x0C, 0x6A, 0x42, 0xB7, 0x3B,
+               0xBE, 0xAC, 0x01, 0xFA
+       };
+
+       if (dev->device.numa_node == SOCKET_ID_ANY)
+               dev->device.numa_node = rte_socket_id();
 
        RTE_LOG(INFO, PMD, "Creating null ethdev on numa socket %u\n",
-                       numa_node);
+               dev->device.numa_node);
 
        /* now do all data allocation - for eth_dev structure, dummy pci driver
         * and internal (private) data
         */
-       data = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);
-       if (data == NULL)
-               goto error;
-
-       pci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);
-       if (pci_dev == NULL)
-               goto error;
-
-       internals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);
-       if (internals == NULL)
-               goto error;
-
-       /* reserve an ethdev entry */
-       eth_dev = rte_eth_dev_allocate(name, RTE_ETH_DEV_VIRTUAL);
-       if (eth_dev == NULL)
-               goto error;
+       data = rte_zmalloc_socket(rte_vdev_device_name(dev), sizeof(*data), 0,
+               dev->device.numa_node);
+       if (!data)
+               return -ENOMEM;
 
+       eth_dev = rte_eth_vdev_allocate(dev, sizeof(*internals));
+       if (!eth_dev) {
+               rte_free(data);
+               return -ENOMEM;
+       }
        /* now put it all together
         * - store queue data in internals,
-        * - store numa_node info in pci_driver
-        * - point eth_dev_data to internals and pci_driver
+        * - store numa_node info in ethdev data
+        * - point eth_dev_data to internals
         * - and point eth_dev structure to new eth_dev_data structure
         */
        /* NOTE: we'll replace the data element, of originally allocated eth_dev
         * so the nulls are local per-process */
 
-       internals->nb_rx_queues = nb_rx_queues;
-       internals->nb_tx_queues = nb_tx_queues;
+       internals = eth_dev->data->dev_private;
        internals->packet_size = packet_size;
        internals->packet_copy = packet_copy;
-       internals->numa_node = numa_node;
+       internals->port_id = eth_dev->data->port_id;
+       eth_random_addr(internals->eth_addr.addr_bytes);
+
+       internals->flow_type_rss_offloads =  ETH_RSS_PROTO_MASK;
+       internals->reta_size = RTE_DIM(internals->reta_conf) * RTE_RETA_GROUP_SIZE;
 
-       pci_dev->numa_node = numa_node;
-       pci_dev->driver = &rte_null_pmd.pci_drv;
+       rte_memcpy(internals->rss_key, default_rss_key, 40);
 
-       data->dev_private = internals;
-       data->port_id = eth_dev->data->port_id;
+       rte_memcpy(data, eth_dev->data, sizeof(*data));
        data->nb_rx_queues = (uint16_t)nb_rx_queues;
        data->nb_tx_queues = (uint16_t)nb_tx_queues;
        data->dev_link = pmd_link;
-       data->mac_addrs = &eth_addr;
-       strncpy(data->name, eth_dev->data->name, strlen(eth_dev->data->name));
+       data->mac_addrs = &internals->eth_addr;
 
        eth_dev->data = data;
        eth_dev->dev_ops = &ops;
-       eth_dev->pci_dev = pci_dev;
-       eth_dev->driver = &rte_null_pmd;
-       TAILQ_INIT(&eth_dev->link_intr_cbs);
 
        /* finally assign rx and tx ops */
        if (packet_copy) {
@@ -468,13 +564,6 @@ eth_dev_null_create(const char *name,
        }
 
        return 0;
-
-error:
-       rte_free(data);
-       rte_free(pci_dev);
-       rte_free(internals);
-
-       return -1;
 }
 
 static inline int
@@ -512,21 +601,21 @@ get_packet_copy_arg(const char *key __rte_unused,
 }
 
 static int
-rte_pmd_null_devinit(const char *name, const char *params)
+rte_pmd_null_probe(struct rte_vdev_device *dev)
 {
-       unsigned numa_node;
+       const char *name, *params;
        unsigned packet_size = default_packet_size;
        unsigned packet_copy = default_packet_copy;
        struct rte_kvargs *kvlist = NULL;
        int ret;
 
-       if (name == NULL)
+       if (!dev)
                return -EINVAL;
 
+       name = rte_vdev_device_name(dev);
+       params = rte_vdev_device_args(dev);
        RTE_LOG(INFO, PMD, "Initializing pmd_null for %s\n", name);
 
-       numa_node = rte_socket_id();
-
        if (params != NULL) {
                kvlist = rte_kvargs_parse(params, valid_arguments);
                if (kvlist == NULL)
@@ -555,7 +644,7 @@ rte_pmd_null_devinit(const char *name, const char *params)
                        "packet copy is %s\n", packet_size,
                        packet_copy ? "enabled" : "disabled");
 
-       ret = eth_dev_null_create(name, numa_node, packet_size, packet_copy);
+       ret = eth_dev_null_create(dev, packet_size, packet_copy);
 
 free_kvlist:
        if (kvlist)
@@ -564,35 +653,36 @@ free_kvlist:
 }
 
 static int
-rte_pmd_null_devuninit(const char *name)
+rte_pmd_null_remove(struct rte_vdev_device *dev)
 {
        struct rte_eth_dev *eth_dev = NULL;
 
-       if (name == NULL)
+       if (!dev)
                return -EINVAL;
 
        RTE_LOG(INFO, PMD, "Closing null ethdev on numa socket %u\n",
                        rte_socket_id());
 
-       /* reserve an ethdev entry */
-       eth_dev = rte_eth_dev_allocated(name);
+       /* find the ethdev entry */
+       eth_dev = rte_eth_dev_allocated(rte_vdev_device_name(dev));
        if (eth_dev == NULL)
                return -1;
 
        rte_free(eth_dev->data->dev_private);
        rte_free(eth_dev->data);
-       rte_free(eth_dev->pci_dev);
 
        rte_eth_dev_release_port(eth_dev);
 
        return 0;
 }
 
-static struct rte_driver pmd_null_drv = {
-       .name = "eth_null",
-       .type = PMD_VDEV,
-       .init = rte_pmd_null_devinit,
-       .uninit = rte_pmd_null_devuninit,
+static struct rte_vdev_driver pmd_null_drv = {
+       .probe = rte_pmd_null_probe,
+       .remove = rte_pmd_null_remove,
 };
 
-PMD_REGISTER_DRIVER(pmd_null_drv);
+RTE_PMD_REGISTER_VDEV(net_null, pmd_null_drv);
+RTE_PMD_REGISTER_ALIAS(net_null, eth_null);
+RTE_PMD_REGISTER_PARAM_STRING(net_null,
+       "size=<int> "
+       "copy=<int>");