net: add rte prefix to ether structures
[dpdk.git] / drivers / net / pcap / rte_eth_pcap.c
index 3a40e84..7655b3a 100644 (file)
@@ -1,60 +1,44 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
- *   Copyright(c) 2014 6WIND S.A.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2016 Intel Corporation.
+ * Copyright(c) 2014 6WIND S.A.
+ * All rights reserved.
  */
 
 #include <time.h>
-#include <rte_mbuf.h>
-#include <rte_ethdev.h>
-#include <rte_malloc.h>
-#include <rte_memcpy.h>
-#include <rte_string_fns.h>
-#include <rte_cycles.h>
-#include <rte_kvargs.h>
-#include <rte_vdev.h>
 
 #include <net/if.h>
+#include <sys/socket.h>
+#include <sys/ioctl.h>
+#include <unistd.h>
+
+#if defined(RTE_EXEC_ENV_FREEBSD)
+#include <sys/sysctl.h>
+#include <net/if_dl.h>
+#endif
 
 #include <pcap.h>
 
+#include <rte_cycles.h>
+#include <rte_ethdev_driver.h>
+#include <rte_ethdev_vdev.h>
+#include <rte_kvargs.h>
+#include <rte_malloc.h>
+#include <rte_mbuf.h>
+#include <rte_bus_vdev.h>
+#include <rte_string_fns.h>
+
 #define RTE_ETH_PCAP_SNAPSHOT_LEN 65535
 #define RTE_ETH_PCAP_SNAPLEN ETHER_MAX_JUMBO_FRAME_LEN
 #define RTE_ETH_PCAP_PROMISC 1
 #define RTE_ETH_PCAP_TIMEOUT -1
+
 #define ETH_PCAP_RX_PCAP_ARG  "rx_pcap"
 #define ETH_PCAP_TX_PCAP_ARG  "tx_pcap"
 #define ETH_PCAP_RX_IFACE_ARG "rx_iface"
+#define ETH_PCAP_RX_IFACE_IN_ARG "rx_iface_in"
 #define ETH_PCAP_TX_IFACE_ARG "tx_iface"
 #define ETH_PCAP_IFACE_ARG    "iface"
+#define ETH_PCAP_PHY_MAC_ARG  "phy_mac"
 
 #define ETH_PCAP_ARG_MAXLEN    64
 
@@ -65,24 +49,27 @@ static unsigned char tx_pcap_data[RTE_ETH_PCAP_SNAPLEN];
 static struct timeval start_time;
 static uint64_t start_cycles;
 static uint64_t hz;
+static uint8_t iface_idx;
+
+struct queue_stat {
+       volatile unsigned long pkts;
+       volatile unsigned long bytes;
+       volatile unsigned long err_pkts;
+};
 
 struct pcap_rx_queue {
-       pcap_t *pcap;
-       uint8_t in_port;
+       uint16_t port_id;
+       uint16_t queue_id;
        struct rte_mempool *mb_pool;
-       volatile unsigned long rx_pkts;
-       volatile unsigned long rx_bytes;
-       volatile unsigned long err_pkts;
+       struct queue_stat rx_stat;
        char name[PATH_MAX];
        char type[ETH_PCAP_ARG_MAXLEN];
 };
 
 struct pcap_tx_queue {
-       pcap_dumper_t *dumper;
-       pcap_t *pcap;
-       volatile unsigned long tx_pkts;
-       volatile unsigned long tx_bytes;
-       volatile unsigned long err_pkts;
+       uint16_t port_id;
+       uint16_t queue_id;
+       struct queue_stat tx_stat;
        char name[PATH_MAX];
        char type[ETH_PCAP_ARG_MAXLEN];
 };
@@ -90,52 +77,61 @@ struct pcap_tx_queue {
 struct pmd_internals {
        struct pcap_rx_queue rx_queue[RTE_PMD_PCAP_MAX_QUEUES];
        struct pcap_tx_queue tx_queue[RTE_PMD_PCAP_MAX_QUEUES];
+       char devargs[ETH_PCAP_ARG_MAXLEN];
+       struct rte_ether_addr eth_addr;
        int if_index;
        int single_iface;
+       int phy_mac;
+};
+
+struct pmd_process_private {
+       pcap_t *rx_pcap[RTE_PMD_PCAP_MAX_QUEUES];
+       pcap_t *tx_pcap[RTE_PMD_PCAP_MAX_QUEUES];
+       pcap_dumper_t *tx_dumper[RTE_PMD_PCAP_MAX_QUEUES];
 };
 
 struct pmd_devargs {
-       unsigned num_of_queue;
+       unsigned int num_of_queue;
        struct devargs_queue {
                pcap_dumper_t *dumper;
                pcap_t *pcap;
                const char *name;
                const char *type;
        } queue[RTE_PMD_PCAP_MAX_QUEUES];
+       int phy_mac;
 };
 
-const char *valid_arguments[] = {
+static const char *valid_arguments[] = {
        ETH_PCAP_RX_PCAP_ARG,
        ETH_PCAP_TX_PCAP_ARG,
        ETH_PCAP_RX_IFACE_ARG,
+       ETH_PCAP_RX_IFACE_IN_ARG,
        ETH_PCAP_TX_IFACE_ARG,
        ETH_PCAP_IFACE_ARG,
+       ETH_PCAP_PHY_MAC_ARG,
        NULL
 };
 
-static int open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper);
-static int open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap);
-static int open_single_iface(const char *iface, pcap_t **pcap);
-
-static struct ether_addr eth_addr = { .addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 } };
-static const char *drivername = "Pcap PMD";
 static struct rte_eth_link pmd_link = {
                .link_speed = ETH_SPEED_NUM_10G,
                .link_duplex = ETH_LINK_FULL_DUPLEX,
                .link_status = ETH_LINK_DOWN,
-               .link_autoneg = ETH_LINK_SPEED_FIXED,
+               .link_autoneg = ETH_LINK_FIXED,
 };
 
+static int eth_pcap_logtype;
+
+#define PMD_LOG(level, fmt, args...) \
+       rte_log(RTE_LOG_ ## level, eth_pcap_logtype, \
+               "%s(): " fmt "\n", __func__, ##args)
+
 static int
-eth_pcap_rx_jumbo(struct rte_mempool *mb_pool,
-                 struct rte_mbuf *mbuf,
-                 const u_char *data,
-                 uint16_t data_len)
+eth_pcap_rx_jumbo(struct rte_mempool *mb_pool, struct rte_mbuf *mbuf,
+               const u_char *data, uint16_t data_len)
 {
-       struct rte_mbuf *m = mbuf;
-
        /* Copy the first segment. */
        uint16_t len = rte_pktmbuf_tailroom(mbuf);
+       struct rte_mbuf *m = mbuf;
 
        rte_memcpy(rte_pktmbuf_append(mbuf, len), data, len);
        data_len -= len;
@@ -175,7 +171,7 @@ eth_pcap_gather_data(unsigned char *data, struct rte_mbuf *mbuf)
 
        while (mbuf) {
                rte_memcpy(data + data_len, rte_pktmbuf_mtod(mbuf, void *),
-                          mbuf->data_len);
+                       mbuf->data_len);
 
                data_len += mbuf->data_len;
                mbuf = mbuf->next;
@@ -183,20 +179,23 @@ eth_pcap_gather_data(unsigned char *data, struct rte_mbuf *mbuf)
 }
 
 static uint16_t
-eth_pcap_rx(void *queue,
-               struct rte_mbuf **bufs,
-               uint16_t nb_pkts)
+eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        struct pcap_pkthdr header;
+       struct pmd_process_private *pp;
        const u_char *packet;
        struct rte_mbuf *mbuf;
        struct pcap_rx_queue *pcap_q = queue;
        uint16_t num_rx = 0;
        uint16_t buf_size;
        uint32_t rx_bytes = 0;
+       pcap_t *pcap;
 
-       if (unlikely(pcap_q->pcap == NULL || nb_pkts == 0))
+       pp = rte_eth_devices[pcap_q->port_id].process_private;
+       pcap = pp->rx_pcap[pcap_q->queue_id];
+
+       if (unlikely(pcap == NULL || nb_pkts == 0))
                return 0;
 
        /* Reads the given number of packets from the pcap file one by one
@@ -204,20 +203,20 @@ eth_pcap_rx(void *queue,
         */
        for (i = 0; i < nb_pkts; i++) {
                /* Get the next PCAP packet */
-               packet = pcap_next(pcap_q->pcap, &header);
+               packet = pcap_next(pcap, &header);
                if (unlikely(packet == NULL))
                        break;
-               else
-                       mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
+
+               mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
                if (unlikely(mbuf == NULL))
                        break;
 
                /* Now get the space available for data in the mbuf */
-               buf_size = (uint16_t)(rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
-                               RTE_PKTMBUF_HEADROOM);
+               buf_size = rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
+                               RTE_PKTMBUF_HEADROOM;
 
                if (header.caplen <= buf_size) {
-                       /* pcap packet will fit in the mbuf, go ahead and copy */
+                       /* pcap packet will fit in the mbuf, can copy it */
                        rte_memcpy(rte_pktmbuf_mtod(mbuf, void *), packet,
                                        header.caplen);
                        mbuf->data_len = (uint16_t)header.caplen;
@@ -226,18 +225,21 @@ eth_pcap_rx(void *queue,
                        if (unlikely(eth_pcap_rx_jumbo(pcap_q->mb_pool,
                                                       mbuf,
                                                       packet,
-                                                      header.caplen) == -1))
+                                                      header.caplen) == -1)) {
+                               rte_pktmbuf_free(mbuf);
                                break;
+                       }
                }
 
                mbuf->pkt_len = (uint16_t)header.caplen;
-               mbuf->port = pcap_q->in_port;
+               mbuf->port = pcap_q->port_id;
                bufs[num_rx] = mbuf;
                num_rx++;
                rx_bytes += header.caplen;
        }
-       pcap_q->rx_pkts += num_rx;
-       pcap_q->rx_bytes += rx_bytes;
+       pcap_q->rx_stat.pkts += num_rx;
+       pcap_q->rx_stat.bytes += rx_bytes;
+
        return num_rx;
 }
 
@@ -248,7 +250,7 @@ calculate_timestamp(struct timeval *ts) {
 
        cycles = rte_get_timer_cycles() - start_cycles;
        cur_time.tv_sec = cycles / hz;
-       cur_time.tv_usec = (cycles % hz) * 10e6 / hz;
+       cur_time.tv_usec = (cycles % hz) * 1e6 / hz;
        timeradd(&start_time, &cur_time, ts);
 }
 
@@ -256,21 +258,25 @@ calculate_timestamp(struct timeval *ts) {
  * Callback to handle writing packets to a pcap file.
  */
 static uint16_t
-eth_pcap_tx_dumper(void *queue,
-               struct rte_mbuf **bufs,
-               uint16_t nb_pkts)
+eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        struct rte_mbuf *mbuf;
+       struct pmd_process_private *pp;
        struct pcap_tx_queue *dumper_q = queue;
        uint16_t num_tx = 0;
        uint32_t tx_bytes = 0;
        struct pcap_pkthdr header;
+       pcap_dumper_t *dumper;
 
-       if (dumper_q->dumper == NULL || nb_pkts == 0)
+       pp = rte_eth_devices[dumper_q->port_id].process_private;
+       dumper = pp->tx_dumper[dumper_q->queue_id];
+
+       if (dumper == NULL || nb_pkts == 0)
                return 0;
 
-       /* writes the nb_pkts packets to the previously opened pcap file dumper */
+       /* writes the nb_pkts packets to the previously opened pcap file
+        * dumper */
        for (i = 0; i < nb_pkts; i++) {
                mbuf = bufs[i];
                calculate_timestamp(&header.ts);
@@ -278,17 +284,16 @@ eth_pcap_tx_dumper(void *queue,
                header.caplen = header.len;
 
                if (likely(mbuf->nb_segs == 1)) {
-                       pcap_dump((u_char *)dumper_q->dumper, &header,
+                       pcap_dump((u_char *)dumper, &header,
                                  rte_pktmbuf_mtod(mbuf, void*));
                } else {
                        if (mbuf->pkt_len <= ETHER_MAX_JUMBO_FRAME_LEN) {
                                eth_pcap_gather_data(tx_pcap_data, mbuf);
-                               pcap_dump((u_char *)dumper_q->dumper, &header,
+                               pcap_dump((u_char *)dumper, &header,
                                          tx_pcap_data);
                        } else {
-                               RTE_LOG(ERR, PMD,
-                                       "Dropping PCAP packet. "
-                                       "Size (%d) > max jumbo size (%d).\n",
+                               PMD_LOG(ERR,
+                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).",
                                        mbuf->pkt_len,
                                        ETHER_MAX_JUMBO_FRAME_LEN);
 
@@ -297,9 +302,9 @@ eth_pcap_tx_dumper(void *queue,
                        }
                }
 
-               rte_pktmbuf_free(mbuf);
                num_tx++;
                tx_bytes += mbuf->pkt_len;
+               rte_pktmbuf_free(mbuf);
        }
 
        /*
@@ -307,10 +312,11 @@ eth_pcap_tx_dumper(void *queue,
         * process stops and to make sure the pcap file is actually written,
         * we flush the pcap dumper within each burst.
         */
-       pcap_dump_flush(dumper_q->dumper);
-       dumper_q->tx_pkts += num_tx;
-       dumper_q->tx_bytes += tx_bytes;
-       dumper_q->err_pkts += nb_pkts - num_tx;
+       pcap_dump_flush(dumper);
+       dumper_q->tx_stat.pkts += num_tx;
+       dumper_q->tx_stat.bytes += tx_bytes;
+       dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;
+
        return num_tx;
 }
 
@@ -318,37 +324,38 @@ eth_pcap_tx_dumper(void *queue,
  * Callback to handle sending packets through a real NIC.
  */
 static uint16_t
-eth_pcap_tx(void *queue,
-               struct rte_mbuf **bufs,
-               uint16_t nb_pkts)
+eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        int ret;
        struct rte_mbuf *mbuf;
+       struct pmd_process_private *pp;
        struct pcap_tx_queue *tx_queue = queue;
        uint16_t num_tx = 0;
        uint32_t tx_bytes = 0;
+       pcap_t *pcap;
 
-       if (unlikely(nb_pkts == 0 || tx_queue->pcap == NULL))
+       pp = rte_eth_devices[tx_queue->port_id].process_private;
+       pcap = pp->tx_pcap[tx_queue->queue_id];
+
+       if (unlikely(nb_pkts == 0 || pcap == NULL))
                return 0;
 
        for (i = 0; i < nb_pkts; i++) {
                mbuf = bufs[i];
 
                if (likely(mbuf->nb_segs == 1)) {
-                       ret = pcap_sendpacket(tx_queue->pcap,
-                                             rte_pktmbuf_mtod(mbuf, u_char *),
-                                             mbuf->pkt_len);
+                       ret = pcap_sendpacket(pcap,
+                                       rte_pktmbuf_mtod(mbuf, u_char *),
+                                       mbuf->pkt_len);
                } else {
                        if (mbuf->pkt_len <= ETHER_MAX_JUMBO_FRAME_LEN) {
                                eth_pcap_gather_data(tx_pcap_data, mbuf);
-                               ret = pcap_sendpacket(tx_queue->pcap,
-                                                     tx_pcap_data,
-                                                     mbuf->pkt_len);
+                               ret = pcap_sendpacket(pcap,
+                                               tx_pcap_data, mbuf->pkt_len);
                        } else {
-                               RTE_LOG(ERR, PMD,
-                                       "Dropping PCAP packet. "
-                                       "Size (%d) > max jumbo size (%d).\n",
+                               PMD_LOG(ERR,
+                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).",
                                        mbuf->pkt_len,
                                        ETHER_MAX_JUMBO_FRAME_LEN);
 
@@ -364,17 +371,88 @@ eth_pcap_tx(void *queue,
                rte_pktmbuf_free(mbuf);
        }
 
-       tx_queue->tx_pkts += num_tx;
-       tx_queue->tx_bytes += tx_bytes;
-       tx_queue->err_pkts += nb_pkts - num_tx;
+       tx_queue->tx_stat.pkts += num_tx;
+       tx_queue->tx_stat.bytes += tx_bytes;
+       tx_queue->tx_stat.err_pkts += nb_pkts - num_tx;
+
        return num_tx;
 }
 
+/*
+ * pcap_open_live wrapper function
+ */
+static inline int
+open_iface_live(const char *iface, pcap_t **pcap) {
+       *pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN,
+                       RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf);
+
+       if (*pcap == NULL) {
+               PMD_LOG(ERR, "Couldn't open %s: %s", iface, errbuf);
+               return -1;
+       }
+
+       return 0;
+}
+
+static int
+open_single_iface(const char *iface, pcap_t **pcap)
+{
+       if (open_iface_live(iface, pcap) < 0) {
+               PMD_LOG(ERR, "Couldn't open interface %s", iface);
+               return -1;
+       }
+
+       return 0;
+}
+
+static int
+open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper)
+{
+       pcap_t *tx_pcap;
+
+       /*
+        * We need to create a dummy empty pcap_t to use it
+        * with pcap_dump_open(). We create big enough an Ethernet
+        * pcap holder.
+        */
+       tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN);
+       if (tx_pcap == NULL) {
+               PMD_LOG(ERR, "Couldn't create dead pcap");
+               return -1;
+       }
+
+       /* The dumper is created using the previous pcap_t reference */
+       *dumper = pcap_dump_open(tx_pcap, pcap_filename);
+       if (*dumper == NULL) {
+               pcap_close(tx_pcap);
+               PMD_LOG(ERR, "Couldn't open %s for writing.",
+                       pcap_filename);
+               return -1;
+       }
+
+       pcap_close(tx_pcap);
+       return 0;
+}
+
+static int
+open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
+{
+       *pcap = pcap_open_offline(pcap_filename, errbuf);
+       if (*pcap == NULL) {
+               PMD_LOG(ERR, "Couldn't open %s: %s", pcap_filename,
+                       errbuf);
+               return -1;
+       }
+
+       return 0;
+}
+
 static int
 eth_dev_start(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internals = dev->data->dev_private;
+       struct pmd_process_private *pp = dev->process_private;
        struct pcap_tx_queue *tx;
        struct pcap_rx_queue *rx;
 
@@ -383,11 +461,13 @@ eth_dev_start(struct rte_eth_dev *dev)
                tx = &internals->tx_queue[0];
                rx = &internals->rx_queue[0];
 
-               if (!tx->pcap && strcmp(tx->type, ETH_PCAP_IFACE_ARG) == 0) {
-                       if (open_single_iface(tx->name, &tx->pcap) < 0)
+               if (!pp->tx_pcap[0] &&
+                       strcmp(tx->type, ETH_PCAP_IFACE_ARG) == 0) {
+                       if (open_single_iface(tx->name, &pp->tx_pcap[0]) < 0)
                                return -1;
-                       rx->pcap = tx->pcap;
+                       pp->rx_pcap[0] = pp->tx_pcap[0];
                }
+
                goto status_up;
        }
 
@@ -395,13 +475,14 @@ eth_dev_start(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                tx = &internals->tx_queue[i];
 
-               if (!tx->dumper && strcmp(tx->type, ETH_PCAP_TX_PCAP_ARG) == 0) {
-                       if (open_single_tx_pcap(tx->name, &tx->dumper) < 0)
+               if (!pp->tx_dumper[i] &&
+                               strcmp(tx->type, ETH_PCAP_TX_PCAP_ARG) == 0) {
+                       if (open_single_tx_pcap(tx->name,
+                               &pp->tx_dumper[i]) < 0)
                                return -1;
-               }
-
-               else if (!tx->pcap && strcmp(tx->type, ETH_PCAP_TX_IFACE_ARG) == 0) {
-                       if (open_single_iface(tx->name, &tx->pcap) < 0)
+               } else if (!pp->tx_pcap[i] &&
+                               strcmp(tx->type, ETH_PCAP_TX_IFACE_ARG) == 0) {
+                       if (open_single_iface(tx->name, &pp->tx_pcap[i]) < 0)
                                return -1;
                }
        }
@@ -410,23 +491,27 @@ eth_dev_start(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                rx = &internals->rx_queue[i];
 
-               if (rx->pcap != NULL)
+               if (pp->rx_pcap[i] != NULL)
                        continue;
 
                if (strcmp(rx->type, ETH_PCAP_RX_PCAP_ARG) == 0) {
-                       if (open_single_rx_pcap(rx->name, &rx->pcap) < 0)
+                       if (open_single_rx_pcap(rx->name, &pp->rx_pcap[i]) < 0)
                                return -1;
-               }
-
-               else if (strcmp(rx->type, ETH_PCAP_RX_IFACE_ARG) == 0) {
-                       if (open_single_iface(rx->name, &rx->pcap) < 0)
+               } else if (strcmp(rx->type, ETH_PCAP_RX_IFACE_ARG) == 0) {
+                       if (open_single_iface(rx->name, &pp->rx_pcap[i]) < 0)
                                return -1;
                }
        }
 
 status_up:
+       for (i = 0; i < dev->data->nb_rx_queues; i++)
+               dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+
+       for (i = 0; i < dev->data->nb_tx_queues; i++)
+               dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
 
        dev->data->dev_link.link_status = ETH_LINK_UP;
+
        return 0;
 }
 
@@ -438,45 +523,44 @@ status_up:
 static void
 eth_dev_stop(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internals = dev->data->dev_private;
-       struct pcap_tx_queue *tx;
-       struct pcap_rx_queue *rx;
+       struct pmd_process_private *pp = dev->process_private;
 
        /* Special iface case. Single pcap is open and shared between tx/rx. */
        if (internals->single_iface) {
-               tx = &internals->tx_queue[0];
-               rx = &internals->rx_queue[0];
-               pcap_close(tx->pcap);
-               tx->pcap = NULL;
-               rx->pcap = NULL;
+               pcap_close(pp->tx_pcap[0]);
+               pp->tx_pcap[0] = NULL;
+               pp->rx_pcap[0] = NULL;
                goto status_down;
        }
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               tx = &internals->tx_queue[i];
-
-               if (tx->dumper != NULL) {
-                       pcap_dump_close(tx->dumper);
-                       tx->dumper = NULL;
+               if (pp->tx_dumper[i] != NULL) {
+                       pcap_dump_close(pp->tx_dumper[i]);
+                       pp->tx_dumper[i] = NULL;
                }
 
-               if (tx->pcap != NULL) {
-                       pcap_close(tx->pcap);
-                       tx->pcap = NULL;
+               if (pp->tx_pcap[i] != NULL) {
+                       pcap_close(pp->tx_pcap[i]);
+                       pp->tx_pcap[i] = NULL;
                }
        }
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               rx = &internals->rx_queue[i];
-
-               if (rx->pcap != NULL) {
-                       pcap_close(rx->pcap);
-                       rx->pcap = NULL;
+               if (pp->rx_pcap[i] != NULL) {
+                       pcap_close(pp->rx_pcap[i]);
+                       pp->rx_pcap[i] = NULL;
                }
        }
 
 status_down:
+       for (i = 0; i < dev->data->nb_rx_queues; i++)
+               dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+
+       for (i = 0; i < dev->data->nb_tx_queues; i++)
+               dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+
        dev->data->dev_link.link_status = ETH_LINK_DOWN;
 }
 
@@ -491,21 +575,19 @@ eth_dev_info(struct rte_eth_dev *dev,
                struct rte_eth_dev_info *dev_info)
 {
        struct pmd_internals *internals = dev->data->dev_private;
-       dev_info->driver_name = drivername;
+
        dev_info->if_index = internals->if_index;
        dev_info->max_mac_addrs = 1;
        dev_info->max_rx_pktlen = (uint32_t) -1;
        dev_info->max_rx_queues = dev->data->nb_rx_queues;
        dev_info->max_tx_queues = dev->data->nb_tx_queues;
        dev_info->min_rx_bufsize = 0;
-       dev_info->pci_dev = NULL;
 }
 
-static void
-eth_stats_get(struct rte_eth_dev *dev,
-               struct rte_eth_stats *igb_stats)
+static int
+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-       unsigned i;
+       unsigned int i;
        unsigned long rx_packets_total = 0, rx_bytes_total = 0;
        unsigned long tx_packets_total = 0, tx_bytes_total = 0;
        unsigned long tx_packets_err_total = 0;
@@ -513,42 +595,46 @@ eth_stats_get(struct rte_eth_dev *dev,
 
        for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
                        i < dev->data->nb_rx_queues; i++) {
-               igb_stats->q_ipackets[i] = internal->rx_queue[i].rx_pkts;
-               igb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;
-               rx_packets_total += igb_stats->q_ipackets[i];
-               rx_bytes_total += igb_stats->q_ibytes[i];
+               stats->q_ipackets[i] = internal->rx_queue[i].rx_stat.pkts;
+               stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes;
+               rx_packets_total += stats->q_ipackets[i];
+               rx_bytes_total += stats->q_ibytes[i];
        }
 
        for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
                        i < dev->data->nb_tx_queues; i++) {
-               igb_stats->q_opackets[i] = internal->tx_queue[i].tx_pkts;
-               igb_stats->q_obytes[i] = internal->tx_queue[i].tx_bytes;
-               igb_stats->q_errors[i] = internal->tx_queue[i].err_pkts;
-               tx_packets_total += igb_stats->q_opackets[i];
-               tx_bytes_total += igb_stats->q_obytes[i];
-               tx_packets_err_total += igb_stats->q_errors[i];
+               stats->q_opackets[i] = internal->tx_queue[i].tx_stat.pkts;
+               stats->q_obytes[i] = internal->tx_queue[i].tx_stat.bytes;
+               stats->q_errors[i] = internal->tx_queue[i].tx_stat.err_pkts;
+               tx_packets_total += stats->q_opackets[i];
+               tx_bytes_total += stats->q_obytes[i];
+               tx_packets_err_total += stats->q_errors[i];
        }
 
-       igb_stats->ipackets = rx_packets_total;
-       igb_stats->ibytes = rx_bytes_total;
-       igb_stats->opackets = tx_packets_total;
-       igb_stats->obytes = tx_bytes_total;
-       igb_stats->oerrors = tx_packets_err_total;
+       stats->ipackets = rx_packets_total;
+       stats->ibytes = rx_bytes_total;
+       stats->opackets = tx_packets_total;
+       stats->obytes = tx_bytes_total;
+       stats->oerrors = tx_packets_err_total;
+
+       return 0;
 }
 
 static void
 eth_stats_reset(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internal = dev->data->dev_private;
+
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               internal->rx_queue[i].rx_pkts = 0;
-               internal->rx_queue[i].rx_bytes = 0;
+               internal->rx_queue[i].rx_stat.pkts = 0;
+               internal->rx_queue[i].rx_stat.bytes = 0;
        }
+
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               internal->tx_queue[i].tx_pkts = 0;
-               internal->tx_queue[i].tx_bytes = 0;
-               internal->tx_queue[i].err_pkts = 0;
+               internal->tx_queue[i].tx_stat.pkts = 0;
+               internal->tx_queue[i].tx_stat.bytes = 0;
+               internal->tx_queue[i].tx_stat.err_pkts = 0;
        }
 }
 
@@ -579,9 +665,12 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
 {
        struct pmd_internals *internals = dev->data->dev_private;
        struct pcap_rx_queue *pcap_q = &internals->rx_queue[rx_queue_id];
+
        pcap_q->mb_pool = mb_pool;
+       pcap_q->port_id = dev->data->port_id;
+       pcap_q->queue_id = rx_queue_id;
        dev->data->rx_queues[rx_queue_id] = pcap_q;
-       pcap_q->in_port = dev->data->port_id;
+
        return 0;
 }
 
@@ -592,20 +681,60 @@ eth_tx_queue_setup(struct rte_eth_dev *dev,
                unsigned int socket_id __rte_unused,
                const struct rte_eth_txconf *tx_conf __rte_unused)
 {
-
        struct pmd_internals *internals = dev->data->dev_private;
-       dev->data->tx_queues[tx_queue_id] = &internals->tx_queue[tx_queue_id];
+       struct pcap_tx_queue *pcap_q = &internals->tx_queue[tx_queue_id];
+
+       pcap_q->port_id = dev->data->port_id;
+       pcap_q->queue_id = tx_queue_id;
+       dev->data->tx_queues[tx_queue_id] = pcap_q;
+
+       return 0;
+}
+
+static int
+eth_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+       dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
+
+       return 0;
+}
+
+static int
+eth_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
+{
+       dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
+
+       return 0;
+}
+
+static int
+eth_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+       dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;
+
+       return 0;
+}
+
+static int
+eth_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
+{
+       dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;
+
        return 0;
 }
 
 static const struct eth_dev_ops ops = {
        .dev_start = eth_dev_start,
-       .dev_stop =     eth_dev_stop,
+       .dev_stop = eth_dev_stop,
        .dev_close = eth_dev_close,
        .dev_configure = eth_dev_configure,
        .dev_infos_get = eth_dev_info,
        .rx_queue_setup = eth_rx_queue_setup,
        .tx_queue_setup = eth_tx_queue_setup,
+       .rx_queue_start = eth_rx_queue_start,
+       .tx_queue_start = eth_tx_queue_start,
+       .rx_queue_stop = eth_rx_queue_stop,
+       .tx_queue_stop = eth_tx_queue_stop,
        .rx_queue_release = eth_queue_release,
        .tx_queue_release = eth_queue_release,
        .link_update = eth_link_update,
@@ -613,6 +742,22 @@ static const struct eth_dev_ops ops = {
        .stats_reset = eth_stats_reset,
 };
 
+static int
+add_queue(struct pmd_devargs *pmd, const char *name, const char *type,
+               pcap_t *pcap, pcap_dumper_t *dumper)
+{
+       if (pmd->num_of_queue >= RTE_PMD_PCAP_MAX_QUEUES)
+               return -1;
+       if (pcap)
+               pmd->queue[pmd->num_of_queue].pcap = pcap;
+       if (dumper)
+               pmd->queue[pmd->num_of_queue].dumper = dumper;
+       pmd->queue[pmd->num_of_queue].name = name;
+       pmd->queue[pmd->num_of_queue].type = type;
+       pmd->num_of_queue++;
+       return 0;
+}
+
 /*
  * Function handler that opens the pcap file for reading a stores a
  * reference of it for use it later on.
@@ -620,30 +765,18 @@ static const struct eth_dev_ops ops = {
 static int
 open_rx_pcap(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
        const char *pcap_filename = value;
        struct pmd_devargs *rx = extra_args;
        pcap_t *pcap = NULL;
 
-       for (i = 0; i < rx->num_of_queue; i++) {
-               if (open_single_rx_pcap(pcap_filename, &pcap) < 0)
-                       return -1;
-
-               rx->queue[i].pcap = pcap;
-               rx->queue[i].name = pcap_filename;
-               rx->queue[i].type = key;
-       }
-
-       return 0;
-}
+       if (open_single_rx_pcap(pcap_filename, &pcap) < 0)
+               return -1;
 
-static int
-open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
-{
-       if ((*pcap = pcap_open_offline(pcap_filename, errbuf)) == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", pcap_filename, errbuf);
+       if (add_queue(rx, pcap_filename, key, pcap, NULL) < 0) {
+               pcap_close(pcap);
                return -1;
        }
+
        return 0;
 }
 
@@ -654,79 +787,69 @@ open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
 static int
 open_tx_pcap(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
        const char *pcap_filename = value;
        struct pmd_devargs *dumpers = extra_args;
        pcap_dumper_t *dumper;
 
-       for (i = 0; i < dumpers->num_of_queue; i++) {
-               if (open_single_tx_pcap(pcap_filename, &dumper) < 0)
-                       return -1;
+       if (open_single_tx_pcap(pcap_filename, &dumper) < 0)
+               return -1;
 
-               dumpers->queue[i].dumper = dumper;
-               dumpers->queue[i].name = pcap_filename;
-               dumpers->queue[i].type = key;
+       if (add_queue(dumpers, pcap_filename, key, NULL, dumper) < 0) {
+               pcap_dump_close(dumper);
+               return -1;
        }
 
        return 0;
 }
 
-static int
-open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper)
+/*
+ * Opens an interface for reading and writing
+ */
+static inline int
+open_rx_tx_iface(const char *key, const char *value, void *extra_args)
 {
-       pcap_t *tx_pcap;
-       /*
-        * We need to create a dummy empty pcap_t to use it
-        * with pcap_dump_open(). We create big enough an Ethernet
-        * pcap holder.
-        */
+       const char *iface = value;
+       struct pmd_devargs *tx = extra_args;
+       pcap_t *pcap = NULL;
 
-       if ((tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN))
-                       == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't create dead pcap\n");
+       if (open_single_iface(iface, &pcap) < 0)
                return -1;
-       }
 
-       /* The dumper is created using the previous pcap_t reference */
-       if ((*dumper = pcap_dump_open(tx_pcap, pcap_filename)) == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s for writing.\n", pcap_filename);
-               return -1;
-       }
+       tx->queue[0].pcap = pcap;
+       tx->queue[0].name = iface;
+       tx->queue[0].type = key;
 
        return 0;
 }
 
-/*
- * pcap_open_live wrapper function
- */
 static inline int
-open_iface_live(const char *iface, pcap_t **pcap) {
-       *pcap = pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN,
-                       RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf);
-
-       if (*pcap == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", iface, errbuf);
+set_iface_direction(const char *iface, pcap_t *pcap,
+               pcap_direction_t direction)
+{
+       const char *direction_str = (direction == PCAP_D_IN) ? "IN" : "OUT";
+       if (pcap_setdirection(pcap, direction) < 0) {
+               PMD_LOG(ERR, "Setting %s pcap direction %s failed - %s\n",
+                               iface, direction_str, pcap_geterr(pcap));
                return -1;
        }
+       PMD_LOG(INFO, "Setting %s pcap direction %s\n",
+                       iface, direction_str);
        return 0;
 }
 
-/*
- * Opens an interface for reading and writing
- */
 static inline int
-open_rx_tx_iface(const char *key, const char *value, void *extra_args)
+open_iface(const char *key, const char *value, void *extra_args)
 {
        const char *iface = value;
-       struct pmd_devargs *tx = extra_args;
+       struct pmd_devargs *pmd = extra_args;
        pcap_t *pcap = NULL;
 
        if (open_single_iface(iface, &pcap) < 0)
                return -1;
-
-       tx->queue[0].pcap = pcap;
-       tx->queue[0].name = iface;
-       tx->queue[0].type = key;
+       if (add_queue(pmd, iface, key, pcap, NULL) < 0) {
+               pcap_close(pcap);
+               return -1;
+       }
 
        return 0;
 }
@@ -737,133 +860,213 @@ open_rx_tx_iface(const char *key, const char *value, void *extra_args)
 static inline int
 open_rx_iface(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
-       const char *iface = value;
-       struct pmd_devargs *rx = extra_args;
-       pcap_t *pcap = NULL;
+       int ret = open_iface(key, value, extra_args);
+       if (ret < 0)
+               return ret;
+       if (strcmp(key, ETH_PCAP_RX_IFACE_IN_ARG) == 0) {
+               struct pmd_devargs *pmd = extra_args;
+               unsigned int qid = pmd->num_of_queue - 1;
 
-       for (i = 0; i < rx->num_of_queue; i++) {
-               if (open_single_iface(iface, &pcap) < 0)
-                       return -1;
-               rx->queue[i].pcap = pcap;
-               rx->queue[i].name = iface;
-               rx->queue[i].type = key;
+               set_iface_direction(pmd->queue[qid].name,
+                               pmd->queue[qid].pcap,
+                               PCAP_D_IN);
        }
 
        return 0;
 }
 
+static inline int
+rx_iface_args_process(const char *key, const char *value, void *extra_args)
+{
+       if (strcmp(key, ETH_PCAP_RX_IFACE_ARG) == 0 ||
+                       strcmp(key, ETH_PCAP_RX_IFACE_IN_ARG) == 0)
+               return open_rx_iface(key, value, extra_args);
+
+       return 0;
+}
+
 /*
  * Opens a NIC for writing packets to it
  */
 static int
 open_tx_iface(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
-       const char *iface = value;
-       struct pmd_devargs *tx = extra_args;
-       pcap_t *pcap;
-
-       for (i = 0; i < tx->num_of_queue; i++) {
-               if (open_single_iface(iface, &pcap) < 0)
-                       return -1;
-               tx->queue[i].pcap = pcap;
-               tx->queue[i].name = iface;
-               tx->queue[i].type = key;
-       }
-
-       return 0;
+       return open_iface(key, value, extra_args);
 }
 
 static int
-open_single_iface(const char *iface, pcap_t **pcap)
+select_phy_mac(const char *key __rte_unused, const char *value,
+               void *extra_args)
 {
-       if (open_iface_live(iface, pcap) < 0) {
-               RTE_LOG(ERR, PMD, "Couldn't open interface %s\n", iface);
-               return -1;
-       }
+       if (extra_args) {
+               const int phy_mac = atoi(value);
+               int *enable_phy_mac = extra_args;
 
+               if (phy_mac)
+                       *enable_phy_mac = 1;
+       }
        return 0;
 }
 
+static struct rte_vdev_driver pmd_pcap_drv;
+
 static int
-rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
-               const unsigned nb_tx_queues, struct pmd_internals **internals,
+pmd_init_internals(struct rte_vdev_device *vdev,
+               const unsigned int nb_rx_queues,
+               const unsigned int nb_tx_queues,
+               struct pmd_internals **internals,
                struct rte_eth_dev **eth_dev)
 {
-       struct rte_eth_dev_data *data = NULL;
-       unsigned int numa_node = rte_socket_id();
+       struct rte_eth_dev_data *data;
+       struct pmd_process_private *pp;
+       unsigned int numa_node = vdev->device.numa_node;
 
-       RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %u\n",
+       PMD_LOG(INFO, "Creating pcap-backed ethdev on numa socket %d",
                numa_node);
 
-       /* now do all data allocation - for eth_dev structure
-        * and internal (private) data
-        */
-       data = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);
-       if (data == NULL)
-               goto error;
+       pp = (struct pmd_process_private *)
+               rte_zmalloc(NULL, sizeof(struct pmd_process_private),
+                               RTE_CACHE_LINE_SIZE);
 
-       *internals = rte_zmalloc_socket(name, sizeof(**internals), 0,
-                       numa_node);
-       if (*internals == NULL)
-               goto error;
+       if (pp == NULL) {
+               PMD_LOG(ERR,
+                       "Failed to allocate memory for process private");
+               return -1;
+       }
 
        /* reserve an ethdev entry */
-       *eth_dev = rte_eth_dev_allocate(name);
-       if (*eth_dev == NULL)
-               goto error;
-
-       /* check length of device name */
-       if ((strlen((*eth_dev)->data->name) + 1) > sizeof(data->name))
-               goto error;
-
+       *eth_dev = rte_eth_vdev_allocate(vdev, sizeof(**internals));
+       if (!(*eth_dev)) {
+               rte_free(pp);
+               return -1;
+       }
+       (*eth_dev)->process_private = pp;
        /* now put it all together
         * - store queue data in internals,
         * - store numa_node info in eth_dev
         * - point eth_dev_data to internals
         * - and point eth_dev structure to new eth_dev_data structure
         */
-       data->dev_private = *internals;
-       data->port_id = (*eth_dev)->data->port_id;
-       snprintf(data->name, sizeof(data->name), "%s", (*eth_dev)->data->name);
+       *internals = (*eth_dev)->data->dev_private;
+       /*
+        * Interface MAC = 02:70:63:61:70:<iface_idx>
+        * derived from: 'locally administered':'p':'c':'a':'p':'iface_idx'
+        * where the middle 4 characters are converted to hex.
+        */
+       (*internals)->eth_addr = (struct rte_ether_addr) {
+               .addr_bytes = { 0x02, 0x70, 0x63, 0x61, 0x70, iface_idx++ }
+       };
+       (*internals)->phy_mac = 0;
+       data = (*eth_dev)->data;
        data->nb_rx_queues = (uint16_t)nb_rx_queues;
        data->nb_tx_queues = (uint16_t)nb_tx_queues;
        data->dev_link = pmd_link;
-       data->mac_addrs = &eth_addr;
-       strncpy(data->name,
-               (*eth_dev)->data->name, strlen((*eth_dev)->data->name));
+       data->mac_addrs = &(*internals)->eth_addr;
 
        /*
         * NOTE: we'll replace the data element, of originally allocated
         * eth_dev so the rings are local per-process
         */
-       (*eth_dev)->data = data;
        (*eth_dev)->dev_ops = &ops;
-       (*eth_dev)->driver = NULL;
-       data->dev_flags = RTE_ETH_DEV_DETACHABLE;
-       data->kdrv = RTE_KDRV_NONE;
-       data->drv_name = drivername;
-       data->numa_node = numa_node;
+
+       strlcpy((*internals)->devargs, rte_vdev_device_args(vdev),
+                       ETH_PCAP_ARG_MAXLEN);
 
        return 0;
+}
+
+static int
+eth_pcap_update_mac(const char *if_name, struct rte_eth_dev *eth_dev,
+               const unsigned int numa_node)
+{
+#if defined(RTE_EXEC_ENV_LINUX)
+       void *mac_addrs;
+       struct ifreq ifr;
+       int if_fd = socket(AF_INET, SOCK_DGRAM, 0);
+
+       if (if_fd == -1)
+               return -1;
+
+       rte_strscpy(ifr.ifr_name, if_name, sizeof(ifr.ifr_name));
+       if (ioctl(if_fd, SIOCGIFHWADDR, &ifr)) {
+               close(if_fd);
+               return -1;
+       }
+
+       mac_addrs = rte_zmalloc_socket(NULL, ETHER_ADDR_LEN, 0, numa_node);
+       if (!mac_addrs) {
+               close(if_fd);
+               return -1;
+       }
+
+       PMD_LOG(INFO, "Setting phy MAC for %s", if_name);
+       eth_dev->data->mac_addrs = mac_addrs;
+       rte_memcpy(eth_dev->data->mac_addrs[0].addr_bytes,
+                       ifr.ifr_hwaddr.sa_data, ETHER_ADDR_LEN);
+
+       close(if_fd);
+
+       return 0;
+
+#elif defined(RTE_EXEC_ENV_FREEBSD)
+       void *mac_addrs;
+       struct if_msghdr *ifm;
+       struct sockaddr_dl *sdl;
+       int mib[6];
+       size_t len = 0;
+       char *buf;
+
+       mib[0] = CTL_NET;
+       mib[1] = AF_ROUTE;
+       mib[2] = 0;
+       mib[3] = AF_LINK;
+       mib[4] = NET_RT_IFLIST;
+       mib[5] = if_nametoindex(if_name);
+
+       if (sysctl(mib, 6, NULL, &len, NULL, 0) < 0)
+               return -1;
+
+       if (len == 0)
+               return -1;
+
+       buf = rte_malloc(NULL, len, 0);
+       if (!buf)
+               return -1;
 
-error:
-       rte_free(data);
-       rte_free(*internals);
+       if (sysctl(mib, 6, buf, &len, NULL, 0) < 0) {
+               rte_free(buf);
+               return -1;
+       }
+       ifm = (struct if_msghdr *)buf;
+       sdl = (struct sockaddr_dl *)(ifm + 1);
 
+       mac_addrs = rte_zmalloc_socket(NULL, ETHER_ADDR_LEN, 0, numa_node);
+       if (!mac_addrs) {
+               rte_free(buf);
+               return -1;
+       }
+
+       PMD_LOG(INFO, "Setting phy MAC for %s", if_name);
+       eth_dev->data->mac_addrs = mac_addrs;
+       rte_memcpy(eth_dev->data->mac_addrs[0].addr_bytes,
+                       LLADDR(sdl), ETHER_ADDR_LEN);
+
+       rte_free(buf);
+
+       return 0;
+#else
        return -1;
+#endif
 }
 
 static int
-rte_eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
-               const unsigned nb_rx_queues, struct pmd_devargs *tx_queues,
-               const unsigned nb_tx_queues, struct rte_kvargs *kvlist,
+eth_from_pcaps_common(struct rte_vdev_device *vdev,
+               struct pmd_devargs *rx_queues, const unsigned int nb_rx_queues,
+               struct pmd_devargs *tx_queues, const unsigned int nb_tx_queues,
                struct pmd_internals **internals, struct rte_eth_dev **eth_dev)
 {
-       struct rte_kvargs_pair *pair = NULL;
-       unsigned k_idx;
-       unsigned i;
+       struct pmd_process_private *pp;
+       unsigned int i;
 
        /* do some parameter checking */
        if (rx_queues == NULL && nb_rx_queues > 0)
@@ -871,62 +1074,64 @@ rte_eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
        if (tx_queues == NULL && nb_tx_queues > 0)
                return -1;
 
-       if (rte_pmd_init_internals(name, nb_rx_queues, nb_tx_queues, internals,
+       if (pmd_init_internals(vdev, nb_rx_queues, nb_tx_queues, internals,
                        eth_dev) < 0)
                return -1;
 
+       pp = (*eth_dev)->process_private;
        for (i = 0; i < nb_rx_queues; i++) {
-               (*internals)->rx_queue[i].pcap = rx_queues->queue[i].pcap;
-               snprintf((*internals)->rx_queue[i].name,
-                       sizeof((*internals)->rx_queue[i].name), "%s",
-                       rx_queues->queue[i].name);
-               snprintf((*internals)->rx_queue[i].type,
-                       sizeof((*internals)->rx_queue[i].type), "%s",
-                       rx_queues->queue[i].type);
+               struct pcap_rx_queue *rx = &(*internals)->rx_queue[i];
+               struct devargs_queue *queue = &rx_queues->queue[i];
+
+               pp->rx_pcap[i] = queue->pcap;
+               strlcpy(rx->name, queue->name, sizeof(rx->name));
+               strlcpy(rx->type, queue->type, sizeof(rx->type));
        }
+
        for (i = 0; i < nb_tx_queues; i++) {
-               (*internals)->tx_queue[i].dumper = tx_queues->queue[i].dumper;
-               snprintf((*internals)->tx_queue[i].name,
-                       sizeof((*internals)->tx_queue[i].name), "%s",
-                       tx_queues->queue[i].name);
-               snprintf((*internals)->tx_queue[i].type,
-                       sizeof((*internals)->tx_queue[i].type), "%s",
-                       tx_queues->queue[i].type);
-       }
+               struct pcap_tx_queue *tx = &(*internals)->tx_queue[i];
+               struct devargs_queue *queue = &tx_queues->queue[i];
 
-       for (k_idx = 0; k_idx < kvlist->count; k_idx++) {
-               pair = &kvlist->pairs[k_idx];
-               if (strstr(pair->key, ETH_PCAP_IFACE_ARG) != NULL)
-                       break;
+               pp->tx_dumper[i] = queue->dumper;
+               pp->tx_pcap[i] = queue->pcap;
+               strlcpy(tx->name, queue->name, sizeof(tx->name));
+               strlcpy(tx->type, queue->type, sizeof(tx->type));
        }
 
-       if (pair == NULL)
-               (*internals)->if_index = 0;
-       else
-               (*internals)->if_index = if_nametoindex(pair->value);
-
        return 0;
 }
 
 static int
-rte_eth_from_pcaps(const char *name, struct pmd_devargs *rx_queues,
-               const unsigned nb_rx_queues, struct pmd_devargs *tx_queues,
-               const unsigned nb_tx_queues, struct rte_kvargs *kvlist,
+eth_from_pcaps(struct rte_vdev_device *vdev,
+               struct pmd_devargs *rx_queues, const unsigned int nb_rx_queues,
+               struct pmd_devargs *tx_queues, const unsigned int nb_tx_queues,
                int single_iface, unsigned int using_dumpers)
 {
        struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
        int ret;
 
-       ret = rte_eth_from_pcaps_common(name, rx_queues, nb_rx_queues,
-               tx_queues, nb_tx_queues, kvlist, &internals, &eth_dev);
+       ret = eth_from_pcaps_common(vdev, rx_queues, nb_rx_queues,
+               tx_queues, nb_tx_queues, &internals, &eth_dev);
 
        if (ret < 0)
                return ret;
 
-       /* store wether we are using a single interface for rx/tx or not */
+       /* store weather we are using a single interface for rx/tx or not */
        internals->single_iface = single_iface;
 
+       if (single_iface) {
+               internals->if_index = if_nametoindex(rx_queues->queue[0].name);
+
+               /* phy_mac arg is applied only only if "iface" devarg is provided */
+               if (rx_queues->phy_mac) {
+                       int ret = eth_pcap_update_mac(rx_queues->queue[0].name,
+                                       eth_dev, vdev->device.numa_node);
+                       if (ret == 0)
+                               internals->phy_mac = 1;
+               }
+       }
+
        eth_dev->rx_pkt_burst = eth_pcap_rx;
 
        if (using_dumpers)
@@ -934,28 +1139,48 @@ rte_eth_from_pcaps(const char *name, struct pmd_devargs *rx_queues,
        else
                eth_dev->tx_pkt_burst = eth_pcap_tx;
 
+       rte_eth_dev_probing_finish(eth_dev);
        return 0;
 }
 
-
 static int
-rte_pmd_pcap_devinit(const char *name, const char *params)
+pmd_pcap_probe(struct rte_vdev_device *dev)
 {
+       const char *name;
        unsigned int is_rx_pcap = 0, is_tx_pcap = 0;
        struct rte_kvargs *kvlist;
        struct pmd_devargs pcaps = {0};
        struct pmd_devargs dumpers = {0};
+       struct rte_eth_dev *eth_dev =  NULL;
+       struct pmd_internals *internal;
+       int single_iface = 0;
        int ret;
 
-       RTE_LOG(INFO, PMD, "Initializing pmd_pcap for %s\n", name);
+       name = rte_vdev_device_name(dev);
+       PMD_LOG(INFO, "Initializing pmd_pcap for %s", name);
 
        gettimeofday(&start_time, NULL);
        start_cycles = rte_get_timer_cycles();
        hz = rte_get_timer_hz();
 
-       kvlist = rte_kvargs_parse(params, valid_arguments);
-       if (kvlist == NULL)
-               return -1;
+       if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+               eth_dev = rte_eth_dev_attach_secondary(name);
+               if (!eth_dev) {
+                       PMD_LOG(ERR, "Failed to probe %s", name);
+                       return -1;
+               }
+
+               internal = eth_dev->data->dev_private;
+
+               kvlist = rte_kvargs_parse(internal->devargs, valid_arguments);
+               if (kvlist == NULL)
+                       return -1;
+       } else {
+               kvlist = rte_kvargs_parse(rte_vdev_device_args(dev),
+                               valid_arguments);
+               if (kvlist == NULL)
+                       return -1;
+       }
 
        /*
         * If iface argument is passed we open the NICs and use them for
@@ -967,34 +1192,37 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
                                &open_rx_tx_iface, &pcaps);
                if (ret < 0)
                        goto free_kvlist;
-               dumpers.queue[0].pcap = pcaps.queue[0].pcap;
-               dumpers.queue[0].name = pcaps.queue[0].name;
-               dumpers.queue[0].type = pcaps.queue[0].type;
-               ret = rte_eth_from_pcaps(name, &pcaps, 1, &dumpers, 1,
-                               kvlist, 1, is_tx_pcap);
-               goto free_kvlist;
+
+               dumpers.queue[0] = pcaps.queue[0];
+
+               ret = rte_kvargs_process(kvlist, ETH_PCAP_PHY_MAC_ARG,
+                               &select_phy_mac, &pcaps.phy_mac);
+               if (ret < 0)
+                       goto free_kvlist;
+
+               dumpers.phy_mac = pcaps.phy_mac;
+
+               single_iface = 1;
+               pcaps.num_of_queue = 1;
+               dumpers.num_of_queue = 1;
+
+               goto create_eth;
        }
 
        /*
         * We check whether we want to open a RX stream from a real NIC or a
         * pcap file
         */
-       pcaps.num_of_queue = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG);
-       if (pcaps.num_of_queue)
-               is_rx_pcap = 1;
-       else
-               pcaps.num_of_queue = rte_kvargs_count(kvlist,
-                               ETH_PCAP_RX_IFACE_ARG);
-
-       if (pcaps.num_of_queue > RTE_PMD_PCAP_MAX_QUEUES)
-               pcaps.num_of_queue = RTE_PMD_PCAP_MAX_QUEUES;
+       is_rx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0;
+       pcaps.num_of_queue = 0;
 
-       if (is_rx_pcap)
+       if (is_rx_pcap) {
                ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_PCAP_ARG,
                                &open_rx_pcap, &pcaps);
-       else
-               ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_IFACE_ARG,
-                               &open_rx_iface, &pcaps);
+       } else {
+               ret = rte_kvargs_process(kvlist, NULL,
+                               &rx_iface_args_process, &pcaps);
+       }
 
        if (ret < 0)
                goto free_kvlist;
@@ -1003,15 +1231,8 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
         * We check whether we want to open a TX stream to a real NIC or a
         * pcap file
         */
-       dumpers.num_of_queue = rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG);
-       if (dumpers.num_of_queue)
-               is_tx_pcap = 1;
-       else
-               dumpers.num_of_queue = rte_kvargs_count(kvlist,
-                               ETH_PCAP_TX_IFACE_ARG);
-
-       if (dumpers.num_of_queue > RTE_PMD_PCAP_MAX_QUEUES)
-               dumpers.num_of_queue = RTE_PMD_PCAP_MAX_QUEUES;
+       is_tx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG) ? 1 : 0;
+       dumpers.num_of_queue = 0;
 
        if (is_tx_pcap)
                ret = rte_kvargs_process(kvlist, ETH_PCAP_TX_PCAP_ARG,
@@ -1023,47 +1244,105 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
        if (ret < 0)
                goto free_kvlist;
 
-       ret = rte_eth_from_pcaps(name, &pcaps, pcaps.num_of_queue, &dumpers,
-               dumpers.num_of_queue, kvlist, 0, is_tx_pcap);
+create_eth:
+       if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+               struct pmd_process_private *pp;
+               unsigned int i;
+
+               internal = eth_dev->data->dev_private;
+                       pp = (struct pmd_process_private *)
+                               rte_zmalloc(NULL,
+                                       sizeof(struct pmd_process_private),
+                                       RTE_CACHE_LINE_SIZE);
+
+               if (pp == NULL) {
+                       PMD_LOG(ERR,
+                               "Failed to allocate memory for process private");
+                       ret = -1;
+                       goto free_kvlist;
+               }
+
+               eth_dev->dev_ops = &ops;
+               eth_dev->device = &dev->device;
+
+               /* setup process private */
+               for (i = 0; i < pcaps.num_of_queue; i++)
+                       pp->rx_pcap[i] = pcaps.queue[i].pcap;
+
+               for (i = 0; i < dumpers.num_of_queue; i++) {
+                       pp->tx_dumper[i] = dumpers.queue[i].dumper;
+                       pp->tx_pcap[i] = dumpers.queue[i].pcap;
+               }
+
+               eth_dev->process_private = pp;
+               eth_dev->rx_pkt_burst = eth_pcap_rx;
+               if (is_tx_pcap)
+                       eth_dev->tx_pkt_burst = eth_pcap_tx_dumper;
+               else
+                       eth_dev->tx_pkt_burst = eth_pcap_tx;
+
+               rte_eth_dev_probing_finish(eth_dev);
+               goto free_kvlist;
+       }
+
+       ret = eth_from_pcaps(dev, &pcaps, pcaps.num_of_queue, &dumpers,
+               dumpers.num_of_queue, single_iface, is_tx_pcap);
 
 free_kvlist:
        rte_kvargs_free(kvlist);
+
        return ret;
 }
 
 static int
-rte_pmd_pcap_devuninit(const char *name)
+pmd_pcap_remove(struct rte_vdev_device *dev)
 {
+       struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
 
-       RTE_LOG(INFO, PMD, "Closing pcap ethdev on numa socket %u\n",
+       PMD_LOG(INFO, "Closing pcap ethdev on numa socket %d",
                        rte_socket_id());
 
-       if (name == NULL)
+       if (!dev)
                return -1;
 
        /* reserve an ethdev entry */
-       eth_dev = rte_eth_dev_allocated(name);
+       eth_dev = rte_eth_dev_allocated(rte_vdev_device_name(dev));
        if (eth_dev == NULL)
                return -1;
 
-       rte_free(eth_dev->data->dev_private);
-       rte_free(eth_dev->data);
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+               internals = eth_dev->data->dev_private;
+               if (internals != NULL && internals->phy_mac == 0)
+                       /* not dynamically allocated, must not be freed */
+                       eth_dev->data->mac_addrs = NULL;
+       }
 
+       rte_free(eth_dev->process_private);
        rte_eth_dev_release_port(eth_dev);
 
        return 0;
 }
 
 static struct rte_vdev_driver pmd_pcap_drv = {
-       .init = rte_pmd_pcap_devinit,
-       .uninit = rte_pmd_pcap_devuninit,
+       .probe = pmd_pcap_probe,
+       .remove = pmd_pcap_remove,
 };
 
-DRIVER_REGISTER_VDEV(net_pcap, pmd_pcap_drv);
-DRIVER_REGISTER_PARAM_STRING(net_pcap,
+RTE_PMD_REGISTER_VDEV(net_pcap, pmd_pcap_drv);
+RTE_PMD_REGISTER_ALIAS(net_pcap, eth_pcap);
+RTE_PMD_REGISTER_PARAM_STRING(net_pcap,
        ETH_PCAP_RX_PCAP_ARG "=<string> "
        ETH_PCAP_TX_PCAP_ARG "=<string> "
        ETH_PCAP_RX_IFACE_ARG "=<ifc> "
+       ETH_PCAP_RX_IFACE_IN_ARG "=<ifc> "
        ETH_PCAP_TX_IFACE_ARG "=<ifc> "
-       ETH_PCAP_IFACE_ARG "=<ifc>");
+       ETH_PCAP_IFACE_ARG "=<ifc> "
+       ETH_PCAP_PHY_MAC_ARG "=<int>");
+
+RTE_INIT(eth_pcap_init_log)
+{
+       eth_pcap_logtype = rte_log_register("pmd.net.pcap");
+       if (eth_pcap_logtype >= 0)
+               rte_log_set_level(eth_pcap_logtype, RTE_LOG_NOTICE);
+}