net: add rte prefix to ether defines
[dpdk.git] / drivers / net / qede / qede_ethdev.c
index 3e1a62c..84d8984 100644 (file)
@@ -1,12 +1,11 @@
-/*
- * Copyright (c) 2016 QLogic Corporation.
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2016 - 2018 Cavium Inc.
  * All rights reserved.
- * www.qlogic.com
- *
- * See LICENSE.qede_pmd for copyright and licensing details.
+ * www.cavium.com
  */
 
 #include "qede_ethdev.h"
+#include <rte_string_fns.h>
 #include <rte_alarm.h>
 #include <rte_version.h>
 #include <rte_kvargs.h>
@@ -16,112 +15,10 @@ int qede_logtype_init;
 int qede_logtype_driver;
 
 static const struct qed_eth_ops *qed_ops;
-static int64_t timer_period = 1;
-
-/* VXLAN tunnel classification mapping */
-const struct _qede_udp_tunn_types {
-       uint16_t rte_filter_type;
-       enum ecore_filter_ucast_type qede_type;
-       enum ecore_tunn_clss qede_tunn_clss;
-       const char *string;
-} qede_tunn_types[] = {
-       {
-               ETH_TUNNEL_FILTER_OMAC,
-               ECORE_FILTER_MAC,
-               ECORE_TUNN_CLSS_MAC_VLAN,
-               "outer-mac"
-       },
-       {
-               ETH_TUNNEL_FILTER_TENID,
-               ECORE_FILTER_VNI,
-               ECORE_TUNN_CLSS_MAC_VNI,
-               "vni"
-       },
-       {
-               ETH_TUNNEL_FILTER_IMAC,
-               ECORE_FILTER_INNER_MAC,
-               ECORE_TUNN_CLSS_INNER_MAC_VLAN,
-               "inner-mac"
-       },
-       {
-               ETH_TUNNEL_FILTER_IVLAN,
-               ECORE_FILTER_INNER_VLAN,
-               ECORE_TUNN_CLSS_INNER_MAC_VLAN,
-               "inner-vlan"
-       },
-       {
-               ETH_TUNNEL_FILTER_OMAC | ETH_TUNNEL_FILTER_TENID,
-               ECORE_FILTER_MAC_VNI_PAIR,
-               ECORE_TUNN_CLSS_MAC_VNI,
-               "outer-mac and vni"
-       },
-       {
-               ETH_TUNNEL_FILTER_OMAC | ETH_TUNNEL_FILTER_IMAC,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "outer-mac and inner-mac"
-       },
-       {
-               ETH_TUNNEL_FILTER_OMAC | ETH_TUNNEL_FILTER_IVLAN,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "outer-mac and inner-vlan"
-       },
-       {
-               ETH_TUNNEL_FILTER_TENID | ETH_TUNNEL_FILTER_IMAC,
-               ECORE_FILTER_INNER_MAC_VNI_PAIR,
-               ECORE_TUNN_CLSS_INNER_MAC_VNI,
-               "vni and inner-mac",
-       },
-       {
-               ETH_TUNNEL_FILTER_TENID | ETH_TUNNEL_FILTER_IVLAN,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "vni and inner-vlan",
-       },
-       {
-               ETH_TUNNEL_FILTER_IMAC | ETH_TUNNEL_FILTER_IVLAN,
-               ECORE_FILTER_INNER_PAIR,
-               ECORE_TUNN_CLSS_INNER_MAC_VLAN,
-               "inner-mac and inner-vlan",
-       },
-       {
-               ETH_TUNNEL_FILTER_OIP,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "outer-IP"
-       },
-       {
-               ETH_TUNNEL_FILTER_IIP,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "inner-IP"
-       },
-       {
-               RTE_TUNNEL_FILTER_IMAC_IVLAN,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "IMAC_IVLAN"
-       },
-       {
-               RTE_TUNNEL_FILTER_IMAC_IVLAN_TENID,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "IMAC_IVLAN_TENID"
-       },
-       {
-               RTE_TUNNEL_FILTER_IMAC_TENID,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "IMAC_TENID"
-       },
-       {
-               RTE_TUNNEL_FILTER_OMAC_TENID_IMAC,
-               ECORE_FILTER_UNUSED,
-               MAX_ECORE_TUNN_CLSS,
-               "OMAC_TENID_IMAC"
-       },
-};
+static int qede_eth_dev_uninit(struct rte_eth_dev *eth_dev);
+static int qede_eth_dev_init(struct rte_eth_dev *eth_dev);
+
+#define QEDE_SP_TIMER_PERIOD   10000 /* 100ms */
 
 struct rte_qede_xstats_name_off {
        char name[RTE_ETH_XSTATS_NAME_SIZE];
@@ -338,6 +235,24 @@ static void qede_interrupt_action(struct ecore_hwfn *p_hwfn)
        ecore_int_sp_dpc((osal_int_ptr_t)(p_hwfn));
 }
 
+static void
+qede_interrupt_handler_intx(void *param)
+{
+       struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param;
+       struct qede_dev *qdev = eth_dev->data->dev_private;
+       struct ecore_dev *edev = &qdev->edev;
+       u64 status;
+
+       /* Check if our device actually raised an interrupt */
+       status = ecore_int_igu_read_sisr_reg(ECORE_LEADING_HWFN(edev));
+       if (status & 0x1) {
+               qede_interrupt_action(ECORE_LEADING_HWFN(edev));
+
+               if (rte_intr_enable(eth_dev->intr_handle))
+                       DP_ERR(edev, "rte_intr_enable failed\n");
+       }
+}
+
 static void
 qede_interrupt_handler(void *param)
 {
@@ -383,7 +298,7 @@ static void qede_print_adapter_info(struct qede_dev *qdev)
                (info->mfw_rev >> 16) & 0xff,
                (info->mfw_rev >> 8) & 0xff, (info->mfw_rev) & 0xff);
        DP_INFO(edev, " Management Firmware version : %s\n", ver_str);
-       DP_INFO(edev, " Firmware file : %s\n", fw_file);
+       DP_INFO(edev, " Firmware file : %s\n", qede_fw_file);
        DP_INFO(edev, "*********************************\n");
 }
 
@@ -518,14 +433,9 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)
        params.update_vport_active_tx_flg = 1;
        params.vport_active_rx_flg = flg;
        params.vport_active_tx_flg = flg;
-       if (!qdev->enable_tx_switching) {
-               if ((QEDE_NPAR_TX_SWITCHING != NULL) ||
-                   ((QEDE_VF_TX_SWITCHING != NULL) && IS_VF(edev))) {
-                       params.update_tx_switching_flg = 1;
-                       params.tx_switching_flg = !flg;
-                       DP_INFO(edev, "%s tx-switching is disabled\n",
-                               QEDE_NPAR_TX_SWITCHING ? "NPAR" : "VF");
-               }
+       if (~qdev->enable_tx_switching & flg) {
+               params.update_tx_switching_flg = 1;
+               params.tx_switching_flg = !flg;
        }
        for_each_hwfn(edev, i) {
                p_hwfn = &edev->hwfns[i];
@@ -603,45 +513,6 @@ int qede_enable_tpa(struct rte_eth_dev *eth_dev, bool flg)
        return 0;
 }
 
-/* Update MTU via vport-update without doing port restart.
- * The vport must be deactivated before calling this API.
- */
-int qede_update_mtu(struct rte_eth_dev *eth_dev, uint16_t mtu)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       struct ecore_sp_vport_update_params params;
-       struct ecore_hwfn *p_hwfn;
-       int rc;
-       int i;
-
-       memset(&params, 0, sizeof(struct ecore_sp_vport_update_params));
-       params.vport_id = 0;
-       params.mtu = mtu;
-       params.vport_id = 0;
-       for_each_hwfn(edev, i) {
-               p_hwfn = &edev->hwfns[i];
-               params.opaque_fid = p_hwfn->hw_info.opaque_fid;
-               rc = ecore_sp_vport_update(p_hwfn, &params,
-                               ECORE_SPQ_MODE_EBLOCK, NULL);
-               if (rc != ECORE_SUCCESS) {
-                       DP_ERR(edev, "Failed to update MTU\n");
-                       return -1;
-               }
-       }
-       DP_INFO(edev, "MTU updated to %u\n", mtu);
-
-       return 0;
-}
-
-static void qede_set_ucast_cmn_params(struct ecore_filter_ucast *ucast)
-{
-       memset(ucast, 0, sizeof(struct ecore_filter_ucast));
-       ucast->is_rx_filter = true;
-       ucast->is_tx_filter = true;
-       /* ucast->assert_on_error = true; - For debug */
-}
-
 static int
 qed_configure_filter_rx_mode(struct rte_eth_dev *eth_dev,
                             enum qed_filter_rx_mode_type type)
@@ -680,167 +551,7 @@ qed_configure_filter_rx_mode(struct rte_eth_dev *eth_dev,
                        ECORE_SPQ_MODE_CB, NULL);
 }
 
-static int
-qede_tunnel_update(struct qede_dev *qdev,
-                  struct ecore_tunnel_info *tunn_info)
-{
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       enum _ecore_status_t rc = ECORE_INVAL;
-       struct ecore_hwfn *p_hwfn;
-       struct ecore_ptt *p_ptt;
-       int i;
-
-       for_each_hwfn(edev, i) {
-               p_hwfn = &edev->hwfns[i];
-               if (IS_PF(edev)) {
-                       p_ptt = ecore_ptt_acquire(p_hwfn);
-                       if (!p_ptt) {
-                               DP_ERR(p_hwfn, "Can't acquire PTT\n");
-                               return -EAGAIN;
-                       }
-               } else {
-                       p_ptt = NULL;
-               }
-
-               rc = ecore_sp_pf_update_tunn_cfg(p_hwfn, p_ptt,
-                               tunn_info, ECORE_SPQ_MODE_CB, NULL);
-               if (IS_PF(edev))
-                       ecore_ptt_release(p_hwfn, p_ptt);
-
-               if (rc != ECORE_SUCCESS)
-                       break;
-       }
-
-       return rc;
-}
-
-static int
-qede_vxlan_enable(struct rte_eth_dev *eth_dev, uint8_t clss,
-                 bool enable)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       enum _ecore_status_t rc = ECORE_INVAL;
-       struct ecore_tunnel_info tunn;
-
-       if (qdev->vxlan.enable == enable)
-               return ECORE_SUCCESS;
-
-       memset(&tunn, 0, sizeof(struct ecore_tunnel_info));
-       tunn.vxlan.b_update_mode = true;
-       tunn.vxlan.b_mode_enabled = enable;
-       tunn.b_update_rx_cls = true;
-       tunn.b_update_tx_cls = true;
-       tunn.vxlan.tun_cls = clss;
-
-       tunn.vxlan_port.b_update_port = true;
-       tunn.vxlan_port.port = enable ? QEDE_VXLAN_DEF_PORT : 0;
-
-       rc = qede_tunnel_update(qdev, &tunn);
-       if (rc == ECORE_SUCCESS) {
-               qdev->vxlan.enable = enable;
-               qdev->vxlan.udp_port = (enable) ? QEDE_VXLAN_DEF_PORT : 0;
-               DP_INFO(edev, "vxlan is %s, UDP port = %d\n",
-                       enable ? "enabled" : "disabled", qdev->vxlan.udp_port);
-       } else {
-               DP_ERR(edev, "Failed to update tunn_clss %u\n",
-                      tunn.vxlan.tun_cls);
-       }
-
-       return rc;
-}
-
-static int
-qede_geneve_enable(struct rte_eth_dev *eth_dev, uint8_t clss,
-                 bool enable)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       enum _ecore_status_t rc = ECORE_INVAL;
-       struct ecore_tunnel_info tunn;
-
-       memset(&tunn, 0, sizeof(struct ecore_tunnel_info));
-       tunn.l2_geneve.b_update_mode = true;
-       tunn.l2_geneve.b_mode_enabled = enable;
-       tunn.ip_geneve.b_update_mode = true;
-       tunn.ip_geneve.b_mode_enabled = enable;
-       tunn.l2_geneve.tun_cls = clss;
-       tunn.ip_geneve.tun_cls = clss;
-       tunn.b_update_rx_cls = true;
-       tunn.b_update_tx_cls = true;
-
-       tunn.geneve_port.b_update_port = true;
-       tunn.geneve_port.port = enable ? QEDE_GENEVE_DEF_PORT : 0;
-
-       rc = qede_tunnel_update(qdev, &tunn);
-       if (rc == ECORE_SUCCESS) {
-               qdev->geneve.enable = enable;
-               qdev->geneve.udp_port = (enable) ? QEDE_GENEVE_DEF_PORT : 0;
-               DP_INFO(edev, "GENEVE is %s, UDP port = %d\n",
-                       enable ? "enabled" : "disabled", qdev->geneve.udp_port);
-       } else {
-               DP_ERR(edev, "Failed to update tunn_clss %u\n",
-                      clss);
-       }
-
-       return rc;
-}
-
-static int
-qede_ipgre_enable(struct rte_eth_dev *eth_dev, uint8_t clss,
-                 bool enable)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       enum _ecore_status_t rc = ECORE_INVAL;
-       struct ecore_tunnel_info tunn;
-
-       memset(&tunn, 0, sizeof(struct ecore_tunnel_info));
-       tunn.ip_gre.b_update_mode = true;
-       tunn.ip_gre.b_mode_enabled = enable;
-       tunn.ip_gre.tun_cls = clss;
-       tunn.ip_gre.tun_cls = clss;
-       tunn.b_update_rx_cls = true;
-       tunn.b_update_tx_cls = true;
-
-       rc = qede_tunnel_update(qdev, &tunn);
-       if (rc == ECORE_SUCCESS) {
-               qdev->ipgre.enable = enable;
-               DP_INFO(edev, "IPGRE is %s\n",
-                       enable ? "enabled" : "disabled");
-       } else {
-               DP_ERR(edev, "Failed to update tunn_clss %u\n",
-                      clss);
-       }
-
-       return rc;
-}
-
-static int
-qede_tunn_enable(struct rte_eth_dev *eth_dev, uint8_t clss,
-                enum rte_eth_tunnel_type tunn_type, bool enable)
-{
-       int rc = -EINVAL;
-
-       switch (tunn_type) {
-       case RTE_TUNNEL_TYPE_VXLAN:
-               rc = qede_vxlan_enable(eth_dev, clss, enable);
-               break;
-       case RTE_TUNNEL_TYPE_GENEVE:
-               rc = qede_geneve_enable(eth_dev, clss, enable);
-               break;
-       case RTE_TUNNEL_TYPE_IP_IN_GRE:
-               rc = qede_ipgre_enable(eth_dev, clss, enable);
-               break;
-       default:
-               rc = -EINVAL;
-               break;
-       }
-
-       return rc;
-}
-
-static int
+int
 qede_ucast_filter(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
                  bool add)
 {
@@ -848,19 +559,19 @@ qede_ucast_filter(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
        struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
        struct qede_ucast_entry *tmp = NULL;
        struct qede_ucast_entry *u;
-       struct ether_addr *mac_addr;
+       struct rte_ether_addr *mac_addr;
 
-       mac_addr  = (struct ether_addr *)ucast->mac;
+       mac_addr  = (struct rte_ether_addr *)ucast->mac;
        if (add) {
                SLIST_FOREACH(tmp, &qdev->uc_list_head, list) {
                        if ((memcmp(mac_addr, &tmp->mac,
-                                   ETHER_ADDR_LEN) == 0) &&
+                                   RTE_ETHER_ADDR_LEN) == 0) &&
                             ucast->vni == tmp->vni &&
                             ucast->vlan == tmp->vlan) {
-                               DP_ERR(edev, "Unicast MAC is already added"
-                                      " with vlan = %u, vni = %u\n",
-                                      ucast->vlan,  ucast->vni);
-                                       return -EEXIST;
+                               DP_INFO(edev, "Unicast MAC is already added"
+                                       " with vlan = %u, vni = %u\n",
+                                       ucast->vlan,  ucast->vni);
+                                       return 0;
                        }
                }
                u = rte_malloc(NULL, sizeof(struct qede_ucast_entry),
@@ -869,7 +580,7 @@ qede_ucast_filter(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
                        DP_ERR(edev, "Did not allocate memory for ucast\n");
                        return -ENOMEM;
                }
-               ether_addr_copy(mac_addr, &u->mac);
+               rte_ether_addr_copy(mac_addr, &u->mac);
                u->vlan = ucast->vlan;
                u->vni = ucast->vni;
                SLIST_INSERT_HEAD(&qdev->uc_list_head, u, list);
@@ -877,7 +588,7 @@ qede_ucast_filter(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
        } else {
                SLIST_FOREACH(tmp, &qdev->uc_list_head, list) {
                        if ((memcmp(mac_addr, &tmp->mac,
-                                   ETHER_ADDR_LEN) == 0) &&
+                                   RTE_ETHER_ADDR_LEN) == 0) &&
                            ucast->vlan == tmp->vlan      &&
                            ucast->vni == tmp->vni)
                        break;
@@ -894,8 +605,9 @@ qede_ucast_filter(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
 }
 
 static int
-qede_add_mcast_filters(struct rte_eth_dev *eth_dev, struct ether_addr *mc_addrs,
-                      uint32_t mc_addrs_num)
+qede_add_mcast_filters(struct rte_eth_dev *eth_dev,
+               struct rte_ether_addr *mc_addrs,
+               uint32_t mc_addrs_num)
 {
        struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
        struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
@@ -911,14 +623,14 @@ qede_add_mcast_filters(struct rte_eth_dev *eth_dev, struct ether_addr *mc_addrs,
                        DP_ERR(edev, "Did not allocate memory for mcast\n");
                        return -ENOMEM;
                }
-               ether_addr_copy(&mc_addrs[i], &m->mac);
+               rte_ether_addr_copy(&mc_addrs[i], &m->mac);
                SLIST_INSERT_HEAD(&qdev->mc_list_head, m, list);
        }
        memset(&mcast, 0, sizeof(mcast));
        mcast.num_mc_addrs = mc_addrs_num;
        mcast.opcode = ECORE_FILTER_ADD;
        for (i = 0; i < mc_addrs_num; i++)
-               ether_addr_copy(&mc_addrs[i], (struct ether_addr *)
+               rte_ether_addr_copy(&mc_addrs[i], (struct rte_ether_addr *)
                                                        &mcast.mac[i]);
        rc = ecore_filter_mcast_cmd(edev, &mcast, ECORE_SPQ_MODE_CB, NULL);
        if (rc != ECORE_SUCCESS) {
@@ -943,7 +655,8 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev)
        mcast.opcode = ECORE_FILTER_REMOVE;
        j = 0;
        SLIST_FOREACH(tmp, &qdev->mc_list_head, list) {
-               ether_addr_copy(&tmp->mac, (struct ether_addr *)&mcast.mac[j]);
+               rte_ether_addr_copy(&tmp->mac,
+                               (struct rte_ether_addr *)&mcast.mac[j]);
                j++;
        }
        rc = ecore_filter_mcast_cmd(edev, &mcast, ECORE_SPQ_MODE_CB, NULL);
@@ -961,7 +674,7 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev)
        return 0;
 }
 
-static enum _ecore_status_t
+enum _ecore_status_t
 qede_mac_int_ops(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
                 bool add)
 {
@@ -979,7 +692,10 @@ qede_mac_int_ops(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
        if (rc == 0)
                rc = ecore_filter_ucast_cmd(edev, ucast,
                                            ECORE_SPQ_MODE_CB, NULL);
-       if (rc != ECORE_SUCCESS)
+       /* Indicate error only for add filter operation.
+        * Delete filter operations are not severe.
+        */
+       if ((rc != ECORE_SUCCESS) && add)
                DP_ERR(edev, "MAC filter failed, rc = %d, op = %d\n",
                       rc, add);
 
@@ -987,15 +703,19 @@ qede_mac_int_ops(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
 }
 
 static int
-qede_mac_addr_add(struct rte_eth_dev *eth_dev, struct ether_addr *mac_addr,
+qede_mac_addr_add(struct rte_eth_dev *eth_dev, struct rte_ether_addr *mac_addr,
                  __rte_unused uint32_t index, __rte_unused uint32_t pool)
 {
        struct ecore_filter_ucast ucast;
        int re;
 
+       if (!rte_is_valid_assigned_ether_addr(mac_addr))
+               return -EINVAL;
+
        qede_set_ucast_cmn_params(&ucast);
+       ucast.opcode = ECORE_FILTER_ADD;
        ucast.type = ECORE_FILTER_MAC;
-       ether_addr_copy(mac_addr, (struct ether_addr *)&ucast.mac);
+       rte_ether_addr_copy(mac_addr, (struct rte_ether_addr *)&ucast.mac);
        re = (int)qede_mac_int_ops(eth_dev, &ucast, 1);
        return re;
 }
@@ -1015,19 +735,22 @@ qede_mac_addr_remove(struct rte_eth_dev *eth_dev, uint32_t index)
                return;
        }
 
+       if (!rte_is_valid_assigned_ether_addr(&eth_dev->data->mac_addrs[index]))
+               return;
+
        qede_set_ucast_cmn_params(&ucast);
        ucast.opcode = ECORE_FILTER_REMOVE;
        ucast.type = ECORE_FILTER_MAC;
 
        /* Use the index maintained by rte */
-       ether_addr_copy(&eth_dev->data->mac_addrs[index],
-                       (struct ether_addr *)&ucast.mac);
+       rte_ether_addr_copy(&eth_dev->data->mac_addrs[index],
+                       (struct rte_ether_addr *)&ucast.mac);
 
        qede_mac_int_ops(eth_dev, &ucast, false);
 }
 
 static int
-qede_mac_addr_set(struct rte_eth_dev *eth_dev, struct ether_addr *mac_addr)
+qede_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *mac_addr)
 {
        struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
        struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
@@ -1038,11 +761,12 @@ qede_mac_addr_set(struct rte_eth_dev *eth_dev, struct ether_addr *mac_addr)
                return -EPERM;
        }
 
-       qede_mac_addr_add(eth_dev, mac_addr, 0, 0);
-       return 0;
+       qede_mac_addr_remove(eth_dev, 0);
+
+       return qede_mac_addr_add(eth_dev, mac_addr, 0, 0);
 }
 
-static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool flg)
+void qede_config_accept_any_vlan(struct qede_dev *qdev, bool flg)
 {
        struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
        struct ecore_sp_vport_update_params params;
@@ -1117,9 +841,9 @@ static int qede_vlan_filter_set(struct rte_eth_dev *eth_dev,
 
                SLIST_FOREACH(tmp, &qdev->vlan_list_head, list) {
                        if (tmp->vid == vlan_id) {
-                               DP_ERR(edev, "VLAN %u already configured\n",
-                                      vlan_id);
-                               return -EEXIST;
+                               DP_INFO(edev, "VLAN %u already configured\n",
+                                       vlan_id);
+                               return 0;
                        }
                }
 
@@ -1296,6 +1020,12 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
 
        PMD_INIT_FUNC_TRACE(edev);
 
+       /* Update MTU only if it has changed */
+       if (eth_dev->data->mtu != qdev->mtu) {
+               if (qede_update_mtu(eth_dev, qdev->mtu))
+                       goto err;
+       }
+
        /* Configure TPA parameters */
        if (rxmode->offloads & DEV_RX_OFFLOAD_TCP_LRO) {
                if (qede_enable_tpa(eth_dev, true))
@@ -1359,13 +1089,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
        /* Disable traffic */
        ecore_hw_stop_fastpath(edev); /* TBD - loop */
 
-       if (IS_PF(edev))
-               qede_mac_addr_remove(eth_dev, 0);
-
        DP_INFO(edev, "Device is stopped\n");
 }
 
-const char *valid_args[] = {
+static const char * const valid_args[] = {
        QEDE_NPAR_TX_SWITCHING,
        QEDE_VF_TX_SWITCHING,
        NULL,
@@ -1387,8 +1114,12 @@ static int qede_args_check(const char *key, const char *val, void *opaque)
        }
 
        if ((strcmp(QEDE_NPAR_TX_SWITCHING, key) == 0) ||
-           (strcmp(QEDE_VF_TX_SWITCHING, key) == 0))
+           ((strcmp(QEDE_VF_TX_SWITCHING, key) == 0) && IS_VF(edev))) {
                qdev->enable_tx_switching = !!tmp;
+               DP_INFO(edev, "Disabling %s tx-switching\n",
+                       strcmp(QEDE_NPAR_TX_SWITCHING, key) ?
+                       "VF" : "NPAR");
+       }
 
        return ret;
 }
@@ -1463,7 +1194,8 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
 
        /* Parse devargs and fix up rxmode */
        if (qede_args(eth_dev))
-               return -ENOTSUP;
+               DP_NOTICE(edev, false,
+                         "Invalid devargs supplied, requested change will not take effect\n");
 
        if (!(rxmode->mq_mode == ETH_MQ_RX_NONE ||
              rxmode->mq_mode == ETH_MQ_RX_RSS)) {
@@ -1484,7 +1216,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
        if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
                eth_dev->data->mtu =
                        eth_dev->data->dev_conf.rxmode.max_rx_pkt_len -
-                       ETHER_HDR_LEN - ETHER_CRC_LEN;
+                       RTE_ETHER_HDR_LEN - QEDE_ETH_OVERHEAD;
 
        if (rxmode->offloads & DEV_RX_OFFLOAD_SCATTER)
                eth_dev->data->scattered_rx = 1;
@@ -1496,8 +1228,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
 
        /* Enable VLAN offloads by default */
        ret = qede_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK  |
-                                            ETH_VLAN_FILTER_MASK |
-                                            ETH_VLAN_EXTEND_MASK);
+                                            ETH_VLAN_FILTER_MASK);
        if (ret)
                return ret;
 
@@ -1556,7 +1287,7 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,
                                     DEV_RX_OFFLOAD_TCP_CKSUM   |
                                     DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
                                     DEV_RX_OFFLOAD_TCP_LRO     |
-                                    DEV_RX_OFFLOAD_CRC_STRIP   |
+                                    DEV_RX_OFFLOAD_KEEP_CRC    |
                                     DEV_RX_OFFLOAD_SCATTER     |
                                     DEV_RX_OFFLOAD_JUMBO_FRAME |
                                     DEV_RX_OFFLOAD_VLAN_FILTER |
@@ -1571,7 +1302,6 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,
                                     DEV_TX_OFFLOAD_UDP_CKSUM   |
                                     DEV_TX_OFFLOAD_TCP_CKSUM   |
                                     DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
-                                    DEV_TX_OFFLOAD_QINQ_INSERT |
                                     DEV_TX_OFFLOAD_MULTI_SEGS  |
                                     DEV_TX_OFFLOAD_TCP_TSO     |
                                     DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
@@ -1585,11 +1315,7 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,
        dev_info->default_rxconf = (struct rte_eth_rxconf) {
                /* Packets are always dropped if no descriptors are available */
                .rx_drop_en = 1,
-               /* The below RX offloads are always enabled */
-               .offloads = (DEV_RX_OFFLOAD_CRC_STRIP  |
-                            DEV_RX_OFFLOAD_IPV4_CKSUM |
-                            DEV_RX_OFFLOAD_TCP_CKSUM  |
-                            DEV_RX_OFFLOAD_UDP_CKSUM),
+               .offloads = 0,
        };
 
        memset(&link, 0, sizeof(struct qed_link_output));
@@ -1615,18 +1341,20 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete)
 {
        struct qede_dev *qdev = eth_dev->data->dev_private;
        struct ecore_dev *edev = &qdev->edev;
+       struct qed_link_output q_link;
+       struct rte_eth_link link;
        uint16_t link_duplex;
-       struct qed_link_output link;
-       struct rte_eth_link *curr = &eth_dev->data->dev_link;
 
-       memset(&link, 0, sizeof(struct qed_link_output));
-       qdev->ops->common->get_link(edev, &link);
+       memset(&q_link, 0, sizeof(q_link));
+       memset(&link, 0, sizeof(link));
+
+       qdev->ops->common->get_link(edev, &q_link);
 
        /* Link Speed */
-       curr->link_speed = link.speed;
+       link.link_speed = q_link.speed;
 
        /* Link Mode */
-       switch (link.duplex) {
+       switch (q_link.duplex) {
        case QEDE_DUPLEX_HALF:
                link_duplex = ETH_LINK_HALF_DUPLEX;
                break;
@@ -1637,33 +1365,29 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete)
        default:
                link_duplex = -1;
        }
-       curr->link_duplex = link_duplex;
+       link.link_duplex = link_duplex;
 
        /* Link Status */
-       curr->link_status = (link.link_up) ? ETH_LINK_UP : ETH_LINK_DOWN;
+       link.link_status = q_link.link_up ? ETH_LINK_UP : ETH_LINK_DOWN;
 
        /* AN */
-       curr->link_autoneg = (link.supported_caps & QEDE_SUPPORTED_AUTONEG) ?
+       link.link_autoneg = (q_link.supported_caps & QEDE_SUPPORTED_AUTONEG) ?
                             ETH_LINK_AUTONEG : ETH_LINK_FIXED;
 
        DP_INFO(edev, "Link - Speed %u Mode %u AN %u Status %u\n",
-               curr->link_speed, curr->link_duplex,
-               curr->link_autoneg, curr->link_status);
+               link.link_speed, link.link_duplex,
+               link.link_autoneg, link.link_status);
 
-       /* return 0 means link status changed, -1 means not changed */
-       return ((curr->link_status == link.link_up) ? -1 : 0);
+       return rte_eth_linkstatus_set(eth_dev, &link);
 }
 
 static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev)
 {
-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
        struct qede_dev *qdev = eth_dev->data->dev_private;
        struct ecore_dev *edev = &qdev->edev;
+       enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC;
 
        PMD_INIT_FUNC_TRACE(edev);
-#endif
-
-       enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC;
 
        if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1)
                type |= QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;
@@ -1673,12 +1397,10 @@ static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev)
 
 static void qede_promiscuous_disable(struct rte_eth_dev *eth_dev)
 {
-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
        struct qede_dev *qdev = eth_dev->data->dev_private;
        struct ecore_dev *edev = &qdev->edev;
 
        PMD_INIT_FUNC_TRACE(edev);
-#endif
 
        if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1)
                qed_configure_filter_rx_mode(eth_dev,
@@ -1698,7 +1420,7 @@ static void qede_poll_sp_sb_cb(void *param)
        qede_interrupt_action(ECORE_LEADING_HWFN(edev));
        qede_interrupt_action(&edev->hwfns[1]);
 
-       rc = rte_eal_alarm_set(timer_period * US_PER_S,
+       rc = rte_eal_alarm_set(QEDE_SP_TIMER_PERIOD,
                               qede_poll_sp_sb_cb,
                               (void *)eth_dev);
        if (rc != 0) {
@@ -1737,8 +1459,20 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
        qdev->ops->common->slowpath_stop(edev);
        qdev->ops->common->remove(edev);
        rte_intr_disable(&pci_dev->intr_handle);
-       rte_intr_callback_unregister(&pci_dev->intr_handle,
-                                    qede_interrupt_handler, (void *)eth_dev);
+
+       switch (pci_dev->intr_handle.type) {
+       case RTE_INTR_HANDLE_UIO_INTX:
+       case RTE_INTR_HANDLE_VFIO_LEGACY:
+               rte_intr_callback_unregister(&pci_dev->intr_handle,
+                                            qede_interrupt_handler_intx,
+                                            (void *)eth_dev);
+               break;
+       default:
+               rte_intr_callback_unregister(&pci_dev->intr_handle,
+                                          qede_interrupt_handler,
+                                          (void *)eth_dev);
+       }
+
        if (ECORE_IS_CMT(edev))
                rte_eal_alarm_cancel(qede_poll_sp_sb_cb, (void *)eth_dev);
 }
@@ -1860,27 +1594,24 @@ qede_get_xstats_names(struct rte_eth_dev *dev,
 
        if (xstats_names != NULL) {
                for (i = 0; i < RTE_DIM(qede_xstats_strings); i++) {
-                       snprintf(xstats_names[stat_idx].name,
-                               sizeof(xstats_names[stat_idx].name),
-                               "%s",
-                               qede_xstats_strings[i].name);
+                       strlcpy(xstats_names[stat_idx].name,
+                               qede_xstats_strings[i].name,
+                               sizeof(xstats_names[stat_idx].name));
                        stat_idx++;
                }
 
                if (ECORE_IS_BB(edev)) {
                        for (i = 0; i < RTE_DIM(qede_bb_xstats_strings); i++) {
-                               snprintf(xstats_names[stat_idx].name,
-                                       sizeof(xstats_names[stat_idx].name),
-                                       "%s",
-                                       qede_bb_xstats_strings[i].name);
+                               strlcpy(xstats_names[stat_idx].name,
+                                       qede_bb_xstats_strings[i].name,
+                                       sizeof(xstats_names[stat_idx].name));
                                stat_idx++;
                        }
                } else {
                        for (i = 0; i < RTE_DIM(qede_ah_xstats_strings); i++) {
-                               snprintf(xstats_names[stat_idx].name,
-                                       sizeof(xstats_names[stat_idx].name),
-                                       "%s",
-                                       qede_ah_xstats_strings[i].name);
+                               strlcpy(xstats_names[stat_idx].name,
+                                       qede_ah_xstats_strings[i].name,
+                                       sizeof(xstats_names[stat_idx].name));
                                stat_idx++;
                        }
                }
@@ -2028,8 +1759,9 @@ static void qede_allmulticast_disable(struct rte_eth_dev *eth_dev)
 }
 
 static int
-qede_set_mc_addr_list(struct rte_eth_dev *eth_dev, struct ether_addr *mc_addrs,
-                     uint32_t mc_addrs_num)
+qede_set_mc_addr_list(struct rte_eth_dev *eth_dev,
+               struct rte_ether_addr *mc_addrs,
+               uint32_t mc_addrs_num)
 {
        struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
        struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
@@ -2042,7 +1774,7 @@ qede_set_mc_addr_list(struct rte_eth_dev *eth_dev, struct ether_addr *mc_addrs,
        }
 
        for (i = 0; i < mc_addrs_num; i++) {
-               if (!is_multicast_ether_addr(&mc_addrs[i])) {
+               if (!rte_is_multicast_ether_addr(&mc_addrs[i])) {
                        DP_ERR(edev, "Not a valid multicast MAC\n");
                        return -EINVAL;
                }
@@ -2056,6 +1788,70 @@ qede_set_mc_addr_list(struct rte_eth_dev *eth_dev, struct ether_addr *mc_addrs,
        return qede_add_mcast_filters(eth_dev, mc_addrs, mc_addrs_num);
 }
 
+/* Update MTU via vport-update without doing port restart.
+ * The vport must be deactivated before calling this API.
+ */
+int qede_update_mtu(struct rte_eth_dev *eth_dev, uint16_t mtu)
+{
+       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
+       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
+       struct ecore_hwfn *p_hwfn;
+       int rc;
+       int i;
+
+       if (IS_PF(edev)) {
+               struct ecore_sp_vport_update_params params;
+
+               memset(&params, 0, sizeof(struct ecore_sp_vport_update_params));
+               params.vport_id = 0;
+               params.mtu = mtu;
+               params.vport_id = 0;
+               for_each_hwfn(edev, i) {
+                       p_hwfn = &edev->hwfns[i];
+                       params.opaque_fid = p_hwfn->hw_info.opaque_fid;
+                       rc = ecore_sp_vport_update(p_hwfn, &params,
+                                       ECORE_SPQ_MODE_EBLOCK, NULL);
+                       if (rc != ECORE_SUCCESS)
+                               goto err;
+               }
+       } else {
+               for_each_hwfn(edev, i) {
+                       p_hwfn = &edev->hwfns[i];
+                       rc = ecore_vf_pf_update_mtu(p_hwfn, mtu);
+                       if (rc == ECORE_INVAL) {
+                               DP_INFO(edev, "VF MTU Update TLV not supported\n");
+                               /* Recreate vport */
+                               rc = qede_start_vport(qdev, mtu);
+                               if (rc != ECORE_SUCCESS)
+                                       goto err;
+
+                               /* Restore config lost due to vport stop */
+                               if (eth_dev->data->promiscuous)
+                                       qede_promiscuous_enable(eth_dev);
+                               else
+                                       qede_promiscuous_disable(eth_dev);
+
+                               if (eth_dev->data->all_multicast)
+                                       qede_allmulticast_enable(eth_dev);
+                               else
+                                       qede_allmulticast_disable(eth_dev);
+
+                               qede_vlan_offload_set(eth_dev,
+                                                     qdev->vlan_offload_mask);
+                       } else if (rc != ECORE_SUCCESS) {
+                               goto err;
+                       }
+               }
+       }
+       DP_INFO(edev, "%s MTU updated to %u\n", IS_PF(edev) ? "PF" : "VF", mtu);
+
+       return 0;
+
+err:
+       DP_ERR(edev, "Failed to update MTU\n");
+       return -1;
+}
+
 static int qede_flow_ctrl_set(struct rte_eth_dev *eth_dev,
                              struct rte_eth_fc_conf *fc_conf)
 {
@@ -2210,7 +2006,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
        vport_update_params.vport_id = 0;
        /* pass the L2 handles instead of qids */
        for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) {
-               idx = qdev->rss_ind_table[i];
+               idx = i % QEDE_RSS_COUNT(qdev);
                rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq->handle;
        }
        vport_update_params.rss_params = &rss_params;
@@ -2428,19 +2224,18 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
        struct qede_fastpath *fp;
        uint32_t max_rx_pkt_len;
        uint32_t frame_size;
-       uint16_t rx_buf_size;
        uint16_t bufsz;
        bool restart = false;
-       int i;
+       int i, rc;
 
        PMD_INIT_FUNC_TRACE(edev);
        qede_dev_info_get(dev, &dev_info);
-       max_rx_pkt_len = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;
-       frame_size = max_rx_pkt_len + QEDE_ETH_OVERHEAD;
-       if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) {
+       max_rx_pkt_len = mtu + QEDE_MAX_ETHER_HDR_LEN;
+       frame_size = max_rx_pkt_len;
+       if (mtu < RTE_ETHER_MIN_MTU || frame_size > dev_info.max_rx_pktlen) {
                DP_ERR(edev, "MTU %u out of range, %u is maximum allowable\n",
-                      mtu, dev_info.max_rx_pktlen - ETHER_HDR_LEN -
-                       ETHER_CRC_LEN - QEDE_ETH_OVERHEAD);
+                      mtu, dev_info.max_rx_pktlen - RTE_ETHER_HDR_LEN -
+                      QEDE_ETH_OVERHEAD);
                return -EINVAL;
        }
        if (!dev->data->scattered_rx &&
@@ -2458,12 +2253,8 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
                dev->data->dev_started = 0;
                qede_dev_stop(dev);
                restart = true;
-       } else {
-               if (IS_PF(edev))
-                       qede_mac_addr_remove(dev, 0);
        }
        rte_delay_ms(1000);
-       qede_start_vport(qdev, mtu); /* Recreate vport */
        qdev->mtu = mtu;
 
        /* Fix up RX buf size for all queues of the port */
@@ -2472,36 +2263,21 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
                if (fp->rxq != NULL) {
                        bufsz = (uint16_t)rte_pktmbuf_data_room_size(
                                fp->rxq->mb_pool) - RTE_PKTMBUF_HEADROOM;
-                       if (dev->data->scattered_rx)
-                               rx_buf_size = bufsz + ETHER_HDR_LEN +
-                                             ETHER_CRC_LEN + QEDE_ETH_OVERHEAD;
-                       else
-                               rx_buf_size = frame_size;
-                       rx_buf_size = QEDE_CEIL_TO_CACHE_LINE_SIZE(rx_buf_size);
-                       fp->rxq->rx_buf_size = rx_buf_size;
-                       DP_INFO(edev, "RX buffer size %u\n", rx_buf_size);
+                       /* cache align the mbuf size to simplfy rx_buf_size
+                        * calculation
+                        */
+                       bufsz = QEDE_FLOOR_TO_CACHE_LINE_SIZE(bufsz);
+                       rc = qede_calc_rx_buf_size(dev, bufsz, frame_size);
+                       if (rc < 0)
+                               return rc;
+
+                       fp->rxq->rx_buf_size = rc;
                }
        }
-       if (max_rx_pkt_len > ETHER_MAX_LEN)
-               dev->data->dev_conf.rxmode.jumbo_frame = 1;
-       else
-               dev->data->dev_conf.rxmode.jumbo_frame = 0;
-
-       /* Restore config lost due to vport stop */
-       if (IS_PF(edev))
-               qede_mac_addr_set(dev, &qdev->primary_mac);
-
-       if (dev->data->promiscuous)
-               qede_promiscuous_enable(dev);
-       else
-               qede_promiscuous_disable(dev);
-
-       if (dev->data->all_multicast)
-               qede_allmulticast_enable(dev);
+       if (max_rx_pkt_len > RTE_ETHER_MAX_LEN)
+               dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
        else
-               qede_allmulticast_disable(dev);
-
-       qede_vlan_offload_set(dev, qdev->vlan_offload_mask);
+               dev->data->dev_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
 
        if (!dev->data->dev_started && restart) {
                qede_dev_start(dev);
@@ -2518,411 +2294,15 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
 }
 
 static int
-qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
-                     struct rte_eth_udp_tunnel *tunnel_udp)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       struct ecore_tunnel_info tunn; /* @DPDK */
-       uint16_t udp_port;
-       int rc;
-
-       PMD_INIT_FUNC_TRACE(edev);
-
-       memset(&tunn, 0, sizeof(tunn));
-
-       switch (tunnel_udp->prot_type) {
-       case RTE_TUNNEL_TYPE_VXLAN:
-               if (qdev->vxlan.udp_port != tunnel_udp->udp_port) {
-                       DP_ERR(edev, "UDP port %u doesn't exist\n",
-                               tunnel_udp->udp_port);
-                       return ECORE_INVAL;
-               }
-               udp_port = 0;
-
-               tunn.vxlan_port.b_update_port = true;
-               tunn.vxlan_port.port = udp_port;
-
-               rc = qede_tunnel_update(qdev, &tunn);
-               if (rc != ECORE_SUCCESS) {
-                       DP_ERR(edev, "Unable to config UDP port %u\n",
-                              tunn.vxlan_port.port);
-                       return rc;
-               }
-
-               qdev->vxlan.udp_port = udp_port;
-               /* If the request is to delete UDP port and if the number of
-                * VXLAN filters have reached 0 then VxLAN offload can be be
-                * disabled.
-                */
-               if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
-                       return qede_vxlan_enable(eth_dev,
-                                       ECORE_TUNN_CLSS_MAC_VLAN, false);
-
-               break;
-       case RTE_TUNNEL_TYPE_GENEVE:
-               if (qdev->geneve.udp_port != tunnel_udp->udp_port) {
-                       DP_ERR(edev, "UDP port %u doesn't exist\n",
-                               tunnel_udp->udp_port);
-                       return ECORE_INVAL;
-               }
-
-               udp_port = 0;
-
-               tunn.geneve_port.b_update_port = true;
-               tunn.geneve_port.port = udp_port;
-
-               rc = qede_tunnel_update(qdev, &tunn);
-               if (rc != ECORE_SUCCESS) {
-                       DP_ERR(edev, "Unable to config UDP port %u\n",
-                              tunn.vxlan_port.port);
-                       return rc;
-               }
-
-               qdev->vxlan.udp_port = udp_port;
-               /* If the request is to delete UDP port and if the number of
-                * GENEVE filters have reached 0 then GENEVE offload can be be
-                * disabled.
-                */
-               if (qdev->geneve.enable && qdev->geneve.num_filters == 0)
-                       return qede_geneve_enable(eth_dev,
-                                       ECORE_TUNN_CLSS_MAC_VLAN, false);
-
-               break;
-
-       default:
-               return ECORE_INVAL;
-       }
-
-       return 0;
-
-}
-static int
-qede_udp_dst_port_add(struct rte_eth_dev *eth_dev,
-                     struct rte_eth_udp_tunnel *tunnel_udp)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       struct ecore_tunnel_info tunn; /* @DPDK */
-       uint16_t udp_port;
-       int rc;
-
-       PMD_INIT_FUNC_TRACE(edev);
-
-       memset(&tunn, 0, sizeof(tunn));
-
-       switch (tunnel_udp->prot_type) {
-       case RTE_TUNNEL_TYPE_VXLAN:
-               if (qdev->vxlan.udp_port == tunnel_udp->udp_port) {
-                       DP_INFO(edev,
-                               "UDP port %u for VXLAN was already configured\n",
-                               tunnel_udp->udp_port);
-                       return ECORE_SUCCESS;
-               }
-
-               /* Enable VxLAN tunnel with default MAC/VLAN classification if
-                * it was not enabled while adding VXLAN filter before UDP port
-                * update.
-                */
-               if (!qdev->vxlan.enable) {
-                       rc = qede_vxlan_enable(eth_dev,
-                               ECORE_TUNN_CLSS_MAC_VLAN, true);
-                       if (rc != ECORE_SUCCESS) {
-                               DP_ERR(edev, "Failed to enable VXLAN "
-                                       "prior to updating UDP port\n");
-                               return rc;
-                       }
-               }
-               udp_port = tunnel_udp->udp_port;
-
-               tunn.vxlan_port.b_update_port = true;
-               tunn.vxlan_port.port = udp_port;
-
-               rc = qede_tunnel_update(qdev, &tunn);
-               if (rc != ECORE_SUCCESS) {
-                       DP_ERR(edev, "Unable to config UDP port %u for VXLAN\n",
-                              udp_port);
-                       return rc;
-               }
-
-               DP_INFO(edev, "Updated UDP port %u for VXLAN\n", udp_port);
-
-               qdev->vxlan.udp_port = udp_port;
-               break;
-       case RTE_TUNNEL_TYPE_GENEVE:
-               if (qdev->geneve.udp_port == tunnel_udp->udp_port) {
-                       DP_INFO(edev,
-                               "UDP port %u for GENEVE was already configured\n",
-                               tunnel_udp->udp_port);
-                       return ECORE_SUCCESS;
-               }
-
-               /* Enable GENEVE tunnel with default MAC/VLAN classification if
-                * it was not enabled while adding GENEVE filter before UDP port
-                * update.
-                */
-               if (!qdev->geneve.enable) {
-                       rc = qede_geneve_enable(eth_dev,
-                               ECORE_TUNN_CLSS_MAC_VLAN, true);
-                       if (rc != ECORE_SUCCESS) {
-                               DP_ERR(edev, "Failed to enable GENEVE "
-                                       "prior to updating UDP port\n");
-                               return rc;
-                       }
-               }
-               udp_port = tunnel_udp->udp_port;
-
-               tunn.geneve_port.b_update_port = true;
-               tunn.geneve_port.port = udp_port;
-
-               rc = qede_tunnel_update(qdev, &tunn);
-               if (rc != ECORE_SUCCESS) {
-                       DP_ERR(edev, "Unable to config UDP port %u for GENEVE\n",
-                              udp_port);
-                       return rc;
-               }
-
-               DP_INFO(edev, "Updated UDP port %u for GENEVE\n", udp_port);
-
-               qdev->geneve.udp_port = udp_port;
-               break;
-       default:
-               return ECORE_INVAL;
-       }
-
-       return 0;
-}
-
-static void qede_get_ecore_tunn_params(uint32_t filter, uint32_t *type,
-                                      uint32_t *clss, char *str)
-{
-       uint16_t j;
-       *clss = MAX_ECORE_TUNN_CLSS;
-
-       for (j = 0; j < RTE_DIM(qede_tunn_types); j++) {
-               if (filter == qede_tunn_types[j].rte_filter_type) {
-                       *type = qede_tunn_types[j].qede_type;
-                       *clss = qede_tunn_types[j].qede_tunn_clss;
-                       strcpy(str, qede_tunn_types[j].string);
-                       return;
-               }
-       }
-}
-
-static int
-qede_set_ucast_tunn_cmn_param(struct ecore_filter_ucast *ucast,
-                             const struct rte_eth_tunnel_filter_conf *conf,
-                             uint32_t type)
-{
-       /* Init commmon ucast params first */
-       qede_set_ucast_cmn_params(ucast);
-
-       /* Copy out the required fields based on classification type */
-       ucast->type = type;
-
-       switch (type) {
-       case ECORE_FILTER_VNI:
-               ucast->vni = conf->tenant_id;
-       break;
-       case ECORE_FILTER_INNER_VLAN:
-               ucast->vlan = conf->inner_vlan;
-       break;
-       case ECORE_FILTER_MAC:
-               memcpy(ucast->mac, conf->outer_mac.addr_bytes,
-                      ETHER_ADDR_LEN);
-       break;
-       case ECORE_FILTER_INNER_MAC:
-               memcpy(ucast->mac, conf->inner_mac.addr_bytes,
-                      ETHER_ADDR_LEN);
-       break;
-       case ECORE_FILTER_MAC_VNI_PAIR:
-               memcpy(ucast->mac, conf->outer_mac.addr_bytes,
-                       ETHER_ADDR_LEN);
-               ucast->vni = conf->tenant_id;
-       break;
-       case ECORE_FILTER_INNER_MAC_VNI_PAIR:
-               memcpy(ucast->mac, conf->inner_mac.addr_bytes,
-                       ETHER_ADDR_LEN);
-               ucast->vni = conf->tenant_id;
-       break;
-       case ECORE_FILTER_INNER_PAIR:
-               memcpy(ucast->mac, conf->inner_mac.addr_bytes,
-                       ETHER_ADDR_LEN);
-               ucast->vlan = conf->inner_vlan;
-       break;
-       default:
-               return -EINVAL;
-       }
-
-       return ECORE_SUCCESS;
-}
-
-static int
-_qede_tunn_filter_config(struct rte_eth_dev *eth_dev,
-                        const struct rte_eth_tunnel_filter_conf *conf,
-                        __attribute__((unused)) enum rte_filter_op filter_op,
-                        enum ecore_tunn_clss *clss,
-                        bool add)
+qede_dev_reset(struct rte_eth_dev *dev)
 {
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       struct ecore_filter_ucast ucast = {0};
-       enum ecore_filter_ucast_type type;
-       uint16_t filter_type = 0;
-       char str[80];
-       int rc;
-
-       filter_type = conf->filter_type;
-       /* Determine if the given filter classification is supported */
-       qede_get_ecore_tunn_params(filter_type, &type, clss, str);
-       if (*clss == MAX_ECORE_TUNN_CLSS) {
-               DP_ERR(edev, "Unsupported filter type\n");
-               return -EINVAL;
-       }
-       /* Init tunnel ucast params */
-       rc = qede_set_ucast_tunn_cmn_param(&ucast, conf, type);
-       if (rc != ECORE_SUCCESS) {
-               DP_ERR(edev, "Unsupported Tunnel filter type 0x%x\n",
-               conf->filter_type);
-               return rc;
-       }
-       DP_INFO(edev, "Rule: \"%s\", op %d, type 0x%x\n",
-               str, filter_op, ucast.type);
-
-       ucast.opcode = add ? ECORE_FILTER_ADD : ECORE_FILTER_REMOVE;
-
-       /* Skip MAC/VLAN if filter is based on VNI */
-       if (!(filter_type & ETH_TUNNEL_FILTER_TENID)) {
-               rc = qede_mac_int_ops(eth_dev, &ucast, add);
-               if ((rc == 0) && add) {
-                       /* Enable accept anyvlan */
-                       qede_config_accept_any_vlan(qdev, true);
-               }
-       } else {
-               rc = qede_ucast_filter(eth_dev, &ucast, add);
-               if (rc == 0)
-                       rc = ecore_filter_ucast_cmd(edev, &ucast,
-                                           ECORE_SPQ_MODE_CB, NULL);
-       }
-
-       return rc;
-}
-
-static int
-qede_tunn_filter_config(struct rte_eth_dev *eth_dev,
-                       enum rte_filter_op filter_op,
-                       const struct rte_eth_tunnel_filter_conf *conf)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       enum ecore_tunn_clss clss = MAX_ECORE_TUNN_CLSS;
-       bool add;
-       int rc;
-
-       PMD_INIT_FUNC_TRACE(edev);
-
-       switch (filter_op) {
-       case RTE_ETH_FILTER_ADD:
-               add = true;
-               break;
-       case RTE_ETH_FILTER_DELETE:
-               add = false;
-               break;
-       default:
-               DP_ERR(edev, "Unsupported operation %d\n", filter_op);
-               return -EINVAL;
-       }
-
-       if (IS_VF(edev))
-               return qede_tunn_enable(eth_dev,
-                                       ECORE_TUNN_CLSS_MAC_VLAN,
-                                       conf->tunnel_type, add);
-
-       rc = _qede_tunn_filter_config(eth_dev, conf, filter_op, &clss, add);
-       if (rc != ECORE_SUCCESS)
-               return rc;
-
-       if (add) {
-               if (conf->tunnel_type == RTE_TUNNEL_TYPE_VXLAN) {
-                       qdev->vxlan.num_filters++;
-                       qdev->vxlan.filter_type = conf->filter_type;
-               } else { /* GENEVE */
-                       qdev->geneve.num_filters++;
-                       qdev->geneve.filter_type = conf->filter_type;
-               }
-
-               if (!qdev->vxlan.enable || !qdev->geneve.enable ||
-                   !qdev->ipgre.enable)
-                       return qede_tunn_enable(eth_dev, clss,
-                                               conf->tunnel_type,
-                                               true);
-       } else {
-               if (conf->tunnel_type == RTE_TUNNEL_TYPE_VXLAN)
-                       qdev->vxlan.num_filters--;
-               else /*GENEVE*/
-                       qdev->geneve.num_filters--;
-
-               /* Disable VXLAN if VXLAN filters become 0 */
-               if ((qdev->vxlan.num_filters == 0) ||
-                   (qdev->geneve.num_filters == 0))
-                       return qede_tunn_enable(eth_dev, clss,
-                                               conf->tunnel_type,
-                                               false);
-       }
-
-       return 0;
-}
+       int ret;
 
-int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev,
-                        enum rte_filter_type filter_type,
-                        enum rte_filter_op filter_op,
-                        void *arg)
-{
-       struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
-       struct ecore_dev *edev = QEDE_INIT_EDEV(qdev);
-       struct rte_eth_tunnel_filter_conf *filter_conf =
-                       (struct rte_eth_tunnel_filter_conf *)arg;
-
-       switch (filter_type) {
-       case RTE_ETH_FILTER_TUNNEL:
-               switch (filter_conf->tunnel_type) {
-               case RTE_TUNNEL_TYPE_VXLAN:
-               case RTE_TUNNEL_TYPE_GENEVE:
-               case RTE_TUNNEL_TYPE_IP_IN_GRE:
-                       DP_INFO(edev,
-                               "Packet steering to the specified Rx queue"
-                               " is not supported with UDP tunneling");
-                       return(qede_tunn_filter_config(eth_dev, filter_op,
-                                                     filter_conf));
-               case RTE_TUNNEL_TYPE_TEREDO:
-               case RTE_TUNNEL_TYPE_NVGRE:
-               case RTE_L2_TUNNEL_TYPE_E_TAG:
-                       DP_ERR(edev, "Unsupported tunnel type %d\n",
-                               filter_conf->tunnel_type);
-                       return -EINVAL;
-               case RTE_TUNNEL_TYPE_NONE:
-               default:
-                       return 0;
-               }
-               break;
-       case RTE_ETH_FILTER_FDIR:
-               return qede_fdir_filter_conf(eth_dev, filter_op, arg);
-       case RTE_ETH_FILTER_NTUPLE:
-               return qede_ntuple_filter_conf(eth_dev, filter_op, arg);
-       case RTE_ETH_FILTER_MACVLAN:
-       case RTE_ETH_FILTER_ETHERTYPE:
-       case RTE_ETH_FILTER_FLEXIBLE:
-       case RTE_ETH_FILTER_SYN:
-       case RTE_ETH_FILTER_HASH:
-       case RTE_ETH_FILTER_L2_TUNNEL:
-       case RTE_ETH_FILTER_MAX:
-       default:
-               DP_ERR(edev, "Unsupported filter type %d\n",
-                       filter_type);
-               return -EINVAL;
-       }
+       ret = qede_eth_dev_uninit(dev);
+       if (ret)
+               return ret;
 
-       return 0;
+       return qede_eth_dev_init(dev);
 }
 
 static const struct eth_dev_ops qede_eth_dev_ops = {
@@ -2930,9 +2310,11 @@ static const struct eth_dev_ops qede_eth_dev_ops = {
        .dev_infos_get = qede_dev_info_get,
        .rx_queue_setup = qede_rx_queue_setup,
        .rx_queue_release = qede_rx_queue_release,
+       .rx_descriptor_status = qede_rx_descriptor_status,
        .tx_queue_setup = qede_tx_queue_setup,
        .tx_queue_release = qede_tx_queue_release,
        .dev_start = qede_dev_start,
+       .dev_reset = qede_dev_reset,
        .dev_set_link_up = qede_dev_set_link_up,
        .dev_set_link_down = qede_dev_set_link_down,
        .link_update = qede_link_update,
@@ -2971,9 +2353,11 @@ static const struct eth_dev_ops qede_eth_vf_dev_ops = {
        .dev_infos_get = qede_dev_info_get,
        .rx_queue_setup = qede_rx_queue_setup,
        .rx_queue_release = qede_rx_queue_release,
+       .rx_descriptor_status = qede_rx_descriptor_status,
        .tx_queue_setup = qede_tx_queue_setup,
        .tx_queue_release = qede_tx_queue_release,
        .dev_start = qede_dev_start,
+       .dev_reset = qede_dev_reset,
        .dev_set_link_up = qede_dev_set_link_up,
        .dev_set_link_down = qede_dev_set_link_down,
        .link_update = qede_link_update,
@@ -2999,6 +2383,9 @@ static const struct eth_dev_ops qede_eth_vf_dev_ops = {
        .mtu_set = qede_set_mtu,
        .udp_tunnel_port_add = qede_udp_dst_port_add,
        .udp_tunnel_port_del = qede_udp_dst_port_del,
+       .mac_addr_add = qede_mac_addr_add,
+       .mac_addr_remove = qede_mac_addr_remove,
+       .mac_addr_set = qede_mac_addr_set,
 };
 
 static void qede_update_pf_params(struct ecore_dev *edev)
@@ -3021,12 +2408,13 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
        struct qed_slowpath_params params;
        static bool do_once = true;
        uint8_t bulletin_change;
-       uint8_t vf_mac[ETHER_ADDR_LEN];
+       uint8_t vf_mac[RTE_ETHER_ADDR_LEN];
        uint8_t is_mac_forced;
        bool is_mac_exist;
        /* Fix up ecore debug level */
        uint32_t dp_module = ~0 & ~ECORE_MSG_HW;
        uint8_t dp_level = ECORE_LEVEL_VERBOSE;
+       uint32_t int_mode;
        int rc;
 
        /* Extract key data structures */
@@ -3071,8 +2459,22 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
                return -ENODEV;
        }
        qede_update_pf_params(edev);
-       rte_intr_callback_register(&pci_dev->intr_handle,
-                                  qede_interrupt_handler, (void *)eth_dev);
+
+       switch (pci_dev->intr_handle.type) {
+       case RTE_INTR_HANDLE_UIO_INTX:
+       case RTE_INTR_HANDLE_VFIO_LEGACY:
+               int_mode = ECORE_INT_MODE_INTA;
+               rte_intr_callback_register(&pci_dev->intr_handle,
+                                          qede_interrupt_handler_intx,
+                                          (void *)eth_dev);
+               break;
+       default:
+               int_mode = ECORE_INT_MODE_MSIX;
+               rte_intr_callback_register(&pci_dev->intr_handle,
+                                          qede_interrupt_handler,
+                                          (void *)eth_dev);
+       }
+
        if (rte_intr_enable(&pci_dev->intr_handle)) {
                DP_ERR(edev, "rte_intr_enable() failed\n");
                return -ENODEV;
@@ -3080,7 +2482,8 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
 
        /* Start the Slowpath-process */
        memset(&params, 0, sizeof(struct qed_slowpath_params));
-       params.int_mode = ECORE_INT_MODE_MSIX;
+
+       params.int_mode = int_mode;
        params.drv_major = QEDE_PMD_VERSION_MAJOR;
        params.drv_minor = QEDE_PMD_VERSION_MINOR;
        params.drv_rev = QEDE_PMD_VERSION_REVISION;
@@ -3093,7 +2496,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
         * interrupt vector but we need one for each engine.
         */
        if (ECORE_IS_CMT(edev) && IS_PF(edev)) {
-               rc = rte_eal_alarm_set(timer_period * US_PER_S,
+               rc = rte_eal_alarm_set(QEDE_SP_TIMER_PERIOD,
                                       qede_poll_sp_sb_cb,
                                       (void *)eth_dev);
                if (rc != 0) {
@@ -3135,7 +2538,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
 
        /* Allocate memory for storing MAC addr */
        eth_dev->data->mac_addrs = rte_zmalloc(edev->name,
-                                       (ETHER_ADDR_LEN *
+                                       (RTE_ETHER_ADDR_LEN *
                                        adapter->dev_info.num_mac_filters),
                                        RTE_CACHE_LINE_SIZE);
 
@@ -3149,10 +2552,10 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
        }
 
        if (!is_vf) {
-               ether_addr_copy((struct ether_addr *)edev->hwfns[0].
+               rte_ether_addr_copy((struct rte_ether_addr *)edev->hwfns[0].
                                hw_info.hw_mac_addr,
                                &eth_dev->data->mac_addrs[0]);
-               ether_addr_copy(&eth_dev->data->mac_addrs[0],
+               rte_ether_addr_copy(&eth_dev->data->mac_addrs[0],
                                &adapter->primary_mac);
        } else {
                ecore_vf_read_bulletin(ECORE_LEADING_HWFN(edev),
@@ -3163,12 +2566,14 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
                                                ECORE_LEADING_HWFN(edev),
                                                vf_mac,
                                                &is_mac_forced);
-                       if (is_mac_exist && is_mac_forced) {
+                       if (is_mac_exist) {
                                DP_INFO(edev, "VF macaddr received from PF\n");
-                               ether_addr_copy((struct ether_addr *)&vf_mac,
-                                               &eth_dev->data->mac_addrs[0]);
-                               ether_addr_copy(&eth_dev->data->mac_addrs[0],
-                                               &adapter->primary_mac);
+                               rte_ether_addr_copy(
+                                       (struct rte_ether_addr *)&vf_mac,
+                                       &eth_dev->data->mac_addrs[0]);
+                               rte_ether_addr_copy(
+                                       &eth_dev->data->mac_addrs[0],
+                                       &adapter->primary_mac);
                        } else {
                                DP_ERR(edev, "No VF macaddr assigned\n");
                        }
@@ -3187,11 +2592,11 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
 
        adapter->num_tx_queues = 0;
        adapter->num_rx_queues = 0;
-       SLIST_INIT(&adapter->fdir_info.fdir_list_head);
+       SLIST_INIT(&adapter->arfs_info.arfs_list_head);
        SLIST_INIT(&adapter->vlan_list_head);
        SLIST_INIT(&adapter->uc_list_head);
        SLIST_INIT(&adapter->mc_list_head);
-       adapter->mtu = ETHER_MTU;
+       adapter->mtu = RTE_ETHER_MTU;
        adapter->vport_started = false;
 
        /* VF tunnel offloads is enabled by default in PF driver */
@@ -3241,12 +2646,10 @@ static int qede_eth_dev_init(struct rte_eth_dev *eth_dev)
 
 static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev)
 {
-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
        struct qede_dev *qdev = eth_dev->data->dev_private;
        struct ecore_dev *edev = &qdev->edev;
 
        PMD_INIT_FUNC_TRACE(edev);
-#endif
 
        /* only uninitialize in the primary process */
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
@@ -3259,11 +2662,6 @@ static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev)
        eth_dev->rx_pkt_burst = NULL;
        eth_dev->tx_pkt_burst = NULL;
 
-       if (eth_dev->data->mac_addrs)
-               rte_free(eth_dev->data->mac_addrs);
-
-       eth_dev->data->mac_addrs = NULL;
-
        return 0;
 }
 
@@ -3340,7 +2738,8 @@ static int qedevf_eth_dev_pci_remove(struct rte_pci_device *pci_dev)
 
 static struct rte_pci_driver rte_qedevf_pmd = {
        .id_table = pci_id_qedevf_map,
-       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
+       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |
+                    RTE_PCI_DRV_IOVA_AS_VA,
        .probe = qedevf_eth_dev_pci_probe,
        .remove = qedevf_eth_dev_pci_remove,
 };
@@ -3359,7 +2758,8 @@ static int qede_eth_dev_pci_remove(struct rte_pci_device *pci_dev)
 
 static struct rte_pci_driver rte_qede_pmd = {
        .id_table = pci_id_qede_map,
-       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
+       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |
+                    RTE_PCI_DRV_IOVA_AS_VA,
        .probe = qede_eth_dev_pci_probe,
        .remove = qede_eth_dev_pci_remove,
 };
@@ -3371,9 +2771,7 @@ RTE_PMD_REGISTER_PCI(net_qede_vf, rte_qedevf_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_qede_vf, pci_id_qedevf_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_qede_vf, "* igb_uio | vfio-pci");
 
-RTE_INIT(qede_init_log);
-static void
-qede_init_log(void)
+RTE_INIT(qede_init_log)
 {
        qede_logtype_init = rte_log_register("pmd.net.qede.init");
        if (qede_logtype_init >= 0)