net: add rte prefix to ether structures
[dpdk.git] / drivers / net / sfc / sfc_ethdev.c
index 034229f..fadcdb5 100644 (file)
@@ -14,6 +14,7 @@
 #include <rte_bus_pci.h>
 #include <rte_errno.h>
 #include <rte_string_fns.h>
+#include <rte_ether.h>
 
 #include "efx.h"
 
@@ -36,7 +37,7 @@ static struct sfc_dp_list sfc_dp_head =
 static int
 sfc_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        efx_nic_fw_info_t enfi;
        int ret;
        int rc;
@@ -86,27 +87,30 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
        const struct sfc_adapter_priv *sap = sfc_adapter_priv_by_eth_dev(dev);
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_rss *rss = &sas->rss;
        uint64_t txq_offloads_def = 0;
 
        sfc_log_init(sa, "entry");
 
+       dev_info->min_mtu = ETHER_MIN_MTU;
+       dev_info->max_mtu = EFX_MAC_SDU_MAX;
+
        dev_info->max_rx_pktlen = EFX_MAC_PDU_MAX;
 
        /* Autonegotiation may be disabled */
        dev_info->speed_capa = ETH_LINK_SPEED_FIXED;
-       if (sa->port.phy_adv_cap_mask & EFX_PHY_CAP_1000FDX)
+       if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_1000FDX))
                dev_info->speed_capa |= ETH_LINK_SPEED_1G;
-       if (sa->port.phy_adv_cap_mask & EFX_PHY_CAP_10000FDX)
+       if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_10000FDX))
                dev_info->speed_capa |= ETH_LINK_SPEED_10G;
-       if (sa->port.phy_adv_cap_mask & EFX_PHY_CAP_25000FDX)
+       if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_25000FDX))
                dev_info->speed_capa |= ETH_LINK_SPEED_25G;
-       if (sa->port.phy_adv_cap_mask & EFX_PHY_CAP_40000FDX)
+       if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_40000FDX))
                dev_info->speed_capa |= ETH_LINK_SPEED_40G;
-       if (sa->port.phy_adv_cap_mask & EFX_PHY_CAP_50000FDX)
+       if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_50000FDX))
                dev_info->speed_capa |= ETH_LINK_SPEED_50G;
-       if (sa->port.phy_adv_cap_mask & EFX_PHY_CAP_100000FDX)
+       if (sa->port.phy_adv_cap_mask & (1u << EFX_PHY_CAP_100000FDX))
                dev_info->speed_capa |= ETH_LINK_SPEED_100G;
 
        dev_info->max_rx_queues = sa->rxq_max;
@@ -153,21 +157,21 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        }
 
        /* Initialize to hardware limits */
-       dev_info->rx_desc_lim.nb_max = EFX_RXQ_MAXNDESCS;
-       dev_info->rx_desc_lim.nb_min = EFX_RXQ_MINNDESCS;
+       dev_info->rx_desc_lim.nb_max = sa->rxq_max_entries;
+       dev_info->rx_desc_lim.nb_min = sa->rxq_min_entries;
        /* The RXQ hardware requires that the descriptor count is a power
         * of 2, but rx_desc_lim cannot properly describe that constraint.
         */
-       dev_info->rx_desc_lim.nb_align = EFX_RXQ_MINNDESCS;
+       dev_info->rx_desc_lim.nb_align = sa->rxq_min_entries;
 
        /* Initialize to hardware limits */
        dev_info->tx_desc_lim.nb_max = sa->txq_max_entries;
-       dev_info->tx_desc_lim.nb_min = EFX_TXQ_MINNDESCS;
+       dev_info->tx_desc_lim.nb_min = sa->txq_min_entries;
        /*
         * The TXQ hardware requires that the descriptor count is a power
         * of 2, but tx_desc_lim cannot properly describe that constraint
         */
-       dev_info->tx_desc_lim.nb_align = EFX_TXQ_MINNDESCS;
+       dev_info->tx_desc_lim.nb_align = sa->txq_min_entries;
 
        if (sap->dp_rx->get_dev_info != NULL)
                sap->dp_rx->get_dev_info(dev_info);
@@ -182,18 +186,15 @@ static const uint32_t *
 sfc_dev_supported_ptypes_get(struct rte_eth_dev *dev)
 {
        const struct sfc_adapter_priv *sap = sfc_adapter_priv_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
-       const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
-       uint32_t tunnel_encaps = encp->enc_tunnel_encapsulations_supported;
 
-       return sap->dp_rx->supported_ptypes_get(tunnel_encaps);
+       return sap->dp_rx->supported_ptypes_get(sap->shared->tunnel_encaps);
 }
 
 static int
 sfc_dev_configure(struct rte_eth_dev *dev)
 {
        struct rte_eth_dev_data *dev_data = dev->data;
-       struct sfc_adapter *sa = dev_data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "entry n_rxq=%u n_txq=%u",
@@ -222,7 +223,7 @@ sfc_dev_configure(struct rte_eth_dev *dev)
 static int
 sfc_dev_start(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "entry");
@@ -239,7 +240,7 @@ sfc_dev_start(struct rte_eth_dev *dev)
 static int
 sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct rte_eth_link current_link;
        int ret;
 
@@ -270,7 +271,7 @@ sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 static void
 sfc_dev_stop(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
 
        sfc_log_init(sa, "entry");
 
@@ -284,7 +285,7 @@ sfc_dev_stop(struct rte_eth_dev *dev)
 static int
 sfc_dev_set_link_up(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "entry");
@@ -300,7 +301,7 @@ sfc_dev_set_link_up(struct rte_eth_dev *dev)
 static int
 sfc_dev_set_link_down(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
 
        sfc_log_init(sa, "entry");
 
@@ -314,7 +315,7 @@ sfc_dev_set_link_down(struct rte_eth_dev *dev)
 static void
 sfc_dev_close(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
 
        sfc_log_init(sa, "entry");
 
@@ -345,7 +346,7 @@ sfc_dev_filter_set(struct rte_eth_dev *dev, enum sfc_dev_filter_mode mode,
 {
        struct sfc_port *port;
        boolean_t *toggle;
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        boolean_t allmulti = (mode == SFC_DEV_FILTER_MODE_ALLMULTI);
        const char *desc = (allmulti) ? "all-multi" : "promiscuous";
 
@@ -357,7 +358,7 @@ sfc_dev_filter_set(struct rte_eth_dev *dev, enum sfc_dev_filter_mode mode,
        if (*toggle != enabled) {
                *toggle = enabled;
 
-               if (port->isolated) {
+               if (sfc_sa2shared(sa)->isolated) {
                        sfc_warn(sa, "isolated mode is active on the port");
                        sfc_warn(sa, "the change is to be applied on the next "
                                     "start provided that isolated mode is "
@@ -404,7 +405,7 @@ sfc_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
                   struct rte_mempool *mb_pool)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "RxQ=%u nb_rx_desc=%u socket_id=%u",
@@ -459,7 +460,7 @@ sfc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
                   const struct rte_eth_txconf *tx_conf)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "TxQ = %u, nb_tx_desc = %u, socket_id = %u",
@@ -534,7 +535,7 @@ sfc_update_diff_stat(uint64_t *stat, uint64_t newval)
 static int
 sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        uint64_t *mac_stats;
        int ret;
@@ -611,7 +612,7 @@ unlock:
 static void
 sfc_stats_reset(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        int rc;
 
@@ -633,7 +634,7 @@ static int
 sfc_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
               unsigned int xstats_count)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        uint64_t *mac_stats;
        int rc;
@@ -672,7 +673,7 @@ sfc_xstats_get_names(struct rte_eth_dev *dev,
                     struct rte_eth_xstat_name *xstats_names,
                     unsigned int xstats_count)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        unsigned int i;
        unsigned int nstats = 0;
@@ -694,7 +695,7 @@ static int
 sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
                     uint64_t *values, unsigned int n)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        uint64_t *mac_stats;
        unsigned int nb_supported = 0;
@@ -741,7 +742,7 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,
                           struct rte_eth_xstat_name *xstats_names,
                           const uint64_t *ids, unsigned int size)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        unsigned int nb_supported = 0;
        unsigned int nb_written = 0;
@@ -771,7 +772,7 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev,
 static int
 sfc_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        unsigned int wanted_fc, link_fc;
 
        memset(fc_conf, 0, sizeof(*fc_conf));
@@ -811,7 +812,7 @@ sfc_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 static int
 sfc_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        unsigned int fcntl;
        int rc;
@@ -864,10 +865,38 @@ fail_inval:
        return -rc;
 }
 
+static int
+sfc_check_scatter_on_all_rx_queues(struct sfc_adapter *sa, size_t pdu)
+{
+       struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
+       const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
+       boolean_t scatter_enabled;
+       const char *error;
+       unsigned int i;
+
+       for (i = 0; i < sas->rxq_count; i++) {
+               if ((sas->rxq_info[i].state & SFC_RXQ_INITIALIZED) == 0)
+                       continue;
+
+               scatter_enabled = (sas->rxq_info[i].type_flags &
+                                  EFX_RXQ_FLAG_SCATTER);
+
+               if (!sfc_rx_check_scatter(pdu, sa->rxq_ctrl[i].buf_size,
+                                         encp->enc_rx_prefix_size,
+                                         scatter_enabled, &error)) {
+                       sfc_err(sa, "MTU check for RxQ %u failed: %s", i,
+                               error);
+                       return EINVAL;
+               }
+       }
+
+       return 0;
+}
+
 static int
 sfc_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        size_t pdu = EFX_MAC_PDU(mtu);
        size_t old_pdu;
        int rc;
@@ -890,6 +919,10 @@ sfc_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
 
        sfc_adapter_lock(sa);
 
+       rc = sfc_check_scatter_on_all_rx_queues(sa, pdu);
+       if (rc != 0)
+               goto fail_check_scatter;
+
        if (pdu != sa->port.pdu) {
                if (sa->state == SFC_ADAPTER_STARTED) {
                        sfc_stop(sa);
@@ -926,6 +959,8 @@ fail_start:
                sfc_err(sa, "cannot start with neither new (%u) nor old (%u) "
                        "PDU max size - port is stopped",
                        (unsigned int)pdu, (unsigned int)old_pdu);
+
+fail_check_scatter:
        sfc_adapter_unlock(sa);
 
 fail_inval:
@@ -934,12 +969,12 @@ fail_inval:
        return -rc;
 }
 static int
-sfc_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
+sfc_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        const efx_nic_cfg_t *encp = efx_nic_cfg_get(sa->nic);
        struct sfc_port *port = &sa->port;
-       struct ether_addr *old_addr = &dev->data->mac_addrs[0];
+       struct rte_ether_addr *old_addr = &dev->data->mac_addrs[0];
        int rc = 0;
 
        sfc_adapter_lock(sa);
@@ -957,7 +992,7 @@ sfc_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
         * on the next port start if the user prevents
         * isolated mode from being enabled.
         */
-       if (port->isolated) {
+       if (sfc_sa2shared(sa)->isolated) {
                sfc_warn(sa, "isolated mode is active on the port");
                sfc_warn(sa, "will not set MAC address");
                goto unlock;
@@ -1018,16 +1053,16 @@ unlock:
 
 
 static int
-sfc_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *mc_addr_set,
-                    uint32_t nb_mc_addr)
+sfc_set_mc_addr_list(struct rte_eth_dev *dev,
+               struct rte_ether_addr *mc_addr_set, uint32_t nb_mc_addr)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_port *port = &sa->port;
        uint8_t *mc_addrs = port->mcast_addrs;
        int rc;
        unsigned int i;
 
-       if (port->isolated) {
+       if (sfc_sa2shared(sa)->isolated) {
                sfc_err(sa, "isolated mode is active on the port");
                sfc_err(sa, "will not set multicast address list");
                return -ENOTSUP;
@@ -1071,11 +1106,8 @@ sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,
                      struct rte_eth_rxq_info *qinfo)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
        struct sfc_rxq_info *rxq_info;
 
-       sfc_adapter_lock(sa);
-
        SFC_ASSERT(rx_queue_id < sas->rxq_count);
 
        rxq_info = &sas->rxq_info[rx_queue_id];
@@ -1090,8 +1122,6 @@ sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,
                qinfo->scattered_rx = 1;
        }
        qinfo->nb_desc = rxq_info->entries;
-
-       sfc_adapter_unlock(sa);
 }
 
 /*
@@ -1103,11 +1133,8 @@ sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,
                      struct rte_eth_txq_info *qinfo)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
        struct sfc_txq_info *txq_info;
 
-       sfc_adapter_lock(sa);
-
        SFC_ASSERT(tx_queue_id < sas->txq_count);
 
        txq_info = &sas->txq_info[tx_queue_id];
@@ -1118,8 +1145,6 @@ sfc_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t tx_queue_id,
        qinfo->conf.tx_free_thresh = txq_info->free_thresh;
        qinfo->conf.tx_deferred_start = txq_info->deferred_start;
        qinfo->nb_desc = txq_info->entries;
-
-       sfc_adapter_unlock(sa);
 }
 
 /*
@@ -1191,7 +1216,7 @@ static int
 sfc_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "RxQ=%u", rx_queue_id);
@@ -1227,7 +1252,7 @@ static int
 sfc_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
 
        sfc_log_init(sa, "RxQ=%u", rx_queue_id);
 
@@ -1245,7 +1270,7 @@ static int
 sfc_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc;
 
        sfc_log_init(sa, "TxQ = %u", tx_queue_id);
@@ -1281,7 +1306,7 @@ static int
 sfc_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
 
        sfc_log_init(sa, "TxQ = %u", tx_queue_id);
 
@@ -1318,7 +1343,7 @@ sfc_dev_udp_tunnel_op(struct rte_eth_dev *dev,
                      struct rte_eth_udp_tunnel *tunnel_udp,
                      enum sfc_udp_tunnel_op_e op)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        efx_tunnel_protocol_t tunnel_proto;
        int rc;
 
@@ -1421,14 +1446,11 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
                          struct rte_eth_rss_conf *rss_conf)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
        struct sfc_rss *rss = &sas->rss;
 
        if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE)
                return -ENOTSUP;
 
-       sfc_adapter_lock(sa);
-
        /*
         * Mapping of hash configuration between RTE and EFX is not one-to-one,
         * hence, conversion is done here to derive a correct set of ETH_RSS
@@ -1440,8 +1462,6 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
        if (rss_conf->rss_key != NULL)
                rte_memcpy(rss_conf->rss_key, rss->key, EFX_RSS_KEY_SIZE);
 
-       sfc_adapter_unlock(sa);
-
        return 0;
 }
 
@@ -1449,13 +1469,12 @@ static int
 sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
                        struct rte_eth_rss_conf *rss_conf)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_rss *rss = &sfc_sa2shared(sa)->rss;
-       struct sfc_port *port = &sa->port;
        unsigned int efx_hash_types;
        int rc = 0;
 
-       if (port->isolated)
+       if (sfc_sa2shared(sa)->isolated)
                return -ENOTSUP;
 
        if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) {
@@ -1527,12 +1546,10 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,
                       uint16_t reta_size)
 {
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
-       struct sfc_adapter *sa = dev->data->dev_private;
        struct sfc_rss *rss = &sas->rss;
-       struct sfc_port *port = &sa->port;
        int entry;
 
-       if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || port->isolated)
+       if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || sas->isolated)
                return -ENOTSUP;
 
        if (rss->channels == 0)
@@ -1541,8 +1558,6 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,
        if (reta_size != EFX_RSS_TBL_SIZE)
                return -EINVAL;
 
-       sfc_adapter_lock(sa);
-
        for (entry = 0; entry < reta_size; entry++) {
                int grp = entry / RTE_RETA_GROUP_SIZE;
                int grp_idx = entry % RTE_RETA_GROUP_SIZE;
@@ -1551,8 +1566,6 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,
                        reta_conf[grp].reta[grp_idx] = rss->tbl[entry];
        }
 
-       sfc_adapter_unlock(sa);
-
        return 0;
 }
 
@@ -1561,15 +1574,14 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev,
                        struct rte_eth_rss_reta_entry64 *reta_conf,
                        uint16_t reta_size)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_rss *rss = &sfc_sa2shared(sa)->rss;
-       struct sfc_port *port = &sa->port;
        unsigned int *rss_tbl_new;
        uint16_t entry;
        int rc = 0;
 
 
-       if (port->isolated)
+       if (sfc_sa2shared(sa)->isolated)
                return -ENOTSUP;
 
        if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) {
@@ -1635,7 +1647,7 @@ sfc_dev_filter_ctrl(struct rte_eth_dev *dev, enum rte_filter_type filter_type,
                    enum rte_filter_op filter_op,
                    void *arg)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        int rc = ENOTSUP;
 
        sfc_log_init(sa, "entry");
@@ -1778,7 +1790,7 @@ sfc_strdup(const char *str)
 static int
 sfc_eth_dev_set_ops(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        const struct sfc_dp_rx *dp_rx;
        const struct sfc_dp_tx *dp_tx;
@@ -1880,6 +1892,7 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)
        sa->priv.dp_tx = dp_tx;
 
        dev->rx_pkt_burst = dp_rx->pkt_burst;
+       dev->tx_pkt_prepare = dp_tx->pkt_prepare;
        dev->tx_pkt_burst = dp_tx->pkt_burst;
 
        dev->dev_ops = &sfc_eth_dev_ops;
@@ -1903,10 +1916,11 @@ fail_kvarg_rx_datapath:
 static void
 sfc_eth_dev_clear_ops(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
+       struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);
        struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
 
        dev->dev_ops = NULL;
+       dev->tx_pkt_prepare = NULL;
        dev->rx_pkt_burst = NULL;
        dev->tx_pkt_burst = NULL;
 
@@ -1920,6 +1934,7 @@ sfc_eth_dev_clear_ops(struct rte_eth_dev *dev)
 }
 
 static const struct eth_dev_ops sfc_eth_dev_secondary_ops = {
+       .dev_supported_ptypes_get       = sfc_dev_supported_ptypes_get,
        .rx_queue_count                 = sfc_rx_queue_count,
        .rx_descriptor_done             = sfc_rx_descriptor_done,
        .rx_descriptor_status           = sfc_rx_descriptor_status,
@@ -1986,6 +2001,7 @@ sfc_eth_dev_secondary_init(struct rte_eth_dev *dev, uint32_t logtype_main)
 
        dev->process_private = sap;
        dev->rx_pkt_burst = dp_rx->pkt_burst;
+       dev->tx_pkt_prepare = dp_tx->pkt_prepare;
        dev->tx_pkt_burst = dp_tx->pkt_burst;
        dev->dev_ops = &sfc_eth_dev_secondary_ops;
 
@@ -2007,6 +2023,7 @@ sfc_eth_dev_secondary_clear_ops(struct rte_eth_dev *dev)
        free(dev->process_private);
        dev->process_private = NULL;
        dev->dev_ops = NULL;
+       dev->tx_pkt_prepare = NULL;
        dev->tx_pkt_burst = NULL;
        dev->rx_pkt_burst = NULL;
 }
@@ -2030,13 +2047,13 @@ sfc_register_dp(void)
 static int
 sfc_eth_dev_init(struct rte_eth_dev *dev)
 {
-       struct sfc_adapter *sa = dev->data->dev_private;
-       struct sfc_adapter_shared *sas;
+       struct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        uint32_t logtype_main;
+       struct sfc_adapter *sa;
        int rc;
        const efx_nic_cfg_t *encp;
-       const struct ether_addr *from;
+       const struct rte_ether_addr *from;
 
        sfc_register_dp();
 
@@ -2044,23 +2061,27 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
                                            SFC_LOGTYPE_MAIN_STR,
                                            RTE_LOG_NOTICE);
 
-       sa->priv.shared = &sa->_shared;
-       sas = sa->priv.shared;
-
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
                return -sfc_eth_dev_secondary_init(dev, logtype_main);
 
+       /* Required for logging */
+       sas->pci_addr = pci_dev->addr;
+       sas->port_id = dev->data->port_id;
+
        /*
-        * sfc_adapter is a mixture of shared and process private data.
-        * During transition period use it in both kinds. When the
-        * driver becomes ready to separate it, sfc_adapter will become
-        * primary process private only.
+        * Allocate process private data from heap, since it should not
+        * be located in shared memory allocated using rte_malloc() API.
         */
+       sa = calloc(1, sizeof(*sa));
+       if (sa == NULL) {
+               rc = ENOMEM;
+               goto fail_alloc_sa;
+       }
+
        dev->process_private = sa;
 
        /* Required for logging */
-       sas->pci_addr = pci_dev->addr;
-       sas->port_id = dev->data->port_id;
+       sa->priv.shared = sas;
        sa->priv.logtype_main = logtype_main;
 
        sa->eth_dev = dev;
@@ -2104,7 +2125,7 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
         * The arguments are really reverse order in comparison to
         * Linux kernel. Copy from NIC config to Ethernet device data.
         */
-       from = (const struct ether_addr *)(encp->enc_mac_addr);
+       from = (const struct rte_ether_addr *)(encp->enc_mac_addr);
        ether_addr_copy(from, &dev->data->mac_addrs[0]);
 
        sfc_adapter_unlock(sa);
@@ -2130,6 +2151,9 @@ fail_mac_addrs:
 fail_kvargs_parse:
        sfc_log_init(sa, "failed %d", rc);
        dev->process_private = NULL;
+       free(sa);
+
+fail_alloc_sa:
        SFC_ASSERT(rc > 0);
        return -rc;
 }
@@ -2144,7 +2168,7 @@ sfc_eth_dev_uninit(struct rte_eth_dev *dev)
                return 0;
        }
 
-       sa = dev->data->dev_private;
+       sa = sfc_adapter_by_eth_dev(dev);
        sfc_log_init(sa, "entry");
 
        sfc_adapter_lock(sa);
@@ -2163,6 +2187,10 @@ sfc_eth_dev_uninit(struct rte_eth_dev *dev)
 
        /* Required for logging, so cleanup last */
        sa->eth_dev = NULL;
+
+       dev->process_private = NULL;
+       free(sa);
+
        return 0;
 }
 
@@ -2182,7 +2210,7 @@ static int sfc_eth_dev_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
        struct rte_pci_device *pci_dev)
 {
        return rte_eth_dev_pci_generic_probe(pci_dev,
-               sizeof(struct sfc_adapter), sfc_eth_dev_init);
+               sizeof(struct sfc_adapter_shared), sfc_eth_dev_init);
 }
 
 static int sfc_eth_dev_pci_remove(struct rte_pci_device *pci_dev)