net/sfc: avoid failure on port start if Rx mode is rejected
[dpdk.git] / drivers / net / sfc / sfc_rx.c
index 802beb2..0a9fa42 100644 (file)
@@ -185,6 +185,28 @@ sfc_rx_desc_flags_to_packet_type(const unsigned int desc_flags)
                ((desc_flags & EFX_PKT_UDP) ? RTE_PTYPE_L4_UDP : 0);
 }
 
+static void
+sfc_rx_set_rss_hash(struct sfc_rxq *rxq, unsigned int flags, struct rte_mbuf *m)
+{
+#if EFSYS_OPT_RX_SCALE
+       uint8_t *mbuf_data;
+
+
+       if ((rxq->flags & SFC_RXQ_RSS_HASH) == 0)
+               return;
+
+       mbuf_data = rte_pktmbuf_mtod(m, uint8_t *);
+
+       if (flags & (EFX_PKT_IPV4 | EFX_PKT_IPV6)) {
+               m->hash.rss = efx_pseudo_hdr_hash_get(rxq->common,
+                                                     EFX_RX_HASHALG_TOEPLITZ,
+                                                     mbuf_data);
+
+               m->ol_flags |= PKT_RX_RSS_HASH;
+       }
+#endif
+}
+
 uint16_t
 sfc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 {
@@ -193,6 +215,7 @@ sfc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
        unsigned int prefix_size = rxq->prefix_size;
        unsigned int done_pkts = 0;
        boolean_t discard_next = B_FALSE;
+       struct rte_mbuf *scatter_pkt = NULL;
 
        if (unlikely((rxq->state & SFC_RXQ_RUNNING) == 0))
                return 0;
@@ -218,9 +241,6 @@ sfc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                if (desc_flags & (EFX_ADDR_MISMATCH | EFX_DISCARD))
                        goto discard;
 
-               if (desc_flags & EFX_PKT_CONT)
-                       goto discard;
-
                if (desc_flags & EFX_PKT_PREFIX_LEN) {
                        uint16_t tmp_size;
                        int rc __rte_unused;
@@ -233,13 +253,43 @@ sfc_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                        seg_len = rxd->size - prefix_size;
                }
 
-               m->data_off += prefix_size;
                rte_pktmbuf_data_len(m) = seg_len;
                rte_pktmbuf_pkt_len(m) = seg_len;
 
+               if (scatter_pkt != NULL) {
+                       if (rte_pktmbuf_chain(scatter_pkt, m) != 0) {
+                               rte_mempool_put(rxq->refill_mb_pool,
+                                               scatter_pkt);
+                               goto discard;
+                       }
+                       /* The packet to deliver */
+                       m = scatter_pkt;
+               }
+
+               if (desc_flags & EFX_PKT_CONT) {
+                       /* The packet is scattered, more fragments to come */
+                       scatter_pkt = m;
+                       /* Futher fragments have no prefix */
+                       prefix_size = 0;
+                       continue;
+               }
+
+               /* Scattered packet is done */
+               scatter_pkt = NULL;
+               /* The first fragment of the packet has prefix */
+               prefix_size = rxq->prefix_size;
+
                m->ol_flags = sfc_rx_desc_flags_to_offload_flags(desc_flags);
                m->packet_type = sfc_rx_desc_flags_to_packet_type(desc_flags);
 
+               /*
+                * Extract RSS hash from the packet prefix and
+                * set the corresponding field (if needed and possible)
+                */
+               sfc_rx_set_rss_hash(rxq, desc_flags, m);
+
+               m->data_off += prefix_size;
+
                *rx_pkts++ = m;
                done_pkts++;
                continue;
@@ -250,6 +300,9 @@ discard:
                rxd->mbuf = NULL;
        }
 
+       /* pending is only moved when entire packet is received */
+       SFC_ASSERT(scatter_pkt == NULL);
+
        rxq->completed = completed;
 
        sfc_rx_qrefill(rxq);
@@ -348,6 +401,56 @@ sfc_rx_qflush(struct sfc_adapter *sa, unsigned int sw_index)
        sfc_rx_qpurge(rxq);
 }
 
+static int
+sfc_rx_default_rxq_set_filter(struct sfc_adapter *sa, struct sfc_rxq *rxq)
+{
+       boolean_t rss = (sa->rss_channels > 1) ? B_TRUE : B_FALSE;
+       struct sfc_port *port = &sa->port;
+       int rc;
+
+       /*
+        * If promiscuous or all-multicast mode has been requested, setting
+        * filter for the default Rx queue might fail, in particular, while
+        * running over PCI function which is not a member of corresponding
+        * privilege groups; if this occurs, few iterations will be made to
+        * repeat this step without promiscuous and all-multicast flags set
+        */
+retry:
+       rc = efx_mac_filter_default_rxq_set(sa->nic, rxq->common, rss);
+       if (rc == 0)
+               return 0;
+       else if (rc != EOPNOTSUPP)
+               return rc;
+
+       if (port->promisc) {
+               sfc_warn(sa, "promiscuous mode has been requested, "
+                            "but the HW rejects it");
+               sfc_warn(sa, "promiscuous mode will be disabled");
+
+               port->promisc = B_FALSE;
+               rc = sfc_set_rx_mode(sa);
+               if (rc != 0)
+                       return rc;
+
+               goto retry;
+       }
+
+       if (port->allmulti) {
+               sfc_warn(sa, "all-multicast mode has been requested, "
+                            "but the HW rejects it");
+               sfc_warn(sa, "all-multicast mode will be disabled");
+
+               port->allmulti = B_FALSE;
+               rc = sfc_set_rx_mode(sa);
+               if (rc != 0)
+                       return rc;
+
+               goto retry;
+       }
+
+       return rc;
+}
+
 int
 sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)
 {
@@ -386,8 +489,7 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)
        sfc_rx_qrefill(rxq);
 
        if (sw_index == 0) {
-               rc = efx_mac_filter_default_rxq_set(sa->nic, rxq->common,
-                                                   B_FALSE);
+               rc = sfc_rx_default_rxq_set_filter(sa, rxq);
                if (rc != 0)
                        goto fail_mac_filter_default_rxq_set;
        }
@@ -420,6 +522,9 @@ sfc_rx_qstop(struct sfc_adapter *sa, unsigned int sw_index)
 
        rxq_info = &sa->rxq_info[sw_index];
        rxq = rxq_info->rxq;
+
+       if (rxq->state == SFC_RXQ_INITIALIZED)
+               return;
        SFC_ASSERT(rxq->state & SFC_RXQ_STARTED);
 
        /* It seems to be used by DPDK for debug purposes only ('rte_ether') */
@@ -467,11 +572,6 @@ sfc_rx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_rx_desc,
                rc = EINVAL;
        }
 
-       if (rx_conf->rx_deferred_start != 0) {
-               sfc_err(sa, "RxQ deferred start is not supported");
-               rc = EINVAL;
-       }
-
        return rc;
 }
 
@@ -618,7 +718,9 @@ sfc_rx_qinit(struct sfc_adapter *sa, unsigned int sw_index,
 
        SFC_ASSERT(nb_rx_desc <= rxq_info->max_entries);
        rxq_info->entries = nb_rx_desc;
-       rxq_info->type = EFX_RXQ_TYPE_DEFAULT;
+       rxq_info->type =
+               sa->eth_dev->data->dev_conf.rxmode.enable_scatter ?
+               EFX_RXQ_TYPE_SCATTER : EFX_RXQ_TYPE_DEFAULT;
 
        evq_index = sfc_evq_index_by_rxq_sw_index(sa, sw_index);
 
@@ -659,9 +761,15 @@ sfc_rx_qinit(struct sfc_adapter *sa, unsigned int sw_index,
        rxq->batch_max = encp->enc_rx_batch_max;
        rxq->prefix_size = encp->enc_rx_prefix_size;
 
+#if EFSYS_OPT_RX_SCALE
+       if (sa->hash_support == EFX_RX_HASH_AVAILABLE)
+               rxq->flags |= SFC_RXQ_RSS_HASH;
+#endif
+
        rxq->state = SFC_RXQ_INITIALIZED;
 
        rxq_info->rxq = rxq;
+       rxq_info->deferred_start = (rx_conf->rx_deferred_start != 0);
 
        return 0;
 
@@ -703,6 +811,78 @@ sfc_rx_qfini(struct sfc_adapter *sa, unsigned int sw_index)
        rte_free(rxq);
 }
 
+#if EFSYS_OPT_RX_SCALE
+efx_rx_hash_type_t
+sfc_rte_to_efx_hash_type(uint64_t rss_hf)
+{
+       efx_rx_hash_type_t efx_hash_types = 0;
+
+       if ((rss_hf & (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |
+                      ETH_RSS_NONFRAG_IPV4_OTHER)) != 0)
+               efx_hash_types |= EFX_RX_HASH_IPV4;
+
+       if ((rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) != 0)
+               efx_hash_types |= EFX_RX_HASH_TCPIPV4;
+
+       if ((rss_hf & (ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |
+                       ETH_RSS_NONFRAG_IPV6_OTHER | ETH_RSS_IPV6_EX)) != 0)
+               efx_hash_types |= EFX_RX_HASH_IPV6;
+
+       if ((rss_hf & (ETH_RSS_NONFRAG_IPV6_TCP | ETH_RSS_IPV6_TCP_EX)) != 0)
+               efx_hash_types |= EFX_RX_HASH_TCPIPV6;
+
+       return efx_hash_types;
+}
+
+uint64_t
+sfc_efx_to_rte_hash_type(efx_rx_hash_type_t efx_hash_types)
+{
+       uint64_t rss_hf = 0;
+
+       if ((efx_hash_types & EFX_RX_HASH_IPV4) != 0)
+               rss_hf |= (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |
+                          ETH_RSS_NONFRAG_IPV4_OTHER);
+
+       if ((efx_hash_types & EFX_RX_HASH_TCPIPV4) != 0)
+               rss_hf |= ETH_RSS_NONFRAG_IPV4_TCP;
+
+       if ((efx_hash_types & EFX_RX_HASH_IPV6) != 0)
+               rss_hf |= (ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |
+                          ETH_RSS_NONFRAG_IPV6_OTHER | ETH_RSS_IPV6_EX);
+
+       if ((efx_hash_types & EFX_RX_HASH_TCPIPV6) != 0)
+               rss_hf |= (ETH_RSS_NONFRAG_IPV6_TCP | ETH_RSS_IPV6_TCP_EX);
+
+       return rss_hf;
+}
+#endif
+
+static int
+sfc_rx_rss_config(struct sfc_adapter *sa)
+{
+       int rc = 0;
+
+#if EFSYS_OPT_RX_SCALE
+       if (sa->rss_channels > 1) {
+               rc = efx_rx_scale_mode_set(sa->nic, EFX_RX_HASHALG_TOEPLITZ,
+                                          sa->rss_hash_types, B_TRUE);
+               if (rc != 0)
+                       goto finish;
+
+               rc = efx_rx_scale_key_set(sa->nic, sa->rss_key,
+                                         sizeof(sa->rss_key));
+               if (rc != 0)
+                       goto finish;
+
+               rc = efx_rx_scale_tbl_set(sa->nic, sa->rss_tbl,
+                                         sizeof(sa->rss_tbl));
+       }
+
+finish:
+#endif
+       return rc;
+}
+
 int
 sfc_rx_start(struct sfc_adapter *sa)
 {
@@ -715,10 +895,17 @@ sfc_rx_start(struct sfc_adapter *sa)
        if (rc != 0)
                goto fail_rx_init;
 
+       rc = sfc_rx_rss_config(sa);
+       if (rc != 0)
+               goto fail_rss_config;
+
        for (sw_index = 0; sw_index < sa->rxq_count; ++sw_index) {
-               rc = sfc_rx_qstart(sa, sw_index);
-               if (rc != 0)
-                       goto fail_rx_qstart;
+               if ((!sa->rxq_info[sw_index].deferred_start ||
+                    sa->rxq_info[sw_index].deferred_started)) {
+                       rc = sfc_rx_qstart(sa, sw_index);
+                       if (rc != 0)
+                               goto fail_rx_qstart;
+               }
        }
 
        return 0;
@@ -727,6 +914,7 @@ fail_rx_qstart:
        while (sw_index-- > 0)
                sfc_rx_qstop(sa, sw_index);
 
+fail_rss_config:
        efx_rx_fini(sa->nic);
 
 fail_rx_init:
@@ -773,6 +961,14 @@ sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)
        case ETH_MQ_RX_NONE:
                /* No special checks are required */
                break;
+#if EFSYS_OPT_RX_SCALE
+       case ETH_MQ_RX_RSS:
+               if (sa->rss_support == EFX_RX_SCALE_UNAVAILABLE) {
+                       sfc_err(sa, "RSS is not available");
+                       rc = EINVAL;
+               }
+               break;
+#endif
        default:
                sfc_err(sa, "Rx multi-queue mode %u not supported",
                        rxmode->mq_mode);
@@ -806,11 +1002,6 @@ sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)
                rxmode->hw_strip_crc = 1;
        }
 
-       if (rxmode->enable_scatter) {
-               sfc_err(sa, "Scatter on Rx not supported");
-               rc = EINVAL;
-       }
-
        if (rxmode->enable_lro) {
                sfc_err(sa, "LRO not supported");
                rc = EINVAL;
@@ -853,6 +1044,16 @@ sfc_rx_init(struct sfc_adapter *sa)
                        goto fail_rx_qinit_info;
        }
 
+#if EFSYS_OPT_RX_SCALE
+       sa->rss_channels = (dev_conf->rxmode.mq_mode == ETH_MQ_RX_RSS) ?
+                          MIN(sa->rxq_count, EFX_MAXRSS) : 1;
+
+       if (sa->rss_channels > 1) {
+               for (sw_index = 0; sw_index < EFX_RSS_TBL_SIZE; ++sw_index)
+                       sa->rss_tbl[sw_index] = sw_index % sa->rss_channels;
+       }
+#endif
+
        return 0;
 
 fail_rx_qinit_info: