net/virtio: split Rx/Tx queue
[dpdk.git] / drivers / net / virtio / virtio_ethdev.c
index a833740..4cb27b6 100644 (file)
@@ -117,40 +117,61 @@ struct rte_virtio_xstats_name_off {
 };
 
 /* [rt]x_qX_ is prepended to the name string here */
-static const struct rte_virtio_xstats_name_off rte_virtio_q_stat_strings[] = {
-       {"good_packets",           offsetof(struct virtqueue, packets)},
-       {"good_bytes",             offsetof(struct virtqueue, bytes)},
-       {"errors",                 offsetof(struct virtqueue, errors)},
-       {"multicast_packets",      offsetof(struct virtqueue, multicast)},
-       {"broadcast_packets",      offsetof(struct virtqueue, broadcast)},
-       {"undersize_packets",      offsetof(struct virtqueue, size_bins[0])},
-       {"size_64_packets",        offsetof(struct virtqueue, size_bins[1])},
-       {"size_65_127_packets",    offsetof(struct virtqueue, size_bins[2])},
-       {"size_128_255_packets",   offsetof(struct virtqueue, size_bins[3])},
-       {"size_256_511_packets",   offsetof(struct virtqueue, size_bins[4])},
-       {"size_512_1023_packets",  offsetof(struct virtqueue, size_bins[5])},
-       {"size_1024_1517_packets", offsetof(struct virtqueue, size_bins[6])},
-       {"size_1518_max_packets",  offsetof(struct virtqueue, size_bins[7])},
+static const struct rte_virtio_xstats_name_off rte_virtio_rxq_stat_strings[] = {
+       {"good_packets",           offsetof(struct virtnet_rx, stats.packets)},
+       {"good_bytes",             offsetof(struct virtnet_rx, stats.bytes)},
+       {"errors",                 offsetof(struct virtnet_rx, stats.errors)},
+       {"multicast_packets",      offsetof(struct virtnet_rx, stats.multicast)},
+       {"broadcast_packets",      offsetof(struct virtnet_rx, stats.broadcast)},
+       {"undersize_packets",      offsetof(struct virtnet_rx, stats.size_bins[0])},
+       {"size_64_packets",        offsetof(struct virtnet_rx, stats.size_bins[1])},
+       {"size_65_127_packets",    offsetof(struct virtnet_rx, stats.size_bins[2])},
+       {"size_128_255_packets",   offsetof(struct virtnet_rx, stats.size_bins[3])},
+       {"size_256_511_packets",   offsetof(struct virtnet_rx, stats.size_bins[4])},
+       {"size_512_1023_packets",  offsetof(struct virtnet_rx, stats.size_bins[5])},
+       {"size_1024_1517_packets", offsetof(struct virtnet_rx, stats.size_bins[6])},
+       {"size_1518_max_packets",  offsetof(struct virtnet_rx, stats.size_bins[7])},
 };
 
-#define VIRTIO_NB_Q_XSTATS (sizeof(rte_virtio_q_stat_strings) / \
-                           sizeof(rte_virtio_q_stat_strings[0]))
+/* [rt]x_qX_ is prepended to the name string here */
+static const struct rte_virtio_xstats_name_off rte_virtio_txq_stat_strings[] = {
+       {"good_packets",           offsetof(struct virtnet_tx, stats.packets)},
+       {"good_bytes",             offsetof(struct virtnet_tx, stats.bytes)},
+       {"errors",                 offsetof(struct virtnet_tx, stats.errors)},
+       {"multicast_packets",      offsetof(struct virtnet_tx, stats.multicast)},
+       {"broadcast_packets",      offsetof(struct virtnet_tx, stats.broadcast)},
+       {"undersize_packets",      offsetof(struct virtnet_tx, stats.size_bins[0])},
+       {"size_64_packets",        offsetof(struct virtnet_tx, stats.size_bins[1])},
+       {"size_65_127_packets",    offsetof(struct virtnet_tx, stats.size_bins[2])},
+       {"size_128_255_packets",   offsetof(struct virtnet_tx, stats.size_bins[3])},
+       {"size_256_511_packets",   offsetof(struct virtnet_tx, stats.size_bins[4])},
+       {"size_512_1023_packets",  offsetof(struct virtnet_tx, stats.size_bins[5])},
+       {"size_1024_1517_packets", offsetof(struct virtnet_tx, stats.size_bins[6])},
+       {"size_1518_max_packets",  offsetof(struct virtnet_tx, stats.size_bins[7])},
+};
+
+#define VIRTIO_NB_RXQ_XSTATS (sizeof(rte_virtio_rxq_stat_strings) / \
+                           sizeof(rte_virtio_rxq_stat_strings[0]))
+#define VIRTIO_NB_TXQ_XSTATS (sizeof(rte_virtio_txq_stat_strings) / \
+                           sizeof(rte_virtio_txq_stat_strings[0]))
 
 static int
-virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
+virtio_send_command(struct virtnet_ctl *cvq, struct virtio_pmd_ctrl *ctrl,
                int *dlen, int pkt_num)
 {
        uint32_t head, i;
        int k, sum = 0;
        virtio_net_ctrl_ack status = ~0;
        struct virtio_pmd_ctrl result;
+       struct virtqueue *vq;
 
        ctrl->status = status;
 
-       if (!(vq && vq->hw->cvq)) {
+       if (!cvq && !cvq->vq) {
                PMD_INIT_LOG(ERR, "Control queue is not supported.");
                return -1;
        }
+       vq = cvq->vq;
        head = vq->vq_desc_head_idx;
 
        PMD_INIT_LOG(DEBUG, "vq->vq_desc_head_idx = %d, status = %d, "
@@ -160,7 +181,7 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
        if ((vq->vq_free_cnt < ((uint32_t)pkt_num + 2)) || (pkt_num < 1))
                return -1;
 
-       memcpy(vq->virtio_net_hdr_mz->addr, ctrl,
+       memcpy(cvq->virtio_net_hdr_mz->addr, ctrl,
                sizeof(struct virtio_pmd_ctrl));
 
        /*
@@ -170,14 +191,14 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
         * One RX packet for ACK.
         */
        vq->vq_ring.desc[head].flags = VRING_DESC_F_NEXT;
-       vq->vq_ring.desc[head].addr = vq->virtio_net_hdr_mz->phys_addr;
+       vq->vq_ring.desc[head].addr = cvq->virtio_net_hdr_mz->phys_addr;
        vq->vq_ring.desc[head].len = sizeof(struct virtio_net_ctrl_hdr);
        vq->vq_free_cnt--;
        i = vq->vq_ring.desc[head].next;
 
        for (k = 0; k < pkt_num; k++) {
                vq->vq_ring.desc[i].flags = VRING_DESC_F_NEXT;
-               vq->vq_ring.desc[i].addr = vq->virtio_net_hdr_mz->phys_addr
+               vq->vq_ring.desc[i].addr = cvq->virtio_net_hdr_mz->phys_addr
                        + sizeof(struct virtio_net_ctrl_hdr)
                        + sizeof(ctrl->status) + sizeof(uint8_t)*sum;
                vq->vq_ring.desc[i].len = dlen[k];
@@ -187,7 +208,7 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
        }
 
        vq->vq_ring.desc[i].flags = VRING_DESC_F_WRITE;
-       vq->vq_ring.desc[i].addr = vq->virtio_net_hdr_mz->phys_addr
+       vq->vq_ring.desc[i].addr = cvq->virtio_net_hdr_mz->phys_addr
                        + sizeof(struct virtio_net_ctrl_hdr);
        vq->vq_ring.desc[i].len = sizeof(ctrl->status);
        vq->vq_free_cnt--;
@@ -232,7 +253,7 @@ virtio_send_command(struct virtqueue *vq, struct virtio_pmd_ctrl *ctrl,
        PMD_INIT_LOG(DEBUG, "vq->vq_free_cnt=%d\nvq->vq_desc_head_idx=%d",
                        vq->vq_free_cnt, vq->vq_desc_head_idx);
 
-       memcpy(&result, vq->virtio_net_hdr_mz->addr,
+       memcpy(&result, cvq->virtio_net_hdr_mz->addr,
                        sizeof(struct virtio_pmd_ctrl));
 
        return result.status;
@@ -272,10 +293,6 @@ virtio_dev_queue_release(struct virtqueue *vq)
                if (vq->configured)
                        hw->vtpci_ops->del_queue(hw, vq);
 
-               rte_memzone_free(vq->mz);
-               if (vq->virtio_net_hdr_mz)
-                       rte_memzone_free(vq->virtio_net_hdr_mz);
-
                rte_free(vq->sw_ring);
                rte_free(vq);
        }
@@ -287,14 +304,21 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
                        uint16_t vtpci_queue_idx,
                        uint16_t nb_desc,
                        unsigned int socket_id,
-                       struct virtqueue **pvq)
+                       void **pvq)
 {
        char vq_name[VIRTQUEUE_MAX_NAME_SZ];
-       const struct rte_memzone *mz;
+       char vq_hdr_name[VIRTQUEUE_MAX_NAME_SZ];
+       const struct rte_memzone *mz = NULL, *hdr_mz = NULL;
        unsigned int vq_size, size;
        struct virtio_hw *hw = dev->data->dev_private;
-       struct virtqueue *vq = NULL;
+       struct virtnet_rx *rxvq;
+       struct virtnet_tx *txvq;
+       struct virtnet_ctl *cvq;
+       struct virtqueue *vq;
        const char *queue_names[] = {"rvq", "txq", "cvq"};
+       size_t sz_vq, sz_q = 0, sz_hdr_mz = 0;
+       void *sw_ring = NULL;
+       int ret;
 
        PMD_INIT_LOG(DEBUG, "setting up queue: %u", vtpci_queue_idx);
 
@@ -316,32 +340,31 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
 
        snprintf(vq_name, sizeof(vq_name), "port%d_%s%d",
                 dev->data->port_id, queue_names[queue_type], queue_idx);
-       vq = rte_zmalloc(vq_name, sizeof(struct virtqueue) +
-                        vq_size * sizeof(struct vq_desc_extra),
-                        RTE_CACHE_LINE_SIZE);
-       if (vq == NULL) {
-               PMD_INIT_LOG(ERR, "Can not allocate virtqueue");
-               return -ENOMEM;
-       }
 
+       sz_vq = RTE_ALIGN_CEIL(sizeof(*vq) +
+                               vq_size * sizeof(struct vq_desc_extra),
+                               RTE_CACHE_LINE_SIZE);
        if (queue_type == VTNET_RQ) {
-               size_t sz_sw;
-
-               sz_sw = (RTE_PMD_VIRTIO_RX_MAX_BURST + vq_size) *
-                       sizeof(vq->sw_ring[0]);
-               vq->sw_ring = rte_zmalloc_socket("rxq->sw_ring", sz_sw,
-                                                RTE_CACHE_LINE_SIZE,
-                                                socket_id);
-               if (!vq->sw_ring) {
-                       PMD_INIT_LOG(ERR, "Can not allocate RX soft ring");
-                       virtio_dev_queue_release(vq);
-                       return -ENOMEM;
-               }
+               sz_q = sz_vq + sizeof(*rxvq);
+       } else if (queue_type == VTNET_TQ) {
+               sz_q = sz_vq + sizeof(*txvq);
+               /*
+                * For each xmit packet, allocate a virtio_net_hdr
+                * and indirect ring elements
+                */
+               sz_hdr_mz = vq_size * sizeof(struct virtio_tx_region);
+       } else if (queue_type == VTNET_CQ) {
+               sz_q = sz_vq + sizeof(*cvq);
+               /* Allocate a page for control vq command, data and status */
+               sz_hdr_mz = PAGE_SIZE;
        }
 
+       vq = rte_zmalloc_socket(vq_name, sz_q, RTE_CACHE_LINE_SIZE, socket_id);
+       if (vq == NULL) {
+               PMD_INIT_LOG(ERR, "can not allocate vq");
+               return -ENOMEM;
+       }
        vq->hw = hw;
-       vq->port_id = dev->data->port_id;
-       vq->queue_id = queue_idx;
        vq->vq_queue_index = vtpci_queue_idx;
        vq->vq_nentries = vq_size;
 
@@ -354,16 +377,17 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
         */
        size = vring_size(vq_size, VIRTIO_PCI_VRING_ALIGN);
        vq->vq_ring_size = RTE_ALIGN_CEIL(size, VIRTIO_PCI_VRING_ALIGN);
-       PMD_INIT_LOG(DEBUG, "vring_size: %d, rounded_vring_size: %d", size, vq->vq_ring_size);
+       PMD_INIT_LOG(DEBUG, "vring_size: %d, rounded_vring_size: %d",
+                    size, vq->vq_ring_size);
 
-       mz = rte_memzone_reserve_aligned(vq_name, vq->vq_ring_size,
-               socket_id, 0, VIRTIO_PCI_VRING_ALIGN);
+       mz = rte_memzone_reserve_aligned(vq_name, vq->vq_ring_size, socket_id,
+                                        0, VIRTIO_PCI_VRING_ALIGN);
        if (mz == NULL) {
                if (rte_errno == EEXIST)
                        mz = rte_memzone_lookup(vq_name);
                if (mz == NULL) {
-                       virtio_dev_queue_release(vq);
-                       return -ENOMEM;
+                       ret = -ENOMEM;
+                       goto fail_q_alloc;
                }
        }
 
@@ -374,44 +398,65 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
         */
        if ((mz->phys_addr + vq->vq_ring_size - 1) >> (VIRTIO_PCI_QUEUE_ADDR_SHIFT + 32)) {
                PMD_INIT_LOG(ERR, "vring address shouldn't be above 16TB!");
-               virtio_dev_queue_release(vq);
-               return -ENOMEM;
+               ret = -ENOMEM;
+               goto fail_q_alloc;
        }
-
        memset(mz->addr, 0, sizeof(mz->len));
-       vq->mz = mz;
+
        vq->vq_ring_mem = mz->phys_addr;
        vq->vq_ring_virt_mem = mz->addr;
-       PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem:      0x%"PRIx64, (uint64_t)mz->phys_addr);
-       PMD_INIT_LOG(DEBUG, "vq->vq_ring_virt_mem: 0x%"PRIx64, (uint64_t)(uintptr_t)mz->addr);
-       vq->virtio_net_hdr_mz  = NULL;
-       vq->virtio_net_hdr_mem = 0;
-
-       if (queue_type == VTNET_TQ) {
-               const struct rte_memzone *hdr_mz;
-               struct virtio_tx_region *txr;
-               unsigned int i;
-
-               /*
-                * For each xmit packet, allocate a virtio_net_hdr
-                * and indirect ring elements
-                */
-               snprintf(vq_name, sizeof(vq_name), "port%d_tvq%d_hdrzone",
-                        dev->data->port_id, queue_idx);
-               hdr_mz = rte_memzone_reserve_aligned(vq_name,
-                                                    vq_size * sizeof(*txr),
+       PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem:      0x%" PRIx64,
+                    (uint64_t)mz->phys_addr);
+       PMD_INIT_LOG(DEBUG, "vq->vq_ring_virt_mem: 0x%" PRIx64,
+                    (uint64_t)(uintptr_t)mz->addr);
+
+       if (sz_hdr_mz) {
+               snprintf(vq_hdr_name, sizeof(vq_hdr_name), "port%d_%s%d_hdr",
+                        dev->data->port_id, queue_names[queue_type],
+                        queue_idx);
+               hdr_mz = rte_memzone_reserve_aligned(vq_hdr_name, sz_hdr_mz,
                                                     socket_id, 0,
                                                     RTE_CACHE_LINE_SIZE);
                if (hdr_mz == NULL) {
                        if (rte_errno == EEXIST)
-                               hdr_mz = rte_memzone_lookup(vq_name);
+                               hdr_mz = rte_memzone_lookup(vq_hdr_name);
                        if (hdr_mz == NULL) {
-                               virtio_dev_queue_release(vq);
-                               return -ENOMEM;
+                               ret = -ENOMEM;
+                               goto fail_q_alloc;
                        }
                }
-               vq->virtio_net_hdr_mz = hdr_mz;
-               vq->virtio_net_hdr_mem = hdr_mz->phys_addr;
+       }
+
+       if (queue_type == VTNET_RQ) {
+               size_t sz_sw = (RTE_PMD_VIRTIO_RX_MAX_BURST + vq_size) *
+                              sizeof(vq->sw_ring[0]);
+
+               sw_ring = rte_zmalloc_socket("sw_ring", sz_sw,
+                                            RTE_CACHE_LINE_SIZE, socket_id);
+               if (!sw_ring) {
+                       PMD_INIT_LOG(ERR, "can not allocate RX soft ring");
+                       ret = -ENOMEM;
+                       goto fail_q_alloc;
+               }
+
+               vq->sw_ring = sw_ring;
+               rxvq = (struct virtnet_rx *)RTE_PTR_ADD(vq, sz_vq);
+               rxvq->vq = vq;
+               rxvq->port_id = dev->data->port_id;
+               rxvq->queue_id = queue_idx;
+               rxvq->mz = mz;
+               *pvq = rxvq;
+       } else if (queue_type == VTNET_TQ) {
+               struct virtio_tx_region *txr;
+               unsigned int i;
+
+               txvq = (struct virtnet_tx *)RTE_PTR_ADD(vq, sz_vq);
+               txvq->vq = vq;
+               txvq->port_id = dev->data->port_id;
+               txvq->queue_id = queue_idx;
+               txvq->mz = mz;
+               txvq->virtio_net_hdr_mz = hdr_mz;
+               txvq->virtio_net_hdr_mem = hdr_mz->phys_addr;
 
                txr = hdr_mz->addr;
                memset(txr, 0, vq_size * sizeof(*txr));
@@ -421,58 +466,55 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
                        vring_desc_init(start_dp, RTE_DIM(txr[i].tx_indir));
 
                        /* first indirect descriptor is always the tx header */
-                       start_dp->addr = vq->virtio_net_hdr_mem
+                       start_dp->addr = txvq->virtio_net_hdr_mem
                                + i * sizeof(*txr)
                                + offsetof(struct virtio_tx_region, tx_hdr);
 
-                       start_dp->len = vq->hw->vtnet_hdr_size;
+                       start_dp->len = hw->vtnet_hdr_size;
                        start_dp->flags = VRING_DESC_F_NEXT;
                }
 
+               *pvq = txvq;
        } else if (queue_type == VTNET_CQ) {
-               /* Allocate a page for control vq command, data and status */
-               snprintf(vq_name, sizeof(vq_name), "port%d_cvq_hdrzone",
-                       dev->data->port_id);
-               vq->virtio_net_hdr_mz = rte_memzone_reserve_aligned(vq_name,
-                       PAGE_SIZE, socket_id, 0, RTE_CACHE_LINE_SIZE);
-               if (vq->virtio_net_hdr_mz == NULL) {
-                       if (rte_errno == EEXIST)
-                               vq->virtio_net_hdr_mz =
-                                       rte_memzone_lookup(vq_name);
-                       if (vq->virtio_net_hdr_mz == NULL) {
-                               virtio_dev_queue_release(vq);
-                               return -ENOMEM;
-                       }
-               }
-               vq->virtio_net_hdr_mem =
-                       vq->virtio_net_hdr_mz->phys_addr;
-               memset(vq->virtio_net_hdr_mz->addr, 0, PAGE_SIZE);
+               cvq = (struct virtnet_ctl *)RTE_PTR_ADD(vq, sz_vq);
+               cvq->vq = vq;
+               cvq->mz = mz;
+               cvq->virtio_net_hdr_mz = hdr_mz;
+               cvq->virtio_net_hdr_mem = hdr_mz->phys_addr;
+               memset(cvq->virtio_net_hdr_mz->addr, 0, PAGE_SIZE);
+               *pvq = cvq;
        }
 
        hw->vtpci_ops->setup_queue(hw, vq);
-
        vq->configured = 1;
-       *pvq = vq;
        return 0;
+
+fail_q_alloc:
+       rte_free(sw_ring);
+       rte_memzone_free(hdr_mz);
+       rte_memzone_free(mz);
+       rte_free(vq);
+
+       return ret;
 }
 
 static int
 virtio_dev_cq_queue_setup(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx,
                uint32_t socket_id)
 {
-       struct virtqueue *vq;
+       struct virtnet_ctl *cvq;
        int ret;
        struct virtio_hw *hw = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
        ret = virtio_dev_queue_setup(dev, VTNET_CQ, VTNET_SQ_CQ_QUEUE_IDX,
-                       vtpci_queue_idx, 0, socket_id, &vq);
+                       vtpci_queue_idx, 0, socket_id, (void **)&cvq);
        if (ret < 0) {
                PMD_INIT_LOG(ERR, "control vq initialization failed");
                return ret;
        }
 
-       hw->cvq = vq;
+       hw->cvq = cvq;
        return 0;
 }
 
@@ -680,32 +722,32 @@ virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        unsigned i;
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               const struct virtqueue *txvq = dev->data->tx_queues[i];
+               const struct virtnet_tx *txvq = dev->data->tx_queues[i];
                if (txvq == NULL)
                        continue;
 
-               stats->opackets += txvq->packets;
-               stats->obytes += txvq->bytes;
-               stats->oerrors += txvq->errors;
+               stats->opackets += txvq->stats.packets;
+               stats->obytes += txvq->stats.bytes;
+               stats->oerrors += txvq->stats.errors;
 
                if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
-                       stats->q_opackets[i] = txvq->packets;
-                       stats->q_obytes[i] = txvq->bytes;
+                       stats->q_opackets[i] = txvq->stats.packets;
+                       stats->q_obytes[i] = txvq->stats.bytes;
                }
        }
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               const struct virtqueue *rxvq = dev->data->rx_queues[i];
+               const struct virtnet_rx *rxvq = dev->data->rx_queues[i];
                if (rxvq == NULL)
                        continue;
 
-               stats->ipackets += rxvq->packets;
-               stats->ibytes += rxvq->bytes;
-               stats->ierrors += rxvq->errors;
+               stats->ipackets += rxvq->stats.packets;
+               stats->ibytes += rxvq->stats.bytes;
+               stats->ierrors += rxvq->stats.errors;
 
                if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
-                       stats->q_ipackets[i] = rxvq->packets;
-                       stats->q_ibytes[i] = rxvq->bytes;
+                       stats->q_ipackets[i] = rxvq->stats.packets;
+                       stats->q_ibytes[i] = rxvq->stats.bytes;
                }
        }
 
@@ -720,8 +762,8 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
        unsigned count = 0;
        unsigned t;
 
-       unsigned nstats = dev->data->nb_tx_queues * VIRTIO_NB_Q_XSTATS +
-               dev->data->nb_rx_queues * VIRTIO_NB_Q_XSTATS;
+       unsigned nstats = dev->data->nb_tx_queues * VIRTIO_NB_TXQ_XSTATS +
+               dev->data->nb_rx_queues * VIRTIO_NB_RXQ_XSTATS;
 
        if (xstats_names == NULL) {
                /* Note: limit checked in rte_eth_xstats_names() */
@@ -730,11 +772,11 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
                        struct virtqueue *rxvq = dev->data->rx_queues[i];
                        if (rxvq == NULL)
                                continue;
-                       for (t = 0; t < VIRTIO_NB_Q_XSTATS; t++) {
+                       for (t = 0; t < VIRTIO_NB_RXQ_XSTATS; t++) {
                                snprintf(xstats_names[count].name,
                                        sizeof(xstats_names[count].name),
                                        "rx_q%u_%s", i,
-                                       rte_virtio_q_stat_strings[t].name);
+                                       rte_virtio_rxq_stat_strings[t].name);
                                xstats_names[count].id = count;
                                count++;
                        }
@@ -744,11 +786,11 @@ static int virtio_dev_xstats_get_names(struct rte_eth_dev *dev,
                        struct virtqueue *txvq = dev->data->tx_queues[i];
                        if (txvq == NULL)
                                continue;
-                       for (t = 0; t < VIRTIO_NB_Q_XSTATS; t++) {
+                       for (t = 0; t < VIRTIO_NB_TXQ_XSTATS; t++) {
                                snprintf(xstats_names[count].name,
                                        sizeof(xstats_names[count].name),
                                        "tx_q%u_%s", i,
-                                       rte_virtio_q_stat_strings[t].name);
+                                       rte_virtio_txq_stat_strings[t].name);
                                xstats_names[count].id = count;
                                count++;
                        }
@@ -765,40 +807,40 @@ virtio_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
        unsigned i;
        unsigned count = 0;
 
-       unsigned nstats = dev->data->nb_tx_queues * VIRTIO_NB_Q_XSTATS +
-               dev->data->nb_rx_queues * VIRTIO_NB_Q_XSTATS;
+       unsigned nstats = dev->data->nb_tx_queues * VIRTIO_NB_TXQ_XSTATS +
+               dev->data->nb_rx_queues * VIRTIO_NB_RXQ_XSTATS;
 
        if (n < nstats)
                return nstats;
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               struct virtqueue *rxvq = dev->data->rx_queues[i];
+               struct virtnet_rx *rxvq = dev->data->rx_queues[i];
 
                if (rxvq == NULL)
                        continue;
 
                unsigned t;
 
-               for (t = 0; t < VIRTIO_NB_Q_XSTATS; t++) {
+               for (t = 0; t < VIRTIO_NB_RXQ_XSTATS; t++) {
                        xstats[count].id = count;
                        xstats[count].value = *(uint64_t *)(((char *)rxvq) +
-                               rte_virtio_q_stat_strings[t].offset);
+                               rte_virtio_rxq_stat_strings[t].offset);
                        count++;
                }
        }
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               struct virtqueue *txvq = dev->data->tx_queues[i];
+               struct virtnet_tx *txvq = dev->data->tx_queues[i];
 
                if (txvq == NULL)
                        continue;
 
                unsigned t;
 
-               for (t = 0; t < VIRTIO_NB_Q_XSTATS; t++) {
+               for (t = 0; t < VIRTIO_NB_TXQ_XSTATS; t++) {
                        xstats[count].id = count;
                        xstats[count].value = *(uint64_t *)(((char *)txvq) +
-                               rte_virtio_q_stat_strings[t].offset);
+                               rte_virtio_txq_stat_strings[t].offset);
                        count++;
                }
        }
@@ -818,29 +860,31 @@ virtio_dev_stats_reset(struct rte_eth_dev *dev)
        unsigned int i;
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               struct virtqueue *txvq = dev->data->tx_queues[i];
+               struct virtnet_tx *txvq = dev->data->tx_queues[i];
                if (txvq == NULL)
                        continue;
 
-               txvq->packets = 0;
-               txvq->bytes = 0;
-               txvq->errors = 0;
-               txvq->multicast = 0;
-               txvq->broadcast = 0;
-               memset(txvq->size_bins, 0, sizeof(txvq->size_bins[0]) * 8);
+               txvq->stats.packets = 0;
+               txvq->stats.bytes = 0;
+               txvq->stats.errors = 0;
+               txvq->stats.multicast = 0;
+               txvq->stats.broadcast = 0;
+               memset(txvq->stats.size_bins, 0,
+                      sizeof(txvq->stats.size_bins[0]) * 8);
        }
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
-               struct virtqueue *rxvq = dev->data->rx_queues[i];
+               struct virtnet_rx *rxvq = dev->data->rx_queues[i];
                if (rxvq == NULL)
                        continue;
 
-               rxvq->packets = 0;
-               rxvq->bytes = 0;
-               rxvq->errors = 0;
-               rxvq->multicast = 0;
-               rxvq->broadcast = 0;
-               memset(rxvq->size_bins, 0, sizeof(rxvq->size_bins[0]) * 8);
+               rxvq->stats.packets = 0;
+               rxvq->stats.bytes = 0;
+               rxvq->stats.errors = 0;
+               rxvq->stats.multicast = 0;
+               rxvq->stats.broadcast = 0;
+               memset(rxvq->stats.size_bins, 0,
+                      sizeof(rxvq->stats.size_bins[0]) * 8);
        }
 }
 
@@ -1233,7 +1277,8 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
        eth_dev->tx_pkt_burst = NULL;
        eth_dev->rx_pkt_burst = NULL;
 
-       virtio_dev_queue_release(hw->cvq);
+       if (hw->cvq)
+               virtio_dev_queue_release(hw->cvq->vq);
 
        rte_free(eth_dev->data->mac_addrs);
        eth_dev->data->mac_addrs = NULL;
@@ -1321,6 +1366,8 @@ virtio_dev_start(struct rte_eth_dev *dev)
 {
        uint16_t nb_queues, i;
        struct virtio_hw *hw = dev->data->dev_private;
+       struct virtnet_rx *rxvq;
+       struct virtnet_tx *txvq __rte_unused;
 
        /* check if lsc interrupt feature is enabled */
        if (dev->data->dev_conf.intr_conf.lsc) {
@@ -1360,16 +1407,22 @@ virtio_dev_start(struct rte_eth_dev *dev)
 
        PMD_INIT_LOG(DEBUG, "nb_queues=%d", nb_queues);
 
-       for (i = 0; i < nb_queues; i++)
-               virtqueue_notify(dev->data->rx_queues[i]);
+       for (i = 0; i < nb_queues; i++) {
+               rxvq = dev->data->rx_queues[i];
+               virtqueue_notify(rxvq->vq);
+       }
 
        PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
 
-       for (i = 0; i < dev->data->nb_rx_queues; i++)
-               VIRTQUEUE_DUMP((struct virtqueue *)dev->data->rx_queues[i]);
+       for (i = 0; i < dev->data->nb_rx_queues; i++) {
+               rxvq = dev->data->rx_queues[i];
+               VIRTQUEUE_DUMP(rxvq->vq);
+       }
 
-       for (i = 0; i < dev->data->nb_tx_queues; i++)
-               VIRTQUEUE_DUMP((struct virtqueue *)dev->data->tx_queues[i]);
+       for (i = 0; i < dev->data->nb_tx_queues; i++) {
+               txvq = dev->data->tx_queues[i];
+               VIRTQUEUE_DUMP(txvq->vq);
+       }
 
        return 0;
 }
@@ -1380,14 +1433,14 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev)
        int i, mbuf_num = 0;
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
+               struct virtnet_rx *rxvq = dev->data->rx_queues[i];
+
                PMD_INIT_LOG(DEBUG,
                             "Before freeing rxq[%d] used and unused buf", i);
-               VIRTQUEUE_DUMP((struct virtqueue *)dev->data->rx_queues[i]);
+               VIRTQUEUE_DUMP(rxvq->vq);
 
-               PMD_INIT_LOG(DEBUG, "rx_queues[%d]=%p",
-                               i, dev->data->rx_queues[i]);
-               while ((buf = (struct rte_mbuf *)virtqueue_detatch_unused(
-                                       dev->data->rx_queues[i])) != NULL) {
+               PMD_INIT_LOG(DEBUG, "rx_queues[%d]=%p", i, rxvq);
+               while ((buf = virtqueue_detatch_unused(rxvq->vq)) != NULL) {
                        rte_pktmbuf_free(buf);
                        mbuf_num++;
                }
@@ -1395,27 +1448,27 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev)
                PMD_INIT_LOG(DEBUG, "free %d mbufs", mbuf_num);
                PMD_INIT_LOG(DEBUG,
                             "After freeing rxq[%d] used and unused buf", i);
-               VIRTQUEUE_DUMP((struct virtqueue *)dev->data->rx_queues[i]);
+               VIRTQUEUE_DUMP(rxvq->vq);
        }
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
+               struct virtnet_tx *txvq = dev->data->tx_queues[i];
+
                PMD_INIT_LOG(DEBUG,
                             "Before freeing txq[%d] used and unused bufs",
                             i);
-               VIRTQUEUE_DUMP((struct virtqueue *)dev->data->tx_queues[i]);
+               VIRTQUEUE_DUMP(txvq->vq);
 
                mbuf_num = 0;
-               while ((buf = (struct rte_mbuf *)virtqueue_detatch_unused(
-                                       dev->data->tx_queues[i])) != NULL) {
+               while ((buf = virtqueue_detatch_unused(txvq->vq)) != NULL) {
                        rte_pktmbuf_free(buf);
-
                        mbuf_num++;
                }
 
                PMD_INIT_LOG(DEBUG, "free %d mbufs", mbuf_num);
                PMD_INIT_LOG(DEBUG,
                             "After freeing txq[%d] used and unused buf", i);
-               VIRTQUEUE_DUMP((struct virtqueue *)dev->data->tx_queues[i]);
+               VIRTQUEUE_DUMP(txvq->vq);
        }
 }