remove extra parentheses in return statement

[dpdk.git] / lib / librte_ether / rte_ether.h

diff --git a/lib/librte_ether/rte_ether.h b/lib/librte_ether/rte_ether.h
index 0797908..1d62d8e 100644 (file)
--- a/lib/librte_ether/rte_ether.h
+++ b/lib/librte_ether/rte_ether.h
@@ -145,7 +145,7 @@ static inline int is_zero_ether_addr(const struct ether_addr *ea)
  */
 static inline int is_unicast_ether_addr(const struct ether_addr *ea)
 {
-       return ((ea->addr_bytes[0] & ETHER_GROUP_ADDR) == 0);
+       return (ea->addr_bytes[0] & ETHER_GROUP_ADDR) == 0;
 }
 
 /**
@@ -160,7 +160,7 @@ static inline int is_unicast_ether_addr(const struct ether_addr *ea)
  */
 static inline int is_multicast_ether_addr(const struct ether_addr *ea)
 {
-       return (ea->addr_bytes[0] & ETHER_GROUP_ADDR);
+       return ea->addr_bytes[0] & ETHER_GROUP_ADDR;
 }
 
 /**
@@ -175,7 +175,7 @@ static inline int is_multicast_ether_addr(const struct ether_addr *ea)
  */
 static inline int is_broadcast_ether_addr(const struct ether_addr *ea)
 {
-       const uint16_t *ea_words = (const uint16_t *)ea;
+       const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea;
 
        return (ea_words[0] == 0xFFFF && ea_words[1] == 0xFFFF &&
                ea_words[2] == 0xFFFF);
@@ -193,7 +193,7 @@ static inline int is_broadcast_ether_addr(const struct ether_addr *ea)
  */
 static inline int is_universal_ether_addr(const struct ether_addr *ea)
 {
-       return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 0);
+       return (ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 0;
 }
 
 /**
@@ -208,7 +208,7 @@ static inline int is_universal_ether_addr(const struct ether_addr *ea)
  */
 static inline int is_local_admin_ether_addr(const struct ether_addr *ea)
 {
-       return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) != 0);
+       return (ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) != 0;
 }
 
 /**
@@ -224,7 +224,7 @@ static inline int is_local_admin_ether_addr(const struct ether_addr *ea)
  */
 static inline int is_valid_assigned_ether_addr(const struct ether_addr *ea)
 {
-       return (is_unicast_ether_addr(ea) && (! is_zero_ether_addr(ea)));
+       return is_unicast_ether_addr(ea) && (! is_zero_ether_addr(ea));
 }
 
 /**
@@ -277,7 +277,7 @@ static inline void ether_addr_copy(const struct ether_addr *ea_from,
  *   A pointer to buffer contains the formatted MAC address.
  * @param size
  *   The format buffer size.
- * @param ea_to
+ * @param eth_addr
  *   A pointer to a ether_addr structure.
  */
 static inline void
@@ -331,6 +331,7 @@ struct vxlan_hdr {
 #define ETHER_TYPE_VLAN 0x8100 /**< IEEE 802.1Q VLAN tagging. */
 #define ETHER_TYPE_1588 0x88F7 /**< IEEE 802.1AS 1588 Precise Time Protocol. */
 #define ETHER_TYPE_SLOW 0x8809 /**< Slow protocols (LACP and Marker). */
+#define ETHER_TYPE_TEB  0x6558 /**< Transparent Ethernet Bridging. */
 
 #define ETHER_VXLAN_HLEN (sizeof(struct udp_hdr) + sizeof(struct vxlan_hdr))
 /**< VXLAN tunnel header length. */
@@ -382,7 +383,6 @@ static inline int rte_vlan_insert(struct rte_mbuf **m)
        struct ether_hdr *oh, *nh;
        struct vlan_hdr *vh;
 
-#ifdef RTE_MBUF_REFCNT
        /* Can't insert header if mbuf is shared */
        if (rte_mbuf_refcnt_read(*m) > 1) {
                struct rte_mbuf *copy;
@@ -393,7 +393,7 @@ static inline int rte_vlan_insert(struct rte_mbuf **m)
                rte_pktmbuf_free(*m);
                *m = copy;
        }
-#endif
+
        oh = rte_pktmbuf_mtod(*m, struct ether_hdr *);
        nh = (struct ether_hdr *)
                rte_pktmbuf_prepend(*m, sizeof(struct vlan_hdr));