doc: whitespace changes in licenses
[dpdk.git] / lib / librte_pmd_ixgbe / ixgbe_rxtx.c
index d82b206..fd5fd3d 100644 (file)
@@ -1,35 +1,34 @@
 /*-
  *   BSD LICENSE
  * 
- *   Copyright(c) 2010-2012 Intel Corporation. All rights reserved.
+ *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.
  *   All rights reserved.
  * 
- *   Redistribution and use in source and binary forms, with or without 
- *   modification, are permitted provided that the following conditions 
+ *   Redistribution and use in source and binary forms, with or without
+ *   modification, are permitted provided that the following conditions
  *   are met:
  * 
- *     * Redistributions of source code must retain the above copyright 
+ *     * Redistributions of source code must retain the above copyright
  *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright 
- *       notice, this list of conditions and the following disclaimer in 
- *       the documentation and/or other materials provided with the 
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in
+ *       the documentation and/or other materials provided with the
  *       distribution.
- *     * Neither the name of Intel Corporation nor the names of its 
- *       contributors may be used to endorse or promote products derived 
+ *     * Neither the name of Intel Corporation nor the names of its
+ *       contributors may be used to endorse or promote products derived
  *       from this software without specific prior written permission.
  * 
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 
+ *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- * 
  */
 
 #include <sys/queue.h>
 #include "ixgbe/ixgbe_api.h"
 #include "ixgbe/ixgbe_vf.h"
 #include "ixgbe_ethdev.h"
+#include "ixgbe/ixgbe_dcb.h"
+
+
+#define RTE_PMD_IXGBE_TX_MAX_BURST 32
 
 #ifdef RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC
 #define RTE_PMD_IXGBE_RX_MAX_BURST 32
@@ -123,6 +126,7 @@ struct igb_rx_queue {
        volatile union ixgbe_adv_rx_desc *rx_ring; /**< RX ring virtual address. */
        uint64_t            rx_ring_phys_addr; /**< RX ring DMA address. */
        volatile uint32_t   *rdt_reg_addr; /**< RDT register address. */
+       volatile uint32_t   *rdh_reg_addr; /**< RDH register address. */
        struct igb_rx_entry *sw_ring; /**< address of RX software ring. */
        struct rte_mbuf *pkt_first_seg; /**< First segment of current packet. */
        struct rte_mbuf *pkt_last_seg; /**< Last segment of current packet. */
@@ -136,6 +140,7 @@ struct igb_rx_queue {
 #endif
        uint16_t            rx_free_thresh; /**< max free RX desc to hold. */
        uint16_t            queue_id; /**< RX queue index. */
+       uint16_t            reg_idx;  /**< RX queue register index. */
        uint8_t             port_id;  /**< Device port identifier. */
        uint8_t             crc_len;  /**< 0 if CRC stripped, 4 otherwise. */
        uint8_t             drop_en;  /**< If not 0, set SRRCTL.Drop_En. */
@@ -159,10 +164,11 @@ enum ixgbe_advctx_num {
 /**
  * Structure to check if new context need be built
  */
+
 struct ixgbe_advctx_info {
        uint16_t flags;           /**< ol_flags for context build. */
        uint32_t cmp_mask;        /**< compare mask for vlan_macip_lens */
-       uint32_t vlan_macip_lens; /**< vlan, mac ip length. */
+       union rte_vlan_macip vlan_macip_lens; /**< vlan, mac ip length. */
 };
 
 /**
@@ -185,11 +191,15 @@ struct igb_tx_queue {
        uint16_t            last_desc_cleaned;
        /** Total number of TX descriptors ready to be allocated. */
        uint16_t            nb_tx_free;
+       uint16_t tx_next_dd; /**< next desc to scan for DD bit */
+       uint16_t tx_next_rs; /**< next desc to set RS bit */
        uint16_t            queue_id;      /**< TX queue index. */
+       uint16_t            reg_idx;       /**< TX queue register index. */
        uint8_t             port_id;       /**< Device port identifier. */
        uint8_t             pthresh;       /**< Prefetch threshold register. */
        uint8_t             hthresh;       /**< Host threshold register. */
        uint8_t             wthresh;       /**< Write-back threshold reg. */
+       uint32_t txq_flags; /**< Holds flags for this TXq */
        uint32_t            ctx_curr;      /**< Hardware context states. */
        /** Hardware context0 history. */
        struct ixgbe_advctx_info ctx_cache[IXGBE_CTX_NUM];
@@ -220,6 +230,269 @@ struct igb_tx_queue {
  *  TX functions
  *
  **********************************************************************/
+
+/*
+ * The "simple" TX queue functions require that the following
+ * flags are set when the TX queue is configured:
+ *  - ETH_TXQ_FLAGS_NOMULTSEGS
+ *  - ETH_TXQ_FLAGS_NOVLANOFFL
+ *  - ETH_TXQ_FLAGS_NOXSUMSCTP
+ *  - ETH_TXQ_FLAGS_NOXSUMUDP
+ *  - ETH_TXQ_FLAGS_NOXSUMTCP
+ * and that the RS bit threshold (tx_rs_thresh) is at least equal to
+ * RTE_PMD_IXGBE_TX_MAX_BURST.
+ */
+#define IXGBE_SIMPLE_FLAGS ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \
+                           ETH_TXQ_FLAGS_NOOFFLOADS)
+
+/*
+ * Check for descriptors with their DD bit set and free mbufs.
+ * Return the total number of buffers freed.
+ */
+static inline int __attribute__((always_inline))
+ixgbe_tx_free_bufs(struct igb_tx_queue *txq)
+{
+       struct igb_tx_entry *txep;
+       uint32_t status;
+       int i;
+
+       /* check DD bit on threshold descriptor */
+       status = txq->tx_ring[txq->tx_next_dd].wb.status;
+       if (! (status & IXGBE_ADVTXD_STAT_DD))
+               return 0;
+
+       /*
+        * first buffer to free from S/W ring is at index
+        * tx_next_dd - (tx_rs_thresh-1)
+        */
+       txep = &(txq->sw_ring[txq->tx_next_dd - (txq->tx_rs_thresh - 1)]);
+
+       /* prefetch the mbufs that are about to be freed */
+       for (i = 0; i < txq->tx_rs_thresh; ++i)
+               rte_prefetch0((txep + i)->mbuf);
+
+       /* free buffers one at a time */
+       if ((txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT) != 0) {
+               for (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {
+                       rte_mempool_put(txep->mbuf->pool, txep->mbuf);
+                       txep->mbuf = NULL;
+               }
+       } else {
+               for (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {
+                       rte_pktmbuf_free_seg(txep->mbuf);
+                       txep->mbuf = NULL;
+               }
+       }
+
+       /* buffers were freed, update counters */
+       txq->nb_tx_free = (uint16_t)(txq->nb_tx_free + txq->tx_rs_thresh);
+       txq->tx_next_dd = (uint16_t)(txq->tx_next_dd + txq->tx_rs_thresh);
+       if (txq->tx_next_dd >= txq->nb_tx_desc)
+               txq->tx_next_dd = (uint16_t)(txq->tx_rs_thresh - 1);
+
+       return txq->tx_rs_thresh;
+}
+
+/*
+ * Populate descriptors with the following info:
+ * 1.) buffer_addr = phys_addr + headroom
+ * 2.) cmd_type_len = DCMD_DTYP_FLAGS | pkt_len
+ * 3.) olinfo_status = pkt_len << PAYLEN_SHIFT
+ */
+
+/* Defines for Tx descriptor */
+#define DCMD_DTYP_FLAGS (IXGBE_ADVTXD_DTYP_DATA |\
+                        IXGBE_ADVTXD_DCMD_IFCS |\
+                        IXGBE_ADVTXD_DCMD_DEXT |\
+                        IXGBE_ADVTXD_DCMD_EOP)
+
+/* Populate 4 descriptors with data from 4 mbufs */
+static inline void
+tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts)
+{
+       uint64_t buf_dma_addr;
+       uint32_t pkt_len;
+       int i;
+
+       for (i = 0; i < 4; ++i, ++txdp, ++pkts) {
+               buf_dma_addr = RTE_MBUF_DATA_DMA_ADDR(*pkts);
+               pkt_len = (*pkts)->pkt.data_len;
+
+               /* write data to descriptor */
+               txdp->read.buffer_addr = buf_dma_addr;
+               txdp->read.cmd_type_len =
+                               ((uint32_t)DCMD_DTYP_FLAGS | pkt_len);
+               txdp->read.olinfo_status =
+                               (pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT);
+       }
+}
+
+/* Populate 1 descriptor with data from 1 mbuf */
+static inline void
+tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts)
+{
+       uint64_t buf_dma_addr;
+       uint32_t pkt_len;
+
+       buf_dma_addr = RTE_MBUF_DATA_DMA_ADDR(*pkts);
+       pkt_len = (*pkts)->pkt.data_len;
+
+       /* write data to descriptor */
+       txdp->read.buffer_addr = buf_dma_addr;
+       txdp->read.cmd_type_len =
+                       ((uint32_t)DCMD_DTYP_FLAGS | pkt_len);
+       txdp->read.olinfo_status =
+                       (pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT);
+}
+
+/*
+ * Fill H/W descriptor ring with mbuf data.
+ * Copy mbuf pointers to the S/W ring.
+ */
+static inline void
+ixgbe_tx_fill_hw_ring(struct igb_tx_queue *txq, struct rte_mbuf **pkts,
+                     uint16_t nb_pkts)
+{
+       volatile union ixgbe_adv_tx_desc *txdp = &(txq->tx_ring[txq->tx_tail]);
+       struct igb_tx_entry *txep = &(txq->sw_ring[txq->tx_tail]);
+       const int N_PER_LOOP = 4;
+       const int N_PER_LOOP_MASK = N_PER_LOOP-1;
+       int mainpart, leftover;
+       int i, j;
+
+       /*
+        * Process most of the packets in chunks of N pkts.  Any
+        * leftover packets will get processed one at a time.
+        */
+       mainpart = (nb_pkts & ((uint32_t) ~N_PER_LOOP_MASK));
+       leftover = (nb_pkts & ((uint32_t)  N_PER_LOOP_MASK));
+       for (i = 0; i < mainpart; i += N_PER_LOOP) {
+               /* Copy N mbuf pointers to the S/W ring */
+               for (j = 0; j < N_PER_LOOP; ++j) {
+                       (txep + i + j)->mbuf = *(pkts + i + j);
+               }
+               tx4(txdp + i, pkts + i);
+       }
+
+       if (unlikely(leftover > 0)) {
+               for (i = 0; i < leftover; ++i) {
+                       (txep + mainpart + i)->mbuf = *(pkts + mainpart + i);
+                       tx1(txdp + mainpart + i, pkts + mainpart + i);
+               }
+       }
+}
+
+static inline uint16_t
+tx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
+            uint16_t nb_pkts)
+{
+       struct igb_tx_queue *txq = (struct igb_tx_queue *)tx_queue;
+       volatile union ixgbe_adv_tx_desc *tx_r = txq->tx_ring;
+       uint16_t n = 0;
+
+       /*
+        * Begin scanning the H/W ring for done descriptors when the
+        * number of available descriptors drops below tx_free_thresh.  For
+        * each done descriptor, free the associated buffer.
+        */
+       if (txq->nb_tx_free < txq->tx_free_thresh)
+               ixgbe_tx_free_bufs(txq);
+
+       /* Only use descriptors that are available */
+       nb_pkts = (uint16_t)RTE_MIN(txq->nb_tx_free, nb_pkts);
+       if (unlikely(nb_pkts == 0))
+               return 0;
+
+       /* Use exactly nb_pkts descriptors */
+       txq->nb_tx_free = (uint16_t)(txq->nb_tx_free - nb_pkts);
+
+       /*
+        * At this point, we know there are enough descriptors in the
+        * ring to transmit all the packets.  This assumes that each
+        * mbuf contains a single segment, and that no new offloads
+        * are expected, which would require a new context descriptor.
+        */
+
+       /*
+        * See if we're going to wrap-around. If so, handle the top
+        * of the descriptor ring first, then do the bottom.  If not,
+        * the processing looks just like the "bottom" part anyway...
+        */
+       if ((txq->tx_tail + nb_pkts) > txq->nb_tx_desc) {
+               n = (uint16_t)(txq->nb_tx_desc - txq->tx_tail);
+               ixgbe_tx_fill_hw_ring(txq, tx_pkts, n);
+
+               /*
+                * We know that the last descriptor in the ring will need to
+                * have its RS bit set because tx_rs_thresh has to be
+                * a divisor of the ring size
+                */
+               tx_r[txq->tx_next_rs].read.cmd_type_len |=
+                       rte_cpu_to_le_32(IXGBE_ADVTXD_DCMD_RS);
+               txq->tx_next_rs = (uint16_t)(txq->tx_rs_thresh - 1);
+
+               txq->tx_tail = 0;
+       }
+
+       /* Fill H/W descriptor ring with mbuf data */
+       ixgbe_tx_fill_hw_ring(txq, tx_pkts + n, (uint16_t)(nb_pkts - n));
+       txq->tx_tail = (uint16_t)(txq->tx_tail + (nb_pkts - n));
+
+       /*
+        * Determine if RS bit should be set
+        * This is what we actually want:
+        *   if ((txq->tx_tail - 1) >= txq->tx_next_rs)
+        * but instead of subtracting 1 and doing >=, we can just do
+        * greater than without subtracting.
+        */
+       if (txq->tx_tail > txq->tx_next_rs) {
+               tx_r[txq->tx_next_rs].read.cmd_type_len |=
+                       rte_cpu_to_le_32(IXGBE_ADVTXD_DCMD_RS);
+               txq->tx_next_rs = (uint16_t)(txq->tx_next_rs +
+                                               txq->tx_rs_thresh);
+               if (txq->tx_next_rs >= txq->nb_tx_desc)
+                       txq->tx_next_rs = (uint16_t)(txq->tx_rs_thresh - 1);
+       }
+
+       /*
+        * Check for wrap-around. This would only happen if we used
+        * up to the last descriptor in the ring, no more, no less.
+        */
+       if (txq->tx_tail >= txq->nb_tx_desc)
+               txq->tx_tail = 0;
+
+       /* update tail pointer */
+       rte_wmb();
+       IXGBE_PCI_REG_WRITE(txq->tdt_reg_addr, txq->tx_tail);
+
+       return nb_pkts;
+}
+
+uint16_t
+ixgbe_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts,
+                      uint16_t nb_pkts)
+{
+       uint16_t nb_tx;
+
+       /* Try to transmit at least chunks of TX_MAX_BURST pkts */
+       if (likely(nb_pkts <= RTE_PMD_IXGBE_TX_MAX_BURST))
+               return tx_xmit_pkts(tx_queue, tx_pkts, nb_pkts);
+
+       /* transmit more than the max burst, in chunks of TX_MAX_BURST */
+       nb_tx = 0;
+       while (nb_pkts) {
+               uint16_t ret, n;
+               n = (uint16_t)RTE_MIN(nb_pkts, RTE_PMD_IXGBE_TX_MAX_BURST);
+               ret = tx_xmit_pkts(tx_queue, &(tx_pkts[nb_tx]), n);
+               nb_tx = (uint16_t)(nb_tx + ret);
+               nb_pkts = (uint16_t)(nb_pkts - ret);
+               if (ret < n)
+                       break;
+       }
+
+       return nb_tx;
+}
+
 static inline void
 ixgbe_set_xmit_ctx(struct igb_tx_queue* txq,
                volatile struct ixgbe_adv_tx_context_desc *ctx_txd,
@@ -272,7 +545,8 @@ ixgbe_set_xmit_ctx(struct igb_tx_queue* txq,
 
        txq->ctx_cache[ctx_idx].flags = ol_flags;
        txq->ctx_cache[ctx_idx].cmp_mask = cmp_mask;
-       txq->ctx_cache[ctx_idx].vlan_macip_lens = vlan_macip_lens & cmp_mask;
+       txq->ctx_cache[ctx_idx].vlan_macip_lens.data =
+               vlan_macip_lens & cmp_mask;
 
        ctx_txd->type_tucmd_mlhl = rte_cpu_to_le_32(type_tucmd_mlhl);
        ctx_txd->vlan_macip_lens = rte_cpu_to_le_32(vlan_macip_lens);
@@ -290,7 +564,7 @@ what_advctx_update(struct igb_tx_queue *txq, uint16_t flags,
 {
        /* If match with the current used context */
        if (likely((txq->ctx_cache[txq->ctx_curr].flags == flags) &&
-               (txq->ctx_cache[txq->ctx_curr].vlan_macip_lens ==
+               (txq->ctx_cache[txq->ctx_curr].vlan_macip_lens.data ==
                (txq->ctx_cache[txq->ctx_curr].cmp_mask & vlan_macip_lens)))) {
                        return txq->ctx_curr;
        }
@@ -298,7 +572,7 @@ what_advctx_update(struct igb_tx_queue *txq, uint16_t flags,
        /* What if match with the next context  */
        txq->ctx_curr ^= 1;
        if (likely((txq->ctx_cache[txq->ctx_curr].flags == flags) &&
-               (txq->ctx_cache[txq->ctx_curr].vlan_macip_lens ==
+               (txq->ctx_cache[txq->ctx_curr].vlan_macip_lens.data ==
                (txq->ctx_cache[txq->ctx_curr].cmp_mask & vlan_macip_lens)))) {
                        return txq->ctx_curr;
        }
@@ -346,9 +620,9 @@ ixgbe_xmit_cleanup(struct igb_tx_queue *txq)
        uint16_t nb_tx_to_clean;
 
        /* Determine the last descriptor needing to be cleaned */
-       desc_to_clean_to = last_desc_cleaned + txq->tx_rs_thresh;
+       desc_to_clean_to = (uint16_t)(last_desc_cleaned + txq->tx_rs_thresh);
        if (desc_to_clean_to >= nb_tx_desc)
-               desc_to_clean_to = desc_to_clean_to - nb_tx_desc;
+               desc_to_clean_to = (uint16_t)(desc_to_clean_to - nb_tx_desc);
 
        /* Check to make sure the last descriptor to clean is done */
        desc_to_clean_to = sw_ring[desc_to_clean_to].last_id;
@@ -365,10 +639,11 @@ ixgbe_xmit_cleanup(struct igb_tx_queue *txq)
 
        /* Figure out how many descriptors will be cleaned */
        if (last_desc_cleaned > desc_to_clean_to)
-               nb_tx_to_clean = ((nb_tx_desc - last_desc_cleaned) +
-                                 desc_to_clean_to);
+               nb_tx_to_clean = (uint16_t)((nb_tx_desc - last_desc_cleaned) +
+                                                       desc_to_clean_to);
        else
-               nb_tx_to_clean = desc_to_clean_to - last_desc_cleaned;
+               nb_tx_to_clean = (uint16_t)(desc_to_clean_to -
+                                               last_desc_cleaned);
 
        PMD_TX_FREE_LOG(DEBUG,
                        "Cleaning %4u TX descriptors: %4u to %4u "
@@ -386,7 +661,7 @@ ixgbe_xmit_cleanup(struct igb_tx_queue *txq)
 
        /* Update the txq to reflect the last descriptor that was cleaned */
        txq->last_desc_cleaned = desc_to_clean_to;
-       txq->nb_tx_free += nb_tx_to_clean;
+       txq->nb_tx_free = (uint16_t)(txq->nb_tx_free + nb_tx_to_clean);
 
        /* No Error */
        return (0);
@@ -415,7 +690,7 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
        uint16_t nb_used;
        uint16_t tx_ol_req;
        uint32_t vlan_macip_lens;
-       uint32_t ctx;
+       uint32_t ctx = 0;
        uint32_t new_ctx;
 
        txq = tx_queue;
@@ -442,15 +717,14 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
                 * are needed for offload functionality.
                 */
                ol_flags = tx_pkt->ol_flags;
-               vlan_macip_lens = tx_pkt->pkt.vlan_tci << 16 |
-                               tx_pkt->pkt.l2_len << IXGBE_ADVTXD_MACLEN_SHIFT |
-                               tx_pkt->pkt.l3_len;
+               vlan_macip_lens = tx_pkt->pkt.vlan_macip.data;
 
                /* If hardware offload required */
-               tx_ol_req = ol_flags & PKT_TX_OFFLOAD_MASK;
+               tx_ol_req = (uint16_t)(ol_flags & PKT_TX_OFFLOAD_MASK);
                if (tx_ol_req) {
                        /* If new context need be built or reuse the exist ctx. */
-                       ctx = what_advctx_update(txq, tx_ol_req, vlan_macip_lens);
+                       ctx = what_advctx_update(txq, tx_ol_req,
+                               vlan_macip_lens);
                        /* Only allocate context descriptor if required*/
                        new_ctx = (ctx == IXGBE_CTX_NUM);
                        ctx = txq->ctx_curr;
@@ -461,7 +735,7 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
                 * This will always be the number of segments + the number of
                 * Context descriptors required to transmit the packet
                 */
-               nb_used = tx_pkt->pkt.nb_segs + new_ctx;
+               nb_used = (uint16_t)(tx_pkt->pkt.nb_segs + new_ctx);
 
                /*
                 * The number of descriptors that must be allocated for a
@@ -639,8 +913,8 @@ ixgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
                 * The last packet data descriptor needs End Of Packet (EOP)
                 */
                cmd_type_len |= IXGBE_TXD_CMD_EOP;
-               txq->nb_tx_used += nb_used;
-               txq->nb_tx_free -= nb_used;
+               txq->nb_tx_used = (uint16_t)(txq->nb_tx_used + nb_used);
+               txq->nb_tx_free = (uint16_t)(txq->nb_tx_free - nb_used);
 
                /* Set RS bit only on threshold packets' last descriptor */
                if (txq->nb_tx_used >= txq->tx_rs_thresh) {
@@ -709,7 +983,7 @@ rx_desc_hlen_type_rss_to_pkt_flags(uint32_t hl_tp_rs)
                                ip_pkt_types_map[(hl_tp_rs >> 4) & 0x0F]);
 
 #endif
-       return (pkt_flags | ip_rss_types_map[hl_tp_rs & 0xF]);
+       return (uint16_t)(pkt_flags | ip_rss_types_map[hl_tp_rs & 0xF]);
 }
 
 static inline uint16_t
@@ -722,11 +996,12 @@ rx_desc_status_to_pkt_flags(uint32_t rx_status)
         * Do not check whether L3/L4 rx checksum done by NIC or not,
         * That can be found from rte_eth_rxmode.hw_ip_checksum flag
         */
-       pkt_flags = (uint16_t) (rx_status & IXGBE_RXD_STAT_VP) ? PKT_RX_VLAN_PKT : 0;
+       pkt_flags = (uint16_t)((rx_status & IXGBE_RXD_STAT_VP) ?
+                                               PKT_RX_VLAN_PKT : 0);
 
 #ifdef RTE_LIBRTE_IEEE1588
        if (rx_status & IXGBE_RXD_STAT_TMST)
-               pkt_flags = (pkt_flags | PKT_RX_IEEE1588_TMST);
+               pkt_flags = (uint16_t)(pkt_flags | PKT_RX_IEEE1588_TMST);
 #endif
        return pkt_flags;
 }
@@ -799,7 +1074,8 @@ ixgbe_rx_scan_hw_ring(struct igb_rx_queue *rxq)
                /* Translate descriptor info to mbuf format */
                for (j = 0; j < nb_dd; ++j) {
                        mb = rxep[j].mbuf;
-                       pkt_len = rxdp[j].wb.upper.length - rxq->crc_len;
+                       pkt_len = (uint16_t)(rxdp[j].wb.upper.length -
+                                                       rxq->crc_len);
                        mb->pkt.data_len = pkt_len;
                        mb->pkt.pkt_len = pkt_len;
                        mb->pkt.vlan_macip.f.vlan_tci = rxdp[j].wb.upper.vlan;
@@ -809,8 +1085,10 @@ ixgbe_rx_scan_hw_ring(struct igb_rx_queue *rxq)
                        mb->ol_flags  = rx_desc_hlen_type_rss_to_pkt_flags(
                                        rxdp[j].wb.lower.lo_dword.data);
                        /* reuse status field from scan list */
-                       mb->ol_flags |= rx_desc_status_to_pkt_flags(s[j]);
-                       mb->ol_flags |= rx_desc_error_to_pkt_flags(s[j]);
+                       mb->ol_flags = (uint16_t)(mb->ol_flags |
+                                       rx_desc_status_to_pkt_flags(s[j]));
+                       mb->ol_flags = (uint16_t)(mb->ol_flags |
+                                       rx_desc_error_to_pkt_flags(s[j]));
                }
 
                /* Move mbuf pointers from the S/W ring to the stage */
@@ -824,8 +1102,10 @@ ixgbe_rx_scan_hw_ring(struct igb_rx_queue *rxq)
        }
 
        /* clear software ring entries so we can cleanup correctly */
-       for (i = 0; i < nb_rx; ++i)
+       for (i = 0; i < nb_rx; ++i) {
                rxq->sw_ring[rxq->rx_tail + i].mbuf = NULL;
+       }
+
 
        return nb_rx;
 }
@@ -841,7 +1121,8 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq)
        int diag, i;
 
        /* allocate buffers in bulk directly into the S/W ring */
-       alloc_idx = rxq->rx_free_trigger - (rxq->rx_free_thresh - 1);
+       alloc_idx = (uint16_t)(rxq->rx_free_trigger -
+                               (rxq->rx_free_thresh - 1));
        rxep = &rxq->sw_ring[alloc_idx];
        diag = rte_mempool_get_bulk(rxq->mb_pool, (void *)rxep,
                                    rxq->rx_free_thresh);
@@ -870,9 +1151,10 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq)
        IXGBE_PCI_REG_WRITE(rxq->rdt_reg_addr, rxq->rx_free_trigger);
 
        /* update state of internal queue structure */
-       rxq->rx_free_trigger += rxq->rx_free_thresh;
+       rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_trigger +
+                                               rxq->rx_free_thresh);
        if (rxq->rx_free_trigger >= rxq->nb_rx_desc)
-               rxq->rx_free_trigger = (rxq->rx_free_thresh - 1);
+               rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1);
 
        /* no errors */
        return 0;
@@ -886,15 +1168,15 @@ ixgbe_rx_fill_from_stage(struct igb_rx_queue *rxq, struct rte_mbuf **rx_pkts,
        int i;
 
        /* how many packets are ready to return? */
-       nb_pkts = RTE_MIN(nb_pkts, rxq->rx_nb_avail);
+       nb_pkts = (uint16_t)RTE_MIN(nb_pkts, rxq->rx_nb_avail);
 
        /* copy mbuf pointers to the application's packet list */
        for (i = 0; i < nb_pkts; ++i)
                rx_pkts[i] = stage[i];
 
        /* update internal queue state */
-       rxq->rx_nb_avail -= nb_pkts;
-       rxq->rx_next_avail += nb_pkts;
+       rxq->rx_nb_avail = (uint16_t)(rxq->rx_nb_avail - nb_pkts);
+       rxq->rx_next_avail = (uint16_t)(rxq->rx_next_avail + nb_pkts);
 
        return nb_pkts;
 }
@@ -911,12 +1193,12 @@ rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                return ixgbe_rx_fill_from_stage(rxq, rx_pkts, nb_pkts);
 
        /* Scan the H/W ring for packets to receive */
-       nb_rx = ixgbe_rx_scan_hw_ring(rxq);
+       nb_rx = (uint16_t)ixgbe_rx_scan_hw_ring(rxq);
 
        /* update internal queue state */
        rxq->rx_next_avail = 0;
        rxq->rx_nb_avail = nb_rx;
-       rxq->rx_tail += nb_rx;
+       rxq->rx_tail = (uint16_t)(rxq->rx_tail + nb_rx);
 
        /* if required, allocate new buffers to replenish descriptors */
        if (rxq->rx_tail > rxq->rx_free_trigger) {
@@ -934,7 +1216,7 @@ rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                         * allocate new buffers to replenish the old ones.
                         */
                        rxq->rx_nb_avail = 0;
-                       rxq->rx_tail -= nb_rx;
+                       rxq->rx_tail = (uint16_t)(rxq->rx_tail - nb_rx);
                        for (i = 0, j = rxq->rx_tail; i < nb_rx; ++i, ++j)
                                rxq->sw_ring[j].mbuf = rxq->rx_stage[i];
 
@@ -955,7 +1237,7 @@ rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 /* split requests into chunks of size RTE_PMD_IXGBE_RX_MAX_BURST */
 uint16_t
 ixgbe_recv_pkts_bulk_alloc(void *rx_queue, struct rte_mbuf **rx_pkts,
-               uint16_t nb_pkts)
+                          uint16_t nb_pkts)
 {
        uint16_t nb_rx;
 
@@ -969,10 +1251,10 @@ ixgbe_recv_pkts_bulk_alloc(void *rx_queue, struct rte_mbuf **rx_pkts,
        nb_rx = 0;
        while (nb_pkts) {
                uint16_t ret, n;
-               n = RTE_MIN(nb_pkts, RTE_PMD_IXGBE_RX_MAX_BURST);
+               n = (uint16_t)RTE_MIN(nb_pkts, RTE_PMD_IXGBE_RX_MAX_BURST);
                ret = rx_recv_pkts(rx_queue, &rx_pkts[nb_rx], n);
-               nb_rx += ret;
-               nb_pkts -= ret;
+               nb_rx = (uint16_t)(nb_rx + ret);
+               nb_pkts = (uint16_t)(nb_pkts - ret);
                if (ret < n)
                        break;
        }
@@ -1115,11 +1397,14 @@ ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 
                hlen_type_rss = rte_le_to_cpu_32(rxd.wb.lower.lo_dword.data);
                /* Only valid if PKT_RX_VLAN_PKT set in pkt_flags */
-               rxm->pkt.vlan_tci = rte_le_to_cpu_16(rxd.wb.upper.vlan);
+               rxm->pkt.vlan_macip.f.vlan_tci =
+                       rte_le_to_cpu_16(rxd.wb.upper.vlan);
 
                pkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(hlen_type_rss);
-               pkt_flags = (pkt_flags | rx_desc_status_to_pkt_flags(staterr));
-               pkt_flags = (pkt_flags | rx_desc_error_to_pkt_flags(staterr));
+               pkt_flags = (uint16_t)(pkt_flags |
+                               rx_desc_status_to_pkt_flags(staterr));
+               pkt_flags = (uint16_t)(pkt_flags |
+                               rx_desc_error_to_pkt_flags(staterr));
                rxm->ol_flags = pkt_flags;
 
                if (likely(pkt_flags & PKT_RX_RSS_HASH))
@@ -1357,14 +1642,14 @@ ixgbe_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
                 * The vlan_tci field is only valid when PKT_RX_VLAN_PKT is
                 * set in the pkt_flags field.
                 */
-               first_seg->pkt.vlan_tci =
+               first_seg->pkt.vlan_macip.f.vlan_tci =
                                rte_le_to_cpu_16(rxd.wb.upper.vlan);
                hlen_type_rss = rte_le_to_cpu_32(rxd.wb.lower.lo_dword.data);
                pkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(hlen_type_rss);
-               pkt_flags = (pkt_flags |
-                                       rx_desc_status_to_pkt_flags(staterr));
-               pkt_flags = (pkt_flags |
-                                       rx_desc_error_to_pkt_flags(staterr));
+               pkt_flags = (uint16_t)(pkt_flags |
+                               rx_desc_status_to_pkt_flags(staterr));
+               pkt_flags = (uint16_t)(pkt_flags |
+                               rx_desc_error_to_pkt_flags(staterr));
                first_seg->ol_flags = pkt_flags;
 
                if (likely(pkt_flags & PKT_RX_RSS_HASH))
@@ -1473,7 +1758,7 @@ ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
        if (mz)
                return mz;
 
-       return rte_memzone_reserve_aligned(z_name, (uint64_t) ring_size,
+       return rte_memzone_reserve_aligned(z_name, ring_size,
                        socket_id, 0, IXGBE_ALIGN);
 }
 
@@ -1496,9 +1781,9 @@ static void
 ixgbe_tx_queue_release(struct igb_tx_queue *txq)
 {
        if (txq != NULL) {
-       ixgbe_tx_queue_release_mbufs(txq);
-       rte_free(txq->sw_ring);
-       rte_free(txq);
+               ixgbe_tx_queue_release_mbufs(txq);
+               rte_free(txq->sw_ring);
+               rte_free(txq);
        }
 }
 
@@ -1531,6 +1816,9 @@ ixgbe_reset_tx_queue(struct igb_tx_queue *txq)
                prev = i;
        }
 
+       txq->tx_next_dd = (uint16_t)(txq->tx_rs_thresh - 1);
+       txq->tx_next_rs = (uint16_t)(txq->tx_rs_thresh - 1);
+
        txq->tx_tail = 0;
        txq->nb_tx_used = 0;
        /*
@@ -1583,41 +1871,45 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
         *  tx_rs_thresh must be greater than 0.
         *  tx_rs_thresh must be less than the size of the ring minus 2.
         *  tx_rs_thresh must be less than or equal to tx_free_thresh.
+        *  tx_rs_thresh must be a divisor of the ring size.
         *  tx_free_thresh must be greater than 0.
         *  tx_free_thresh must be less than the size of the ring minus 3.
         * One descriptor in the TX ring is used as a sentinel to avoid a
         * H/W race condition, hence the maximum threshold constraints.
         * When set to zero use default values.
         */
-       tx_rs_thresh = (tx_conf->tx_rs_thresh) ?
-                       tx_conf->tx_rs_thresh : DEFAULT_TX_RS_THRESH;
-       tx_free_thresh = (tx_conf->tx_free_thresh) ?
-                       tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH;
+       tx_rs_thresh = (uint16_t)((tx_conf->tx_rs_thresh) ?
+                       tx_conf->tx_rs_thresh : DEFAULT_TX_RS_THRESH);
+       tx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ?
+                       tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH);
        if (tx_rs_thresh >= (nb_desc - 2)) {
-               RTE_LOG(ERR, PMD,
-                            "tx_rs_thresh must be less than the "
-                            "number of TX descriptors minus 2. "
-                            "(tx_rs_thresh=%u port=%d queue=%d)",
-                            tx_rs_thresh, dev->data->port_id, queue_idx);
+               RTE_LOG(ERR, PMD, "tx_rs_thresh must be less than the number "
+                       "of TX descriptors minus 2. (tx_rs_thresh=%u port=%d "
+                               "queue=%d)\n", (unsigned int)tx_rs_thresh,
+                               (int)dev->data->port_id, (int)queue_idx);
                return -(EINVAL);
        }
        if (tx_free_thresh >= (nb_desc - 3)) {
-               RTE_LOG(ERR, PMD,
-                            "tx_rs_thresh must be less than the "
-                            "tx_free_thresh must be less than the "
-                            "number of TX descriptors minus 3. "
-                            "(tx_free_thresh=%u port=%d queue=%d)",
-                            tx_free_thresh, dev->data->port_id, queue_idx);
+               RTE_LOG(ERR, PMD, "tx_rs_thresh must be less than the "
+                       "tx_free_thresh must be less than the number of TX "
+                       "descriptors minus 3. (tx_free_thresh=%u port=%d "
+                               "queue=%d)\n", (unsigned int)tx_free_thresh,
+                               (int)dev->data->port_id, (int)queue_idx);
                return -(EINVAL);
        }
        if (tx_rs_thresh > tx_free_thresh) {
-               RTE_LOG(ERR, PMD,
-                            "tx_rs_thresh must be less than or equal to "
-                            "tx_free_thresh. "
-                            "(tx_free_thresh=%u tx_rs_thresh=%u "
-                            "port=%d queue=%d)",
-                            tx_free_thresh, tx_rs_thresh,
-                            dev->data->port_id, queue_idx);
+               RTE_LOG(ERR, PMD, "tx_rs_thresh must be less than or equal to "
+                       "tx_free_thresh. (tx_free_thresh=%u tx_rs_thresh=%u "
+                       "port=%d queue=%d)\n", (unsigned int)tx_free_thresh,
+                       (unsigned int)tx_rs_thresh, (int)dev->data->port_id,
+                                                       (int)queue_idx);
+               return -(EINVAL);
+       }
+       if ((nb_desc % tx_rs_thresh) != 0) {
+               RTE_LOG(ERR, PMD, "tx_rs_thresh must be a divisor of the "
+                       "number of TX descriptors. (tx_rs_thresh=%u port=%d "
+                               "queue=%d)\n", (unsigned int)tx_rs_thresh,
+                               (int)dev->data->port_id, (int)queue_idx);
                return -(EINVAL);
        }
 
@@ -1628,13 +1920,10 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
         * accumulates WTHRESH descriptors.
         */
        if ((tx_rs_thresh > 1) && (tx_conf->tx_thresh.wthresh != 0)) {
-               RTE_LOG(ERR, PMD,
-                            "TX WTHRESH should be set to 0 if "
-                            "tx_rs_thresh is greater than 1. "
-                            "TX WTHRESH will be set to 0. "
-                            "(tx_rs_thresh=%u port=%d queue=%d)",
-                            tx_rs_thresh,
-                            dev->data->port_id, queue_idx);
+               RTE_LOG(ERR, PMD, "TX WTHRESH must be set to 0 if "
+                       "tx_rs_thresh is greater than 1. (tx_rs_thresh=%u "
+                       "port=%d queue=%d)\n", (unsigned int)tx_rs_thresh,
+                               (int)dev->data->port_id, (int)queue_idx);
                return -(EINVAL);
        }
 
@@ -1643,8 +1932,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
                ixgbe_tx_queue_release(dev->data->tx_queues[queue_idx]);
 
        /* First allocate the tx queue data structure */
-       txq = rte_zmalloc("ethdev TX queue", sizeof(struct igb_tx_queue),
-                         CACHE_LINE_SIZE);
+       txq = rte_zmalloc_socket("ethdev TX queue", sizeof(struct igb_tx_queue),
+                                CACHE_LINE_SIZE, socket_id);
        if (txq == NULL)
                return (-ENOMEM);
 
@@ -1668,7 +1957,10 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
        txq->hthresh = tx_conf->tx_thresh.hthresh;
        txq->wthresh = tx_conf->tx_thresh.wthresh;
        txq->queue_id = queue_idx;
+       txq->reg_idx = (uint16_t)((RTE_ETH_DEV_SRIOV(dev).active == 0) ? 
+               queue_idx : RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx + queue_idx);
        txq->port_id = dev->data->port_id;
+       txq->txq_flags = tx_conf->txq_flags;
 
        /*
         * Modification to set VFTDT for virtual function if vf is detected
@@ -1676,15 +1968,15 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
        if (hw->mac.type == ixgbe_mac_82599_vf)
                txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
        else
-               txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(queue_idx));
+               txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
 
        txq->tx_ring_phys_addr = (uint64_t) tz->phys_addr;
        txq->tx_ring = (union ixgbe_adv_tx_desc *) tz->addr;
 
        /* Allocate software ring */
-       txq->sw_ring = rte_zmalloc("txq->sw_ring",
+       txq->sw_ring = rte_zmalloc_socket("txq->sw_ring",
                                   sizeof(struct igb_tx_entry) * nb_desc,
-                                  CACHE_LINE_SIZE);
+                                  CACHE_LINE_SIZE, socket_id);
        if (txq->sw_ring == NULL) {
                ixgbe_tx_queue_release(txq);
                return (-ENOMEM);
@@ -1696,7 +1988,17 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
 
        dev->data->tx_queues[queue_idx] = txq;
 
-       dev->tx_pkt_burst = ixgbe_xmit_pkts;
+       /* Use a simple Tx queue (no offloads, no multi segs) if possible */
+       if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS) &&
+           (txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST)) {
+               PMD_INIT_LOG(INFO, "Using simple tx code path\n");
+               dev->tx_pkt_burst = ixgbe_xmit_pkts_simple;
+       } else {
+               PMD_INIT_LOG(INFO, "Using full-featured tx code path\n");
+               PMD_INIT_LOG(INFO, " - txq_flags = %lx [IXGBE_SIMPLE_FLAGS=%lx]\n", (long unsigned)txq->txq_flags, (long unsigned)IXGBE_SIMPLE_FLAGS);
+               PMD_INIT_LOG(INFO, " - tx_rs_thresh = %lu [RTE_PMD_IXGBE_TX_MAX_BURST=%lu]\n", (long unsigned)txq->tx_rs_thresh, (long unsigned)RTE_PMD_IXGBE_TX_MAX_BURST);
+               dev->tx_pkt_burst = ixgbe_xmit_pkts;
+       }
 
        return (0);
 }
@@ -1729,9 +2031,11 @@ ixgbe_rx_queue_release_mbufs(struct igb_rx_queue *rxq)
 static void
 ixgbe_rx_queue_release(struct igb_rx_queue *rxq)
 {
-       ixgbe_rx_queue_release_mbufs(rxq);
-       rte_free(rxq->sw_ring);
-       rte_free(rxq);
+       if (rxq != NULL) {
+               ixgbe_rx_queue_release_mbufs(rxq);
+               rte_free(rxq->sw_ring);
+               rte_free(rxq);
+       }
 }
 
 void
@@ -1749,7 +2053,11 @@ ixgbe_dev_rx_queue_release(void *rxq)
  *           function must be used.
  */
 static inline int
+#ifdef RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC
 check_rx_burst_bulk_alloc_preconditions(struct igb_rx_queue *rxq)
+#else
+check_rx_burst_bulk_alloc_preconditions(__rte_unused struct igb_rx_queue *rxq)
+#endif
 {
        int ret = 0;
 
@@ -1779,11 +2087,12 @@ check_rx_burst_bulk_alloc_preconditions(struct igb_rx_queue *rxq)
        return ret;
 }
 
-/* (Re)set dynamic igb_rx_queue fields to defaults */
+/* Reset dynamic igb_rx_queue fields back to defaults */
 static void
 ixgbe_reset_rx_queue(struct igb_rx_queue *rxq)
 {
        unsigned i;
+       uint16_t len;
 
        /*
         * By default, the Rx queue setup function allocates enough memory for
@@ -1798,7 +2107,7 @@ ixgbe_reset_rx_queue(struct igb_rx_queue *rxq)
 #ifdef RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC
        if (check_rx_burst_bulk_alloc_preconditions(rxq) == 0)
                /* zero out extra memory */
-               len = rxq->nb_rx_desc + RTE_PMD_IXGBE_RX_MAX_BURST;
+               len = (uint16_t)(rxq->nb_rx_desc + RTE_PMD_IXGBE_RX_MAX_BURST);
        else
 #endif
                /* do not zero out extra memory */
@@ -1825,7 +2134,7 @@ ixgbe_reset_rx_queue(struct igb_rx_queue *rxq)
 
        rxq->rx_nb_avail = 0;
        rxq->rx_next_avail = 0;
-       rxq->rx_free_trigger = rxq->rx_free_thresh - 1;
+       rxq->rx_free_trigger = (uint16_t)(rxq->rx_free_thresh - 1);
 #endif /* RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC */
        rxq->rx_tail = 0;
        rxq->nb_rx_hold = 0;
@@ -1844,6 +2153,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
        const struct rte_memzone *rz;
        struct igb_rx_queue *rxq;
        struct ixgbe_hw     *hw;
+       int use_def_burst_func = 1;
+       uint16_t len;
 
        PMD_INIT_FUNC_TRACE();
        hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1864,20 +2175,23 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
                ixgbe_rx_queue_release(dev->data->rx_queues[queue_idx]);
 
        /* First allocate the rx queue data structure */
-       rxq = rte_zmalloc("ethdev RX queue", sizeof(struct igb_rx_queue),
-                         CACHE_LINE_SIZE);
+       rxq = rte_zmalloc_socket("ethdev RX queue", sizeof(struct igb_rx_queue),
+                                CACHE_LINE_SIZE, socket_id);
        if (rxq == NULL)
                return (-ENOMEM);
        rxq->mb_pool = mp;
        rxq->nb_rx_desc = nb_desc;
        rxq->rx_free_thresh = rx_conf->rx_free_thresh;
        rxq->queue_id = queue_idx;
+       rxq->reg_idx = (uint16_t)((RTE_ETH_DEV_SRIOV(dev).active == 0) ? 
+               queue_idx : RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx + queue_idx);
        rxq->port_id = dev->data->port_id;
-       rxq->crc_len = (uint8_t) ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 :
-                                 ETHER_CRC_LEN);
+       rxq->crc_len = (uint8_t) ((dev->data->dev_conf.rxmode.hw_strip_crc) ?
+                                                       0 : ETHER_CRC_LEN);
+       rxq->drop_en = rx_conf->rx_drop_en;
 
        /*
-        * Allocate TX ring hardware descriptors. A memzone large enough to
+        * Allocate RX ring hardware descriptors. A memzone large enough to
         * handle the maximum ring size is allocated in order to allow for
         * resizing in later calls to the queue setup function.
         */
@@ -1891,10 +2205,18 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
        /*
         * Modified to setup VFRDT for Virtual Function
         */
-       if (hw->mac.type == ixgbe_mac_82599_vf)
-               rxq->rdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
-       else
-               rxq->rdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_RDT(queue_idx));
+       if (hw->mac.type == ixgbe_mac_82599_vf) {
+               rxq->rdt_reg_addr =
+                       IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
+               rxq->rdh_reg_addr =
+                       IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDH(queue_idx));
+       }
+       else {
+               rxq->rdt_reg_addr =
+                       IXGBE_PCI_REG_ADDR(hw, IXGBE_RDT(rxq->reg_idx));
+               rxq->rdh_reg_addr =
+                       IXGBE_PCI_REG_ADDR(hw, IXGBE_RDH(rxq->reg_idx));
+       }
 
        rxq->rx_ring_phys_addr = (uint64_t) rz->phys_addr;
        rxq->rx_ring = (union ixgbe_adv_rx_desc *) rz->addr;
@@ -1905,13 +2227,13 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
         * function does not access an invalid memory region.
         */
 #ifdef RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC
-       len = nb_desc + RTE_PMD_IXGBE_RX_MAX_BURST;
+       len = (uint16_t)(nb_desc + RTE_PMD_IXGBE_RX_MAX_BURST);
 #else
        len = nb_desc;
 #endif
-       rxq->sw_ring = rte_zmalloc("rxq->sw_ring",
-                                  sizeof(struct igb_rx_entry) * nb_desc,
-                                  CACHE_LINE_SIZE);
+       rxq->sw_ring = rte_zmalloc_socket("rxq->sw_ring",
+                                         sizeof(struct igb_rx_entry) * len,
+                                         CACHE_LINE_SIZE, socket_id);
        if (rxq->sw_ring == NULL) {
                ixgbe_rx_queue_release(rxq);
                return (-ENOMEM);
@@ -1948,22 +2270,72 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
        return 0;
 }
 
+uint32_t
+ixgbe_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
+{
+#define IXGBE_RXQ_SCAN_INTERVAL 4
+       volatile union ixgbe_adv_rx_desc *rxdp;
+       struct igb_rx_queue *rxq;
+       uint32_t desc = 0;
+
+       if (rx_queue_id >= dev->data->nb_rx_queues) {
+               PMD_RX_LOG(ERR, "Invalid RX queue id=%d\n", rx_queue_id);
+               return 0;
+       }
+
+       rxq = dev->data->rx_queues[rx_queue_id];
+       rxdp = &(rxq->rx_ring[rxq->rx_tail]);
+
+       while ((desc < rxq->nb_rx_desc) &&
+               (rxdp->wb.upper.status_error & IXGBE_RXDADV_STAT_DD)) {
+               desc += IXGBE_RXQ_SCAN_INTERVAL;
+               rxdp += IXGBE_RXQ_SCAN_INTERVAL;
+               if (rxq->rx_tail + desc >= rxq->nb_rx_desc)
+                       rxdp = &(rxq->rx_ring[rxq->rx_tail +
+                               desc - rxq->nb_rx_desc]);
+       }
+
+       return desc;
+}
+
+int
+ixgbe_dev_rx_descriptor_done(void *rx_queue, uint16_t offset)
+{
+       volatile union ixgbe_adv_rx_desc *rxdp;
+       struct igb_rx_queue *rxq = rx_queue;
+       uint32_t desc;
+
+       if (unlikely(offset >= rxq->nb_rx_desc))
+               return 0;
+       desc = rxq->rx_tail + offset;
+       if (desc >= rxq->nb_rx_desc)
+               desc -= rxq->nb_rx_desc;
+
+       rxdp = &rxq->rx_ring[desc];
+       return !!(rxdp->wb.upper.status_error & IXGBE_RXDADV_STAT_DD);
+}
+
 void
 ixgbe_dev_clear_queues(struct rte_eth_dev *dev)
 {
        unsigned i;
 
+       PMD_INIT_FUNC_TRACE();
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                struct igb_tx_queue *txq = dev->data->tx_queues[i];
-               ixgbe_tx_queue_release_mbufs(txq);
-               ixgbe_reset_tx_queue(txq);
+               if (txq != NULL) {
+                       ixgbe_tx_queue_release_mbufs(txq);
+                       ixgbe_reset_tx_queue(txq);
+               }
        }
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                struct igb_rx_queue *rxq = dev->data->rx_queues[i];
-               ixgbe_rx_queue_release_mbufs(rxq);
-               ixgbe_reset_rx_queue(rxq);
+               if (rxq != NULL) {
+                       ixgbe_rx_queue_release_mbufs(rxq);
+                       ixgbe_reset_rx_queue(rxq);
+               }
        }
 }
 
@@ -2138,6 +2510,7 @@ ixgbe_vmdq_dcb_configure(struct rte_eth_dev *dev)
        } else {
                vt_ctl |= IXGBE_VT_CTL_DIS_DEFPL;
        }
+
        IXGBE_WRITE_REG(hw, IXGBE_VT_CTL, vt_ctl);
 
        /* RTRUP2TC: mapping user priorities to traffic classes (TCs) */
@@ -2189,6 +2562,492 @@ ixgbe_vmdq_dcb_configure(struct rte_eth_dev *dev)
        }
 }
 
+/**
+ * ixgbe_dcb_config_tx_hw_config - Configure general DCB TX parameters
+ * @hw: pointer to hardware structure
+ * @dcb_config: pointer to ixgbe_dcb_config structure
+ */
+static void 
+ixgbe_dcb_tx_hw_config(struct ixgbe_hw *hw,
+               struct ixgbe_dcb_config *dcb_config)
+{
+       uint32_t reg;
+       uint32_t q;
+       
+       PMD_INIT_FUNC_TRACE();
+       if (hw->mac.type != ixgbe_mac_82598EB) {
+               /* Disable the Tx desc arbiter so that MTQC can be changed */
+               reg = IXGBE_READ_REG(hw, IXGBE_RTTDCS);
+               reg |= IXGBE_RTTDCS_ARBDIS;
+               IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, reg);
+
+               /* Enable DCB for Tx with 8 TCs */
+               if (dcb_config->num_tcs.pg_tcs == 8) {
+                       reg = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_8TC_8TQ;
+               }
+               else {
+                       reg = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_4TC_4TQ;
+               }
+               if (dcb_config->vt_mode)
+                   reg |= IXGBE_MTQC_VT_ENA;
+               IXGBE_WRITE_REG(hw, IXGBE_MTQC, reg);
+
+               /* Disable drop for all queues */
+               for (q = 0; q < 128; q++)
+                       IXGBE_WRITE_REG(hw, IXGBE_QDE,
+                    (IXGBE_QDE_WRITE | (q << IXGBE_QDE_IDX_SHIFT)));
+
+               /* Enable the Tx desc arbiter */
+               reg = IXGBE_READ_REG(hw, IXGBE_RTTDCS);
+               reg &= ~IXGBE_RTTDCS_ARBDIS;
+               IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, reg);
+
+               /* Enable Security TX Buffer IFG for DCB */
+               reg = IXGBE_READ_REG(hw, IXGBE_SECTXMINIFG);
+               reg |= IXGBE_SECTX_DCB;
+               IXGBE_WRITE_REG(hw, IXGBE_SECTXMINIFG, reg);
+       }
+       return;
+}
+
+/**
+ * ixgbe_vmdq_dcb_hw_tx_config - Configure general VMDQ+DCB TX parameters
+ * @dev: pointer to rte_eth_dev structure
+ * @dcb_config: pointer to ixgbe_dcb_config structure
+ */
+static void
+ixgbe_vmdq_dcb_hw_tx_config(struct rte_eth_dev *dev,
+                       struct ixgbe_dcb_config *dcb_config)
+{
+       struct rte_eth_vmdq_dcb_tx_conf *vmdq_tx_conf =
+                       &dev->data->dev_conf.tx_adv_conf.vmdq_dcb_tx_conf;
+       struct ixgbe_hw *hw = 
+                       IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       
+       PMD_INIT_FUNC_TRACE();
+       if (hw->mac.type != ixgbe_mac_82598EB)  
+               /*PF VF Transmit Enable*/
+               IXGBE_WRITE_REG(hw, IXGBE_VFTE(0),
+                       vmdq_tx_conf->nb_queue_pools == ETH_16_POOLS ? 0xFFFF : 0xFFFFFFFF);
+    
+       /*Configure general DCB TX parameters*/
+       ixgbe_dcb_tx_hw_config(hw,dcb_config);
+       return;
+}
+
+static void 
+ixgbe_vmdq_dcb_rx_config(struct rte_eth_dev *dev,
+                        struct ixgbe_dcb_config *dcb_config)
+{
+       struct rte_eth_vmdq_dcb_conf *vmdq_rx_conf =
+                       &dev->data->dev_conf.rx_adv_conf.vmdq_dcb_conf;
+       struct ixgbe_dcb_tc_config *tc;
+       uint8_t i,j;
+
+       /* convert rte_eth_conf.rx_adv_conf to struct ixgbe_dcb_config */
+       if (vmdq_rx_conf->nb_queue_pools == ETH_16_POOLS ) {
+               dcb_config->num_tcs.pg_tcs = ETH_8_TCS;
+               dcb_config->num_tcs.pfc_tcs = ETH_8_TCS;
+       }
+       else {
+               dcb_config->num_tcs.pg_tcs = ETH_4_TCS;
+               dcb_config->num_tcs.pfc_tcs = ETH_4_TCS;
+       }
+       /* User Priority to Traffic Class mapping */
+       for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+               j = vmdq_rx_conf->dcb_queue[i];
+               tc = &dcb_config->tc_config[j];
+               tc->path[IXGBE_DCB_RX_CONFIG].up_to_tc_bitmap =
+                                               (uint8_t)(1 << j);
+       }
+}
+
+static void 
+ixgbe_dcb_vt_tx_config(struct rte_eth_dev *dev,
+                        struct ixgbe_dcb_config *dcb_config)
+{ 
+       struct rte_eth_vmdq_dcb_tx_conf *vmdq_tx_conf =
+                       &dev->data->dev_conf.tx_adv_conf.vmdq_dcb_tx_conf;
+       struct ixgbe_dcb_tc_config *tc;
+       uint8_t i,j;
+       
+       /* convert rte_eth_conf.rx_adv_conf to struct ixgbe_dcb_config */
+       if (vmdq_tx_conf->nb_queue_pools == ETH_16_POOLS ) {
+               dcb_config->num_tcs.pg_tcs = ETH_8_TCS;
+               dcb_config->num_tcs.pfc_tcs = ETH_8_TCS;
+       }
+       else {
+               dcb_config->num_tcs.pg_tcs = ETH_4_TCS;
+               dcb_config->num_tcs.pfc_tcs = ETH_4_TCS;
+       }
+
+       /* User Priority to Traffic Class mapping */
+       for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+               j = vmdq_tx_conf->dcb_queue[i];
+               tc = &dcb_config->tc_config[j];
+               tc->path[IXGBE_DCB_TX_CONFIG].up_to_tc_bitmap =
+                                               (uint8_t)(1 << j);
+       }
+       return;
+}
+
+static void 
+ixgbe_dcb_rx_config(struct rte_eth_dev *dev,
+               struct ixgbe_dcb_config *dcb_config)
+{
+       struct rte_eth_dcb_rx_conf *rx_conf =
+                       &dev->data->dev_conf.rx_adv_conf.dcb_rx_conf;
+       struct ixgbe_dcb_tc_config *tc;
+       uint8_t i,j;
+
+       dcb_config->num_tcs.pg_tcs = (uint8_t)rx_conf->nb_tcs;
+       dcb_config->num_tcs.pfc_tcs = (uint8_t)rx_conf->nb_tcs;
+       
+       /* User Priority to Traffic Class mapping */ 
+       for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+               j = rx_conf->dcb_queue[i];
+               tc = &dcb_config->tc_config[j];
+               tc->path[IXGBE_DCB_RX_CONFIG].up_to_tc_bitmap =
+                                               (uint8_t)(1 << j);
+       }
+}
+
+static void 
+ixgbe_dcb_tx_config(struct rte_eth_dev *dev,
+               struct ixgbe_dcb_config *dcb_config)
+{
+       struct rte_eth_dcb_tx_conf *tx_conf =
+                       &dev->data->dev_conf.tx_adv_conf.dcb_tx_conf;
+       struct ixgbe_dcb_tc_config *tc;
+       uint8_t i,j;
+
+       dcb_config->num_tcs.pg_tcs = (uint8_t)tx_conf->nb_tcs;
+       dcb_config->num_tcs.pfc_tcs = (uint8_t)tx_conf->nb_tcs;
+    
+       /* User Priority to Traffic Class mapping */ 
+       for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+               j = tx_conf->dcb_queue[i];
+               tc = &dcb_config->tc_config[j];
+               tc->path[IXGBE_DCB_TX_CONFIG].up_to_tc_bitmap =
+                                               (uint8_t)(1 << j);
+       }
+}
+
+/**
+ * ixgbe_dcb_rx_hw_config - Configure general DCB RX HW parameters
+ * @hw: pointer to hardware structure
+ * @dcb_config: pointer to ixgbe_dcb_config structure
+ */
+static void
+ixgbe_dcb_rx_hw_config(struct ixgbe_hw *hw,
+               struct ixgbe_dcb_config *dcb_config)
+{
+       uint32_t reg;
+       uint32_t vlanctrl;
+       uint8_t i;
+
+       PMD_INIT_FUNC_TRACE();
+       /*
+        * Disable the arbiter before changing parameters
+        * (always enable recycle mode; WSP)
+        */
+       reg = IXGBE_RTRPCS_RRM | IXGBE_RTRPCS_RAC | IXGBE_RTRPCS_ARBDIS;
+       IXGBE_WRITE_REG(hw, IXGBE_RTRPCS, reg);
+
+       if (hw->mac.type != ixgbe_mac_82598EB) {
+               reg = IXGBE_READ_REG(hw, IXGBE_MRQC);
+               if (dcb_config->num_tcs.pg_tcs == 4) {
+                       if (dcb_config->vt_mode)
+                               reg = (reg & ~IXGBE_MRQC_MRQE_MASK) |
+                                       IXGBE_MRQC_VMDQRT4TCEN;
+                       else {
+                               IXGBE_WRITE_REG(hw, IXGBE_VT_CTL, 0);
+                               reg = (reg & ~IXGBE_MRQC_MRQE_MASK) |
+                                       IXGBE_MRQC_RT4TCEN;
+                       }
+               }
+               if (dcb_config->num_tcs.pg_tcs == 8) {
+                       if (dcb_config->vt_mode)
+                               reg = (reg & ~IXGBE_MRQC_MRQE_MASK) |
+                                       IXGBE_MRQC_VMDQRT8TCEN;
+                       else {
+                               IXGBE_WRITE_REG(hw, IXGBE_VT_CTL, 0);
+                               reg = (reg & ~IXGBE_MRQC_MRQE_MASK) |
+                                       IXGBE_MRQC_RT8TCEN;
+                       }
+               }
+
+               IXGBE_WRITE_REG(hw, IXGBE_MRQC, reg);
+       }
+
+       /* VLNCTRL: enable vlan filtering and allow all vlan tags through */
+       vlanctrl = IXGBE_READ_REG(hw, IXGBE_VLNCTRL);
+       vlanctrl |= IXGBE_VLNCTRL_VFE ; /* enable vlan filters */
+       IXGBE_WRITE_REG(hw, IXGBE_VLNCTRL, vlanctrl);
+       /* VFTA - enable all vlan filters */
+       for (i = 0; i < NUM_VFTA_REGISTERS; i++) {
+               IXGBE_WRITE_REG(hw, IXGBE_VFTA(i), 0xFFFFFFFF);
+       }
+
+       /*
+        * Configure Rx packet plane (recycle mode; WSP) and
+        * enable arbiter
+        */
+       reg = IXGBE_RTRPCS_RRM | IXGBE_RTRPCS_RAC;
+       IXGBE_WRITE_REG(hw, IXGBE_RTRPCS, reg);
+       return;
+}
+
+static void 
+ixgbe_dcb_hw_arbite_rx_config(struct ixgbe_hw *hw, uint16_t *refill,
+                       uint16_t *max,uint8_t *bwg_id, uint8_t *tsa, uint8_t *map)
+{
+       switch (hw->mac.type) {
+       case ixgbe_mac_82598EB:
+               ixgbe_dcb_config_rx_arbiter_82598(hw, refill, max, tsa);
+               break;
+       case ixgbe_mac_82599EB:
+       case ixgbe_mac_X540:
+               ixgbe_dcb_config_rx_arbiter_82599(hw, refill, max, bwg_id,
+                                                 tsa, map);
+               break;
+       default:
+               break;
+       }
+}
+
+static void 
+ixgbe_dcb_hw_arbite_tx_config(struct ixgbe_hw *hw, uint16_t *refill, uint16_t *max,
+                           uint8_t *bwg_id, uint8_t *tsa, uint8_t *map)
+{
+       switch (hw->mac.type) {
+       case ixgbe_mac_82598EB:
+               ixgbe_dcb_config_tx_desc_arbiter_82598(hw, refill, max, bwg_id,tsa);
+               ixgbe_dcb_config_tx_data_arbiter_82598(hw, refill, max, bwg_id,tsa);
+               break;
+       case ixgbe_mac_82599EB:
+       case ixgbe_mac_X540:
+               ixgbe_dcb_config_tx_desc_arbiter_82599(hw, refill, max, bwg_id,tsa);
+               ixgbe_dcb_config_tx_data_arbiter_82599(hw, refill, max, bwg_id,tsa, map);
+               break;
+       default:
+               break;
+       }
+}
+
+#define DCB_RX_CONFIG  1
+#define DCB_TX_CONFIG  1
+#define DCB_TX_PB      1024
+/**
+ * ixgbe_dcb_hw_configure - Enable DCB and configure 
+ * general DCB in VT mode and non-VT mode parameters
+ * @dev: pointer to rte_eth_dev structure
+ * @dcb_config: pointer to ixgbe_dcb_config structure
+ */
+static int
+ixgbe_dcb_hw_configure(struct rte_eth_dev *dev,
+                       struct ixgbe_dcb_config *dcb_config)
+{
+       int     ret = 0;
+       uint8_t i,pfc_en,nb_tcs;
+       uint16_t pbsize;
+       uint8_t config_dcb_rx = 0;
+       uint8_t config_dcb_tx = 0;
+       uint8_t tsa[IXGBE_DCB_MAX_TRAFFIC_CLASS] = {0};
+       uint8_t bwgid[IXGBE_DCB_MAX_TRAFFIC_CLASS] = {0};
+       uint16_t refill[IXGBE_DCB_MAX_TRAFFIC_CLASS] = {0};
+       uint16_t max[IXGBE_DCB_MAX_TRAFFIC_CLASS] = {0};
+       uint8_t map[IXGBE_DCB_MAX_TRAFFIC_CLASS] = {0};
+       struct ixgbe_dcb_tc_config *tc;
+       uint32_t max_frame = dev->data->max_frame_size;
+       struct ixgbe_hw *hw = 
+                       IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       switch(dev->data->dev_conf.rxmode.mq_mode){
+       case ETH_MQ_RX_VMDQ_DCB:
+               dcb_config->vt_mode = true;
+               if (hw->mac.type != ixgbe_mac_82598EB) {
+                       config_dcb_rx = DCB_RX_CONFIG;
+                       /*
+                        *get dcb and VT rx configuration parameters 
+                        *from rte_eth_conf
+                        */
+                       ixgbe_vmdq_dcb_rx_config(dev,dcb_config);
+                       /*Configure general VMDQ and DCB RX parameters*/
+                       ixgbe_vmdq_dcb_configure(dev);
+               }
+               break;
+       case ETH_MQ_RX_DCB:
+               dcb_config->vt_mode = false;
+               config_dcb_rx = DCB_RX_CONFIG;
+               /* Get dcb TX configuration parameters from rte_eth_conf */
+               ixgbe_dcb_rx_config(dev,dcb_config);
+               /*Configure general DCB RX parameters*/
+               ixgbe_dcb_rx_hw_config(hw, dcb_config);
+               break;
+       default:
+               PMD_INIT_LOG(ERR, "Incorrect DCB RX mode configuration\n");
+               break;
+       }
+       switch (dev->data->dev_conf.txmode.mq_mode) {
+       case ETH_MQ_TX_VMDQ_DCB:
+               dcb_config->vt_mode = true;
+               config_dcb_tx = DCB_TX_CONFIG;
+               /* get DCB and VT TX configuration parameters from rte_eth_conf */
+               ixgbe_dcb_vt_tx_config(dev,dcb_config);
+               /*Configure general VMDQ and DCB TX parameters*/
+               ixgbe_vmdq_dcb_hw_tx_config(dev,dcb_config);
+               break;
+
+       case ETH_MQ_TX_DCB:
+               dcb_config->vt_mode = false;
+               config_dcb_tx = DCB_TX_CONFIG;
+               /*get DCB TX configuration parameters from rte_eth_conf*/
+               ixgbe_dcb_tx_config(dev,dcb_config);
+               /*Configure general DCB TX parameters*/
+               ixgbe_dcb_tx_hw_config(hw, dcb_config);
+               break;
+       default:
+               PMD_INIT_LOG(ERR, "Incorrect DCB TX mode configuration\n");
+               break;
+       }
+
+       nb_tcs = dcb_config->num_tcs.pfc_tcs;
+       /* Unpack map */
+       ixgbe_dcb_unpack_map_cee(dcb_config, IXGBE_DCB_RX_CONFIG, map);
+       if(nb_tcs == ETH_4_TCS) {
+               /* Avoid un-configured priority mapping to TC0 */
+               uint8_t j = 4;
+               uint8_t mask = 0xFF;
+               for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES - 4; i++) 
+                       mask = (uint8_t)(mask & (~ (1 << map[i])));
+               for (i = 0; mask && (i < IXGBE_DCB_MAX_TRAFFIC_CLASS); i++) {
+                       if ((mask & 0x1) && (j < ETH_DCB_NUM_USER_PRIORITIES))
+                               map[j++] = i;
+                       mask >>= 1;
+               }
+               /* Re-configure 4 TCs BW */
+               for (i = 0; i < nb_tcs; i++) {
+                       tc = &dcb_config->tc_config[i];
+                       tc->path[IXGBE_DCB_TX_CONFIG].bwg_percent =
+                                               (uint8_t)(100 / nb_tcs);
+                       tc->path[IXGBE_DCB_RX_CONFIG].bwg_percent =
+                                               (uint8_t)(100 / nb_tcs);
+               }
+               for (; i < IXGBE_DCB_MAX_TRAFFIC_CLASS; i++) {
+                       tc = &dcb_config->tc_config[i];
+                       tc->path[IXGBE_DCB_TX_CONFIG].bwg_percent = 0;
+                       tc->path[IXGBE_DCB_RX_CONFIG].bwg_percent = 0;
+               }
+       }
+
+       if(config_dcb_rx) {
+               /* Set RX buffer size */
+               pbsize = (uint16_t)(NIC_RX_BUFFER_SIZE / nb_tcs);
+               uint32_t rxpbsize = pbsize << IXGBE_RXPBSIZE_SHIFT;
+               for (i = 0 ; i < nb_tcs; i++) {
+                       IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), rxpbsize);
+               }
+               /* zero alloc all unused TCs */
+               for (; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+                       IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), 0);
+               }
+       }
+       if(config_dcb_tx) {
+               /* Only support an equally distributed Tx packet buffer strategy. */
+               uint32_t txpktsize = IXGBE_TXPBSIZE_MAX / nb_tcs;
+               uint32_t txpbthresh = (txpktsize / DCB_TX_PB) - IXGBE_TXPKT_SIZE_MAX;
+               for (i = 0; i < nb_tcs; i++) {
+                       IXGBE_WRITE_REG(hw, IXGBE_TXPBSIZE(i), txpktsize);
+                       IXGBE_WRITE_REG(hw, IXGBE_TXPBTHRESH(i), txpbthresh);
+               }
+               /* Clear unused TCs, if any, to zero buffer size*/
+               for (; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+                       IXGBE_WRITE_REG(hw, IXGBE_TXPBSIZE(i), 0);
+                       IXGBE_WRITE_REG(hw, IXGBE_TXPBTHRESH(i), 0);
+               }
+       }
+
+       /*Calculates traffic class credits*/
+       ixgbe_dcb_calculate_tc_credits_cee(hw, dcb_config,max_frame,
+                               IXGBE_DCB_TX_CONFIG);
+       ixgbe_dcb_calculate_tc_credits_cee(hw, dcb_config,max_frame,
+                               IXGBE_DCB_RX_CONFIG);
+
+       if(config_dcb_rx) {
+               /* Unpack CEE standard containers */
+               ixgbe_dcb_unpack_refill_cee(dcb_config, IXGBE_DCB_RX_CONFIG, refill);
+               ixgbe_dcb_unpack_max_cee(dcb_config, max);
+               ixgbe_dcb_unpack_bwgid_cee(dcb_config, IXGBE_DCB_RX_CONFIG, bwgid);
+               ixgbe_dcb_unpack_tsa_cee(dcb_config, IXGBE_DCB_RX_CONFIG, tsa);
+               /* Configure PG(ETS) RX */
+               ixgbe_dcb_hw_arbite_rx_config(hw,refill,max,bwgid,tsa,map);
+       }
+
+       if(config_dcb_tx) {
+               /* Unpack CEE standard containers */
+               ixgbe_dcb_unpack_refill_cee(dcb_config, IXGBE_DCB_TX_CONFIG, refill);
+               ixgbe_dcb_unpack_max_cee(dcb_config, max);
+               ixgbe_dcb_unpack_bwgid_cee(dcb_config, IXGBE_DCB_TX_CONFIG, bwgid);
+               ixgbe_dcb_unpack_tsa_cee(dcb_config, IXGBE_DCB_TX_CONFIG, tsa);
+               /* Configure PG(ETS) TX */
+               ixgbe_dcb_hw_arbite_tx_config(hw,refill,max,bwgid,tsa,map);
+       }
+
+       /*Configure queue statistics registers*/
+       ixgbe_dcb_config_tc_stats_82599(hw, dcb_config);
+
+       /* Check if the PFC is supported */
+       if(dev->data->dev_conf.dcb_capability_en & ETH_DCB_PFC_SUPPORT) {
+               pbsize = (uint16_t) (NIC_RX_BUFFER_SIZE / nb_tcs);
+               for (i = 0; i < nb_tcs; i++) {
+                       /*
+                       * If the TC count is 8,and the default high_water is 48,
+                       * the low_water is 16 as default.
+                       */
+                       hw->fc.high_water[i] = (pbsize * 3 ) / 4;
+                       hw->fc.low_water[i] = pbsize / 4;
+                       /* Enable pfc for this TC */
+                       tc = &dcb_config->tc_config[i];
+                       tc->pfc = ixgbe_dcb_pfc_enabled;
+               }
+               ixgbe_dcb_unpack_pfc_cee(dcb_config, map, &pfc_en);
+               if(dcb_config->num_tcs.pfc_tcs == ETH_4_TCS)
+                       pfc_en &= 0x0F;
+               ret = ixgbe_dcb_config_pfc(hw, pfc_en, map);
+       }
+
+       return ret;
+}
+
+/**
+ * ixgbe_configure_dcb - Configure DCB  Hardware
+ * @dev: pointer to rte_eth_dev
+ */
+void ixgbe_configure_dcb(struct rte_eth_dev *dev)
+{
+       struct ixgbe_dcb_config *dcb_cfg =
+                       IXGBE_DEV_PRIVATE_TO_DCB_CFG(dev->data->dev_private); 
+       struct rte_eth_conf *dev_conf = &(dev->data->dev_conf);
+       
+       PMD_INIT_FUNC_TRACE();  
+       
+       /* check support mq_mode for DCB */
+       if ((dev_conf->rxmode.mq_mode != ETH_MQ_RX_VMDQ_DCB) && 
+           (dev_conf->rxmode.mq_mode != ETH_MQ_RX_DCB)) 
+               return;
+
+       if (dev->data->nb_rx_queues != ETH_DCB_NUM_QUEUES)
+               return;
+
+       /** Configure DCB hardware **/
+       ixgbe_dcb_hw_configure(dev,dcb_cfg);
+       
+       return;
+}
+
 static int
 ixgbe_alloc_rx_queue_mbufs(struct igb_rx_queue *rxq)
 {
@@ -2205,6 +3064,14 @@ ixgbe_alloc_rx_queue_mbufs(struct igb_rx_queue *rxq)
                                     (unsigned) rxq->queue_id);
                        return (-ENOMEM);
                }
+
+               rte_mbuf_refcnt_set(mbuf, 1);
+               mbuf->type = RTE_MBUF_PKT;
+               mbuf->pkt.next = NULL;
+               mbuf->pkt.data = (char *)mbuf->buf_addr + RTE_PKTMBUF_HEADROOM;
+               mbuf->pkt.nb_segs = 1;
+               mbuf->pkt.in_port = rxq->port_id;
+
                dma_addr =
                        rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mbuf));
                rxd = &rxq->rx_ring[i];
@@ -2216,6 +3083,115 @@ ixgbe_alloc_rx_queue_mbufs(struct igb_rx_queue *rxq)
        return 0;
 }
 
+static int
+ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
+{
+       struct ixgbe_hw *hw = 
+               IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (hw->mac.type == ixgbe_mac_82598EB)
+               return 0;
+
+       if (RTE_ETH_DEV_SRIOV(dev).active == 0) {
+               /* 
+                * SRIOV inactive scheme
+                * any DCB/RSS w/o VMDq multi-queue setting
+                */
+               if (dev->data->nb_rx_queues > 1)
+                       switch (dev->data->dev_conf.rxmode.mq_mode) {
+                       case ETH_MQ_RX_NONE:
+                               /* if mq_mode not assign, we use rss mode.*/
+                       case ETH_MQ_RX_RSS:
+                               ixgbe_rss_configure(dev);
+                               break;
+
+                       case ETH_MQ_RX_VMDQ_DCB:
+                               ixgbe_vmdq_dcb_configure(dev);
+                               break;
+                               
+                       default: ixgbe_rss_disable(dev);
+                       }
+               else
+                       ixgbe_rss_disable(dev);
+       } else {
+               switch (RTE_ETH_DEV_SRIOV(dev).active) {
+               /*
+                * SRIOV active scheme
+                * FIXME if support DCB/RSS together with VMDq & SRIOV
+                */
+               case ETH_64_POOLS:
+                       IXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQEN);
+                       break;
+
+               case ETH_32_POOLS:
+                       IXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQRT4TCEN);
+                       break;
+               
+               case ETH_16_POOLS:
+                       IXGBE_WRITE_REG(hw, IXGBE_MRQC, IXGBE_MRQC_VMDQRT8TCEN);
+                       break;
+               default:
+                       RTE_LOG(ERR, PMD, "invalid pool number in IOV mode\n");
+               }
+       }
+
+       return 0;
+}
+
+static int
+ixgbe_dev_mq_tx_configure(struct rte_eth_dev *dev)
+{
+       struct ixgbe_hw *hw = 
+               IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint32_t mtqc;
+       uint32_t rttdcs;
+
+       if (hw->mac.type == ixgbe_mac_82598EB)
+               return 0;
+
+       /* disable arbiter before setting MTQC */
+       rttdcs = IXGBE_READ_REG(hw, IXGBE_RTTDCS);
+       rttdcs |= IXGBE_RTTDCS_ARBDIS;
+       IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs);
+
+       if (RTE_ETH_DEV_SRIOV(dev).active == 0) {
+               /* 
+                * SRIOV inactive scheme
+                * any DCB w/o VMDq multi-queue setting
+                */
+               mtqc = IXGBE_MTQC_64Q_1PB;
+       } else {
+               switch (RTE_ETH_DEV_SRIOV(dev).active) {
+
+               /*
+                * SRIOV active scheme
+                * FIXME if support DCB together with VMDq & SRIOV
+                */
+               case ETH_64_POOLS:
+                       mtqc = IXGBE_MTQC_VT_ENA | IXGBE_MTQC_64VF;
+                       break;
+               case ETH_32_POOLS:
+                       mtqc = IXGBE_MTQC_VT_ENA | IXGBE_MTQC_32VF;
+                       break;
+               case ETH_16_POOLS:
+                       mtqc = IXGBE_MTQC_VT_ENA | IXGBE_MTQC_RT_ENA | 
+                               IXGBE_MTQC_8TC_8TQ;
+                       break;
+               default:
+                       mtqc = IXGBE_MTQC_64Q_1PB;
+                       RTE_LOG(ERR, PMD, "invalid pool number in IOV mode\n");
+               }
+       }
+       
+       IXGBE_WRITE_REG(hw, IXGBE_MTQC, mtqc);
+
+       /* re-enable arbiter */
+       rttdcs &= ~IXGBE_RTTDCS_ARBDIS;
+       IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs);
+
+       return 0;
+}
+
 /*
  * Initializes Receive Unit.
  */
@@ -2296,14 +3272,14 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
 
                /* Setup the Base and Length of the Rx Descriptor Rings */
                bus_addr = rxq->rx_ring_phys_addr;
-               IXGBE_WRITE_REG(hw, IXGBE_RDBAL(i),
+               IXGBE_WRITE_REG(hw, IXGBE_RDBAL(rxq->reg_idx),
                                (uint32_t)(bus_addr & 0x00000000ffffffffULL));
-               IXGBE_WRITE_REG(hw, IXGBE_RDBAH(i),
+               IXGBE_WRITE_REG(hw, IXGBE_RDBAH(rxq->reg_idx),
                                (uint32_t)(bus_addr >> 32));
-               IXGBE_WRITE_REG(hw, IXGBE_RDLEN(i),
+               IXGBE_WRITE_REG(hw, IXGBE_RDLEN(rxq->reg_idx),
                                rxq->nb_rx_desc * sizeof(union ixgbe_adv_rx_desc));
-               IXGBE_WRITE_REG(hw, IXGBE_RDH(i), 0);
-               IXGBE_WRITE_REG(hw, IXGBE_RDT(i), 0);
+               IXGBE_WRITE_REG(hw, IXGBE_RDH(rxq->reg_idx), 0);
+               IXGBE_WRITE_REG(hw, IXGBE_RDT(rxq->reg_idx), 0);
 
                /* Configure the SRRCTL register */
 #ifdef RTE_HEADER_SPLIT_ENABLE
@@ -2318,7 +3294,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
                                        IXGBE_PSRTYPE_UDPHDR   |
                                        IXGBE_PSRTYPE_IPV4HDR  |
                                        IXGBE_PSRTYPE_IPV6HDR;
-                               IXGBE_WRITE_REG(hw, IXGBE_PSRTYPE(i), psrtype);
+                               IXGBE_WRITE_REG(hw, IXGBE_PSRTYPE(rxq->reg_idx), psrtype);
                        }
                        srrctl = ((dev->data->dev_conf.rxmode.split_hdr_size <<
                                   IXGBE_SRRCTL_BSIZEHDRSIZE_SHIFT) &
@@ -2328,6 +3304,10 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
 #endif
                        srrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;
 
+               /* Set if packets are dropped when no descriptors available */
+               if (rxq->drop_en)
+                       srrctl |= IXGBE_SRRCTL_DROP_EN;
+
                /*
                 * Configure the RX buffer size in the BSIZEPACKET field of
                 * the SRRCTL register of the queue.
@@ -2340,35 +3320,23 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
                                       RTE_PKTMBUF_HEADROOM);
                srrctl |= ((buf_size >> IXGBE_SRRCTL_BSIZEPKT_SHIFT) &
                           IXGBE_SRRCTL_BSIZEPKT_MASK);
-               IXGBE_WRITE_REG(hw, IXGBE_SRRCTL(i), srrctl);
+               IXGBE_WRITE_REG(hw, IXGBE_SRRCTL(rxq->reg_idx), srrctl);
 
                buf_size = (uint16_t) ((srrctl & IXGBE_SRRCTL_BSIZEPKT_MASK) <<
                                       IXGBE_SRRCTL_BSIZEPKT_SHIFT);
-               if (dev->data->dev_conf.rxmode.max_rx_pkt_len > buf_size){
+
+               /* It adds dual VLAN length for supporting dual VLAN */
+               if ((dev->data->dev_conf.rxmode.max_rx_pkt_len +
+                               2 * IXGBE_VLAN_TAG_SIZE) > buf_size){
                        dev->data->scattered_rx = 1;
                        dev->rx_pkt_burst = ixgbe_recv_scattered_pkts;
                }
        }
 
        /*
-        * Configure RSS if device configured with multiple RX queues.
+        * Device configured with multiple RX queues.
         */
-       if (hw->mac.type == ixgbe_mac_82599EB) {
-               if (dev->data->nb_rx_queues > 1)
-                       switch (dev->data->dev_conf.rxmode.mq_mode) {
-                               case ETH_RSS:
-                                       ixgbe_rss_configure(dev);
-                                       break;
-
-                               case ETH_VMDQ_DCB:
-                                       ixgbe_vmdq_dcb_configure(dev);
-                                       break;
-
-                               default: ixgbe_rss_disable(dev);
-                       }
-               else
-                       ixgbe_rss_disable(dev);
-       }
+       ixgbe_dev_mq_rx_configure(dev);
 
        /*
         * Setup the Checksum Register.
@@ -2408,7 +3376,6 @@ ixgbe_dev_tx_init(struct rte_eth_dev *dev)
        uint64_t bus_addr;
        uint32_t hlreg0;
        uint32_t txctrl;
-       uint32_t rttdcs;
        uint16_t i;
 
        PMD_INIT_FUNC_TRACE();
@@ -2424,15 +3391,15 @@ ixgbe_dev_tx_init(struct rte_eth_dev *dev)
                txq = dev->data->tx_queues[i];
 
                bus_addr = txq->tx_ring_phys_addr;
-               IXGBE_WRITE_REG(hw, IXGBE_TDBAL(i),
+               IXGBE_WRITE_REG(hw, IXGBE_TDBAL(txq->reg_idx),
                                (uint32_t)(bus_addr & 0x00000000ffffffffULL));
-               IXGBE_WRITE_REG(hw, IXGBE_TDBAH(i),
+               IXGBE_WRITE_REG(hw, IXGBE_TDBAH(txq->reg_idx),
                                (uint32_t)(bus_addr >> 32));
-               IXGBE_WRITE_REG(hw, IXGBE_TDLEN(i),
+               IXGBE_WRITE_REG(hw, IXGBE_TDLEN(txq->reg_idx),
                                txq->nb_tx_desc * sizeof(union ixgbe_adv_tx_desc));
                /* Setup the HW Tx Head and TX Tail descriptor pointers */
-               IXGBE_WRITE_REG(hw, IXGBE_TDH(i), 0);
-               IXGBE_WRITE_REG(hw, IXGBE_TDT(i), 0);
+               IXGBE_WRITE_REG(hw, IXGBE_TDH(txq->reg_idx), 0);
+               IXGBE_WRITE_REG(hw, IXGBE_TDT(txq->reg_idx), 0);
 
                /*
                 * Disable Tx Head Writeback RO bit, since this hoses
@@ -2441,9 +3408,9 @@ ixgbe_dev_tx_init(struct rte_eth_dev *dev)
                switch (hw->mac.type) {
                        case ixgbe_mac_82598EB:
                                txctrl = IXGBE_READ_REG(hw,
-                                                       IXGBE_DCA_TXCTRL(i));
-                               txctrl &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
-                               IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL(i),
+                                                       IXGBE_DCA_TXCTRL(txq->reg_idx));
+                               txctrl &= ~IXGBE_DCA_TXCTRL_DESC_WRO_EN;
+                               IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL(txq->reg_idx),
                                                txctrl);
                                break;
 
@@ -2451,26 +3418,16 @@ ixgbe_dev_tx_init(struct rte_eth_dev *dev)
                        case ixgbe_mac_X540:
                        default:
                                txctrl = IXGBE_READ_REG(hw,
-                                               IXGBE_DCA_TXCTRL_82599(i));
-                               txctrl &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
-                               IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(i),
+                                               IXGBE_DCA_TXCTRL_82599(txq->reg_idx));
+                               txctrl &= ~IXGBE_DCA_TXCTRL_DESC_WRO_EN;
+                               IXGBE_WRITE_REG(hw, IXGBE_DCA_TXCTRL_82599(txq->reg_idx),
                                                txctrl);
                                break;
                }
        }
 
-       if (hw->mac.type != ixgbe_mac_82598EB) {
-               /* disable arbiter before setting MTQC */
-               rttdcs = IXGBE_READ_REG(hw, IXGBE_RTTDCS);
-               rttdcs |= IXGBE_RTTDCS_ARBDIS;
-               IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs);
-
-               IXGBE_WRITE_REG(hw, IXGBE_MTQC, IXGBE_MTQC_64Q_1PB);
-
-               /* re-enable arbiter */
-               rttdcs &= ~IXGBE_RTTDCS_ARBDIS;
-               IXGBE_WRITE_REG(hw, IXGBE_RTTDCS, rttdcs);
-       }
+       /* Device configured with multiple TX queues. */
+       ixgbe_dev_mq_tx_configure(dev);
 }
 
 /*
@@ -2495,11 +3452,11 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                txq = dev->data->tx_queues[i];
                /* Setup Transmit Threshold Registers */
-               txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(i));
+               txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(txq->reg_idx));
                txdctl |= txq->pthresh & 0x7F;
                txdctl |= ((txq->hthresh & 0x7F) << 8);
                txdctl |= ((txq->wthresh & 0x7F) << 16);
-               IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(i), txdctl);
+               IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(txq->reg_idx), txdctl);
        }
 
        if (hw->mac.type != ixgbe_mac_82598EB) {
@@ -2509,16 +3466,17 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)
        }
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
-               txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(i));
+               txq = dev->data->tx_queues[i];
+               txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(txq->reg_idx));
                txdctl |= IXGBE_TXDCTL_ENABLE;
-               IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(i), txdctl);
+               IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(txq->reg_idx), txdctl);
 
                /* Wait until TX Enable ready */
                if (hw->mac.type == ixgbe_mac_82599EB) {
                        poll_ms = 10;
                        do {
                                rte_delay_ms(1);
-                               txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(i));
+                               txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(txq->reg_idx));
                        } while (--poll_ms && !(txdctl & IXGBE_TXDCTL_ENABLE));
                        if (!poll_ms)
                                PMD_INIT_LOG(ERR, "Could not enable "
@@ -2527,21 +3485,21 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)
        }
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
                rxq = dev->data->rx_queues[i];
-               rxdctl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(i));
+               rxdctl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(rxq->reg_idx));
                rxdctl |= IXGBE_RXDCTL_ENABLE;
-               IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(i), rxdctl);
+               IXGBE_WRITE_REG(hw, IXGBE_RXDCTL(rxq->reg_idx), rxdctl);
 
                /* Wait until RX Enable ready */
                poll_ms = 10;
                do {
                        rte_delay_ms(1);
-                       rxdctl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(i));
+                       rxdctl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(rxq->reg_idx));
                } while (--poll_ms && !(rxdctl & IXGBE_RXDCTL_ENABLE));
                if (!poll_ms)
                        PMD_INIT_LOG(ERR, "Could not enable "
                                     "Rx Queue %d\n", i);
                rte_wmb();
-               IXGBE_WRITE_REG(hw, IXGBE_RDT(i), rxq->nb_rx_desc - 1);
+               IXGBE_WRITE_REG(hw, IXGBE_RDT(rxq->reg_idx), rxq->nb_rx_desc - 1);
        }
 
        /* Enable Receive engine */
@@ -2578,9 +3536,9 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
 
                /* Allocate buffers for descriptor rings */
                ret = ixgbe_alloc_rx_queue_mbufs(rxq);
-               if (ret){
-                       return -1;
-               }
+               if (ret)
+                       return ret;
+
                /* Setup the Base and Length of the Rx Descriptor Rings */
                bus_addr = rxq->rx_ring_phys_addr;
 
@@ -2618,6 +3576,10 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
 #endif
                        srrctl = IXGBE_SRRCTL_DESCTYPE_ADV_ONEBUF;
 
+               /* Set if packets are dropped when no descriptors available */
+               if (rxq->drop_en)
+                       srrctl |= IXGBE_SRRCTL_DROP_EN;
+
                /*
                 * Configure the RX buffer size in the BSIZEPACKET field of
                 * the SRRCTL register of the queue.
@@ -2638,11 +3600,15 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
 
                buf_size = (uint16_t) ((srrctl & IXGBE_SRRCTL_BSIZEPKT_MASK) <<
                                       IXGBE_SRRCTL_BSIZEPKT_SHIFT);
-               if (dev->data->dev_conf.rxmode.max_rx_pkt_len > buf_size){
+
+               /* It adds dual VLAN length for supporting dual VLAN */
+               if ((dev->data->dev_conf.rxmode.max_rx_pkt_len +
+                               2 * IXGBE_VLAN_TAG_SIZE) > buf_size) {
                        dev->data->scattered_rx = 1;
                        dev->rx_pkt_burst = ixgbe_recv_scattered_pkts;
                }
        }
+
        return 0;
 }
 
@@ -2681,7 +3647,7 @@ ixgbevf_dev_tx_init(struct rte_eth_dev *dev)
                 */
                txctrl = IXGBE_READ_REG(hw,
                                IXGBE_VFDCA_TXCTRL(i));
-               txctrl &= ~IXGBE_DCA_TXCTRL_TX_WB_RO_EN;
+               txctrl &= ~IXGBE_DCA_TXCTRL_DESC_WRO_EN;
                IXGBE_WRITE_REG(hw, IXGBE_VFDCA_TXCTRL(i),
                                txctrl);
        }