add prefix to cache line macros
[dpdk.git] / lib / librte_pmd_vmxnet3 / vmxnet3_ethdev.c
index bb00816..963a8a5 100644 (file)
@@ -186,8 +186,7 @@ eth_vmxnet3_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,
                     struct rte_eth_dev *eth_dev)
 {
        struct rte_pci_device *pci_dev;
-       struct vmxnet3_hw *hw =
-               VMXNET3_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+       struct vmxnet3_hw *hw = eth_dev->data->dev_private;
        uint32_t mac_hi, mac_lo, ver;
 
        PMD_INIT_FUNC_TRACE();
@@ -217,21 +216,21 @@ eth_vmxnet3_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,
 
        /* Check h/w version compatibility with driver. */
        ver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_VRRS);
-       PMD_INIT_LOG(DEBUG, "Harware version : %d\n", ver);
+       PMD_INIT_LOG(DEBUG, "Harware version : %d", ver);
        if (ver & 0x1)
                VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS, 1);
        else {
-               PMD_INIT_LOG(ERR, "Uncompatiable h/w version, should be 0x1\n");
+               PMD_INIT_LOG(ERR, "Uncompatiable h/w version, should be 0x1");
                return -EIO;
        }
 
        /* Check UPT version compatibility with driver. */
        ver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_UVRS);
-       PMD_INIT_LOG(DEBUG, "UPT harware version : %d\n", ver);
+       PMD_INIT_LOG(DEBUG, "UPT harware version : %d", ver);
        if (ver & 0x1)
                VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_UVRS, 1);
        else {
-               PMD_INIT_LOG(ERR, "Incompatiable UPT version.\n");
+               PMD_INIT_LOG(ERR, "Incompatiable UPT version.");
                return -EIO;
        }
 
@@ -254,7 +253,7 @@ eth_vmxnet3_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,
        ether_addr_copy((struct ether_addr *) hw->perm_addr,
                        &eth_dev->data->mac_addrs[0]);
 
-       PMD_INIT_LOG(DEBUG, "MAC Address : %02x:%02x:%02x:%02x:%02x:%02x\n",
+       PMD_INIT_LOG(DEBUG, "MAC Address : %02x:%02x:%02x:%02x:%02x:%02x",
                     hw->perm_addr[0], hw->perm_addr[1], hw->perm_addr[2],
                     hw->perm_addr[3], hw->perm_addr[4], hw->perm_addr[5]);
 
@@ -271,7 +270,7 @@ static struct eth_driver rte_vmxnet3_pmd = {
                .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
        },
        .eth_dev_init = eth_vmxnet3_dev_init,
-       .dev_private_size = sizeof(struct vmxnet3_adapter),
+       .dev_private_size = sizeof(struct vmxnet3_hw),
 };
 
 /*
@@ -292,8 +291,7 @@ static int
 vmxnet3_dev_configure(struct rte_eth_dev *dev)
 {
        const struct rte_memzone *mz;
-       struct vmxnet3_hw *hw =
-               VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
        size_t size;
 
        PMD_INIT_FUNC_TRACE();
@@ -319,7 +317,7 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
                              "shared", rte_socket_id(), 8);
 
        if (mz == NULL) {
-               PMD_INIT_LOG(ERR, "ERROR: Creating shared zone\n");
+               PMD_INIT_LOG(ERR, "ERROR: Creating shared zone");
                return -ENOMEM;
        }
        memset(mz->addr, 0, mz->len);
@@ -334,7 +332,7 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
        mz = gpa_zone_reserve(dev, size, "queuedesc",
                              rte_socket_id(), VMXNET3_QUEUE_DESC_ALIGN);
        if (mz == NULL) {
-               PMD_INIT_LOG(ERR, "ERROR: Creating queue descriptors zone\n");
+               PMD_INIT_LOG(ERR, "ERROR: Creating queue descriptors zone");
                return -ENOMEM;
        }
        memset(mz->addr, 0, mz->len);
@@ -349,10 +347,10 @@ vmxnet3_dev_configure(struct rte_eth_dev *dev)
 
                /* Allocate memory structure for UPT1_RSSConf and configure */
                mz = gpa_zone_reserve(dev, sizeof(struct VMXNET3_RSSConf), "rss_conf",
-                                     rte_socket_id(), CACHE_LINE_SIZE);
+                                     rte_socket_id(), RTE_CACHE_LINE_SIZE);
                if (mz == NULL) {
                        PMD_INIT_LOG(ERR,
-                                    "ERROR: Creating rss_conf structure zone\n");
+                                    "ERROR: Creating rss_conf structure zone");
                        return -ENOMEM;
                }
                memset(mz->addr, 0, mz->len);
@@ -368,7 +366,7 @@ static int
 vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 {
        struct rte_eth_conf port_conf = dev->data->dev_conf;
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
        Vmxnet3_DriverShared *shared = hw->shared;
        Vmxnet3_DSDevRead *devRead = &shared->devRead;
        uint32_t *mac_ptr;
@@ -403,15 +401,17 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 
        for (i = 0; i < hw->num_tx_queues; i++) {
                Vmxnet3_TxQueueDesc *tqd = &hw->tqd_start[i];
-               vmxnet3_tx_queue_t *txq   = dev->data->tx_queues[i];
+               vmxnet3_tx_queue_t *txq  = dev->data->tx_queues[i];
 
                tqd->ctrl.txNumDeferred  = 0;
                tqd->ctrl.txThreshold    = 1;
                tqd->conf.txRingBasePA   = txq->cmd_ring.basePA;
                tqd->conf.compRingBasePA = txq->comp_ring.basePA;
+               tqd->conf.dataRingBasePA = txq->data_ring.basePA;
 
                tqd->conf.txRingSize   = txq->cmd_ring.size;
                tqd->conf.compRingSize = txq->comp_ring.size;
+               tqd->conf.dataRingSize = txq->data_ring.size;
                tqd->conf.intrIdx      = txq->comp_ring.intr_idx;
                tqd->status.stopped    = TRUE;
                tqd->status.error      = 0;
@@ -420,7 +420,7 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 
        for (i = 0; i < hw->num_rx_queues; i++) {
                Vmxnet3_RxQueueDesc *rqd  = &hw->rqd_start[i];
-               vmxnet3_rx_queue_t *rxq    = dev->data->rx_queues[i];
+               vmxnet3_rx_queue_t *rxq   = dev->data->rx_queues[i];
 
                rqd->conf.rxRingBasePA[0] = rxq->cmd_ring[0].basePA;
                rqd->conf.rxRingBasePA[1] = rxq->cmd_ring[1].basePA;
@@ -463,7 +463,7 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
        }
 
        PMD_INIT_LOG(DEBUG,
-                    "Writing MAC Address : %02x:%02x:%02x:%02x:%02x:%02x\n",
+                    "Writing MAC Address : %02x:%02x:%02x:%02x:%02x:%02x",
                     hw->perm_addr[0], hw->perm_addr[1], hw->perm_addr[2],
                     hw->perm_addr[3], hw->perm_addr[4], hw->perm_addr[5]);
 
@@ -487,7 +487,7 @@ static int
 vmxnet3_dev_start(struct rte_eth_dev *dev)
 {
        int status, ret;
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -506,7 +506,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
        status = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
 
        if (status != 0) {
-               PMD_INIT_LOG(ERR, "Device activation in %s(): UNSUCCESSFUL\n", __func__);
+               PMD_INIT_LOG(ERR, "Device activation in %s(): UNSUCCESSFUL", __func__);
                return -1;
        }
 
@@ -519,19 +519,19 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
         */
        ret = vmxnet3_dev_rxtx_init(dev);
        if (ret != VMXNET3_SUCCESS) {
-               PMD_INIT_LOG(ERR, "Device receive init in %s: UNSUCCESSFUL\n", __func__);
+               PMD_INIT_LOG(ERR, "Device receive init in %s: UNSUCCESSFUL", __func__);
                return ret;
        }
 
        /* Setting proper Rx Mode and issue Rx Mode Update command */
-       vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
+       vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
 
        /*
         * Don't need to handle events for now
         */
 #if PROCESS_SYS_EVENTS == 1
        events = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_ECR);
-       PMD_INIT_LOG(DEBUG, "Reading events: 0x%X\n\n", events);
+       PMD_INIT_LOG(DEBUG, "Reading events: 0x%X", events);
        vmxnet3_process_events(hw);
 #endif
        return status;
@@ -544,13 +544,12 @@ static void
 vmxnet3_dev_stop(struct rte_eth_dev *dev)
 {
        struct rte_eth_link link;
-       struct vmxnet3_hw *hw =
-               VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
 
        if (hw->adapter_stopped == TRUE) {
-               PMD_INIT_LOG(DEBUG, "Device already closed.\n");
+               PMD_INIT_LOG(DEBUG, "Device already closed.");
                return;
        }
 
@@ -564,7 +563,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
 
        /* reset the device */
        VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_RESET_DEV);
-       PMD_INIT_LOG(DEBUG, "Device reset.\n");
+       PMD_INIT_LOG(DEBUG, "Device reset.");
        hw->adapter_stopped = FALSE;
 
        vmxnet3_dev_clear_queues(dev);
@@ -580,57 +579,59 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)
 static void
 vmxnet3_dev_close(struct rte_eth_dev *dev)
 {
-       struct vmxnet3_hw *hw =
-               VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE();
 
        vmxnet3_dev_stop(dev);
        hw->adapter_stopped = TRUE;
-
 }
 
 static void
 vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
        unsigned int i;
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
 
-       stats->opackets = 0;
-       stats->obytes = 0;
-       stats->oerrors = 0;
-       stats->ipackets = 0;
-       stats->ibytes = 0;
-       stats->rx_nombuf = 0;
-       stats->ierrors = 0;
-       stats->imcasts  = 0;
-       stats->fdirmatch = 0;
-       stats->fdirmiss = 0;
-
+       RTE_BUILD_BUG_ON(RTE_ETHDEV_QUEUE_STAT_CNTRS < VMXNET3_MAX_TX_QUEUES);
        for (i = 0; i < hw->num_tx_queues; i++) {
-               stats->opackets += hw->tqd_start[i].stats.ucastPktsTxOK +
-                               hw->tqd_start[i].stats.mcastPktsTxOK +
-                               hw->tqd_start[i].stats.bcastPktsTxOK;
-               stats->obytes   += hw->tqd_start[i].stats.ucastBytesTxOK +
-                               hw->tqd_start[i].stats.mcastBytesTxOK +
-                               hw->tqd_start[i].stats.bcastBytesTxOK;
-               stats->oerrors  += hw->tqd_start[i].stats.pktsTxError +
-                               hw->tqd_start[i].stats.pktsTxDiscard;
+               struct UPT1_TxStats *txStats = &hw->tqd_start[i].stats;
+
+               stats->q_opackets[i] = txStats->ucastPktsTxOK +
+                       txStats->mcastPktsTxOK +
+                       txStats->bcastPktsTxOK;
+               stats->q_obytes[i] = txStats->ucastBytesTxOK +
+                       txStats->mcastBytesTxOK +
+                       txStats->bcastBytesTxOK;
+
+               stats->opackets += stats->q_opackets[i];
+               stats->obytes += stats->q_obytes[i];
+               stats->oerrors += txStats->pktsTxError +
+                       txStats->pktsTxDiscard;
        }
 
+       RTE_BUILD_BUG_ON(RTE_ETHDEV_QUEUE_STAT_CNTRS < VMXNET3_MAX_RX_QUEUES);
        for (i = 0; i < hw->num_rx_queues; i++) {
-               stats->ipackets  += hw->rqd_start[i].stats.ucastPktsRxOK +
-                               hw->rqd_start[i].stats.mcastPktsRxOK +
-                               hw->rqd_start[i].stats.bcastPktsRxOK;
-               stats->ibytes    += hw->rqd_start[i].stats.ucastBytesRxOK +
-                               hw->rqd_start[i].stats.mcastBytesRxOK +
-                               hw->rqd_start[i].stats.bcastBytesRxOK;
-               stats->rx_nombuf += hw->rqd_start[i].stats.pktsRxOutOfBuf;
-               stats->ierrors   += hw->rqd_start[i].stats.pktsRxError;
-       }
+               struct UPT1_RxStats *rxStats = &hw->rqd_start[i].stats;
+
+               stats->q_ipackets[i] = rxStats->ucastPktsRxOK +
+                       rxStats->mcastPktsRxOK +
+                       rxStats->bcastPktsRxOK;
 
+               stats->q_ibytes[i] = rxStats->ucastBytesRxOK +
+                       rxStats->mcastBytesRxOK +
+                       rxStats->bcastBytesRxOK;
+
+               stats->ipackets += stats->q_ipackets[i];
+               stats->ibytes += stats->q_ibytes[i];
+
+               stats->q_errors[i] = rxStats->pktsRxError;
+               stats->ierrors += rxStats->pktsRxError;
+               stats->imcasts += rxStats->mcastPktsRxOK;
+               stats->rx_nombuf += rxStats->pktsRxOutOfBuf;
+       }
 }
 
 static void
@@ -647,7 +648,7 @@ vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, struct rte_
 static int
 vmxnet3_dev_link_update(struct rte_eth_dev *dev, __attribute__((unused)) int wait_to_complete)
 {
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
        struct rte_eth_link link;
        uint32_t ret;
 
@@ -655,7 +656,7 @@ vmxnet3_dev_link_update(struct rte_eth_dev *dev, __attribute__((unused)) int wai
        ret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);
 
        if (!ret) {
-               PMD_INIT_LOG(ERR, "Link Status Negative : %s()\n", __func__);
+               PMD_INIT_LOG(ERR, "Link Status Negative : %s()", __func__);
                return -1;
        }
 
@@ -690,7 +691,7 @@ vmxnet3_dev_set_rxmode(struct vmxnet3_hw *hw, uint32_t feature, int set) {
 static void
 vmxnet3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 {
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 1);
 }
@@ -699,7 +700,7 @@ vmxnet3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 static void
 vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev)
 {
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 0);
 }
@@ -708,7 +709,7 @@ vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev)
 static void
 vmxnet3_dev_allmulticast_enable(struct rte_eth_dev *dev)
 {
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_ALL_MULTI, 1);
 }
@@ -717,7 +718,7 @@ vmxnet3_dev_allmulticast_enable(struct rte_eth_dev *dev)
 static void
 vmxnet3_dev_allmulticast_disable(struct rte_eth_dev *dev)
 {
-       struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct vmxnet3_hw *hw = dev->data->dev_private;
 
        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_ALL_MULTI, 0);
 }
@@ -729,7 +730,7 @@ vmxnet3_process_events(struct vmxnet3_hw *hw)
        uint32_t events = hw->shared->ecr;
 
        if (!events) {
-               PMD_INIT_LOG(ERR, "No events to process in %s()\n", __func__);
+               PMD_INIT_LOG(ERR, "No events to process in %s()", __func__);
                return;
        }
 
@@ -742,18 +743,18 @@ vmxnet3_process_events(struct vmxnet3_hw *hw)
        /* Check if link state has changed */
        if (events & VMXNET3_ECR_LINK)
                PMD_INIT_LOG(ERR,
-                            "Process events in %s(): VMXNET3_ECR_LINK event\n", __func__);
+                            "Process events in %s(): VMXNET3_ECR_LINK event", __func__);
 
        /* Check if there is an error on xmit/recv queues */
        if (events & (VMXNET3_ECR_TQERR | VMXNET3_ECR_RQERR)) {
                VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_QUEUE_STATUS);
 
                if (hw->tqd_start->status.stopped)
-                       PMD_INIT_LOG(ERR, "tq error 0x%x\n",
+                       PMD_INIT_LOG(ERR, "tq error 0x%x",
                                     hw->tqd_start->status.error);
 
                if (hw->rqd_start->status.stopped)
-                       PMD_INIT_LOG(ERR, "rq error 0x%x\n",
+                       PMD_INIT_LOG(ERR, "rq error 0x%x",
                                     hw->rqd_start->status.error);
 
                /* Reset the device */
@@ -761,10 +762,10 @@ vmxnet3_process_events(struct vmxnet3_hw *hw)
        }
 
        if (events & VMXNET3_ECR_DIC)
-               PMD_INIT_LOG(ERR, "Device implementation change event.\n");
+               PMD_INIT_LOG(ERR, "Device implementation change event.");
 
        if (events & VMXNET3_ECR_DEBUG)
-               PMD_INIT_LOG(ERR, "Debug event generated by device.\n");
+               PMD_INIT_LOG(ERR, "Debug event generated by device.");
 
 }
 #endif