examples/ipsec-secgw: fix IP version check
authorTomasz Duszynski <tdu@semihalf.com>
Fri, 13 Oct 2017 12:50:09 +0000 (14:50 +0200)
committerPablo de Lara <pablo.de.lara.guarch@intel.com>
Wed, 25 Oct 2017 16:10:32 +0000 (18:10 +0200)
commit3417350e7f1726d6495e0d85e2212f6d4f959e4e
tree2e93183f77916b63a8b156e47caa4bf2e5a65087
parent9b0b95a48c0e171454cfca4231cecac7d470a75c
examples/ipsec-secgw: fix IP version check

Since new_ip and ip4 are overlapping buffers copying ip4 over new_ip
using memmove() might overwrite memory at ip4. This could happen if
following condition holds:

ip_hdr_len > sizeof(struct esp_hdr) + sa->iv_len

Thus using ip4 to check ip version is wrong as it might not contain
proper value.

Fixes: f159e70b0922 ("examples/ipsec-secgw: support transport mode")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Reviewed-by: Aviad Yehezkel <aviadye@mellanox.com>
examples/ipsec-secgw/esp.c