net/ipn3ke: fix TM commit check
authorKevin Traynor <ktraynor@redhat.com>
Wed, 6 Nov 2019 19:01:58 +0000 (19:01 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 8 Nov 2019 15:40:28 +0000 (16:40 +0100)
commit841a0b7aed3d2ac738167f9eff7f2e9d6dce8bd0
treefad343c7e0a86b451c3f84ff5b7b35d09602651d
parent01c65002b7153b4a111c77854715d535c0b6e851
net/ipn3ke: fix TM commit check

Coverity is complaining about identical code regardless of which branch
of the if else is taken. Functionally it means an error will always be
returned if this if else is hit. Remove the else branch.

    CID 337928 (#1 of 1): Identical code for different branches
    (IDENTICAL_BRANCHES)identical_branches: The same code is executed
    regardless of whether n->level != IPN3KE_TM_NODE_LEVEL_COS ||
    n->n_children != 0U is true, because the 'then' and 'else' branches
    are identical. Should one of the branches be modified, or the entire
    'if' statement replaced?
1506  if (n->level != IPN3KE_TM_NODE_LEVEL_COS ||
1507          n->n_children != 0) {
1508          return -rte_tm_error_set(error,
1509                  EINVAL,
1510                  RTE_TM_ERROR_TYPE_UNSPECIFIED,
1511                  NULL,
1512                  rte_strerror(EINVAL));
    else_branch: The else branch, identical to the then branch.
1513  } else {
1514          return -rte_tm_error_set(error,
1515                  EINVAL,
1516                  RTE_TM_ERROR_TYPE_UNSPECIFIED,
1517                  NULL,
1518                  rte_strerror(EINVAL));
1519  }

Coverity issue: 337928
Fixes: c820468ac99c ("net/ipn3ke: support TM")
Cc: stable@dpdk.org
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Reviewed-by: Rosen Xu <rosen.xu@intel.com>
drivers/net/ipn3ke/ipn3ke_tm.c