vhost: enable reply-ack systematically
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Thu, 28 May 2020 09:03:47 +0000 (11:03 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 30 Jun 2020 12:52:29 +0000 (14:52 +0200)
commitd1c074bd7663b3eb009eff30aff3306d242f4a61
treee637808a7a138409a3e5538cdf1693587ba51251
parent3990ea41c403f848ce7aa3637fee58ac81b73753
vhost: enable reply-ack systematically

As announced during v20.05 release cycle, this
patch makes reply-ack protocol feature to be enabled
unconditionally.

This protocol feature makes the communication between the
master and the slave more robust, avoiding for example
possible undefined behaviour with VHOST_USER_SET_MEM_TABLE.

Also, reply-ack support will be required for upcoming
VHOST_USER_SET_STATUS request.

Note that this protocol feature was disabled by default
because Qemu version 2.7.0 to 2.9.0 had a bug causing a
deadlock when reply-ack was negotiated and multiqueue
enabled. These Qemu version are now very old and no more
maintained, so we can reasonably consider we no more
support them.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
doc/guides/prog_guide/vhost_lib.rst
lib/librte_vhost/vhost_user.c