ip_frag: remove IP checkum offload flag
authorSunil Kumar Kori <skori@marvell.com>
Mon, 8 Jul 2019 04:32:58 +0000 (10:02 +0530)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 8 Jul 2019 09:04:01 +0000 (11:04 +0200)
commite29fc44370c23e3018af3eaae476568410cd6fd0
treed3e671d54fcd244776d935ec74f69e0819873fb0
parentd32411d03466c7cdcc842acdab87dd9f1a5ce2c3
ip_frag: remove IP checkum offload flag

Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags
during fragmentation and reassemble operation implicitly.
Because of this, application is forced to use checksum offload
whether it is supported by platform or not.

Also documentation does not provide any expected value of ol_flags
in returned mbuf (reassembled or fragmented) so application will never
come to know that which offloads are enabled. So transmission may be failed
for the platforms which does not support checksum offload.

Also, IPv6 does not contain any checksum field in header so setting
mbuf->ol_flags with PKT_TX_IP_CKSUM is itself invalid.

So removing mentioned flag from the library.

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
doc/guides/rel_notes/release_19_08.rst
lib/librte_ip_frag/rte_ipv4_reassembly.c
lib/librte_ip_frag/rte_ipv6_reassembly.c