git.droids-corp.org / dpdk.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7e3389b) | patch
net/sfc/base: cope with clang warning on negative shift
authorAndrew Rybchenko <arybchenko@solarflare.com>
Wed, 25 Apr 2018 17:51:37 +0000 (18:51 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 27 Apr 2018 17:00:55 +0000 (18:00 +0100)
commiteff7d1d2dcca4a5749454d956bc317e1b4c37a18
tree7903521be54f276bf0ac57eb6d7c3bc13cae06f5tree | snapshot
parent7e3389b172375b485028b58d9ee782d6928458d8commit | diff
net/sfc/base: cope with clang warning on negative shift

clang 4.0.1-6 on Ubuntu generates false positive warning that shift
is negative.  It is done regardless of the fact that the branch is
not taken because of previous check.

The warning is generate in EFX_INSERT_NATIVE32 used by
EFX_INSERT_FIELD_NATIVE32. All similar cases are fixed as well.

It is undesirable to suppress the warning completely.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
drivers/net/sfc/base/efx_types.h diff | blob | history
DPDK repo used for reviews