2 # SPDX-License-Identifier: BSD-3-Clause
3 # Copyright 2015 6WIND S.A.
6 # - DPDK_CHECKPATCH_PATH
7 # - DPDK_CHECKPATCH_LINE_LENGTH
8 . $(dirname $(readlink -e $0))/load-devel-config
10 VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh
12 length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
14 # override default Linux options
16 options="$options --max-line-length=$length"
17 options="$options --show-types"
18 options="$options --ignore=LINUX_VERSION_CODE,\
19 FILE_PATH_CHANGES,MAINTAINERS_STYLE,SPDX_LICENSE_TAG,\
20 VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
21 PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
22 SPLIT_STRING,LONG_LINE_STRING,\
23 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
24 NEW_TYPEDEFS,COMPARISON_TO_NULL"
27 if echo $tmpinput | grep -q '^checkpatches\.' ; then
32 trap "clean_tmp_files" INT
36 usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]]
38 Run Linux kernel checkpatch.pl with DPDK options.
39 The environment variable DPDK_CHECKPATCH_PATH must be set.
41 The patches to check can be from stdin, files specified on the command line,
42 or latest git commits limited with -n option (default limit: origin/master).
46 check_forbidden_additions() { # <patch>
47 # refrain from new additions of rte_panic() and rte_exit()
48 # multiple folders and expressions are separated by spaces
49 awk -v FOLDERS="lib drivers" \
50 -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
52 -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
54 # svg figures must be included with wildcard extension
55 # because of png conversion for pdf docs
56 awk -v FOLDERS='doc' \
57 -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
59 -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
66 while getopts hn:qv ARG ; do
71 h ) print_usage ; exit 0 ;;
72 ? ) print_usage ; exit 1 ;;
75 shift $(($OPTIND - 1))
77 if [ ! -f "$DPDK_CHECKPATCH_PATH" ] || [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
80 echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
84 print_headline() { # <title>
85 printf '\n### %s\n\n' "$1"
92 check () { # <patch> <commit> <title>
94 headline_printed=false
97 ! $verbose || print_headline "$3"
100 elif [ -n "$2" ] ; then
101 tmpinput=$(mktemp -t dpdk.checkpatches.XXXXXX)
102 git format-patch --find-renames \
103 --no-stat --stdout -1 $commit > "$tmpinput"
105 tmpinput=$(mktemp -t dpdk.checkpatches.XXXXXX)
109 ! $verbose || printf 'Running checkpatch.pl:\n'
110 report=$($DPDK_CHECKPATCH_PATH $options "$tmpinput" 2>/dev/null)
111 if [ $? -ne 0 ] ; then
112 $headline_printed || print_headline "$3"
113 printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p'
117 ! $verbose || printf '\nChecking API additions/removals:\n'
118 report=$($VALIDATE_NEW_API "$tmpinput")
119 if [ $? -ne 0 ] ; then
120 $headline_printed || print_headline "$3"
121 printf '%s\n' "$report"
125 ! $verbose || printf '\nChecking forbidden tokens additions:\n'
126 report=$(check_forbidden_additions "$tmpinput")
127 if [ $? -ne 0 ] ; then
128 $headline_printed || print_headline "$3"
129 printf '%s\n' "$report"
134 [ $ret -eq 0 ] && return 0
136 status=$(($status + 1))
139 if [ -n "$1" ] ; then
140 for patch in "$@" ; do
141 # Subject can be on 2 lines
142 subject=$(sed '/^Subject: */!d;s///;N;s,\n[[:space:]]\+, ,;s,\n.*,,;q' "$patch")
143 check "$patch" '' "$subject"
145 elif [ ! -t 0 ] ; then # stdin
146 subject=$(while read header value ; do
147 if [ "$header" = 'Subject:' ] ; then
149 continuation=$(echo "$next" | sed -n 's,^[[:space:]]\+, ,p')
150 echo $value$continuation
154 check '' '' "$subject"
156 if [ $number -eq 0 ] ; then
157 commits=$(git rev-list --reverse origin/master..)
159 commits=$(git rev-list --reverse --max-count=$number HEAD)
161 for commit in $commits ; do
162 subject=$(git log --format='%s' -1 $commit)
163 check '' $commit "$subject"
166 pass=$(($total - $status))
167 $quiet || printf '\n%d/%d valid patch' $pass $total
168 $quiet || [ $pass -le 1 ] || printf 'es'
169 $quiet || printf '\n'