drivers/net/bnxt/bnxt_flow.c

   1 /* SPDX-License-Identifier: BSD-3-Clause
   2  * Copyright(c) 2014-2018 Broadcom
   3  * All rights reserved.
   4  */
   5
   6 #include <sys/queue.h>
   7
   8 #include <rte_log.h>
   9 #include <rte_malloc.h>
  10 #include <rte_flow.h>
  11 #include <rte_flow_driver.h>
  12 #include <rte_tailq.h>
  13
  14 #include "bnxt.h"
  15 #include "bnxt_filter.h"
  16 #include "bnxt_hwrm.h"
  17 #include "bnxt_ring.h"
  18 #include "bnxt_rxq.h"
  19 #include "bnxt_vnic.h"
  20 #include "hsi_struct_def_dpdk.h"
  21
  22 static int
  23 bnxt_flow_args_validate(const struct rte_flow_attr *attr,
  24                         const struct rte_flow_item pattern[],
  25                         const struct rte_flow_action actions[],
  26                         struct rte_flow_error *error)
  27 {
  28         if (!pattern) {
  29                 rte_flow_error_set(error,
  30                                    EINVAL,
  31                                    RTE_FLOW_ERROR_TYPE_ITEM_NUM,
  32                                    NULL,
  33                                    "NULL pattern.");
  34                 return -rte_errno;
  35         }
  36
  37         if (!actions) {
  38                 rte_flow_error_set(error,
  39                                    EINVAL,
  40                                    RTE_FLOW_ERROR_TYPE_ACTION_NUM,
  41                                    NULL,
  42                                    "NULL action.");
  43                 return -rte_errno;
  44         }
  45
  46         if (!attr) {
  47                 rte_flow_error_set(error,
  48                                    EINVAL,
  49                                    RTE_FLOW_ERROR_TYPE_ATTR,
  50                                    NULL,
  51                                    "NULL attribute.");
  52                 return -rte_errno;
  53         }
  54
  55         return 0;
  56 }
  57
  58 static const struct rte_flow_item *
  59 bnxt_flow_non_void_item(const struct rte_flow_item *cur)
  60 {
  61         while (1) {
  62                 if (cur->type != RTE_FLOW_ITEM_TYPE_VOID)
  63                         return cur;
  64                 cur++;
  65         }
  66 }
  67
  68 static const struct rte_flow_action *
  69 bnxt_flow_non_void_action(const struct rte_flow_action *cur)
  70 {
  71         while (1) {
  72                 if (cur->type != RTE_FLOW_ACTION_TYPE_VOID)
  73                         return cur;
  74                 cur++;
  75         }
  76 }
  77
  78 static int
  79 bnxt_filter_type_check(const struct rte_flow_item pattern[],
  80                        struct rte_flow_error *error __rte_unused)
  81 {
  82         const struct rte_flow_item *item =
  83                 bnxt_flow_non_void_item(pattern);
  84         int use_ntuple = 1;
  85         bool has_vlan = 0;
  86
  87         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
  88                 switch (item->type) {
  89                 case RTE_FLOW_ITEM_TYPE_ANY:
  90                 case RTE_FLOW_ITEM_TYPE_ETH:
  91                         use_ntuple = 0;
  92                         break;
  93                 case RTE_FLOW_ITEM_TYPE_VLAN:
  94                         use_ntuple = 0;
  95                         has_vlan = 1;
  96                         break;
  97                 case RTE_FLOW_ITEM_TYPE_IPV4:
  98                 case RTE_FLOW_ITEM_TYPE_IPV6:
  99                 case RTE_FLOW_ITEM_TYPE_TCP:
 100                 case RTE_FLOW_ITEM_TYPE_UDP:
 101                         /* FALLTHROUGH */
 102                         /* need ntuple match, reset exact match */
 103                         use_ntuple |= 1;
 104                         break;
 105                 default:
 106                         PMD_DRV_LOG(DEBUG, "Unknown Flow type\n");
 107                         use_ntuple |= 0;
 108                 }
 109                 item++;
 110         }
 111
 112         if (has_vlan && use_ntuple) {
 113                 PMD_DRV_LOG(ERR,
 114                             "VLAN flow cannot use NTUPLE filter\n");
 115                 rte_flow_error_set(error, EINVAL,
 116                                    RTE_FLOW_ERROR_TYPE_ITEM,
 117                                    item,
 118                                    "Cannot use VLAN with NTUPLE");
 119                 return -rte_errno;
 120         }
 121
 122         return use_ntuple;
 123 }
 124
 125 static int
 126 bnxt_validate_and_parse_flow_type(struct bnxt *bp,
 127                                   const struct rte_flow_attr *attr,
 128                                   const struct rte_flow_item pattern[],
 129                                   struct rte_flow_error *error,
 130                                   struct bnxt_filter_info *filter)
 131 {
 132         const struct rte_flow_item *item = bnxt_flow_non_void_item(pattern);
 133         const struct rte_flow_item_vlan *vlan_spec, *vlan_mask;
 134         const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask;
 135         const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask;
 136         const struct rte_flow_item_tcp *tcp_spec, *tcp_mask;
 137         const struct rte_flow_item_udp *udp_spec, *udp_mask;
 138         const struct rte_flow_item_eth *eth_spec, *eth_mask;
 139         const struct rte_flow_item_nvgre *nvgre_spec;
 140         const struct rte_flow_item_nvgre *nvgre_mask;
 141         const struct rte_flow_item_gre *gre_spec;
 142         const struct rte_flow_item_gre *gre_mask;
 143         const struct rte_flow_item_vxlan *vxlan_spec;
 144         const struct rte_flow_item_vxlan *vxlan_mask;
 145         uint8_t vni_mask[] = {0xFF, 0xFF, 0xFF};
 146         uint8_t tni_mask[] = {0xFF, 0xFF, 0xFF};
 147         const struct rte_flow_item_vf *vf_spec;
 148         uint32_t tenant_id_be = 0, valid_flags = 0;
 149         bool vni_masked = 0;
 150         bool tni_masked = 0;
 151         uint32_t en_ethertype;
 152         uint8_t inner = 0;
 153         uint32_t vf = 0;
 154         uint32_t en = 0;
 155         int use_ntuple;
 156         int dflt_vnic;
 157
 158         use_ntuple = bnxt_filter_type_check(pattern, error);
 159         if (use_ntuple < 0)
 160                 return use_ntuple;
 161         PMD_DRV_LOG(DEBUG, "Use NTUPLE %d\n", use_ntuple);
 162
 163         filter->filter_type = use_ntuple ?
 164                 HWRM_CFA_NTUPLE_FILTER : HWRM_CFA_EM_FILTER;
 165         en_ethertype = use_ntuple ?
 166                 NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE :
 167                 EM_FLOW_ALLOC_INPUT_EN_ETHERTYPE;
 168
 169         while (item->type != RTE_FLOW_ITEM_TYPE_END) {
 170                 if (item->last) {
 171                         /* last or range is NOT supported as match criteria */
 172                         rte_flow_error_set(error, EINVAL,
 173                                            RTE_FLOW_ERROR_TYPE_ITEM,
 174                                            item,
 175                                            "No support for range");
 176                         return -rte_errno;
 177                 }
 178
 179                 if (!item->spec || !item->mask) {
 180                         rte_flow_error_set(error, EINVAL,
 181                                            RTE_FLOW_ERROR_TYPE_ITEM,
 182                                            item,
 183                                            "spec/mask is NULL");
 184                         return -rte_errno;
 185                 }
 186
 187                 switch (item->type) {
 188                 case RTE_FLOW_ITEM_TYPE_ANY:
 189                         inner =
 190                         ((const struct rte_flow_item_any *)item->spec)->num > 3;
 191                         if (inner)
 192                                 PMD_DRV_LOG(DEBUG, "Parse inner header\n");
 193                         break;
 194                 case RTE_FLOW_ITEM_TYPE_ETH:
 195                         if (!item->spec || !item->mask)
 196                                 break;
 197
 198                         eth_spec = item->spec;
 199                         eth_mask = item->mask;
 200
 201                         /* Source MAC address mask cannot be partially set.
 202                          * Should be All 0's or all 1's.
 203                          * Destination MAC address mask must not be partially
 204                          * set. Should be all 1's or all 0's.
 205                          */
 206                         if ((!rte_is_zero_ether_addr(&eth_mask->src) &&
 207                              !rte_is_broadcast_ether_addr(&eth_mask->src)) ||
 208                             (!rte_is_zero_ether_addr(&eth_mask->dst) &&
 209                              !rte_is_broadcast_ether_addr(&eth_mask->dst))) {
 210                                 rte_flow_error_set(error,
 211                                                    EINVAL,
 212                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 213                                                    item,
 214                                                    "MAC_addr mask not valid");
 215                                 return -rte_errno;
 216                         }
 217
 218                         /* Mask is not allowed. Only exact matches are */
 219                         if (eth_mask->type &&
 220                             eth_mask->type != RTE_BE16(0xffff)) {
 221                                 rte_flow_error_set(error, EINVAL,
 222                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 223                                                    item,
 224                                                    "ethertype mask not valid");
 225                                 return -rte_errno;
 226                         }
 227
 228                         if (rte_is_broadcast_ether_addr(&eth_mask->dst)) {
 229                                 if (!rte_is_unicast_ether_addr(&eth_spec->dst)) {
 230                                         rte_flow_error_set(error,
 231                                                            EINVAL,
 232                                                            RTE_FLOW_ERROR_TYPE_ITEM,
 233                                                            item,
 234                                                            "DMAC is invalid");
 235                                         return -rte_errno;
 236                                 }
 237                                 rte_memcpy(filter->dst_macaddr,
 238                                            &eth_spec->dst, RTE_ETHER_ADDR_LEN);
 239                                 en |= use_ntuple ?
 240                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
 241                                         EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
 242                                 valid_flags |= inner ?
 243                                         BNXT_FLOW_L2_INNER_DST_VALID_FLAG :
 244                                         BNXT_FLOW_L2_DST_VALID_FLAG;
 245                                 filter->priority = attr->priority;
 246                                 PMD_DRV_LOG(DEBUG,
 247                                             "Creating a priority flow\n");
 248                         }
 249
 250                         if (rte_is_broadcast_ether_addr(&eth_mask->src)) {
 251                                 if (!rte_is_unicast_ether_addr(&eth_spec->src)) {
 252                                         rte_flow_error_set(error,
 253                                                            EINVAL,
 254                                                            RTE_FLOW_ERROR_TYPE_ITEM,
 255                                                            item,
 256                                                            "SMAC is invalid");
 257                                         return -rte_errno;
 258                                 }
 259                                 rte_memcpy(filter->src_macaddr,
 260                                            &eth_spec->src, RTE_ETHER_ADDR_LEN);
 261                                 en |= use_ntuple ?
 262                                         NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
 263                                         EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
 264                                 valid_flags |= inner ?
 265                                         BNXT_FLOW_L2_INNER_SRC_VALID_FLAG :
 266                                         BNXT_FLOW_L2_SRC_VALID_FLAG;
 267                         } /*
 268                            * else {
 269                            *  PMD_DRV_LOG(ERR, "Handle this condition\n");
 270                            * }
 271                            */
 272                         if (eth_mask->type) {
 273                                 filter->ethertype =
 274                                         rte_be_to_cpu_16(eth_spec->type);
 275                                 en |= en_ethertype;
 276                         }
 277                         if (inner)
 278                                 valid_flags |= BNXT_FLOW_PARSE_INNER_FLAG;
 279
 280                         break;
 281                 case RTE_FLOW_ITEM_TYPE_VLAN:
 282                         vlan_spec = item->spec;
 283                         vlan_mask = item->mask;
 284                         if (en & en_ethertype) {
 285                                 rte_flow_error_set(error, EINVAL,
 286                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 287                                                    item,
 288                                                    "VLAN TPID matching is not"
 289                                                    " supported");
 290                                 return -rte_errno;
 291                         }
 292                         if (vlan_mask->tci &&
 293                             vlan_mask->tci == RTE_BE16(0x0fff)) {
 294                                 /* Only the VLAN ID can be matched. */
 295                                 filter->l2_ovlan =
 296                                         rte_be_to_cpu_16(vlan_spec->tci &
 297                                                          RTE_BE16(0x0fff));
 298                                 en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
 299                         } else {
 300                                 rte_flow_error_set(error,
 301                                                    EINVAL,
 302                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 303                                                    item,
 304                                                    "VLAN mask is invalid");
 305                                 return -rte_errno;
 306                         }
 307                         if (vlan_mask->inner_type &&
 308                             vlan_mask->inner_type != RTE_BE16(0xffff)) {
 309                                 rte_flow_error_set(error, EINVAL,
 310                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 311                                                    item,
 312                                                    "inner ethertype mask not"
 313                                                    " valid");
 314                                 return -rte_errno;
 315                         }
 316                         if (vlan_mask->inner_type) {
 317                                 filter->ethertype =
 318                                         rte_be_to_cpu_16(vlan_spec->inner_type);
 319                                 en |= en_ethertype;
 320                         }
 321
 322                         break;
 323                 case RTE_FLOW_ITEM_TYPE_IPV4:
 324                         /* If mask is not involved, we could use EM filters. */
 325                         ipv4_spec = item->spec;
 326                         ipv4_mask = item->mask;
 327
 328                         if (!item->spec || !item->mask)
 329                                 break;
 330
 331                         /* Only IP DST and SRC fields are maskable. */
 332                         if (ipv4_mask->hdr.version_ihl ||
 333                             ipv4_mask->hdr.type_of_service ||
 334                             ipv4_mask->hdr.total_length ||
 335                             ipv4_mask->hdr.packet_id ||
 336                             ipv4_mask->hdr.fragment_offset ||
 337                             ipv4_mask->hdr.time_to_live ||
 338                             ipv4_mask->hdr.next_proto_id ||
 339                             ipv4_mask->hdr.hdr_checksum) {
 340                                 rte_flow_error_set(error,
 341                                                    EINVAL,
 342                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 343                                                    item,
 344                                                    "Invalid IPv4 mask.");
 345                                 return -rte_errno;
 346                         }
 347
 348                         filter->dst_ipaddr[0] = ipv4_spec->hdr.dst_addr;
 349                         filter->src_ipaddr[0] = ipv4_spec->hdr.src_addr;
 350
 351                         if (use_ntuple)
 352                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
 353                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
 354                         else
 355                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 356                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 357
 358                         if (ipv4_mask->hdr.src_addr) {
 359                                 filter->src_ipaddr_mask[0] =
 360                                         ipv4_mask->hdr.src_addr;
 361                                 en |= !use_ntuple ? 0 :
 362                                      NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 363                         }
 364
 365                         if (ipv4_mask->hdr.dst_addr) {
 366                                 filter->dst_ipaddr_mask[0] =
 367                                         ipv4_mask->hdr.dst_addr;
 368                                 en |= !use_ntuple ? 0 :
 369                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 370                         }
 371
 372                         filter->ip_addr_type = use_ntuple ?
 373                          HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 :
 374                          HWRM_CFA_EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
 375
 376                         if (ipv4_spec->hdr.next_proto_id) {
 377                                 filter->ip_protocol =
 378                                         ipv4_spec->hdr.next_proto_id;
 379                                 if (use_ntuple)
 380                                         en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
 381                                 else
 382                                         en |= EM_FLOW_ALLOC_INPUT_EN_IP_PROTO;
 383                         }
 384                         break;
 385                 case RTE_FLOW_ITEM_TYPE_IPV6:
 386                         ipv6_spec = item->spec;
 387                         ipv6_mask = item->mask;
 388
 389                         if (!item->spec || !item->mask)
 390                                 break;
 391
 392                         /* Only IP DST and SRC fields are maskable. */
 393                         if (ipv6_mask->hdr.vtc_flow ||
 394                             ipv6_mask->hdr.payload_len ||
 395                             ipv6_mask->hdr.proto ||
 396                             ipv6_mask->hdr.hop_limits) {
 397                                 rte_flow_error_set(error,
 398                                                    EINVAL,
 399                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 400                                                    item,
 401                                                    "Invalid IPv6 mask.");
 402                                 return -rte_errno;
 403                         }
 404
 405                         if (use_ntuple)
 406                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
 407                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
 408                         else
 409                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 410                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 411
 412                         rte_memcpy(filter->src_ipaddr,
 413                                    ipv6_spec->hdr.src_addr, 16);
 414                         rte_memcpy(filter->dst_ipaddr,
 415                                    ipv6_spec->hdr.dst_addr, 16);
 416
 417                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
 418                                                    16)) {
 419                                 rte_memcpy(filter->src_ipaddr_mask,
 420                                            ipv6_mask->hdr.src_addr, 16);
 421                                 en |= !use_ntuple ? 0 :
 422                                     NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 423                         }
 424
 425                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
 426                                                    16)) {
 427                                 rte_memcpy(filter->dst_ipaddr_mask,
 428                                            ipv6_mask->hdr.dst_addr, 16);
 429                                 en |= !use_ntuple ? 0 :
 430                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 431                         }
 432
 433                         filter->ip_addr_type = use_ntuple ?
 434                                 NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 :
 435                                 EM_FLOW_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
 436                         break;
 437                 case RTE_FLOW_ITEM_TYPE_TCP:
 438                         tcp_spec = item->spec;
 439                         tcp_mask = item->mask;
 440
 441                         if (!item->spec || !item->mask)
 442                                 break;
 443
 444                         /* Check TCP mask. Only DST & SRC ports are maskable */
 445                         if (tcp_mask->hdr.sent_seq ||
 446                             tcp_mask->hdr.recv_ack ||
 447                             tcp_mask->hdr.data_off ||
 448                             tcp_mask->hdr.tcp_flags ||
 449                             tcp_mask->hdr.rx_win ||
 450                             tcp_mask->hdr.cksum ||
 451                             tcp_mask->hdr.tcp_urp) {
 452                                 rte_flow_error_set(error,
 453                                                    EINVAL,
 454                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 455                                                    item,
 456                                                    "Invalid TCP mask");
 457                                 return -rte_errno;
 458                         }
 459
 460                         filter->src_port = tcp_spec->hdr.src_port;
 461                         filter->dst_port = tcp_spec->hdr.dst_port;
 462
 463                         if (use_ntuple)
 464                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
 465                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
 466                         else
 467                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
 468                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
 469
 470                         if (tcp_mask->hdr.dst_port) {
 471                                 filter->dst_port_mask = tcp_mask->hdr.dst_port;
 472                                 en |= !use_ntuple ? 0 :
 473                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
 474                         }
 475
 476                         if (tcp_mask->hdr.src_port) {
 477                                 filter->src_port_mask = tcp_mask->hdr.src_port;
 478                                 en |= !use_ntuple ? 0 :
 479                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
 480                         }
 481                         break;
 482                 case RTE_FLOW_ITEM_TYPE_UDP:
 483                         udp_spec = item->spec;
 484                         udp_mask = item->mask;
 485
 486                         if (!item->spec || !item->mask)
 487                                 break;
 488
 489                         if (udp_mask->hdr.dgram_len ||
 490                             udp_mask->hdr.dgram_cksum) {
 491                                 rte_flow_error_set(error,
 492                                                    EINVAL,
 493                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 494                                                    item,
 495                                                    "Invalid UDP mask");
 496                                 return -rte_errno;
 497                         }
 498
 499                         filter->src_port = udp_spec->hdr.src_port;
 500                         filter->dst_port = udp_spec->hdr.dst_port;
 501
 502                         if (use_ntuple)
 503                                 en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
 504                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
 505                         else
 506                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_PORT |
 507                                         EM_FLOW_ALLOC_INPUT_EN_DST_PORT;
 508
 509                         if (udp_mask->hdr.dst_port) {
 510                                 filter->dst_port_mask = udp_mask->hdr.dst_port;
 511                                 en |= !use_ntuple ? 0 :
 512                                   NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
 513                         }
 514
 515                         if (udp_mask->hdr.src_port) {
 516                                 filter->src_port_mask = udp_mask->hdr.src_port;
 517                                 en |= !use_ntuple ? 0 :
 518                                   NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
 519                         }
 520                         break;
 521                 case RTE_FLOW_ITEM_TYPE_VXLAN:
 522                         vxlan_spec = item->spec;
 523                         vxlan_mask = item->mask;
 524                         /* Check if VXLAN item is used to describe protocol.
 525                          * If yes, both spec and mask should be NULL.
 526                          * If no, both spec and mask shouldn't be NULL.
 527                          */
 528                         if ((!vxlan_spec && vxlan_mask) ||
 529                             (vxlan_spec && !vxlan_mask)) {
 530                                 rte_flow_error_set(error,
 531                                                    EINVAL,
 532                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 533                                                    item,
 534                                                    "Invalid VXLAN item");
 535                                 return -rte_errno;
 536                         }
 537
 538                         if (!vxlan_spec && !vxlan_mask) {
 539                                 filter->tunnel_type =
 540                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
 541                                 break;
 542                         }
 543
 544                         if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
 545                             vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
 546                             vxlan_spec->flags != 0x8) {
 547                                 rte_flow_error_set(error,
 548                                                    EINVAL,
 549                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 550                                                    item,
 551                                                    "Invalid VXLAN item");
 552                                 return -rte_errno;
 553                         }
 554
 555                         /* Check if VNI is masked. */
 556                         if (vxlan_spec && vxlan_mask) {
 557                                 vni_masked =
 558                                         !!memcmp(vxlan_mask->vni, vni_mask,
 559                                                  RTE_DIM(vni_mask));
 560                                 if (vni_masked) {
 561                                         rte_flow_error_set
 562                                                 (error,
 563                                                  EINVAL,
 564                                                  RTE_FLOW_ERROR_TYPE_ITEM,
 565                                                  item,
 566                                                  "Invalid VNI mask");
 567                                         return -rte_errno;
 568                                 }
 569
 570                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
 571                                            vxlan_spec->vni, 3);
 572                                 filter->vni =
 573                                         rte_be_to_cpu_32(tenant_id_be);
 574                                 filter->tunnel_type =
 575                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
 576                         }
 577                         break;
 578                 case RTE_FLOW_ITEM_TYPE_NVGRE:
 579                         nvgre_spec = item->spec;
 580                         nvgre_mask = item->mask;
 581                         /* Check if NVGRE item is used to describe protocol.
 582                          * If yes, both spec and mask should be NULL.
 583                          * If no, both spec and mask shouldn't be NULL.
 584                          */
 585                         if ((!nvgre_spec && nvgre_mask) ||
 586                             (nvgre_spec && !nvgre_mask)) {
 587                                 rte_flow_error_set(error,
 588                                                    EINVAL,
 589                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 590                                                    item,
 591                                                    "Invalid NVGRE item");
 592                                 return -rte_errno;
 593                         }
 594
 595                         if (!nvgre_spec && !nvgre_mask) {
 596                                 filter->tunnel_type =
 597                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
 598                                 break;
 599                         }
 600
 601                         if (nvgre_spec->c_k_s_rsvd0_ver != 0x2000 ||
 602                             nvgre_spec->protocol != 0x6558) {
 603                                 rte_flow_error_set(error,
 604                                                    EINVAL,
 605                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 606                                                    item,
 607                                                    "Invalid NVGRE item");
 608                                 return -rte_errno;
 609                         }
 610
 611                         if (nvgre_spec && nvgre_mask) {
 612                                 tni_masked =
 613                                         !!memcmp(nvgre_mask->tni, tni_mask,
 614                                                  RTE_DIM(tni_mask));
 615                                 if (tni_masked) {
 616                                         rte_flow_error_set
 617                                                 (error,
 618                                                  EINVAL,
 619                                                  RTE_FLOW_ERROR_TYPE_ITEM,
 620                                                  item,
 621                                                  "Invalid TNI mask");
 622                                         return -rte_errno;
 623                                 }
 624                                 rte_memcpy(((uint8_t *)&tenant_id_be + 1),
 625                                            nvgre_spec->tni, 3);
 626                                 filter->vni =
 627                                         rte_be_to_cpu_32(tenant_id_be);
 628                                 filter->tunnel_type =
 629                                  CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
 630                         }
 631                         break;
 632
 633                 case RTE_FLOW_ITEM_TYPE_GRE:
 634                         gre_spec = (const struct rte_flow_item_gre *)item->spec;
 635                         gre_mask = (const struct rte_flow_item_gre *)item->mask;
 636
 637                         /*
 638                          *Check if GRE item is used to describe protocol.
 639                          * If yes, both spec and mask should be NULL.
 640                          * If no, both spec and mask shouldn't be NULL.
 641                          */
 642                         if (!!gre_spec ^ !!gre_mask) {
 643                                 rte_flow_error_set(error, EINVAL,
 644                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 645                                                    item,
 646                                                    "Invalid GRE item");
 647                                 return -rte_errno;
 648                         }
 649
 650                         if (!gre_spec && !gre_mask) {
 651                                 filter->tunnel_type =
 652                                 CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE;
 653                                 break;
 654                         }
 655                         break;
 656
 657                 case RTE_FLOW_ITEM_TYPE_VF:
 658                         vf_spec = item->spec;
 659                         vf = vf_spec->id;
 660                         if (!BNXT_PF(bp)) {
 661                                 rte_flow_error_set(error,
 662                                                    EINVAL,
 663                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 664                                                    item,
 665                                                    "Configuring on a VF!");
 666                                 return -rte_errno;
 667                         }
 668
 669                         if (vf >= bp->pdev->max_vfs) {
 670                                 rte_flow_error_set(error,
 671                                                    EINVAL,
 672                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 673                                                    item,
 674                                                    "Incorrect VF id!");
 675                                 return -rte_errno;
 676                         }
 677
 678                         if (!attr->transfer) {
 679                                 rte_flow_error_set(error,
 680                                                    ENOTSUP,
 681                                                    RTE_FLOW_ERROR_TYPE_ITEM,
 682                                                    item,
 683                                                    "Matching VF traffic without"
 684                                                    " affecting it (transfer attribute)"
 685                                                    " is unsupported");
 686                                 return -rte_errno;
 687                         }
 688
 689                         filter->mirror_vnic_id =
 690                         dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
 691                         if (dflt_vnic < 0) {
 692                                 /* This simply indicates there's no driver
 693                                  * loaded. This is not an error.
 694                                  */
 695                                 rte_flow_error_set
 696                                         (error,
 697                                          EINVAL,
 698                                          RTE_FLOW_ERROR_TYPE_ITEM,
 699                                          item,
 700                                          "Unable to get default VNIC for VF");
 701                                 return -rte_errno;
 702                         }
 703
 704                         filter->mirror_vnic_id = dflt_vnic;
 705                         en |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
 706                         break;
 707                 default:
 708                         break;
 709                 }
 710                 item++;
 711         }
 712         filter->enables = en;
 713         filter->valid_flags = valid_flags;
 714
 715         return 0;
 716 }
 717
 718 /* Parse attributes */
 719 static int
 720 bnxt_flow_parse_attr(const struct rte_flow_attr *attr,
 721                      struct rte_flow_error *error)
 722 {
 723         /* Must be input direction */
 724         if (!attr->ingress) {
 725                 rte_flow_error_set(error,
 726                                    EINVAL,
 727                                    RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
 728                                    attr,
 729                                    "Only support ingress.");
 730                 return -rte_errno;
 731         }
 732
 733         /* Not supported */
 734         if (attr->egress) {
 735                 rte_flow_error_set(error,
 736                                    EINVAL,
 737                                    RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,
 738                                    attr,
 739                                    "No support for egress.");
 740                 return -rte_errno;
 741         }
 742
 743         return 0;
 744 }
 745
 746 static struct bnxt_filter_info *
 747 bnxt_find_matching_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
 748 {
 749         struct bnxt_filter_info *mf, *f0;
 750         struct bnxt_vnic_info *vnic0;
 751         struct rte_flow *flow;
 752         int i;
 753
 754         vnic0 = &bp->vnic_info[0];
 755         f0 = STAILQ_FIRST(&vnic0->filter);
 756
 757         /* This flow has same DST MAC as the port/l2 filter. */
 758         if (memcmp(f0->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN) == 0)
 759                 return f0;
 760
 761         for (i = bp->max_vnics - 1; i >= 0; i--) {
 762                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
 763
 764                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
 765                         continue;
 766
 767                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
 768                         mf = flow->filter;
 769
 770                         if (mf->matching_l2_fltr_ptr)
 771                                 continue;
 772
 773                         if (mf->ethertype == nf->ethertype &&
 774                             mf->l2_ovlan == nf->l2_ovlan &&
 775                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
 776                             mf->l2_ivlan == nf->l2_ivlan &&
 777                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
 778                             !memcmp(mf->src_macaddr, nf->src_macaddr,
 779                                     RTE_ETHER_ADDR_LEN) &&
 780                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
 781                                     RTE_ETHER_ADDR_LEN))
 782                                 return mf;
 783                 }
 784         }
 785         return NULL;
 786 }
 787
 788 static struct bnxt_filter_info *
 789 bnxt_create_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
 790                       struct bnxt_vnic_info *vnic)
 791 {
 792         struct bnxt_filter_info *filter1;
 793         int rc;
 794
 795         /* Alloc new L2 filter.
 796          * This flow needs MAC filter which does not match any existing
 797          * L2 filters.
 798          */
 799         filter1 = bnxt_get_unused_filter(bp);
 800         if (filter1 == NULL)
 801                 return NULL;
 802
 803         filter1->flags = HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_XDP_DISABLE;
 804         filter1->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX;
 805         if (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
 806             nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG) {
 807                 filter1->flags |=
 808                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 809                 PMD_DRV_LOG(DEBUG, "Create Outer filter\n");
 810         }
 811
 812         if (nf->filter_type == HWRM_CFA_L2_FILTER &&
 813             (nf->valid_flags & BNXT_FLOW_L2_SRC_VALID_FLAG ||
 814              nf->valid_flags & BNXT_FLOW_L2_INNER_SRC_VALID_FLAG)) {
 815                 PMD_DRV_LOG(DEBUG, "Create L2 filter for SRC MAC\n");
 816                 filter1->flags |=
 817                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_SOURCE_VALID;
 818                 memcpy(filter1->l2_addr, nf->src_macaddr, RTE_ETHER_ADDR_LEN);
 819         } else {
 820                 PMD_DRV_LOG(DEBUG, "Create L2 filter for DST MAC\n");
 821                 memcpy(filter1->l2_addr, nf->dst_macaddr, RTE_ETHER_ADDR_LEN);
 822         }
 823
 824         if (nf->priority &&
 825             (nf->valid_flags & BNXT_FLOW_L2_DST_VALID_FLAG ||
 826              nf->valid_flags & BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
 827                 /* Tell the FW where to place the filter in the table. */
 828                 if (nf->priority > 65535) {
 829                         filter1->pri_hint =
 830                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_PRI_HINT_BELOW_FILTER;
 831                         /* This will place the filter in TCAM */
 832                         filter1->l2_filter_id_hint = (uint64_t)-1;
 833                 }
 834         }
 835
 836         if (nf->valid_flags & (BNXT_FLOW_L2_DST_VALID_FLAG |
 837                                BNXT_FLOW_L2_SRC_VALID_FLAG |
 838                                BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
 839                                BNXT_FLOW_L2_INNER_DST_VALID_FLAG)) {
 840                 filter1->enables =
 841                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |
 842                         L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK;
 843                 memset(filter1->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
 844         }
 845
 846         if (nf->valid_flags & BNXT_FLOW_L2_DROP_FLAG) {
 847                 filter1->flags |=
 848                         HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_DROP;
 849                 if (nf->ethertype == RTE_ETHER_TYPE_IPV4) {
 850                         /* Num VLANs for drop filter will/should be 0.
 851                          * If the req is memset to 0, then the count will
 852                          * be automatically set to 0.
 853                          */
 854                         if (nf->valid_flags & BNXT_FLOW_PARSE_INNER_FLAG) {
 855                                 filter1->enables |=
 856                                         L2_FILTER_ALLOC_INPUT_EN_T_NUM_VLANS;
 857                         } else {
 858                                 filter1->enables |=
 859                                         L2_FILTER_ALLOC_INPUT_EN_NUM_VLANS;
 860                                 filter1->flags |=
 861                                 HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 862                         }
 863                 }
 864         }
 865
 866         rc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id,
 867                                      filter1);
 868         if (rc) {
 869                 bnxt_free_filter(bp, filter1);
 870                 return NULL;
 871         }
 872         filter1->l2_ref_cnt++;
 873         return filter1;
 874 }
 875
 876 struct bnxt_filter_info *
 877 bnxt_get_l2_filter(struct bnxt *bp, struct bnxt_filter_info *nf,
 878                    struct bnxt_vnic_info *vnic)
 879 {
 880         struct bnxt_filter_info *l2_filter = NULL;
 881
 882         l2_filter = bnxt_find_matching_l2_filter(bp, nf);
 883         if (l2_filter) {
 884                 l2_filter->l2_ref_cnt++;
 885                 nf->matching_l2_fltr_ptr = l2_filter;
 886         } else {
 887                 l2_filter = bnxt_create_l2_filter(bp, nf, vnic);
 888                 nf->matching_l2_fltr_ptr = NULL;
 889         }
 890
 891         return l2_filter;
 892 }
 893
 894 static int bnxt_vnic_prep(struct bnxt *bp, struct bnxt_vnic_info *vnic)
 895 {
 896         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
 897         uint64_t rx_offloads = dev_conf->rxmode.offloads;
 898         int rc;
 899
 900         rc = bnxt_vnic_grp_alloc(bp, vnic);
 901         if (rc)
 902                 goto ret;
 903
 904         rc = bnxt_hwrm_vnic_alloc(bp, vnic);
 905         if (rc) {
 906                 PMD_DRV_LOG(ERR, "HWRM vnic alloc failure rc: %x\n", rc);
 907                 goto ret;
 908         }
 909         bp->nr_vnics++;
 910
 911         /* RSS context is required only when there is more than one RSS ring */
 912         if (vnic->rx_queue_cnt > 1) {
 913                 rc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, 0 /* ctx_idx 0 */);
 914                 if (rc) {
 915                         PMD_DRV_LOG(ERR,
 916                                     "HWRM vnic ctx alloc failure: %x\n", rc);
 917                         goto ret;
 918                 }
 919         } else {
 920                 PMD_DRV_LOG(DEBUG, "No RSS context required\n");
 921         }
 922
 923         if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
 924                 vnic->vlan_strip = true;
 925         else
 926                 vnic->vlan_strip = false;
 927
 928         rc = bnxt_hwrm_vnic_cfg(bp, vnic);
 929         if (rc)
 930                 goto ret;
 931
 932         bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
 933
 934 ret:
 935         return rc;
 936 }
 937
 938 static int match_vnic_rss_cfg(struct bnxt *bp,
 939                               struct bnxt_vnic_info *vnic,
 940                               const struct rte_flow_action_rss *rss)
 941 {
 942         unsigned int match = 0, i;
 943
 944         if (vnic->rx_queue_cnt != rss->queue_num)
 945                 return -EINVAL;
 946
 947         for (i = 0; i < rss->queue_num; i++) {
 948                 if (!bp->rx_queues[rss->queue[i]]->vnic->rx_queue_cnt &&
 949                     !bp->rx_queues[rss->queue[i]]->rx_started)
 950                         return -EINVAL;
 951         }
 952
 953         for (i = 0; i < vnic->rx_queue_cnt; i++) {
 954                 int j;
 955
 956                 for (j = 0; j < vnic->rx_queue_cnt; j++) {
 957                         if (bp->grp_info[rss->queue[i]].fw_grp_id ==
 958                             vnic->fw_grp_ids[j])
 959                                 match++;
 960                 }
 961         }
 962
 963         if (match != vnic->rx_queue_cnt) {
 964                 PMD_DRV_LOG(ERR,
 965                             "VNIC queue count %d vs queues matched %d\n",
 966                             match, vnic->rx_queue_cnt);
 967                 return -EINVAL;
 968         }
 969
 970         return 0;
 971 }
 972
 973 static void
 974 bnxt_update_filter_flags_en(struct bnxt_filter_info *filter,
 975                             struct bnxt_filter_info *filter1,
 976                             int use_ntuple)
 977 {
 978         if (!use_ntuple &&
 979             !(filter->valid_flags &
 980               ~(BNXT_FLOW_L2_DST_VALID_FLAG |
 981                 BNXT_FLOW_L2_SRC_VALID_FLAG |
 982                 BNXT_FLOW_L2_INNER_SRC_VALID_FLAG |
 983                 BNXT_FLOW_L2_INNER_DST_VALID_FLAG |
 984                 BNXT_FLOW_L2_DROP_FLAG |
 985                 BNXT_FLOW_PARSE_INNER_FLAG))) {
 986                 filter->flags = filter1->flags;
 987                 filter->enables = filter1->enables;
 988                 filter->filter_type = HWRM_CFA_L2_FILTER;
 989                 memcpy(filter->l2_addr, filter1->l2_addr, RTE_ETHER_ADDR_LEN);
 990                 memset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);
 991                 filter->pri_hint = filter1->pri_hint;
 992                 filter->l2_filter_id_hint = filter1->l2_filter_id_hint;
 993         }
 994         filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
 995         filter->l2_ref_cnt = filter1->l2_ref_cnt;
 996         PMD_DRV_LOG(DEBUG,
 997                 "l2_filter: %p fw_l2_filter_id %" PRIx64 " l2_ref_cnt %u\n",
 998                 filter1, filter->fw_l2_filter_id, filter->l2_ref_cnt);
 999 }
1000
1001 static int
1002 bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
1003                              const struct rte_flow_item pattern[],
1004                              const struct rte_flow_action actions[],
1005                              const struct rte_flow_attr *attr,
1006                              struct rte_flow_error *error,
1007                              struct bnxt_filter_info *filter)
1008 {
1009         const struct rte_flow_action *act =
1010                 bnxt_flow_non_void_action(actions);
1011         struct bnxt *bp = dev->data->dev_private;
1012         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
1013         struct bnxt_vnic_info *vnic = NULL, *vnic0 = NULL;
1014         const struct rte_flow_action_queue *act_q;
1015         const struct rte_flow_action_vf *act_vf;
1016         struct bnxt_filter_info *filter1 = NULL;
1017         const struct rte_flow_action_rss *rss;
1018         struct bnxt_rx_queue *rxq = NULL;
1019         int dflt_vnic, vnic_id;
1020         unsigned int rss_idx;
1021         uint32_t vf = 0, i;
1022         int rc, use_ntuple;
1023
1024         rc =
1025         bnxt_validate_and_parse_flow_type(bp, attr, pattern, error, filter);
1026         if (rc != 0)
1027                 goto ret;
1028
1029         rc = bnxt_flow_parse_attr(attr, error);
1030         if (rc != 0)
1031                 goto ret;
1032
1033         /* Since we support ingress attribute only - right now. */
1034         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1035                 filter->flags = HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_PATH_RX;
1036
1037         use_ntuple = bnxt_filter_type_check(pattern, error);
1038         switch (act->type) {
1039         case RTE_FLOW_ACTION_TYPE_QUEUE:
1040                 /* Allow this flow. Redirect to a VNIC. */
1041                 act_q = (const struct rte_flow_action_queue *)act->conf;
1042                 if (!act_q->index || act_q->index >= bp->rx_nr_rings) {
1043                         rte_flow_error_set(error,
1044                                            EINVAL,
1045                                            RTE_FLOW_ERROR_TYPE_ACTION,
1046                                            act,
1047                                            "Invalid queue ID.");
1048                         rc = -rte_errno;
1049                         goto ret;
1050                 }
1051                 PMD_DRV_LOG(DEBUG, "Queue index %d\n", act_q->index);
1052
1053                 vnic_id = attr->group;
1054                 if (!vnic_id) {
1055                         PMD_DRV_LOG(DEBUG, "Group id is 0\n");
1056                         vnic_id = act_q->index;
1057                 }
1058
1059                 vnic = &bp->vnic_info[vnic_id];
1060                 if (vnic == NULL) {
1061                         rte_flow_error_set(error,
1062                                            EINVAL,
1063                                            RTE_FLOW_ERROR_TYPE_ACTION,
1064                                            act,
1065                                            "No matching VNIC found.");
1066                         rc = -rte_errno;
1067                         goto ret;
1068                 }
1069                 if (vnic->rx_queue_cnt) {
1070                         if (vnic->start_grp_id != act_q->index) {
1071                                 PMD_DRV_LOG(ERR,
1072                                             "VNIC already in use\n");
1073                                 rte_flow_error_set(error,
1074                                                    EINVAL,
1075                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1076                                                    act,
1077                                                    "VNIC already in use");
1078                                 rc = -rte_errno;
1079                                 goto ret;
1080                         }
1081                         goto use_vnic;
1082                 }
1083
1084                 rxq = bp->rx_queues[act_q->index];
1085
1086                 if (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) && rxq &&
1087                     vnic->fw_vnic_id != INVALID_HW_RING_ID)
1088                         goto use_vnic;
1089
1090                 //if (!rxq ||
1091                     //bp->vnic_info[0].fw_grp_ids[act_q->index] !=
1092                     //INVALID_HW_RING_ID ||
1093                     //!rxq->rx_deferred_start) {
1094                 if (!rxq ||
1095                     bp->vnic_info[0].fw_grp_ids[act_q->index] !=
1096                     INVALID_HW_RING_ID) {
1097                         PMD_DRV_LOG(ERR,
1098                                     "Queue invalid or used with other VNIC\n");
1099                         rte_flow_error_set(error,
1100                                            EINVAL,
1101                                            RTE_FLOW_ERROR_TYPE_ACTION,
1102                                            act,
1103                                            "Queue invalid queue or in use");
1104                         rc = -rte_errno;
1105                         goto ret;
1106                 }
1107
1108                 rxq->vnic = vnic;
1109                 rxq->rx_started = 1;
1110                 vnic->rx_queue_cnt++;
1111                 vnic->start_grp_id = act_q->index;
1112                 vnic->end_grp_id = act_q->index;
1113                 vnic->func_default = 0; //This is not a default VNIC.
1114
1115                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1116
1117                 rc = bnxt_vnic_prep(bp, vnic);
1118                 if (rc)  {
1119                         rte_flow_error_set(error,
1120                                            EINVAL,
1121                                            RTE_FLOW_ERROR_TYPE_ACTION,
1122                                            act,
1123                                            "VNIC prep fail");
1124                         rc = -rte_errno;
1125                         goto ret;
1126                 }
1127
1128                 PMD_DRV_LOG(DEBUG,
1129                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1130                             act_q->index, vnic, vnic->fw_grp_ids);
1131
1132 use_vnic:
1133                 vnic->ff_pool_idx = vnic_id;
1134                 PMD_DRV_LOG(DEBUG,
1135                             "Setting vnic ff_idx %d\n", vnic->ff_pool_idx);
1136                 filter->dst_id = vnic->fw_vnic_id;
1137                 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1138                 if (filter1 == NULL) {
1139                         rte_flow_error_set(error,
1140                                            ENOSPC,
1141                                            RTE_FLOW_ERROR_TYPE_ACTION,
1142                                            act,
1143                                            "Filter not available");
1144                         rc = -rte_errno;
1145                         goto ret;
1146                 }
1147
1148                 PMD_DRV_LOG(DEBUG, "new fltr: %p l2fltr: %p l2_ref_cnt: %d\n",
1149                             filter, filter1, filter1->l2_ref_cnt);
1150                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1151                 break;
1152         case RTE_FLOW_ACTION_TYPE_DROP:
1153                 vnic0 = &bp->vnic_info[0];
1154                 filter->dst_id = vnic0->fw_vnic_id;
1155                 filter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;
1156                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1157                 if (filter1 == NULL) {
1158                         rte_flow_error_set(error,
1159                                            ENOSPC,
1160                                            RTE_FLOW_ERROR_TYPE_ACTION,
1161                                            act,
1162                                            "Filter not available");
1163                         rc = -rte_errno;
1164                         goto ret;
1165                 }
1166
1167                 if (filter->filter_type == HWRM_CFA_EM_FILTER)
1168                         filter->flags =
1169                                 HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;
1170                 else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1171                         filter->flags =
1172                                 HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
1173
1174                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1175                 break;
1176         case RTE_FLOW_ACTION_TYPE_COUNT:
1177                 vnic0 = &bp->vnic_info[0];
1178                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1179                 if (filter1 == NULL) {
1180                         rte_flow_error_set(error,
1181                                            ENOSPC,
1182                                            RTE_FLOW_ERROR_TYPE_ACTION,
1183                                            act,
1184                                            "New filter not available");
1185                         rc = -rte_errno;
1186                         goto ret;
1187                 }
1188
1189                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1190                 filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_METER;
1191                 break;
1192         case RTE_FLOW_ACTION_TYPE_VF:
1193                 act_vf = (const struct rte_flow_action_vf *)act->conf;
1194                 vf = act_vf->id;
1195
1196                 if (filter->tunnel_type ==
1197                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN ||
1198                     filter->tunnel_type ==
1199                     CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE) {
1200                         /* If issued on a VF, ensure id is 0 and is trusted */
1201                         if (BNXT_VF(bp)) {
1202                                 if (!BNXT_VF_IS_TRUSTED(bp) || vf) {
1203                                         rte_flow_error_set(error, EINVAL,
1204                                                 RTE_FLOW_ERROR_TYPE_ACTION,
1205                                                 act,
1206                                                 "Incorrect VF");
1207                                         rc = -rte_errno;
1208                                         goto ret;
1209                                 }
1210                         }
1211
1212                         filter->enables |= filter->tunnel_type;
1213                         filter->filter_type = HWRM_CFA_TUNNEL_REDIRECT_FILTER;
1214                         goto done;
1215                 }
1216
1217                 if (vf >= bp->pdev->max_vfs) {
1218                         rte_flow_error_set(error,
1219                                            EINVAL,
1220                                            RTE_FLOW_ERROR_TYPE_ACTION,
1221                                            act,
1222                                            "Incorrect VF id!");
1223                         rc = -rte_errno;
1224                         goto ret;
1225                 }
1226
1227                 filter->mirror_vnic_id =
1228                 dflt_vnic = bnxt_hwrm_func_qcfg_vf_dflt_vnic_id(bp, vf);
1229                 if (dflt_vnic < 0) {
1230                         /* This simply indicates there's no driver loaded.
1231                          * This is not an error.
1232                          */
1233                         rte_flow_error_set(error,
1234                                            EINVAL,
1235                                            RTE_FLOW_ERROR_TYPE_ACTION,
1236                                            act,
1237                                            "Unable to get default VNIC for VF");
1238                         rc = -rte_errno;
1239                         goto ret;
1240                 }
1241
1242                 filter->mirror_vnic_id = dflt_vnic;
1243                 filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_MIRROR_VNIC_ID;
1244
1245                 vnic0 = &bp->vnic_info[0];
1246                 filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
1247                 if (filter1 == NULL) {
1248                         rte_flow_error_set(error,
1249                                            ENOSPC,
1250                                            RTE_FLOW_ERROR_TYPE_ACTION,
1251                                            act,
1252                                            "New filter not available");
1253                         rc = -rte_errno;
1254                         goto ret;
1255                 }
1256
1257                 filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
1258                 break;
1259         case RTE_FLOW_ACTION_TYPE_RSS:
1260                 rss = (const struct rte_flow_action_rss *)act->conf;
1261
1262                 vnic_id = attr->group;
1263                 if (!vnic_id) {
1264                         PMD_DRV_LOG(ERR, "Group id cannot be 0\n");
1265                         rte_flow_error_set(error,
1266                                            EINVAL,
1267                                            RTE_FLOW_ERROR_TYPE_ATTR,
1268                                            NULL,
1269                                            "Group id cannot be 0");
1270                         rc = -rte_errno;
1271                         goto ret;
1272                 }
1273
1274                 vnic = &bp->vnic_info[vnic_id];
1275                 if (vnic == NULL) {
1276                         rte_flow_error_set(error,
1277                                            EINVAL,
1278                                            RTE_FLOW_ERROR_TYPE_ACTION,
1279                                            act,
1280                                            "No matching VNIC for RSS group.");
1281                         rc = -rte_errno;
1282                         goto ret;
1283                 }
1284                 PMD_DRV_LOG(DEBUG, "VNIC found\n");
1285
1286                 /* Check if requested RSS config matches RSS config of VNIC
1287                  * only if it is not a fresh VNIC configuration.
1288                  * Otherwise the existing VNIC configuration can be used.
1289                  */
1290                 if (vnic->rx_queue_cnt) {
1291                         rc = match_vnic_rss_cfg(bp, vnic, rss);
1292                         if (rc) {
1293                                 PMD_DRV_LOG(ERR,
1294                                             "VNIC and RSS config mismatch\n");
1295                                 rte_flow_error_set(error,
1296                                                    EINVAL,
1297                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1298                                                    act,
1299                                                    "VNIC and RSS cfg mismatch");
1300                                 rc = -rte_errno;
1301                                 goto ret;
1302                         }
1303                         goto vnic_found;
1304                 }
1305
1306                 for (i = 0; i < rss->queue_num; i++) {
1307                         PMD_DRV_LOG(DEBUG, "RSS action Queue %d\n",
1308                                     rss->queue[i]);
1309
1310                         if (!rss->queue[i] ||
1311                             rss->queue[i] >= bp->rx_nr_rings ||
1312                             !bp->rx_queues[rss->queue[i]]) {
1313                                 rte_flow_error_set(error,
1314                                                    EINVAL,
1315                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1316                                                    act,
1317                                                    "Invalid queue ID for RSS");
1318                                 rc = -rte_errno;
1319                                 goto ret;
1320                         }
1321                         rxq = bp->rx_queues[rss->queue[i]];
1322
1323                         //if (bp->vnic_info[0].fw_grp_ids[rss->queue[i]] !=
1324                             //INVALID_HW_RING_ID ||
1325                             //!rxq->rx_deferred_start) {
1326                         if (bp->vnic_info[0].fw_grp_ids[rss->queue[i]] !=
1327                             INVALID_HW_RING_ID) {
1328                                 PMD_DRV_LOG(ERR,
1329                                             "queue active with other VNIC\n");
1330                                 rte_flow_error_set(error,
1331                                                    EINVAL,
1332                                                    RTE_FLOW_ERROR_TYPE_ACTION,
1333                                                    act,
1334                                                    "Invalid queue ID for RSS");
1335                                 rc = -rte_errno;
1336                                 goto ret;
1337                         }
1338
1339                         rxq->vnic = vnic;
1340                         rxq->rx_started = 1;
1341                         vnic->rx_queue_cnt++;
1342                 }
1343
1344                 vnic->start_grp_id = rss->queue[0];
1345                 vnic->end_grp_id = rss->queue[rss->queue_num - 1];
1346                 vnic->func_default = 0; //This is not a default VNIC.
1347
1348                 rc = bnxt_vnic_prep(bp, vnic);
1349                 if (rc) {
1350                         rte_flow_error_set(error,
1351                                            EINVAL,
1352                                            RTE_FLOW_ERROR_TYPE_ACTION,
1353                                            act,
1354                                            "VNIC prep fail");
1355                         rc = -rte_errno;
1356                         goto ret;
1357                 }
1358
1359                 PMD_DRV_LOG(DEBUG,
1360                             "vnic[%d] = %p vnic->fw_grp_ids = %p\n",
1361                             vnic_id, vnic, vnic->fw_grp_ids);
1362
1363                 vnic->ff_pool_idx = vnic_id;
1364                 PMD_DRV_LOG(DEBUG,
1365                             "Setting vnic ff_pool_idx %d\n", vnic->ff_pool_idx);
1366
1367                 /* This can be done only after vnic_grp_alloc is done. */
1368                 for (i = 0; i < vnic->rx_queue_cnt; i++) {
1369                         vnic->fw_grp_ids[i] =
1370                                 bp->grp_info[rss->queue[i]].fw_grp_id;
1371                         /* Make sure vnic0 does not use these rings. */
1372                         bp->vnic_info[0].fw_grp_ids[rss->queue[i]] =
1373                                 INVALID_HW_RING_ID;
1374                 }
1375
1376                 for (rss_idx = 0; rss_idx < HW_HASH_INDEX_SIZE; ) {
1377                         for (i = 0; i < vnic->rx_queue_cnt; i++)
1378                                 vnic->rss_table[rss_idx++] =
1379                                         vnic->fw_grp_ids[i];
1380                 }
1381
1382                 /* Configure RSS only if the queue count is > 1 */
1383                 if (vnic->rx_queue_cnt > 1) {
1384                         vnic->hash_type =
1385                                 bnxt_rte_to_hwrm_hash_types(rss->types);
1386
1387                         if (!rss->key_len) {
1388                                 /* If hash key has not been specified,
1389                                  * use random hash key.
1390                                  */
1391                                 prandom_bytes(vnic->rss_hash_key,
1392                                               HW_HASH_KEY_SIZE);
1393                         } else {
1394                                 if (rss->key_len > HW_HASH_KEY_SIZE)
1395                                         memcpy(vnic->rss_hash_key,
1396                                                rss->key,
1397                                                HW_HASH_KEY_SIZE);
1398                                 else
1399                                         memcpy(vnic->rss_hash_key,
1400                                                rss->key,
1401                                                rss->key_len);
1402                         }
1403                         bnxt_hwrm_vnic_rss_cfg(bp, vnic);
1404                 } else {
1405                         PMD_DRV_LOG(DEBUG, "No RSS config required\n");
1406                 }
1407
1408 vnic_found:
1409                 filter->dst_id = vnic->fw_vnic_id;
1410                 filter1 = bnxt_get_l2_filter(bp, filter, vnic);
1411                 if (filter1 == NULL) {
1412                         rte_flow_error_set(error,
1413                                            ENOSPC,
1414                                            RTE_FLOW_ERROR_TYPE_ACTION,
1415                                            act,
1416                                            "New filter not available");
1417                         rc = -rte_errno;
1418                         goto ret;
1419                 }
1420
1421                 PMD_DRV_LOG(DEBUG, "L2 filter created\n");
1422                 bnxt_update_filter_flags_en(filter, filter1, use_ntuple);
1423                 break;
1424         default:
1425                 rte_flow_error_set(error,
1426                                    EINVAL,
1427                                    RTE_FLOW_ERROR_TYPE_ACTION,
1428                                    act,
1429                                    "Invalid action.");
1430                 rc = -rte_errno;
1431                 goto ret;
1432         }
1433
1434         if (filter1 && !filter->matching_l2_fltr_ptr) {
1435                 bnxt_free_filter(bp, filter1);
1436                 filter1->fw_l2_filter_id = -1;
1437         }
1438
1439 done:
1440         act = bnxt_flow_non_void_action(++act);
1441         if (act->type != RTE_FLOW_ACTION_TYPE_END) {
1442                 rte_flow_error_set(error,
1443                                    EINVAL,
1444                                    RTE_FLOW_ERROR_TYPE_ACTION,
1445                                    act,
1446                                    "Invalid action.");
1447                 rc = -rte_errno;
1448                 goto ret;
1449         }
1450
1451         return rc;
1452 ret:
1453
1454         //TODO: Cleanup according to ACTION TYPE.
1455         if (rte_errno)  {
1456                 if (vnic && STAILQ_EMPTY(&vnic->filter))
1457                         vnic->rx_queue_cnt = 0;
1458
1459                 if (rxq && !vnic->rx_queue_cnt)
1460                         rxq->vnic = &bp->vnic_info[0];
1461         }
1462         return rc;
1463 }
1464
1465 static
1466 struct bnxt_vnic_info *find_matching_vnic(struct bnxt *bp,
1467                                           struct bnxt_filter_info *filter)
1468 {
1469         struct bnxt_vnic_info *vnic = NULL;
1470         unsigned int i;
1471
1472         for (i = 0; i < bp->max_vnics; i++) {
1473                 vnic = &bp->vnic_info[i];
1474                 if (vnic->fw_vnic_id != INVALID_VNIC_ID &&
1475                     filter->dst_id == vnic->fw_vnic_id) {
1476                         PMD_DRV_LOG(DEBUG, "Found matching VNIC Id %d\n",
1477                                     vnic->ff_pool_idx);
1478                         return vnic;
1479                 }
1480         }
1481         return NULL;
1482 }
1483
1484 static int
1485 bnxt_flow_validate(struct rte_eth_dev *dev,
1486                    const struct rte_flow_attr *attr,
1487                    const struct rte_flow_item pattern[],
1488                    const struct rte_flow_action actions[],
1489                    struct rte_flow_error *error)
1490 {
1491         struct bnxt *bp = dev->data->dev_private;
1492         struct bnxt_vnic_info *vnic = NULL;
1493         struct bnxt_filter_info *filter;
1494         int ret = 0;
1495
1496         bnxt_acquire_flow_lock(bp);
1497         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1498         if (ret != 0) {
1499                 bnxt_release_flow_lock(bp);
1500                 return ret;
1501         }
1502
1503         filter = bnxt_get_unused_filter(bp);
1504         if (filter == NULL) {
1505                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1506                 bnxt_release_flow_lock(bp);
1507                 return -ENOMEM;
1508         }
1509
1510         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1511                                            error, filter);
1512         if (ret)
1513                 goto exit;
1514
1515         vnic = find_matching_vnic(bp, filter);
1516         if (vnic) {
1517                 if (STAILQ_EMPTY(&vnic->filter)) {
1518                         rte_free(vnic->fw_grp_ids);
1519                         bnxt_hwrm_vnic_ctx_free(bp, vnic);
1520                         bnxt_hwrm_vnic_free(bp, vnic);
1521                         vnic->rx_queue_cnt = 0;
1522                         PMD_DRV_LOG(DEBUG, "Free VNIC\n");
1523                 }
1524         }
1525
1526         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1527                 bnxt_hwrm_clear_em_filter(bp, filter);
1528         else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1529                 bnxt_hwrm_clear_ntuple_filter(bp, filter);
1530         else
1531                 bnxt_hwrm_clear_l2_filter(bp, filter);
1532
1533 exit:
1534         /* No need to hold on to this filter if we are just validating flow */
1535         filter->fw_l2_filter_id = UINT64_MAX;
1536         bnxt_free_filter(bp, filter);
1537         bnxt_release_flow_lock(bp);
1538
1539         return ret;
1540 }
1541
1542 static void
1543 bnxt_update_filter(struct bnxt *bp, struct bnxt_filter_info *old_filter,
1544                    struct bnxt_filter_info *new_filter)
1545 {
1546         /* Clear the new L2 filter that was created in the previous step in
1547          * bnxt_validate_and_parse_flow. For L2 filters, we will use the new
1548          * filter which points to the new destination queue and so we clear
1549          * the previous L2 filter. For ntuple filters, we are going to reuse
1550          * the old L2 filter and create new NTUPLE filter with this new
1551          * destination queue subsequently during bnxt_flow_create.
1552          */
1553         if (new_filter->filter_type == HWRM_CFA_L2_FILTER) {
1554                 bnxt_hwrm_clear_l2_filter(bp, old_filter);
1555                 bnxt_hwrm_set_l2_filter(bp, new_filter->dst_id, new_filter);
1556         } else {
1557                 if (new_filter->filter_type == HWRM_CFA_EM_FILTER)
1558                         bnxt_hwrm_clear_em_filter(bp, old_filter);
1559                 if (new_filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1560                         bnxt_hwrm_clear_ntuple_filter(bp, old_filter);
1561         }
1562 }
1563
1564 static int
1565 bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_info *nf)
1566 {
1567         struct bnxt_filter_info *mf;
1568         struct rte_flow *flow;
1569         int i;
1570
1571         for (i = bp->max_vnics - 1; i >= 0; i--) {
1572                 struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
1573
1574                 if (vnic->fw_vnic_id == INVALID_VNIC_ID)
1575                         continue;
1576
1577                 STAILQ_FOREACH(flow, &vnic->flow_list, next) {
1578                         mf = flow->filter;
1579
1580                         if (mf->filter_type == nf->filter_type &&
1581                             mf->flags == nf->flags &&
1582                             mf->src_port == nf->src_port &&
1583                             mf->src_port_mask == nf->src_port_mask &&
1584                             mf->dst_port == nf->dst_port &&
1585                             mf->dst_port_mask == nf->dst_port_mask &&
1586                             mf->ip_protocol == nf->ip_protocol &&
1587                             mf->ip_addr_type == nf->ip_addr_type &&
1588                             mf->ethertype == nf->ethertype &&
1589                             mf->vni == nf->vni &&
1590                             mf->tunnel_type == nf->tunnel_type &&
1591                             mf->l2_ovlan == nf->l2_ovlan &&
1592                             mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
1593                             mf->l2_ivlan == nf->l2_ivlan &&
1594                             mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
1595                             !memcmp(mf->l2_addr, nf->l2_addr,
1596                                     RTE_ETHER_ADDR_LEN) &&
1597                             !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
1598                                     RTE_ETHER_ADDR_LEN) &&
1599                             !memcmp(mf->src_macaddr, nf->src_macaddr,
1600                                     RTE_ETHER_ADDR_LEN) &&
1601                             !memcmp(mf->dst_macaddr, nf->dst_macaddr,
1602                                     RTE_ETHER_ADDR_LEN) &&
1603                             !memcmp(mf->src_ipaddr, nf->src_ipaddr,
1604                                     sizeof(nf->src_ipaddr)) &&
1605                             !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
1606                                     sizeof(nf->src_ipaddr_mask)) &&
1607                             !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
1608                                     sizeof(nf->dst_ipaddr)) &&
1609                             !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
1610                                     sizeof(nf->dst_ipaddr_mask))) {
1611                                 if (mf->dst_id == nf->dst_id)
1612                                         return -EEXIST;
1613                                 /* Free the old filter, update flow
1614                                  * with new filter
1615                                  */
1616                                 bnxt_update_filter(bp, mf, nf);
1617                                 STAILQ_REMOVE(&vnic->filter, mf,
1618                                               bnxt_filter_info, next);
1619                                 STAILQ_INSERT_TAIL(&vnic->filter, nf, next);
1620                                 bnxt_free_filter(bp, mf);
1621                                 flow->filter = nf;
1622                                 return -EXDEV;
1623                         }
1624                 }
1625         }
1626         return 0;
1627 }
1628
1629 static struct rte_flow *
1630 bnxt_flow_create(struct rte_eth_dev *dev,
1631                  const struct rte_flow_attr *attr,
1632                  const struct rte_flow_item pattern[],
1633                  const struct rte_flow_action actions[],
1634                  struct rte_flow_error *error)
1635 {
1636         struct bnxt *bp = dev->data->dev_private;
1637         struct bnxt_vnic_info *vnic = NULL;
1638         struct bnxt_filter_info *filter;
1639         bool update_flow = false;
1640         struct rte_flow *flow;
1641         int ret = 0;
1642         uint32_t tun_type;
1643
1644         if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
1645                 rte_flow_error_set(error, EINVAL,
1646                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1647                                    "Failed to create flow, Not a Trusted VF!");
1648                 return NULL;
1649         }
1650
1651         if (!dev->data->dev_started) {
1652                 rte_flow_error_set(error,
1653                                    EINVAL,
1654                                    RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
1655                                    NULL,
1656                                    "Device must be started");
1657                 return NULL;
1658         }
1659
1660         flow = rte_zmalloc("bnxt_flow", sizeof(struct rte_flow), 0);
1661         if (!flow) {
1662                 rte_flow_error_set(error, ENOMEM,
1663                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1664                                    "Failed to allocate memory");
1665                 return flow;
1666         }
1667
1668         bnxt_acquire_flow_lock(bp);
1669         ret = bnxt_flow_args_validate(attr, pattern, actions, error);
1670         if (ret != 0) {
1671                 PMD_DRV_LOG(ERR, "Not a validate flow.\n");
1672                 goto free_flow;
1673         }
1674
1675         filter = bnxt_get_unused_filter(bp);
1676         if (filter == NULL) {
1677                 PMD_DRV_LOG(ERR, "Not enough resources for a new flow.\n");
1678                 goto free_flow;
1679         }
1680
1681         ret = bnxt_validate_and_parse_flow(dev, pattern, actions, attr,
1682                                            error, filter);
1683         if (ret != 0)
1684                 goto free_filter;
1685
1686         ret = bnxt_match_filter(bp, filter);
1687         if (ret == -EEXIST) {
1688                 PMD_DRV_LOG(DEBUG, "Flow already exists.\n");
1689                 /* Clear the filter that was created as part of
1690                  * validate_and_parse_flow() above
1691                  */
1692                 bnxt_hwrm_clear_l2_filter(bp, filter);
1693                 goto free_filter;
1694         } else if (ret == -EXDEV) {
1695                 PMD_DRV_LOG(DEBUG, "Flow with same pattern exists\n");
1696                 PMD_DRV_LOG(DEBUG, "Updating with different destination\n");
1697                 update_flow = true;
1698         }
1699
1700         /* If tunnel redirection to a VF/PF is specified then only tunnel_type
1701          * is set and enable is set to the tunnel type. Issue hwrm cmd directly
1702          * in such a case.
1703          */
1704         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1705             filter->enables == filter->tunnel_type) {
1706                 ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1707                 if (ret) {
1708                         rte_flow_error_set(error, -ret,
1709                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1710                                            "Unable to query tunnel to VF");
1711                         goto free_filter;
1712                 }
1713                 if (tun_type == (1U << filter->tunnel_type)) {
1714                         ret =
1715                         bnxt_hwrm_tunnel_redirect_free(bp,
1716                                                        filter->tunnel_type);
1717                         if (ret) {
1718                                 PMD_DRV_LOG(ERR,
1719                                             "Unable to free existing tunnel\n");
1720                                 rte_flow_error_set(error, -ret,
1721                                                    RTE_FLOW_ERROR_TYPE_HANDLE,
1722                                                    NULL,
1723                                                    "Unable to free preexisting "
1724                                                    "tunnel on VF");
1725                                 goto free_filter;
1726                         }
1727                 }
1728                 ret = bnxt_hwrm_tunnel_redirect(bp, filter->tunnel_type);
1729                 if (ret) {
1730                         rte_flow_error_set(error, -ret,
1731                                            RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1732                                            "Unable to redirect tunnel to VF");
1733                         goto free_filter;
1734                 }
1735                 vnic = &bp->vnic_info[0];
1736                 goto done;
1737         }
1738
1739         if (filter->filter_type == HWRM_CFA_EM_FILTER) {
1740                 filter->enables |=
1741                         HWRM_CFA_EM_FLOW_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1742                 ret = bnxt_hwrm_set_em_filter(bp, filter->dst_id, filter);
1743         }
1744
1745         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER) {
1746                 filter->enables |=
1747                         HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
1748                 ret = bnxt_hwrm_set_ntuple_filter(bp, filter->dst_id, filter);
1749         }
1750
1751         vnic = find_matching_vnic(bp, filter);
1752 done:
1753         if (!ret || update_flow) {
1754                 flow->filter = filter;
1755                 flow->vnic = vnic;
1756                 if (update_flow) {
1757                         ret = -EXDEV;
1758                         goto free_flow;
1759                 }
1760
1761                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
1762                 PMD_DRV_LOG(ERR, "Successfully created flow.\n");
1763                 STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
1764                 bnxt_release_flow_lock(bp);
1765                 return flow;
1766         }
1767
1768 free_filter:
1769         bnxt_free_filter(bp, filter);
1770 free_flow:
1771         if (ret == -EEXIST)
1772                 rte_flow_error_set(error, ret,
1773                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1774                                    "Matching Flow exists.");
1775         else if (ret == -EXDEV)
1776                 rte_flow_error_set(error, 0,
1777                                    RTE_FLOW_ERROR_TYPE_NONE, NULL,
1778                                    "Flow with pattern exists, updating destination queue");
1779         else
1780                 rte_flow_error_set(error, -ret,
1781                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1782                                    "Failed to create flow.");
1783         rte_free(flow);
1784         flow = NULL;
1785         bnxt_release_flow_lock(bp);
1786         return flow;
1787 }
1788
1789 static int bnxt_handle_tunnel_redirect_destroy(struct bnxt *bp,
1790                                                struct bnxt_filter_info *filter,
1791                                                struct rte_flow_error *error)
1792 {
1793         uint16_t tun_dst_fid;
1794         uint32_t tun_type;
1795         int ret = 0;
1796
1797         ret = bnxt_hwrm_tunnel_redirect_query(bp, &tun_type);
1798         if (ret) {
1799                 rte_flow_error_set(error, -ret,
1800                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1801                                    "Unable to query tunnel to VF");
1802                 return ret;
1803         }
1804         if (tun_type == (1U << filter->tunnel_type)) {
1805                 ret = bnxt_hwrm_tunnel_redirect_info(bp, filter->tunnel_type,
1806                                                      &tun_dst_fid);
1807                 if (ret) {
1808                         rte_flow_error_set(error, -ret,
1809                                            RTE_FLOW_ERROR_TYPE_HANDLE,
1810                                            NULL,
1811                                            "tunnel_redirect info cmd fail");
1812                         return ret;
1813                 }
1814                 PMD_DRV_LOG(INFO, "Pre-existing tunnel fid = %x vf->fid = %x\n",
1815                             tun_dst_fid + bp->first_vf_id, bp->fw_fid);
1816
1817                 /* Tunnel doesn't belong to this VF, so don't send HWRM
1818                  * cmd, just delete the flow from driver
1819                  */
1820                 if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id))
1821                         PMD_DRV_LOG(ERR,
1822                                     "Tunnel does not belong to this VF, skip hwrm_tunnel_redirect_free\n");
1823                 else
1824                         ret = bnxt_hwrm_tunnel_redirect_free(bp,
1825                                                         filter->tunnel_type);
1826         }
1827         return ret;
1828 }
1829
1830 static int
1831 bnxt_flow_destroy(struct rte_eth_dev *dev,
1832                   struct rte_flow *flow,
1833                   struct rte_flow_error *error)
1834 {
1835         struct bnxt *bp = dev->data->dev_private;
1836         struct bnxt_filter_info *filter;
1837         struct bnxt_vnic_info *vnic;
1838         int ret = 0;
1839
1840         bnxt_acquire_flow_lock(bp);
1841         if (!flow) {
1842                 rte_flow_error_set(error, EINVAL,
1843                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1844                                    "Invalid flow: failed to destroy flow.");
1845                 bnxt_release_flow_lock(bp);
1846                 return -EINVAL;
1847         }
1848
1849         filter = flow->filter;
1850         vnic = flow->vnic;
1851
1852         if (!filter) {
1853                 rte_flow_error_set(error, EINVAL,
1854                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1855                                    "Invalid flow: failed to destroy flow.");
1856                 bnxt_release_flow_lock(bp);
1857                 return -EINVAL;
1858         }
1859
1860         if (filter->filter_type == HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1861             filter->enables == filter->tunnel_type) {
1862                 ret = bnxt_handle_tunnel_redirect_destroy(bp,
1863                                                           filter,
1864                                                           error);
1865                 if (!ret) {
1866                         goto done;
1867                 } else {
1868                         bnxt_release_flow_lock(bp);
1869                         return ret;
1870                 }
1871         }
1872
1873         ret = bnxt_match_filter(bp, filter);
1874         if (ret == 0)
1875                 PMD_DRV_LOG(ERR, "Could not find matching flow\n");
1876
1877         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1878                 ret = bnxt_hwrm_clear_em_filter(bp, filter);
1879         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1880                 ret = bnxt_hwrm_clear_ntuple_filter(bp, filter);
1881         ret = bnxt_hwrm_clear_l2_filter(bp, filter);
1882
1883 done:
1884         if (!ret) {
1885                 /* If it is a L2 drop filter, when the filter is created,
1886                  * the FW updates the BC/MC records.
1887                  * Once this filter is removed, issue the set_rx_mask command
1888                  * to reset the BC/MC records in the HW to the settings
1889                  * before the drop counter is created.
1890                  */
1891                 if (filter->valid_flags & BNXT_FLOW_L2_DROP_FLAG)
1892                         bnxt_set_rx_mask_no_vlan(bp, &bp->vnic_info[0]);
1893
1894                 STAILQ_REMOVE(&vnic->filter, filter, bnxt_filter_info, next);
1895                 bnxt_free_filter(bp, filter);
1896                 STAILQ_REMOVE(&vnic->flow_list, flow, rte_flow, next);
1897                 rte_free(flow);
1898
1899                 /* If this was the last flow associated with this vnic,
1900                  * switch the queue back to RSS pool.
1901                  */
1902                 if (vnic && !vnic->func_default &&
1903                     STAILQ_EMPTY(&vnic->flow_list)) {
1904                         rte_free(vnic->fw_grp_ids);
1905                         if (vnic->rx_queue_cnt > 1)
1906                                 bnxt_hwrm_vnic_ctx_free(bp, vnic);
1907
1908                         bnxt_hwrm_vnic_free(bp, vnic);
1909                         vnic->rx_queue_cnt = 0;
1910                 }
1911         } else {
1912                 rte_flow_error_set(error, -ret,
1913                                    RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
1914                                    "Failed to destroy flow.");
1915         }
1916
1917         bnxt_release_flow_lock(bp);
1918         return ret;
1919 }
1920
1921 static int
1922 bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
1923 {
1924         struct bnxt *bp = dev->data->dev_private;
1925         struct bnxt_filter_info *filter = NULL;
1926         struct bnxt_vnic_info *vnic;
1927         struct rte_flow *flow;
1928         unsigned int i;
1929         int ret = 0;
1930
1931         bnxt_acquire_flow_lock(bp);
1932         for (i = 0; i < bp->max_vnics; i++) {
1933                 vnic = &bp->vnic_info[i];
1934                 if (vnic && vnic->fw_vnic_id == INVALID_VNIC_ID)
1935                         continue;
1936
1937                 while (!STAILQ_EMPTY(&vnic->flow_list)) {
1938                         flow = STAILQ_FIRST(&vnic->flow_list);
1939                         filter = flow->filter;
1940
1941                         if (filter->filter_type ==
1942                             HWRM_CFA_TUNNEL_REDIRECT_FILTER &&
1943                             filter->enables == filter->tunnel_type) {
1944                                 ret =
1945                                 bnxt_handle_tunnel_redirect_destroy(bp,
1946                                                                     filter,
1947                                                                     error);
1948                                 if (!ret) {
1949                                         goto done;
1950                                 } else {
1951                                         bnxt_release_flow_lock(bp);
1952                                         return ret;
1953                                 }
1954                         }
1955
1956                         if (filter->filter_type == HWRM_CFA_EM_FILTER)
1957                                 ret = bnxt_hwrm_clear_em_filter(bp, filter);
1958                         if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
1959                                 ret = bnxt_hwrm_clear_ntuple_filter(bp, filter);
1960                         else if (i)
1961                                 ret = bnxt_hwrm_clear_l2_filter(bp, filter);
1962
1963                         if (ret) {
1964                                 rte_flow_error_set
1965                                         (error,
1966                                          -ret,
1967                                          RTE_FLOW_ERROR_TYPE_HANDLE,
1968                                          NULL,
1969                                          "Failed to flush flow in HW.");
1970                                 bnxt_release_flow_lock(bp);
1971                                 return -rte_errno;
1972                         }
1973 done:
1974                         STAILQ_REMOVE(&vnic->flow_list, flow,
1975                                       rte_flow, next);
1976
1977                         STAILQ_REMOVE(&vnic->filter,
1978                                       filter,
1979                                       bnxt_filter_info,
1980                                       next);
1981                         bnxt_free_filter(bp, filter);
1982
1983                         rte_free(flow);
1984
1985                         /* If this was the last flow associated with this vnic,
1986                          * switch the queue back to RSS pool.
1987                          */
1988                         if (STAILQ_EMPTY(&vnic->flow_list)) {
1989                                 rte_free(vnic->fw_grp_ids);
1990                                 if (vnic->rx_queue_cnt > 1)
1991                                         bnxt_hwrm_vnic_ctx_free(bp, vnic);
1992                                 bnxt_hwrm_vnic_free(bp, vnic);
1993                                 vnic->rx_queue_cnt = 0;
1994                         }
1995                 }
1996         }
1997
1998         bnxt_release_flow_lock(bp);
1999         return ret;
2000 }
2001
2002 const struct rte_flow_ops bnxt_flow_ops = {
2003         .validate = bnxt_flow_validate,
2004         .create = bnxt_flow_create,
2005         .destroy = bnxt_flow_destroy,
2006         .flush = bnxt_flow_flush,
2007 };